gint offset = 0;
gint context_length;
guint8 port_number;
- guint8 variant;
gint protocol_start;
gint protocol_length;
gint timestamp_start;
gint timestamp_length;
+ gint variant_start;
+ gint variant_length;
guint8 direction;
tvbuff_t *next_tvb;
int encap;
offset += protocol_length;
/* Variant */
- variant = tvb_get_guint8(tvb, offset);
+ variant_start = offset;
+ variant_length = tvb_strsize(tvb, offset);
proto_tree_add_item(dct2000_tree, hf_catapult_dct2000_variant, tvb,
- offset, 1, FALSE);
- offset++;
+ offset, variant_length, FALSE);
+ offset += variant_length;
/* Direction */
direction = tvb_get_guint8(tvb, offset);
proto_item_set_len(dct2000_tree, offset);
/* Add useful details to protocol tree label */
- proto_item_append_text(ti, " context=%s.%u t=%s %c prot=%s (v=%d)",
+ proto_item_append_text(ti, " context=%s.%u t=%s %c prot=%s (v=%s)",
tvb_get_ephemeral_string(tvb, 0, context_length),
port_number,
tvb_get_ephemeral_string(tvb, timestamp_start, timestamp_length),
(direction == 0) ? 'S' : 'R',
tvb_get_ephemeral_string(tvb, protocol_start, protocol_length),
- variant);
+ tvb_get_ephemeral_string(tvb, variant_start, variant_length));
/* Note that the first item of pinfo->pseudo_header->dct2000 will contain
if (check_col(pinfo->cinfo, COL_INFO))
{
col_add_fstr(pinfo->cinfo, COL_INFO,
- "Unparsed protocol data (context=%s.%u t=%s %c prot=%s (v=%d))",
+ "Unparsed protocol data (context=%s.%u t=%s %c prot=%s (v=%s))",
tvb_get_ephemeral_string(tvb, 0, context_length),
port_number,
tvb_get_ephemeral_string(tvb, timestamp_start, timestamp_length),
(direction == 0) ? 'S' : 'R',
tvb_get_ephemeral_string(tvb, protocol_start, protocol_length),
- variant);
+ tvb_get_ephemeral_string(tvb, variant_start, variant_length));
}
}
}
},
{ &hf_catapult_dct2000_variant,
{ "Protocol variant",
- "dct2000.variant", FT_UINT8, BASE_DEC, NULL, 0x0,
+ "dct2000.variant", FT_STRING, BASE_NONE, NULL, 0x0,
"DCT2000 protocol variant", HFILL
}
},
#define MAX_CONTEXT_NAME 64
#define MAX_PROTOCOL_NAME 64
#define MAX_PORT_DIGITS 2
-#define MAX_VARIANT_DIGITS 2
+#define MAX_VARIANT_DIGITS 32
#define AAL_HEADER_CHARS 12
/* TODO:
/* The DCT2000 protocol name of the packet, plus variant number */
static gchar protocol_name[MAX_PROTOCOL_NAME+1];
-static gchar variant;
+static gchar variant_name[MAX_VARIANT_DIGITS+1];
/*************************************************/
packet_direction_t *direction,
int *encap,
gboolean seek_read);
-int write_stub_header(guchar *frame_buffer, char *timestamp_string,
+static int write_stub_header(guchar *frame_buffer, char *timestamp_string,
packet_direction_t direction, int encap);
static guchar hex_from_char(gchar c);
static gchar char_from_hex(guchar hex);
int port_digits = 0;
char port_number_string[MAX_PORT_DIGITS+1];
int variant_digits = 0;
- char variant_number_string[MAX_VARIANT_DIGITS+1];
-
int protocol_chars = 0;
char seconds_buff[MAX_SECONDS_CHARS+1];
{
return FALSE;
}
- variant_number_string[variant_digits] = linebuff[n];
+ variant_name[variant_digits] = linebuff[n];
}
if (variant_digits > MAX_VARIANT_DIGITS || (n+1 >= line_length))
{
}
if (variant_digits > 0)
{
- variant_number_string[variant_digits] = '\0';
- variant = atoi(variant_number_string);
+ variant_name[variant_digits] = '\0';
}
else
{
- variant = 1;
+ strcpy(variant_name, "1");
}
stub_offset += (strlen(protocol_name) + 1);
/* Protocol variant number */
- frame_buffer[stub_offset] = variant;
- stub_offset++;
-
+ strcpy((void*)&frame_buffer[stub_offset], variant_name);
+ stub_offset += (strlen(variant_name) + 1);
+
/* Direction */
frame_buffer[stub_offset] = direction;
stub_offset++;