Fix Dead Store (Dead nested assignment) Warning found by Clang
authoralagoutte <alagoutte@f5534014-38df-0310-8fa8-9805f1628bb7>
Thu, 21 Apr 2011 13:33:59 +0000 (13:33 +0000)
committeralagoutte <alagoutte@f5534014-38df-0310-8fa8-9805f1628bb7>
Thu, 21 Apr 2011 13:33:59 +0000 (13:33 +0000)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36759 f5534014-38df-0310-8fa8-9805f1628bb7

epan/dissectors/packet-smtp.c

index cf2f3360b515be5e93d2e58240352fa3a170cd18..d4512ee45c2acc750eb38684c3059feb997b163e 100644 (file)
@@ -255,7 +255,6 @@ dissect_smtp(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
   conversation_t            *conversation;
   struct smtp_session_state *session_state;
   const guchar              *line, *linep, *lineend;
-  guchar                    c;
   guint32                   code;
   int                       linelen = 0;
   gint                      length_remaining;
@@ -475,7 +474,7 @@ dissect_smtp(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
            */
           linep = line;
           lineend = line + linelen;
-          while (linep < lineend && (c = *linep) != ' ')
+          while (linep < lineend && *linep != ' ')
             linep++;
           cmdlen = (int)(linep - line);
           if (line_is_smtp_command(line, cmdlen)) {