Wireshark crashes in gsm_map dissector
authoretxrab <etxrab@f5534014-38df-0310-8fa8-9805f1628bb7>
Tue, 29 Nov 2011 07:03:31 +0000 (07:03 +0000)
committeretxrab <etxrab@f5534014-38df-0310-8fa8-9805f1628bb7>
Tue, 29 Nov 2011 07:03:31 +0000 (07:03 +0000)
commitfacd61445770faed9b647dec51fc3998bdee6853
tree6f42fe27c5478d6eddc66081529ab60e7f316b7e
parentc6b0614f22b4db895b64dbe8bcb2ae4701181e12
Wireshark crashes in gsm_map dissector

For now use Jeff's fix:
"The REAL problem is that the GSM_MAP dissector is using this value_string_ext
in the hf without BASE_EXT_STRING:

    { &hf_gsm_old_localValue,
      { "localValue", "gsm_old.localValue",
        FT_INT32, BASE_DEC, &gsm_old_GSMMAPOperationLocalvalue_vals_ext, 0,
        "OperationLocalvalue", HFILL }},

This, in turn, appears to be caused because OperationLocalValue is an alias
for/of GSMMAPOperationLocalValue and only the latter is defined with
.USE_VALS_EXT.

I can fix it by doing:

Index: asn1/gsm_map/gsm_map.cnf
===================================================================
--- asn1/gsm_map/gsm_map.cnf    (revision 39628)
+++ asn1/gsm_map/gsm_map.cnf    (working copy)
@@ -54,6 +54,7 @@

 #.USE_VALS_EXT
 GSMMAPOperationLocalvalue
+OperationLocalvalue

 #.EXPORTS
 AddressString

But it seems to be that asn2wrs should arguably be figuring this out on its
own."

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@40033 f5534014-38df-0310-8fa8-9805f1628bb7
asn1/gsm_map/gsm_map.cnf
epan/dissectors/packet-gsm_map.c