From Xiao Xiangquan:
[obnox/wireshark/wip.git] / wiretap / netxray.c
index 93bc759cddbace18f35fd9849d72b35b6a380c8c..f7285fd7ca501ae9aedb4070a651120fcab3d442 100644 (file)
@@ -24,7 +24,6 @@
 #include "config.h"
 #endif
 
-#include <stdlib.h>
 #include <errno.h>
 #include <string.h>
 #include "wtap-int.h"
@@ -46,44 +45,78 @@ static const char netxray_magic[] = {       /* magic header */
        'X', 'C', 'P', '\0'
 };
 
-/* NetXRay file header (minus magic number). */
+/* NetXRay file header (minus magic number).                   */
+/*                                                             */
+/* As field usages are identified, please revise as needed     */
+/* Please do *not* use netxray_hdr xxx... names in the code    */
+/* (Placeholder names for all 'unknown' fields are             */
+/*   of form xxx_x<hex_hdr_offset>                             */
+/*   where <hex_hdr_offset> *includes* the magic number)       */
+
 struct netxray_hdr {
-       char    version[8];     /* version number */
-       guint32 start_time;     /* UNIX time when capture started */
-       guint32 nframes;        /* number of packets */
-       guint32 xxx;            /* unknown */
-       guint32 start_offset;   /* offset of first packet in capture */
-       guint32 end_offset;     /* offset after last packet in capture */
-       guint32 xxy[3];         /* unknown */
-       guint8  network;        /* datalink type */
-       guint8  xxz[3];         /* XXX - is this the upper 3 bytes of the datalink type? */
-       guint8  timeunit;       /* encodes length of a tick */
-       guint8  xxa[3];         /* XXX - is this the upper 3 bytes of the time units? */
-       guint32 timelo;         /* lower 32 bits of time stamp of capture start */
-       guint32 timehi;         /* upper 32 bits of time stamp of capture start */
-       guint32 linespeed;      /* speed of network, in bits/second */
-       guint8  xxb[12];        /* other stuff */
-       guint8  realtick[4];    /* in version 2, units of the timestamps  */
-       guint8  xxc[48];        /* other unknown stuff */
+       char    version[8];     /* version number                               */
+       guint32 start_time;     /* UNIX [UTC] time when capture started         */
+
+       guint32 nframes;        /* number of packets                            */
+       guint32 xxx_x14;        /* unknown [some kind of file offset]           */
+       guint32 start_offset;   /* offset of first packet in capture            */
+       guint32 end_offset;     /* offset after last packet in capture          */
+
+       guint32 xxx_x20;        /* unknown [some kind of file offset]           */
+       guint32 xxx_x24;        /* unknown [unused ?]                           */
+       guint32 xxx_x28;        /* unknown [some kind of file offset]           */
+       guint8  network;        /* datalink type                                */
+       guint8  network_plus;   /* [See code]                                   */
+       guint8  xxx_x2E[2];     /* unknown                                      */
+
+       guint8  timeunit;       /* encodes length of a tick                     */
+       guint8  xxx_x31[3];     /* XXX - upper 3 bytes of timeunit ?            */
+       guint32 timelo;         /* lower 32 bits of capture start time stamp    */
+       guint32 timehi;         /* upper 32 bits of capture start time stamp    */
+       guint32 linespeed;      /* speed of network, in bits/second             */
+
+       guint8  xxx_x40[12];    /* unknown [other stuff]                        */
+       guint8  realtick[4];    /* (ticks/sec for Ethernet/Ndis/Timeunit=2 ?)   */
+                               /* (realtick[1], realtick[2] also currently     */
+                               /*  used as flag for 'FCS presence')            */
+
+       guint8  xxx_x50[4];     /* unknown [other stuff]                        */
+       guint8  captype;        /* capture type                                 */
+       guint8  xxx_x55[3];     /* unknown [other stuff]                        */
+       guint8  xxx_x58[4];     /* unknown [other stuff]                        */
+       guint8  wan_hdlc_subsub_captype; /* WAN HDLC subsub_captype             */
+       guint8  xxx_x5D[3];     /* unknown [other stuff]                        */
+
+       guint8  xxx_x60[16];    /* unknown [other stuff]                        */
+
+       guint8  xxx_x70[14];    /* unknown [other stuff]                        */
+       gint16 timezone_hrs;    /* timezone hours [at least for version 2.2..]; */
+                               /*  positive values = west of UTC:              */
+                               /*  negative values = east of UTC:              */
+                               /*  e.g. +5 is American Eastern                 */
+                               /* [Does not appear to be adjusted for DST ]    */
 };
 
 /*
- * Capture type, in xxc[4].
+ * Capture type, in hdr.captype.
  *
- * XXX - S6040-model Sniffers with gigabit blades store 6 here for
- * Etherneet captures, and some other Ethernet captures had a capture
- * type of 3, so presumably the interpretation of the capture type
- * depends on the network type.  We prefix all the capture types
- * for WAN captures with WAN_.
+ * Values other than 0 are dependent on the network type.
+ * For Ethernet captures, it indicates the type of capture pod.
+ * For WAN captures (all of which are done with a pod), it indicates
+ * the link-layer type.
  */
-#define CAPTYPE_NDIS   0       /* Capture on network interface using NDIS */
+#define CAPTYPE_NDIS   0               /* Capture on network interface using NDIS                      */
 
 /*
  * Ethernet capture types.
  */
-#define ETH_CAPTYPE_GIGPOD     2       /* gigabit Ethernet captured with pod */
-#define ETH_CAPTYPE_OTHERPOD   3       /* non-gigabit Ethernet captured with pod */
-#define ETH_CAPTYPE_GIGPOD2    6       /* gigabit Ethernet captured with pod */
+#define ETH_CAPTYPE_GIGPOD     2       /* gigabit Ethernet captured with pod                           */
+#define ETH_CAPTYPE_OTHERPOD   3       /* non-gigabit Ethernet captured with pod                       */
+#define ETH_CAPTYPE_OTHERPOD2  5       /* gigabit Ethernet via pod ??                                  */
+                                       /*  Captype 5 seen in capture from Distributed Sniffer with:    */
+                                       /*    Version 4.50.211 software                                 */
+                                       /*    SysKonnect SK-9843 Gigabit Ethernet Server Adapter        */
+#define ETH_CAPTYPE_GIGPOD2    6       /* gigabit Ethernet, captured with blade on S6040-model Sniffer */
 
 /*
  * WAN capture types.
@@ -99,39 +132,119 @@ struct netxray_hdr {
 #define WAN_CAPTYPE_SMDS       10      /* SMDS DXI */
 #define WAN_CAPTYPE_BROUTER4   11      /* Bridge/router captured with pod */
 #define WAN_CAPTYPE_BROUTER5   12      /* Bridge/router captured with pod */
+#define WAN_CAPTYPE_CHDLC      19      /* Cisco router (CHDLC) captured with pod */
 
-#define CAPTYPE_ATM    15      /* ATM captured with pod */
+#define CAPTYPE_ATM            15      /* ATM captured with pod */
 
 /*
- * # of ticks that equal 1 second, in version 002.xxx files with a zero
- * hdr.realtick value; the index into this array is hdr.timeunit.
+ * # of ticks that equal 1 second, in version 002.xxx files other
+ * than Ethernet captures with a captype other than CAPTYPE_NDIS;
+ * the index into this array is hdr.timeunit.
+ *
+ * DO NOT SEND IN PATCHES THAT CHANGE ANY OF THE NON-ZERO VALUES IN
+ * ANY OF THE TpS TABLES.  THOSE VALUES ARE CORRECT FOR AT LEAST ONE
+ * CAPTURE, SO CHANGING THEM WILL BREAK AT LEAST SOME CAPTURES.  WE
+ * WILL NOT CHECK IN PATCHES THAT CHANGE THESE VALUES.
+ *
+ * Instead, if a value in a TpS table is wrong, check whether captype
+ * has a non-zero value; if so, perhaps we need a new TpS table for the
+ * corresponding network type and captype, or perhaps the 'realtick'
+ * field contains the correct ticks-per-second value.
+ *
+ * TpS...[] entries of 0.0 mean that no capture file for the
+ * corresponding captype/timeunit values has yet been seen, or that
+ * we're using the 'realtick' value.
  *
- * XXX - the third item was 1193180.0, presumably because somebody found
- * it gave the right answer for some captures, but 3 times that, i.e.
- * 3579540.0, appears to give the right answer for some other captures.
- * In at least some captures, 3579540.0 is what's in the hdr.realtick
- * field, but hdr.timeunit is 0, giving a TpS value of 1000000.0.
+ * XXX - 05/29/07: For Ethernet captype = 0 (NDIS) and timeunit = 2:
+ *  Perusal of a number of Sniffer captures
+ *  (including those from Wireshark bug reports
+ *  and those from the Wireshark 'menagerie)
+ *  suggests that 'realtick' for this case
+ *  contains the correct ticks/second to be used.
+ *  So: we'll use realtick for Ethernet captype=0 and timeunit=2.
+ *  (It might be that realtick should be used for Ethernet captype = 0
+ *  and timeunit = 1 but I've not yet enough captures to be sure).
+ *   Based upon the captures reviewed to date, realtick cannot be used for
+ *   any of the other Ethernet captype/timeunit combinations for which there
+ *   are non-zero values in the TpS tables.
  *
- * Which of 1193180.0 or 1193000.0 is right for captures with no
- * hdr.realtick value (i.e., hdr.realtick is 0) and a hdr.timeunit value
- * of 1?  In at least one ATM capture, hdr.realtick is 1193180.0
- * and hdr.timeunit is 0.  However, in at least one Ethernet capture,
- * hdr.realtick is 1193000.0 and hdr.timeunit is 1, so both of those
- * values appear in hdr.realtick; perhaps whatever capture provoked
- * us to change from 1193180.0 to 1193000.0 has a hdr.realtick value
- * of 1193000.0 - or vice versa.
+ *  In at least one capture where "realtick" doesn't correspond
+ *  to the value from the appropriate TpS table, the per-packet header's
+ *  "xxx" field is all zero, so it's not as if a 2.x header includes
+ *  a "compatibility" time stamp corresponding to the value from the
+ *  TpS table and a "real" time stamp corresponding to "realtick".
  *
- * XXX - what's the significance of hdr.timeunit if hdr.realticks is
- * non-zero?  It's different in different captures; does it signify
- * anything?
+ * XXX - the item corresponding to timeunit = 2 is 1193180.0, presumably
+ *  because somebody found it gave the right answer for some captures, but
+ *  3 times that, i.e. 3579540.0, appears to give the right answer for some
+ *  other captures.
  *
- * XXX - what's the range of hdr.timeunit in files with hdr.realticks
- * 0?  Does it ever have a value of 2 in any of those captures, or is
- * it either 0 or 1?
+ *  Some captures have realtick of 1193182, some have 3579545, and some
+ *  have 1193000.  Most of those, in one set of captures somebody has,
+ *  are wrong.  (Did that mean "wrong for some capture files, but not
+ *  for the files in which they occurred", or "wrong for the files in
+ *  which they occurred?  If it's "wrong for some capture files, but
+ *  not for the files in which they occurred", perhaps those were Ethernet
+ *  captures with a captype of 0 and timeunit = 2, so that we now use
+ *  realtick, and perhaps that fixes the problems.)
+ *
+ * XXX - in at least one ATM capture, hdr.realtick is 1193180.0
+ *  and hdr.timeunit is 0.  Does that capture have a captype of
+ *  CAPTYPE_ATM?  If so, what should the table for ATM captures with
+ *  that captype be?
  */
-static double TpS[] = { 1e6, 1193000.0, 3579540.0 };
+static const double TpS[] = { 1e6, 1193000.0, 1193182.0 };
 #define NUM_NETXRAY_TIMEUNITS (sizeof TpS / sizeof TpS[0])
 
+/*
+ * Table of time units for Ethernet captures with captype ETH_CAPTYPE_GIGPOD.
+ * 0.0 means "unknown".
+ *
+ * It appears that, at least for Ethernet captures, if captype is
+ * ETH_CAPTYPE_GIGPOD, that indicates that it's a gigabit Ethernet
+ * capture, possibly from a special whizzo gigabit pod, and also
+ * indicates that the time stamps have some higher resolution than
+ * in other captures, possibly thanks to a high-resolution timer
+ * on the pod.
+ *
+ * It also appears that the time units might differ for gigabit pod
+ * captures between version 002.001 and 002.002.  For 002.001,
+ * the values below are correct; for 002.002, it's claimed that
+ * the right value for TpS_gigpod[2] is 1250000.0, but at least one
+ * 002.002 gigabit pod capture has 31250000.0 as the right value.
+ * XXX: Note that the TpS_otherpod[2] value is 1250000.0; It seems
+ *  reasonable to suspect that the original claim might actually
+ *  have been for a capture with a captype of 'otherpod'.
+ * (Based upon captures reviewed realtick does not contain the
+ *   correct TpS values for the 'gigpod' captype).
+ */
+static const double TpS_gigpod[] = { 1e9, 0.0, 31250000.0 };
+#define NUM_NETXRAY_TIMEUNITS_GIGPOD (sizeof TpS_gigpod / sizeof TpS_gigpod[0])
+
+/*
+ * Table of time units for Ethernet captures with captype ETH_CAPTYPE_OTHERPOD.
+ *  (Based upon captures reviewed realtick does not contain the
+ *   correct TpS values for the 'otherpod' captype).
+ */
+static const double TpS_otherpod[] = { 1e6, 0.0, 1250000.0 };
+#define NUM_NETXRAY_TIMEUNITS_OTHERPOD (sizeof TpS_otherpod / sizeof TpS_otherpod[0])
+
+/*
+ * Table of time units for Ethernet captures with captype ETH_CAPTYPE_OTHERPOD2.
+ * (Based upon captures reviewed realtick does not contain the
+ *   correct TpS values for the 'otherpod2' captype).
+ */
+static const double TpS_otherpod2[] = { 1e6, 0.0, 0.0 };
+#define NUM_NETXRAY_TIMEUNITS_OTHERPOD2 (sizeof TpS_otherpod2 / sizeof TpS_otherpod2[0])
+
+/*
+ * Table of time units for Ethernet captures with captype ETH_CAPTYPE_GIGPOD2.
+ * (Based upon captures reviewed realtick does not contain the
+ *   correct TpS values for the 'gigpod2' captype).
+ */
+static const double TpS_gigpod2[] = { 1e9, 0.0, 20000000.0 };
+#define NUM_NETXRAY_TIMEUNITS_GIGPOD2 (sizeof TpS_gigpod2 / sizeof TpS_gigpod2[0])
+
 /* Version number strings. */
 static const char vers_1_0[] = {
        '0', '0', '1', '.', '0', '0', '0', '\0'
@@ -153,6 +266,10 @@ static const char vers_2_002[] = {
        '0', '0', '2', '.', '0', '0', '2', '\0'
 };
 
+static const char vers_2_003[] = {
+       '0', '0', '2', '.', '0', '0', '3', '\0'
+};
+
 /* Old NetXRay data record format - followed by frame data. */
 struct old_netxrayrec_hdr {
        guint32 timelo;         /* lower 32 bits of time stamp */
@@ -188,25 +305,37 @@ union netxrayrec_hdr {
        struct netxrayrec_2_x_hdr hdr_2_x;
 };
 
+typedef struct {
+       time_t          start_time;
+       double          ticks_per_sec;
+       double          start_timestamp;
+       gboolean        wrapped;
+       guint32         nframes;
+       gint64          start_offset;
+       gint64          end_offset;
+       int             version_major;
+       gboolean        fcs_valid;      /* if packets have valid FCS at the end */
+       guint           isdn_type;      /* 1 = E1 PRI, 2 = T1 PRI, 3 = BRI */
+} netxray_t;
+
 static gboolean netxray_read(wtap *wth, int *err, gchar **err_info,
-    long *data_offset);
-static gboolean netxray_seek_read(wtap *wth, long seek_off,
-    union wtap_pseudo_header *pseudo_header, guchar *pd, int length,
+    gint64 *data_offset);
+static gboolean netxray_seek_read(wtap *wth, gint64 seek_off,
+    union wtap_pseudo_header *pseudo_header, guint8 *pd, int length,
     int *err, gchar **err_info);
 static int netxray_read_rec_header(wtap *wth, FILE_T fh,
-    union netxrayrec_hdr *hdr, int *err);
+    union netxrayrec_hdr *hdr, int *err, gchar **err_info);
 static guint netxray_set_pseudo_header(wtap *wth, const guint8 *pd, int len,
     union wtap_pseudo_header *pseudo_header, union netxrayrec_hdr *hdr);
 static gboolean netxray_read_rec_data(FILE_T fh, guint8 *data_ptr,
-    guint32 packet_size, int *err);
-static void netxray_close(wtap *wth);
+    guint32 packet_size, int *err, gchar **err_info);
 static gboolean netxray_dump_1_1(wtap_dumper *wdh,
     const struct wtap_pkthdr *phdr,
-    const union wtap_pseudo_header *pseudo_header, const guchar *pd, int *err);
+    const union wtap_pseudo_header *pseudo_header, const guint8 *pd, int *err);
 static gboolean netxray_dump_close_1_1(wtap_dumper *wdh, int *err);
 static gboolean netxray_dump_2_0(wtap_dumper *wdh,
     const struct wtap_pkthdr *phdr,
-    const union wtap_pseudo_header *pseudo_header, const guchar *pd, int *err);
+    const union wtap_pseudo_header *pseudo_header, const guint8 *pd, int *err);
 static gboolean netxray_dump_close_2_0(wtap_dumper *wdh, int *err);
 
 int netxray_open(wtap *wth, int *err, gchar **err_info)
@@ -216,7 +345,7 @@ int netxray_open(wtap *wth, int *err, gchar **err_info)
        gboolean is_old;
        struct netxray_hdr hdr;
        guint network_type;
-       double timeunit;
+       double ticks_per_sec;
        int version_major, version_minor;
        int file_type;
        double start_timestamp;
@@ -233,26 +362,27 @@ int netxray_open(wtap *wth, int *err, gchar **err_info)
                 * pods use the same network type value but aren't
                 * shaped like Ethernet.  We handle that below.
                 */
-               WTAP_ENCAP_ETHERNET,    /* WAN(PPP), but shaped like Ethernet */
-               WTAP_ENCAP_UNKNOWN,     /* LocalTalk */
-               WTAP_ENCAP_UNKNOWN,     /* "DIX" - should not occur */
-               WTAP_ENCAP_UNKNOWN,     /* ARCNET raw */
-               WTAP_ENCAP_UNKNOWN,     /* ARCNET 878.2 */
-               WTAP_ENCAP_ATM_PDUS_UNTRUNCATED,        /* ATM */
+               WTAP_ENCAP_ETHERNET,            /* WAN(PPP), but shaped like Ethernet */
+               WTAP_ENCAP_UNKNOWN,             /* LocalTalk */
+               WTAP_ENCAP_UNKNOWN,             /* "DIX" - should not occur */
+               WTAP_ENCAP_UNKNOWN,             /* ARCNET raw */
+               WTAP_ENCAP_UNKNOWN,             /* ARCNET 878.2 */
+               WTAP_ENCAP_ATM_PDUS_UNTRUNCATED,/* ATM */
                WTAP_ENCAP_IEEE_802_11_WITH_RADIO,
-                                       /* Wireless WAN with radio information */
-               WTAP_ENCAP_UNKNOWN      /* IrDA */
+                                               /* Wireless WAN with radio information */
+               WTAP_ENCAP_UNKNOWN              /* IrDA */
        };
        #define NUM_NETXRAY_ENCAPS (sizeof netxray_encap / sizeof netxray_encap[0])
        int file_encap;
        guint isdn_type = 0;
+       netxray_t *netxray;
 
        /* Read in the string that should be at the start of a NetXRay
         * file */
        errno = WTAP_ERR_CANT_READ;
-       bytes_read = file_read(magic, 1, sizeof magic, wth->fh);
+       bytes_read = file_read(magic, sizeof magic, wth->fh);
        if (bytes_read != sizeof magic) {
-               *err = file_error(wth->fh);
+               *err = file_error(wth->fh, err_info);
                if (*err != 0)
                        return -1;
                return 0;
@@ -269,9 +399,9 @@ int netxray_open(wtap *wth, int *err, gchar **err_info)
 
        /* Read the rest of the header. */
        errno = WTAP_ERR_CANT_READ;
-       bytes_read = file_read(&hdr, 1, sizeof hdr, wth->fh);
+       bytes_read = file_read(&hdr, sizeof hdr, wth->fh);
        if (bytes_read != sizeof hdr) {
-               *err = file_error(wth->fh);
+               *err = file_error(wth->fh, err_info);
                if (*err != 0)
                        return -1;
                return 0;
@@ -310,6 +440,10 @@ int netxray_open(wtap *wth, int *err, gchar **err_info)
                        version_major = 2;
                        version_minor = 2;
                        file_type = WTAP_FILE_NETXRAY_2_00x;
+               } else if (memcmp(hdr.version, vers_2_003, sizeof vers_2_003) == 0) {
+                       version_major = 2;
+                       version_minor = 3;
+                       file_type = WTAP_FILE_NETXRAY_2_00x;
                } else {
                        *err = WTAP_ERR_UNSUPPORTED;
                        *err_info = g_strdup_printf("netxray: version \"%.8s\" unsupported", hdr.version);
@@ -317,7 +451,7 @@ int netxray_open(wtap *wth, int *err, gchar **err_info)
                }
        }
 
-       switch (hdr.xxz[0]) {
+       switch (hdr.network_plus) {
 
        case 0:
                /*
@@ -341,7 +475,7 @@ int netxray_open(wtap *wth, int *err, gchar **err_info)
        default:
                *err = WTAP_ERR_UNSUPPORTED;
                *err_info = g_strdup_printf("netxray: the byte after the network type has the value %u, which I don't understand",
-                   hdr.xxz[0]);
+                   hdr.network_plus);
                return -1;
        }
 
@@ -349,7 +483,7 @@ int netxray_open(wtap *wth, int *err, gchar **err_info)
            || netxray_encap[network_type] == WTAP_ENCAP_UNKNOWN) {
                *err = WTAP_ERR_UNSUPPORTED_ENCAP;
                *err_info = g_strdup_printf("netxray: network type %u (%u) unknown or unsupported",
-                   network_type, hdr.xxz[0]);
+                   network_type, hdr.network_plus);
                return -1;
        }
 
@@ -361,11 +495,13 @@ int netxray_open(wtap *wth, int *err, gchar **err_info)
        switch (file_type) {
 
        case WTAP_FILE_NETXRAY_OLD:
-               timeunit = 1000.0;
+               ticks_per_sec = 1000.0;
+               wth->tsprecision = WTAP_FILE_TSPREC_MSEC;
                break;
 
        case WTAP_FILE_NETXRAY_1_0:
-               timeunit = 1000.0;
+               ticks_per_sec = 1000.0;
+               wth->tsprecision = WTAP_FILE_TSPREC_MSEC;
                break;
 
        case WTAP_FILE_NETXRAY_1_1:
@@ -375,46 +511,174 @@ int netxray_open(wtap *wth, int *err, gchar **err_info)
                 * rather than the milliseconds time stamps in NetXRay
                 * and older versions of Windows Sniffer.
                 */
-               timeunit = 1000000.0;
+               ticks_per_sec = 1000000.0;
+               wth->tsprecision = WTAP_FILE_TSPREC_USEC;
                break;
 
        case WTAP_FILE_NETXRAY_2_00x:
                /*
-                * In version 2.x files, there appears to be a time stamp
-                * value in the file header for at least some captures.
-                * In others, the time stamp value is 0; if that's the case,
-                * use the hdr.timeunit value.
+                * Get the time stamp units from the appropriate TpS
+                * table or from the file header.
                 */
-               timeunit = pletohl(&hdr.realtick);
-               if (timeunit == 0) {
+               switch (network_type) {
+
+               case 1:
+                       /*
+                        * Ethernet - the table to use depends on whether
+                        * this is an NDIS or pod capture.
+                        */
+                       switch (hdr.captype) {
+
+                       case CAPTYPE_NDIS:
+                               if (hdr.timeunit >= NUM_NETXRAY_TIMEUNITS) {
+                                       *err = WTAP_ERR_UNSUPPORTED;
+                                       *err_info = g_strdup_printf(
+                                           "netxray: Unknown timeunit %u for Ethernet/CAPTYPE_NDIS version %.8s capture",
+                                           hdr.timeunit, hdr.version);
+                                       return -1;
+                               }
+                               /*
+                               XXX: 05/29/07: Use 'realtick' instead of TpS table if timeunit=2;
+                                       Using 'realtick' in this case results
+                                       in the correct 'ticks per second' for all the captures that
+                                       I have of this type (including captures from a number of Wirshark
+                                       bug reports).
+                               */
+                               if (hdr.timeunit == 2) {
+                                       ticks_per_sec = pletohl(hdr.realtick);
+                               }
+                               else {
+                                       ticks_per_sec = TpS[hdr.timeunit];
+                               }
+                               break;
+
+                       case ETH_CAPTYPE_GIGPOD:
+                               if (hdr.timeunit >= NUM_NETXRAY_TIMEUNITS_GIGPOD
+                                   || TpS_gigpod[hdr.timeunit] == 0.0) {
+                                       *err = WTAP_ERR_UNSUPPORTED;
+                                       *err_info = g_strdup_printf(
+                                           "netxray: Unknown timeunit %u for Ethernet/ETH_CAPTYPE_GIGPOD version %.8s capture",
+                                           hdr.timeunit, hdr.version);
+                                       return -1;
+                               }
+                               ticks_per_sec = TpS_gigpod[hdr.timeunit];
+
+                               /*
+                                * At least for 002.002 and 002.003
+                                * captures, the start time stamp is 0,
+                                * not the value in the file.
+                                */
+                               if (version_minor == 2 || version_minor == 3)
+                                       start_timestamp = 0.0;
+                               break;
+
+                       case ETH_CAPTYPE_OTHERPOD:
+                               if (hdr.timeunit >= NUM_NETXRAY_TIMEUNITS_OTHERPOD
+                                   || TpS_otherpod[hdr.timeunit] == 0.0) {
+                                       *err = WTAP_ERR_UNSUPPORTED;
+                                       *err_info = g_strdup_printf(
+                                           "netxray: Unknown timeunit %u for Ethernet/ETH_CAPTYPE_OTHERPOD version %.8s capture",
+                                           hdr.timeunit, hdr.version);
+                                       return -1;
+                               }
+                               ticks_per_sec = TpS_otherpod[hdr.timeunit];
+
+                               /*
+                                * At least for 002.002 and 002.003
+                                * captures, the start time stamp is 0,
+                                * not the value in the file.
+                                */
+                               if (version_minor == 2 || version_minor == 3)
+                                       start_timestamp = 0.0;
+                               break;
+
+                       case ETH_CAPTYPE_OTHERPOD2:
+                               if (hdr.timeunit >= NUM_NETXRAY_TIMEUNITS_OTHERPOD2
+                                   || TpS_otherpod2[hdr.timeunit] == 0.0) {
+                                       *err = WTAP_ERR_UNSUPPORTED;
+                                       *err_info = g_strdup_printf(
+                                           "netxray: Unknown timeunit %u for Ethernet/ETH_CAPTYPE_OTHERPOD2 version %.8s capture",
+                                           hdr.timeunit, hdr.version);
+                                       return -1;
+                               }
+                               ticks_per_sec = TpS_otherpod2[hdr.timeunit];
+                               /*
+                                * XXX: start time stamp in the one capture file examined of this type was 0;
+                                *      We'll assume the start time handling is the same as for other pods.
+                                *
+                                * At least for 002.002 and 002.003
+                                * captures, the start time stamp is 0,
+                                * not the value in the file.
+                                */
+                               if (version_minor == 2 || version_minor == 3)
+                                       start_timestamp = 0.0;
+                               break;
+
+                       case ETH_CAPTYPE_GIGPOD2:
+                               if (hdr.timeunit >= NUM_NETXRAY_TIMEUNITS_GIGPOD2
+                                   || TpS_gigpod2[hdr.timeunit] == 0.0) {
+                                       *err = WTAP_ERR_UNSUPPORTED;
+                                       *err_info = g_strdup_printf(
+                                           "netxray: Unknown timeunit %u for Ethernet/ETH_CAPTYPE_GIGPOD2 version %.8s capture",
+                                           hdr.timeunit, hdr.version);
+                                       return -1;
+                               }
+                               ticks_per_sec = TpS_gigpod2[hdr.timeunit];
+                               /*
+                                * XXX: start time stamp in the one capture file examined of this type was 0;
+                                *      We'll assume the start time handling is the same as for other pods.
+                                *
+                                * At least for 002.002 and 002.003
+                                * captures, the start time stamp is 0,
+                                * not the value in the file.
+                                */
+                               if (version_minor == 2 || version_minor == 3)
+                                       start_timestamp = 0.0;
+                               break;
+
+                       default:
+                               *err = WTAP_ERR_UNSUPPORTED;
+                               *err_info = g_strdup_printf(
+                                   "netxray: Unknown capture type %u for Ethernet version %.8s capture",
+                                   hdr.captype, hdr.version);
+                               return -1;
+                       }
+                       break;
+
+               default:
                        if (hdr.timeunit >= NUM_NETXRAY_TIMEUNITS) {
                                *err = WTAP_ERR_UNSUPPORTED;
-                               *err_info = g_strdup_printf("netxray: Unknown timeunit %u",
-                                   hdr.timeunit);
+                               *err_info = g_strdup_printf(
+                                   "netxray: Unknown timeunit %u for %u/%u version %.8s capture",
+                                   hdr.timeunit, network_type, hdr.captype,
+                                   hdr.version);
                                return -1;
                        }
-                       timeunit = TpS[hdr.timeunit];
+                       ticks_per_sec = TpS[hdr.timeunit];
+                       break;
                }
 
                /*
-                * For gigabit pod captures, the start timestamp appears
-                * to be 0.
+                * If the number of ticks per second is greater than
+                * 1 million, make the precision be nanoseconds rather
+                * than microseconds.
                 *
-                * XXX - is that true for other types of captures, such
-                * as gigabit pod captures with hdr.xxc[4] = 6, or
-                * for other pod captures?  Is it true for *all* pod
-                * captures?
+                * XXX - do values only slightly greater than one million
+                * correspond to a resolution sufficiently better than
+                * 1 microsecond to display more digits of precision?
+                * XXX - Seems reasonable to use nanosecs only if TPS >= 10M
                 */
-               if (network_type == 1 && hdr.xxc[4] == ETH_CAPTYPE_GIGPOD &&
-                   version_minor == 2)
-                       start_timestamp = 0.0;
+               if (ticks_per_sec >= 1e7)
+                       wth->tsprecision = WTAP_FILE_TSPREC_NSEC;
+               else
+                       wth->tsprecision = WTAP_FILE_TSPREC_USEC;
                break;
 
        default:
                g_assert_not_reached();
-               timeunit = 0.0;
+               ticks_per_sec = 0.0;
        }
-       start_timestamp = start_timestamp/timeunit;
+       start_timestamp = start_timestamp/ticks_per_sec;
 
        if (network_type == 4) {
                /*
@@ -423,12 +687,12 @@ int netxray_open(wtap *wth, int *err, gchar **err_info)
                 * frames (as a result, presumably, of having passed
                 * through NDISWAN).
                 *
-                * In version 2, it looks as if there's stuff in the "xxc"
-                * words of the file header to specify what particular
-                * type of WAN capture we have.
+                * In version 2, it looks as if there's stuff in the
+                * file header to specify what particular type of WAN
+                * capture we have.
                 */
                if (version_major == 2) {
-                       switch (hdr.xxc[4]) {
+                       switch (hdr.captype) {
 
                        case WAN_CAPTYPE_PPP:
                                /*
@@ -440,6 +704,18 @@ int netxray_open(wtap *wth, int *err, gchar **err_info)
                        case WAN_CAPTYPE_FRELAY:
                                /*
                                 * Frame Relay.
+                                *
+                                * XXX - in at least one capture, this
+                                * is Cisco HDLC, not Frame Relay, but
+                                * in another capture, it's Frame Relay.
+                                *
+                                * [Bytes in each capture:
+                                * Cisco HDLC:  hdr.xxx_x60[06:10]: 0x02 0x00 0x01 0x00 0x06
+                                * Frame Relay: hdr.xxx_x60[06:10]  0x00 0x00 0x00 0x00 0x00
+
+                                * Cisco HDLC:  hdr.xxx_x60[14:15]: 0xff 0xff
+                                * Frame Relay: hdr.xxx_x60[14:15]: 0x00 0x00
+                                * ]
                                 */
                                file_encap = WTAP_ENCAP_FRELAY_WITH_PHDR;
                                break;
@@ -449,9 +725,13 @@ int netxray_open(wtap *wth, int *err, gchar **err_info)
                                /*
                                 * Various HDLC flavors?
                                 */
-                               switch (hdr.xxc[12]) {
+                               switch (hdr.wan_hdlc_subsub_captype) {
 
                                case 0: /* LAPB/X.25 */
+                                       /*
+                                        * XXX - at least one capture of
+                                        * this type appears to be PPP.
+                                        */
                                        file_encap = WTAP_ENCAP_LAPB;
                                        break;
 
@@ -459,13 +739,13 @@ int netxray_open(wtap *wth, int *err, gchar **err_info)
                                case 2: /* T1 PRI */
                                case 3: /* BRI */
                                        file_encap = WTAP_ENCAP_ISDN;
-                                       isdn_type = hdr.xxc[12];
+                                       isdn_type = hdr.wan_hdlc_subsub_captype;
                                        break;
 
                                default:
                                        *err = WTAP_ERR_UNSUPPORTED_ENCAP;
                                        *err_info = g_strdup_printf("netxray: WAN HDLC capture subsubtype 0x%02x unknown or unsupported",
-                                          hdr.xxc[12]);
+                                          hdr.wan_hdlc_subsub_captype);
                                        return -1;
                                }
                                break;
@@ -477,10 +757,17 @@ int netxray_open(wtap *wth, int *err, gchar **err_info)
                                file_encap = WTAP_ENCAP_SDLC;
                                break;
 
+                       case WAN_CAPTYPE_CHDLC:
+                               /*
+                                *  Cisco router (CHDLC) captured with pod
+                                */
+                               file_encap = WTAP_ENCAP_CHDLC_WITH_PHDR;
+                               break;
+
                        default:
                                *err = WTAP_ERR_UNSUPPORTED_ENCAP;
                                *err_info = g_strdup_printf("netxray: WAN capture subtype 0x%02x unknown or unsupported",
-                                  hdr.xxc[4]);
+                                  hdr.captype);
                                return -1;
                        }
                } else
@@ -490,27 +777,28 @@ int netxray_open(wtap *wth, int *err, gchar **err_info)
 
        /* This is a netxray file */
        wth->file_type = file_type;
-       wth->capture.netxray = g_malloc(sizeof(netxray_t));
+       netxray = (netxray_t *)g_malloc(sizeof(netxray_t));
+       wth->priv = (void *)netxray;
        wth->subtype_read = netxray_read;
        wth->subtype_seek_read = netxray_seek_read;
-       wth->subtype_close = netxray_close;
        wth->file_encap = file_encap;
        wth->snapshot_length = 0;       /* not available in header */
-       wth->capture.netxray->start_time = pletohl(&hdr.start_time);
-       wth->capture.netxray->timeunit = timeunit;
-       wth->capture.netxray->start_timestamp = start_timestamp;
-       wth->capture.netxray->version_major = version_major;
+       netxray->start_time = pletohl(&hdr.start_time);
+       netxray->ticks_per_sec = ticks_per_sec;
+       netxray->start_timestamp = start_timestamp;
+       netxray->version_major = version_major;
 
        /*
         * If frames have an extra 4 bytes of stuff at the end, is
         * it an FCS, or just junk?
         */
-       wth->capture.netxray->fcs_valid = FALSE;
+       netxray->fcs_valid = FALSE;
        switch (file_encap) {
 
        case WTAP_ENCAP_ETHERNET:
        case WTAP_ENCAP_IEEE_802_11_WITH_RADIO:
        case WTAP_ENCAP_ISDN:
+       case WTAP_ENCAP_LAPB:
                /*
                 * It appears that, in at least some version 2 Ethernet
                 * captures, for frames that have 0xff in hdr_2_x.xxx[2]
@@ -544,39 +832,54 @@ int netxray_open(wtap *wth, int *err, gchar **err_info)
                 * Perhaps hdr.realtick[0] is 0x00, in which case time
                 * stamp units in the range 1192960 through 1193215
                 * correspond to captures with an FCS, but that's still
-                * a bit bizarre.  Note that there are captures with
-                * a network type of 0 (Ethernet) and capture type
-                * of 0 (NDIS) that do, and that don't, have 0x34 0x12
-                * in them, so it's not as if NDIS captures always lack
-                * FCSes - although the question then is whether any
-                * NDIS captures with 0x34 0x12 have frames with an FCS;
-                * if not, then it might be that no NDIS captures have
-                * FCSes.
+                * a bit bizarre.
+                *
+                * Note that there are captures with a network type of 0
+                * (Ethernet) and capture type of 0 (NDIS) that do, and
+                * that don't, have 0x34 0x12 in them, and at least one
+                * of the NDIS captures with 0x34 0x12 in it has FCSes,
+                * so it's not as if no NDIS captures have an FCS.
                 *
                 * There are also captures with a network type of 4 (WAN),
                 * capture type of 6 (HDLC), and subtype of 2 (T1 PRI) that
                 * do, and that don't, have 0x34 0x12, so there are at least
-                * some captures taken with a pod that might lack an FCS.
+                * some captures taken with a WAN pod that might lack an FCS.
+                * (We haven't yet tried dissecting the 4 bytes at the
+                * end of packets with hdr_2_x.xxx[2] and hdr_2_x.xxx[3]
+                * equal to 0xff as an FCS.)
                 *
                 * All captures I've seen that have 0x34 and 0x12 *and*
                 * have at least one frame with an FCS have a value of
-                * 0x01 in xxb[4].  No captures I've seen with a network
+                * 0x01 in xxx_x40[4].  No captures I've seen with a network
                 * type of 0 (Ethernet) missing 0x34 0x12 have 0x01 there,
                 * however.  However, there's at least one capture
                 * without 0x34 and 0x12, with a network type of 0,
-                * and with 0x01 in xxb[4], *without* FCSes in the
+                * and with 0x01 in xxx_x40[4], *without* FCSes in the
                 * frames - the 4 bytes at the end are all zero - so it's
-                * not as simple as "xxb[4] = 0x01 means the 4 bytes at
+                * not as simple as "xxx_x40[4] = 0x01 means the 4 bytes at
                 * the end are FCSes".  Also, there's also at least one
-                * 802.11 capture with an xxb[4] value of 0x01 with junk
-                * rather than an FCS at the end of the frame.
+                * 802.11 capture with an xxx_x40[4] value of 0x01 with junk
+                * rather than an FCS at the end of the frame, so xxx_x40[4]
+                * isn't an obvious flag to determine whether the
+                * capture has FCSes.
                 *
-                * There don't seem to be any other values in xxb or xxc
+                * There don't seem to be any other values in any of the
+                * xxx_x5..., xxx_x6...., xxx_x7.... fields
                 * that obviously correspond to frames having an FCS.
+                *
+                * 05/29/07: Examination of numerous sniffer captures suggests
+                *            that the apparent correlation of certain realtick
+                *            bytes to 'FCS presence' may actually be
+                *            a 'false positive'.
+                *           ToDo: Review analysis and update code.
+                *           It might be that the ticks-per-second value
+                *           is hardware-dependent, and that hardware with
+                *           a particular realtick value puts an FCS there
+                *           and other hardware doesn't.
                 */
                if (version_major == 2) {
                        if (hdr.realtick[1] == 0x34 && hdr.realtick[2] == 0x12)
-                               wth->capture.netxray->fcs_valid = TRUE;
+                               netxray->fcs_valid = TRUE;
                }
                break;
        }
@@ -585,17 +888,21 @@ int netxray_open(wtap *wth, int *err, gchar **err_info)
         * Remember the ISDN type, as we need it to interpret the
         * channel number in ISDN captures.
         */
-       wth->capture.netxray->isdn_type = isdn_type;
+       netxray->isdn_type = isdn_type;
 
        /* Remember the offset after the last packet in the capture (which
         * isn't necessarily the last packet in the file), as it appears
-        * there's sometimes crud after it. */
-       wth->capture.netxray->wrapped = FALSE;
-       wth->capture.netxray->end_offset = pletohl(&hdr.end_offset);
+        * there's sometimes crud after it.
+        * XXX: Remember 'start_offset' to help testing for 'short file' at EOF
+        */
+       netxray->wrapped      = FALSE;
+       netxray->nframes      = pletohl(&hdr.nframes);
+       netxray->start_offset = pletohl(&hdr.start_offset);
+       netxray->end_offset   = pletohl(&hdr.end_offset);
 
        /* Seek to the beginning of the data records. */
        if (file_seek(wth->fh, pletohl(&hdr.start_offset), SEEK_SET, err) == -1) {
-               g_free(wth->capture.netxray);
+               g_free(netxray);
                return -1;
        }
        wth->data_offset = pletohl(&hdr.start_offset);
@@ -604,9 +911,10 @@ int netxray_open(wtap *wth, int *err, gchar **err_info)
 }
 
 /* Read the next packet */
-static gboolean netxray_read(wtap *wth, int *err, gchar **err_info _U_,
-    long *data_offset)
+static gboolean netxray_read(wtap *wth, int *err, gchar **err_info,
+    gint64 *data_offset)
 {
+       netxray_t *netxray = (netxray_t *)wth->priv;
        guint32 packet_size;
        union netxrayrec_hdr hdr;
        int     hdr_size;
@@ -616,13 +924,13 @@ static gboolean netxray_read(wtap *wth, int *err, gchar **err_info _U_,
 
 reread:
        /* Have we reached the end of the packet data? */
-       if (wth->data_offset == wth->capture.netxray->end_offset) {
+       if (wth->data_offset == netxray->end_offset) {
                /* Yes. */
                *err = 0;       /* it's just an EOF, not an error */
                return FALSE;
        }
        /* Read record header. */
-       hdr_size = netxray_read_rec_header(wth, wth->fh, &hdr, err);
+       hdr_size = netxray_read_rec_header(wth, wth->fh, &hdr, err, err_info);
        if (hdr_size == 0) {
                /*
                 * Error or EOF.
@@ -634,10 +942,34 @@ reread:
                        return FALSE;
                }
 
-               /* We're at EOF.  Wrap? */
-               if (!wth->capture.netxray->wrapped) {
+               /* We're at EOF.  Wrap?
+                * XXX: Need to handle 'short file' cases
+                *      (Distributed Sniffer seems to have a
+                *       certain small propensity to generate 'short' files
+                *       i.e. [many] bytes are missing from the end of the file)
+                *   case 1: start_offset < end_offset
+                *           wrap will read already read packets again;
+                *           so: error with "short file"
+                *   case 2: start_offset > end_offset ("circular" file)
+                *           wrap will mean there's a gap (missing packets).
+                *           However, I don't see a good way to identify this
+                *           case so we'll just have to allow the wrap.
+                *           (Maybe there can be an error message after all
+                *            packets are read since there'll be less packets than
+                *            specified in the file header).
+                * Note that these cases occur *only* if a 'short' eof occurs exactly
+                * at the expected beginning of a frame header record; If there is a
+                * partial frame header (or partial frame data) record, then the
+                * netxray_read... functions will detect the short record.
+                */
+               if (netxray->start_offset < netxray->end_offset) {
+                       *err = WTAP_ERR_SHORT_READ;
+                       return FALSE;
+               }
+
+               if (!netxray->wrapped) {
                        /* Yes.  Remember that we did. */
-                       wth->capture.netxray->wrapped = TRUE;
+                       netxray->wrapped = TRUE;
                        if (file_seek(wth->fh, CAPTUREFILE_HEADER_SIZE,
                            SEEK_SET, err) == -1)
                                return FALSE;
@@ -659,13 +991,13 @@ reread:
        /*
         * Read the packet data.
         */
-       if (wth->capture.netxray->version_major == 0)
+       if (netxray->version_major == 0)
                packet_size = pletohs(&hdr.old_hdr.len);
        else
                packet_size = pletohs(&hdr.hdr_1_x.incl_len);
        buffer_assure_space(wth->frame_buffer, packet_size);
        pd = buffer_start_ptr(wth->frame_buffer);
-       if (!netxray_read_rec_data(wth->fh, pd, packet_size, err))
+       if (!netxray_read_rec_data(wth->fh, pd, packet_size, err, err_info))
                return FALSE;
        wth->data_offset += packet_size;
 
@@ -675,14 +1007,14 @@ reread:
        padding = netxray_set_pseudo_header(wth, pd, packet_size,
            &wth->pseudo_header, &hdr);
 
-       if (wth->capture.netxray->version_major == 0) {
+       if (netxray->version_major == 0) {
                t = (double)pletohl(&hdr.old_hdr.timelo)
                    + (double)pletohl(&hdr.old_hdr.timehi)*4294967296.0;
-               t /= wth->capture.netxray->timeunit;
-               t -= wth->capture.netxray->start_timestamp;
-               wth->phdr.ts.tv_sec = wth->capture.netxray->start_time + (long)t;
-               wth->phdr.ts.tv_usec = (unsigned long)((t-(double)(unsigned long)(t))
-                       *1.0e6);
+               t /= netxray->ticks_per_sec;
+               t -= netxray->start_timestamp;
+               wth->phdr.ts.secs = netxray->start_time + (long)t;
+               wth->phdr.ts.nsecs = (int)((t-(double)(unsigned long)(t))
+                       *1.0e9);
                /*
                 * We subtract the padding from the packet size, so our caller
                 * doesn't see it.
@@ -692,11 +1024,11 @@ reread:
        } else {
                t = (double)pletohl(&hdr.hdr_1_x.timelo)
                    + (double)pletohl(&hdr.hdr_1_x.timehi)*4294967296.0;
-               t /= wth->capture.netxray->timeunit;
-               t -= wth->capture.netxray->start_timestamp;
-               wth->phdr.ts.tv_sec = wth->capture.netxray->start_time + (long)t;
-               wth->phdr.ts.tv_usec = (unsigned long)((t-(double)(unsigned long)(t))
-                       *1.0e6);
+               t /= netxray->ticks_per_sec;
+               t -= netxray->start_timestamp;
+               wth->phdr.ts.secs = netxray->start_time + (time_t)t;
+               wth->phdr.ts.nsecs = (int)((t-(double)(unsigned long)(t))
+                       *1.0e9);
                /*
                 * We subtract the padding from the packet size, so our caller
                 * doesn't see it.
@@ -709,9 +1041,9 @@ reread:
 }
 
 static gboolean
-netxray_seek_read(wtap *wth, long seek_off,
-    union wtap_pseudo_header *pseudo_header, guchar *pd, int length,
-    int *err, gchar **err_info _U_)
+netxray_seek_read(wtap *wth, gint64 seek_off,
+    union wtap_pseudo_header *pseudo_header, guint8 *pd, int length,
+    int *err, gchar **err_info)
 {
        union netxrayrec_hdr hdr;
        gboolean ret;
@@ -719,7 +1051,8 @@ netxray_seek_read(wtap *wth, long seek_off,
        if (file_seek(wth->random_fh, seek_off, SEEK_SET, err) == -1)
                return FALSE;
 
-       if (!netxray_read_rec_header(wth, wth->random_fh, &hdr, err)) {
+       if (!netxray_read_rec_header(wth, wth->random_fh, &hdr, err,
+           err_info)) {
                if (*err == 0) {
                        /*
                         * EOF - we report that as a short read, as
@@ -734,7 +1067,7 @@ netxray_seek_read(wtap *wth, long seek_off,
        /*
         * Read the packet data.
         */
-       ret = netxray_read_rec_data(wth->random_fh, pd, length, err);
+       ret = netxray_read_rec_data(wth->random_fh, pd, length, err, err_info);
        if (!ret)
                return FALSE;
 
@@ -747,13 +1080,14 @@ netxray_seek_read(wtap *wth, long seek_off,
 
 static int
 netxray_read_rec_header(wtap *wth, FILE_T fh, union netxrayrec_hdr *hdr,
-    int *err)
+    int *err, gchar **err_info)
 {
+       netxray_t *netxray = (netxray_t *)wth->priv;
        int     bytes_read;
        int     hdr_size = 0;
 
        /* Read record header. */
-       switch (wth->capture.netxray->version_major) {
+       switch (netxray->version_major) {
 
        case 0:
                hdr_size = sizeof (struct old_netxrayrec_hdr);
@@ -768,9 +1102,9 @@ netxray_read_rec_header(wtap *wth, FILE_T fh, union netxrayrec_hdr *hdr,
                break;
        }
        errno = WTAP_ERR_CANT_READ;
-       bytes_read = file_read(hdr, 1, hdr_size, fh);
+       bytes_read = file_read(hdr, hdr_size, fh);
        if (bytes_read != hdr_size) {
-               *err = file_error(wth->fh);
+               *err = file_error(wth->fh, err_info);
                if (*err != 0)
                        return 0;
                if (bytes_read != 0) {
@@ -791,13 +1125,14 @@ static guint
 netxray_set_pseudo_header(wtap *wth, const guint8 *pd, int len,
     union wtap_pseudo_header *pseudo_header, union netxrayrec_hdr *hdr)
 {
+       netxray_t *netxray = (netxray_t *)wth->priv;
        guint padding = 0;
 
        /*
         * If this is Ethernet, 802.11, ISDN, X.25, or ATM, set the
         * pseudo-header.
         */
-       switch (wth->capture.netxray->version_major) {
+       switch (netxray->version_major) {
 
        case 1:
                switch (wth->file_encap) {
@@ -841,7 +1176,7 @@ netxray_set_pseudo_header(wtap *wth, const guint8 *pd, int len,
                                 * We have 4 bytes of stuff at the
                                 * end of the frame - FCS, or junk?
                                 */
-                               if (wth->capture.netxray->fcs_valid) {
+                               if (netxray->fcs_valid) {
                                        /*
                                         * FCS.
                                         */
@@ -861,8 +1196,20 @@ netxray_set_pseudo_header(wtap *wth, const guint8 *pd, int len,
                         * It appears, in one 802.11 capture, that
                         * we have 4 bytes of junk at the ends of
                         * frames in which hdr->hdr_2_x.xxx[2] and
-                        * hdr->hdr_2_x.xxx[3] are 0xff; we assume
-                        * for now that it works like Ethernet.
+                        * hdr->hdr_2_x.xxx[3] are 0xff; I haven't
+                        * seen any frames where it's an FCS, but,
+                        * for now, we still check the fcs_valid
+                        * flag - I also haven't seen any capture
+                        * where we'd set it based on the realtick
+                        * value.
+                        *
+                        * It also appears that if the low-order bit of
+                        * hdr->hdr_2_x.xxx[8] is set, the packet has a
+                        * bad FCS.  According to Ken Mann, the 0x4 bit
+                        * is sometimes also set for errors.
+                        *
+                        * Ken also says that xxx[11] is 0x5 when the
+                        * packet is WEP-encrypted.
                         */
                        if (hdr->hdr_2_x.xxx[2] == 0xff &&
                            hdr->hdr_2_x.xxx[3] == 0xff) {
@@ -870,7 +1217,7 @@ netxray_set_pseudo_header(wtap *wth, const guint8 *pd, int len,
                                 * We have 4 bytes of stuff at the
                                 * end of the frame - FCS, or junk?
                                 */
-                               if (wth->capture.netxray->fcs_valid) {
+                               if (netxray->fcs_valid) {
                                        /*
                                         * FCS.
                                         */
@@ -890,6 +1237,12 @@ netxray_set_pseudo_header(wtap *wth, const guint8 *pd, int len,
                            hdr->hdr_2_x.xxx[13];
                        pseudo_header->ieee_802_11.signal_level =
                            hdr->hdr_2_x.xxx[14];
+                       /*
+                        * According to Ken Mann, at least in the captures
+                        * he's seen, xxx[15] is the noise level, which
+                        * is either 0xFF meaning "none reported" or a value
+                        * from 0x00 to 0x7F for 0 to 100%.
+                        */
                        break;
 
                case WTAP_ENCAP_ISDN:
@@ -908,7 +1261,7 @@ netxray_set_pseudo_header(wtap *wth, const guint8 *pd, int len,
                            (hdr->hdr_2_x.xxx[12] & 0x01);
                        pseudo_header->isdn.channel =
                            hdr->hdr_2_x.xxx[13] & 0x1F;
-                       switch (wth->capture.netxray->isdn_type) {
+                       switch (netxray->isdn_type) {
 
                        case 1:
                                /*
@@ -971,10 +1324,33 @@ netxray_set_pseudo_header(wtap *wth, const guint8 *pd, int len,
                         */
                        pseudo_header->x25.flags =
                            (hdr->hdr_2_x.xxx[12] & 0x01) ? 0x00 : FROM_DCE;
+
+                       /*
+                        * It appears, at least with version 2 captures,
+                        * that we have 4 bytes of stuff (which might be
+                        * a valid FCS or might be junk) at the end of
+                        * the packet if hdr->hdr_2_x.xxx[2] and
+                        * hdr->hdr_2_x.xxx[3] are 0xff, and we don't if
+                        * they don't.
+                        *
+                        * XXX - does the low-order bit of hdr->hdr_2_x.xxx[8]
+                        * indicate a bad FCS, as is the case with
+                        * Ethernet?
+                        */
+                       if (hdr->hdr_2_x.xxx[2] == 0xff &&
+                           hdr->hdr_2_x.xxx[3] == 0xff) {
+                               /*
+                                * FCS, or junk, at the end.
+                                * XXX - is it an FCS if "fcs_valid" is
+                                * true?
+                                */
+                               padding = 4;
+                       }
                        break;
 
                case WTAP_ENCAP_PPP_WITH_PHDR:
                case WTAP_ENCAP_SDLC:
+               case WTAP_ENCAP_CHDLC_WITH_PHDR:
                        pseudo_header->p2p.sent =
                            (hdr->hdr_2_x.xxx[12] & 0x01) ? TRUE : FALSE;
                        break;
@@ -1070,15 +1446,15 @@ netxray_set_pseudo_header(wtap *wth, const guint8 *pd, int len,
 
 static gboolean
 netxray_read_rec_data(FILE_T fh, guint8 *data_ptr, guint32 packet_size,
-    int *err)
+    int *err, gchar **err_info)
 {
        int     bytes_read;
 
        errno = WTAP_ERR_CANT_READ;
-       bytes_read = file_read(data_ptr, 1, packet_size, fh);
+       bytes_read = file_read(data_ptr, packet_size, fh);
 
        if (bytes_read <= 0 || (guint32)bytes_read != packet_size) {
-               *err = file_error(fh);
+               *err = file_error(fh, err_info);
                if (*err == 0)
                        *err = WTAP_ERR_SHORT_READ;
                return FALSE;
@@ -1086,423 +1462,365 @@ netxray_read_rec_data(FILE_T fh, guint8 *data_ptr, guint32 packet_size,
        return TRUE;
 }
 
-static void
-netxray_close(wtap *wth)
-{
-       g_free(wth->capture.netxray);
-}
+typedef struct {
+       gboolean first_frame;
+       struct wtap_nstime start;
+       guint32 nframes;
+} netxray_dump_t;
 
 static const struct {
        int     wtap_encap_value;
        int     ndis_value;
 } wtap_encap_1_1[] = {
-    { WTAP_ENCAP_ETHERNET, 0 },                /* -> NDIS Ethernet */
-    { WTAP_ENCAP_TOKEN_RING, 1 },      /* -> NDIS Token Ring */
-    { WTAP_ENCAP_FDDI, 2 },            /* -> NDIS FDDI */
-    { WTAP_ENCAP_FDDI_BITSWAPPED, 2 }, /* -> NDIS FDDI */
+       { WTAP_ENCAP_ETHERNET, 0 },             /* -> NDIS Ethernet */
+       { WTAP_ENCAP_TOKEN_RING, 1 },           /* -> NDIS Token Ring */
+       { WTAP_ENCAP_FDDI, 2 },                 /* -> NDIS FDDI */
+       { WTAP_ENCAP_FDDI_BITSWAPPED, 2 },      /* -> NDIS FDDI */
 };
 #define NUM_WTAP_ENCAPS_1_1 (sizeof wtap_encap_1_1 / sizeof wtap_encap_1_1[0])
 
 static int
 wtap_encap_to_netxray_1_1_encap(int encap)
 {
-    unsigned int i;
+       unsigned int i;
 
-    for (i = 0; i < NUM_WTAP_ENCAPS_1_1; i++) {
-       if (encap == wtap_encap_1_1[i].wtap_encap_value)
-           return wtap_encap_1_1[i].ndis_value;
-    }
+       for (i = 0; i < NUM_WTAP_ENCAPS_1_1; i++) {
+               if (encap == wtap_encap_1_1[i].wtap_encap_value)
+                       return wtap_encap_1_1[i].ndis_value;
+       }
 
-    return -1;
+       return -1;
 }
 
 /* Returns 0 if we could write the specified encapsulation type,
    an error indication otherwise. */
 int netxray_dump_can_write_encap_1_1(int encap)
 {
-    /* Per-packet encapsulations aren't supported. */
-    if (encap == WTAP_ENCAP_PER_PACKET)
-       return WTAP_ERR_ENCAP_PER_PACKET_UNSUPPORTED;
+       /* Per-packet encapsulations aren't supported. */
+       if (encap == WTAP_ENCAP_PER_PACKET)
+               return WTAP_ERR_ENCAP_PER_PACKET_UNSUPPORTED;
 
-    if (wtap_encap_to_netxray_1_1_encap(encap) == -1)
-       return WTAP_ERR_UNSUPPORTED_ENCAP;
+       if (wtap_encap_to_netxray_1_1_encap(encap) == -1)
+               return WTAP_ERR_UNSUPPORTED_ENCAP;
 
-    return 0;
+       return 0;
 }
 
 /* Returns TRUE on success, FALSE on failure; sets "*err" to an error code on
    failure */
-gboolean netxray_dump_open_1_1(wtap_dumper *wdh, gboolean cant_seek, int *err)
+gboolean netxray_dump_open_1_1(wtap_dumper *wdh, int *err)
 {
-    /* This is a NetXRay file.  We can't fill in some fields in the header
-       until all the packets have been written, so we can't write to a
-       pipe. */
-    if (cant_seek) {
-       *err = WTAP_ERR_CANT_WRITE_TO_PIPE;
-       return FALSE;
-    }
-
-    wdh->subtype_write = netxray_dump_1_1;
-    wdh->subtype_close = netxray_dump_close_1_1;
-
-    /* We can't fill in all the fields in the file header, as we
-       haven't yet written any packets.  As we'll have to rewrite
-       the header when we've written out all the packets, we just
-       skip over the header for now. */
-    if (fseek(wdh->fh, CAPTUREFILE_HEADER_SIZE, SEEK_SET) == -1) {
-       *err = errno;
-       return FALSE;
-    }
-
-    wdh->dump.netxray = g_malloc(sizeof(netxray_dump_t));
-    wdh->dump.netxray->first_frame = TRUE;
-    wdh->dump.netxray->start.tv_sec = 0;
-    wdh->dump.netxray->start.tv_usec = 0;
-    wdh->dump.netxray->nframes = 0;
-
-    return TRUE;
+       netxray_dump_t *netxray;
+
+       wdh->subtype_write = netxray_dump_1_1;
+       wdh->subtype_close = netxray_dump_close_1_1;
+
+       /* We can't fill in all the fields in the file header, as we
+          haven't yet written any packets.  As we'll have to rewrite
+          the header when we've written out all the packets, we just
+          skip over the header for now. */
+       if (fseek(wdh->fh, CAPTUREFILE_HEADER_SIZE, SEEK_SET) == -1) {
+               *err = errno;
+               return FALSE;
+       }
+       wdh->bytes_dumped += CAPTUREFILE_HEADER_SIZE;
+
+       netxray = (netxray_dump_t *)g_malloc(sizeof(netxray_dump_t));
+       wdh->priv = (void *)netxray;
+       netxray->first_frame = TRUE;
+       netxray->start.secs = 0;
+       netxray->start.nsecs = 0;
+       netxray->nframes = 0;
+
+       return TRUE;
 }
 
 /* Write a record for a packet to a dump file.
    Returns TRUE on success, FALSE on failure. */
 static gboolean netxray_dump_1_1(wtap_dumper *wdh,
-       const struct wtap_pkthdr *phdr,
-       const union wtap_pseudo_header *pseudo_header _U_,
-       const guchar *pd, int *err)
+                                const struct wtap_pkthdr *phdr,
+                                const union wtap_pseudo_header *pseudo_header _U_,
+                                const guint8 *pd, int *err)
 {
-    netxray_dump_t *netxray = wdh->dump.netxray;
-    guint32 timestamp;
-    struct netxrayrec_1_x_hdr rec_hdr;
-    size_t nwritten;
-
-    /* NetXRay/Windows Sniffer files have a capture start date/time
-       in the header, in a UNIX-style format, with one-second resolution,
-       and a start time stamp with microsecond resolution that's just
-       an arbitrary time stamp relative to some unknown time (boot
-       time?), and have times relative to the start time stamp in
-       the packet headers; pick the seconds value of the time stamp
-       of the first packet as the UNIX-style start date/time, and make
-       the high-resolution start time stamp 0, with the time stamp of
-       packets being the delta between the stamp of the packet and
-       the stamp of the first packet with the microseconds part 0. */
-    if (netxray->first_frame) {
-       netxray->first_frame = FALSE;
-       netxray->start = phdr->ts;
-    }
-
-    /* build the header for each packet */
-    memset(&rec_hdr, '\0', sizeof(rec_hdr));
-    timestamp = (phdr->ts.tv_sec - netxray->start.tv_sec)*1000000 +
-        phdr->ts.tv_usec;
-    rec_hdr.timelo = htolel(timestamp);
-    rec_hdr.timehi = htolel(0);
-    rec_hdr.orig_len = htoles(phdr->len);
-    rec_hdr.incl_len = htoles(phdr->caplen);
-
-    nwritten = fwrite(&rec_hdr, 1, sizeof(rec_hdr), wdh->fh);
-    if (nwritten != sizeof(rec_hdr)) {
-       if (nwritten == 0 && ferror(wdh->fh))
-           *err = errno;
-       else
-           *err = WTAP_ERR_SHORT_WRITE;
-       return FALSE;
-    }
-
-    /* write the packet data */
-    nwritten = fwrite(pd, 1, phdr->caplen, wdh->fh);
-    if (nwritten != phdr->caplen) {
-       if (nwritten == 0 && ferror(wdh->fh))
-           *err = errno;
-       else
-           *err = WTAP_ERR_SHORT_WRITE;
-       return FALSE;
-    }
+       netxray_dump_t *netxray = (netxray_dump_t *)wdh->priv;
+       guint64 timestamp;
+       guint32 t32;
+       struct netxrayrec_1_x_hdr rec_hdr;
+
+       /* NetXRay/Windows Sniffer files have a capture start date/time
+          in the header, in a UNIX-style format, with one-second resolution,
+          and a start time stamp with microsecond resolution that's just
+          an arbitrary time stamp relative to some unknown time (boot
+          time?), and have times relative to the start time stamp in
+          the packet headers; pick the seconds value of the time stamp
+          of the first packet as the UNIX-style start date/time, and make
+          the high-resolution start time stamp 0, with the time stamp of
+          packets being the delta between the stamp of the packet and
+          the stamp of the first packet with the microseconds part 0. */
+       if (netxray->first_frame) {
+               netxray->first_frame = FALSE;
+               netxray->start = phdr->ts;
+       }
+
+       /* build the header for each packet */
+       memset(&rec_hdr, '\0', sizeof(rec_hdr));
+       timestamp = ((guint64)phdr->ts.secs - (guint64)netxray->start.secs)*1000000
+               + ((guint64)phdr->ts.nsecs)/1000;
+       t32 = (guint32)(timestamp%G_GINT64_CONSTANT(4294967296));
+       rec_hdr.timelo = htolel(t32);
+       t32 = (guint32)(timestamp/G_GINT64_CONSTANT(4294967296));
+       rec_hdr.timehi = htolel(t32);
+       rec_hdr.orig_len = htoles(phdr->len);
+       rec_hdr.incl_len = htoles(phdr->caplen);
+
+       if (!wtap_dump_file_write(wdh, &rec_hdr, sizeof(rec_hdr), err))
+               return FALSE;
+       wdh->bytes_dumped += sizeof(rec_hdr);
+
+       /* write the packet data */
+       if (!wtap_dump_file_write(wdh, pd, phdr->caplen, err))
+               return FALSE;
+       wdh->bytes_dumped += phdr->caplen;
 
-    netxray->nframes++;
+       netxray->nframes++;
 
-    return TRUE;
+       return TRUE;
 }
 
 /* Finish writing to a dump file.
    Returns TRUE on success, FALSE on failure. */
 static gboolean netxray_dump_close_1_1(wtap_dumper *wdh, int *err)
 {
-    char hdr_buf[CAPTUREFILE_HEADER_SIZE - sizeof(netxray_magic)];
-    netxray_dump_t *netxray = wdh->dump.netxray;
-    guint32 filelen;
-    struct netxray_hdr file_hdr;
-    size_t nwritten;
-
-    filelen = ftell(wdh->fh);
-
-    /* Go back to beginning */
-    fseek(wdh->fh, 0, SEEK_SET);
-
-    /* Rewrite the file header. */
-    nwritten = fwrite(netxray_magic, 1, sizeof netxray_magic, wdh->fh);
-    if (nwritten != sizeof netxray_magic) {
-       if (err != NULL) {
-           if (nwritten == 0 && ferror(wdh->fh))
-               *err = errno;
-           else
-               *err = WTAP_ERR_SHORT_WRITE;
-       }
-       return FALSE;
-    }
-
-    /* "sniffer" version ? */
-    memset(&file_hdr, '\0', sizeof file_hdr);
-    memcpy(file_hdr.version, vers_1_1, sizeof vers_1_1);
-    file_hdr.start_time = htolel(netxray->start.tv_sec);
-    file_hdr.nframes = htolel(netxray->nframes);
-    file_hdr.start_offset = htolel(CAPTUREFILE_HEADER_SIZE);
-    file_hdr.end_offset = htolel(filelen);
-    file_hdr.network = wtap_encap_to_netxray_1_1_encap(wdh->encap);
-    file_hdr.timelo = htolel(0);
-    file_hdr.timehi = htolel(0);
-
-    memset(hdr_buf, '\0', sizeof hdr_buf);
-    memcpy(hdr_buf, &file_hdr, sizeof(file_hdr));
-    nwritten = fwrite(hdr_buf, 1, sizeof hdr_buf, wdh->fh);
-    if (nwritten != sizeof hdr_buf) {
-       if (err != NULL) {
-           if (nwritten == 0 && ferror(wdh->fh))
-               *err = errno;
-           else
-               *err = WTAP_ERR_SHORT_WRITE;
-       }
-       return FALSE;
-    }
+       char hdr_buf[CAPTUREFILE_HEADER_SIZE - sizeof(netxray_magic)];
+       netxray_dump_t *netxray = (netxray_dump_t *)wdh->priv;
+       guint32 filelen;
+       struct netxray_hdr file_hdr;
+
+       filelen = (guint32)ftell(wdh->fh);      /* XXX - large files? */
 
-    return TRUE;
+       /* Go back to beginning */
+       fseek(wdh->fh, 0, SEEK_SET);
+
+       /* Rewrite the file header. */
+       if (!wtap_dump_file_write(wdh, netxray_magic, sizeof netxray_magic, err))
+               return FALSE;
+
+       /* "sniffer" version ? */
+       memset(&file_hdr, '\0', sizeof file_hdr);
+       memcpy(file_hdr.version, vers_1_1, sizeof vers_1_1);
+       file_hdr.start_time = htolel(netxray->start.secs);
+       file_hdr.nframes = htolel(netxray->nframes);
+       file_hdr.start_offset = htolel(CAPTUREFILE_HEADER_SIZE);
+       file_hdr.end_offset = htolel(filelen);
+       file_hdr.network = wtap_encap_to_netxray_1_1_encap(wdh->encap);
+       file_hdr.timelo = htolel(0);
+       file_hdr.timehi = htolel(0);
+
+       memset(hdr_buf, '\0', sizeof hdr_buf);
+       memcpy(hdr_buf, &file_hdr, sizeof(file_hdr));
+       if (!wtap_dump_file_write(wdh, hdr_buf, sizeof hdr_buf, err))
+               return FALSE;
+
+       return TRUE;
 }
 
 static const struct {
        int     wtap_encap_value;
        int     ndis_value;
 } wtap_encap_2_0[] = {
-    { WTAP_ENCAP_ETHERNET, 0 },                        /* -> NDIS Ethernet */
-    { WTAP_ENCAP_TOKEN_RING, 1 },              /* -> NDIS Token Ring */
-    { WTAP_ENCAP_FDDI, 2 },                    /* -> NDIS FDDI */
-    { WTAP_ENCAP_FDDI_BITSWAPPED, 2 },         /* -> NDIS FDDI */
-    { WTAP_ENCAP_PPP_WITH_PHDR, 3 },           /* -> NDIS WAN */
-    { WTAP_ENCAP_FRELAY_WITH_PHDR, 3 },                /* -> NDIS WAN */
-    { WTAP_ENCAP_LAPB, 3 },                    /* -> NDIS WAN */
-    { WTAP_ENCAP_SDLC, 3 },                    /* -> NDIS WAN */
+       { WTAP_ENCAP_ETHERNET, 0 },                     /* -> NDIS Ethernet */
+       { WTAP_ENCAP_TOKEN_RING, 1 },           /* -> NDIS Token Ring */
+       { WTAP_ENCAP_FDDI, 2 },                 /* -> NDIS FDDI */
+       { WTAP_ENCAP_FDDI_BITSWAPPED, 2 },              /* -> NDIS FDDI */
+       { WTAP_ENCAP_PPP_WITH_PHDR, 3 },                /* -> NDIS WAN */
+       { WTAP_ENCAP_FRELAY_WITH_PHDR, 3 },             /* -> NDIS WAN */
+       { WTAP_ENCAP_LAPB, 3 },                 /* -> NDIS WAN */
+       { WTAP_ENCAP_SDLC, 3 },                 /* -> NDIS WAN */
 };
 #define NUM_WTAP_ENCAPS_2_0 (sizeof wtap_encap_2_0 / sizeof wtap_encap_2_0[0])
 
 static int
 wtap_encap_to_netxray_2_0_encap(int encap)
 {
-    unsigned int i;
+       unsigned int i;
 
-    for (i = 0; i < NUM_WTAP_ENCAPS_2_0; i++) {
-       if (encap == wtap_encap_2_0[i].wtap_encap_value)
-           return wtap_encap_2_0[i].ndis_value;
-    }
+       for (i = 0; i < NUM_WTAP_ENCAPS_2_0; i++) {
+               if (encap == wtap_encap_2_0[i].wtap_encap_value)
+                       return wtap_encap_2_0[i].ndis_value;
+       }
 
-    return -1;
+       return -1;
 }
 
 /* Returns 0 if we could write the specified encapsulation type,
    an error indication otherwise. */
 int netxray_dump_can_write_encap_2_0(int encap)
 {
-    /* Per-packet encapsulations aren't supported. */
-    if (encap == WTAP_ENCAP_PER_PACKET)
-       return WTAP_ERR_ENCAP_PER_PACKET_UNSUPPORTED;
+       /* Per-packet encapsulations aren't supported. */
+       if (encap == WTAP_ENCAP_PER_PACKET)
+               return WTAP_ERR_ENCAP_PER_PACKET_UNSUPPORTED;
 
-    if (wtap_encap_to_netxray_2_0_encap(encap) == -1)
-       return WTAP_ERR_UNSUPPORTED_ENCAP;
+       if (wtap_encap_to_netxray_2_0_encap(encap) == -1)
+               return WTAP_ERR_UNSUPPORTED_ENCAP;
 
-    return 0;
+       return 0;
 }
 
 /* Returns TRUE on success, FALSE on failure; sets "*err" to an error code on
    failure */
-gboolean netxray_dump_open_2_0(wtap_dumper *wdh, gboolean cant_seek, int *err)
+gboolean netxray_dump_open_2_0(wtap_dumper *wdh, int *err)
 {
-    /* This is a NetXRay file.  We can't fill in some fields in the header
-       until all the packets have been written, so we can't write to a
-       pipe. */
-    if (cant_seek) {
-       *err = WTAP_ERR_CANT_WRITE_TO_PIPE;
-       return FALSE;
-    }
-
-    wdh->subtype_write = netxray_dump_2_0;
-    wdh->subtype_close = netxray_dump_close_2_0;
-
-    /* We can't fill in all the fields in the file header, as we
-       haven't yet written any packets.  As we'll have to rewrite
-       the header when we've written out all the packets, we just
-       skip over the header for now. */
-    if (fseek(wdh->fh, CAPTUREFILE_HEADER_SIZE, SEEK_SET) == -1) {
-       *err = errno;
-       return FALSE;
-    }
-
-    wdh->dump.netxray = g_malloc(sizeof(netxray_dump_t));
-    wdh->dump.netxray->first_frame = TRUE;
-    wdh->dump.netxray->start.tv_sec = 0;
-    wdh->dump.netxray->start.tv_usec = 0;
-    wdh->dump.netxray->nframes = 0;
-
-    return TRUE;
+       netxray_dump_t *netxray;
+
+       wdh->subtype_write = netxray_dump_2_0;
+       wdh->subtype_close = netxray_dump_close_2_0;
+
+       /* We can't fill in all the fields in the file header, as we
+          haven't yet written any packets.  As we'll have to rewrite
+          the header when we've written out all the packets, we just
+          skip over the header for now. */
+       if (fseek(wdh->fh, CAPTUREFILE_HEADER_SIZE, SEEK_SET) == -1) {
+               *err = errno;
+               return FALSE;
+       }
+       wdh->bytes_dumped += CAPTUREFILE_HEADER_SIZE;
+
+       netxray = (netxray_dump_t *)g_malloc(sizeof(netxray_dump_t));
+       wdh->priv = (void *)netxray;
+       netxray->first_frame = TRUE;
+       netxray->start.secs = 0;
+       netxray->start.nsecs = 0;
+       netxray->nframes = 0;
+
+       return TRUE;
 }
 
 /* Write a record for a packet to a dump file.
    Returns TRUE on success, FALSE on failure. */
 static gboolean netxray_dump_2_0(wtap_dumper *wdh,
-       const struct wtap_pkthdr *phdr,
-       const union wtap_pseudo_header *pseudo_header _U_,
-       const guchar *pd, int *err)
+                                const struct wtap_pkthdr *phdr,
+                                const union wtap_pseudo_header *pseudo_header _U_,
+                                const guint8 *pd, int *err)
 {
-    netxray_dump_t *netxray = wdh->dump.netxray;
-    guint32 timestamp;
-    struct netxrayrec_2_x_hdr rec_hdr;
-    size_t nwritten;
-
-    /* NetXRay/Windows Sniffer files have a capture start date/time
-       in the header, in a UNIX-style format, with one-second resolution,
-       and a start time stamp with microsecond resolution that's just
-       an arbitrary time stamp relative to some unknown time (boot
-       time?), and have times relative to the start time stamp in
-       the packet headers; pick the seconds value of the time stamp
-       of the first packet as the UNIX-style start date/time, and make
-       the high-resolution start time stamp 0, with the time stamp of
-       packets being the delta between the stamp of the packet and
-       the stamp of the first packet with the microseconds part 0. */
-    if (netxray->first_frame) {
-       netxray->first_frame = FALSE;
-       netxray->start = phdr->ts;
-    }
-
-    /* build the header for each packet */
-    memset(&rec_hdr, '\0', sizeof(rec_hdr));
-    timestamp = (phdr->ts.tv_sec - netxray->start.tv_sec)*1000000 +
-        phdr->ts.tv_usec;
-    rec_hdr.timelo = htolel(timestamp);
-    rec_hdr.timehi = htolel(0);
-    rec_hdr.orig_len = htoles(phdr->len);
-    rec_hdr.incl_len = htoles(phdr->caplen);
-
-    switch (phdr->pkt_encap) {
-
-    case WTAP_ENCAP_IEEE_802_11_WITH_RADIO:
-       rec_hdr.xxx[12] = pseudo_header->ieee_802_11.channel;
-       rec_hdr.xxx[13] = pseudo_header->ieee_802_11.data_rate;
-       rec_hdr.xxx[14] = pseudo_header->ieee_802_11.signal_level;
-       break;
-
-    case WTAP_ENCAP_PPP_WITH_PHDR:
-    case WTAP_ENCAP_SDLC:
-       rec_hdr.xxx[12] |= pseudo_header->p2p.sent ? 0x01 : 0x00;
-       break;
-
-    case WTAP_ENCAP_FRELAY_WITH_PHDR:
-       rec_hdr.xxx[12] |= (pseudo_header->x25.flags & FROM_DCE) ? 0x00 : 0x01;
-       break;
-    }
-
-    nwritten = fwrite(&rec_hdr, 1, sizeof(rec_hdr), wdh->fh);
-    if (nwritten != sizeof(rec_hdr)) {
-       if (nwritten == 0 && ferror(wdh->fh))
-           *err = errno;
-       else
-           *err = WTAP_ERR_SHORT_WRITE;
-       return FALSE;
-    }
-
-    /* write the packet data */
-    nwritten = fwrite(pd, 1, phdr->caplen, wdh->fh);
-    if (nwritten != phdr->caplen) {
-       if (nwritten == 0 && ferror(wdh->fh))
-           *err = errno;
-       else
-           *err = WTAP_ERR_SHORT_WRITE;
-       return FALSE;
-    }
+       netxray_dump_t *netxray = (netxray_dump_t *)wdh->priv;
+       guint64 timestamp;
+       guint32 t32;
+       struct netxrayrec_2_x_hdr rec_hdr;
+
+       /* NetXRay/Windows Sniffer files have a capture start date/time
+          in the header, in a UNIX-style format, with one-second resolution,
+          and a start time stamp with microsecond resolution that's just
+          an arbitrary time stamp relative to some unknown time (boot
+          time?), and have times relative to the start time stamp in
+          the packet headers; pick the seconds value of the time stamp
+          of the first packet as the UNIX-style start date/time, and make
+          the high-resolution start time stamp 0, with the time stamp of
+          packets being the delta between the stamp of the packet and
+          the stamp of the first packet with the microseconds part 0. */
+       if (netxray->first_frame) {
+               netxray->first_frame = FALSE;
+               netxray->start = phdr->ts;
+       }
+
+       /* build the header for each packet */
+       memset(&rec_hdr, '\0', sizeof(rec_hdr));
+       timestamp = ((guint64)phdr->ts.secs - (guint64)netxray->start.secs)*1000000
+               + ((guint64)phdr->ts.nsecs)/1000;
+       t32 = (guint32)(timestamp%G_GINT64_CONSTANT(4294967296));
+       rec_hdr.timelo = htolel(t32);
+       t32 = (guint32)(timestamp/G_GINT64_CONSTANT(4294967296));
+       rec_hdr.timehi = htolel(t32);
+       rec_hdr.orig_len = htoles(phdr->len);
+       rec_hdr.incl_len = htoles(phdr->caplen);
+
+       switch (phdr->pkt_encap) {
+
+       case WTAP_ENCAP_IEEE_802_11_WITH_RADIO:
+               rec_hdr.xxx[12] = pseudo_header->ieee_802_11.channel;
+               rec_hdr.xxx[13] = pseudo_header->ieee_802_11.data_rate;
+               rec_hdr.xxx[14] = pseudo_header->ieee_802_11.signal_level;
+               break;
+
+       case WTAP_ENCAP_PPP_WITH_PHDR:
+       case WTAP_ENCAP_SDLC:
+               rec_hdr.xxx[12] |= pseudo_header->p2p.sent ? 0x01 : 0x00;
+               break;
+
+       case WTAP_ENCAP_FRELAY_WITH_PHDR:
+               rec_hdr.xxx[12] |= (pseudo_header->x25.flags & FROM_DCE) ? 0x00 : 0x01;
+               break;
+       }
+
+       if (!wtap_dump_file_write(wdh, &rec_hdr, sizeof(rec_hdr), err))
+               return FALSE;
+       wdh->bytes_dumped += sizeof(rec_hdr);
 
-    netxray->nframes++;
+       /* write the packet data */
+       if (!wtap_dump_file_write(wdh, pd, phdr->caplen, err))
+               return FALSE;
+       wdh->bytes_dumped += phdr->caplen;
+
+       netxray->nframes++;
 
-    return TRUE;
+       return TRUE;
 }
 
 /* Finish writing to a dump file.
    Returns TRUE on success, FALSE on failure. */
 static gboolean netxray_dump_close_2_0(wtap_dumper *wdh, int *err)
 {
-    char hdr_buf[CAPTUREFILE_HEADER_SIZE - sizeof(netxray_magic)];
-    netxray_dump_t *netxray = wdh->dump.netxray;
-    guint32 filelen;
-    struct netxray_hdr file_hdr;
-    size_t nwritten;
-
-    filelen = ftell(wdh->fh);
-
-    /* Go back to beginning */
-    fseek(wdh->fh, 0, SEEK_SET);
-
-    /* Rewrite the file header. */
-    nwritten = fwrite(netxray_magic, 1, sizeof netxray_magic, wdh->fh);
-    if (nwritten != sizeof netxray_magic) {
-       if (err != NULL) {
-           if (nwritten == 0 && ferror(wdh->fh))
-               *err = errno;
-           else
-               *err = WTAP_ERR_SHORT_WRITE;
-       }
-       return FALSE;
-    }
-
-    /* "sniffer" version ? */
-    memset(&file_hdr, '\0', sizeof file_hdr);
-    memcpy(file_hdr.version, vers_2_001, sizeof vers_2_001);
-    file_hdr.start_time = htolel(netxray->start.tv_sec);
-    file_hdr.nframes = htolel(netxray->nframes);
-    file_hdr.start_offset = htolel(CAPTUREFILE_HEADER_SIZE);
-    file_hdr.end_offset = htolel(filelen);
-    file_hdr.network = wtap_encap_to_netxray_2_0_encap(wdh->encap);
-    file_hdr.timelo = htolel(0);
-    file_hdr.timehi = htolel(0);
-    switch (wdh->encap) {
-
-    case WTAP_ENCAP_PPP_WITH_PHDR:
-       file_hdr.xxc[4] = WAN_CAPTYPE_PPP;
-       break;
-
-    case WTAP_ENCAP_FRELAY_WITH_PHDR:
-       file_hdr.xxc[4] = WAN_CAPTYPE_FRELAY;
-       break;
-
-    case WTAP_ENCAP_LAPB:
-       file_hdr.xxc[4] = WAN_CAPTYPE_HDLC;
-       file_hdr.xxc[12] = 0;
-       break;
-
-    case WTAP_ENCAP_SDLC:
-       file_hdr.xxc[4] = WAN_CAPTYPE_SDLC;
-       break;
-
-    default:
-       file_hdr.xxc[4] = CAPTYPE_NDIS;
-       break;
-    }
-
-    memset(hdr_buf, '\0', sizeof hdr_buf);
-    memcpy(hdr_buf, &file_hdr, sizeof(file_hdr));
-    nwritten = fwrite(hdr_buf, 1, sizeof hdr_buf, wdh->fh);
-    if (nwritten != sizeof hdr_buf) {
-       if (err != NULL) {
-           if (nwritten == 0 && ferror(wdh->fh))
-               *err = errno;
-           else
-               *err = WTAP_ERR_SHORT_WRITE;
+       char hdr_buf[CAPTUREFILE_HEADER_SIZE - sizeof(netxray_magic)];
+       netxray_dump_t *netxray = (netxray_dump_t *)wdh->priv;
+       guint32 filelen;
+       struct netxray_hdr file_hdr;
+
+       filelen = (guint32)ftell(wdh->fh);      /* XXX - large files? */
+
+       /* Go back to beginning */
+       fseek(wdh->fh, 0, SEEK_SET);
+
+       /* Rewrite the file header. */
+       if (!wtap_dump_file_write(wdh, netxray_magic, sizeof netxray_magic, err))
+               return FALSE;
+
+       /* "sniffer" version ? */
+       memset(&file_hdr, '\0', sizeof file_hdr);
+       memcpy(file_hdr.version, vers_2_001, sizeof vers_2_001);
+       file_hdr.start_time = htolel(netxray->start.secs);
+       file_hdr.nframes = htolel(netxray->nframes);
+       file_hdr.start_offset = htolel(CAPTUREFILE_HEADER_SIZE);
+       file_hdr.end_offset = htolel(filelen);
+       file_hdr.network = wtap_encap_to_netxray_2_0_encap(wdh->encap);
+       file_hdr.timelo = htolel(0);
+       file_hdr.timehi = htolel(0);
+       switch (wdh->encap) {
+
+       case WTAP_ENCAP_PPP_WITH_PHDR:
+               file_hdr.captype = WAN_CAPTYPE_PPP;
+               break;
+
+       case WTAP_ENCAP_FRELAY_WITH_PHDR:
+               file_hdr.captype = WAN_CAPTYPE_FRELAY;
+               break;
+
+       case WTAP_ENCAP_LAPB:
+               file_hdr.captype = WAN_CAPTYPE_HDLC;
+               file_hdr.wan_hdlc_subsub_captype = 0;
+               break;
+
+       case WTAP_ENCAP_SDLC:
+               file_hdr.captype = WAN_CAPTYPE_SDLC;
+               break;
+
+       default:
+               file_hdr.captype = CAPTYPE_NDIS;
+               break;
        }
-       return FALSE;
-    }
 
-    return TRUE;
+       memset(hdr_buf, '\0', sizeof hdr_buf);
+       memcpy(hdr_buf, &file_hdr, sizeof(file_hdr));
+       if (!wtap_dump_file_write(wdh, hdr_buf, sizeof hdr_buf, err))
+               return FALSE;
+
+       return TRUE;
 }