/* packet-isis-lsp.c
* Routines for decoding isis lsp packets and their CLVs
*
- * $Id: packet-isis-lsp.c,v 1.36 2002/09/02 22:10:15 guy Exp $
+ * $Id: packet-isis-lsp.c,v 1.44 2003/05/28 22:39:14 guy Exp $
* Stuart Stanley <stuarts@mxmail.net>
*
* Ethereal - Network traffic analyzer
static int hf_isis_lsp_remaining_life = -1;
static int hf_isis_lsp_sequence_number = -1;
static int hf_isis_lsp_checksum = -1;
+static int hf_isis_lsp_checksum_bad = -1;
static int hf_isis_lsp_clv_ipv4_int_addr = -1;
static int hf_isis_lsp_clv_ipv6_int_addr = -1;
static int hf_isis_lsp_clv_te_router_id = -1;
static int hf_isis_lsp_clv_mt = -1;
+static int hf_isis_lsp_p = -1;
+static int hf_isis_lsp_att = -1;
+static int hf_isis_lsp_hippity = -1;
+static int hf_isis_lsp_is_type = -1;
static gint ett_isis_lsp = -1;
+static gint ett_isis_lsp_info = -1;
+static gint ett_isis_lsp_att = -1;
static gint ett_isis_lsp_clv_area_addr = -1;
static gint ett_isis_lsp_clv_is_neighbors = -1;
static gint ett_isis_lsp_clv_ext_is_reachability = -1; /* CLV 22 */
- static gint ett_isis_lsp_part_of_clv_ext_is_reachability = -1;
- static gint ett_isis_lsp_subclv_admin_group = -1;
- static gint ett_isis_lsp_subclv_unrsv_bw = -1;
+static gint ett_isis_lsp_part_of_clv_ext_is_reachability = -1;
+static gint ett_isis_lsp_subclv_admin_group = -1;
+static gint ett_isis_lsp_subclv_unrsv_bw = -1;
static gint ett_isis_lsp_clv_unknown = -1;
static gint ett_isis_lsp_clv_partition_dis = -1;
static gint ett_isis_lsp_clv_prefix_neighbors = -1;
static gint ett_isis_lsp_clv_ipv4_int_addr = -1;
static gint ett_isis_lsp_clv_ipv6_int_addr = -1; /* CLV 232 */
static gint ett_isis_lsp_clv_ip_reachability = -1;
+static gint ett_isis_lsp_clv_ip_reach_subclv = -1;
static gint ett_isis_lsp_clv_ext_ip_reachability = -1; /* CLV 135 */
- static gint ett_isis_lsp_part_of_clv_ext_ip_reachability = -1;
+static gint ett_isis_lsp_part_of_clv_ext_ip_reachability = -1;
static gint ett_isis_lsp_clv_ipv6_reachability = -1; /* CLV 236 */
- static gint ett_isis_lsp_part_of_clv_ipv6_reachability = -1;
+static gint ett_isis_lsp_part_of_clv_ipv6_reachability = -1;
static gint ett_isis_lsp_clv_mt = -1;
static gint ett_isis_lsp_clv_mt_is = -1;
static gint ett_isis_lsp_part_of_clv_mt_is = -1;
-
-static const char *isis_lsp_attached_bits[] = {
- "error", "expense", "delay", "default" };
+static gint ett_isis_lsp_clv_mt_reachable_IPv4_prefx = -1; /* CLV 235 */
+static gint ett_isis_lsp_clv_mt_reachable_IPv6_prefx = -1; /* CLV 237 */
static const value_string isis_lsp_istype_vals[] = {
{ ISIS_LSP_TYPE_UNUSED0, "Unused 0x0 (invalid)"},
- { ISIS_LSP_TYPE_LEVEL_1, "Level 1 IS"},
+ { ISIS_LSP_TYPE_LEVEL_1, "Level 1"},
{ ISIS_LSP_TYPE_UNUSED2, "Unused 0x2 (invalid)"},
- { ISIS_LSP_TYPE_LEVEL_2, "Level 1 and Level 2 IS"},
+ { ISIS_LSP_TYPE_LEVEL_2, "Level 2"},
{ 0, NULL } };
+static const true_false_string supported_string = {
+ "Supported",
+ "Unsupported"
+ };
+
+static const true_false_string hippity_string = {
+ "Set",
+ "Unset"
+ };
+
+
/*
* Predclare dissectors for use in clv dissection.
*/
proto_tree *tree, int offset, int id_length, int length);
static void dissect_lsp_ip_reachability_clv(tvbuff_t *tvb,
proto_tree *tree, int offset, int id_length, int length);
-
+static void dissect_ipreach_subclv(tvbuff_t *tvb,
+ proto_tree *tree, int offset, int clv_code, int clv_len);
+static void dissect_lsp_mt_reachable_IPv4_prefx_clv(tvbuff_t *tvb,
+ proto_tree *tree, int offset, int id_length, int length);
+static void dissect_lsp_mt_reachable_IPv6_prefx_clv(tvbuff_t *tvb,
+ proto_tree *tree, int offset, int id_length, int length);
static const isis_clv_handle_t clv_l1_lsp_opts[] = {
&ett_isis_lsp_clv_mt_is,
dissect_lsp_mt_is_reachability_clv
},
-
+ {
+ ISIS_CLV_L1_LSP_MT_REACHABLE_IPv4_PREFX,
+ "Multi Topology Reachable IPv4 Prefixes",
+ &ett_isis_lsp_clv_mt_reachable_IPv4_prefx,
+ dissect_lsp_mt_reachable_IPv4_prefx_clv
+ },
+ {
+ ISIS_CLV_L1_LSP_MT_REACHABLE_IPv6_PREFX,
+ "Multi Topology Reachable IPv6 Prefixes",
+ &ett_isis_lsp_clv_mt_reachable_IPv6_prefx,
+ dissect_lsp_mt_reachable_IPv6_prefx_clv
+ },
{
0,
"",
&ett_isis_lsp_clv_mt_is,
dissect_lsp_mt_is_reachability_clv
},
+ {
+ ISIS_CLV_L2_LSP_MT_REACHABLE_IPv4_PREFX,
+ "Multi Topology Reachable IPv4 Prefixes",
+ &ett_isis_lsp_clv_mt_reachable_IPv4_prefx,
+ dissect_lsp_mt_reachable_IPv4_prefx_clv
+ },
+ {
+ ISIS_CLV_L2_LSP_MT_REACHABLE_IPv6_PREFX,
+ "Multi Topology Reachable IPv6 Prefixes",
+ &ett_isis_lsp_clv_mt_reachable_IPv6_prefx,
+ dissect_lsp_mt_reachable_IPv6_prefx_clv
+ },
{
0,
"",
}
};
+/*
+ * Name: dissect_lsp_mt_id()
+ *
+ * Description:
+ * dissect and display the multi-topology ID value
+ *
+ * Input:
+ * tvbuff_t * : tvbuffer for packet data
+ * proto_tree * : protocol display tree to fill out. CAN'T BE NULL
+ * int : offset into packet data where we are.
+ *
+ * Output:
+ * void, but we will add to proto tree.
+ */
+static void
+dissect_lsp_mt_id(tvbuff_t *tvb, proto_tree *tree, int offset)
+{
+ int mt_block, mt_id;
+ char mt_desc[60];
+
+ /* fetch two bytes */
+ mt_block = tvb_get_ntohs(tvb, offset);
+
+ proto_tree_add_text ( tree, tvb, offset, 1 ,
+ "4 most significant bits reserved, should be set to 0 (%d)", ISIS_LSP_MT_MSHIP_RES(mt_block));
+
+ mt_id = ISIS_LSP_MT_MSHIP_ID(mt_block);
+ /*mask out the lower 12 bits */
+ switch(mt_id) {
+ case 0:
+ strcpy(mt_desc,"'standard' topology");
+ break;
+ case 1:
+ strcpy(mt_desc,"IPv4 In-Band Management purposes");
+ break;
+ case 2:
+ strcpy(mt_desc,"IPv6 routing topology");
+ break;
+ case 3:
+ strcpy(mt_desc,"IPv4 multicast routing topology");
+ break;
+ case 4:
+ strcpy(mt_desc,"IPv6 multicast routing topology");
+ break;
+ default:
+ strcpy(mt_desc,((mt_block & 0x0fff) < 3996) ? "Reserved for IETF Consensus" : "Development, Experimental and Proprietary features");
+ }
+
+ proto_tree_add_text ( tree, tvb, offset, 2 ,
+ "%s (%d)", mt_desc, mt_id);
+
+}
/*
* Name: dissect_metric()
}
}
+/*
+ * Name: dissect_ipreach_subclv ()
+ *
+ * Description: parses IP reach subTLVs
+ * Called by various IP Reachability dissectors.
+ *
+ * Input:
+ * tvbuff_t * : tvbuffer for packet data
+ * proto_tree * : protocol display tree to fill out.
+ * int : offset into packet data where we are (beginning of the sub_clv value).
+ *
+ * Output:
+ * void
+ */
+static void
+dissect_ipreach_subclv(tvbuff_t *tvb, proto_tree *tree, int offset, int clv_code, int clv_len)
+{
+
+ switch (clv_code) {
+ case 1:
+ while (clv_len >= 4) {
+ proto_tree_add_text(tree, tvb, offset, 4,
+ "32-Bit Administrative tag: 0x%08x (=%u)",
+ tvb_get_ntohl(tvb, offset),
+ tvb_get_ntohl(tvb, offset));
+ offset+=4;
+ clv_len-=4;
+ }
+ break;
+ case 2:
+ while (clv_len >= 8) {
+ proto_tree_add_text(tree, tvb, offset, 8,
+ "64-Bit Administrative tag: 0x%08x%08x",
+ tvb_get_ntohl(tvb, offset),
+ tvb_get_ntohl(tvb, offset+4));
+ offset+=8;
+ clv_len-=8;
+ }
+ break;
+
+ default :
+ proto_tree_add_text (tree, tvb, offset, clv_len+2,
+ "Unknown sub-TLV: code %u, length %u",
+ clv_code, clv_len );
+ break;
+ }
+}
+
+
/*
* Name: dissect_lsp_ext_ip_reachability_clv()
*
* the metric as a 32-bit unsigned interger and allows to add
* sub-CLV(s).
*
+ * CALLED BY TLV 235 DISSECTOR
+ *
+ *
* Input:
* tvbuff_t * : tvbuffer for packet data
* proto_tree * : proto tree to build on (may be null)
{
proto_item *pi = NULL;
proto_tree *subtree = NULL;
+ proto_tree *subtree2 = NULL;
guint8 ctrl_info;
guint8 bit_length, byte_length;
guint8 prefix [4];
- guint8 len;
+ guint32 metric;
+ guint8 len,i;
+ guint8 subclvs_len;
+ guint8 clv_code, clv_len;
if (!tree) return;
ctrl_info = tvb_get_guint8(tvb, offset+4);
bit_length = ctrl_info & 0x3f;
byte_length = (bit_length + 7) / 8;
- tvb_memcpy (tvb, prefix, offset+5, byte_length);
- pi = proto_tree_add_text (tree, tvb, offset, -1,
- "IPv4 prefix: %s/%d",
- ip_to_str (prefix),
- bit_length );
- subtree = proto_item_add_subtree (pi,
- ett_isis_lsp_part_of_clv_ext_ip_reachability);
+ if (byte_length > sizeof(prefix)) {
+ isis_dissect_unknown(tvb, tree, offset,
+ "IPv4 prefix has an invalid length: %d bytes", byte_length );
+ return;
+ }
+ tvb_memcpy (tvb, prefix, offset+5, byte_length);
+ metric = tvb_get_ntohl(tvb, offset);
+ subclvs_len = 0;
+ if ((ctrl_info & 0x40) != 0)
+ subclvs_len = 1+tvb_get_guint8(tvb, offset+5+byte_length);
- proto_tree_add_text (subtree, tvb, offset, 4,
- "Metric: %d, Distribution: %s", tvb_get_ntohl(tvb, offset), ((ctrl_info & 0x80) == 0) ? "up" : "down" );
+ pi = proto_tree_add_text (tree, tvb, offset, 5+byte_length+subclvs_len,
+ "IPv4 prefix: %s/%d, Metric: %u, Distribution: %s, %ssub-TLVs present",
+ ip_to_str (prefix),
+ bit_length,
+ metric,
+ ((ctrl_info & 0x80) == 0) ? "up" : "down",
+ ((ctrl_info & 0x40) == 0) ? "no " : "" );
- proto_tree_add_text (subtree, tvb, offset+4, 1,
- "%s sub-TLVs present",
- ((ctrl_info & 0x40) == 0) ? "no" : "" );
+ /* open up a new tree per prefix */
+ subtree = proto_item_add_subtree (pi, ett_isis_lsp_part_of_clv_ext_ip_reachability);
+
+ proto_tree_add_text (subtree, tvb, offset+5, byte_length, "IPv4 prefix: %s/%u",
+ ip_to_str (prefix),
+ bit_length);
+
+ proto_tree_add_text (subtree, tvb, offset, 4, "Metric: %u", metric);
+
+ proto_tree_add_text (subtree, tvb, offset+4, 1, "Distribution: %s",
+ ((ctrl_info & 0x80) == 0) ? "up" : "down");
len = 5 + byte_length;
- if ((ctrl_info & 0x40) != 0)
- len += 1 + tvb_get_guint8(tvb, offset+len) ;
- proto_item_set_len (pi, len);
+ if ((ctrl_info & 0x40) != 0) {
+ subclvs_len = tvb_get_guint8(tvb, offset+len);
+ pi = proto_tree_add_text (subtree, tvb, offset+len, 1, "sub-TLVs present, total length: %u bytes",
+ subclvs_len);
+ proto_item_set_len (pi, subclvs_len+1);
+ /* open up a new tree for the subTLVs */
+ subtree2 = proto_item_add_subtree (pi, ett_isis_lsp_clv_ip_reach_subclv);
+
+ i =0;
+ while (i < subclvs_len) {
+ clv_code = tvb_get_guint8(tvb, offset+len+1); /* skip the total subtlv len indicator */
+ clv_len = tvb_get_guint8(tvb, offset+len+2);
+
+ /*
+ * we pass on now the raw data to the ipreach_subtlv dissector
+ * therefore we need to skip 3 bytes
+ * (total subtlv len, subtlv type, subtlv len)
+ */
+ dissect_ipreach_subclv(tvb, subtree2, offset+len+3, clv_code, clv_len);
+ i += clv_len + 2;
+ }
+ len += 1 + subclvs_len;
+ } else {
+ proto_tree_add_text (subtree, tvb, offset+4, 1, "no sub-TLVs present");
+ proto_item_set_len (pi, len);
+ }
+
offset += len;
length -= len;
}
*
* Description: Decode an IPv6 reachability CLV - code 236.
*
+ * CALLED BY TLV 237 DISSECTOR
+ *
* Input:
* tvbuff_t * : tvbuffer for packet data
* proto_tree * : proto tree to build on (may be null)
dissect_lsp_ipv6_reachability_clv(tvbuff_t *tvb, proto_tree *tree, int offset,
int id_length _U_, int length)
{
- proto_item *ti;
- proto_tree *ntree = NULL;
+ proto_item *pi;
+ proto_tree *subtree = NULL;
+ proto_tree *subtree2 = NULL;
+ guint8 ctrl_info;
guint8 bit_length, byte_length;
struct e_in6_addr prefix;
- guint8 ctrl_info;
guint32 metric;
- guint8 len;
+ guint8 len,i;
+ guint8 subclvs_len;
+ guint8 clv_code, clv_len;
if (!tree) return;
- memset (prefix.s6_addr, 0, 16);
-
while (length > 0) {
+ memset (prefix.s6_addr, 0, 16);
+ ctrl_info = tvb_get_guint8(tvb, offset+4);
bit_length = tvb_get_guint8(tvb, offset+5);
byte_length = (bit_length + 7) / 8;
- tvb_memcpy (tvb, prefix.s6_addr, offset+6, byte_length);
- ti = proto_tree_add_text (tree, tvb, offset, -1,
- "IP prefix: %s /%d",
- ip6_to_str (&prefix),
- bit_length );
- ntree = proto_item_add_subtree (ti, ett_isis_lsp_part_of_clv_ipv6_reachability);
-
+ if (byte_length > sizeof(prefix)) {
+ isis_dissect_unknown(tvb, tree, offset,
+ "IPv6 prefix has an invalid length: %d bytes", byte_length );
+ return;
+ }
+ tvb_memcpy (tvb, prefix.s6_addr, offset+6, byte_length);
metric = tvb_get_ntohl(tvb, offset);
- proto_tree_add_text (ntree, tvb, offset, 4,
- "Metric: %d", metric);
+ subclvs_len = 0;
+ if ((ctrl_info & 0x20) != 0)
+ subclvs_len = 1+tvb_get_guint8(tvb, offset+6+byte_length);
- ctrl_info = tvb_get_guint8(tvb, offset+4);
- proto_tree_add_text (ntree, tvb, offset+4, 1,
+ pi = proto_tree_add_text (tree, tvb, offset, 6+byte_length+subclvs_len,
+ "IPv6 prefix: %s/%u, Metric: %u, Distribution: %s, %s, %ssub-TLVs present",
+ ip6_to_str (&prefix),
+ bit_length,
+ metric,
+ ((ctrl_info & 0x80) == 0) ? "up" : "down",
+ ((ctrl_info & 0x40) == 0) ? "internal" : "external",
+ ((ctrl_info & 0x20) == 0) ? "no " : "" );
+
+ subtree = proto_item_add_subtree (pi, ett_isis_lsp_part_of_clv_ipv6_reachability);
+
+ proto_tree_add_text (subtree, tvb, offset+6, byte_length, "IPv6 prefix: %s/%u",
+ ip6_to_str (&prefix),
+ bit_length);
+
+ proto_tree_add_text (subtree, tvb, offset, 4,
+ "Metric: %u", metric);
+
+ proto_tree_add_text (subtree, tvb, offset+4, 1,
"Distribution: %s, %s",
((ctrl_info & 0x80) == 0) ? "up" : "down",
((ctrl_info & 0x40) == 0) ? "internal" : "external" );
- proto_tree_add_text (ntree, tvb, offset+4, 1,
- "Reserved bits: 0x%x",
- (ctrl_info & 0x1f) );
- proto_tree_add_text (ntree, tvb, offset+4, 1,
- "sub-TLVs: %s",
- ((ctrl_info & 0x20) == 0) ? "no" : "yes" );
+ if ((ctrl_info & 0x1f) != 0) {
+ proto_tree_add_text (subtree, tvb, offset+4, 1,
+ "Reserved bits: 0x%x",
+ (ctrl_info & 0x1f) );
+ }
len = 6 + byte_length;
- if ((ctrl_info & 0x20) != 0)
- len += 1 + tvb_get_guint8(tvb, offset+len);
- proto_item_set_len (ti, len);
+ if ((ctrl_info & 0x20) != 0) {
+ subclvs_len = tvb_get_guint8(tvb, offset+len);
+ pi = proto_tree_add_text (subtree, tvb, offset+len, 1, "sub-TLVs present, total length: %u bytes",
+ subclvs_len);
+ proto_item_set_len (pi, subclvs_len+1);
+ /* open up a new tree for the subTLVs */
+ subtree2 = proto_item_add_subtree (pi, ett_isis_lsp_clv_ip_reach_subclv);
+
+ i =0;
+ while (i < subclvs_len) {
+ clv_code = tvb_get_guint8(tvb, offset+len+1); /* skip the total subtlv len indicator */
+ clv_len = tvb_get_guint8(tvb, offset+len+2);
+ dissect_ipreach_subclv(tvb, subtree2, offset+len+3, clv_code, clv_len);
+ i += clv_len + 2;
+ }
+ len += 1 + subclvs_len;
+ } else {
+ proto_tree_add_text (subtree, tvb, offset+4, 1, "no sub-TLVs present");
+ proto_item_set_len (pi, len);
+ }
offset += len;
length -= len;
}
/*
* Name: dissect_lsp_mt_clv()
*
- * Description:
+ * Description: - code 229
* Decode for a lsp packets Multi Topology clv. Calls into the
* clv common one.
*
* of the IS reachability TLV (code 2). It encodes the metric
* as a 24-bit unsigned interger and allows to add sub-CLV(s).
*
+ * CALLED BY TLV 222 DISSECTOR
+ *
* Input:
* tvbuff_t * : tvbuffer for packet data
* proto_tree * : protocol display tree to fill out. May be NULL
}
}
-/* MT IS */
+/*
+ * Name: dissect_lsp_mt_reachable_IPv4_prefx_clv()
+ *
+ * Description: Decode Multi-Topology IPv4 Prefixes - code 235
+ *
+ *
+ * Input:
+ * tvbuff_t * : tvbuffer for packet data
+ * proto_tree * : protocol display tree to fill out. May be NULL
+ * int : offset into packet data where we are.
+ * int : length of IDs in packet.
+ * int : length of clv we are decoding
+ *
+ * Output:
+ * void, but we will add to proto tree if !NULL.
+ */
+static void
+dissect_lsp_mt_reachable_IPv4_prefx_clv(tvbuff_t *tvb,
+ proto_tree *tree, int offset, int id_length _U_, int length)
+{
+ if (!tree) return;
+ if (length < 2) {
+ isis_dissect_unknown(tvb, tree, offset,
+ "short lsp multi-topology reachable IPv4 prefixes(%d vs %d)", length,
+ 2 );
+ return;
+ }
+ dissect_lsp_mt_id(tvb, tree, offset);
+ dissect_lsp_ext_ip_reachability_clv(tvb, tree, offset+2, 0, length-2);
+}
+/*
+ * Name: dissect_lsp_mt_reachable_IPv6_prefx_clv()
+ *
+ * Description: Decode Multi-Topology IPv6 Prefixes - code 237
+ *
+ *
+ * Input:
+ * tvbuff_t * : tvbuffer for packet data
+ * proto_tree * : protocol display tree to fill out. May be NULL
+ * int : offset into packet data where we are.
+ * int : length of IDs in packet.
+ * int : length of clv we are decoding
+ *
+ * Output:
+ * void, but we will add to proto tree if !NULL.
+ */
+static void
+dissect_lsp_mt_reachable_IPv6_prefx_clv(tvbuff_t *tvb,
+ proto_tree *tree, int offset, int id_length _U_, int length)
+{
+ if (!tree) return;
+ if (length < 2) {
+ isis_dissect_unknown(tvb, tree, offset,
+ "short lsp multi-topology reachable IPv6 prefixes(%d vs %d)", length,
+ 2 );
+ return;
+ }
+ dissect_lsp_mt_id(tvb, tree, offset);
+ dissect_lsp_ipv6_reachability_clv(tvb, tree, offset+2, 0, length-2);
+}
+/*
+ * Name: dissect_lsp_mt_is_reachability_clv()
+ *
+ * Description: Decode Multi-Topology Intermediate Systems - code 222
+ *
+ *
+ * Input:
+ * tvbuff_t * : tvbuffer for packet data
+ * proto_tree * : protocol display tree to fill out. May be NULL
+ * int : offset into packet data where we are.
+ * int : unused
+ * int : length of clv we are decoding
+ *
+ * Output:
+ * void, but we will add to proto tree if !NULL.
+ */
static void
dissect_lsp_mt_is_reachability_clv(tvbuff_t *tvb, proto_tree *tree, int offset,
int id_length _U_, int length)
{
- proto_item *ti;
- proto_tree *ntree = NULL;
- guint8 subclvs_len;
- guint8 len;
-
- int mt_block;
- char mt_desc[60];
-
if (!tree) return;
-
- while (length > 0) {
-
- /* fetch two bytes */
- mt_block = tvb_get_ntohs(tvb, offset);
-
- /* mask out the lower 12 bits */
- switch(mt_block&0x0fff) {
- case 0:
- strcpy(mt_desc,"IPv4 unicast");
- break;
- case 1:
- strcpy(mt_desc,"In-Band Management");
- break;
- case 2:
- strcpy(mt_desc,"IPv6 unicast");
- break;
- case 3:
- strcpy(mt_desc,"Multicast");
- break;
- case 4095:
- strcpy(mt_desc,"Development, Experimental or Proprietary");
- break;
- default:
- strcpy(mt_desc,"Reserved for IETF Consensus");
- }
-
- proto_tree_add_text ( tree, tvb, offset, 2 ,
- "%s Topology (0x%x)",
- mt_desc,
- mt_block&0xfff );
-
- ti = proto_tree_add_text (tree, tvb, offset+2, -1,
- "IS neighbor: %s",
- print_system_id(tvb_get_ptr(tvb, offset+2, 7), 7) );
-
- ntree = proto_item_add_subtree (ti,
- ett_isis_lsp_part_of_clv_mt_is );
-
- proto_tree_add_text (ntree, tvb, offset+9, 3,
- "Metric: %d", tvb_get_ntoh24(tvb, offset+9) );
-
- subclvs_len = tvb_get_guint8(tvb, offset+12);
- if (subclvs_len == 0) {
- proto_tree_add_text (ntree, tvb, offset+12, 1, "no sub-TLVs present");
- } else {
- proto_tree_add_text (ntree, tvb, offset+12, 1, "sub-TLVs present");
- }
-
- len = 13 + subclvs_len;
- proto_item_set_len (ti, len);
- offset += len;
- length -= len;
-
+ if (length < 2) {
+ isis_dissect_unknown(tvb, tree, offset,
+ "short lsp reachability(%d vs %d)", length,
+ 2 );
+ return;
}
+
+ /*
+ * the MT ID value dissection is used in other LSPs so we push it
+ * in a function
+ */
+ dissect_lsp_mt_id(tvb, tree, offset);
+ /*
+ * fix here. No need to parse TLV 22 (with bugs) while it is
+ * already done correctly!!
+ */
+ dissect_lsp_ext_is_reachability_clv(tvb, tree, offset+2, 0, length-2);
}
/*
isis_dissect_isis_lsp(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, int offset,
int lsp_type, int header_length, int id_length)
{
- proto_item *ti;
- proto_tree *lsp_tree = NULL;
- guint16 pdu_length;
- char sbuf[128];
- int inx, q, some, value, len;
+ proto_item *ti, *to, *ta;
+ proto_tree *lsp_tree = NULL, *info_tree, *att_tree;
+ guint16 pdu_length, checksum, cacl_checksum=0;
+ guint8 lsp_info, lsp_att;
+ int len, offset_checksum;
if (tree) {
ti = proto_tree_add_text(tree, tvb, offset, -1,
tvb_get_ntohs(tvb, offset));
}
offset += 2;
+ offset_checksum = offset;
if (tree) {
proto_tree_add_text(lsp_tree, tvb, offset, id_length + 2,
offset += 4;
if (tree) {
- /* XXX -> we could validate the cksum here! */
- proto_tree_add_uint(lsp_tree, hf_isis_lsp_checksum, tvb,
- offset, 2, tvb_get_ntohs(tvb, offset));
+ checksum = tvb_get_ntohs(tvb, offset);
+ switch (check_and_get_checksum(tvb, offset_checksum, pdu_length-12, checksum, offset, &cacl_checksum))
+ {
+
+ case NO_CKSUM :
+ proto_tree_add_uint_format(lsp_tree, hf_isis_lsp_checksum, tvb, offset, 2, checksum,
+ "Checksum: 0x%04x (unused)", checksum);
+ break;
+ case DATA_MISSING :
+ isis_dissect_unknown(tvb, tree, offset,
+ "packet length %d went beyond packet",
+ tvb_length_remaining(tvb, offset_checksum));
+ break;
+ case CKSUM_NOT_OK :
+ proto_tree_add_uint_format(lsp_tree, hf_isis_lsp_checksum, tvb, offset, 2, checksum,
+ "Checksum: 0x%04x (incorrect, should be 0x%04x)",
+ checksum, cacl_checksum);
+ proto_tree_add_boolean_hidden(lsp_tree, hf_isis_lsp_checksum_bad,
+ tvb, offset, 2, TRUE);
+ break;
+ case CKSUM_OK :
+ proto_tree_add_uint_format(lsp_tree, hf_isis_lsp_checksum, tvb, offset, 2, checksum,
+ "Checksum: 0x%04x (correct)", checksum);
+ proto_tree_add_boolean_hidden(lsp_tree, hf_isis_lsp_checksum_bad,
+ tvb, offset, 2, FALSE);
+ break;
+ default :
+ g_message("'check_and_get_checksum' returned an invalid value");
+ }
}
offset += 2;
if (tree) {
/*
- * We need to build our type block values.
+ * P | ATT | HIPPITY | IS TYPE description.
*/
- sbuf[0] = 0;
- some = 0;
- value = ISIS_LSP_ATT(tvb_get_guint8(tvb, offset));
- inx = 0;
- for ( q = (1<<ISIS_LSP_ATT_SHIFT); q > 0; q = q >> 1 ){
- if (q & value) {
- if (some++) {
- strcat(sbuf, ", ");
- }
- strcat ( sbuf, isis_lsp_attached_bits[inx] );
- }
- inx++;
- }
- if (!some) {
- strcat ( sbuf, "default-only" );
- }
- proto_tree_add_text(lsp_tree, tvb, offset + 18, 1,
- "Type block(0x%02x): P:%d, Supported metric(s): %s, OL:%d, istype:%s",
- tvb_get_guint8(tvb, offset),
- ISIS_LSP_PARTITION(tvb_get_guint8(tvb, offset)) ? 1 : 0,
- sbuf,
- ISIS_LSP_HIPPITY(tvb_get_guint8(tvb, offset)) ? 1 : 0,
- val_to_str(ISIS_LSP_IS_TYPE(tvb_get_guint8(tvb, offset)),
- isis_lsp_istype_vals, "Unknown (0x%x)")
+ lsp_info = tvb_get_guint8(tvb, offset);
+ to = proto_tree_add_text(lsp_tree, tvb, offset, 1,
+ "Type block(0x%02x): Partition Repair:%d, Attached bits:%d, Overload bit:%d, IS type:%d",
+ lsp_info,
+ ISIS_LSP_PARTITION(lsp_info),
+ ISIS_LSP_ATT(lsp_info),
+ ISIS_LSP_HIPPITY(lsp_info),
+ ISIS_LSP_IS_TYPE(lsp_info)
);
+
+ info_tree = proto_item_add_subtree(to, ett_isis_lsp_info);
+ proto_tree_add_boolean(info_tree, hf_isis_lsp_p, tvb, offset, 1, lsp_info);
+ ta = proto_tree_add_uint(info_tree, hf_isis_lsp_att, tvb, offset, 1, lsp_info);
+ att_tree = proto_item_add_subtree(ta, ett_isis_lsp_att);
+ lsp_att = ISIS_LSP_ATT(lsp_info);
+ proto_tree_add_text(att_tree, tvb, offset, 1,
+ "%d... = Default metric: %s", ISIS_LSP_ATT_DEFAULT(lsp_att), ISIS_LSP_ATT_DEFAULT(lsp_att) ? "Set" : "Unset");
+ proto_tree_add_text(att_tree, tvb, offset, 1,
+ ".%d.. = Delay metric: %s", ISIS_LSP_ATT_DELAY(lsp_att), ISIS_LSP_ATT_DELAY(lsp_att) ? "Set" : "Unset");
+ proto_tree_add_text(att_tree, tvb, offset, 1,
+ "..%d. = Expense metric: %s", ISIS_LSP_ATT_EXPENSE(lsp_att), ISIS_LSP_ATT_EXPENSE(lsp_att) ? "Set" : "Unset");
+ proto_tree_add_text(att_tree, tvb, offset, 1,
+ "...%d = Error metric: %s", ISIS_LSP_ATT_ERROR(lsp_att), ISIS_LSP_ATT_ERROR(lsp_att) ? "Set" : "Unset");
+ proto_tree_add_boolean(info_tree, hf_isis_lsp_hippity, tvb, offset, 1, lsp_info);
+ proto_tree_add_uint(info_tree, hf_isis_lsp_is_type, tvb, offset, 1, lsp_info);
}
offset += 1;
{ &hf_isis_lsp_checksum,
{ "Checksum", "isis.lsp.checksum",FT_UINT16,
BASE_HEX, NULL, 0x0, "", HFILL }},
+
+ { &hf_isis_lsp_checksum_bad,
+ { "Bad Checksum", "isis.lsp.checksum_bad", FT_BOOLEAN, BASE_NONE,
+ NULL, 0, "Bad IS-IS LSP Checksum", HFILL }},
{ &hf_isis_lsp_clv_ipv4_int_addr,
{ "IPv4 interface address", "isis.lsp.clv_ipv4_int_addr", FT_IPv4,
{ &hf_isis_lsp_clv_mt,
{ "MT-ID ", "isis.lsp.clv_mt",
FT_UINT16, BASE_HEX, NULL, 0x0, "", HFILL }},
+
+ { &hf_isis_lsp_p,
+ { "Partition Repair", "isis.lsp.partition_repair", FT_BOOLEAN, 8,
+ TFS(&supported_string), ISIS_LSP_PARTITION_MASK,
+ "If set, this router supports the optional Partition Repair function", HFILL }},
+
+ { &hf_isis_lsp_att,
+ { "Attachment", "isis.lsp.att", FT_UINT8, BASE_DEC,
+ NULL, ISIS_LSP_ATT_MASK,
+ "", HFILL }},
+
+ { &hf_isis_lsp_hippity,
+ { "Overload bit", "isis.lsp.overload", FT_BOOLEAN, 8,
+ TFS(&hippity_string), ISIS_LSP_HIPPITY_MASK,
+ "If set, this router will not be used by any decision process to calculate routes", HFILL }},
+
+ { &hf_isis_lsp_is_type,
+ { "Type of Intermediate System", "isis.lsp.is_type", FT_UINT8, BASE_DEC,
+ VALS(isis_lsp_istype_vals), ISIS_LSP_IS_TYPE_MASK,
+ "", HFILL }},
};
static gint *ett[] = {
&ett_isis_lsp,
+ &ett_isis_lsp_info,
+ &ett_isis_lsp_att,
&ett_isis_lsp_clv_area_addr,
&ett_isis_lsp_clv_is_neighbors,
&ett_isis_lsp_clv_ext_is_reachability, /* CLV 22 */
- &ett_isis_lsp_part_of_clv_ext_is_reachability,
- &ett_isis_lsp_subclv_admin_group,
- &ett_isis_lsp_subclv_unrsv_bw,
+ &ett_isis_lsp_part_of_clv_ext_is_reachability,
+ &ett_isis_lsp_subclv_admin_group,
+ &ett_isis_lsp_subclv_unrsv_bw,
&ett_isis_lsp_clv_unknown,
&ett_isis_lsp_clv_partition_dis,
&ett_isis_lsp_clv_prefix_neighbors,
&ett_isis_lsp_clv_ipv6_int_addr, /* CLV 232 */
&ett_isis_lsp_clv_te_router_id,
&ett_isis_lsp_clv_ip_reachability,
+ &ett_isis_lsp_clv_ip_reach_subclv,
&ett_isis_lsp_clv_ext_ip_reachability, /* CLV 135 */
- &ett_isis_lsp_part_of_clv_ext_ip_reachability,
+ &ett_isis_lsp_part_of_clv_ext_ip_reachability,
&ett_isis_lsp_clv_ipv6_reachability, /* CLV 236 */
- &ett_isis_lsp_part_of_clv_ipv6_reachability,
+ &ett_isis_lsp_part_of_clv_ipv6_reachability,
&ett_isis_lsp_clv_mt,
&ett_isis_lsp_clv_mt_is,
&ett_isis_lsp_part_of_clv_mt_is,
+ &ett_isis_lsp_clv_mt_reachable_IPv4_prefx,
+ &ett_isis_lsp_clv_mt_reachable_IPv6_prefx,
};
proto_register_field_array(proto_isis, hf, array_length(hf));