"hex_str_to_bytes()" modifies the GByteArray supplied to it, so don't
[obnox/wireshark/wip.git] / packet-ip.c
index 2181a9e25a8ba2757990403e81fed2539d9f0d79..f43f977a28a354ef7c5d8731c8a57ceb65ec2c83 100644 (file)
@@ -1,23 +1,22 @@
 /* packet-ip.c
  * Routines for IP and miscellaneous IP protocol packet disassembly
  *
- * $Id: packet-ip.c,v 1.133 2001/05/23 03:33:58 gerald Exp $
+ * $Id: packet-ip.c,v 1.201 2003/11/13 08:16:52 sahlberg Exp $
  *
  * Ethereal - Network traffic analyzer
- * By Gerald Combs <gerald@zing.org>
+ * By Gerald Combs <gerald@ethereal.com>
  * Copyright 1998 Gerald Combs
  *
- * 
  * This program is free software; you can redistribute it and/or
  * modify it under the terms of the GNU General Public License
  * as published by the Free Software Foundation; either version 2
  * of the License, or (at your option) any later version.
- * 
+ *
  * This program is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
- * 
+ *
  * You should have received a copy of the GNU General Public License
  * along with this program; if not, write to the Free Software
  * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
 # include "config.h"
 #endif
 
-#ifdef HAVE_SYS_TYPES_H
-# include <sys/types.h>
-#endif
-
-#ifdef HAVE_NETINET_IN_H
-# include <netinet/in.h>
-#endif
-
 #include <stdio.h>
 #include <string.h>
 #include <glib.h>
 # include "snprintf.h"
 #endif
 
-#include "packet.h"
-#include "resolv.h"
+#include <epan/packet.h>
+#include <epan/resolv.h>
 #include "ipproto.h"
+#include "ip_opts.h"
 #include "prefs.h"
+#include "reassemble.h"
 #include "etypes.h"
 #include "greproto.h"
 #include "ppptypes.h"
 #include "llcsaps.h"
 #include "aftypes.h"
+#include "arcnet_pids.h"
 #include "packet-ip.h"
 #include "packet-ipsec.h"
 #include "in_cksum.h"
 #include "nlpid.h"
+#include "tap.h"
+
+static int ip_tap = -1;
 
 static void dissect_icmp(tvbuff_t *, packet_info *, proto_tree *);
 
@@ -101,6 +98,7 @@ static int hf_ip_fragment_overlap_conflict = -1;
 static int hf_ip_fragment_multiple_tails = -1;
 static int hf_ip_fragment_too_long_fragment = -1;
 static int hf_ip_fragment_error = -1;
+static int hf_ip_reassembled_in = -1;
 
 static gint ett_ip = -1;
 static gint ett_ip_dsfield = -1;
@@ -113,16 +111,58 @@ static gint ett_ip_option_timestamp = -1;
 static gint ett_ip_fragments = -1;
 static gint ett_ip_fragment  = -1;
 
-/* Used by IPv6 as well, so not static */
-dissector_table_t ip_dissector_table;
+static const fragment_items ip_frag_items = {
+       &ett_ip_fragment,
+       &ett_ip_fragments,
+       &hf_ip_fragments,
+       &hf_ip_fragment,
+       &hf_ip_fragment_overlap,
+       &hf_ip_fragment_overlap_conflict,
+       &hf_ip_fragment_multiple_tails,
+       &hf_ip_fragment_too_long_fragment,
+       &hf_ip_fragment_error,
+       &hf_ip_reassembled_in,
+       "fragments"
+};
+
+static dissector_table_t ip_dissector_table;
+
+static dissector_handle_t ip_handle;
+static dissector_handle_t data_handle;
 
 static int proto_icmp = -1;
 static int hf_icmp_type = -1;
 static int hf_icmp_code = -1;
 static int hf_icmp_checksum = -1;
 static int hf_icmp_checksum_bad = -1;
+static int hf_icmp_ident = -1;
+static int hf_icmp_seq_num = -1;
+static int hf_icmp_mtu = -1;
+static int hf_icmp_redir_gw = -1;
+
+
+/* Mobile ip */
+static int hf_icmp_mip_type = -1;
+static int hf_icmp_mip_length = -1;
+static int hf_icmp_mip_prefix_length = -1;
+static int hf_icmp_mip_seq = -1;
+static int hf_icmp_mip_life = -1;
+static int hf_icmp_mip_flags = -1;
+static int hf_icmp_mip_r = -1;
+static int hf_icmp_mip_b = -1;
+static int hf_icmp_mip_h = -1;
+static int hf_icmp_mip_f = -1;
+static int hf_icmp_mip_m = -1;
+static int hf_icmp_mip_g = -1;
+static int hf_icmp_mip_v = -1;
+static int hf_icmp_mip_res = -1;
+static int hf_icmp_mip_reserved = -1;
+static int hf_icmp_mip_coa = -1;
+static int hf_icmp_mip_challenge = -1;
 
 static gint ett_icmp = -1;
+static gint ett_icmp_mip = -1;
+static gint ett_icmp_mip_flags = -1;
 
 /* ICMP definitions */
 
@@ -164,20 +204,6 @@ static gint ett_icmp = -1;
 
 /* IP structs and definitions */
 
-typedef struct _e_ip 
-   {
-   guint8  ip_v_hl; /* combines ip_v and ip_hl */
-   guint8  ip_tos;
-   guint16 ip_len;
-   guint16 ip_id;
-   guint16 ip_off;
-   guint8  ip_ttl;
-   guint8  ip_p;
-   guint16 ip_sum;
-   guint32 ip_src;
-   guint32 ip_dst;
-   } e_ip;
-
 /* Offsets of fields within an IP header. */
 #define        IPH_V_HL        0
 #define        IPH_TOS         1
@@ -301,322 +327,19 @@ typedef struct _e_ip
 /*
  * defragmentation of IPv4
  */
-static GHashTable *ip_fragment_table=NULL;
-
-typedef struct _ip_fragment_key {
-       guint32 srcip;
-       guint32 dstip;
-       guint32 id;
-} ip_fragment_key;
-
-/* make sure that all flags that are set in a fragment entry is also set for
- * the flags field of ipfd_head !!!
- */
-/* only in ipfd_head: packet is defragmented */
-#define IPD_DEFRAGMENTED       0x0001
-/* there are overlapping fragments */
-#define IPD_OVERLAP            0x0002
-/* overlapping fragments contain different data */ 
-#define IPD_OVERLAPCONFLICT    0x0004  
-/* more than one fragment which indicates end-of data */
-#define IPD_MULTIPLETAILS      0x0008
-/* fragment contains data past the end of the datagram */
-#define IPD_TOOLONGFRAGMENT    0x0010
-typedef struct _ip_fragment_data {
-       struct _ip_fragment_data *next;
-       guint32 frame;
-       guint32 offset;
-       guint32 len;
-       guint32 datalen; /*Only valid in first item of list */
-       guint32 flags;
-       unsigned char *data;
-} ip_fragment_data;
-
-#define LINK_FRAG(ipfd_head,ipfd)                                      \
-       {       ip_fragment_data *ipfd_i;                               \
-               /* add fragment to list, keep list sorted */            \
-               for(ipfd_i=ipfd_head;ipfd_i->next;ipfd_i=ipfd_i->next){ \
-                       if( (ipfd->offset) < (ipfd_i->next->offset) )   \
-                               break;                                  \
-               }                                                       \
-               ipfd->next=ipfd_i->next;                                \
-               ipfd_i->next=ipfd;                                      \
-       }
-
-
-static gint
-ip_fragment_equal(gconstpointer k1, gconstpointer k2)
-{
-       ip_fragment_key* key1 = (ip_fragment_key*) k1;
-       ip_fragment_key* key2 = (ip_fragment_key*) k2;
-
-       return ( ( (key1->srcip == key2->srcip) &&
-                  (key1->dstip == key2->dstip) &&
-                  (key1->id    == key2->id) 
-                ) ?
-                TRUE : FALSE);
-}
-
-static guint
-ip_fragment_hash(gconstpointer k)
-{
-       ip_fragment_key* key = (ip_fragment_key*) k;
-
-       return (key->srcip ^ key->dstip ^ key->id);
-}
-
-static gboolean
-free_all_fragments(gpointer key, gpointer value, gpointer user_data)
-{
-       ip_fragment_data *ipfd_head;
-       ip_fragment_data *ipfd_i;
-
-       ipfd_head=value;
-       while(ipfd_head){
-               ipfd_i=ipfd_head->next;
-               if(ipfd_head->data){
-                       g_free(ipfd_head->data);
-               }
-               g_free(ipfd_head);
-               ipfd_head=ipfd_i;
-       }
-
-       g_free(key);
-       return TRUE;
-}
+static GHashTable *ip_fragment_table = NULL;
+static GHashTable *ip_reassembled_table = NULL;
 
 static void
 ip_defragment_init(void)
 {
-       if( ip_fragment_table != NULL ){
-               /* The fragment hash table exists.
-                * 
-                * Remove all entries and free all memory.
-                */
-               g_hash_table_foreach_remove(ip_fragment_table,free_all_fragments,NULL);
-       } else {
-               /* The fragment table does not exist. Create it */
-               ip_fragment_table = g_hash_table_new(ip_fragment_hash,
-                               ip_fragment_equal);
-       }
-}
-
-/* This function adds a new fragment to the fragment hash table
- * If this is the first fragment seen in for this ip packet,
- * a new entry is created in the hash table, otherwise
- * This fragment is just added to the linked list of 
- * fragments for this packet.
- * The list of fragments for a specific ip-packet is kept sorted for
- * easier handling.
- * tvb had better contain an IPv4 packet, or BAD things will probably happen.
- *
- * Returns a pointer to the head of the fragment data list if we have all the
- * fragments, NULL otherwise.
- */
-static ip_fragment_data *
-ip_fragment_add(tvbuff_t *tvb, int offset, packet_info *pinfo, guint32 id,
-               guint32 floff)
-{
-       ip_fragment_key *ipfk;
-       ip_fragment_data *ipfd_head;
-       ip_fragment_data *ipfd;
-       ip_fragment_data *ipfd_i;
-       guint32 frag_offset;
-       guint32 max,dfpos;
-
-
-       /* create key to search hash with */
-       ipfk=g_malloc(sizeof(ip_fragment_key));
-       memcpy(&ipfk->srcip, pinfo->src.data, sizeof(ipfk->srcip));
-       memcpy(&ipfk->dstip, pinfo->dst.data, sizeof(ipfk->dstip));
-       ipfk->id    = id;
-
-       ipfd_head=g_hash_table_lookup(ip_fragment_table, ipfk);
-
-
-       /* have we already seen this frame ?*/
-       if( pinfo->fd->flags.visited ){
-               g_free(ipfk);
-               if (ipfd_head != NULL && ipfd_head->flags & IPD_DEFRAGMENTED) {
-                       return ipfd_head;
-               } else {
-                       return NULL;
-               }
-       }
-
-
-
-       frag_offset = (floff & IP_OFFSET)*8;
-
-       if (ipfd_head==NULL){
-               /* not found, this must be the first snooped fragment for this
-                 * ip packet. Create list-head.
-                */
-               ipfd_head=g_malloc(sizeof(ip_fragment_data));
-               /* head/first structure in list only holds no other data than
-                 * 'datalen' then we dont have to change the head of the list
-                 * even if we want to keep it sorted
-                 */
-               ipfd_head->next=NULL;
-               ipfd_head->datalen=0;
-               ipfd_head->offset=0;
-               ipfd_head->len=0;
-               ipfd_head->flags=0;
-               ipfd_head->data=NULL;
-               g_hash_table_insert(ip_fragment_table, ipfk, ipfd_head);
-       } else {
-               /* this was not the first fragment, so we can throw ipfk 
-                * away, only used for the first fragment, 3 lines up
-                */
-               g_free(ipfk);
-       }
-
-
-       /* create new ipfd describing this fragment */
-       ipfd = g_malloc(sizeof(ip_fragment_data));
-       ipfd->next = NULL;
-       ipfd->flags = 0;
-       ipfd->frame = pinfo->fd->num;
-       ipfd->offset = frag_offset;
-       ipfd->len  = pinfo->iplen;
-       ipfd->len  -= (pinfo->iphdrlen*4);
-       ipfd->data = NULL;
-
-
-
-       if( !(floff&IP_MF) ){  
-               /* this is a tail fragment */
-               if (ipfd_head->datalen) {
-                       /* ok we have already seen other tails for this packet
-                        * it might be a duplicate.
-                        */
-                       if (ipfd_head->datalen != (ipfd->offset + ipfd->len) ){
-                               /* Oops, this tail indicates a different packet
-                                * len than the previous ones. Somethings wrong
-                                */
-                               ipfd->flags      |= IPD_MULTIPLETAILS;
-                               ipfd_head->flags |= IPD_MULTIPLETAILS;
-                       }
-               } else {
-                       /* this was the first tail fragment, now we know the
-                        * length of the packet
-                        */
-                       ipfd_head->datalen = ipfd->offset + ipfd->len;
-               }
-       }
-
-
-
-
-       /* If the packet is already defragmented, this MUST be an overlap.
-         * The entire defragmented packet is in ipfd_head->data
-        * Even if we have previously defragmented this packet, we still check
-        * check it. Someone might play overlap and TTL games.
-         */
-       if (ipfd_head->flags & IPD_DEFRAGMENTED) {
-               ipfd->flags      |= IPD_OVERLAP;
-               ipfd_head->flags |= IPD_OVERLAP;
-               /* make sure its not too long */
-               if (ipfd->offset + ipfd->len > ipfd_head->datalen) {
-                       ipfd->flags      |= IPD_TOOLONGFRAGMENT;
-                       ipfd_head->flags |= IPD_TOOLONGFRAGMENT;
-                       LINK_FRAG(ipfd_head,ipfd);
-                       return (ipfd_head);
-               }
-               /* make sure it doesnt conflict with previous data */
-               if ( memcmp(ipfd_head->data+ipfd->offset,
-                       tvb_get_ptr(tvb,offset,ipfd->len),ipfd->len) ){
-                       ipfd->flags      |= IPD_OVERLAPCONFLICT;
-                       ipfd_head->flags |= IPD_OVERLAPCONFLICT;
-                       LINK_FRAG(ipfd_head,ipfd);
-                       return (ipfd_head);
-               }
-               /* it was just an overlap, link it and return */
-               LINK_FRAG(ipfd_head,ipfd);
-               return (ipfd_head);
-       }
-
-
-
-       /* If we have reached this point, the packet is not defragmented yet.
-         * Save all payload in a buffer until we can defragment.
-        */
-       ipfd->data = g_malloc(ipfd->len);
-       tvb_memcpy(tvb, ipfd->data, offset, ipfd->len);
-       LINK_FRAG(ipfd_head,ipfd);
-
-
-       if( !(ipfd_head->datalen) ){
-               /* if we dont know the datalen, there are still missing
-                * packets. Cheaper than the check below.
-                */
-               return NULL;
-       }
-
-
-       /* check if we have received the entire fragment
-        * this is easy since the list is sorted and the head is faked.
-        */
-       max = 0;
-       for (ipfd_i=ipfd_head->next;ipfd_i;ipfd_i=ipfd_i->next) {
-               if ( ((ipfd_i->offset)<=max) && 
-                   ((ipfd_i->offset+ipfd_i->len)>max) ){
-                       max = ipfd_i->offset+ipfd_i->len;
-               }
-       }
-
-       if (max < (ipfd_head->datalen)) {
-               /* we have not received all packets yet */
-               return NULL;
-       }
-
-
-       if (max > (ipfd_head->datalen)) {
-               /* oops, too long fragment detected */
-               ipfd->flags      |= IPD_TOOLONGFRAGMENT;
-               ipfd_head->flags |= IPD_TOOLONGFRAGMENT;
-       }
-
-
-       /* we have received an entire packet, defragment it and
-         * free all fragments 
-         */
-       ipfd_head->data = g_malloc(max);
-
-       /* add all data fragments */
-       for (dfpos=0,ipfd_i=ipfd_head;ipfd_i;ipfd_i=ipfd_i->next) {
-               if (ipfd_i->len) {
-                       if (ipfd_i->offset < dfpos) {
-                               ipfd_i->flags    |= IPD_OVERLAP;
-                               ipfd_head->flags |= IPD_OVERLAP;
-                               if ( memcmp(ipfd_head->data+ipfd_i->offset,
-                                       ipfd_i->data,
-                                       MIN(ipfd_i->len,(dfpos-ipfd_i->offset))
-                                       ) ){
-                                       ipfd_i->flags    |= IPD_OVERLAPCONFLICT;
-                                       ipfd_head->flags |= IPD_OVERLAPCONFLICT;
-                               }
-                       }
-                       memcpy(ipfd_head->data+ipfd_i->offset,ipfd_i->data,ipfd_i->len);
-                       g_free(ipfd_i->data);
-                       ipfd_i->data=NULL;
-
-                       dfpos=MAX(dfpos,(ipfd_i->offset+ipfd_i->len));
-               }
-       }
-
-       /* mark this packet as defragmented.
-           allows us to skip any trailing fragments */
-       ipfd_head->flags |= IPD_DEFRAGMENTED;
-
-       return ipfd_head;
+  fragment_table_init(&ip_fragment_table);
+  reassembled_table_init(&ip_reassembled_table);
 }
 
-
-
 void
-capture_ip(const u_char *pd, int offset, packet_counts *ld) {
-  if (!BYTES_ARE_IN_FRAME(offset, IPH_MIN_LEN)) {
+capture_ip(const guchar *pd, int offset, int len, packet_counts *ld) {
+  if (!BYTES_ARE_IN_FRAME(offset, len, IPH_MIN_LEN)) {
     ld->other++;
     return;
   }
@@ -631,6 +354,7 @@ capture_ip(const u_char *pd, int offset, packet_counts *ld) {
       ld->udp++;
       break;
     case IP_PROTO_ICMP:
+    case IP_PROTO_ICMPV6:      /* XXX - separate counters? */
       ld->icmp++;
       break;
     case IP_PROTO_OSPF:
@@ -649,7 +373,8 @@ capture_ip(const u_char *pd, int offset, packet_counts *ld) {
 
 static void
 dissect_ipopt_security(const ip_tcp_opt *optp, tvbuff_t *tvb, int offset,
-                       guint optlen, frame_data *fd, proto_tree *opt_tree)
+                       guint optlen, packet_info *pinfo _U_,
+                       proto_tree *opt_tree)
 {
   proto_tree *field_tree = NULL;
   proto_item *tf;
@@ -701,13 +426,14 @@ dissect_ipopt_security(const ip_tcp_opt *optp, tvbuff_t *tvb, int offset,
 
 static void
 dissect_ipopt_route(const ip_tcp_opt *optp, tvbuff_t *tvb, int offset,
-                       guint optlen, frame_data *fd, proto_tree *opt_tree)
+                       guint optlen, packet_info *pinfo _U_,
+                       proto_tree *opt_tree)
 {
   proto_tree *field_tree = NULL;
   proto_item *tf;
   int ptr;
   int optoffset = 0;
-  struct in_addr addr;
+  guint32 addr;
 
   tf = proto_tree_add_text(opt_tree, tvb, offset,      optlen, "%s (%u bytes)",
                                optp->name, optlen);
@@ -737,7 +463,7 @@ dissect_ipopt_route(const ip_tcp_opt *optp, tvbuff_t *tvb, int offset,
 
     proto_tree_add_text(field_tree, tvb, offset + optoffset, 4,
               "%s%s",
-              ((addr.s_addr == 0) ? "-" : (char *)get_hostname(addr.s_addr)),
+              ((addr == 0) ? "-" : (char *)get_hostname(addr)),
               ((optoffset == ptr) ? " <- (current)" : ""));
     optoffset += 4;
     optlen -= 4;
@@ -746,7 +472,8 @@ dissect_ipopt_route(const ip_tcp_opt *optp, tvbuff_t *tvb, int offset,
 
 static void
 dissect_ipopt_sid(const ip_tcp_opt *optp, tvbuff_t *tvb, int offset,
-                       guint optlen, frame_data *fd, proto_tree *opt_tree)
+                       guint optlen, packet_info *pinfo _U_,
+                       proto_tree *opt_tree)
 {
   proto_tree_add_text(opt_tree, tvb, offset,      optlen,
     "%s: %u", optp->name, tvb_get_ntohs(tvb, offset + 2));
@@ -755,7 +482,7 @@ dissect_ipopt_sid(const ip_tcp_opt *optp, tvbuff_t *tvb, int offset,
 
 static void
 dissect_ipopt_timestamp(const ip_tcp_opt *optp, tvbuff_t *tvb,
-    int offset, guint optlen, frame_data *fd, proto_tree *opt_tree)
+    int offset, guint optlen, packet_info *pinfo _U_, proto_tree *opt_tree)
 {
   proto_tree *field_tree = NULL;
   proto_item *tf;
@@ -767,7 +494,7 @@ dissect_ipopt_timestamp(const ip_tcp_opt *optp, tvbuff_t *tvb,
     {IPOPT_TS_TSANDADDR, "Time stamp and address"                },
     {IPOPT_TS_PRESPEC,   "Time stamps for prespecified addresses"},
     {0,                  NULL                                    } };
-  struct in_addr addr;
+  guint32 addr;
   guint ts;
 
   tf = proto_tree_add_text(opt_tree, tvb, offset,      optlen, "%s:", optp->name);
@@ -806,7 +533,7 @@ dissect_ipopt_timestamp(const ip_tcp_opt *optp, tvbuff_t *tvb,
       optlen -= 8;
       proto_tree_add_text(field_tree, tvb, offset + optoffset,      8,
           "Address = %s, time stamp = %u",
-          ((addr.s_addr == 0) ? "-" :  (char *)get_hostname(addr.s_addr)),
+          ((addr == 0) ? "-" :  (char *)get_hostname(addr)),
           ts);
       optoffset += 8;
     } else {
@@ -826,15 +553,15 @@ dissect_ipopt_timestamp(const ip_tcp_opt *optp, tvbuff_t *tvb,
 
 static void
 dissect_ipopt_ra(const ip_tcp_opt *optp, tvbuff_t *tvb, int offset,
-               guint optlen, frame_data *fd, proto_tree *opt_tree)
+               guint optlen, packet_info *pinfo _U_, proto_tree *opt_tree)
 {
   /* Router-Alert, as defined by RFC2113 */
   int opt = tvb_get_ntohs(tvb, offset + 2);
-  static const value_string ra_opts[] = { 
+  static const value_string ra_opts[] = {
        {0, "Every router examines packet"},
        {0, NULL}
   };
-  
+
   proto_tree_add_text(opt_tree, tvb, offset,      optlen,
     "%s: %s", optp->name, val_to_str(opt, ra_opts, "Unknown (%d)"));
   return;
@@ -921,16 +648,16 @@ static const ip_tcp_opt ipopts[] = {
 void
 dissect_ip_tcp_options(tvbuff_t *tvb, int offset, guint length,
                        const ip_tcp_opt *opttab, int nopts, int eol,
-                       frame_data *fd, proto_tree *opt_tree)
+                       packet_info *pinfo, proto_tree *opt_tree)
 {
-  u_char            opt;
+  guchar            opt;
   const ip_tcp_opt *optp;
   opt_len_type      len_type;
-  int               optlen;
+  unsigned int      optlen;
   char             *name;
   char              name_str[7+1+1+2+2+1+1];   /* "Unknown (0x%02x)" */
   void            (*dissect)(const struct ip_tcp_opt *, tvbuff_t *,
-                               int, guint, frame_data *, proto_tree *);
+                               int, guint, packet_info *, proto_tree *);
   guint             len;
 
   while (length > 0) {
@@ -1002,7 +729,7 @@ dissect_ip_tcp_options(tvbuff_t *tvb, int offset, guint length,
         } else {
           if (dissect != NULL) {
             /* Option has a dissector. */
-            (*dissect)(optp, tvb, offset,          len, fd, opt_tree);
+            (*dissect)(optp, tvb, offset,          len, pinfo, opt_tree);
           } else {
             /* Option has no data, hence no dissector. */
             proto_tree_add_text(opt_tree, tvb, offset,  len, "%s", name);
@@ -1021,7 +748,7 @@ dissect_ip_tcp_options(tvbuff_t *tvb, int offset, guint length,
   }
 }
 
-static const value_string dscp_vals[] = {
+const value_string dscp_vals[] = {
                  { IPDSFIELD_DSCP_DEFAULT, "Default"               },
                  { IPDSFIELD_DSCP_CS1,     "Class Selector 1"      },
                  { IPDSFIELD_DSCP_CS2,     "Class Selector 2"      },
@@ -1076,11 +803,6 @@ static const true_false_string tos_set_high = {
   "Normal"
 };
 
-static const true_false_string flags_set_truth = {
-  "Set",
-  "Not set"
-};
-
 static guint16 ip_checksum(const guint8 *ptr, int len)
 {
        vec_t cksum_vec[1];
@@ -1093,297 +815,237 @@ static guint16 ip_checksum(const guint8 *ptr, int len)
 static void
 dissect_ip(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
 {
-  e_ip       iph;
   proto_tree *ip_tree = NULL, *field_tree;
-  proto_item *ti, *tf;
+  proto_item *ti = NULL, *tf;
+  guint32    addr;
   int        offset = 0;
-  guint      hlen, optlen, len, payload_len, reported_payload_len, padding;
+  guint      hlen, optlen;
   guint16    flags;
   guint8     nxt;
   guint16    ipsum;
-  ip_fragment_data *ipfd_head;
+  fragment_data *ipfd_head=NULL;
   tvbuff_t   *next_tvb;
-  packet_info save_pi;
-  gboolean must_restore_pi = FALSE;
-  gboolean update_col_info = TRUE;
-
-  if (check_col(pinfo->fd, COL_PROTOCOL))
-    col_set_str(pinfo->fd, COL_PROTOCOL, "IP");
-  if (check_col(pinfo->fd, COL_INFO))
-    col_clear(pinfo->fd, COL_INFO);
-
-  /* Avoids alignment problems on many architectures. */
-  tvb_memcpy(tvb, (guint8 *)&iph, offset, sizeof(e_ip));
-  iph.ip_len = ntohs(iph.ip_len);
-  iph.ip_id  = ntohs(iph.ip_id);
-  iph.ip_off = ntohs(iph.ip_off);
-  iph.ip_sum = ntohs(iph.ip_sum);
-
-  /* Length of payload handed to us. */
-  reported_payload_len = tvb_reported_length(tvb);
-  payload_len = tvb_length(tvb);
-
-  /* Length of IP datagram. */
-  len = iph.ip_len;
-
-  if (len < reported_payload_len) {
-    /* Adjust the length of this tvbuff to include only the IP datagram.
-       Our caller may use that to determine how much of its packet
-       was padding. */
-    tvb_set_reported_length(tvb, len);
-
-    /* Shrink the total payload by the amount of padding. */
-    padding = reported_payload_len - len;
-    if (pinfo->len >= padding)
-      pinfo->len -= padding;
-
-    /* Shrink the captured payload by the amount of padding in the
-       captured payload (which may be less than the amount of padding,
-       as the padding may not have been captured). */
-    if (len < payload_len) {
-      padding = payload_len - len;
-      if (pinfo->captured_len >= padding)
-        pinfo->captured_len -= padding;
-    }
+  gboolean   update_col_info = TRUE;
+  gboolean   save_fragmented;
+  static e_ip eip_arr[4];
+  static int eip_current=0;
+  e_ip *iph;
+
+  eip_current++;
+  if(eip_current==4){
+     eip_current=0;
   }
+  iph=&eip_arr[eip_current];
+
+  if (check_col(pinfo->cinfo, COL_PROTOCOL))
+    col_set_str(pinfo->cinfo, COL_PROTOCOL, "IP");
+  if (check_col(pinfo->cinfo, COL_INFO))
+    col_clear(pinfo->cinfo, COL_INFO);
+
+  iph->ip_v_hl = tvb_get_guint8(tvb, offset);
+  hlen = lo_nibble(iph->ip_v_hl) * 4;  /* IP header length, in bytes */
 
-  hlen = lo_nibble(iph.ip_v_hl) * 4;   /* IP header length, in bytes */
   if (tree) {
-    if (ip_summary_in_tree && hlen >= IPH_MIN_LEN) {
-      ti = proto_tree_add_protocol_format(tree, proto_ip, tvb, offset, hlen,
-               "Internet Protocol, Src Addr: %s (%s), Dst Addr: %s (%s)",
-               get_hostname(iph.ip_src), ip_to_str((guint8 *) &iph.ip_src),
-               get_hostname(iph.ip_dst), ip_to_str((guint8 *) &iph.ip_dst));
-    } else {
-      ti = proto_tree_add_item(tree, proto_ip, tvb, offset, hlen, FALSE);
-    }
+    ti = proto_tree_add_item(tree, proto_ip, tvb, offset, hlen, FALSE);
     ip_tree = proto_item_add_subtree(ti, ett_ip);
+
+    proto_tree_add_uint(ip_tree, hf_ip_version, tvb, offset, 1,
+       hi_nibble(iph->ip_v_hl));
   }
 
   if (hlen < IPH_MIN_LEN) {
-    if (check_col(pinfo->fd, COL_INFO))
-      col_add_fstr(pinfo->fd, COL_INFO, "Bogus IP header length (%u, must be at least %u)",
+    if (check_col(pinfo->cinfo, COL_INFO))
+      col_add_fstr(pinfo->cinfo, COL_INFO, "Bogus IP header length (%u, must be at least %u)",
        hlen, IPH_MIN_LEN);
     if (tree) {
       proto_tree_add_uint_format(ip_tree, hf_ip_hdr_len, tvb, offset, 1, hlen,
-       "Header length: %u bytes (bogus, must be at least %u)", hlen,
-       IPH_MIN_LEN);
+       "Header length: %u bytes (bogus, must be at least %u)", hlen,
+       IPH_MIN_LEN);
     }
-    return;
+    goto end_of_ip;
   }
 
-  /*
-   * Compute the checksum of the IP header.
-   */
-  ipsum = ip_checksum(tvb_get_ptr(tvb, offset, hlen), hlen);
-
   if (tree) {
-    proto_tree_add_uint(ip_tree, hf_ip_version, tvb, offset, 1, hi_nibble(iph.ip_v_hl));
     proto_tree_add_uint_format(ip_tree, hf_ip_hdr_len, tvb, offset, 1, hlen,
        "Header length: %u bytes", hlen);
+  }
 
+  iph->ip_tos = tvb_get_guint8(tvb, offset + 1);
+  if (tree) {
     if (g_ip_dscp_actif) {
-      tf = proto_tree_add_uint_format(ip_tree, hf_ip_dsfield, tvb, offset + 1, 1, iph.ip_tos,
-          "Differentiated Services Field: 0x%02x (DSCP 0x%02x: %s; ECN: 0x%02x)", iph.ip_tos,
-          IPDSFIELD_DSCP(iph.ip_tos), val_to_str(IPDSFIELD_DSCP(iph.ip_tos), dscp_vals,
-          "Unknown DSCP"),IPDSFIELD_ECN(iph.ip_tos));
+      tf = proto_tree_add_uint_format(ip_tree, hf_ip_dsfield, tvb, offset + 1, 1, iph->ip_tos,
+          "Differentiated Services Field: 0x%02x (DSCP 0x%02x: %s; ECN: 0x%02x)", iph->ip_tos,
+          IPDSFIELD_DSCP(iph->ip_tos), val_to_str(IPDSFIELD_DSCP(iph->ip_tos), dscp_vals,
+          "Unknown DSCP"),IPDSFIELD_ECN(iph->ip_tos));
 
       field_tree = proto_item_add_subtree(tf, ett_ip_dsfield);
-      proto_tree_add_uint(field_tree, hf_ip_dsfield_dscp, tvb, offset + 1, 1, iph.ip_tos);
-      proto_tree_add_uint(field_tree, hf_ip_dsfield_ect, tvb, offset + 1, 1, iph.ip_tos);
-      proto_tree_add_uint(field_tree, hf_ip_dsfield_ce, tvb, offset + 1, 1, iph.ip_tos);
+      proto_tree_add_uint(field_tree, hf_ip_dsfield_dscp, tvb, offset + 1, 1, iph->ip_tos);
+      proto_tree_add_uint(field_tree, hf_ip_dsfield_ect, tvb, offset + 1, 1, iph->ip_tos);
+      proto_tree_add_uint(field_tree, hf_ip_dsfield_ce, tvb, offset + 1, 1, iph->ip_tos);
     } else {
-      tf = proto_tree_add_uint_format(ip_tree, hf_ip_tos, tvb, offset + 1, 1, iph.ip_tos,
-         "Type of service: 0x%02x (%s)", iph.ip_tos,
-         val_to_str( IPTOS_TOS(iph.ip_tos), iptos_vals, "Unknown") );
+      tf = proto_tree_add_uint_format(ip_tree, hf_ip_tos, tvb, offset + 1, 1, iph->ip_tos,
+         "Type of service: 0x%02x (%s)", iph->ip_tos,
+         val_to_str( IPTOS_TOS(iph->ip_tos), iptos_vals, "Unknown") );
 
       field_tree = proto_item_add_subtree(tf, ett_ip_tos);
-      proto_tree_add_uint(field_tree, hf_ip_tos_precedence, tvb, offset + 1, 1, iph.ip_tos);
-      proto_tree_add_boolean(field_tree, hf_ip_tos_delay, tvb, offset + 1, 1, iph.ip_tos);
-      proto_tree_add_boolean(field_tree, hf_ip_tos_throughput, tvb, offset + 1, 1, iph.ip_tos);
-      proto_tree_add_boolean(field_tree, hf_ip_tos_reliability, tvb, offset + 1, 1, iph.ip_tos);
-      proto_tree_add_boolean(field_tree, hf_ip_tos_cost, tvb, offset + 1, 1, iph.ip_tos);
+      proto_tree_add_uint(field_tree, hf_ip_tos_precedence, tvb, offset + 1, 1, iph->ip_tos);
+      proto_tree_add_boolean(field_tree, hf_ip_tos_delay, tvb, offset + 1, 1, iph->ip_tos);
+      proto_tree_add_boolean(field_tree, hf_ip_tos_throughput, tvb, offset + 1, 1, iph->ip_tos);
+      proto_tree_add_boolean(field_tree, hf_ip_tos_reliability, tvb, offset + 1, 1, iph->ip_tos);
+      proto_tree_add_boolean(field_tree, hf_ip_tos_cost, tvb, offset + 1, 1, iph->ip_tos);
+    }
+  }
+
+  /* Length of IP datagram.
+     XXX - what if this is greater than the reported length of the
+     tvbuff?  This could happen, for example, in an IP datagram
+     inside an ICMP datagram; we need to somehow let the
+     dissector we call know that, as it might want to avoid
+     doing its checksumming. */
+  iph->ip_len = tvb_get_ntohs(tvb, offset + 2);
+
+  /* Adjust the length of this tvbuff to include only the IP datagram. */
+  set_actual_length(tvb, iph->ip_len);
+
+  if (iph->ip_len < hlen) {
+    if (check_col(pinfo->cinfo, COL_INFO))
+      col_add_fstr(pinfo->cinfo, COL_INFO, "Bogus IP length (%u, less than header length %u)",
+       iph->ip_len, hlen);
+    if (tree) {
+      proto_tree_add_uint_format(ip_tree, hf_ip_len, tvb, offset + 2, 2, iph->ip_len,
+       "Total length: %u bytes (bogus, less than header length %u)", iph->ip_len,
+       hlen);
     }
-    proto_tree_add_uint(ip_tree, hf_ip_len, tvb, offset +  2, 2, iph.ip_len);
-    proto_tree_add_uint(ip_tree, hf_ip_id, tvb, offset +  4, 2, iph.ip_id);
+    goto end_of_ip;
+  }
+  if (tree)
+    proto_tree_add_uint(ip_tree, hf_ip_len, tvb, offset + 2, 2, iph->ip_len);
+
+  iph->ip_id  = tvb_get_ntohs(tvb, offset + 4);
+  if (tree)
+    proto_tree_add_uint_format(ip_tree, hf_ip_id, tvb, offset + 4, 2, iph->ip_id, "Identification: 0x%04x (%d)", iph->ip_id, iph->ip_id);
 
-    flags = (iph.ip_off & (IP_DF|IP_MF)) >> 12;
-    tf = proto_tree_add_uint(ip_tree, hf_ip_flags, tvb, offset +  6, 1, flags);
+  iph->ip_off = tvb_get_ntohs(tvb, offset + 6);
+  if (tree) {
+    flags = (iph->ip_off & (IP_DF|IP_MF)) >> 12;
+    tf = proto_tree_add_uint(ip_tree, hf_ip_flags, tvb, offset + 6, 1, flags);
     field_tree = proto_item_add_subtree(tf, ett_ip_off);
     proto_tree_add_boolean(field_tree, hf_ip_flags_df, tvb, offset + 6, 1, flags),
     proto_tree_add_boolean(field_tree, hf_ip_flags_mf, tvb, offset + 6, 1, flags),
 
-    proto_tree_add_uint(ip_tree, hf_ip_frag_offset, tvb, offset +  6, 2,
-      (iph.ip_off & IP_OFFSET)*8);
+    proto_tree_add_uint(ip_tree, hf_ip_frag_offset, tvb, offset + 6, 2,
+      (iph->ip_off & IP_OFFSET)*8);
+  }
+
+  if (tree)
+    proto_tree_add_item(ip_tree, hf_ip_ttl, tvb, offset + 8, 1, FALSE);
 
-    proto_tree_add_uint(ip_tree, hf_ip_ttl, tvb, offset +  8, 1, iph.ip_ttl);
-    proto_tree_add_uint_format(ip_tree, hf_ip_proto, tvb, offset +  9, 1, iph.ip_p,
-       "Protocol: %s (0x%02x)", ipprotostr(iph.ip_p), iph.ip_p);
+  iph->ip_p = tvb_get_guint8(tvb, offset + 9);
+  if (tree) {
+    proto_tree_add_uint_format(ip_tree, hf_ip_proto, tvb, offset + 9, 1, iph->ip_p,
+       "Protocol: %s (0x%02x)", ipprotostr(iph->ip_p), iph->ip_p);
+  }
+
+  iph->ip_sum = tvb_get_ntohs(tvb, offset + 10);
 
-    if (ipsum == 0) {
-       proto_tree_add_uint_format(ip_tree, hf_ip_checksum, tvb, offset + 10, 2, iph.ip_sum,
-              "Header checksum: 0x%04x (correct)", iph.ip_sum);
+  /*
+   * If we have the entire IP header available, check the checksum.
+   */
+  if (tvb_bytes_exist(tvb, offset, hlen)) {
+    ipsum = ip_checksum(tvb_get_ptr(tvb, offset, hlen), hlen);
+    if (tree) {
+      if (ipsum == 0) {
+       proto_tree_add_uint_format(ip_tree, hf_ip_checksum, tvb, offset + 10, 2, iph->ip_sum,
+              "Header checksum: 0x%04x (correct)", iph->ip_sum);
+      }
+      else {
+       proto_tree_add_boolean_hidden(ip_tree, hf_ip_checksum_bad, tvb, offset + 10, 2, TRUE);
+       proto_tree_add_uint_format(ip_tree, hf_ip_checksum, tvb, offset + 10, 2, iph->ip_sum,
+          "Header checksum: 0x%04x (incorrect, should be 0x%04x)", iph->ip_sum,
+         in_cksum_shouldbe(iph->ip_sum, ipsum));
+      }
     }
-    else {
-       proto_tree_add_item_hidden(ip_tree, hf_ip_checksum_bad, tvb, offset + 10, 2, TRUE);
-       proto_tree_add_uint_format(ip_tree, hf_ip_checksum, tvb, offset + 10, 2, iph.ip_sum,
-          "Header checksum: 0x%04x (incorrect, should be 0x%04x)", iph.ip_sum,
-         in_cksum_shouldbe(iph.ip_sum, ipsum));
+  } else {
+    ipsum = 0;
+    if (tree)
+      proto_tree_add_uint(ip_tree, hf_ip_checksum, tvb, offset + 10, 2, iph->ip_sum);
+  }
+
+  SET_ADDRESS(&pinfo->net_src, AT_IPv4, 4, tvb_get_ptr(tvb, offset + IPH_SRC, 4));
+  SET_ADDRESS(&pinfo->src, AT_IPv4, 4, tvb_get_ptr(tvb, offset + IPH_SRC, 4));
+  SET_ADDRESS(&iph->ip_src, AT_IPv4, 4, tvb_get_ptr(tvb, offset + IPH_SRC, 4));
+  if (tree) {
+    memcpy(&addr, iph->ip_src.data, 4);
+    if (ip_summary_in_tree) {
+      proto_item_append_text(ti, ", Src Addr: %s (%s)",
+               get_hostname(addr), ip_to_str((guint8 *) iph->ip_src.data));
     }
+    proto_tree_add_ipv4(ip_tree, hf_ip_src, tvb, offset + 12, 4, addr);
+    proto_tree_add_ipv4_hidden(ip_tree, hf_ip_addr, tvb, offset + 12, 4, addr);
+  }
 
-    proto_tree_add_ipv4(ip_tree, hf_ip_src, tvb, offset + 12, 4, iph.ip_src);
-    proto_tree_add_ipv4(ip_tree, hf_ip_dst, tvb, offset + 16, 4, iph.ip_dst);
-    proto_tree_add_ipv4_hidden(ip_tree, hf_ip_addr, tvb, offset + 12, 4, iph.ip_src);
-    proto_tree_add_ipv4_hidden(ip_tree, hf_ip_addr, tvb, offset + 16, 4, iph.ip_dst);
+  SET_ADDRESS(&pinfo->net_dst, AT_IPv4, 4, tvb_get_ptr(tvb, offset + IPH_DST, 4));
+  SET_ADDRESS(&pinfo->dst, AT_IPv4, 4, tvb_get_ptr(tvb, offset + IPH_DST, 4));
+  SET_ADDRESS(&iph->ip_dst, AT_IPv4, 4, tvb_get_ptr(tvb, offset + IPH_DST, 4));
 
+  if (tree) {
+    memcpy(&addr, iph->ip_dst.data, 4);
+    if (ip_summary_in_tree) {
+      proto_item_append_text(ti, ", Dst Addr: %s (%s)",
+               get_hostname(addr), ip_to_str((guint8 *) iph->ip_dst.data));
+    }
+    proto_tree_add_ipv4(ip_tree, hf_ip_dst, tvb, offset + 16, 4, addr);
+    proto_tree_add_ipv4_hidden(ip_tree, hf_ip_addr, tvb, offset + 16, 4, addr);
+  }
+
+  if (tree) {
     /* Decode IP options, if any. */
-    if (hlen > sizeof (e_ip)) {
+    if (hlen > IPH_MIN_LEN) {
       /* There's more than just the fixed-length header.  Decode the
          options. */
-      optlen = hlen - sizeof (e_ip);   /* length of options, in bytes */
-      tf = proto_tree_add_text(ip_tree, tvb, offset +  20, optlen,
+      optlen = hlen - IPH_MIN_LEN;     /* length of options, in bytes */
+      tf = proto_tree_add_text(ip_tree, tvb, offset + 20, optlen,
         "Options: (%u bytes)", optlen);
       field_tree = proto_item_add_subtree(tf, ett_ip_options);
       dissect_ip_tcp_options(tvb, offset + 20, optlen,
-         ipopts, N_IP_OPTS, IPOPT_END, pinfo->fd, field_tree);
+         ipopts, N_IP_OPTS, IPOPT_END, pinfo, field_tree);
     }
   }
 
-  pinfo->ipproto = iph.ip_p;
+  pinfo->ipproto = iph->ip_p;
 
-  pinfo->iplen = iph.ip_len;
+  pinfo->iplen = iph->ip_len;
 
-  pinfo->iphdrlen = lo_nibble(iph.ip_v_hl);
-
-  SET_ADDRESS(&pinfo->net_src, AT_IPv4, 4, tvb_get_ptr(tvb, offset + IPH_SRC, 4));
-  SET_ADDRESS(&pinfo->src, AT_IPv4, 4, tvb_get_ptr(tvb, offset + IPH_SRC, 4));
-  SET_ADDRESS(&pinfo->net_dst, AT_IPv4, 4, tvb_get_ptr(tvb, offset + IPH_DST, 4));
-  SET_ADDRESS(&pinfo->dst, AT_IPv4, 4, tvb_get_ptr(tvb, offset + IPH_DST, 4));
+  pinfo->iphdrlen = hlen;
 
   /* Skip over header + options */
   offset += hlen;
-  nxt = iph.ip_p;      /* XXX - what if this isn't the same for all fragments? */
+  nxt = iph->ip_p;     /* XXX - what if this isn't the same for all fragments? */
 
-  /* If ip_defragment is on and this is a fragment, then just add the fragment
-   * to the hashtable.
+  /* If ip_defragment is on, this is a fragment, we have all the data
+   * in the fragment, and the header checksum is valid, then just add
+   * the fragment to the hashtable.
    */
-  if (ip_defragment && (iph.ip_off & (IP_MF|IP_OFFSET))) {
-    /* We're reassembling, and this is part of a fragmented datagram.
-       Add the fragment to the hash table if the checksum is ok
-       and the frame isn't truncated. */
-    if ((ipsum==0) && (tvb_reported_length(tvb) <= tvb_length(tvb))) {
-      ipfd_head = ip_fragment_add(tvb, offset, pinfo, iph.ip_id, iph.ip_off);
-    } else {
-      ipfd_head=NULL;
-    }
-
-    if (ipfd_head != NULL) {
-      ip_fragment_data *ipfd;
-      proto_tree *ft=NULL;
-      proto_item *fi=NULL;
-
-      /* OK, we have the complete reassembled payload. */
-      /* show all fragments */
-      fi = proto_tree_add_item(ip_tree, hf_ip_fragments, 
-                tvb, 0, 0, FALSE);
-      ft = proto_item_add_subtree(fi, ett_ip_fragments);
-      for (ipfd=ipfd_head->next; ipfd; ipfd=ipfd->next){
-        if (ipfd->flags & (IPD_OVERLAP|IPD_OVERLAPCONFLICT
-                          |IPD_MULTIPLETAILS|IPD_TOOLONGFRAGMENT) ) {
-          /* this fragment has some flags set, create a subtree 
-           * for it and display the flags.
-           */
-          proto_tree *fet=NULL;
-          proto_item *fei=NULL;
-          int hf;
-
-          if (ipfd->flags & (IPD_OVERLAPCONFLICT
-                      |IPD_MULTIPLETAILS|IPD_TOOLONGFRAGMENT) ) {
-            hf = hf_ip_fragment_error;
-          } else {
-            hf = hf_ip_fragment;
-          }
-          fei = proto_tree_add_string_format(ft, hf, 
-                   tvb, 0, 0, 0,
-                   "Frame:%d payload:%d-%d",
-                   ipfd->frame,
-                   ipfd->offset,
-                   ipfd->offset+ipfd->len-1
-          );
-          fet = proto_item_add_subtree(fei, ett_ip_fragment);
-          if (ipfd->flags&IPD_OVERLAP) {
-            proto_tree_add_boolean(fet, 
-                 hf_ip_fragment_overlap, tvb, 0, 0, 
-                 TRUE);
-          }
-          if (ipfd->flags&IPD_OVERLAPCONFLICT) {
-            proto_tree_add_boolean(fet, 
-                 hf_ip_fragment_overlap_conflict, tvb, 0, 0, 
-                 TRUE);
-          }
-          if (ipfd->flags&IPD_MULTIPLETAILS) {
-            proto_tree_add_boolean(fet, 
-                 hf_ip_fragment_multiple_tails, tvb, 0, 0, 
-                 TRUE);
-          }
-          if (ipfd->flags&IPD_TOOLONGFRAGMENT) {
-            proto_tree_add_boolean(fet, 
-                 hf_ip_fragment_too_long_fragment, tvb, 0, 0, 
-                 TRUE);
-          }
-        } else {
-          /* nothing of interest for this fragment */
-          proto_tree_add_string_format(ft, hf_ip_fragment, 
-                   tvb, 0, 0, 0,
-                   "Frame:%d payload:%d-%d",
-                   ipfd->frame,
-                   ipfd->offset,
-                   ipfd->offset+ipfd->len-1
-          );
-        }
-      }
-      if (ipfd_head->flags & (IPD_OVERLAPCONFLICT
-                        |IPD_MULTIPLETAILS|IPD_TOOLONGFRAGMENT) ) {
-        if (check_col(pinfo->fd, COL_INFO)) {
-          col_set_str(pinfo->fd, COL_INFO, "[Illegal fragments]");
-          update_col_info = FALSE;
-        }
-      }
-
-      /* Allocate a new tvbuff, referring to the reassembled payload. */
-      next_tvb = tvb_new_real_data(ipfd_head->data, ipfd_head->datalen,
-       ipfd_head->datalen, "Reassembled");
-
-      /* Add the tvbuff to the list of tvbuffs to which the tvbuff we
-         were handed refers, so it'll get cleaned up when that tvbuff
-         is cleaned up. */
-      tvb_set_child_real_data_tvbuff(tvb, next_tvb);
-
-      /* Add the defragmented data to the data source list. */
-      pinfo->fd->data_src = g_slist_append(pinfo->fd->data_src, next_tvb);
-
-      /* It's not fragmented. */
-      pinfo->fragmented = FALSE;
-
-      /* Save the current value of "pi", and adjust certain fields to
-         reflect the new tvbuff. */
-      save_pi = pi;
-      pi.compat_top_tvb = next_tvb;
-      pi.len = tvb_reported_length(next_tvb);
-      pi.captured_len = tvb_length(next_tvb);
-      must_restore_pi = TRUE;
-    } else {
-      /* We don't have the complete reassembled payload. */
-      next_tvb = NULL;
-    }
+  save_fragmented = pinfo->fragmented;
+  if (ip_defragment && (iph->ip_off & (IP_MF|IP_OFFSET)) &&
+      tvb_bytes_exist(tvb, offset, pinfo->iplen - pinfo->iphdrlen) &&
+      ipsum == 0) {
+    ipfd_head = fragment_add_check(tvb, offset, pinfo, iph->ip_id,
+                            ip_fragment_table,
+                            ip_reassembled_table,
+                            (iph->ip_off & IP_OFFSET)*8,
+                            pinfo->iplen - pinfo->iphdrlen,
+                            iph->ip_off & IP_MF);
+
+    next_tvb = process_reassembled_data(tvb, offset, pinfo, "Reassembled IPv4",
+      ipfd_head, &ip_frag_items, &update_col_info, ip_tree);
   } else {
     /* If this is the first fragment, dissect its contents, otherwise
        just show it as a fragment.
 
        XXX - if we eventually don't save the reassembled contents of all
        fragmented datagrams, we may want to always reassemble. */
-    if (iph.ip_off & IP_OFFSET) {
+    if (iph->ip_off & IP_OFFSET) {
       /* Not the first fragment - don't dissect it. */
       next_tvb = NULL;
     } else {
@@ -1396,7 +1058,7 @@ dissect_ip(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
        * If this is the first fragment, but not the only fragment,
        * tell the next protocol that.
        */
-      if (iph.ip_off & IP_MF)
+      if (iph->ip_off & IP_MF)
         pinfo->fragmented = TRUE;
       else
         pinfo->fragmented = FALSE;
@@ -1405,14 +1067,21 @@ dissect_ip(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
 
   if (next_tvb == NULL) {
     /* Just show this as a fragment. */
-    if (check_col(pinfo->fd, COL_INFO))
-      col_add_fstr(pinfo->fd, COL_INFO, "Fragmented IP protocol (proto=%s 0x%02x, off=%u)",
-       ipprotostr(iph.ip_p), iph.ip_p, (iph.ip_off & IP_OFFSET) * 8);
-    dissect_data(tvb, offset, pinfo, tree);
+    if (check_col(pinfo->cinfo, COL_INFO)) {
+      col_add_fstr(pinfo->cinfo, COL_INFO, "Fragmented IP protocol (proto=%s 0x%02x, off=%u)",
+       ipprotostr(iph->ip_p), iph->ip_p, (iph->ip_off & IP_OFFSET) * 8);
+    }
+    if( ipfd_head && ipfd_head->reassembled_in != pinfo->fd->num ){
+      if (check_col(pinfo->cinfo, COL_INFO)) {
+        col_append_fstr(pinfo->cinfo, COL_INFO, " [Reassembled in #%u]",
+          ipfd_head->reassembled_in);
+      }
+    }
 
-    /* As we haven't reassembled anything, we haven't changed "pi", so
-       we don't have to restore it. */
-    return;
+    call_dissector(data_handle, tvb_new_subset(tvb, offset, -1, -1), pinfo,
+                   tree);
+    pinfo->fragmented = save_fragmented;
+    goto end_of_ip;
   }
 
   /* Hand off to the next protocol.
@@ -1425,16 +1094,166 @@ dissect_ip(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
   if (!dissector_try_port(ip_dissector_table, nxt, next_tvb, pinfo, tree)) {
     /* Unknown protocol */
     if (update_col_info) {
-      if (check_col(pinfo->fd, COL_INFO))
-        col_add_fstr(pinfo->fd, COL_INFO, "%s (0x%02x)", ipprotostr(iph.ip_p), iph.ip_p);
+      if (check_col(pinfo->cinfo, COL_INFO))
+        col_add_fstr(pinfo->cinfo, COL_INFO, "%s (0x%02x)", ipprotostr(iph->ip_p), iph->ip_p);
     }
-    dissect_data(next_tvb, 0, pinfo, tree);
+    call_dissector(data_handle,next_tvb, pinfo, tree);
   }
+  pinfo->fragmented = save_fragmented;
+
+end_of_ip:
+  tap_queue_packet(ip_tap, pinfo, iph);
 
-  if (must_restore_pi)
-    pi = save_pi;
 }
 
+#define ICMP_MIP_EXTENSION_PAD 0
+#define ICMP_MIP_MOB_AGENT_ADV 16
+#define ICMP_MIP_PREFIX_LENGTHS        19
+#define ICMP_MIP_CHALLENGE     24
+
+static value_string mip_extensions[] = {
+  { ICMP_MIP_EXTENSION_PAD, "One byte padding extension"},  /* RFC 2002 */
+  { ICMP_MIP_MOB_AGENT_ADV, "Mobility Agent Advertisement Extension"},
+                                                           /* RFC 2002 */
+  { ICMP_MIP_PREFIX_LENGTHS, "Prefix Lengths Extension"},   /* RFC 2002 */
+  { ICMP_MIP_CHALLENGE, "Challenge Extension"},             /* RFC 3012 */
+  { 0, NULL}
+};
+
+/*
+ * Dissect the mobile ip advertisement extensions.
+ */
+static void
+dissect_mip_extensions(tvbuff_t *tvb, size_t offset, proto_tree *tree)
+{
+  guint8       type;
+  guint8       length;
+  guint8       flags;
+  proto_item   *ti;
+  proto_tree   *mip_tree=NULL;
+  proto_tree   *flags_tree=NULL;
+  gint         numCOAs;
+  gint         i;
+
+  /* Not much to do if we're not parsing everything */
+  if (!tree) return;
+
+  while (tvb_reported_length_remaining(tvb, offset) > 0) {
+
+       type = tvb_get_guint8(tvb, offset + 0);
+       if (type)
+         length = tvb_get_guint8(tvb, offset + 1);
+       else
+         length=0;
+
+       ti = proto_tree_add_text(tree, tvb, offset,
+                                                        type?(length + 2):1,
+                                                        "Ext: %s",
+                                                        val_to_str(type, mip_extensions,
+                                                                               "Unknown ext %u"));
+       mip_tree = proto_item_add_subtree(ti, ett_icmp_mip);
+
+
+       switch (type) {
+       case ICMP_MIP_EXTENSION_PAD:
+         /* One byte padding extension */
+         /* Add our fields */
+         /* type */
+         proto_tree_add_item(mip_tree, hf_icmp_mip_type, tvb, offset,
+                                                 1, FALSE);
+         offset++;
+         break;
+       case ICMP_MIP_MOB_AGENT_ADV:
+         /* Mobility Agent Advertisement Extension (RFC 2002)*/
+         /* Add our fields */
+         /* type */
+         proto_tree_add_item(mip_tree, hf_icmp_mip_type, tvb, offset,
+                                                 1, FALSE);
+         offset++;
+         /* length */
+         proto_tree_add_item(mip_tree, hf_icmp_mip_length, tvb, offset,
+                                                 1, FALSE);
+         offset++;
+         /* sequence number */
+         proto_tree_add_item(mip_tree, hf_icmp_mip_seq, tvb, offset,
+                                                 2, FALSE);
+         offset+=2;
+         /* Registration Lifetime */
+         proto_tree_add_item(mip_tree, hf_icmp_mip_life, tvb, offset,
+                                                 2, FALSE);
+         offset+=2;
+         /* flags */
+         flags = tvb_get_guint8(tvb, offset);
+         ti = proto_tree_add_item(mip_tree, hf_icmp_mip_flags, tvb, offset,
+                                                          1, FALSE);
+         flags_tree = proto_item_add_subtree(ti, ett_icmp_mip_flags);
+         proto_tree_add_boolean(flags_tree, hf_icmp_mip_r, tvb, offset, 1, flags);
+         proto_tree_add_boolean(flags_tree, hf_icmp_mip_b, tvb, offset, 1, flags);
+         proto_tree_add_boolean(flags_tree, hf_icmp_mip_h, tvb, offset, 1, flags);
+         proto_tree_add_boolean(flags_tree, hf_icmp_mip_f, tvb, offset, 1, flags);
+         proto_tree_add_boolean(flags_tree, hf_icmp_mip_m, tvb, offset, 1, flags);
+         proto_tree_add_boolean(flags_tree, hf_icmp_mip_g, tvb, offset, 1, flags);
+         proto_tree_add_boolean(flags_tree, hf_icmp_mip_v, tvb, offset, 1, flags);
+         proto_tree_add_boolean(flags_tree, hf_icmp_mip_res, tvb, offset, 1, flags);
+         offset++;
+
+         /* Reserved */
+         proto_tree_add_item(mip_tree, hf_icmp_mip_reserved, tvb, offset,
+                                                 1, FALSE);
+         offset++;
+
+         /* COAs */
+         numCOAs = (length - 6) / 4;
+         for (i=0; i<numCOAs; i++) {
+               proto_tree_add_item(mip_tree, hf_icmp_mip_coa, tvb, offset,
+                                                       4, FALSE);
+               offset+=4;
+         }
+         break;
+       case ICMP_MIP_PREFIX_LENGTHS:
+         /* Prefix-Lengths Extension  (RFC 2002)*/
+         /* Add our fields */
+         /* type */
+         proto_tree_add_item(mip_tree, hf_icmp_mip_type, tvb, offset,
+                                                 1, FALSE);
+         offset++;
+         /* length */
+         proto_tree_add_item(mip_tree, hf_icmp_mip_length, tvb, offset,
+                                                 1, FALSE);
+         offset++;
+
+         /* prefix lengths */
+         for(i=0; i<length; i++) {
+               proto_tree_add_item(mip_tree, hf_icmp_mip_prefix_length, tvb, offset,
+                                                       1, FALSE);
+               offset++;
+         }
+         break;
+       case ICMP_MIP_CHALLENGE:
+         /* Challenge Extension  (RFC 3012)*/
+         /* type */
+         proto_tree_add_item(mip_tree, hf_icmp_mip_type, tvb, offset,
+                                                 1, FALSE);
+         offset++;
+         /* length */
+         proto_tree_add_item(mip_tree, hf_icmp_mip_length, tvb, offset,
+                                                 1, FALSE);
+         offset++;
+         /* challenge */
+         proto_tree_add_item(mip_tree, hf_icmp_mip_challenge, tvb, offset,
+                                                 length, FALSE);
+         offset+=length;
+
+         break;
+       default:
+         g_warning("Unknown type(%u)!  I hope the length is right (%u)",
+                               type, length);
+         offset += length + 2;
+         break;
+       } /* switch type */
+  } /* end while */
+
+} /* dissect_mip_extensions */
 
 static const gchar *unreach_str[] = {"Network unreachable",
                                      "Host unreachable",
@@ -1452,7 +1271,7 @@ static const gchar *unreach_str[] = {"Network unreachable",
                                      "Communication administratively filtered",
                                      "Host precedence violation",
                                      "Precedence cutoff in effect"};
-                                     
+
 #define        N_UNREACH       (sizeof unreach_str / sizeof unreach_str[0])
 
 static const gchar *redir_str[] = {"Redirect for network",
@@ -1462,15 +1281,21 @@ static const gchar *redir_str[] = {"Redirect for network",
 
 #define        N_REDIRECT      (sizeof redir_str / sizeof redir_str[0])
 
-static const gchar *ttl_str[] = {"TTL equals 0 during transit",
-                                 "TTL equals 0 during reassembly"};
-                                 
+static const gchar *ttl_str[] = {"Time to live exceeded in transit",
+                                 "Fragment reassembly time exceeded"};
+
 #define        N_TIMXCEED      (sizeof ttl_str / sizeof ttl_str[0])
 
 static const gchar *par_str[] = {"IP header bad", "Required option missing"};
 
 #define        N_PARAMPROB     (sizeof par_str / sizeof par_str[0])
 
+/*
+ * RFC 792 for basic ICMP.
+ * RFC 1191 for ICMP_FRAG_NEEDED (with MTU of next hop).
+ * RFC 1256 for router discovery messages.
+ * RFC 2002 and 3012 for Mobile IP stuff.
+ */
 static void
 dissect_icmp(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
 {
@@ -1484,11 +1309,13 @@ dissect_icmp(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
   guint8     num_addrs = 0;
   guint8     addr_entry_size = 0;
   int        i;
+  gboolean   save_in_error_pkt;
+  tvbuff_t   *next_tvb;
 
-  if (check_col(pinfo->fd, COL_PROTOCOL))
-    col_set_str(pinfo->fd, COL_PROTOCOL, "ICMP");
-  if (check_col(pinfo->fd, COL_INFO))
-    col_clear(pinfo->fd, COL_INFO);
+  if (check_col(pinfo->cinfo, COL_PROTOCOL))
+    col_set_str(pinfo->cinfo, COL_PROTOCOL, "ICMP");
+  if (check_col(pinfo->cinfo, COL_INFO))
+    col_clear(pinfo->cinfo, COL_INFO);
 
   /* To do: check for runts, errs, etc. */
   icmp_type = tvb_get_guint8(tvb, 0);
@@ -1522,7 +1349,14 @@ dissect_icmp(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
       strcpy(type_str, "Echo (ping) request");
       break;
     case ICMP_RTRADVERT:
-      strcpy(type_str, "Router advertisement");
+      switch (icmp_code) {
+      case 16: /* Mobile-Ip */
+        strcpy(type_str, "Mobile IP Advertisement");
+        break;
+      default:
+        strcpy(type_str, "Router advertisement");
+        break;
+      } /* switch icmp_code */
       break;
     case ICMP_RTRSOLICIT:
       strcpy(type_str, "Router solicitation");
@@ -1563,21 +1397,22 @@ dissect_icmp(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
       break;
     default:
       strcpy(type_str, "Unknown ICMP (obsolete or malformed?)");
+      break;
   }
 
-  if (check_col(pinfo->fd, COL_INFO))
-    col_add_str(pinfo->fd, COL_INFO, type_str);
+  if (check_col(pinfo->cinfo, COL_INFO))
+    col_add_str(pinfo->cinfo, COL_INFO, type_str);
 
   if (tree) {
     length = tvb_length(tvb);
     reported_length = tvb_reported_length(tvb);
     ti = proto_tree_add_item(tree, proto_icmp, tvb, 0, length, FALSE);
     icmp_tree = proto_item_add_subtree(ti, ett_icmp);
-    proto_tree_add_uint_format(icmp_tree, hf_icmp_type, tvb, 0, 1, 
+    proto_tree_add_uint_format(icmp_tree, hf_icmp_type, tvb, 0, 1,
                               icmp_type,
                               "Type: %u (%s)",
                               icmp_type, type_str);
-    proto_tree_add_uint_format(icmp_tree, hf_icmp_code, tvb, 1, 1, 
+    proto_tree_add_uint_format(icmp_tree, hf_icmp_code, tvb, 1, 1,
                               icmp_code,
                               "Code: %u %s",
                               icmp_code, code_str);
@@ -1593,7 +1428,7 @@ dissect_icmp(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
                          cksum,
                          "Checksum: 0x%04x (correct)", cksum);
       } else {
-        proto_tree_add_item_hidden(icmp_tree, hf_icmp_checksum_bad,
+        proto_tree_add_boolean_hidden(icmp_tree, hf_icmp_checksum_bad,
                          tvb, 2, 2, TRUE);
         proto_tree_add_uint_format(icmp_tree, hf_icmp_checksum, tvb, 2, 2,
                  cksum,
@@ -1614,20 +1449,17 @@ dissect_icmp(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
       case ICMP_IREQREPLY:
       case ICMP_MASKREQ:
       case ICMP_MASKREPLY:
-       proto_tree_add_text(icmp_tree, tvb, 4, 2, "Identifier: 0x%04x",
-         tvb_get_ntohs(tvb, 4));
-       proto_tree_add_text(icmp_tree, tvb, 6, 2, "Sequence number: %02x:%02x",
-         tvb_get_guint8(tvb, 6), tvb_get_guint8(tvb, 7));
+        proto_tree_add_item(icmp_tree, hf_icmp_ident, tvb, 4, 2, FALSE);
+        proto_tree_add_item(icmp_tree, hf_icmp_seq_num, tvb, 6, 2, FALSE);
        break;
 
-       case ICMP_UNREACH:
-         switch (icmp_code) {
-           case ICMP_FRAG_NEEDED:
-                 proto_tree_add_text(icmp_tree, tvb, 6, 2, "MTU of next hop: %u",
-                   tvb_get_ntohs(tvb, 6));
-                 break;
-           }
-         break;
+      case ICMP_UNREACH:
+        switch (icmp_code) {
+          case ICMP_FRAG_NEEDED:
+            proto_tree_add_item(icmp_tree, hf_icmp_mtu, tvb, 6, 2, FALSE);
+            break;
+       }
+        break;
 
       case ICMP_RTRADVERT:
         num_addrs = tvb_get_guint8(tvb, 4);
@@ -1646,8 +1478,7 @@ dissect_icmp(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
        break;
 
       case ICMP_REDIRECT:
-       proto_tree_add_text(icmp_tree, tvb, 4, 4, "Gateway address: %s",
-         ip_to_str(tvb_get_ptr(tvb, 4, 4)));
+        proto_tree_add_item(icmp_tree, hf_icmp_redir_gw, tvb, 4, 4, FALSE);
        break;
     }
 
@@ -1658,17 +1489,26 @@ dissect_icmp(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
       case ICMP_PARAMPROB:
       case ICMP_SOURCEQUENCH:
       case ICMP_REDIRECT:
+       /* Save the current value of the "we're inside an error packet"
+          flag, and set that flag; subdissectors may treat packets
+          that are the payload of error packets differently from
+          "real" packets. */
+       save_in_error_pkt = pinfo->in_error_pkt;
+       pinfo->in_error_pkt = TRUE;
+
        /* Decode the IP header and first 64 bits of data from the
-          original datagram.
+          original datagram. */
+       next_tvb = tvb_new_subset(tvb, 8, -1, -1);
+       call_dissector(ip_handle, next_tvb, pinfo, icmp_tree);
 
-          XXX - for now, just display it as data; not all dissection
-          routines can handle a short packet without exploding. */
-       dissect_data(tvb, 8, pinfo, icmp_tree);
+       /* Restore the "we're inside an error packet" flag. */
+       pinfo->in_error_pkt = save_in_error_pkt;
        break;
 
       case ICMP_ECHOREPLY:
       case ICMP_ECHO:
-       dissect_data(tvb, 8, pinfo, icmp_tree);
+       call_dissector(data_handle, tvb_new_subset(tvb, 8, -1, -1), pinfo,
+                      icmp_tree);
        break;
 
       case ICMP_RTRADVERT:
@@ -1678,10 +1518,15 @@ dissect_icmp(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
              "Router address: %s",
              ip_to_str(tvb_get_ptr(tvb, 8 + (i*8), 4)));
            proto_tree_add_text(icmp_tree, tvb, 12 + (i*8), 4,
-             "Preference level: %u", tvb_get_ntohl(tvb, 12 + (i*8)));
+             "Preference level: %d", tvb_get_ntohl(tvb, 12 + (i*8)));
+         }
+         if (icmp_code == 16) {
+               /* Mobile-Ip */
+               dissect_mip_extensions(tvb, 8 + i*8, icmp_tree);
          }
        } else
-         dissect_data(tvb, 8, pinfo, icmp_tree);
+         call_dissector(data_handle, tvb_new_subset(tvb, 8, -1, -1), pinfo,
+                        icmp_tree);
        break;
 
       case ICMP_TSTAMP:
@@ -1710,139 +1555,143 @@ proto_register_ip(void)
 
                { &hf_ip_version,
                { "Version",            "ip.version", FT_UINT8, BASE_DEC, NULL, 0x0,
-                       "" }},
+                       "", HFILL }},
 
                { &hf_ip_hdr_len,
                { "Header Length",      "ip.hdr_len", FT_UINT8, BASE_DEC, NULL, 0x0,
-                       "" }},
+                       "", HFILL }},
 
                { &hf_ip_dsfield,
                { "Differentiated Services field",      "ip.dsfield", FT_UINT8, BASE_DEC, NULL, 0x0,
-                       "" }},
+                       "", HFILL }},
 
                { &hf_ip_dsfield_dscp,
                { "Differentiated Services Codepoint",  "ip.dsfield.dscp", FT_UINT8, BASE_HEX,
                        VALS(dscp_vals), IPDSFIELD_DSCP_MASK,
-                       "" }},
+                       "", HFILL }},
 
                { &hf_ip_dsfield_ect,
                { "ECN-Capable Transport (ECT)",        "ip.dsfield.ect", FT_UINT8, BASE_DEC, NULL,
                        IPDSFIELD_ECT_MASK,
-                       "" }},
+                       "", HFILL }},
 
                { &hf_ip_dsfield_ce,
                { "ECN-CE",     "ip.dsfield.ce", FT_UINT8, BASE_DEC, NULL,
                        IPDSFIELD_CE_MASK,
-                       "" }},
+                       "", HFILL }},
 
                { &hf_ip_tos,
                { "Type of Service",    "ip.tos", FT_UINT8, BASE_DEC, NULL, 0x0,
-                       "" }},
+                       "", HFILL }},
 
                { &hf_ip_tos_precedence,
                { "Precedence",         "ip.tos.precedence", FT_UINT8, BASE_DEC, VALS(precedence_vals),
                        IPTOS_PREC_MASK,
-                       "" }},
+                       "", HFILL }},
 
                { &hf_ip_tos_delay,
                { "Delay",              "ip.tos.delay", FT_BOOLEAN, 8, TFS(&tos_set_low),
                        IPTOS_LOWDELAY,
-                       "" }},
+                       "", HFILL }},
 
                { &hf_ip_tos_throughput,
                { "Throughput",         "ip.tos.throughput", FT_BOOLEAN, 8, TFS(&tos_set_high),
                        IPTOS_THROUGHPUT,
-                       "" }},
+                       "", HFILL }},
 
                { &hf_ip_tos_reliability,
                { "Reliability",        "ip.tos.reliability", FT_BOOLEAN, 8, TFS(&tos_set_high),
                        IPTOS_RELIABILITY,
-                       "" }},
+                       "", HFILL }},
 
                { &hf_ip_tos_cost,
                { "Cost",               "ip.tos.cost", FT_BOOLEAN, 8, TFS(&tos_set_low),
                        IPTOS_LOWCOST,
-                       "" }},
+                       "", HFILL }},
 
                { &hf_ip_len,
                { "Total Length",       "ip.len", FT_UINT16, BASE_DEC, NULL, 0x0,
-                       "" }},
+                       "", HFILL }},
 
                { &hf_ip_id,
                { "Identification",     "ip.id", FT_UINT16, BASE_HEX, NULL, 0x0,
-                       "" }},
+                       "", HFILL }},
 
                { &hf_ip_dst,
                { "Destination",        "ip.dst", FT_IPv4, BASE_NONE, NULL, 0x0,
-                       "" }},
+                       "", HFILL }},
 
                { &hf_ip_src,
                { "Source",             "ip.src", FT_IPv4, BASE_NONE, NULL, 0x0,
-                       "" }},
+                       "", HFILL }},
 
                { &hf_ip_addr,
                { "Source or Destination Address", "ip.addr", FT_IPv4, BASE_NONE, NULL, 0x0,
-                       "" }},
+                       "", HFILL }},
 
                { &hf_ip_flags,
                { "Flags",              "ip.flags", FT_UINT8, BASE_HEX, NULL, 0x0,
-                       "" }},
+                       "", HFILL }},
 
                { &hf_ip_flags_df,
                { "Don't fragment",     "ip.flags.df", FT_BOOLEAN, 4, TFS(&flags_set_truth), IP_DF>>12,
-                       "" }},
+                       "", HFILL }},
 
                { &hf_ip_flags_mf,
                { "More fragments",     "ip.flags.mf", FT_BOOLEAN, 4, TFS(&flags_set_truth), IP_MF>>12,
-                       "" }},
+                       "", HFILL }},
 
                { &hf_ip_frag_offset,
                { "Fragment offset",    "ip.frag_offset", FT_UINT16, BASE_DEC, NULL, 0x0,
-                       "" }},
+                       "", HFILL }},
 
                { &hf_ip_ttl,
                { "Time to live",       "ip.ttl", FT_UINT8, BASE_DEC, NULL, 0x0,
-                       "" }},
+                       "", HFILL }},
 
                { &hf_ip_proto,
                { "Protocol",           "ip.proto", FT_UINT8, BASE_HEX, NULL, 0x0,
-                       "" }},
+                       "", HFILL }},
 
                { &hf_ip_checksum,
                { "Header checksum",    "ip.checksum", FT_UINT16, BASE_HEX, NULL, 0x0,
-                       "" }},
+                       "", HFILL }},
 
                { &hf_ip_checksum_bad,
                { "Bad Header checksum",        "ip.checksum_bad", FT_BOOLEAN, BASE_NONE, NULL, 0x0,
-                       "" }},
+                       "", HFILL }},
 
                { &hf_ip_fragment_overlap,
                { "Fragment overlap",   "ip.fragment.overlap", FT_BOOLEAN, BASE_NONE, NULL, 0x0,
-                       "Fragment overlaps with other fragments" }},
+                       "Fragment overlaps with other fragments", HFILL }},
 
                { &hf_ip_fragment_overlap_conflict,
                { "Conflicting data in fragment overlap",       "ip.fragment.overlap.conflict", FT_BOOLEAN, BASE_NONE, NULL, 0x0,
-                       "Overlapping fragments contained conflicting data" }},
+                       "Overlapping fragments contained conflicting data", HFILL }},
 
                { &hf_ip_fragment_multiple_tails,
                { "Multiple tail fragments found",      "ip.fragment.multipletails", FT_BOOLEAN, BASE_NONE, NULL, 0x0,
-                       "Several tails were found when defragmenting the packet" }},
+                       "Several tails were found when defragmenting the packet", HFILL }},
 
                { &hf_ip_fragment_too_long_fragment,
                { "Fragment too long",  "ip.fragment.toolongfragment", FT_BOOLEAN, BASE_NONE, NULL, 0x0,
-                       "Fragment contained data past end of packet" }},
+                       "Fragment contained data past end of packet", HFILL }},
 
                { &hf_ip_fragment_error,
-               { "Defragmentation error",      "ip.fragment.error", FT_STRING, BASE_DEC, NULL, 0x0,
-                       "Defragmentation error due to illegal fragments" }},
+               { "Defragmentation error", "ip.fragment.error", FT_FRAMENUM, BASE_NONE, NULL, 0x0,
+                       "Defragmentation error due to illegal fragments", HFILL }},
 
                { &hf_ip_fragment,
-               { "IP Fragment", "ip.fragment", FT_STRING, BASE_DEC, NULL, 0x0,
-                       "IP Fragment" }},
+               { "IP Fragment", "ip.fragment", FT_FRAMENUM, BASE_NONE, NULL, 0x0,
+                       "IP Fragment", HFILL }},
 
                { &hf_ip_fragments,
-               { "IP Fragments", "ip.fragments", FT_STRING, BASE_DEC, NULL, 0x0,
-                       "IP Fragments" }},
+               { "IP Fragments", "ip.fragments", FT_NONE, BASE_NONE, NULL, 0x0,
+                       "IP Fragments", HFILL }},
+
+               { &hf_ip_reassembled_in,
+               { "Reassembled IP in frame", "ip.reassembled_in", FT_FRAMENUM, BASE_NONE, NULL, 0x0,
+                       "This IP packet is reassembled in this frame", HFILL }}
        };
        static gint *ett[] = {
                &ett_ip,
@@ -1863,9 +1712,10 @@ proto_register_ip(void)
        proto_register_subtree_array(ett, array_length(ett));
 
        /* subdissector code */
-       ip_dissector_table = register_dissector_table("ip.proto");
+       ip_dissector_table = register_dissector_table("ip.proto",
+           "IP protocol", FT_UINT8, BASE_DEC);
 
-       /* Register a configuration option for decoding TOS as DSCP */
+       /* Register configuration options */
        ip_module = prefs_register_protocol(proto_ip, NULL);
        prefs_register_bool_preference(ip_module, "decode_tos_as_diffserv",
            "Decode IPv4 TOS field as DiffServ field",
@@ -1875,56 +1725,150 @@ proto_register_ip(void)
                "Reassemble fragmented IP datagrams",
                "Whether fragmented IP datagrams should be reassembled",
                &ip_defragment);
-       prefs_register_bool_preference(ip_module, "ip_summary_in_tree",
+       prefs_register_bool_preference(ip_module, "summary_in_tree",
            "Show IP summary in protocol tree",
            "Whether the IP summary line should be shown in the protocol tree",
            &ip_summary_in_tree);
 
        register_dissector("ip", dissect_ip, proto_ip);
        register_init_routine(ip_defragment_init);
+        ip_tap=register_tap("ip");
 }
 
 void
 proto_reg_handoff_ip(void)
 {
-       dissector_add("ethertype", ETHERTYPE_IP, dissect_ip, proto_ip);
-       dissector_add("ppp.protocol", PPP_IP, dissect_ip, proto_ip);
-       dissector_add("ppp.protocol", ETHERTYPE_IP, dissect_ip, proto_ip);
-       dissector_add("gre.proto", ETHERTYPE_IP, dissect_ip, proto_ip);
-       dissector_add("gre.proto", GRE_WCCP, dissect_ip, proto_ip);
-       dissector_add("llc.dsap", SAP_IP, dissect_ip, proto_ip);
-       dissector_add("ip.proto", IP_PROTO_IPIP, dissect_ip, proto_ip);
-       dissector_add("null.type", BSD_AF_INET, dissect_ip, proto_ip);
-       dissector_add("chdlctype", ETHERTYPE_IP, dissect_ip, proto_ip);
-       dissector_add("fr.ietf", NLPID_IP, dissect_ip, proto_ip);
+       dissector_handle_t ip_handle;
+
+        data_handle = find_dissector("data");
+        ip_handle = find_dissector("ip");
+       dissector_add("ethertype", ETHERTYPE_IP, ip_handle);
+       dissector_add("ppp.protocol", PPP_IP, ip_handle);
+       dissector_add("ppp.protocol", ETHERTYPE_IP, ip_handle);
+       dissector_add("gre.proto", ETHERTYPE_IP, ip_handle);
+       dissector_add("gre.proto", GRE_WCCP, ip_handle);
+       dissector_add("llc.dsap", SAP_IP, ip_handle);
+       dissector_add("ip.proto", IP_PROTO_IPIP, ip_handle);
+       dissector_add("null.type", BSD_AF_INET, ip_handle);
+       dissector_add("chdlctype", ETHERTYPE_IP, ip_handle);
+       dissector_add("fr.ietf", NLPID_IP, ip_handle);
+       dissector_add("x.25.spi", NLPID_IP, ip_handle);
+        dissector_add("arcnet.protocol_id", ARCNET_PROTO_IP_1051, ip_handle);
+        dissector_add("arcnet.protocol_id", ARCNET_PROTO_IP_1201, ip_handle);
 }
 
 void
 proto_register_icmp(void)
 {
   static hf_register_info hf[] = {
-    
+
     { &hf_icmp_type,
       { "Type",                "icmp.type",            FT_UINT8, BASE_DEC,     NULL, 0x0,
-       "" }},
+       "", HFILL }},
 
     { &hf_icmp_code,
       { "Code",                "icmp.code",            FT_UINT8, BASE_HEX,     NULL, 0x0,
-       "" }},    
+       "", HFILL }},
 
     { &hf_icmp_checksum,
       { "Checksum",    "icmp.checksum",        FT_UINT16, BASE_HEX,    NULL, 0x0,
-       "" }},
+       "", HFILL }},
 
     { &hf_icmp_checksum_bad,
       { "Bad Checksum",        "icmp.checksum_bad",    FT_BOOLEAN, BASE_NONE,  NULL, 0x0,
-       "" }},
+       "", HFILL }},
+
+    { &hf_icmp_ident,
+      {"Identifier", "icmp.ident",              FT_UINT16, BASE_HEX,    NULL, 0x0,
+       "", HFILL }},
+
+    { &hf_icmp_seq_num,
+      {"Sequence number", "icmp.seq",           FT_UINT16, BASE_HEX,    NULL, 0x0,
+       "", HFILL }},
+
+    { &hf_icmp_mtu,
+      {"MTU of next hop", "icmp.mtu",           FT_UINT16, BASE_DEC,    NULL, 0x0,
+       "", HFILL}},
+
+    { &hf_icmp_redir_gw,
+      {"Gateway address", "icmp.redir_gw",      FT_IPv4, BASE_NONE,     NULL, 0x0,
+       "", HFILL }},
+
+    { &hf_icmp_mip_type,
+      { "Extension Type", "icmp.mip.type",     FT_UINT8, BASE_DEC,
+       VALS(mip_extensions), 0x0,"", HFILL}},
+
+    { &hf_icmp_mip_length,
+      { "Length", "icmp.mip.length",           FT_UINT8, BASE_DEC, NULL, 0x0,
+       "", HFILL}},
+
+    { &hf_icmp_mip_prefix_length,
+      { "Prefix Length", "icmp.mip.prefixlength",  FT_UINT8, BASE_DEC, NULL, 0x0,
+       "", HFILL}},
+
+    { &hf_icmp_mip_seq,
+      { "Sequence Number", "icmp.mip.seq",     FT_UINT16, BASE_DEC, NULL, 0x0,
+       "", HFILL}},
+
+    { &hf_icmp_mip_life,
+      { "Registration Lifetime", "icmp.mip.life",  FT_UINT16, BASE_DEC, NULL, 0x0,
+       "", HFILL}},
+
+    { &hf_icmp_mip_flags,
+      { "Flags", "icmp.mip.flags",            FT_UINT8, BASE_HEX, NULL, 0x0,
+       "", HFILL}},
+
+    { &hf_icmp_mip_r,
+      { "Registration Required", "icmp.mip.r", FT_BOOLEAN, 8, NULL, 128,
+       "Registration with this FA is required", HFILL }},
+
+    { &hf_icmp_mip_b,
+      { "Busy", "icmp.mip.b", FT_BOOLEAN, 8, NULL, 64,
+       "This FA will not accept requests at this time", HFILL }},
+
+    { &hf_icmp_mip_h,
+      { "Home Agent", "icmp.mip.h", FT_BOOLEAN, 8, NULL, 32,
+       "Home Agent Services Offered", HFILL }},
+
+    { &hf_icmp_mip_f,
+      { "Foreign Agent", "icmp.mip.f", FT_BOOLEAN, 8, NULL, 16,
+       "Foreign Agent Services Offered", HFILL }},
+
+    { &hf_icmp_mip_m,
+      { "Minimal Encapsulation", "icmp.mip.m", FT_BOOLEAN, 8, NULL, 8,
+       "Minimal encapsulation tunneled datagram support", HFILL }},
+
+    { &hf_icmp_mip_g,
+      { "GRE", "icmp.mip.g", FT_BOOLEAN, 8, NULL, 4,
+       "GRE encapsulated tunneled datagram support", HFILL }},
+
+    { &hf_icmp_mip_v,
+      { "VJ Comp", "icmp.mip.v", FT_BOOLEAN, 8, NULL, 2,
+       "Van Jacobson Header Compression Support", HFILL }},
+
+    { &hf_icmp_mip_res,
+      { "Reserved", "icmp.mip.res", FT_BOOLEAN, 8, NULL, 1,
+       "Reserved", HFILL }},
+
+    { &hf_icmp_mip_reserved,
+      { "Reserved", "icmp.mip.reserved",     FT_UINT8, BASE_HEX, NULL, 0x0,
+       "", HFILL}},
+
+    { &hf_icmp_mip_coa,
+      { "Care-Of-Address", "icmp.mip.coa",    FT_IPv4, BASE_NONE, NULL, 0x0,
+       "", HFILL}},
+
+    { &hf_icmp_mip_challenge,
+      { "Challenge", "icmp.mip.challenge",    FT_BYTES, BASE_NONE, NULL, 0x0,
+       "", HFILL}},
   };
   static gint *ett[] = {
     &ett_icmp,
+       &ett_icmp_mip,
+       &ett_icmp_mip_flags
   };
-  
-  proto_icmp = proto_register_protocol("Internet Control Message Protocol", 
+
+  proto_icmp = proto_register_protocol("Internet Control Message Protocol",
                                       "ICMP", "icmp");
   proto_register_field_array(proto_icmp, hf, array_length(hf));
   proto_register_subtree_array(ett, array_length(ett));
@@ -1933,5 +1877,13 @@ proto_register_icmp(void)
 void
 proto_reg_handoff_icmp(void)
 {
-  dissector_add("ip.proto", IP_PROTO_ICMP, dissect_icmp, proto_icmp);
+  dissector_handle_t icmp_handle;
+
+  /*
+   * Get handle for the IP dissector.
+   */
+  ip_handle = find_dissector("ip");
+
+  icmp_handle = create_dissector_handle(dissect_icmp, proto_icmp);
+  dissector_add("ip.proto", IP_PROTO_ICMP, icmp_handle);
 }