"hex_str_to_bytes()" modifies the GByteArray supplied to it, so don't
[obnox/wireshark/wip.git] / packet-ascend.c
index 72acab9fcc1706ee466390bbba75bf27430f8b03..56d4412512c60969741fd69c082ae87ff7d46fa1 100644 (file)
@@ -1,21 +1,21 @@
 /* packet-ascend.c
  * Routines for decoding Lucent/Ascend packet traces
  *
- * $Id: packet-ascend.c,v 1.19 2000/11/19 02:00:02 guy Exp $
+ * $Id: packet-ascend.c,v 1.32 2002/08/28 21:00:07 jmayer Exp $
  *
  * Ethereal - Network traffic analyzer
- * By Gerald Combs <gerald@zing.org>
+ * By Gerald Combs <gerald@ethereal.com>
  *
  * This program is free software; you can redistribute it and/or
  * modify it under the terms of the GNU General Public License
  * as published by the Free Software Foundation; either version 2
  * of the License, or (at your option) any later version.
- * 
+ *
  * This program is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
- * 
+ *
  * You should have received a copy of the GNU General Public License
  * along with this program; if not, write to the Free Software
  * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
 # include "config.h"
 #endif
 
-#ifdef HAVE_SYS_TYPES_H
-# include <sys/types.h>
-#endif
-
 #include <glib.h>
 #include <string.h>
-#include "packet.h"
-#include "packet-ascend.h"
+#include <epan/packet.h>
 
 static int proto_ascend  = -1;
 static int hf_link_type  = -1;
@@ -51,29 +46,37 @@ static const value_string encaps_vals[] = {
   {0,                NULL          } };
 
 static dissector_handle_t eth_handle;
-static dissector_handle_t ppp_handle;
+static dissector_handle_t ppp_hdlc_handle;
 
-void
+static void
 dissect_ascend(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
 {
   proto_tree                   *fh_tree;
   proto_item                   *ti;
   union wtap_pseudo_header     *pseudo_header = pinfo->pseudo_header;
 
-  CHECK_DISPLAY_AS_DATA(proto_ascend, tvb, pinfo, tree);
-
-  pinfo->current_proto = "Lucent/Ascend";
-
   /* load the top pane info. This should be overwritten by
      the next protocol in the stack */
-  if(check_col(pinfo->fd, COL_RES_DL_SRC))
-    col_add_str(pinfo->fd, COL_RES_DL_SRC, "N/A" );
-  if(check_col(pinfo->fd, COL_RES_DL_DST))
-    col_add_str(pinfo->fd, COL_RES_DL_DST, "N/A" );
-  if(check_col(pinfo->fd, COL_PROTOCOL))
-    col_add_str(pinfo->fd, COL_PROTOCOL, "N/A" );
-  if(check_col(pinfo->fd, COL_INFO))
-    col_add_str(pinfo->fd, COL_INFO, "Lucent/Ascend packet trace" );
+  if(check_col(pinfo->cinfo, COL_RES_DL_SRC))
+    col_set_str(pinfo->cinfo, COL_RES_DL_SRC, "N/A" );
+  if(check_col(pinfo->cinfo, COL_RES_DL_DST))
+    col_set_str(pinfo->cinfo, COL_RES_DL_DST, "N/A" );
+  if(check_col(pinfo->cinfo, COL_PROTOCOL))
+    col_set_str(pinfo->cinfo, COL_PROTOCOL, "N/A" );
+  if(check_col(pinfo->cinfo, COL_INFO))
+    col_set_str(pinfo->cinfo, COL_INFO, "Lucent/Ascend packet trace" );
+
+  /* If this is a transmitted or received PPP frame, set the PPP direction. */
+  switch (pseudo_header->ascend.type) {
+
+  case ASCEND_PFX_WDS_X:
+    pinfo->p2p_dir = P2P_DIR_SENT;
+    break;
+
+  case ASCEND_PFX_WDS_R:
+    pinfo->p2p_dir = P2P_DIR_RECV;
+    break;
+  }
 
   /* populate a tree in the second pane with the status of the link
      layer (ie none) */
@@ -81,16 +84,16 @@ dissect_ascend(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
     ti = proto_tree_add_protocol_format(tree, proto_ascend, tvb, 0, 0,
                                        "Lucent/Ascend packet trace");
     fh_tree = proto_item_add_subtree(ti, ett_raw);
-    proto_tree_add_uint(fh_tree, hf_link_type, tvb, 0, 0, 
+    proto_tree_add_uint(fh_tree, hf_link_type, tvb, 0, 0,
                        pseudo_header->ascend.type);
     if (pseudo_header->ascend.type == ASCEND_PFX_WDD) {
-      proto_tree_add_string(fh_tree, hf_called_number, tvb, 0, 0, 
+      proto_tree_add_string(fh_tree, hf_called_number, tvb, 0, 0,
                          pseudo_header->ascend.call_num);
       proto_tree_add_uint(fh_tree, hf_chunk, tvb, 0, 0,
                          pseudo_header->ascend.chunk);
       proto_tree_add_uint_hidden(fh_tree, hf_session_id, tvb, 0, 0, 0);
     } else {  /* It's wandsession data */
-      proto_tree_add_string(fh_tree, hf_user_name, tvb, 0, 0, 
+      proto_tree_add_string(fh_tree, hf_user_name, tvb, 0, 0,
                          pseudo_header->ascend.user);
       proto_tree_add_uint(fh_tree, hf_session_id, tvb, 0, 0,
                          pseudo_header->ascend.sess);
@@ -102,7 +105,7 @@ dissect_ascend(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
   switch (pseudo_header->ascend.type) {
     case ASCEND_PFX_WDS_X:
     case ASCEND_PFX_WDS_R:
-      call_dissector(ppp_handle, tvb, pinfo, tree);
+      call_dissector(ppp_hdlc_handle, tvb, pinfo, tree);
       break;
     case ASCEND_PFX_WDD:
       call_dissector(eth_handle, tvb, pinfo, tree);
@@ -118,33 +121,34 @@ proto_register_ascend(void)
   static hf_register_info hf[] = {
     { &hf_link_type,
     { "Link type",     "ascend.type",  FT_UINT32, BASE_DEC,    VALS(encaps_vals),      0x0,
-      "" }},
+      "", HFILL }},
 
     { &hf_session_id,
     { "Session ID",    "ascend.sess",  FT_UINT32, BASE_DEC,    NULL, 0x0,
-      "" }},
+      "", HFILL }},
 
     { &hf_called_number,
     { "Called number", "ascend.number", FT_STRING, BASE_NONE,  NULL, 0x0,
-      "" }},
+      "", HFILL }},
 
     { &hf_chunk,
     { "WDD Chunk",     "ascend.chunk", FT_UINT32, BASE_HEX,    NULL, 0x0,
-      "" }},
+      "", HFILL }},
 
     { &hf_task,
     { "Task",          "ascend.task",  FT_UINT32, BASE_HEX,    NULL, 0x0,
-      "" }},
+      "", HFILL }},
 
     { &hf_user_name,
     { "User name",             "ascend.user",  FT_STRING, BASE_NONE,   NULL, 0x0,
-      "" }},
+      "", HFILL }},
   };
   static gint *ett[] = {
     &ett_raw,
   };
 
-  proto_ascend = proto_register_protocol("Lucent/Ascend debug output", "ascend");
+  proto_ascend = proto_register_protocol("Lucent/Ascend debug output",
+                                        "Lucent/Ascend", "ascend");
   proto_register_field_array(proto_ascend, hf, array_length(hf));
   proto_register_subtree_array(ett, array_length(ett));
 }
@@ -152,9 +156,14 @@ proto_register_ascend(void)
 void
 proto_reg_handoff_ascend(void)
 {
+  dissector_handle_t ascend_handle;
+
   /*
-   * Get handles for the Ethernet and PPP dissectors.
+   * Get handles for the Ethernet and PPP-in-HDLC-like-framing dissectors.
    */
   eth_handle = find_dissector("eth");
-  ppp_handle = find_dissector("ppp");
+  ppp_hdlc_handle = find_dissector("ppp_hdlc");
+
+  ascend_handle = create_dissector_handle(dissect_ascend, proto_ascend);
+  dissector_add("wtap_encap", WTAP_ENCAP_ASCEND, ascend_handle);
 }