Fix Coverity 1137, 1138, 1139: UNUSED_VALUE

[obnox/wireshark/wip.git] / make-version.pl

diff --git a/make-version.pl b/make-version.pl
index 827115e4b7dced16e0fd9b5575b101babba07175..f59ba21495118e5431ff3e6865108884e5c6a8f2 100755 (executable)
--- a/make-version.pl
+++ b/make-version.pl
@@ -81,6 +81,7 @@ my %version_pref = (
        );
 my $srcdir = ".";
 
+$ENV{LANG} = "C";  # Ensure we run with correct locale
 
 # Run "svn info".  Parse out the most recent modification time and the
 # revision number.
@@ -253,11 +254,12 @@ sub print_svn_version
                        $revision . "\"\n" .
                        "#define SVNPATH \"" . $repo_path . "\"\n";
        } else {
-               $svn_version = "/* #define SVNVERSION \"\" */\n" .
-                       "/* #define SVNPATH \"\" */\n";
+               $svn_version = "#define SVNVERSION \"SVN Rev Unknown\"\n" .
+                       "#define SVNPATH \"unknown\"\n";
        }
        if (open(OLDVER, "<$version_file")) {
-               if (<OLDVER> eq $svn_version) {
+               my $old_svn_version = <OLDVER> . <OLDVER>;
+               if ($old_svn_version eq $svn_version) {
                        $needs_update = 0;
                }
                close OLDVER;