Update based upon latest names "packet-type-codes" list from the IANA:
[obnox/wireshark/wip.git] / gtk / service_response_time_table.c
index 5d0f0cc716d389466ebf276d8f46a77c52b26a02..31c94d83f2abcd4acdda87b1a2fc44546900d8cd 100644 (file)
@@ -8,17 +8,17 @@
  * Wireshark - Network traffic analyzer
  * By Gerald Combs <gerald@wireshark.org>
  * Copyright 1998 Gerald Combs
- * 
+ *
  * This program is free software; you can redistribute it and/or
  * modify it under the terms of the GNU General Public License
  * as published by the Free Software Foundation; either version 2
  * of the License, or (at your option) any later version.
- * 
+ *
  * This program is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
- * 
+ *
  * You should have received a copy of the GNU General Public License
  * along with this program; if not, write to the Free Software
  * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
 #endif
 
 #include <gtk/gtk.h>
+#include <stdio.h>
 
 #include "epan/packet_info.h"
 
 #include "../simple_dialog.h"
-#include "../globals.h"
 
 #include "gtk/service_response_time_table.h"
 #include "gtk/filter_utils.h"
 #include "gtk/gui_utils.h"
+#include "gtk/utf8_entities.h"
+
+#define NANOSECS_PER_SEC 1000000000
 
 enum
 {
-   INDEX_COLUMN,
-   PROCEDURE_COLUMN,
-   CALLS_COLUMN,
-   MIN_SRT_COLUMN,
-   MAX_SRT_COLUMN,
-   AVG_SRT_COLUMN,
-   N_COLUMNS
+       INDEX_COLUMN,
+       PROCEDURE_COLUMN,
+       CALLS_COLUMN,
+       MIN_SRT_COLUMN,
+       MAX_SRT_COLUMN,
+       AVG_SRT_COLUMN,
+       N_COLUMNS
 };
 
 
@@ -83,92 +86,311 @@ srt_select_filter_cb(GtkWidget *widget _U_, gpointer callback_data, guint callba
        g_free(str);
 }
 
-static gint
+static gboolean
 srt_show_popup_menu_cb(void *widg _U_, GdkEvent *event, srt_stat_table *rst)
 {
        GdkEventButton *bevent = (GdkEventButton *)event;
 
        if(event->type==GDK_BUTTON_PRESS && bevent->button==3){
-               gtk_menu_popup(GTK_MENU(rst->menu), NULL, NULL, NULL, NULL, 
+               gtk_menu_popup(GTK_MENU(rst->menu), NULL, NULL, NULL, NULL,
                        bevent->button, bevent->time);
        }
 
        return FALSE;
 }
 
-static GtkItemFactoryEntry srt_list_menu_items[] =
-{
-       /* Match */
-       {"/Apply as Filter", NULL, NULL, 0, "<Branch>", NULL,},
-       {"/Apply as Filter/Selected", NULL,
-               GTK_MENU_FUNC(srt_select_filter_cb), CALLBACK_MATCH(ACTYPE_SELECTED, 0), NULL, NULL,},
-       {"/Apply as Filter/... not Selected", NULL,
-               GTK_MENU_FUNC(srt_select_filter_cb), CALLBACK_MATCH(ACTYPE_NOT_SELECTED, 0), NULL, NULL,},
-       {"/Apply as Filter/.. and Selected", NULL,
-               GTK_MENU_FUNC(srt_select_filter_cb), CALLBACK_MATCH(ACTYPE_AND_SELECTED, 0), NULL, NULL,},
-       {"/Apply as Filter/... or Selected", NULL,
-               GTK_MENU_FUNC(srt_select_filter_cb), CALLBACK_MATCH(ACTYPE_OR_SELECTED, 0), NULL, NULL,},
-       {"/Apply as Filter/... and not Selected", NULL,
-               GTK_MENU_FUNC(srt_select_filter_cb), CALLBACK_MATCH(ACTYPE_AND_NOT_SELECTED, 0), NULL, NULL,},
-       {"/Apply as Filter/... or not Selected", NULL,
-               GTK_MENU_FUNC(srt_select_filter_cb), CALLBACK_MATCH(ACTYPE_OR_NOT_SELECTED, 0), NULL, NULL,},
-
-       /* Prepare */
-       {"/Prepare a Filter", NULL, NULL, 0, "<Branch>", NULL,},
-       {"/Prepare a Filter/Selected", NULL,
-               GTK_MENU_FUNC(srt_select_filter_cb), CALLBACK_PREPARE(ACTYPE_SELECTED, 0), NULL, NULL,},
-       {"/Prepare a Filter/Not Selected", NULL,
-               GTK_MENU_FUNC(srt_select_filter_cb), CALLBACK_PREPARE(ACTYPE_NOT_SELECTED, 0), NULL, NULL,},
-       {"/Prepare a Filter/... and Selected", NULL,
-               GTK_MENU_FUNC(srt_select_filter_cb), CALLBACK_PREPARE(ACTYPE_AND_SELECTED, 0), NULL, NULL,},
-       {"/Prepare a Filter/... or Selected", NULL,
-               GTK_MENU_FUNC(srt_select_filter_cb), CALLBACK_PREPARE(ACTYPE_OR_SELECTED, 0), NULL, NULL,},
-       {"/Prepare a Filter/... and not Selected", NULL,
-               GTK_MENU_FUNC(srt_select_filter_cb), CALLBACK_PREPARE(ACTYPE_AND_NOT_SELECTED, 0), NULL, NULL,},
-       {"/Prepare a Filter/... or not Selected", NULL,
-               GTK_MENU_FUNC(srt_select_filter_cb), CALLBACK_PREPARE(ACTYPE_OR_NOT_SELECTED, 0), NULL, NULL,},
-
-       /* Find Frame */
-       {"/Find Frame", NULL, NULL, 0, "<Branch>", NULL,},
-       {"/Find Frame/Find Frame", NULL, NULL, 0, "<Branch>", NULL,},
-       {"/Find Frame/Find Frame/Selected", NULL,
-               GTK_MENU_FUNC(srt_select_filter_cb), CALLBACK_FIND_FRAME(ACTYPE_SELECTED, 0), NULL, NULL,},
-       {"/Find Frame/Find Frame/Not Selected", NULL,
-               GTK_MENU_FUNC(srt_select_filter_cb), CALLBACK_FIND_FRAME(ACTYPE_NOT_SELECTED, 0), NULL, NULL,},
-       /* Find Next */
-       {"/Find Frame/Find Next", NULL, NULL, 0, "<Branch>", NULL,},
-       {"/Find Frame/Find Next/Selected", NULL,
-               GTK_MENU_FUNC(srt_select_filter_cb), CALLBACK_FIND_NEXT(ACTYPE_SELECTED, 0), NULL, NULL,},
-       {"/Find Frame/Find Next/Not Selected", NULL,
-               GTK_MENU_FUNC(srt_select_filter_cb), CALLBACK_FIND_NEXT(ACTYPE_NOT_SELECTED, 0), NULL, NULL,},
-
-       /* Find Previous */
-       {"/Find Frame/Find Previous", NULL, NULL, 0, "<Branch>", NULL,},
-       {"/Find Frame/Find Previous/Selected", NULL,
-               GTK_MENU_FUNC(srt_select_filter_cb), CALLBACK_FIND_PREVIOUS(ACTYPE_SELECTED, 0), NULL, NULL,},
-       {"/Find Frame/Find Previous/Not Selected", NULL,
-               GTK_MENU_FUNC(srt_select_filter_cb), CALLBACK_FIND_PREVIOUS(ACTYPE_NOT_SELECTED, 0), NULL, NULL,},
-
-       /* Colorize Procedure */
-       {"/Colorize Procedure", NULL, NULL, 0, "<Branch>", NULL,},
-       {"/Colorize Procedure/Selected", NULL,
-               GTK_MENU_FUNC(srt_select_filter_cb), CALLBACK_COLORIZE(ACTYPE_SELECTED, 0), NULL, NULL,},
-       {"/Colorize Procedure/Not Selected", NULL,
-               GTK_MENU_FUNC(srt_select_filter_cb), CALLBACK_COLORIZE(ACTYPE_NOT_SELECTED, 0), NULL, NULL,}
 
+/* Action callbacks */
+static void
+apply_as_selected_cb(GtkWidget *widget, gpointer user_data)
+{
+       srt_select_filter_cb( widget , user_data, CALLBACK_MATCH(ACTYPE_SELECTED, 0));
+}
+static void
+apply_as_not_selected_cb(GtkWidget *widget, gpointer user_data)
+{
+       srt_select_filter_cb( widget , user_data, CALLBACK_MATCH(ACTYPE_NOT_SELECTED, 0));
+}
+static void
+apply_as_and_selected_cb(GtkWidget *widget, gpointer user_data)
+{
+       srt_select_filter_cb( widget , user_data, CALLBACK_MATCH(ACTYPE_AND_SELECTED, 0));
+}
+static void
+apply_as_or_selected_cb(GtkWidget *widget, gpointer user_data)
+{
+       srt_select_filter_cb( widget , user_data, CALLBACK_MATCH(ACTYPE_OR_SELECTED, 0));
+}
+static void
+apply_as_and_not_selected_cb(GtkWidget *widget, gpointer user_data)
+{
+       srt_select_filter_cb( widget , user_data, CALLBACK_MATCH(ACTYPE_AND_NOT_SELECTED, 0));
+}
+static void
+apply_as_or_not_selected_cb(GtkWidget *widget, gpointer user_data)
+{
+       srt_select_filter_cb( widget , user_data, CALLBACK_MATCH(ACTYPE_OR_NOT_SELECTED, 0));
+}
+
+static void
+prep_as_selected_cb(GtkWidget *widget, gpointer user_data)
+{
+       srt_select_filter_cb( widget , user_data, CALLBACK_PREPARE(ACTYPE_SELECTED, 0));
+}
+static void
+prep_as_not_selected_cb(GtkWidget *widget, gpointer user_data)
+{
+       srt_select_filter_cb( widget , user_data, CALLBACK_PREPARE(ACTYPE_NOT_SELECTED, 0));
+}
+static void
+prep_as_and_selected_cb(GtkWidget *widget, gpointer user_data)
+{
+       srt_select_filter_cb( widget , user_data, CALLBACK_PREPARE(ACTYPE_AND_SELECTED, 0));
+}
+static void
+prep_as_or_selected_cb(GtkWidget *widget, gpointer user_data)
+{
+       srt_select_filter_cb( widget , user_data, CALLBACK_PREPARE(ACTYPE_OR_SELECTED, 0));
+}
+static void
+prep_as_and_not_selected_cb(GtkWidget *widget, gpointer user_data)
+{
+       srt_select_filter_cb( widget , user_data, CALLBACK_PREPARE(ACTYPE_AND_NOT_SELECTED, 0));
+}
+static void
+prep_as_or_not_selected_cb(GtkWidget *widget, gpointer user_data)
+{
+       srt_select_filter_cb( widget , user_data, CALLBACK_PREPARE(ACTYPE_OR_NOT_SELECTED, 0));
+}
+
+static void
+find_selected_cb(GtkWidget *widget, gpointer user_data)
+{
+       srt_select_filter_cb( widget , user_data, CALLBACK_FIND_FRAME(ACTYPE_SELECTED, 0));
+}
+static void
+find_not_selected_cb(GtkWidget *widget, gpointer user_data)
+{
+       srt_select_filter_cb( widget , user_data, CALLBACK_FIND_FRAME(ACTYPE_NOT_SELECTED, 0));
+}
+static void
+find_prev_selected_cb(GtkWidget *widget, gpointer user_data)
+{
+       srt_select_filter_cb( widget , user_data, CALLBACK_FIND_PREVIOUS(ACTYPE_SELECTED, 0));
+}
+static void
+find_prev_not_selected_cb(GtkWidget *widget, gpointer user_data)
+{
+       srt_select_filter_cb( widget , user_data, CALLBACK_FIND_PREVIOUS(ACTYPE_NOT_SELECTED, 0));
+}
+static void
+find_next_selected_cb(GtkWidget *widget, gpointer user_data)
+{
+       srt_select_filter_cb( widget , user_data, CALLBACK_FIND_NEXT(ACTYPE_SELECTED, 0));
+}
+static void
+find_next_not_selected_cb(GtkWidget *widget, gpointer user_data)
+{
+       srt_select_filter_cb( widget , user_data, CALLBACK_FIND_NEXT(ACTYPE_NOT_SELECTED, 0));
+}
+static void
+color_selected_cb(GtkWidget *widget, gpointer user_data)
+{
+       srt_select_filter_cb( widget , user_data, CALLBACK_COLORIZE(ACTYPE_SELECTED, 0));
+}
+static void
+color_not_selected_cb(GtkWidget *widget, gpointer user_data)
+{
+       srt_select_filter_cb( widget , user_data, CALLBACK_COLORIZE(ACTYPE_SELECTED, 0));
+}
+
+static const char *ui_desc_service_resp_t_filter_popup =
+"<ui>\n"
+"  <popup name='ServiceRespTFilterPopup'>\n"
+"    <menu action='/Apply as Filter'>\n"
+"      <menuitem action='/Apply as Filter/Selected'/>\n"
+"      <menuitem action='/Apply as Filter/" UTF8_HORIZONTAL_ELLIPSIS " not Selected'/>\n"
+"      <menuitem action='/Apply as Filter/" UTF8_HORIZONTAL_ELLIPSIS " and Selected'/>\n"
+"      <menuitem action='/Apply as Filter/" UTF8_HORIZONTAL_ELLIPSIS " or Selected'/>\n"
+"      <menuitem action='/Apply as Filter/" UTF8_HORIZONTAL_ELLIPSIS " and not Selected'/>\n"
+"      <menuitem action='/Apply as Filter/" UTF8_HORIZONTAL_ELLIPSIS " or not Selected'/>\n"
+"    </menu>\n"
+"    <menu action='/Prepare a Filter'>\n"
+"      <menuitem action='/Prepare a Filter/Selected'/>\n"
+"      <menuitem action='/Prepare a Filter/" UTF8_HORIZONTAL_ELLIPSIS " not Selected'/>\n"
+"      <menuitem action='/Prepare a Filter/" UTF8_HORIZONTAL_ELLIPSIS " and Selected'/>\n"
+"      <menuitem action='/Prepare a Filter/" UTF8_HORIZONTAL_ELLIPSIS " or Selected'/>\n"
+"      <menuitem action='/Prepare a Filter/" UTF8_HORIZONTAL_ELLIPSIS " and not Selected'/>\n"
+"      <menuitem action='/Prepare a Filter/" UTF8_HORIZONTAL_ELLIPSIS " or not Selected'/>\n"
+"    </menu>\n"
+"    <menu action='/Find Frame'>\n"
+"      <menu action='/Find Frame/Find Frame'>\n"
+"        <menuitem action='/Find Frame/Selected'/>\n"
+"        <menuitem action='/Find Frame/Not Selected'/>\n"
+"      </menu>\n"
+"      <menu action='/Find Frame/Find Next'>\n"
+"        <menuitem action='/Find Next/Selected'/>\n"
+"        <menuitem action='/Find Next/Not Selected'/>\n"
+"      </menu>\n"
+"      <menu action='/Find Frame/Find Previous'>\n"
+"        <menuitem action='/Find Previous/Selected'/>\n"
+"        <menuitem action='/Find Previous/Not Selected'/>\n"
+"      </menu>\n"
+"    </menu>\n"
+"    <menu action='/Colorize Procedure'>\n"
+"     <menuitem action='/Colorize Procedure/Selected'/>\n"
+"     <menuitem action='/Colorize Procedure/Not Selected'/>\n"
+"    </menu>\n"
+"  </popup>\n"
+"</ui>\n";
+
+/*
+ * GtkActionEntry
+ * typedef struct {
+ *   const gchar     *name;
+ *   const gchar     *stock_id;
+ *   const gchar     *label;
+ *   const gchar     *accelerator;
+ *   const gchar     *tooltip;
+ *   GCallback  callback;
+ * } GtkActionEntry;
+ * const gchar *name;                  The name of the action.
+ * const gchar *stock_id;              The stock id for the action, or the name of an icon from the icon theme.
+ * const gchar *label;                 The label for the action. This field should typically be marked for translation,
+ *                                                             see gtk_action_group_set_translation_domain().
+ *                                                             If label is NULL, the label of the stock item with id stock_id is used.
+ * const gchar *accelerator;   The accelerator for the action, in the format understood by gtk_accelerator_parse().
+ * const gchar *tooltip;               The tooltip for the action. This field should typically be marked for translation,
+ *                              see gtk_action_group_set_translation_domain().
+ * GCallback callback;                 The function to call when the action is activated.
+ *
+ */
+static const GtkActionEntry service_resp_t__popup_entries[] = {
+  { "/Apply as Filter",                                                        NULL, "Apply as Filter",                NULL, NULL,                                             NULL },
+  { "/Prepare a Filter",                                               NULL, "Prepare a Filter",               NULL, NULL,                                             NULL },
+  { "/Find Frame",                                                             NULL, "Find Frame",                             NULL, NULL,                                             NULL },
+  { "/Find Frame/Find Frame",                                  NULL, "Find Frame",                             NULL, NULL,                                             NULL },
+  { "/Find Frame/Find Next",                                   NULL, "Find Next" ,                             NULL, NULL,                                             NULL },
+  { "/Find Frame/Find Previous",                               NULL, "Find Previous",                  NULL, NULL,                                             NULL },
+  { "/Colorize Procedure",                                             NULL, "Colorize Procedure",             NULL, NULL,                                             NULL },
+  { "/Apply as Filter/Selected",                               NULL, "Selected",                               NULL, "Selected",                               G_CALLBACK(apply_as_selected_cb) },
+  { "/Apply as Filter/" UTF8_HORIZONTAL_ELLIPSIS " not Selected",              NULL, UTF8_HORIZONTAL_ELLIPSIS " not Selected",         NULL, UTF8_HORIZONTAL_ELLIPSIS " not Selected",         G_CALLBACK(apply_as_not_selected_cb) },
+  { "/Apply as Filter/" UTF8_HORIZONTAL_ELLIPSIS " and Selected",              NULL, UTF8_HORIZONTAL_ELLIPSIS " and Selected",         NULL, UTF8_HORIZONTAL_ELLIPSIS " and Selected",         G_CALLBACK(apply_as_and_selected_cb) },
+  { "/Apply as Filter/" UTF8_HORIZONTAL_ELLIPSIS " or Selected",                       NULL, UTF8_HORIZONTAL_ELLIPSIS " or Selected",          NULL, UTF8_HORIZONTAL_ELLIPSIS " or Selected",          G_CALLBACK(apply_as_or_selected_cb) },
+  { "/Apply as Filter/" UTF8_HORIZONTAL_ELLIPSIS " and not Selected",  NULL, UTF8_HORIZONTAL_ELLIPSIS " and not Selected",     NULL, UTF8_HORIZONTAL_ELLIPSIS " and not Selected",     G_CALLBACK(apply_as_and_not_selected_cb) },
+  { "/Apply as Filter/" UTF8_HORIZONTAL_ELLIPSIS " or not Selected",           NULL, UTF8_HORIZONTAL_ELLIPSIS " or not Selected",      NULL, UTF8_HORIZONTAL_ELLIPSIS " or not Selected",      G_CALLBACK(apply_as_or_not_selected_cb) },
+  { "/Prepare a Filter/Selected",                              NULL, "Selected",                               NULL, "selcted",                                G_CALLBACK(prep_as_selected_cb) },
+  { "/Prepare a Filter/" UTF8_HORIZONTAL_ELLIPSIS " not Selected",             NULL, UTF8_HORIZONTAL_ELLIPSIS " not Selected",         NULL, UTF8_HORIZONTAL_ELLIPSIS " not Selected",         G_CALLBACK(prep_as_not_selected_cb) },
+  { "/Prepare a Filter/" UTF8_HORIZONTAL_ELLIPSIS " and Selected",             NULL, UTF8_HORIZONTAL_ELLIPSIS " and Selected",         NULL, UTF8_HORIZONTAL_ELLIPSIS " and Selected",         G_CALLBACK(prep_as_and_selected_cb) },
+  { "/Prepare a Filter/" UTF8_HORIZONTAL_ELLIPSIS " or Selected",              NULL, UTF8_HORIZONTAL_ELLIPSIS " or Selected",          NULL, UTF8_HORIZONTAL_ELLIPSIS " or Selected",          G_CALLBACK(prep_as_or_selected_cb) },
+  { "/Prepare a Filter/" UTF8_HORIZONTAL_ELLIPSIS " and not Selected", NULL, UTF8_HORIZONTAL_ELLIPSIS " and not Selected",     NULL, UTF8_HORIZONTAL_ELLIPSIS " and not Selected",     G_CALLBACK(prep_as_and_not_selected_cb) },
+  { "/Prepare a Filter/" UTF8_HORIZONTAL_ELLIPSIS " or not Selected",  NULL, UTF8_HORIZONTAL_ELLIPSIS " or not Selected",      NULL, UTF8_HORIZONTAL_ELLIPSIS " or not Selected",      G_CALLBACK(prep_as_or_not_selected_cb) },
+  { "/Find Frame/Selected",                                            NULL, "Selected",                               NULL, "Selected",                               G_CALLBACK(find_selected_cb) },
+  { "/Find Frame/Not Selected",                                        NULL, "Not Selected",                   NULL, "Not Selected",                   G_CALLBACK(find_not_selected_cb) },
+  { "/Find Previous/Selected",                                 NULL, "Selected",                               NULL, "Selected",                               G_CALLBACK(find_prev_selected_cb) },
+  { "/Find Previous/Not Selected",                             NULL, "Not Selected",                   NULL, "Not Selected",                   G_CALLBACK(find_prev_not_selected_cb) },
+  { "/Find Next/Selected",                                             NULL, "Selected",                               NULL, "Selected",                               G_CALLBACK(find_next_selected_cb) },
+  { "/Find Next/Not Selected",                                 NULL, "Not Selected",                   NULL, "Not Selected",                   G_CALLBACK(find_next_not_selected_cb) },
+  { "/Colorize Procedure/Selected",                            NULL, "Selected",                               NULL, "Selected",                               G_CALLBACK(color_selected_cb) },
+  { "/Colorize Procedure/Not Selected",                        NULL, "Not Selected",                   NULL, "Not Selected",                   G_CALLBACK(color_not_selected_cb) },
 };
 
 static void
 srt_create_popup_menu(srt_stat_table *rst)
 {
-       GtkItemFactory *item_factory;
+       GtkUIManager *ui_manager;
+       GtkActionGroup *action_group;
+       GError *error = NULL;
+
+       action_group = gtk_action_group_new ("ServiceRespTFilterPopupActionGroup");
+       gtk_action_group_add_actions (action_group,                                             /* the action group */
+                                     (gpointer)service_resp_t__popup_entries,          /* an array of action descriptions */
+                                     G_N_ELEMENTS(service_resp_t__popup_entries),      /* the number of entries */
+                                     rst);                                                                                     /* data to pass to the action callbacks */
+
+       ui_manager = gtk_ui_manager_new ();
+       gtk_ui_manager_insert_action_group (ui_manager,
+               action_group,
+               0); /* the position at which the group will be inserted */
+       gtk_ui_manager_add_ui_from_string (ui_manager,ui_desc_service_resp_t_filter_popup, -1, &error);
+       if (error != NULL)
+    {
+        fprintf (stderr, "Warning: building service response time filter popup failed: %s\n",
+                error->message);
+        g_error_free (error);
+        error = NULL;
+    }
+       rst->menu = gtk_ui_manager_get_widget(ui_manager, "/ServiceRespTFilterPopup");
+       g_signal_connect(rst->table, "button_press_event", G_CALLBACK(srt_show_popup_menu_cb), rst);
+
+}
 
-       item_factory = gtk_item_factory_new(GTK_TYPE_MENU, "<main>", NULL);
+/* ---------------- */
+static void
+srt_time_func (GtkTreeViewColumn *column _U_,
+              GtkCellRenderer   *renderer,
+              GtkTreeModel      *model,
+              GtkTreeIter       *iter,
+              gpointer           user_data)
+{
+        gchar *str;
+        nstime_t *data;
+
+        /* The col to get data from is in userdata */
+        gint data_column = GPOINTER_TO_INT(user_data);
+
+        gtk_tree_model_get(model, iter, data_column, &data, -1);
+        if (!data) {
+                g_object_set(renderer, "text", "", NULL);
+                return;
+        }
+        str = g_strdup_printf("%3d.%06d", (int)data->secs, (data->nsecs+500)/1000);
+        g_object_set(renderer, "text", str, NULL);
+        g_free(str);
+}
 
-       gtk_item_factory_create_items_ac(item_factory, sizeof(srt_list_menu_items)/sizeof(srt_list_menu_items[0]), srt_list_menu_items, rst, 2);
+static void
+srt_avg_func (GtkTreeViewColumn *column _U_,
+             GtkCellRenderer   *renderer,
+             GtkTreeModel      *model,
+             GtkTreeIter       *iter,
+             gpointer           user_data)
+{
+       gchar *str;
+       guint64 td;
+       gint data_column = GPOINTER_TO_INT(user_data);
 
-       rst->menu = gtk_item_factory_get_widget(item_factory, "<main>");
-       g_signal_connect(rst->table, "button_press_event", G_CALLBACK(srt_show_popup_menu_cb), rst);
+       gtk_tree_model_get(model, iter, data_column, &td, -1);
+       str=g_strdup_printf("%3d.%06d",
+                           (int)(td/1000000), (int)(td%1000000));
+       g_object_set(renderer, "text", str, NULL);
+       g_free(str);
+}
+
+static gint
+srt_time_sort_func(GtkTreeModel *model,
+                  GtkTreeIter *a,
+                  GtkTreeIter *b,
+                  gpointer user_data)
+{
+        nstime_t *ns_a;
+        nstime_t *ns_b;
+        gint ret = 0;
+        gint data_column = GPOINTER_TO_INT(user_data);
+
+        gtk_tree_model_get(model, a, data_column, &ns_a, -1);
+        gtk_tree_model_get(model, b, data_column, &ns_b, -1);
+
+       if (ns_a == ns_b) {
+               ret = 0;
+       }
+       else if (ns_a == NULL || ns_b == NULL) {
+               ret = (ns_a == NULL) ? -1 : 1;
+       }
+       else {
+               ret = nstime_cmp(ns_a,ns_b);
+       }
+       return ret;
 }
 
 /*
@@ -189,19 +411,19 @@ init_srt_table(srt_stat_table *rst, int num_procs, GtkWidget *vbox, const char *
 
        /* Create the store */
        store = gtk_list_store_new (N_COLUMNS,  /* Total number of columns */
-                               G_TYPE_INT,     /* Index     */
-                               G_TYPE_STRING,   /* Procedure */
-                               G_TYPE_INT,     /* Calls     */
-                               G_TYPE_STRING,   /* Min SRT   */
-                               G_TYPE_STRING,   /* Max SRT   */
-                               G_TYPE_STRING);  /* Avg SRT   */
-
-      /* Create a view */
-    tree = gtk_tree_view_new_with_model (GTK_TREE_MODEL (store));
-    rst->table = GTK_TREE_VIEW(tree);
-    sortable = GTK_TREE_SORTABLE(store);
-
-    /* The view now holds a reference.  We can get rid of our own reference */
+                                   G_TYPE_INT,         /* Index     */
+                                   G_TYPE_STRING,   /* Procedure */
+                                   G_TYPE_UINT,        /* Calls     */
+                                   G_TYPE_POINTER,  /* Min SRT   */
+                                   G_TYPE_POINTER,  /* Max SRT   */
+                                   G_TYPE_UINT64);  /* Avg SRT   */
+
+       /* Create a view */
+       tree = gtk_tree_view_new_with_model (GTK_TREE_MODEL (store));
+       rst->table = GTK_TREE_VIEW(tree);
+       sortable = GTK_TREE_SORTABLE(store);
+
+       /* The view now holds a reference.  We can get rid of our own reference */
        g_object_unref (G_OBJECT (store));
 
        if(filter_string){
@@ -216,9 +438,23 @@ init_srt_table(srt_stat_table *rst, int num_procs, GtkWidget *vbox, const char *
                        g_object_set(G_OBJECT(renderer), "xalign", 1.0, NULL);
                }
                g_object_set(renderer, "ypad", 0, NULL);
-               column = gtk_tree_view_column_new_with_attributes (default_titles[i], renderer, "text", 
-                               i, NULL);
-                               
+               switch (i) {
+               case MIN_SRT_COLUMN:
+               case MAX_SRT_COLUMN:
+                       column = gtk_tree_view_column_new_with_attributes (default_titles[i], renderer, NULL);
+                       gtk_tree_view_column_set_cell_data_func(column, renderer, srt_time_func,  GINT_TO_POINTER(i), NULL);
+                       gtk_tree_sortable_set_sort_func(sortable, i, srt_time_sort_func, GINT_TO_POINTER(i), NULL);
+                       break;
+               case AVG_SRT_COLUMN:
+                       column = gtk_tree_view_column_new_with_attributes (default_titles[i], renderer, NULL);
+                       gtk_tree_view_column_set_cell_data_func(column, renderer, srt_avg_func,  GINT_TO_POINTER(i), NULL);
+                       break;
+               default:
+                       column = gtk_tree_view_column_new_with_attributes (default_titles[i], renderer, "text",
+                                       i, NULL);
+                       break;
+               }
+
                gtk_tree_view_column_set_sort_column_id(column, i);
                gtk_tree_view_column_set_resizable(column, TRUE);
                gtk_tree_view_append_column (rst->table, column);
@@ -235,7 +471,7 @@ init_srt_table(srt_stat_table *rst, int num_procs, GtkWidget *vbox, const char *
        gtk_container_add(GTK_CONTAINER(rst->scrolled_window), GTK_WIDGET (rst->table));
        gtk_box_pack_start(GTK_BOX(vbox), rst->scrolled_window, TRUE, TRUE, 0);
 
-    gtk_tree_view_set_reorderable (rst->table, FALSE);   
+       gtk_tree_view_set_reorderable (rst->table, FALSE);
        /* Now enable the sorting of each column */
        gtk_tree_view_set_rules_hint(rst->table, TRUE);
        gtk_tree_view_set_headers_clickable(rst->table, TRUE);
@@ -305,9 +541,9 @@ add_srt_table_data(srt_stat_table *rst, int index, const nstime_t *req_time, pac
                                   INDEX_COLUMN,     rp->index,
                                   PROCEDURE_COLUMN, rp->procedure,
                                   CALLS_COLUMN,     rp->stats.num,
-                                  MIN_SRT_COLUMN,   "",
-                                  MAX_SRT_COLUMN,   "",
-                                  AVG_SRT_COLUMN,   "",
+                                  MIN_SRT_COLUMN,   NULL,
+                                  MAX_SRT_COLUMN,   NULL,
+                                  AVG_SRT_COLUMN,   (guint64)0,
                                   -1);
        }
 
@@ -323,7 +559,6 @@ draw_srt_table_data(srt_stat_table *rst)
 {
        int i;
        guint64 td;
-       char *min, *max, *avg;
        GtkListStore *store = GTK_LIST_STORE(gtk_tree_view_get_model(rst->table));
 
        for(i=0;i<rst->num_procs;i++){
@@ -331,32 +566,20 @@ draw_srt_table_data(srt_stat_table *rst)
                if(rst->procedures[i].stats.num==0){
                        continue;
                }
+               /* Scale the average SRT in units of 1us and round to the nearest us.
+                  tot.secs is a time_t which may be 32 or 64 bits (or even floating)
+                  depending uon the platform.  After casting tot.secs to 64 bits, it
+                  would take a capture with a duration of over 136 *years* to
+                  overflow the secs portion of td. */
+               td = ((guint64)(rst->procedures[i].stats.tot.secs))*NANOSECS_PER_SEC + rst->procedures[i].stats.tot.nsecs;
+               td = ((td / rst->procedures[i].stats.num) + 500) / 1000;
 
-               /* scale it to units of 10us.*/
-               /* for long captures with a large tot time, this can overflow on 32bit */
-               td=(int)rst->procedures[i].stats.tot.secs;
-               td=td*100000+(int)rst->procedures[i].stats.tot.nsecs/10000;
-               td/=rst->procedures[i].stats.num;
-
-               min=g_strdup_printf("%3d.%05d",
-                   (int)rst->procedures[i].stats.min.secs,
-                   rst->procedures[i].stats.min.nsecs/10000);
-
-               max=g_strdup_printf("%3d.%05d",
-                   (int)rst->procedures[i].stats.max.secs,
-                   rst->procedures[i].stats.max.nsecs/10000);
-               avg=g_strdup_printf("%3" G_GINT64_MODIFIER "d.%05" G_GINT64_MODIFIER "d",
-                   td/100000, td%100000);
-                   
                gtk_list_store_set(store, &rst->procedures[i].iter,
                                   CALLS_COLUMN,     rst->procedures[i].stats.num,
-                                  MIN_SRT_COLUMN,   min,
-                                  MAX_SRT_COLUMN,   max,
-                                  AVG_SRT_COLUMN,   avg,
+                                  MIN_SRT_COLUMN,   &rst->procedures[i].stats.min,
+                                  MAX_SRT_COLUMN,   &rst->procedures[i].stats.max,
+                                  AVG_SRT_COLUMN,   td,
                                   -1);
-               g_free(min);
-               g_free(max);
-               g_free(avg);
        }
 }