From Derek Morr:
[obnox/wireshark/wip.git] / epan / dissectors / packet-kerberos.c
index f398d0b22a755b8c79ae6a2f4b6ef8d2b543d1cb..b3338ef8a9c6fb09b5d68cc02f77226187a14997 100644 (file)
  *
  * and
  *
- *     http://www.ietf.org/internet-drafts/draft-ietf-krb-wg-kerberos-clarifications-05.txt
+ *     http://www.ietf.org/internet-drafts/draft-ietf-krb-wg-kerberos-clarifications-07.txt
  *
  * and
  *
- *      http://www.ietf.org/internet-drafts/draft-ietf-krb-wg-kerberos-referrals-03.txt
+ *      http://www.ietf.org/internet-drafts/draft-ietf-krb-wg-kerberos-referrals-05.txt
  *
  * Some structures from RFC2630
  *
+ * Ted Percival ted[AT]midg3t.net
+ *     Support for PA-S4U2Self Kerberos packet type based on ASN.1 description
+ *     in Heimdal:
+ *     http://loka.it.su.se/source/xref/heimdal/heimdal/lib/asn1/k5.asn1
+ *
  * $Id$
  *
- * Ethereal - Network traffic analyzer
- * By Gerald Combs <gerald@ethereal.com>
+ * Wireshark - Network traffic analyzer
+ * By Gerald Combs <gerald@wireshark.org>
  * Copyright 1998 Gerald Combs
  *
  * This program is free software; you can redistribute it and/or
@@ -60,6 +65,7 @@
 
 #include <stdio.h>
 #include <string.h>
+#include <glib.h>
 #include <ctype.h>
 
 #ifdef HAVE_LIBNETTLE
 #include <nettle/des.h>
 #include <nettle/cbc.h>
 #endif
-#include "crypt-md5.h"
+#include <epan/crypt/crypt-md5.h>
 #include <sys/stat.h>  /* For keyfile manipulation */
 #endif
 
-#include <glib.h>
-
 #include <epan/packet.h>
 
 #include <epan/strutil.h>
 
 #include <epan/conversation.h>
+#include <epan/emem.h>
+#include <epan/asn1.h>
 #include <epan/dissectors/packet-kerberos.h>
 #include <epan/dissectors/packet-netbios.h>
 #include <epan/dissectors/packet-tcp.h>
 #include <epan/dissectors/packet-dcerpc-netlogon.h>
 #include <epan/dissectors/packet-dcerpc.h>
 
-#include "asn1.h"              /* for "subid_t" */
 #include <epan/dissectors/packet-gssapi.h>
+#include <epan/dissectors/packet-smb-common.h>
+
+#include <wsutil/file_util.h>
 
 #define UDP_PORT_KERBEROS              88
 #define TCP_PORT_KERBEROS              88
@@ -114,6 +122,13 @@ static gint hf_krb_pac_signature_signature = -1;
 static gint hf_krb_pac_clientid = -1;
 static gint hf_krb_pac_namelen = -1;
 static gint hf_krb_pac_clientname = -1;
+static gint hf_krb_pac_upn_flags = -1;
+static gint hf_krb_pac_upn_upn_name = -1;
+static gint hf_krb_pac_upn_dns_name = -1;
+static gint hf_krb_pac_upn_dns_offset = -1;
+static gint hf_krb_pac_upn_dns_len = -1;
+static gint hf_krb_pac_upn_upn_offset = -1;
+static gint hf_krb_pac_upn_upn_len = -1;
 static gint hf_krb_w2k_pac_entries = -1;
 static gint hf_krb_w2k_pac_version = -1;
 static gint hf_krb_w2k_pac_type = -1;
@@ -134,7 +149,11 @@ static gint hf_krb_PAC_CREDENTIAL_TYPE = -1;
 static gint hf_krb_PAC_SERVER_CHECKSUM = -1;
 static gint hf_krb_PAC_PRIVSVR_CHECKSUM = -1;
 static gint hf_krb_PAC_CLIENT_INFO_TYPE = -1;
+static gint hf_krb_PAC_CONSTRAINED_DELEGATION = -1;
+static gint hf_krb_PAC_UPN_DNS_INFO = -1;
 static gint hf_krb_encrypted_PA_ENC_TIMESTAMP = -1;
+static gint hf_krb_encrypted_enc_authorization_data = -1;
+static gint hf_krb_encrypted_EncKrbCredPart = -1;
 static gint hf_krb_checksum_checksum = -1;
 static gint hf_krb_encrypted_PRIV = -1;
 static gint hf_krb_encrypted_Ticket_data = -1;
@@ -143,14 +162,21 @@ static gint hf_krb_encrypted_KDC_REP_data = -1;
 static gint hf_krb_PA_DATA_type = -1;
 static gint hf_krb_PA_DATA_value = -1;
 static gint hf_krb_etype_info_salt = -1;
+static gint hf_krb_etype_info2_salt = -1;
+static gint hf_krb_etype_info2_s2kparams = -1;
 static gint hf_krb_SAFE_BODY_user_data = -1;
+static gint hf_krb_PRIV_BODY_user_data = -1;
 static gint hf_krb_realm = -1;
+static gint hf_krb_srealm = -1;
+static gint hf_krb_prealm = -1;
 static gint hf_krb_crealm = -1;
 static gint hf_krb_sname = -1;
+static gint hf_krb_pname = -1;
 static gint hf_krb_cname = -1;
 static gint hf_krb_name_string = -1;
 static gint hf_krb_provsrv_location = -1;
 static gint hf_krb_e_text = -1;
+static gint hf_krb_s4u2self_auth = -1;
 static gint hf_krb_name_type = -1;
 static gint hf_krb_lr_type = -1;
 static gint hf_krb_from = -1;
@@ -181,10 +207,13 @@ static gint hf_krb_adtype = -1;
 static gint hf_krb_advalue = -1;
 static gint hf_krb_etype = -1;
 static gint hf_krb_etypes = -1;
+static gint hf_krb_KrbCredInfos = -1;
+static gint hf_krb_sq_tickets = -1;
 static gint hf_krb_LastReqs = -1;
 static gint hf_krb_IF_RELEVANT = -1;
 static gint hf_krb_addr_type = -1;
 static gint hf_krb_address_ip = -1;
+static gint hf_krb_address_ipv6 = -1;
 static gint hf_krb_address_netbios = -1;
 static gint hf_krb_msg_type = -1;
 static gint hf_krb_pvno = -1;
@@ -197,11 +226,15 @@ static gint hf_krb_subkey = -1;
 static gint hf_krb_seq_number = -1;
 static gint hf_krb_EncTicketPart = -1;
 static gint hf_krb_EncAPRepPart = -1;
+static gint hf_krb_EncKrbPrivPart = -1;
+static gint hf_krb_EncKrbCredPart = -1;
 static gint hf_krb_EncKDCRepPart = -1;
 static gint hf_krb_LastReq = -1;
 static gint hf_krb_Authenticator = -1;
 static gint hf_krb_Checksum = -1;
 static gint hf_krb_s_address = -1;
+static gint hf_krb_r_address = -1;
+static gint hf_krb_KrbCredInfo = -1;
 static gint hf_krb_HostAddress = -1;
 static gint hf_krb_HostAddresses = -1;
 static gint hf_krb_APOptions = -1;
@@ -229,6 +262,7 @@ static gint hf_krb_KDCOptions_proxy = -1;
 static gint hf_krb_KDCOptions_allow_postdate = -1;
 static gint hf_krb_KDCOptions_postdated = -1;
 static gint hf_krb_KDCOptions_renewable = -1;
+static gint hf_krb_KDCOptions_constrained_delegation = -1;
 static gint hf_krb_KDCOptions_canonicalize = -1;
 static gint hf_krb_KDCOptions_opt_hardware_auth = -1;
 static gint hf_krb_KDCOptions_disable_transited_check = -1;
@@ -238,10 +272,29 @@ static gint hf_krb_KDCOptions_renew = -1;
 static gint hf_krb_KDCOptions_validate = -1;
 static gint hf_krb_KDC_REQ_BODY = -1;
 static gint hf_krb_PRIV_BODY = -1;
+static gint hf_krb_CRED_BODY = -1;
 static gint hf_krb_ENC_PRIV = -1;
 static gint hf_krb_authenticator_enc = -1;
+static gint hf_krb_CRED_enc = -1;
 static gint hf_krb_ticket_enc = -1;
 static gint hf_krb_e_checksum = -1;
+static gint hf_krb_gssapi_len = -1;
+static gint hf_krb_gssapi_bnd = -1;
+static gint hf_krb_gssapi_dlgopt = -1;
+static gint hf_krb_gssapi_dlglen = -1;
+static gint hf_krb_gssapi_c_flag_deleg = -1;
+static gint hf_krb_gssapi_c_flag_mutual = -1;
+static gint hf_krb_gssapi_c_flag_replay = -1;
+static gint hf_krb_gssapi_c_flag_sequence = -1;
+static gint hf_krb_gssapi_c_flag_conf = -1;
+static gint hf_krb_gssapi_c_flag_integ = -1;
+static gint hf_krb_gssapi_c_flag_dce_style = -1;
+static gint hf_krb_smb_nt_status = -1;
+static gint hf_krb_smb_unknown = -1;
+static gint hf_krb_midl_blob_len = -1;
+static gint hf_krb_midl_fill_bytes = -1;
+static gint hf_krb_midl_version = -1;
+static gint hf_krb_midl_hdr_len = -1;
 
 static gint ett_krb_kerberos = -1;
 static gint ett_krb_TransitedEncoding = -1;
@@ -250,9 +303,12 @@ static gint ett_krb_PAC_CREDENTIAL_TYPE = -1;
 static gint ett_krb_PAC_SERVER_CHECKSUM = -1;
 static gint ett_krb_PAC_PRIVSVR_CHECKSUM = -1;
 static gint ett_krb_PAC_CLIENT_INFO_TYPE = -1;
+static gint ett_krb_PAC_CONSTRAINED_DELEGATION = -1;
 static gint ett_krb_KDC_REP_enc = -1;
 static gint ett_krb_EncTicketPart = -1;
 static gint ett_krb_EncAPRepPart = -1;
+static gint ett_krb_EncKrbPrivPart = -1;
+static gint ett_krb_EncKrbCredPart = -1;
 static gint ett_krb_EncKDCRepPart = -1;
 static gint ett_krb_LastReq = -1;
 static gint ett_krb_Authenticator = -1;
@@ -261,18 +317,24 @@ static gint ett_krb_key = -1;
 static gint ett_krb_subkey = -1;
 static gint ett_krb_AuthorizationData = -1;
 static gint ett_krb_sname = -1;
+static gint ett_krb_pname = -1;
 static gint ett_krb_cname = -1;
 static gint ett_krb_AP_REP_enc = -1;
 static gint ett_krb_padata = -1;
 static gint ett_krb_etypes = -1;
+static gint ett_krb_KrbCredInfos = -1;
+static gint ett_krb_sq_tickets = -1;
 static gint ett_krb_LastReqs = -1;
 static gint ett_krb_IF_RELEVANT = -1;
 static gint ett_krb_PA_DATA_tree = -1;
 static gint ett_krb_PAC = -1;
 static gint ett_krb_s_address = -1;
+static gint ett_krb_r_address = -1;
+static gint ett_krb_KrbCredInfo = -1;
 static gint ett_krb_HostAddress = -1;
 static gint ett_krb_HostAddresses = -1;
 static gint ett_krb_authenticator_enc = -1;
+static gint ett_krb_CRED_enc = -1;
 static gint ett_krb_AP_Options = -1;
 static gint ett_krb_KDC_Options = -1;
 static gint ett_krb_Ticket_Flags = -1;
@@ -280,14 +342,20 @@ static gint ett_krb_request = -1;
 static gint ett_krb_recordmark = -1;
 static gint ett_krb_ticket = -1;
 static gint ett_krb_ticket_enc = -1;
+static gint ett_krb_CRED = -1;
 static gint ett_krb_PRIV = -1;
 static gint ett_krb_PRIV_enc = -1;
 static gint ett_krb_e_checksum = -1;
+static gint ett_krb_PAC_MIDL_BLOB = -1;
+static gint ett_krb_PAC_DREP = -1;
+static gint ett_krb_PAC_UPN_DNS_INFO = -1;
 
 guint32 krb5_errorcode;
 
 
-static int do_col_info;
+static dissector_handle_t krb4_handle=NULL;
+
+static gboolean do_col_info;
 
 
 static void
@@ -317,53 +385,53 @@ call_kerberos_callbacks(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int
 static gboolean krb_decrypt = FALSE;
 
 /* keytab filename */
-static char *keytab_filename = "insert filename here";
+static const char *keytab_filename = "insert filename here";
 
 #endif
 
-#ifdef HAVE_MIT_KERBEROS
+#if defined(HAVE_HEIMDAL_KERBEROS) || defined(HAVE_MIT_KERBEROS)
+#ifdef _WIN32
+/* prevent redefinition warnings in kfw-2.5\inc\win_mac.h */
+#undef HAVE_STDARG_H
+#undef HAVE_SYS_TYPES_H
+#endif
 #include <krb5.h>
-
-#define MAX_ORIG_LEN   256
-typedef struct _enc_key_t {
-       struct _enc_key_t       *next;
-       krb5_keytab_entry       key;
-       char                    key_origin[MAX_ORIG_LEN+1];
-} enc_key_t;
-static enc_key_t *enc_key_list=NULL;
-
+enc_key_t *enc_key_list=NULL;
 
 static void
-add_encryption_key(packet_info *pinfo, int keytype, int keylength, const char *keyvalue, char *origin)
+add_encryption_key(packet_info *pinfo, int keytype, int keylength, const char *keyvalue, const char *origin)
 {
        enc_key_t *new_key;
 
        if(pinfo->fd->flags.visited){
                return;
        }
-printf("added key in %d\n",pinfo->fd->num);
+printf("added key in %u\n",pinfo->fd->num);
 
        new_key=g_malloc(sizeof(enc_key_t));
-       sprintf(new_key->key_origin, "%s learnt from frame %d",origin,pinfo->fd->num);
+       g_snprintf(new_key->key_origin, KRB_MAX_ORIG_LEN, "%s learnt from frame %u",origin,pinfo->fd->num);
        new_key->next=enc_key_list;
        enc_key_list=new_key;
-       new_key->key.principal=NULL;
-       new_key->key.vno=0;
-       new_key->key.key.enctype=keytype;
-       new_key->key.key.length=keylength;
-       new_key->key.key.contents=g_malloc(keylength);
-       memcpy(new_key->key.key.contents, keyvalue, keylength);
+       new_key->keytype=keytype;
+       new_key->keylength=keylength;
+       /*XXX this needs to be freed later */
+       new_key->keyvalue=g_memdup(keyvalue, keylength);
 }
+#endif /* HAVE_HEIMDAL_KERBEROS || HAVE_MIT_KERBEROS */
+
+
+#ifdef HAVE_MIT_KERBEROS
 
 static void
-read_keytab_file(char *filename, krb5_context *context)
+read_keytab_file(const char *filename, krb5_context *context)
 {
        krb5_keytab keytab;
+       krb5_keytab_entry key;
        krb5_error_code ret;
        krb5_kt_cursor cursor;
        enc_key_t *new_key;
 
-       /* should use a file in the ethereal users dir */
+       /* should use a file in the wireshark users dir */
        ret = krb5_kt_resolve(*context, filename, &keytab);
        if(ret){
                fprintf(stderr, "KERBEROS ERROR: Could not open keytab file :%s\n",filename);
@@ -380,20 +448,26 @@ read_keytab_file(char *filename, krb5_context *context)
        do{
                new_key=g_malloc(sizeof(enc_key_t));
                new_key->next=enc_key_list;
-               ret = krb5_kt_next_entry(*context, keytab, &(new_key->key), &cursor);
+               ret = krb5_kt_next_entry(*context, keytab, &key, &cursor);
                if(ret==0){
                        int i;
                        char *pos;
 
                        /* generate origin string, describing where this key came from */
                        pos=new_key->key_origin;
-                       pos+=sprintf(pos, "keytab principal ");
-                       for(i=0;i<new_key->key.principal->length;i++){
-                               pos+=sprintf(pos,"%s%s",(i?"/":""),(new_key->key.principal->data[i]).data);
+                       pos+=MIN(KRB_MAX_ORIG_LEN,
+                                g_snprintf(pos, KRB_MAX_ORIG_LEN, "keytab principal "));
+                       for(i=0;i<key.principal->length;i++){
+                               pos+=MIN(KRB_MAX_ORIG_LEN-(pos-new_key->key_origin),
+                                        g_snprintf(pos, KRB_MAX_ORIG_LEN-(pos-new_key->key_origin), "%s%s",(i?"/":""),(key.principal->data[i]).data));
                        }
-                       pos+=sprintf(pos,"@%s",new_key->key.principal->realm.data);
+                       pos+=MIN(KRB_MAX_ORIG_LEN-(pos-new_key->key_origin),
+                                g_snprintf(pos, KRB_MAX_ORIG_LEN-(pos-new_key->key_origin), "@%s",key.principal->realm.data));
                        *pos=0;
 /*printf("added key for principal :%s\n", new_key->key_origin);*/
+                       new_key->keytype=key.key.enctype;
+                       new_key->keylength=key.key.length;
+                       new_key->keyvalue=g_memdup(key.key.contents, key.key.length);
                        enc_key_list=new_key;
                }
        }while(ret==0);
@@ -406,11 +480,11 @@ read_keytab_file(char *filename, krb5_context *context)
 }
 
 
-static guint8 *
+guint8 *
 decrypt_krb5_data(proto_tree *tree, packet_info *pinfo,
-                       krb5_keyusage usage,
+                       int usage,
                        int length,
-                       const char *cryptotext,
+                       const guint8 *cryptotext,
                        int keytype)
 {
        static int first_time=1;
@@ -418,6 +492,7 @@ decrypt_krb5_data(proto_tree *tree, packet_info *pinfo,
        krb5_error_code ret;
        enc_key_t *ek;
        static krb5_data data = {0,0,NULL};
+       krb5_keytab_entry key;
 
        /* dont do anything if we are not attempting to decrypt data */
        if(!krb_decrypt){
@@ -440,7 +515,12 @@ decrypt_krb5_data(proto_tree *tree, packet_info *pinfo,
        for(ek=enc_key_list;ek;ek=ek->next){
                krb5_enc_data input;
 
-               input.enctype = ek->key.key.enctype;
+               /* shortcircuit and bail out if enctypes are not matching */
+               if(ek->keytype!=keytype){
+                       continue;
+               }
+
+               input.enctype = ek->keytype;
                input.ciphertext.length = length;
                input.ciphertext.data = (guint8 *)cryptotext;
 
@@ -450,16 +530,19 @@ decrypt_krb5_data(proto_tree *tree, packet_info *pinfo,
                }
                data.data = g_malloc(length);
 
-               /* shortcircuit and bail out if enctypes are not matching */
-               if(ek->key.key.enctype!=keytype){
-                       continue;
-               }
+               key.key.enctype=ek->keytype;
+               key.key.length=ek->keylength;
+               key.key.contents=ek->keyvalue;
+               ret = krb5_c_decrypt(context, &(key.key), usage, 0, &input, &data);
+               if((ret == 0) && (length>0)){
+                       char *user_data;
 
-               ret = krb5_c_decrypt(context, &(ek->key.key), usage, 0, &input, &data);
-               if (ret == 0) {
-printf("woohoo decrypted keytype:%d in frame:%d\n", keytype, pinfo->fd->num);
+printf("woohoo decrypted keytype:%d in frame:%u\n", keytype, pinfo->fd->num);
                        proto_tree_add_text(tree, NULL, 0, 0, "[Decrypted using: %s]", ek->key_origin);
-                       return data.data;
+                       /* return a private g_malloced blob to the caller */
+                       user_data=g_malloc(data.length);
+                       memcpy(user_data, data.data, data.length);
+                       return user_data;
                }
        }
 
@@ -467,50 +550,16 @@ printf("woohoo decrypted keytype:%d in frame:%d\n", keytype, pinfo->fd->num);
 }
 
 #elif defined(HAVE_HEIMDAL_KERBEROS)
-
-#include <krb5.h>
-
-#define MAX_ORIG_LEN   256
-typedef struct _enc_key_t {
-       struct _enc_key_t       *next;
-       krb5_keytab_entry       key;
-       char                    key_origin[MAX_ORIG_LEN+1];
-} enc_key_t;
-static enc_key_t *enc_key_list=NULL;
-
-
-static void
-add_encryption_key(packet_info *pinfo, int keytype, int keylength, const char *keyvalue, char *origin)
-{
-       enc_key_t *new_key;
-
-       if(pinfo->fd->flags.visited){
-               return;
-       }
-printf("added key in %d\n",pinfo->fd->num);
-
-       new_key=g_malloc(sizeof(enc_key_t));
-       sprintf(new_key->key_origin, "%s learnt from frame %d",origin,pinfo->fd->num);
-       new_key->next=enc_key_list;
-       enc_key_list=new_key;
-       new_key->key.principal=NULL;
-       new_key->key.vno=0;
-       new_key->key.keyblock.keytype=keytype;
-       new_key->key.keyblock.keyvalue.length=keylength;
-       new_key->key.keyblock.keyvalue.data=g_malloc(keylength);
-       memcpy(new_key->key.keyblock.keyvalue.data, keyvalue, keylength);
-       new_key->key.timestamp=0;
-}
-
 static void
-read_keytab_file(char *filename, krb5_context *context)
+read_keytab_file(const char *filename, krb5_context *context)
 {
        krb5_keytab keytab;
+       krb5_keytab_entry key;
        krb5_error_code ret;
        krb5_kt_cursor cursor;
        enc_key_t *new_key;
 
-       /* should use a file in the ethereal users dir */
+       /* should use a file in the wireshark users dir */
        ret = krb5_kt_resolve(*context, filename, &keytab);
        if(ret){
                fprintf(stderr, "KERBEROS ERROR: Could not open keytab file :%s\n",filename);
@@ -527,20 +576,25 @@ read_keytab_file(char *filename, krb5_context *context)
        do{
                new_key=g_malloc(sizeof(enc_key_t));
                new_key->next=enc_key_list;
-               ret = krb5_kt_next_entry(*context, keytab, &(new_key->key), &cursor);
+               ret = krb5_kt_next_entry(*context, keytab, &key, &cursor);
                if(ret==0){
                        unsigned int i;
                        char *pos;
 
                        /* generate origin string, describing where this key came from */
                        pos=new_key->key_origin;
-                       pos+=sprintf(pos, "keytab principal ");
-                       for(i=0;i<new_key->key.principal->name.name_string.len;i++){
-                               pos+=sprintf(pos,"%s%s",(i?"/":""),new_key->key.principal->name.name_string.val[i]);
+                       pos+=MIN(KRB_MAX_ORIG_LEN,
+                                g_snprintf(pos, KRB_MAX_ORIG_LEN, "keytab principal "));
+                       for(i=0;i<key.principal->name.name_string.len;i++){
+                               pos+=MIN(KRB_MAX_ORIG_LEN-(pos-new_key->key_origin),
+                                        g_snprintf(pos, KRB_MAX_ORIG_LEN-(pos-new_key->key_origin), "%s%s",(i?"/":""),key.principal->name.name_string.val[i]));
                        }
-                       pos+=sprintf(pos,"@%s",new_key->key.principal->realm);
+                       pos+=MIN(KRB_MAX_ORIG_LEN-(pos-new_key->key_origin),
+                                g_snprintf(pos, KRB_MAX_ORIG_LEN-(pos-new_key->key_origin), "@%s",key.principal->realm));
                        *pos=0;
-
+                       new_key->keytype=key.keyblock.keytype;
+                       new_key->keylength=key.keyblock.keyvalue.length;
+                       new_key->keyvalue=g_memdup(key.keyblock.keyvalue.data, key.keyblock.keyvalue.length);
                        enc_key_list=new_key;
                }
        }while(ret==0);
@@ -553,11 +607,11 @@ read_keytab_file(char *filename, krb5_context *context)
 }
 
 
-static guint8 *
+guint8 *
 decrypt_krb5_data(proto_tree *tree, packet_info *pinfo,
-                       krb5_keyusage usage,
+                       int usage,
                        int length,
-                       const char *cryptotext,
+                       const guint8 *cryptotext,
                        int keytype)
 {
        static int first_time=1;
@@ -585,15 +639,19 @@ decrypt_krb5_data(proto_tree *tree, packet_info *pinfo,
        }
 
        for(ek=enc_key_list;ek;ek=ek->next){
+               krb5_keytab_entry key;
                krb5_crypto crypto;
                guint8 *cryptocopy; /* workaround for pre-0.6.1 heimdal bug */
 
                /* shortcircuit and bail out if enctypes are not matching */
-               if(ek->key.keyblock.keytype!=keytype){
+               if(ek->keytype!=keytype){
                        continue;
                }
 
-               ret = krb5_crypto_init(context, &(ek->key.keyblock), 0, &crypto);
+               key.keyblock.keytype=ek->keytype;
+               key.keyblock.keyvalue.length=ek->keylength;
+               key.keyblock.keyvalue.data=ek->keyvalue;
+               ret = krb5_crypto_init(context, &(key.keyblock), 0, &crypto);
                if(ret){
                        return NULL;
                }
@@ -611,11 +669,16 @@ decrypt_krb5_data(proto_tree *tree, packet_info *pinfo,
                                &data,
                                NULL);
                g_free(cryptocopy);
-               if (ret == 0) {
-printf("woohoo decrypted keytype:%d in frame:%d\n", keytype, pinfo->fd->num);
+               if((ret == 0) && (length>0)){
+                       char *user_data;
+
+printf("woohoo decrypted keytype:%d in frame:%u\n", keytype, pinfo->fd->num);
                        proto_tree_add_text(tree, NULL, 0, 0, "[Decrypted using: %s]", ek->key_origin);
                        krb5_crypto_destroy(context, crypto);
-                       return data.data;
+                       /* return a private g_malloced blob to the caller */
+                       user_data=g_malloc(data.length);
+                       memcpy(user_data, data.data, data.length);
+                       return user_data;
                }
                krb5_crypto_destroy(context, crypto);
        }
@@ -624,7 +687,6 @@ printf("woohoo decrypted keytype:%d in frame:%d\n", keytype, pinfo->fd->num);
 
 #elif defined (HAVE_LIBNETTLE)
 
-#define MAX_ORIG_LEN   256
 #define SERVICE_KEY_SIZE (DES3_KEY_SIZE + 2)
 #define KEYTYPE_DES3_CBC_MD5 5 /* Currently the only one supported */
 
@@ -633,20 +695,20 @@ typedef struct _service_key_t {
     int     keytype;
     int     length;
     guint8 *contents;
-    char    origin[MAX_ORIG_LEN+1];
+    char    origin[KRB_MAX_ORIG_LEN+1];
 } service_key_t;
 GSList *service_key_list = NULL;
 
 
 static void
-add_encryption_key(packet_info *pinfo, int keytype, int keylength, const char *keyvalue, char *origin)
+add_encryption_key(packet_info *pinfo, int keytype, int keylength, const char *keyvalue, const char *origin)
 {
        service_key_t *new_key;
 
        if(pinfo->fd->flags.visited){
                return;
        }
-printf("added key in %d\n",pinfo->fd->num);
+printf("added key in %u\n",pinfo->fd->num);
 
        new_key = g_malloc(sizeof(service_key_t));
        new_key->kvno = 0;
@@ -654,7 +716,7 @@ printf("added key in %d\n",pinfo->fd->num);
        new_key->length = keylength;
        new_key->contents = g_malloc(keylength);
        memcpy(new_key->contents, keyvalue, keylength);
-       sprintf(new_key->origin, "%s learnt from frame %d", origin, pinfo->fd->num);
+       g_snprintf(new_key->origin, KRB_MAX_ORIG_LEN, "%s learnt from frame %u", origin, pinfo->fd->num);
        service_key_list = g_slist_append(service_key_list, (gpointer) new_key);
 }
 
@@ -673,7 +735,7 @@ clear_keytab(void) {
 }
 
 static void
-read_keytab_file(char *service_key_file)
+read_keytab_file(const char *service_key_file)
 {
        FILE *skf;
        struct stat st;
@@ -681,7 +743,7 @@ read_keytab_file(char *service_key_file)
        unsigned char buf[SERVICE_KEY_SIZE];
        int newline_skip = 0, count = 0;
 
-       if (service_key_file != NULL && stat (service_key_file, &st) == 0) {
+       if (service_key_file != NULL && ws_stat (service_key_file, &st) == 0) {
 
                /* The service key file contains raw 192-bit (24 byte) 3DES keys.
                 * There can be zero, one (\n), or two (\r\n) characters between
@@ -699,7 +761,7 @@ read_keytab_file(char *service_key_file)
                        }
                }
 
-               skf = fopen(service_key_file, "rb");
+               skf = ws_fopen(service_key_file, "rb");
                if (! skf) return;
 
                while (fread(buf, SERVICE_KEY_SIZE, 1, skf) == 1) {
@@ -709,7 +771,7 @@ read_keytab_file(char *service_key_file)
                        sk->length = DES3_KEY_SIZE;
                        sk->contents = g_malloc(DES3_KEY_SIZE);
                        memcpy(sk->contents, buf + 2, DES3_KEY_SIZE);
-                       sprintf(sk->origin, "3DES service key file, key #%d, offset %ld", count, ftell(skf));
+                       g_snprintf(sk->origin, KRB_MAX_ORIG_LEN, "3DES service key file, key #%d, offset %ld", count, ftell(skf));
                        service_key_list = g_slist_append(service_key_list, (gpointer) sk);
                        fseek(skf, newline_skip, SEEK_CUR);
                        count++;
@@ -721,11 +783,11 @@ g_warning("added key: %s", sk->origin);
 
 #define CONFOUNDER_PLUS_CHECKSUM 24
 
-static guint8 *
-decrypt_krb5_data(proto_tree _U_ *tree, packet_info *pinfo,
+guint8 *
+decrypt_krb5_data(proto_tree *tree, packet_info *pinfo,
                        int _U_ usage,
                        int length,
-                       const char *cryptotext,
+                       const guint8 *cryptotext,
                        int keytype)
 {
        tvbuff_t *encr_tvb;
@@ -758,6 +820,7 @@ decrypt_krb5_data(proto_tree _U_ *tree, packet_info *pinfo,
 
        decrypted_data = g_malloc(length);
        for(ske = service_key_list; ske != NULL; ske = g_slist_next(ske)){
+               gboolean do_continue = FALSE;
                sk = (service_key_t *) ske->data;
 
                des_fix_parity(DES3_KEY_SIZE, key, sk->contents);
@@ -782,10 +845,12 @@ decrypt_krb5_data(proto_tree _U_ *tree, packet_info *pinfo,
                }
                CATCH (BoundsError) {
                        tvb_free(encr_tvb);
-                       continue;
+                       do_continue = TRUE;
                }
                ENDTRY;
 
+               if (do_continue) continue;
+
                data_len = item_len + offset - CONFOUNDER_PLUS_CHECKSUM;
                if ((int) item_len + offset > length) {
                        tvb_free(encr_tvb);
@@ -798,7 +863,7 @@ decrypt_krb5_data(proto_tree _U_ *tree, packet_info *pinfo,
                md5_finish(&md5s, digest);
 
                if (tvb_memeql (encr_tvb, 8, digest, 16) == 0) {
-g_warning("woohoo decrypted keytype:%d in frame:%d\n", keytype, pinfo->fd->num);
+g_warning("woohoo decrypted keytype:%d in frame:%u\n", keytype, pinfo->fd->num);
                        plaintext = g_malloc(data_len);
                        tvb_memcpy(encr_tvb, plaintext, CONFOUNDER_PLUS_CHECKSUM, data_len);
                        tvb_free(encr_tvb);
@@ -815,12 +880,13 @@ g_warning("woohoo decrypted keytype:%d in frame:%d\n", keytype, pinfo->fd->num);
 
 #endif /* HAVE_MIT_KERBEROS / HAVE_HEIMDAL_KERBEROS / HAVE_LIBNETTLE */
 
-
+#define        INET6_ADDRLEN   16
 
 /* TCP Record Mark */
 #define        KRB_RM_RESERVED 0x80000000L
 #define        KRB_RM_RECLEN   0x7fffffffL
 
+#define KRB5_MSG_TICKET                        1       /* Ticket */
 #define KRB5_MSG_AUTHENTICATOR         2       /* Authenticator */
 #define KRB5_MSG_ENC_TICKET_PART       3       /* EncTicketPart */
 #define KRB5_MSG_AS_REQ                10      /* AS-REQ type */
@@ -836,6 +902,8 @@ g_warning("woohoo decrypted keytype:%d in frame:%d\n", keytype, pinfo->fd->num);
 #define KRB5_MSG_ENC_AS_REP_PART       25      /* EncASRepPart */
 #define KRB5_MSG_ENC_TGS_REP_PART      26      /* EncTGSRepPart */
 #define KRB5_MSG_ENC_AP_REP_PART       27      /* EncAPRepPart */
+#define KRB5_MSG_ENC_KRB_PRIV_PART             28      /* EncKrbPrivPart */
+#define KRB5_MSG_ENC_KRB_CRED_PART             29      /* EncKrbCredPart */
 #define KRB5_MSG_ERROR                 30      /* KRB-ERROR type */
 
 /* address type constants */
@@ -865,6 +933,8 @@ g_warning("woohoo decrypted keytype:%d in frame:%d\n", keytype, pinfo->fd->num);
 #define KRB5_ENCTYPE_RSA_ES_OEAP_ENV     14
 #define KRB5_ENCTYPE_DES_EDE3_CBC_ENV    15
 #define KRB5_ENCTYPE_DES3_CBC_SHA1       16
+#define KRB5_ENCTYPE_AES128_CTS_HMAC_SHA1_96 17
+#define KRB5_ENCTYPE_AES256_CTS_HMAC_SHA1_96 18
 #define KRB5_ENCTYPE_DES_CBC_MD5_NT      20
 #define KERB_ENCTYPE_RC4_HMAC            23
 #define KERB_ENCTYPE_RC4_HMAC_EXP        24
@@ -904,7 +974,7 @@ g_warning("woohoo decrypted keytype:%d in frame:%d\n", keytype, pinfo->fd->num);
 #define KRB5_CHKSUM_REAL_CRC32          0xffffff7c
 #define KRB5_CHKSUM_SHA1                0xffffff7d
 #define KRB5_CHKSUM_LM                  0xffffff7e
-
+#define KRB5_CHKSUM_GSSAPI             0x8003
 
 /*
  * For KERB_ENCTYPE_RC4_HMAC and KERB_ENCTYPE_RC4_HMAC_EXP, see
@@ -931,6 +1001,7 @@ g_warning("woohoo decrypted keytype:%d in frame:%d\n", keytype, pinfo->fd->num);
 #define KRB5_PA_PK_AS_REQ              14
 #define KRB5_PA_PK_AS_REP              15
 #define KRB5_PA_DASS                   16
+#define KRB5_PA_ENCTYPE_INFO2          19
 #define KRB5_PA_USE_SPECIFIED_KVNO     20
 #define KRB5_PA_SAM_REDIRECT           21
 #define KRB5_PA_GET_FROM_TYPED_DATA    22
@@ -951,6 +1022,7 @@ g_warning("woohoo decrypted keytype:%d in frame:%d\n", keytype, pinfo->fd->num);
    come up with something better
 */
 #define KRB5_PA_PAC_REQUEST            128     /* MS extension */
+#define KRB5_PA_S4U2SELF               129     /* Impersonation (Microsoft extension) */
 #define KRB5_PA_PROV_SRV_LOCATION      255     /* packetcable stuff */
 
 /* Principal name-type */
@@ -1126,12 +1198,16 @@ static const value_string krb5_error_codes[] = {
 #define PAC_SERVER_CHECKSUM    6
 #define PAC_PRIVSVR_CHECKSUM   7
 #define PAC_CLIENT_INFO_TYPE   10
+#define PAC_CONSTRAINED_DELEGATION 11
+#define PAC_UPN_DNS_INFO        12
 static const value_string w2k_pac_types[] = {
     { PAC_LOGON_INFO           , "Logon Info" },
     { PAC_CREDENTIAL_TYPE      , "Credential Type" },
     { PAC_SERVER_CHECKSUM      , "Server Checksum" },
     { PAC_PRIVSVR_CHECKSUM     , "Privsvr Checksum" },
     { PAC_CLIENT_INFO_TYPE     , "Client Info Type" },
+    { PAC_CONSTRAINED_DELEGATION, "Constrained Delegation" },
+    { PAC_UPN_DNS_INFO         , "UPN DNS Info" },
     { 0, NULL },
 };
 
@@ -1167,6 +1243,7 @@ static const value_string krb5_preauthentication_types[] = {
     { KRB5_PA_CYBERSAFE_SECUREID   , "PA-CYBERSAFE-SECURID" },
     { KRB5_PA_AFS3_SALT            , "PA-AFS3-SALT" },
     { KRB5_PA_ENCTYPE_INFO         , "PA-ENCTYPE-INFO" },
+    { KRB5_PA_ENCTYPE_INFO2         , "PA-ENCTYPE-INFO2" },
     { KRB5_PA_SAM_CHALLENGE        , "PA-SAM-CHALLENGE" },
     { KRB5_PA_SAM_RESPONSE         , "PA-SAM-RESPONSE" },
     { KRB5_PA_PK_AS_REQ            , "PA-PK-AS-REQ" },
@@ -1188,6 +1265,7 @@ static const value_string krb5_preauthentication_types[] = {
     { KRB5_TD_REQ_NONCE            , "TD-REQ-NONCE" },
     { KRB5_TD_REQ_SEQ              , "TD-REQ-SEQ" },
     { KRB5_PA_PAC_REQUEST          , "PA-PAC-REQUEST" },
+    { KRB5_PA_S4U2SELF             , "PA-S4U2SELF" },
     { KRB5_PA_PROV_SRV_LOCATION    , "PA-PROV-SRV-LOCATION" },
     { 0                            , NULL },
 };
@@ -1209,6 +1287,8 @@ static const value_string krb5_encryption_types[] = {
     { KRB5_ENCTYPE_RSA_ES_OEAP_ENV, "rsa-es-oeap-env" },
     { KRB5_ENCTYPE_DES_EDE3_CBC_ENV, "des-ede3-cbc-env" },
     { KRB5_ENCTYPE_DES3_CBC_SHA1  , "des3-cbc-sha1" },
+    { KRB5_ENCTYPE_AES128_CTS_HMAC_SHA1_96  , "aes128-cts-hmac-sha1-96" },
+    { KRB5_ENCTYPE_AES256_CTS_HMAC_SHA1_96  , "aes256-cts-hmac-sha1-96" },
     { KRB5_ENCTYPE_DES_CBC_MD5_NT  , "des-cbc-md5-nt" },
     { KERB_ENCTYPE_RC4_HMAC       , "rc4-hmac" },
     { KERB_ENCTYPE_RC4_HMAC_EXP   , "rc4-hmac-exp" },
@@ -1249,6 +1329,7 @@ static const value_string krb5_checksum_types[] = {
     { KRB5_CHKSUM_REAL_CRC32      , "real-crc32" },
     { KRB5_CHKSUM_SHA1            , "sha1" },
     { KRB5_CHKSUM_LM              , "lm" },
+    { KRB5_CHKSUM_GSSAPI         , "gssapi-8003" },
     { 0                           , NULL },
 };
 
@@ -1264,6 +1345,7 @@ static const value_string krb5_checksum_types[] = {
 #define KRB5_AD_SESAME                         65
 #define KRB5_AD_OSF_DCE_PKI_CERTID             66
 #define KRB5_AD_WIN2K_PAC                              128
+#define KRB5_AD_SIGNTICKET                     0xffffffef
 static const value_string krb5_ad_types[] = {
     { KRB5_AD_IF_RELEVANT                      , "AD-IF-RELEVANT" },
     { KRB5_AD_INTENDED_FOR_SERVER              , "AD-Intended-For-Server" },
@@ -1277,6 +1359,7 @@ static const value_string krb5_ad_types[] = {
     { KRB5_AD_SESAME                           , "AD-SESAME" },
     { KRB5_AD_OSF_DCE_PKI_CERTID               , "AD-OSF-DCE-PKI-CertID" },
     { KRB5_AD_WIN2K_PAC                                , "AD-Win2k-PAC" },
+    { KRB5_AD_SIGNTICKET                       , "AD-SignTicket" },
     { 0        , NULL },
 };
 
@@ -1298,6 +1381,7 @@ static const value_string krb5_address_types[] = {
 };
 
 static const value_string krb5_msg_types[] = {
+       { KRB5_MSG_TICKET,              "Ticket" },
        { KRB5_MSG_AUTHENTICATOR,       "Authenticator" },
        { KRB5_MSG_ENC_TICKET_PART,     "EncTicketPart" },
        { KRB5_MSG_TGS_REQ,             "TGS-REQ" },
@@ -1312,6 +1396,8 @@ static const value_string krb5_msg_types[] = {
        { KRB5_MSG_ENC_AS_REP_PART,     "EncASRepPart" },
        { KRB5_MSG_ENC_TGS_REP_PART,    "EncTGSRepPart" },
        { KRB5_MSG_ENC_AP_REP_PART,     "EncAPRepPart" },
+       { KRB5_MSG_ENC_KRB_PRIV_PART,   "EncKrbPrivPart" },
+       { KRB5_MSG_ENC_KRB_CRED_PART,   "EncKrbCredPart" },
        { KRB5_MSG_ERROR,               "KRB-ERROR" },
         { 0, NULL },
 };
@@ -1319,20 +1405,25 @@ static const value_string krb5_msg_types[] = {
 
 
 
-static int dissect_krb5_application_choice(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset);
-static int dissect_krb5_Authenticator(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset);
-static int dissect_krb5_EncTicketPart(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset);
-static int dissect_krb5_EncAPRepPart(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset);
-static int dissect_krb5_EncKDCRepPart(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset);
-static int dissect_krb5_KDC_REQ(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset);
-static int dissect_krb5_KDC_REP(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset);
-static int dissect_krb5_AP_REQ(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset);
-static int dissect_krb5_AP_REP(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset);
-static int dissect_krb5_SAFE(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset);
-static int dissect_krb5_PRIV(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset);
-static int dissect_krb5_ERROR(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset);
+static int dissect_krb5_application_choice(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_);
+static int dissect_krb5_Application_1(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_);
+static int dissect_krb5_Authenticator(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_);
+static int dissect_krb5_EncTicketPart(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_);
+static int dissect_krb5_EncAPRepPart(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_);
+static int dissect_krb5_EncKrbPrivPart(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_);
+static int dissect_krb5_EncKrbCredPart(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_);
+static int dissect_krb5_EncKDCRepPart(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_);
+static int dissect_krb5_KDC_REQ(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_);
+static int dissect_krb5_KDC_REP(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_);
+static int dissect_krb5_AP_REQ(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_);
+static int dissect_krb5_AP_REP(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_);
+static int dissect_krb5_SAFE(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_);
+static int dissect_krb5_PRIV(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_);
+static int dissect_krb5_CRED(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_);
+static int dissect_krb5_ERROR(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_);
 
-static const ber_choice_t kerberos_applications_choice[] = {
+static const ber_old_choice_t kerberos_applications_choice[] = {
+       { KRB5_MSG_TICKET,      BER_CLASS_APP,  KRB5_MSG_TICKET,        0, dissect_krb5_Application_1 },
        { KRB5_MSG_AUTHENTICATOR,       BER_CLASS_APP,  KRB5_MSG_AUTHENTICATOR, 0, dissect_krb5_Authenticator },
        { KRB5_MSG_ENC_TICKET_PART, BER_CLASS_APP,      KRB5_MSG_ENC_TICKET_PART, 0, dissect_krb5_EncTicketPart },
        { KRB5_MSG_AS_REQ,      BER_CLASS_APP,  KRB5_MSG_AS_REQ,        0,      dissect_krb5_KDC_REQ },
@@ -1344,17 +1435,20 @@ static const ber_choice_t kerberos_applications_choice[] = {
        { KRB5_MSG_ENC_AS_REP_PART, BER_CLASS_APP, KRB5_MSG_ENC_AS_REP_PART, 0, dissect_krb5_EncKDCRepPart },
        { KRB5_MSG_ENC_TGS_REP_PART, BER_CLASS_APP, KRB5_MSG_ENC_TGS_REP_PART, 0, dissect_krb5_EncKDCRepPart },
        { KRB5_MSG_ENC_AP_REP_PART, BER_CLASS_APP, KRB5_MSG_ENC_AP_REP_PART, 0, dissect_krb5_EncAPRepPart },
+       { KRB5_MSG_ENC_KRB_PRIV_PART, BER_CLASS_APP, KRB5_MSG_ENC_KRB_PRIV_PART, 0, dissect_krb5_EncKrbPrivPart },
+       { KRB5_MSG_ENC_KRB_CRED_PART, BER_CLASS_APP, KRB5_MSG_ENC_KRB_CRED_PART, 0, dissect_krb5_EncKrbCredPart },
        { KRB5_MSG_SAFE,        BER_CLASS_APP,  KRB5_MSG_SAFE,          0,      dissect_krb5_SAFE },
        { KRB5_MSG_PRIV,        BER_CLASS_APP,  KRB5_MSG_PRIV,          0,      dissect_krb5_PRIV },
+       { KRB5_MSG_CRED,        BER_CLASS_APP,  KRB5_MSG_CRED,          0,      dissect_krb5_CRED },
        { KRB5_MSG_ERROR,       BER_CLASS_APP,  KRB5_MSG_ERROR,         0,      dissect_krb5_ERROR },
        { 0, 0, 0, 0, NULL }
 };
 
 
 static int
-dissect_krb5_application_choice(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_application_choice(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_choice(pinfo, tree, tvb, offset, kerberos_applications_choice, -1, -1);
+       offset=dissect_ber_old_choice(actx, tree, tvb, offset, kerberos_applications_choice, -1, -1, NULL);
        return offset;
 }
 
@@ -1374,9 +1468,9 @@ static int *APOptions_bits[] = {
   NULL
 };
 static int
-dissect_krb5_APOptions(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_APOptions(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_bitstring32(FALSE, pinfo, tree, tvb, offset, APOptions_bits, hf_krb_APOptions, ett_krb_AP_Options, NULL);
+       offset=dissect_ber_bitstring32(FALSE, actx, tree, tvb, offset, APOptions_bits, hf_krb_APOptions, ett_krb_AP_Options, NULL);
        return offset;
 }
 
@@ -1410,6 +1504,10 @@ static const true_false_string krb5_kdcoptions_renewable = {
        "This ticket is RENEWABLE",
        "This ticket is NOT renewable"
 };
+static const true_false_string krb5_kdcoptions_constrained_delegation = {
+       "This is a request for a CONSTRAINED DELEGATION PAC",
+       "This is a normal request (no constrained delegation)"
+};
 static const true_false_string krb5_kdcoptions_canonicalize = {
        "This is a request for a CANONICALIZED ticket",
        "This is NOT a canonicalized ticket request"
@@ -1444,6 +1542,7 @@ static int* KDCOptions_bits[] = {
   &hf_krb_KDCOptions_postdated,
   &hf_krb_KDCOptions_renewable,
   &hf_krb_KDCOptions_opt_hardware_auth,
+  &hf_krb_KDCOptions_constrained_delegation,
   &hf_krb_KDCOptions_canonicalize,
   &hf_krb_KDCOptions_disable_transited_check,
   &hf_krb_KDCOptions_renewable_ok,
@@ -1454,52 +1553,52 @@ static int* KDCOptions_bits[] = {
 };
 
 static int
-dissect_krb5_KDCOptions(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_KDCOptions(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_bitstring32(FALSE, pinfo, tree, tvb, offset, KDCOptions_bits, hf_krb_KDCOptions, ett_krb_KDC_Options, NULL);
+       offset=dissect_ber_bitstring32(FALSE, actx, tree, tvb, offset, KDCOptions_bits, hf_krb_KDCOptions, ett_krb_KDC_Options, NULL);
        return offset;
 }
 
 static int
-dissect_krb5_rtime(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_rtime(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_GeneralizedTime(FALSE, pinfo, tree, tvb, offset, hf_krb_rtime);
+       offset=dissect_ber_GeneralizedTime(FALSE, actx, tree, tvb, offset, hf_krb_rtime);
        return offset;
 }
 
 int
-dissect_krb5_ctime(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_ctime(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_GeneralizedTime(FALSE, pinfo, tree, tvb, offset, hf_krb_ctime);
+       offset=dissect_ber_GeneralizedTime(FALSE, actx, tree, tvb, offset, hf_krb_ctime);
        return offset;
 }
 static int
-dissect_krb5_cusec(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_cusec(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_integer(FALSE, pinfo, tree, tvb, offset, hf_krb_cusec, NULL);
+       offset=dissect_ber_integer(FALSE, actx, tree, tvb, offset, hf_krb_cusec, NULL);
        return offset;
 }
 
 static int
-dissect_krb5_stime(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_stime(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_GeneralizedTime(FALSE, pinfo, tree, tvb, offset, hf_krb_stime);
+       offset=dissect_ber_GeneralizedTime(FALSE, actx, tree, tvb, offset, hf_krb_stime);
        return offset;
 }
 static int
-dissect_krb5_susec(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_susec(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_integer(FALSE, pinfo, tree, tvb, offset, hf_krb_susec, NULL);
+       offset=dissect_ber_integer(FALSE, actx, tree, tvb, offset, hf_krb_susec, NULL);
        return offset;
 }
 
 
 static int
-dissect_krb5_error_code(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_error_code(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_integer(FALSE, pinfo, tree, tvb, offset, hf_krb_error_code, &krb5_errorcode);
-       if(krb5_errorcode && check_col(pinfo->cinfo, COL_INFO)) {
-               col_add_fstr(pinfo->cinfo, COL_INFO,
+       offset=dissect_ber_integer(FALSE, actx, tree, tvb, offset, hf_krb_error_code, &krb5_errorcode);
+       if(krb5_errorcode && check_col(actx->pinfo->cinfo, COL_INFO)) {
+               col_add_fstr(actx->pinfo->cinfo, COL_INFO,
                        "KRB Error: %s",
                        val_to_str(krb5_errorcode, krb5_error_codes,
                        "Unknown error code %#x"));
@@ -1510,24 +1609,24 @@ dissect_krb5_error_code(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int
 
 
 static int
-dissect_krb5_till(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_till(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_GeneralizedTime(FALSE, pinfo, tree, tvb, offset, hf_krb_till);
+       offset=dissect_ber_GeneralizedTime(FALSE, actx, tree, tvb, offset, hf_krb_till);
        return offset;
 }
 static int
-dissect_krb5_from(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_from(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_GeneralizedTime(FALSE, pinfo, tree, tvb, offset, hf_krb_from);
+       offset=dissect_ber_GeneralizedTime(FALSE, actx, tree, tvb, offset, hf_krb_from);
        return offset;
 }
 
 
 
 static int
-dissect_krb5_nonce(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_nonce(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_integer(FALSE, pinfo, tree, tvb, offset, hf_krb_nonce, NULL);
+       offset=dissect_ber_integer(FALSE, actx, tree, tvb, offset, hf_krb_nonce, NULL);
        return offset;
 }
 
@@ -1536,11 +1635,11 @@ dissect_krb5_nonce(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offs
  *          etype[8]             SEQUENCE OF INTEGER, -- EncryptionType,
  */
 static int
-dissect_krb5_etype(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_etype(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
        guint32 etype;
 
-       offset=dissect_ber_integer(FALSE, pinfo, tree, tvb, offset, hf_krb_etype, &etype);
+       offset=dissect_ber_integer(FALSE, actx, tree, tvb, offset, hf_krb_etype, &etype);
        if(tree){
                proto_item_append_text(tree, " %s",
                        val_to_str(etype, krb5_encryption_types,
@@ -1548,21 +1647,21 @@ dissect_krb5_etype(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offs
        }
        return offset;
 }
-static ber_sequence_t etype_sequence_of[1] = {
+static ber_old_sequence_t etype_sequence_of[1] = {
   { BER_CLASS_UNI, BER_UNI_TAG_INTEGER, BER_FLAGS_NOOWNTAG, dissect_krb5_etype },
 };
 static int
-dissect_krb5_etype_sequence_of(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_etype_sequence_of(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_sequence_of(FALSE, pinfo, tree, tvb, offset, etype_sequence_of, hf_krb_etypes, ett_krb_etypes);
+       offset=dissect_ber_old_sequence_of(FALSE, actx, tree, tvb, offset, etype_sequence_of, hf_krb_etypes, ett_krb_etypes);
 
        return offset;
 }
 static guint32 authenticator_etype;
 static int
-dissect_krb5_authenticator_etype(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_authenticator_etype(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_integer(FALSE, pinfo, tree, tvb, offset, hf_krb_etype, &authenticator_etype);
+       offset=dissect_ber_integer(FALSE, actx, tree, tvb, offset, hf_krb_etype, &authenticator_etype);
        if(tree){
                proto_item_append_text(tree, " %s",
                        val_to_str(authenticator_etype, krb5_encryption_types,
@@ -1572,9 +1671,9 @@ dissect_krb5_authenticator_etype(packet_info *pinfo, proto_tree *tree, tvbuff_t
 }
 static guint32 Ticket_etype;
 static int
-dissect_krb5_Ticket_etype(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_Ticket_etype(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_integer(FALSE, pinfo, tree, tvb, offset, hf_krb_etype, &Ticket_etype);
+       offset=dissect_ber_integer(FALSE, actx, tree, tvb, offset, hf_krb_etype, &Ticket_etype);
        if(tree){
                proto_item_append_text(tree, " %s",
                        val_to_str(Ticket_etype, krb5_encryption_types,
@@ -1584,9 +1683,9 @@ dissect_krb5_Ticket_etype(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, i
 }
 static guint32 AP_REP_etype;
 static int
-dissect_krb5_AP_REP_etype(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_AP_REP_etype(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_integer(FALSE, pinfo, tree, tvb, offset, hf_krb_etype, &AP_REP_etype);
+       offset=dissect_ber_integer(FALSE, actx, tree, tvb, offset, hf_krb_etype, &AP_REP_etype);
        if(tree){
                proto_item_append_text(tree, " %s",
                        val_to_str(AP_REP_etype, krb5_encryption_types,
@@ -1596,9 +1695,9 @@ dissect_krb5_AP_REP_etype(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, i
 }
 static guint32 PA_ENC_TIMESTAMP_etype;
 static int
-dissect_krb5_PA_ENC_TIMESTAMP_etype(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_PA_ENC_TIMESTAMP_etype(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_integer(FALSE, pinfo, tree, tvb, offset, hf_krb_etype, &PA_ENC_TIMESTAMP_etype);
+       offset=dissect_ber_integer(FALSE, actx, tree, tvb, offset, hf_krb_etype, &PA_ENC_TIMESTAMP_etype);
        if(tree){
                proto_item_append_text(tree, " %s",
                        val_to_str(PA_ENC_TIMESTAMP_etype, krb5_encryption_types,
@@ -1615,42 +1714,47 @@ dissect_krb5_PA_ENC_TIMESTAMP_etype(packet_info *pinfo, proto_tree *tree, tvbuff
  *  }
  */
 static guint32 addr_type;
-static int dissect_krb5_addr_type(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+static int dissect_krb5_addr_type(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_integer(FALSE, pinfo, tree, tvb, offset, hf_krb_addr_type, &addr_type);
+       offset=dissect_ber_integer(FALSE, actx, tree, tvb, offset, hf_krb_addr_type, &addr_type);
        return offset;
 }
-static int dissect_krb5_address(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+static int dissect_krb5_address(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       guint8 class;
+       gint8 class;
        gboolean pc;
-       guint32 tag;
+       gint32 tag;
        guint32 len;
-       char address_str[256];
+       char *address_str;
        proto_item *it=NULL;
 
        /* read header and len for the octet string */
-       offset=dissect_ber_identifier(pinfo, tree, tvb, offset, &class, &pc, &tag);
-       offset=dissect_ber_length(pinfo, tree, tvb, offset, &len, NULL);
-
+       offset=dissect_ber_identifier(actx->pinfo, tree, tvb, offset, &class, &pc, &tag);
+       offset=dissect_ber_length(actx->pinfo, tree, tvb, offset, &len, NULL);
 
+       address_str=ep_alloc(256);
        address_str[0]=0;
        address_str[255]=0;
        switch(addr_type){
        case KRB5_ADDR_IPv4:
                it=proto_tree_add_item(tree, hf_krb_address_ip, tvb, offset, 4, FALSE);
-               sprintf(address_str,"%d.%d.%d.%d",tvb_get_guint8(tvb, offset),tvb_get_guint8(tvb, offset+1),tvb_get_guint8(tvb, offset+2),tvb_get_guint8(tvb, offset+3));
+               g_snprintf(address_str,256,"%d.%d.%d.%d",tvb_get_guint8(tvb, offset),tvb_get_guint8(tvb, offset+1),tvb_get_guint8(tvb, offset+2),tvb_get_guint8(tvb, offset+3));
                break;
        case KRB5_ADDR_NETBIOS:
                {
                char netbios_name[(NETBIOS_NAME_LEN - 1)*4 + 1];
                int netbios_name_type;
+               int netbios_name_len = (NETBIOS_NAME_LEN - 1)*4 + 1;
 
-               netbios_name_type = process_netbios_name(tvb_get_ptr(tvb, offset, 16), netbios_name);
-               snprintf(address_str, 255, "%s<%02x>", netbios_name, netbios_name_type);
+               netbios_name_type = process_netbios_name(tvb_get_ptr(tvb, offset, 16), netbios_name, netbios_name_len);
+               g_snprintf(address_str, 255, "%s<%02x>", netbios_name, netbios_name_type);
                it=proto_tree_add_string_format(tree, hf_krb_address_netbios, tvb, offset, 16, netbios_name, "NetBIOS Name: %s (%s)", address_str, netbios_name_type_descr(netbios_name_type));
                }
                break;
+       case KRB5_ADDR_IPv6:
+               it=proto_tree_add_item(tree, hf_krb_address_ipv6, tvb, offset, INET6_ADDRLEN, FALSE);
+               g_snprintf(address_str, 256, "%s", ip6_to_str((const struct e_in6_addr *)tvb_get_ptr(tvb, offset, INET6_ADDRLEN)));
+               break;
        default:
                proto_tree_add_text(tree, tvb, offset, len, "KRB Address: I dont know how to parse this type of address yet");
 
@@ -1665,24 +1769,33 @@ static int dissect_krb5_address(packet_info *pinfo, proto_tree *tree, tvbuff_t *
        offset+=len;
        return offset;
 }
-static ber_sequence_t HostAddress_sequence[] = {
+static ber_old_sequence_t HostAddress_sequence[] = {
        { BER_CLASS_CON, 0, 0, dissect_krb5_addr_type },
        { BER_CLASS_CON, 1, 0, dissect_krb5_address },
        { 0, 0, 0, NULL }
 };
 static int
-dissect_krb5_HostAddress(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_HostAddress(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
+{
+
+       offset=dissect_ber_old_sequence(FALSE, actx, tree, tvb, offset, HostAddress_sequence, hf_krb_HostAddress, ett_krb_HostAddress);
+
+       return offset;
+}
+static int
+dissect_krb5_s_address(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
 
-       offset=dissect_ber_sequence(FALSE, pinfo, tree, tvb, offset, HostAddress_sequence, hf_krb_HostAddress, ett_krb_HostAddress);
+       offset=dissect_ber_old_sequence(FALSE, actx, tree, tvb, offset, HostAddress_sequence, hf_krb_s_address, ett_krb_s_address);
 
        return offset;
 }
+
 static int
-dissect_krb5_s_address(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_r_address(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
 
-       offset=dissect_ber_sequence(FALSE, pinfo, tree, tvb, offset, HostAddress_sequence, hf_krb_s_address, ett_krb_s_address);
+       offset=dissect_ber_old_sequence(FALSE, actx, tree, tvb, offset, HostAddress_sequence, hf_krb_r_address, ett_krb_r_address);
 
        return offset;
 }
@@ -1694,28 +1807,39 @@ dissect_krb5_s_address(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int
  *  }
  *
  */
-static ber_sequence_t HostAddresses_sequence_of[1] = {
+static ber_old_sequence_t HostAddresses_sequence_of[1] = {
   { BER_CLASS_UNI, BER_UNI_TAG_SEQUENCE, BER_FLAGS_NOOWNTAG, dissect_krb5_HostAddress },
 };
 static int
-dissect_krb5_HostAddresses(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_HostAddresses(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_sequence_of(FALSE, pinfo, tree, tvb, offset, HostAddresses_sequence_of, hf_krb_HostAddresses, ett_krb_HostAddresses);
+       offset=dissect_ber_old_sequence_of(FALSE, actx, tree, tvb, offset, HostAddresses_sequence_of, hf_krb_HostAddresses, ett_krb_HostAddresses);
 
        return offset;
 }
 
 
+/* sequence of tickets */
+static ber_old_sequence_t sequence_of_tickets[1] = {
+  { BER_CLASS_APP, 1, 0, dissect_krb5_Application_1},
+};
+static int
+dissect_krb5_sq_tickets(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
+{
+       offset=dissect_ber_old_sequence_of(FALSE, actx, tree, tvb, offset, sequence_of_tickets, hf_krb_sq_tickets, ett_krb_sq_tickets);
+
+       return offset;
+}
 
 static int
-dissect_krb5_msg_type(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_msg_type(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
        guint32 msgtype;
 
-       offset=dissect_ber_integer(FALSE, pinfo, tree, tvb, offset, hf_krb_msg_type, &msgtype);
+       offset=dissect_ber_integer(FALSE, actx, tree, tvb, offset, hf_krb_msg_type, &msgtype);
 
-       if (do_col_info & check_col(pinfo->cinfo, COL_INFO)) {
-               col_add_str(pinfo->cinfo, COL_INFO,
+       if (do_col_info & check_col(actx->pinfo->cinfo, COL_INFO)) {
+               col_add_str(actx->pinfo->cinfo, COL_INFO,
                        val_to_str(msgtype, krb5_msg_types,
                        "Unknown msg type %#x"));
        }
@@ -1730,9 +1854,9 @@ dissect_krb5_msg_type(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int o
 
 
 static int
-dissect_krb5_pvno(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_pvno(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_integer(FALSE, pinfo, tree, tvb, offset, hf_krb_pvno, NULL);
+       offset=dissect_ber_integer(FALSE, actx, tree, tvb, offset, hf_krb_pvno, NULL);
 
        return offset;
 }
@@ -1746,10 +1870,10 @@ dissect_krb5_pvno(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offse
  */
 guint32 name_type;
 static int
-dissect_krb5_name_type(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_name_type(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
 
-       offset=dissect_ber_integer(FALSE, pinfo, tree, tvb, offset, hf_krb_name_type, &name_type);
+       offset=dissect_ber_integer(FALSE, actx, tree, tvb, offset, hf_krb_name_type, &name_type);
        if(tree){
                proto_item_append_text(tree, " (%s):",
                        val_to_str(name_type, krb5_princ_types,
@@ -1759,11 +1883,11 @@ dissect_krb5_name_type(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int
 }
 static char name_string_separator;
 static int
-dissect_krb5_name_string(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_name_string(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
        char name_string[256];
 
-       offset=dissect_ber_GeneralString(pinfo, tree, tvb, offset, hf_krb_name_string, name_string, 255);
+       offset=dissect_ber_GeneralString(actx, tree, tvb, offset, hf_krb_name_string, name_string, 255);
        if(tree){
                proto_item_append_text(tree, "%c%s", name_string_separator, name_string);
                name_string_separator='/';
@@ -1771,84 +1895,126 @@ dissect_krb5_name_string(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, in
 
        return offset;
 }
-static ber_sequence_t name_stringe_sequence_of[1] = {
+static ber_old_sequence_t name_stringe_sequence_of[1] = {
   { BER_CLASS_UNI, BER_UNI_TAG_GeneralString, BER_FLAGS_NOOWNTAG, dissect_krb5_name_string },
 };
 static int
-dissect_krb5_name_strings(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_name_strings(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
        name_string_separator=' ';
-       offset=dissect_ber_sequence_of(FALSE, pinfo, tree, tvb, offset, name_stringe_sequence_of, -1, -1);
+       offset=dissect_ber_old_sequence_of(FALSE, actx, tree, tvb, offset, name_stringe_sequence_of, -1, -1);
 
        return offset;
 }
-static ber_sequence_t PrincipalName_sequence[] = {
+static ber_old_sequence_t PrincipalName_sequence[] = {
        { BER_CLASS_CON, 0, 0, dissect_krb5_name_type },
        { BER_CLASS_CON, 1, 0, dissect_krb5_name_strings },
        { 0, 0, 0, NULL }
 };
 static int
-dissect_krb5_sname(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_sname(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
 
-       offset=dissect_ber_sequence(FALSE, pinfo, tree, tvb, offset, PrincipalName_sequence, hf_krb_sname, ett_krb_sname);
+       offset=dissect_ber_old_sequence(FALSE, actx, tree, tvb, offset, PrincipalName_sequence, hf_krb_sname, ett_krb_sname);
 
        return offset;
 }
 static int
-dissect_krb5_cname(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_pname(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
+{
+
+       offset=dissect_ber_old_sequence(FALSE, actx, tree, tvb, offset, PrincipalName_sequence, hf_krb_pname, ett_krb_pname);
+
+       return offset;
+}
+int
+dissect_krb5_cname(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
 
-       offset=dissect_ber_sequence(FALSE, pinfo, tree, tvb, offset, PrincipalName_sequence, hf_krb_cname, ett_krb_cname);
+       offset=dissect_ber_old_sequence(FALSE, actx, tree, tvb, offset, PrincipalName_sequence, hf_krb_cname, ett_krb_cname);
 
        return offset;
 }
 
 
-static int
-dissect_krb5_realm(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+int
+dissect_krb5_prealm(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
+{
+       offset=dissect_ber_GeneralString(actx, tree, tvb, offset, hf_krb_prealm, NULL, 0);
+       return offset;
+}
+
+int
+dissect_krb5_srealm(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
+{
+       offset=dissect_ber_GeneralString(actx, tree, tvb, offset, hf_krb_srealm, NULL, 0);
+       return offset;
+}
+
+int
+dissect_krb5_realm(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_GeneralString(pinfo, tree, tvb, offset, hf_krb_realm, NULL, 0);
+       offset=dissect_ber_GeneralString(actx, tree, tvb, offset, hf_krb_realm, NULL, 0);
        return offset;
 }
 
 static int
-dissect_krb5_crealm(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_crealm(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_GeneralString(pinfo, tree, tvb, offset, hf_krb_crealm, NULL, 0);
+       offset=dissect_ber_GeneralString(actx, tree, tvb, offset, hf_krb_crealm, NULL, 0);
        return offset;
 }
 
 
 
 static int
-dissect_krb5_PA_PAC_REQUEST_flag(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_PA_PAC_REQUEST_flag(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_boolean(pinfo, tree, tvb, offset, hf_krb_PA_PAC_REQUEST_flag);
+       offset=dissect_ber_boolean(FALSE, actx, tree, tvb, offset, hf_krb_PA_PAC_REQUEST_flag, NULL);
        return offset;
 }
 
 
-static ber_sequence_t PA_PAC_REQUEST_sequence[] = {
+static ber_old_sequence_t PA_PAC_REQUEST_sequence[] = {
        { BER_CLASS_CON, 0, 0, dissect_krb5_PA_PAC_REQUEST_flag },
        { 0, 0, 0, NULL }
 };
 static int
-dissect_krb5_PA_PAC_REQUEST(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_PA_PAC_REQUEST(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
 
-       offset=dissect_ber_sequence(FALSE, pinfo, tree, tvb, offset, PA_PAC_REQUEST_sequence, -1, -1);
+       offset=dissect_ber_old_sequence(FALSE, actx, tree, tvb, offset, PA_PAC_REQUEST_sequence, -1, -1);
 
        return offset;
 }
 
+static int
+dissect_krb5_s4u2self_auth(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
+{
+       offset=dissect_ber_GeneralString(actx, tree, tvb, offset, hf_krb_s4u2self_auth, NULL, 0);
+       return offset;
+}
 
+static ber_old_sequence_t PA_S4U2SELF_sequence[] = {
+       { BER_CLASS_CON, 0, 0, dissect_krb5_cname },
+       { BER_CLASS_CON, 1, 0, dissect_krb5_realm },
+       { BER_CLASS_CON, 2, 0, dissect_krb5_Checksum },
+       { BER_CLASS_CON, 3, 0, dissect_krb5_s4u2self_auth },
+       { 0, 0, 0, NULL }
+};
+
+static int
+dissect_krb5_PA_S4U2SELF(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
+{
+       offset=dissect_ber_old_sequence(FALSE, actx, tree, tvb, offset, PA_S4U2SELF_sequence, -1, -1);
+       return offset;
+}
 
 
 static int
-dissect_krb5_PA_PROV_SRV_LOCATION(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_PA_PROV_SRV_LOCATION(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_GeneralString(pinfo, tree, tvb, offset, hf_krb_provsrv_location, NULL, 0);
+       offset=dissect_ber_GeneralString(actx, tree, tvb, offset, hf_krb_provsrv_location, NULL, 0);
 
        return offset;
 }
@@ -1856,9 +2022,9 @@ dissect_krb5_PA_PROV_SRV_LOCATION(packet_info *pinfo, proto_tree *tree, tvbuff_t
 
 
 static int
-dissect_krb5_kvno(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_kvno(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_integer(FALSE, pinfo, tree, tvb, offset, hf_krb_kvno, NULL);
+       offset=dissect_ber_integer(FALSE, actx, tree, tvb, offset, hf_krb_kvno, NULL);
 
        return offset;
 }
@@ -1866,35 +2032,35 @@ dissect_krb5_kvno(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offse
 
 
 static int
-dissect_krb5_seq_number(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_seq_number(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_integer(FALSE, pinfo, tree, tvb, offset, hf_krb_seq_number, NULL);
+       offset=dissect_ber_integer(FALSE, actx, tree, tvb, offset, hf_krb_seq_number, NULL);
 
        return offset;
 }
 
 
 
-#ifdef HAVE_KERBEROS
 static int
-dissect_krb5_pausec(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_patimestamp(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_integer(FALSE, pinfo, tree, tvb, offset, hf_krb_pausec, NULL);
+       offset=dissect_ber_GeneralizedTime(FALSE, actx, tree, tvb, offset, hf_krb_patimestamp);
        return offset;
 }
+#ifdef HAVE_KERBEROS
 static int
-dissect_krb5_patimestamp(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_pausec(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_GeneralizedTime(FALSE, pinfo, tree, tvb, offset, hf_krb_patimestamp);
+       offset=dissect_ber_integer(FALSE, actx, tree, tvb, offset, hf_krb_pausec, NULL);
        return offset;
 }
-static const ber_sequence_t PA_ENC_TS_ENC_sequence[] = {
+static const ber_old_sequence_t PA_ENC_TS_ENC_sequence[] = {
        { BER_CLASS_CON, 0, 0, dissect_krb5_patimestamp },
        { BER_CLASS_CON, 1, BER_FLAGS_OPTIONAL, dissect_krb5_pausec },
        { 0, 0, 0, NULL }
 };
 static int
-dissect_krb5_decrypt_PA_ENC_TIMESTAMP (packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_decrypt_PA_ENC_TIMESTAMP (proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
        guint8 *plaintext=NULL;
        int length;
@@ -1907,7 +2073,7 @@ dissect_krb5_decrypt_PA_ENC_TIMESTAMP (packet_info *pinfo, proto_tree *tree, tvb
         * == 1
         */
        if(!plaintext){
-               plaintext=decrypt_krb5_data(tree, pinfo, 1, length, tvb_get_ptr(tvb, offset, length), PA_ENC_TIMESTAMP_etype);
+               plaintext=decrypt_krb5_data(tree, actx->pinfo, 1, length, tvb_get_ptr(tvb, offset, length), PA_ENC_TIMESTAMP_etype);
        }
 
        if(plaintext){
@@ -1915,13 +2081,14 @@ dissect_krb5_decrypt_PA_ENC_TIMESTAMP (packet_info *pinfo, proto_tree *tree, tvb
                next_tvb = tvb_new_real_data (plaintext,
                                           length,
                                           length);
+               tvb_set_free_cb(next_tvb, g_free);
                tvb_set_child_real_data_tvbuff(tvb, next_tvb);
 
                /* Add the decrypted data to the data source list. */
-               add_new_data_source(pinfo, next_tvb, "Decrypted Krb5");
+               add_new_data_source(actx->pinfo, next_tvb, "Decrypted Krb5");
 
 
-               offset=dissect_ber_sequence(FALSE, pinfo, tree, next_tvb, 0, PA_ENC_TS_ENC_sequence, -1, -1);
+               offset=dissect_ber_old_sequence(FALSE, actx, tree, next_tvb, 0, PA_ENC_TS_ENC_sequence, -1, -1);
 
        }
        return offset;
@@ -1930,16 +2097,16 @@ dissect_krb5_decrypt_PA_ENC_TIMESTAMP (packet_info *pinfo, proto_tree *tree, tvb
 
 
 static int
-dissect_krb5_encrypted_PA_ENC_TIMESTAMP(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_encrypted_PA_ENC_TIMESTAMP(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
 #ifdef HAVE_KERBEROS
-       offset=dissect_ber_octet_string_wcb(FALSE, pinfo, tree, tvb, offset, hf_krb_encrypted_PA_ENC_TIMESTAMP, dissect_krb5_decrypt_PA_ENC_TIMESTAMP);
+       offset=dissect_ber_old_octet_string_wcb(FALSE, actx, tree, tvb, offset, hf_krb_encrypted_PA_ENC_TIMESTAMP, dissect_krb5_decrypt_PA_ENC_TIMESTAMP);
 #else
-       offset=dissect_ber_octet_string_wcb(FALSE, pinfo, tree, tvb, offset, hf_krb_encrypted_PA_ENC_TIMESTAMP, NULL);
+       offset=dissect_ber_old_octet_string_wcb(FALSE, actx, tree, tvb, offset, hf_krb_encrypted_PA_ENC_TIMESTAMP, NULL);
 #endif
        return offset;
 }
-static ber_sequence_t PA_ENC_TIMESTAMP_sequence[] = {
+static ber_old_sequence_t PA_ENC_TIMESTAMP_sequence[] = {
        { BER_CLASS_CON, 0, 0,
                dissect_krb5_PA_ENC_TIMESTAMP_etype },
        { BER_CLASS_CON, 1, BER_FLAGS_OPTIONAL,
@@ -1949,9 +2116,9 @@ static ber_sequence_t PA_ENC_TIMESTAMP_sequence[] = {
        { 0, 0, 0, NULL }
 };
 static int
-dissect_krb5_PA_ENC_TIMESTAMP(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_PA_ENC_TIMESTAMP(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_sequence(FALSE, pinfo, tree, tvb, offset, PA_ENC_TIMESTAMP_sequence, -1, -1);
+       offset=dissect_ber_old_sequence(FALSE, actx, tree, tvb, offset, PA_ENC_TIMESTAMP_sequence, -1, -1);
 
        return offset;
 }
@@ -1959,13 +2126,27 @@ dissect_krb5_PA_ENC_TIMESTAMP(packet_info *pinfo, proto_tree *tree, tvbuff_t *tv
 
 
 static int
-dissect_krb5_etype_info_salt(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_etype_info_salt(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
+{
+       offset=dissect_ber_octet_string(FALSE, actx, tree, tvb, offset, hf_krb_etype_info_salt, NULL);
+       return offset;
+}
+
+static int
+dissect_krb5_etype_info2_salt(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
+{
+       offset=dissect_ber_GeneralString(actx, tree, tvb, offset, hf_krb_etype_info2_salt, NULL, 0);
+       return offset;
+}
+
+static int
+dissect_krb5_etype_info2_s2kparams(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_octet_string(FALSE, pinfo, tree, tvb, offset, hf_krb_etype_info_salt, NULL);
+       offset=dissect_ber_octet_string(FALSE, actx, tree, tvb, offset, hf_krb_etype_info2_s2kparams, NULL);
        return offset;
 }
 
-static ber_sequence_t PA_ENCTYPE_INFO_ENTRY_sequence[] = {
+static ber_old_sequence_t PA_ENCTYPE_INFO_ENTRY_sequence[] = {
        { BER_CLASS_CON, 0, 0,
                dissect_krb5_etype },
        { BER_CLASS_CON, 1, BER_FLAGS_OPTIONAL,
@@ -1973,20 +2154,84 @@ static ber_sequence_t PA_ENCTYPE_INFO_ENTRY_sequence[] = {
        { 0, 0, 0, NULL }
 };
 static int
-dissect_krb5_PA_ENCTYPE_INFO_ENTRY(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_PA_ENCTYPE_INFO_ENTRY(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_sequence(FALSE, pinfo, tree, tvb, offset, PA_ENCTYPE_INFO_ENTRY_sequence, -1, -1);
+       offset=dissect_ber_old_sequence(FALSE, actx, tree, tvb, offset, PA_ENCTYPE_INFO_ENTRY_sequence, -1, -1);
 
        return offset;
 }
 
-static ber_sequence_t PA_ENCTYPE_INFO_sequence_of[1] = {
+static ber_old_sequence_t PA_ENCTYPE_INFO_sequence_of[1] = {
   { BER_CLASS_UNI, BER_UNI_TAG_SEQUENCE, BER_FLAGS_NOOWNTAG, dissect_krb5_PA_ENCTYPE_INFO_ENTRY },
 };
 static int
-dissect_krb5_PA_ENCTYPE_INFO(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_PA_ENCTYPE_INFO(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
+{
+       offset=dissect_ber_old_sequence_of(FALSE, actx, tree, tvb, offset, PA_ENCTYPE_INFO_sequence_of, -1, -1);
+
+       return offset;
+}
+
+static ber_old_sequence_t PA_ENCTYPE_INFO2_ENTRY_sequence[] = {
+       { BER_CLASS_CON, 0, 0,
+               dissect_krb5_etype },
+       { BER_CLASS_CON, 1, BER_FLAGS_OPTIONAL,
+               dissect_krb5_etype_info2_salt },
+       { BER_CLASS_CON, 2, BER_FLAGS_OPTIONAL,
+               dissect_krb5_etype_info2_s2kparams },
+       { 0, 0, 0, NULL }
+};
+static int
+dissect_krb5_PA_ENCTYPE_INFO2_ENTRY(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
+{
+       offset=dissect_ber_old_sequence(FALSE, actx, tree, tvb, offset, PA_ENCTYPE_INFO2_ENTRY_sequence, -1, -1);
+
+       return offset;
+}
+
+static ber_old_sequence_t PA_ENCTYPE_INFO2_sequence_of[1] = {
+  { BER_CLASS_UNI, BER_UNI_TAG_SEQUENCE, BER_FLAGS_NOOWNTAG, dissect_krb5_PA_ENCTYPE_INFO2_ENTRY },
+};
+static int
+dissect_krb5_PA_ENCTYPE_INFO2(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
+{
+       offset=dissect_ber_old_sequence_of(FALSE, actx, tree, tvb, offset, PA_ENCTYPE_INFO2_sequence_of, -1, -1);
+
+       return offset;
+}
+
+
+static int
+dissect_krb5_PW_SALT(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_sequence_of(FALSE, pinfo, tree, tvb, offset, PA_ENCTYPE_INFO_sequence_of, -1, -1);
+       guint32 nt_status;
+
+       /* Microsoft stores a special 12 byte blob here
+        * guint32 NT_status
+        * guint32 unknown
+        * guint32 unknown
+        * decode everything as this blob for now until we see if anyone
+        * else ever uses it   or we learn how to tell wether this
+        * is such an MS blob or not.
+        */
+       proto_tree_add_item(tree, hf_krb_smb_nt_status, tvb, offset, 4,
+                       TRUE);
+       nt_status=tvb_get_letohl(tvb, offset);
+       if(nt_status && check_col(actx->pinfo->cinfo, COL_INFO)) {
+               col_append_fstr(actx->pinfo->cinfo, COL_INFO,
+                       " NT Status: %s",
+                       val_to_str(nt_status, NT_errors,
+                       "Unknown error code %#x"));
+       }
+       offset += 4;
+
+       proto_tree_add_item(tree, hf_krb_smb_unknown, tvb, offset, 4,
+                       TRUE);
+       offset += 4;
+
+       proto_tree_add_item(tree, hf_krb_smb_unknown, tvb, offset, 4,
+                       TRUE);
+       offset += 4;
 
        return offset;
 }
@@ -2000,9 +2245,9 @@ dissect_krb5_PA_ENCTYPE_INFO(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb
  */
 guint32 krb_PA_DATA_type;
 static int
-dissect_krb5_PA_DATA_type(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_PA_DATA_type(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_integer(FALSE, pinfo, tree, tvb, offset, hf_krb_PA_DATA_type, &krb_PA_DATA_type);
+       offset=dissect_ber_integer(FALSE, actx, tree, tvb, offset, hf_krb_PA_DATA_type, &krb_PA_DATA_type);
        krb_PA_DATA_type&=0xff; /*this is really just one single byte */
 
        if(tree){
@@ -2013,53 +2258,62 @@ dissect_krb5_PA_DATA_type(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, i
        return offset;
 }
 static int
-dissect_krb5_PA_DATA_value(packet_info *pinfo, proto_tree *parent_tree, tvbuff_t *tvb, int offset)
+dissect_krb5_PA_DATA_value(proto_tree *parent_tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
        proto_tree *tree=parent_tree;
 
-       if(ber_last_created_item){
-               tree=proto_item_add_subtree(ber_last_created_item, ett_krb_PA_DATA_tree);
+       if(actx->created_item){
+               tree=proto_item_add_subtree(actx->created_item, ett_krb_PA_DATA_tree);
        }
 
 
        switch(krb_PA_DATA_type){
        case KRB5_PA_TGS_REQ:
-               offset=dissect_ber_octet_string_wcb(FALSE, pinfo, tree, tvb, offset,hf_krb_PA_DATA_value, dissect_krb5_application_choice);
+               offset=dissect_ber_old_octet_string_wcb(FALSE, actx, tree, tvb, offset,hf_krb_PA_DATA_value, dissect_krb5_application_choice);
                break;
        case KRB5_PA_PK_AS_REQ:
-               offset=dissect_ber_octet_string_wcb(FALSE, pinfo, tree, tvb, offset,hf_krb_PA_DATA_value, dissect_pkinit_PA_PK_AS_REQ);
+               offset=dissect_ber_old_octet_string_wcb(FALSE, actx, tree, tvb, offset,hf_krb_PA_DATA_value, dissect_pkinit_PA_PK_AS_REQ);
                break;
        case KRB5_PA_PK_AS_REP:
-               offset=dissect_ber_octet_string_wcb(FALSE, pinfo, tree, tvb, offset,hf_krb_PA_DATA_value, dissect_pkinit_PA_PK_AS_REP);
+               offset=dissect_ber_old_octet_string_wcb(FALSE, actx, tree, tvb, offset,hf_krb_PA_DATA_value, dissect_pkinit_PA_PK_AS_REP);
                break;
        case KRB5_PA_PAC_REQUEST:
-               offset=dissect_ber_octet_string_wcb(FALSE, pinfo, tree, tvb, offset,hf_krb_PA_DATA_value, dissect_krb5_PA_PAC_REQUEST);
+               offset=dissect_ber_old_octet_string_wcb(FALSE, actx, tree, tvb, offset,hf_krb_PA_DATA_value, dissect_krb5_PA_PAC_REQUEST);
+               break;
+       case KRB5_PA_S4U2SELF:
+               offset=dissect_ber_old_octet_string_wcb(FALSE, actx, tree, tvb, offset,hf_krb_PA_DATA_value, dissect_krb5_PA_S4U2SELF);
                break;
        case KRB5_PA_PROV_SRV_LOCATION:
-               offset=dissect_ber_octet_string_wcb(FALSE, pinfo, tree, tvb, offset,hf_krb_PA_DATA_value, dissect_krb5_PA_PROV_SRV_LOCATION);
+               offset=dissect_ber_old_octet_string_wcb(FALSE, actx, tree, tvb, offset,hf_krb_PA_DATA_value, dissect_krb5_PA_PROV_SRV_LOCATION);
                break;
        case KRB5_PA_ENC_TIMESTAMP:
-               offset=dissect_ber_octet_string_wcb(FALSE, pinfo, tree, tvb, offset,hf_krb_PA_DATA_value, dissect_krb5_PA_ENC_TIMESTAMP);
+               offset=dissect_ber_old_octet_string_wcb(FALSE, actx, tree, tvb, offset,hf_krb_PA_DATA_value, dissect_krb5_PA_ENC_TIMESTAMP);
                break;
        case KRB5_PA_ENCTYPE_INFO:
-               offset=dissect_ber_octet_string_wcb(FALSE, pinfo, tree, tvb, offset,hf_krb_PA_DATA_value, dissect_krb5_PA_ENCTYPE_INFO);
+               offset=dissect_ber_old_octet_string_wcb(FALSE, actx, tree, tvb, offset,hf_krb_PA_DATA_value, dissect_krb5_PA_ENCTYPE_INFO);
+               break;
+       case KRB5_PA_ENCTYPE_INFO2:
+               offset=dissect_ber_old_octet_string_wcb(FALSE, actx, tree, tvb, offset,hf_krb_PA_DATA_value, dissect_krb5_PA_ENCTYPE_INFO2);
+               break;
+       case KRB5_PA_PW_SALT:
+               offset=dissect_ber_old_octet_string_wcb(FALSE, actx, tree, tvb, offset,hf_krb_PA_DATA_value, dissect_krb5_PW_SALT);
                break;
        default:
-               offset=dissect_ber_octet_string_wcb(FALSE, pinfo, tree, tvb, offset,hf_krb_PA_DATA_value, NULL);
+               offset=dissect_ber_old_octet_string_wcb(FALSE, actx, tree, tvb, offset,hf_krb_PA_DATA_value, NULL);
        }
        return offset;
 /*qqq*/
 }
 
-static ber_sequence_t PA_DATA_sequence[] = {
+static ber_old_sequence_t PA_DATA_sequence[] = {
        { BER_CLASS_CON, 1, 0, dissect_krb5_PA_DATA_type },
        { BER_CLASS_CON, 2, 0, dissect_krb5_PA_DATA_value },
        { 0, 0, 0, NULL }
 };
 static int
-dissect_krb5_PA_DATA(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_PA_DATA(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_sequence(FALSE, pinfo, tree, tvb, offset, PA_DATA_sequence, -1, -1);
+       offset=dissect_ber_old_sequence(FALSE, actx, tree, tvb, offset, PA_DATA_sequence, -1, -1);
 
        return offset;
 }
@@ -2071,20 +2325,19 @@ dissect_krb5_PA_DATA(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int of
  * padata[3]             SEQUENCE OF PA-DATA OPTIONAL,
  *
  */
-static ber_sequence_t PA_DATA_sequence_of[1] = {
+static ber_old_sequence_t PA_DATA_sequence_of[1] = {
   { BER_CLASS_UNI, BER_UNI_TAG_SEQUENCE, BER_FLAGS_NOOWNTAG, dissect_krb5_PA_DATA },
 };
 static int
-dissect_krb5_padata(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_padata(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_sequence_of(FALSE, pinfo, tree, tvb, offset, PA_DATA_sequence_of, hf_krb_padata, ett_krb_padata);
+       offset=dissect_ber_old_sequence_of(FALSE, actx, tree, tvb, offset, PA_DATA_sequence_of, hf_krb_padata, ett_krb_padata);
 
        return offset;
 }
 
 
 
-
 static const true_false_string krb5_ticketflags_forwardable = {
        "FORWARDABLE tickets are allowed/requested",
        "Do NOT use forwardable tickets"
@@ -2156,18 +2409,18 @@ static int* TicketFlags_bits[] = {
 };
 
 static int
-dissect_krb5_TicketFlags(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_TicketFlags(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_bitstring32(FALSE, pinfo, tree, tvb, offset, TicketFlags_bits, hf_krb_TicketFlags, ett_krb_Ticket_Flags, NULL);
+       offset=dissect_ber_bitstring32(FALSE, actx, tree, tvb, offset, TicketFlags_bits, hf_krb_TicketFlags, ett_krb_Ticket_Flags, NULL);
        return offset;
 }
 
 
 static guint32 keytype;
 static int
-dissect_krb5_keytype(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_keytype(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_integer(FALSE, pinfo, tree, tvb, offset, hf_krb_keytype, &keytype);
+       offset=dissect_ber_integer(FALSE, actx, tree, tvb, offset, hf_krb_keytype, &keytype);
        if(tree){
                proto_item_append_text(tree, " %s",
                        val_to_str(keytype, krb5_encryption_types,
@@ -2176,18 +2429,18 @@ dissect_krb5_keytype(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int of
        return offset;
 }
 static int keylength;
-static const char *keyvalue;
+static const guint8 *keyvalue;
 static int
-store_keyvalue(packet_info *pinfo _U_, proto_tree *tree _U_, tvbuff_t *tvb, int offset)
+store_keyvalue(proto_tree *tree _U_, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
        keylength=tvb_length_remaining(tvb, offset);
        keyvalue=tvb_get_ptr(tvb, offset, keylength);
        return 0;
 }
 static int
-dissect_krb5_keyvalue(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_keyvalue(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_octet_string_wcb(FALSE, pinfo, tree, tvb, offset, hf_krb_keyvalue, store_keyvalue);
+       offset=dissect_ber_old_octet_string_wcb(FALSE, actx, tree, tvb, offset, hf_krb_keyvalue, store_keyvalue);
        return offset;
 }
 
@@ -2197,7 +2450,7 @@ dissect_krb5_keyvalue(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int o
  *     keytype  [0] int32
  *     keyvalue [1] octet string
  */
-static ber_sequence_t EncryptionKey_sequence[] = {
+static ber_old_sequence_t EncryptionKey_sequence[] = {
        { BER_CLASS_CON, 0, 0,
                dissect_krb5_keytype },
        { BER_CLASS_CON, 1, 0,
@@ -2205,29 +2458,91 @@ static ber_sequence_t EncryptionKey_sequence[] = {
        { 0, 0, 0, NULL }
 };
 static int
-dissect_krb5_key(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_key(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_sequence(FALSE, pinfo, tree, tvb, offset, EncryptionKey_sequence, hf_krb_key, ett_krb_key);
+       offset=dissect_ber_old_sequence(FALSE, actx, tree, tvb, offset, EncryptionKey_sequence, hf_krb_key, ett_krb_key);
 
 #ifdef HAVE_KERBEROS
-       add_encryption_key(pinfo, keytype, keylength, keyvalue, "key");
+       add_encryption_key(actx->pinfo, keytype, keylength, keyvalue, "key");
 #endif
        return offset;
 }
 static int
-dissect_krb5_subkey(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_subkey(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_sequence(FALSE, pinfo, tree, tvb, offset, EncryptionKey_sequence, hf_krb_subkey, ett_krb_subkey);
+       offset=dissect_ber_old_sequence(FALSE, actx, tree, tvb, offset, EncryptionKey_sequence, hf_krb_subkey, ett_krb_subkey);
 #ifdef HAVE_KERBEROS
-       add_encryption_key(pinfo, keytype, keylength, keyvalue, "subkey");
+       add_encryption_key(actx->pinfo, keytype, keylength, keyvalue, "subkey");
 #endif
        return offset;
 }
 
+static int
+dissect_krb5_PAC_DREP(proto_tree *parent_tree, tvbuff_t *tvb, int offset, guint8 *drep)
+{
+       proto_item *item=NULL;
+       proto_tree *tree=NULL;
+       guint8 val;
+
+       if(parent_tree){
+               item=proto_tree_add_text(parent_tree, tvb, offset, 16, "DREP");
+               tree=proto_item_add_subtree(item, ett_krb_PAC_DREP);
+       }
+
+       val = tvb_get_guint8(tvb, offset);
+       proto_tree_add_uint(tree, hf_dcerpc_drep_byteorder, tvb, offset, 1, val>>4);
+
+       offset++;
+
+       if (drep) {
+               *drep = val;
+       }
+
+       return offset;
+}
+
+/* This might be some sort of header that MIDL generates when creating
+ * marshalling/unmarshalling code for blobs that are not to be transported
+ * ontop of DCERPC and where the DREP fields specifying things such as
+ * endianess and similar are not available.
+ */
+static int
+dissect_krb5_PAC_NDRHEADERBLOB(proto_tree *parent_tree, tvbuff_t *tvb, int offset, guint8 *drep, asn1_ctx_t *actx _U_)
+{
+       proto_item *item=NULL;
+       proto_tree *tree=NULL;
+
+       if(parent_tree){
+               item=proto_tree_add_text(parent_tree, tvb, offset, 16, "MES header");
+               tree=proto_item_add_subtree(item, ett_krb_PAC_MIDL_BLOB);
+       }
+
+       /* modified DREP field that is used for stuff that is transporetd ontop
+          of non dcerpc
+       */
+       proto_tree_add_item(tree, hf_krb_midl_version, tvb, offset, 1, TRUE);
+       offset++;
+
+       offset = dissect_krb5_PAC_DREP(tree, tvb, offset, drep);
+
 
+       proto_tree_add_item(tree, hf_krb_midl_hdr_len, tvb, offset, 2, TRUE);
+       offset+=2;
+
+       proto_tree_add_item(tree, hf_krb_midl_fill_bytes, tvb, offset, 4,
+                       TRUE);
+       offset += 4;
+
+       /* length of blob that follows */
+       proto_tree_add_item(tree, hf_krb_midl_blob_len, tvb, offset, 8,
+                       TRUE);
+       offset += 8;
+
+       return offset;
+}
 
 static int
-dissect_krb5_PAC_LOGON_INFO(packet_info *pinfo, proto_tree *parent_tree, tvbuff_t *tvb, int offset)
+dissect_krb5_PAC_LOGON_INFO(proto_tree *parent_tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
        proto_item *item=NULL;
        proto_tree *tree=NULL;
@@ -2240,29 +2555,117 @@ dissect_krb5_PAC_LOGON_INFO(packet_info *pinfo, proto_tree *parent_tree, tvbuff_
                tree=proto_item_add_subtree(item, ett_krb_PAC_LOGON_INFO);
        }
 
-       /* skip the first 20 bytes, they look like a unique ndr pointer
-          followed by (where did it come from?) a contect_handle ?*/
-       proto_tree_add_text(tree, tvb, offset, 20, "unknown: is this an undocumented policy handle?");
-       offset+=20;
-
+       /* skip the first 16 bytes, they are some magic created by the idl
+        * compiler   the first 4 bytes might be flags?
+        */
+       offset=dissect_krb5_PAC_NDRHEADERBLOB(tree, tvb, offset, &drep[0], actx);
 
        /* the PAC_LOGON_INFO blob */
        /* fake whatever state the dcerpc runtime support needs */
        di.conformant_run=0;
        di.call_data=NULL;
-       old_private_data=pinfo->private_data;
-       pinfo->private_data=&di;
-       init_ndr_pointer_list(pinfo);
-       offset = dissect_ndr_pointer(tvb, offset, pinfo, tree, drep,
-               netlogon_dissect_PAC_LOGON_INFO, NDR_POINTER_REF,
+       old_private_data=actx->pinfo->private_data;
+       actx->pinfo->private_data=&di;
+       init_ndr_pointer_list(actx->pinfo);
+       offset = dissect_ndr_pointer(tvb, offset, actx->pinfo, tree, drep,
+               netlogon_dissect_PAC_LOGON_INFO, NDR_POINTER_UNIQUE,
                "PAC_LOGON_INFO:", -1);
-       pinfo->private_data=old_private_data;
+       actx->pinfo->private_data=old_private_data;
+
+       return offset;
+}
+
+static int
+dissect_krb5_PAC_CONSTRAINED_DELEGATION(proto_tree *parent_tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
+{
+       proto_item *item=NULL;
+       proto_tree *tree=NULL;
+       guint8 drep[4] = { 0x10, 0x00, 0x00, 0x00}; /* fake DREP struct */
+       dcerpc_info di; /* fake dcerpc_info struct */
+       void *old_private_data;
+
+       item=proto_tree_add_item(parent_tree, hf_krb_PAC_CONSTRAINED_DELEGATION, tvb, offset, tvb_length_remaining(tvb, offset), FALSE);
+       if(parent_tree){
+               tree=proto_item_add_subtree(item, ett_krb_PAC_CONSTRAINED_DELEGATION);
+       }
+
+       /* skip the first 16 bytes, they are some magic created by the idl
+        * compiler   the first 4 bytes might be flags?
+        */
+       offset=dissect_krb5_PAC_NDRHEADERBLOB(tree, tvb, offset, &drep[0], actx);
+
+
+       /* the PAC_CONSTRAINED_DELEGATION blob */
+       /* fake whatever state the dcerpc runtime support needs */
+       di.conformant_run=0;
+       di.call_data=NULL;
+       old_private_data=actx->pinfo->private_data;
+       actx->pinfo->private_data=&di;
+       init_ndr_pointer_list(actx->pinfo);
+       offset = dissect_ndr_pointer(tvb, offset, actx->pinfo, tree, drep,
+               netlogon_dissect_PAC_CONSTRAINED_DELEGATION, NDR_POINTER_UNIQUE,
+               "PAC_CONSTRAINED_DELEGATION:", -1);
+       actx->pinfo->private_data=old_private_data;
+
+       return offset;
+}
+
+static int
+dissect_krb5_PAC_UPN_DNS_INFO(proto_tree *parent_tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
+{
+       proto_item *item=NULL;
+       proto_tree *tree=NULL;
+       guint16 dns_offset, dns_len;
+       guint16 upn_offset, upn_len;
+       const char *dn;
+       int dn_len;
+       guint16 bc;
+
+       item=proto_tree_add_item(parent_tree, hf_krb_PAC_UPN_DNS_INFO, tvb, offset, tvb_length_remaining(tvb, offset), FALSE);
+       if(parent_tree){
+               tree=proto_item_add_subtree(item, ett_krb_PAC_UPN_DNS_INFO);
+       }
+
+       /* upn */
+       upn_len = tvb_get_letohs(tvb, offset);
+       proto_tree_add_item(tree, hf_krb_pac_upn_upn_len, tvb, offset, 2, TRUE);
+       offset+=2;
+       upn_offset = tvb_get_letohs(tvb, offset);
+       proto_tree_add_item(tree, hf_krb_pac_upn_upn_offset, tvb, offset, 2, TRUE);
+       offset+=2;
+
+       /* dns */
+       dns_len = tvb_get_letohs(tvb, offset);
+       proto_tree_add_item(tree, hf_krb_pac_upn_dns_len, tvb, offset, 2, TRUE);
+       offset+=2;
+       dns_offset = tvb_get_letohs(tvb, offset);
+       proto_tree_add_item(tree, hf_krb_pac_upn_dns_offset, tvb, offset, 2, TRUE);
+       offset+=2;
+
+       /* flags */     
+       proto_tree_add_item(tree, hf_krb_pac_upn_flags, tvb, offset, 4, TRUE);  
+
+       /* upn */
+       offset = upn_offset;
+       dn_len = upn_len;
+       bc = tvb_length_remaining(tvb, offset);
+       dn = get_unicode_or_ascii_string(tvb, &offset,
+                       TRUE, &dn_len, TRUE, TRUE, &bc);
+       proto_tree_add_string(tree, hf_krb_pac_upn_upn_name, tvb, upn_offset, upn_len, dn);
+
+       /* dns */
+       offset = dns_offset;
+       dn_len = dns_len;
+       bc = tvb_length_remaining(tvb, offset);
+       dn = get_unicode_or_ascii_string(tvb, &offset,
+                       TRUE, &dn_len, TRUE, TRUE, &bc);
+       proto_tree_add_string(tree, hf_krb_pac_upn_dns_name, tvb, dns_offset, dns_len, dn);
 
        return offset;
 }
 
 static int
-dissect_krb5_PAC_CREDENTIAL_TYPE(packet_info *pinfo _U_, proto_tree *parent_tree, tvbuff_t *tvb, int offset)
+dissect_krb5_PAC_CREDENTIAL_TYPE(proto_tree *parent_tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
        proto_item *item=NULL;
        proto_tree *tree=NULL;
@@ -2277,7 +2680,7 @@ dissect_krb5_PAC_CREDENTIAL_TYPE(packet_info *pinfo _U_, proto_tree *parent_tree
 }
 
 static int
-dissect_krb5_PAC_SERVER_CHECKSUM(packet_info *pinfo _U_, proto_tree *parent_tree, tvbuff_t *tvb, int offset)
+dissect_krb5_PAC_SERVER_CHECKSUM(proto_tree *parent_tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
        proto_item *item=NULL;
        proto_tree *tree=NULL;
@@ -2298,7 +2701,7 @@ dissect_krb5_PAC_SERVER_CHECKSUM(packet_info *pinfo _U_, proto_tree *parent_tree
 }
 
 static int
-dissect_krb5_PAC_PRIVSVR_CHECKSUM(packet_info *pinfo _U_, proto_tree *parent_tree, tvbuff_t *tvb, int offset)
+dissect_krb5_PAC_PRIVSVR_CHECKSUM(proto_tree *parent_tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
        proto_item *item=NULL;
        proto_tree *tree=NULL;
@@ -2319,7 +2722,7 @@ dissect_krb5_PAC_PRIVSVR_CHECKSUM(packet_info *pinfo _U_, proto_tree *parent_tre
 }
 
 static int
-dissect_krb5_PAC_CLIENT_INFO_TYPE(packet_info *pinfo _U_, proto_tree *parent_tree, tvbuff_t *tvb, int offset)
+dissect_krb5_PAC_CLIENT_INFO_TYPE(proto_tree *parent_tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
        proto_item *item=NULL;
        proto_tree *tree=NULL;
@@ -2341,7 +2744,7 @@ dissect_krb5_PAC_CLIENT_INFO_TYPE(packet_info *pinfo _U_, proto_tree *parent_tre
        offset+=2;
 
        /* client name */
-       name=tvb_fake_unicode(tvb, offset, namelen/2, TRUE);
+       name=tvb_get_ephemeral_faked_unicode(tvb, offset, namelen/2, TRUE);
        proto_tree_add_string(tree, hf_krb_pac_clientname, tvb, offset, namelen, name);
        offset+=namelen;
 
@@ -2349,7 +2752,7 @@ dissect_krb5_PAC_CLIENT_INFO_TYPE(packet_info *pinfo _U_, proto_tree *parent_tre
 }
 
 static int
-dissect_krb5_AD_WIN2K_PAC_struct(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_AD_WIN2K_PAC_struct(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
        guint32 pac_type;
        guint32 pac_size;
@@ -2381,20 +2784,27 @@ dissect_krb5_AD_WIN2K_PAC_struct(packet_info *pinfo, proto_tree *tree, tvbuff_t
        next_tvb=tvb_new_subset(tvb, pac_offset, pac_size, pac_size);
        switch(pac_type){
        case PAC_LOGON_INFO:
-               dissect_krb5_PAC_LOGON_INFO(pinfo, tr, next_tvb, 0);
+               dissect_krb5_PAC_LOGON_INFO(tr, next_tvb, 0, actx);
                break;
        case PAC_CREDENTIAL_TYPE:
-               dissect_krb5_PAC_CREDENTIAL_TYPE(pinfo, tr, next_tvb, 0);
+               dissect_krb5_PAC_CREDENTIAL_TYPE(tr, next_tvb, 0, actx);
                break;
        case PAC_SERVER_CHECKSUM:
-               dissect_krb5_PAC_SERVER_CHECKSUM(pinfo, tr, next_tvb, 0);
+               dissect_krb5_PAC_SERVER_CHECKSUM(tr, next_tvb, 0, actx);
                break;
        case PAC_PRIVSVR_CHECKSUM:
-               dissect_krb5_PAC_PRIVSVR_CHECKSUM(pinfo, tr, next_tvb, 0);
+               dissect_krb5_PAC_PRIVSVR_CHECKSUM(tr, next_tvb, 0, actx);
                break;
        case PAC_CLIENT_INFO_TYPE:
-               dissect_krb5_PAC_CLIENT_INFO_TYPE(pinfo, tr, next_tvb, 0);
+               dissect_krb5_PAC_CLIENT_INFO_TYPE(tr, next_tvb, 0, actx);
+               break;
+       case PAC_CONSTRAINED_DELEGATION:
+               dissect_krb5_PAC_CONSTRAINED_DELEGATION(tr, next_tvb, 0, actx);
                break;
+       case PAC_UPN_DNS_INFO:
+               dissect_krb5_PAC_UPN_DNS_INFO(tr, next_tvb, 0, actx);
+               break;
+
        default:;
 /*qqq*/
        }
@@ -2402,7 +2812,7 @@ dissect_krb5_AD_WIN2K_PAC_struct(packet_info *pinfo, proto_tree *tree, tvbuff_t
 }
 
 static int
-dissect_krb5_AD_WIN2K_PAC(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_AD_WIN2K_PAC(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
        guint32 entries;
        guint32 version;
@@ -2419,17 +2829,37 @@ dissect_krb5_AD_WIN2K_PAC(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, i
        offset += 4;
 
        for(i=0;i<entries;i++){
-               offset=dissect_krb5_AD_WIN2K_PAC_struct(pinfo, tree, tvb, offset);
+               offset=dissect_krb5_AD_WIN2K_PAC_struct(tree, tvb, offset, actx);
        }
 
        return offset;
 }
 
+
+int dissect_krb5_Checksum(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx);
+
+static ber_old_sequence_t AD_SIGNTICKET_sequence[] = {
+       { BER_CLASS_CON, 0, 0,
+               dissect_krb5_etype },
+       { BER_CLASS_CON, 1, 0,
+               dissect_krb5_Checksum },
+       { 0, 0, 0, NULL }
+};
+
+/* first seen in traces from vista */
+static int
+dissect_krb5_AD_SIGNTICKET(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx)
+{
+       offset=dissect_ber_old_sequence(FALSE, actx, tree, tvb, offset, AD_SIGNTICKET_sequence, -1, -1);
+
+       return offset;
+}
+
 static guint32 IF_RELEVANT_type;
 static int
-dissect_krb5_IF_RELEVANT_type(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_IF_RELEVANT_type(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_integer(FALSE, pinfo, tree, tvb, offset, hf_krb_IF_RELEVANT_type, &IF_RELEVANT_type);
+       offset=dissect_ber_integer(FALSE, actx, tree, tvb, offset, hf_krb_IF_RELEVANT_type, &IF_RELEVANT_type);
        if(tree){
                proto_item_append_text(tree, " %s",
                        val_to_str(IF_RELEVANT_type, krb5_ad_types,
@@ -2438,18 +2868,21 @@ dissect_krb5_IF_RELEVANT_type(packet_info *pinfo, proto_tree *tree, tvbuff_t *tv
        return offset;
 }
 static int
-dissect_krb5_IF_RELEVANT_value(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_IF_RELEVANT_value(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
        switch(IF_RELEVANT_type){
        case KRB5_AD_WIN2K_PAC:
-               offset=dissect_ber_octet_string_wcb(FALSE, pinfo, tree, tvb, offset, hf_krb_advalue, dissect_krb5_AD_WIN2K_PAC);
+               offset=dissect_ber_old_octet_string_wcb(FALSE, actx, tree, tvb, offset, hf_krb_advalue, dissect_krb5_AD_WIN2K_PAC);
+               break;
+       case KRB5_AD_SIGNTICKET:
+               offset=dissect_ber_old_octet_string_wcb(FALSE, actx, tree, tvb, offset, hf_krb_advalue, dissect_krb5_AD_SIGNTICKET);
                break;
        default:
-               offset=dissect_ber_octet_string(FALSE, pinfo, tree, tvb, offset, hf_krb_IF_RELEVANT_value, NULL);
+               offset=dissect_ber_octet_string(FALSE, actx, tree, tvb, offset, hf_krb_IF_RELEVANT_value, NULL);
        }
        return offset;
 }
-static ber_sequence_t IF_RELEVANT_item_sequence[] = {
+static ber_old_sequence_t IF_RELEVANT_item_sequence[] = {
        { BER_CLASS_CON, 0, 0,
                dissect_krb5_IF_RELEVANT_type },
        { BER_CLASS_CON, 1, 0,
@@ -2457,30 +2890,30 @@ static ber_sequence_t IF_RELEVANT_item_sequence[] = {
        { 0, 0, 0, NULL }
 };
 static int
-dissect_krb5_IF_RELEVANT_item(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_IF_RELEVANT_item(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_sequence(FALSE, pinfo, tree, tvb, offset, IF_RELEVANT_item_sequence, hf_krb_IF_RELEVANT, ett_krb_IF_RELEVANT);
+       offset=dissect_ber_old_sequence(FALSE, actx, tree, tvb, offset, IF_RELEVANT_item_sequence, hf_krb_IF_RELEVANT, ett_krb_IF_RELEVANT);
 
        return offset;
 }
 
-static ber_sequence_t IF_RELEVANT_sequence_of[1] = {
+static ber_old_sequence_t IF_RELEVANT_sequence_of[1] = {
   { BER_CLASS_UNI, BER_UNI_TAG_SEQUENCE, BER_FLAGS_NOOWNTAG, dissect_krb5_IF_RELEVANT_item },
 };
 
 static int
-dissect_krb5_IF_RELEVANT(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_IF_RELEVANT(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_sequence_of(FALSE, pinfo, tree, tvb, offset, IF_RELEVANT_sequence_of, -1, -1);
+       offset=dissect_ber_old_sequence_of(FALSE, actx, tree, tvb, offset, IF_RELEVANT_sequence_of, -1, -1);
 
        return offset;
 }
 
 static guint32 adtype;
 static int
-dissect_krb5_adtype(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_adtype(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_integer(FALSE, pinfo, tree, tvb, offset, hf_krb_adtype, &adtype);
+       offset=dissect_ber_integer(FALSE, actx, tree, tvb, offset, hf_krb_adtype, &adtype);
        if(tree){
                proto_item_append_text(tree, " %s",
                        val_to_str(adtype, krb5_ad_types,
@@ -2489,14 +2922,14 @@ dissect_krb5_adtype(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int off
        return offset;
 }
 static int
-dissect_krb5_advalue(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_advalue(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
        switch(adtype){
        case KRB5_AD_IF_RELEVANT:
-               offset=dissect_ber_octet_string_wcb(FALSE, pinfo, tree, tvb, offset, hf_krb_advalue, dissect_krb5_IF_RELEVANT);
+               offset=dissect_ber_old_octet_string_wcb(FALSE, actx, tree, tvb, offset, hf_krb_advalue, dissect_krb5_IF_RELEVANT);
                break;
        default:
-               offset=dissect_ber_octet_string(FALSE, pinfo, tree, tvb, offset, hf_krb_advalue, NULL);
+               offset=dissect_ber_octet_string(FALSE, actx, tree, tvb, offset, hf_krb_advalue, NULL);
        }
        return offset;
 }
@@ -2505,7 +2938,7 @@ dissect_krb5_advalue(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int of
  *     ad-type  [0] int32
  *     ad-data  [1] octet string
  */
-static ber_sequence_t AuthorizationData_item_sequence[] = {
+static ber_old_sequence_t AuthorizationData_item_sequence[] = {
        { BER_CLASS_CON, 0, 0,
                dissect_krb5_adtype },
        { BER_CLASS_CON, 1, 0,
@@ -2513,31 +2946,31 @@ static ber_sequence_t AuthorizationData_item_sequence[] = {
        { 0, 0, 0, NULL }
 };
 static int
-dissect_krb5_AuthorizationData_item(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_AuthorizationData_item(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_sequence(FALSE, pinfo, tree, tvb, offset, AuthorizationData_item_sequence, hf_krb_AuthorizationData, ett_krb_AuthorizationData);
+       offset=dissect_ber_old_sequence(FALSE, actx, tree, tvb, offset, AuthorizationData_item_sequence, hf_krb_AuthorizationData, ett_krb_AuthorizationData);
 
        return offset;
 }
 
-static ber_sequence_t AuthorizationData_sequence_of[1] = {
+static ber_old_sequence_t AuthorizationData_sequence_of[1] = {
   { BER_CLASS_UNI, BER_UNI_TAG_SEQUENCE, BER_FLAGS_NOOWNTAG, dissect_krb5_AuthorizationData_item },
 };
 static int
-dissect_krb5_AuthorizationData(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_AuthorizationData(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_sequence_of(FALSE, pinfo, tree, tvb, offset, AuthorizationData_sequence_of, -1, -1);
+       offset=dissect_ber_old_sequence_of(FALSE, actx, tree, tvb, offset, AuthorizationData_sequence_of, -1, -1);
 
        return offset;
 }
 
 
 static int
-dissect_krb5_transited_type(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_transited_type(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
        guint32 trtype;
 
-       offset=dissect_ber_integer(FALSE, pinfo, tree, tvb, offset, hf_krb_transitedtype, &trtype);
+       offset=dissect_ber_integer(FALSE, actx, tree, tvb, offset, hf_krb_transitedtype, &trtype);
        if(tree){
                proto_item_append_text(tree, " %s",
                        val_to_str(trtype, krb5_transited_types,
@@ -2547,9 +2980,9 @@ dissect_krb5_transited_type(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb,
 }
 
 static int
-dissect_krb5_transited_contents(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_transited_contents(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_octet_string(FALSE, pinfo, tree, tvb, offset, hf_krb_transitedcontents, NULL);
+       offset=dissect_ber_octet_string(FALSE, actx, tree, tvb, offset, hf_krb_transitedcontents, NULL);
        return offset;
 }
 
@@ -2558,7 +2991,7 @@ dissect_krb5_transited_contents(packet_info *pinfo, proto_tree *tree, tvbuff_t *
  *     tr-type  [0] int32
  *     contents [1] octet string
  */
-static ber_sequence_t TransitedEncoding_sequence[] = {
+static ber_old_sequence_t TransitedEncoding_sequence[] = {
        { BER_CLASS_CON, 0, 0,
                dissect_krb5_transited_type },
        { BER_CLASS_CON, 1, 0,
@@ -2566,36 +2999,36 @@ static ber_sequence_t TransitedEncoding_sequence[] = {
        { 0, 0, 0, NULL }
 };
 static int
-dissect_krb5_transited(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_transited(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_sequence(FALSE, pinfo, tree, tvb, offset, TransitedEncoding_sequence, hf_krb_TransitedEncoding, ett_krb_TransitedEncoding);
+       offset=dissect_ber_old_sequence(FALSE, actx, tree, tvb, offset, TransitedEncoding_sequence, hf_krb_TransitedEncoding, ett_krb_TransitedEncoding);
 
        return offset;
 }
 
 
 static int
-dissect_krb5_authtime(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_authtime(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_GeneralizedTime(FALSE, pinfo, tree, tvb, offset, hf_krb_authtime);
+       offset=dissect_ber_GeneralizedTime(FALSE, actx, tree, tvb, offset, hf_krb_authtime);
        return offset;
 }
 static int
-dissect_krb5_starttime(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_starttime(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_GeneralizedTime(FALSE, pinfo, tree, tvb, offset, hf_krb_starttime);
+       offset=dissect_ber_GeneralizedTime(FALSE, actx, tree, tvb, offset, hf_krb_starttime);
        return offset;
 }
 static int
-dissect_krb5_endtime(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_endtime(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_GeneralizedTime(FALSE, pinfo, tree, tvb, offset, hf_krb_endtime);
+       offset=dissect_ber_GeneralizedTime(FALSE, actx, tree, tvb, offset, hf_krb_endtime);
        return offset;
 }
 static int
-dissect_krb5_renew_till(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_renew_till(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_GeneralizedTime(FALSE, pinfo, tree, tvb, offset, hf_krb_renew_till);
+       offset=dissect_ber_GeneralizedTime(FALSE, actx, tree, tvb, offset, hf_krb_renew_till);
        return offset;
 }
 
@@ -2614,7 +3047,7 @@ dissect_krb5_renew_till(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int
  *      authorization-data      [10] AuthorizationData OPTIONAL
  * }
  */
-static ber_sequence_t EncTicketPart_sequence[] = {
+static ber_old_sequence_t EncTicketPart_sequence[] = {
        { BER_CLASS_CON, 0, 0,
                dissect_krb5_TicketFlags },
        { BER_CLASS_CON, 1, 0,
@@ -2640,9 +3073,9 @@ static ber_sequence_t EncTicketPart_sequence[] = {
        { 0, 0, 0, NULL }
 };
 static int
-dissect_krb5_EncTicketPart(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_EncTicketPart(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_sequence(FALSE, pinfo, tree, tvb, offset, EncTicketPart_sequence, hf_krb_EncTicketPart, ett_krb_EncTicketPart);
+       offset=dissect_ber_old_sequence(FALSE, actx, tree, tvb, offset, EncTicketPart_sequence, hf_krb_EncTicketPart, ett_krb_EncTicketPart);
 
        return offset;
 }
@@ -2660,7 +3093,7 @@ dissect_krb5_EncTicketPart(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb,
  *     seq-number               [3] uint32 OPTIONAL
  * }
  */
-static ber_sequence_t EncAPRepPart_sequence[] = {
+static ber_old_sequence_t EncAPRepPart_sequence[] = {
        { BER_CLASS_CON, 0, 0,
                dissect_krb5_ctime },
        { BER_CLASS_CON, 1, 0,
@@ -2672,9 +3105,9 @@ static ber_sequence_t EncAPRepPart_sequence[] = {
        { 0, 0, 0, NULL }
 };
 static int
-dissect_krb5_EncAPRepPart(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_EncAPRepPart(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_sequence(FALSE, pinfo, tree, tvb, offset, EncAPRepPart_sequence, hf_krb_EncAPRepPart, ett_krb_EncAPRepPart);
+       offset=dissect_ber_old_sequence(FALSE, actx, tree, tvb, offset, EncAPRepPart_sequence, hf_krb_EncAPRepPart, ett_krb_EncAPRepPart);
 
        return offset;
 }
@@ -2694,21 +3127,21 @@ static const value_string krb5_lr_types[] = {
     { 0, NULL }
 };
 static int
-dissect_krb5_lr_type(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_lr_type(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_integer(FALSE, pinfo, tree, tvb, offset, hf_krb_lr_type, &lr_type);
+       offset=dissect_ber_integer(FALSE, actx, tree, tvb, offset, hf_krb_lr_type, &lr_type);
 
        return offset;
 }
 static int
-dissect_krb5_lr_value(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_lr_value(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_GeneralizedTime(FALSE, pinfo, tree, tvb, offset, hf_krb_lr_time);
+       offset=dissect_ber_GeneralizedTime(FALSE, actx, tree, tvb, offset, hf_krb_lr_time);
 
        return offset;
 }
 
-static ber_sequence_t LastReq_sequence[] = {
+static ber_old_sequence_t LastReq_sequence[] = {
        { BER_CLASS_CON, 0, 0,
                dissect_krb5_lr_type },
        { BER_CLASS_CON, 1, 0,
@@ -2716,31 +3149,31 @@ static ber_sequence_t LastReq_sequence[] = {
        { 0, 0, 0, NULL }
 };
 static int
-dissect_krb5_LastReq(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_LastReq(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_sequence(FALSE, pinfo, tree, tvb, offset, LastReq_sequence, hf_krb_LastReq, ett_krb_LastReq);
+       offset=dissect_ber_old_sequence(FALSE, actx, tree, tvb, offset, LastReq_sequence, hf_krb_LastReq, ett_krb_LastReq);
 
        return offset;
 }
-static ber_sequence_t LastReq_sequence_of[1] = {
+static ber_old_sequence_t LastReq_sequence_of[1] = {
   { BER_CLASS_UNI, BER_UNI_TAG_SEQUENCE, BER_FLAGS_NOOWNTAG, dissect_krb5_LastReq },
 };
 static int
-dissect_krb5_LastReq_sequence_of(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_LastReq_sequence_of(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_sequence_of(FALSE, pinfo, tree, tvb, offset, LastReq_sequence_of, hf_krb_LastReqs, ett_krb_LastReqs);
+       offset=dissect_ber_old_sequence_of(FALSE, actx, tree, tvb, offset, LastReq_sequence_of, hf_krb_LastReqs, ett_krb_LastReqs);
 
        return offset;
 }
 
 static int
-dissect_krb5_key_expiration(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_key_expiration(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_GeneralizedTime(FALSE, pinfo, tree, tvb, offset, hf_krb_key_expire);
+       offset=dissect_ber_GeneralizedTime(FALSE, actx, tree, tvb, offset, hf_krb_key_expire);
        return offset;
 }
 
-static ber_sequence_t EncKDCRepPart_sequence[] = {
+static ber_old_sequence_t EncKDCRepPart_sequence[] = {
        { BER_CLASS_CON, 0, 0,
                dissect_krb5_key },
        { BER_CLASS_CON, 1, 0,
@@ -2768,42 +3201,149 @@ static ber_sequence_t EncKDCRepPart_sequence[] = {
        { 0, 0, 0, NULL }
 };
 static int
-dissect_krb5_EncKDCRepPart(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_EncKDCRepPart(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_sequence(FALSE, pinfo, tree, tvb, offset, EncKDCRepPart_sequence, hf_krb_EncKDCRepPart, ett_krb_EncKDCRepPart);
+       offset=dissect_ber_old_sequence(FALSE, actx, tree, tvb, offset, EncKDCRepPart_sequence, hf_krb_EncKDCRepPart, ett_krb_EncKDCRepPart);
 
        return offset;
 }
 
 
 static int
-dissect_krb5_authenticator_vno(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_authenticator_vno(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_integer(FALSE, pinfo, tree, tvb, offset, hf_krb_authenticator_vno, NULL);
+       offset=dissect_ber_integer(FALSE, actx, tree, tvb, offset, hf_krb_authenticator_vno, NULL);
 
        return offset;
 }
 
 
-static int
-dissect_krb5_checksum_type(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
-{
-       offset=dissect_ber_integer(FALSE, pinfo, tree, tvb, offset, hf_krb_checksum_type, NULL);
+#define KRB5_GSS_C_DELEG_FLAG          0x01
+#define KRB5_GSS_C_MUTUAL_FLAG         0x02
+#define KRB5_GSS_C_REPLAY_FLAG         0x04
+#define KRB5_GSS_C_SEQUENCE_FLAG       0x08
+#define KRB5_GSS_C_CONF_FLAG           0x10
+#define KRB5_GSS_C_INTEG_FLAG          0x20
+#define KRB5_GSS_C_DCE_STYLE           0x1000
+static const true_false_string tfs_gss_flags_deleg = {
+       "Delegate credantials to remote peer",
+       "Do NOT delegate"
+};
+static const true_false_string tfs_gss_flags_mutual = {
+       "Request that remote peer authenticates itself",
+       "Mutual authentication NOT required"
+};
+static const true_false_string tfs_gss_flags_replay = {
+       "Enable replay protection for signed or sealed messages",
+       "Do NOT enable replay protection"
+};
+static const true_false_string tfs_gss_flags_sequence = {
+       "Enable Out-of-sequence detection for sign or sealed messages",
+       "Do NOT enable out-of-sequence detection"
+};
+static const true_false_string tfs_gss_flags_conf = {
+       "Confidentiality (sealing) may be invoked",
+       "Do NOT use Confidentiality (sealing)"
+};
+static const true_false_string tfs_gss_flags_integ = {
+       "Integrity protection (signing) may be invoked",
+       "Do NOT use integrity protection"
+};
 
-       return offset;
-}
+static const true_false_string tfs_gss_flags_dce_style = {
+       "DCE-STYLE",
+       "Not using DCE-STYLE"
+};
+
+/* Dissect a GSSAPI checksum as per RFC1964. This is NOT ASN.1 encoded.
+ */
 static int
-dissect_krb5_checksum_checksum(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_rfc1964_checksum(asn1_ctx_t *actx _U_, proto_tree *tree, tvbuff_t *tvb)
 {
-       offset=dissect_ber_octet_string(FALSE, pinfo, tree, tvb, offset, hf_krb_checksum_checksum, NULL);
-       return offset;
-}
+       int offset=0;
+       guint32 len;
+       guint16 dlglen;
 
-/*
- * Checksum ::=        SEQUENCE {
- * }
- */
-static ber_sequence_t Checksum_sequence[] = {
+       /* Length of Bnd field */
+       len=tvb_get_letohl(tvb, offset);
+       proto_tree_add_item(tree, hf_krb_gssapi_len, tvb, offset, 4, TRUE);
+       offset += 4;
+
+       /* Bnd field */
+       proto_tree_add_item(tree, hf_krb_gssapi_bnd, tvb, offset, len, TRUE);
+       offset += len;
+
+
+       /* flags */
+       proto_tree_add_item(tree, hf_krb_gssapi_c_flag_dce_style, tvb, offset, 4, TRUE);
+       proto_tree_add_item(tree, hf_krb_gssapi_c_flag_integ, tvb, offset, 4, TRUE);
+       proto_tree_add_item(tree, hf_krb_gssapi_c_flag_conf, tvb, offset, 4, TRUE);
+       proto_tree_add_item(tree, hf_krb_gssapi_c_flag_sequence, tvb, offset, 4, TRUE);
+       proto_tree_add_item(tree, hf_krb_gssapi_c_flag_replay, tvb, offset, 4, TRUE);
+       proto_tree_add_item(tree, hf_krb_gssapi_c_flag_mutual, tvb, offset, 4, TRUE);
+       proto_tree_add_item(tree, hf_krb_gssapi_c_flag_deleg, tvb, offset, 4, TRUE);
+       offset += 4;
+
+       /* the next fields are optional so we have to check that we have
+        * more data in our buffers */
+       if(tvb_length_remaining(tvb, offset)<2){
+               return offset;
+       }
+       /* dlgopt identifier */
+       proto_tree_add_item(tree, hf_krb_gssapi_dlgopt, tvb, offset, 2, TRUE);
+       offset += 2;
+
+       if(tvb_length_remaining(tvb, offset)<2){
+               return offset;
+       }
+       /* dlglen identifier */
+       dlglen=tvb_get_letohs(tvb, offset);
+       proto_tree_add_item(tree, hf_krb_gssapi_dlglen, tvb, offset, 2, TRUE);
+       offset += 2;
+
+       if(dlglen!=tvb_length_remaining(tvb, offset)){
+               proto_tree_add_text(tree, tvb, 0, 0, "Error: DlgLen:%d is not the same as number of bytes remaining:%d", dlglen, tvb_length_remaining(tvb, offset));
+               return offset;
+       }
+
+       /* this should now be a KRB_CRED message */
+       offset=dissect_ber_old_choice(actx, tree, tvb, offset, kerberos_applications_choice, -1, -1, NULL);
+
+
+       return offset;
+}
+
+static guint32 checksum_type;
+
+static int
+dissect_krb5_checksum_type(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
+{
+       offset=dissect_ber_integer(FALSE, actx, tree, tvb, offset, hf_krb_checksum_type, &checksum_type);
+
+       return offset;
+}
+
+static int
+dissect_krb5_checksum_checksum(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
+{
+       tvbuff_t *next_tvb;
+
+       switch(checksum_type){
+       case KRB5_CHKSUM_GSSAPI:
+               offset=dissect_ber_octet_string(FALSE, actx, tree, tvb, offset, hf_krb_checksum_checksum, &next_tvb);
+               dissect_krb5_rfc1964_checksum(actx, tree, next_tvb);
+               break;
+       default:
+               offset=dissect_ber_octet_string(FALSE, actx, tree, tvb, offset, hf_krb_checksum_checksum, NULL);
+       }
+       return offset;
+}
+
+/*
+ * Checksum ::=        SEQUENCE {
+ * }
+ */
+static ber_old_sequence_t Checksum_sequence[] = {
        { BER_CLASS_CON, 0, 0,
                dissect_krb5_checksum_type },
        { BER_CLASS_CON, 1, 0,
@@ -2811,9 +3351,9 @@ static ber_sequence_t Checksum_sequence[] = {
        { 0, 0, 0, NULL }
 };
 int
-dissect_krb5_Checksum(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_Checksum(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_sequence(FALSE, pinfo, tree, tvb, offset, Checksum_sequence, hf_krb_Checksum, ett_krb_Checksum);
+       offset=dissect_ber_old_sequence(FALSE, actx, tree, tvb, offset, Checksum_sequence, hf_krb_Checksum, ett_krb_Checksum);
 
        return offset;
 }
@@ -2831,7 +3371,7 @@ dissect_krb5_Checksum(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int o
  *     authorization-data       [8] AuthorizationData OPTIONAL
  * }
  */
-static ber_sequence_t Authenticator_sequence[] = {
+static ber_old_sequence_t Authenticator_sequence[] = {
        { BER_CLASS_CON, 0, 0,
                dissect_krb5_authenticator_vno },
        { BER_CLASS_CON, 1, 0,
@@ -2853,14 +3393,93 @@ static ber_sequence_t Authenticator_sequence[] = {
        { 0, 0, 0, NULL }
 };
 static int
-dissect_krb5_Authenticator(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_Authenticator(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_sequence(FALSE, pinfo, tree, tvb, offset, Authenticator_sequence, hf_krb_Authenticator, ett_krb_Authenticator);
+       offset=dissect_ber_old_sequence(FALSE, actx, tree, tvb, offset, Authenticator_sequence, hf_krb_Authenticator, ett_krb_Authenticator);
 
        return offset;
 }
 
 
+static int
+dissect_krb5_PRIV_BODY_user_data(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
+{
+       tvbuff_t *new_tvb;
+       offset=dissect_ber_octet_string(FALSE, actx, tree, tvb, offset, hf_krb_PRIV_BODY_user_data, &new_tvb);
+
+       if (new_tvb)
+               call_kerberos_callbacks(actx->pinfo, tree, new_tvb, KRB_CBTAG_PRIV_USER_DATA);
+
+       return offset;
+}
+
+static ber_old_sequence_t EncKrbPrivPart_sequence[] = {
+       { BER_CLASS_CON, 0, 0,
+               dissect_krb5_PRIV_BODY_user_data },
+       { BER_CLASS_CON, 1, BER_FLAGS_OPTIONAL,
+               dissect_krb5_patimestamp },
+       { BER_CLASS_CON, 2, BER_FLAGS_OPTIONAL,
+               dissect_krb5_cusec },
+       { BER_CLASS_CON, 3, BER_FLAGS_OPTIONAL,
+               dissect_krb5_seq_number },
+       { BER_CLASS_CON, 4, 0,
+               dissect_krb5_s_address },
+       { BER_CLASS_CON, 5, BER_FLAGS_OPTIONAL,
+               dissect_krb5_HostAddresses },
+       { 0, 0, 0, NULL }
+};
+static int
+dissect_krb5_EncKrbPrivPart(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
+{
+       offset=dissect_ber_old_sequence(FALSE, actx, tree, tvb, offset, EncKrbPrivPart_sequence, hf_krb_EncKrbPrivPart, ett_krb_EncKrbPrivPart);
+
+       return offset;
+}
+
+static guint32 PRIV_etype;
+static int
+dissect_krb5_PRIV_etype(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
+{
+       offset=dissect_ber_integer(FALSE, actx, tree, tvb, offset, hf_krb_etype, &PRIV_etype);
+       if(tree){
+               proto_item_append_text(tree, " %s",
+                       val_to_str(PRIV_etype, krb5_encryption_types,
+                       "%#x"));
+       }
+       return offset;
+}
+
+#ifdef HAVE_KERBEROS
+static int
+dissect_krb5_decrypt_PRIV (proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
+{
+       guint8 *plaintext=NULL;
+       int length;
+
+       length=tvb_length_remaining(tvb, offset);
+
+       if(!plaintext){
+               plaintext=decrypt_krb5_data(tree, actx->pinfo, 13, length, tvb_get_ptr(tvb, offset, length), PRIV_etype);
+       }
+
+       if(plaintext){
+               tvbuff_t *next_tvb;
+               next_tvb = tvb_new_real_data (plaintext,
+                                          length,
+                                          length);
+               tvb_set_free_cb(next_tvb, g_free);
+               tvb_set_child_real_data_tvbuff(tvb, next_tvb);
+
+               /* Add the decrypted data to the data source list. */
+               add_new_data_source(actx->pinfo, next_tvb, "Decrypted Krb5");
+
+               offset=dissect_ber_old_choice(actx, tree, next_tvb, 0, kerberos_applications_choice, -1, -1, NULL);
+
+       }
+       return offset;
+}
+#endif
+
 /*
  * PRIV-BODY ::=   SEQUENCE {
  *  KRB-PRIV ::=         [APPLICATION 21] SEQUENCE {
@@ -2870,14 +3489,18 @@ dissect_krb5_Authenticator(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb,
  *  }
  */
 static int
-dissect_krb5_encrypted_PRIV(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_encrypted_PRIV(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_octet_string(FALSE, pinfo, tree, tvb, offset, hf_krb_encrypted_PRIV, NULL);
+#ifdef HAVE_KERBEROS
+       offset=dissect_ber_old_octet_string_wcb(FALSE, actx, tree, tvb, offset, hf_krb_encrypted_PRIV, dissect_krb5_decrypt_PRIV);
+#else
+       offset=dissect_ber_old_octet_string_wcb(FALSE, actx, tree, tvb, offset, hf_krb_encrypted_PRIV, NULL);
+#endif
        return offset;
 }
-static ber_sequence_t ENC_PRIV_sequence[] = {
+static ber_old_sequence_t ENC_PRIV_sequence[] = {
        { BER_CLASS_CON, 0, 0,
-               dissect_krb5_etype },
+               dissect_krb5_PRIV_etype },
        { BER_CLASS_CON, 1, BER_FLAGS_OPTIONAL,
                dissect_krb5_kvno },
        { BER_CLASS_CON, 2, 0,
@@ -2885,12 +3508,12 @@ static ber_sequence_t ENC_PRIV_sequence[] = {
        { 0, 0, 0, NULL }
 };
 static int
-dissect_krb5_ENC_PRIV(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_ENC_PRIV(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_sequence(FALSE, pinfo, tree, tvb, offset, ENC_PRIV_sequence, hf_krb_ENC_PRIV, ett_krb_PRIV_enc);
+       offset=dissect_ber_old_sequence(FALSE, actx, tree, tvb, offset, ENC_PRIV_sequence, hf_krb_ENC_PRIV, ett_krb_PRIV_enc);
        return offset;
 }
-static ber_sequence_t PRIV_BODY_sequence[] = {
+static ber_old_sequence_t PRIV_BODY_sequence[] = {
        { BER_CLASS_CON, 0, 0,
                dissect_krb5_pvno },
        { BER_CLASS_CON, 1, 0,
@@ -2900,38 +3523,189 @@ static ber_sequence_t PRIV_BODY_sequence[] = {
        { 0, 0, 0, NULL }
 };
 static int
-dissect_krb5_PRIV(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_PRIV(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
+{
+
+       offset=dissect_ber_old_sequence(FALSE, actx, tree, tvb, offset, PRIV_BODY_sequence, hf_krb_PRIV_BODY, ett_krb_PRIV);
+
+       return offset;
+}
+
+static guint32 EncKrbCredPart_etype;
+static int
+dissect_krb5_EncKrbCredPart_etype(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
+{
+       offset=dissect_ber_integer(FALSE, actx, tree, tvb, offset, hf_krb_etype, &EncKrbCredPart_etype);
+       if(tree){
+               proto_item_append_text(tree, " %s",
+                       val_to_str(EncKrbCredPart_etype, krb5_encryption_types,
+                       "%#x"));
+       }
+       return offset;
+}
+
+
+
+
+
+static ber_old_sequence_t KrbCredInfo_sequence[] = {
+       { BER_CLASS_CON, 0, 0, dissect_krb5_key },
+       { BER_CLASS_CON, 1, BER_FLAGS_OPTIONAL, dissect_krb5_prealm },
+       { BER_CLASS_CON, 2, BER_FLAGS_OPTIONAL, dissect_krb5_pname },
+       { BER_CLASS_CON, 3, BER_FLAGS_OPTIONAL, dissect_krb5_TicketFlags },
+       { BER_CLASS_CON, 4, BER_FLAGS_OPTIONAL, dissect_krb5_authtime },
+       { BER_CLASS_CON, 5, BER_FLAGS_OPTIONAL, dissect_krb5_starttime },
+       { BER_CLASS_CON, 6, BER_FLAGS_OPTIONAL, dissect_krb5_endtime },
+       { BER_CLASS_CON, 7, BER_FLAGS_OPTIONAL, dissect_krb5_renew_till },
+       { BER_CLASS_CON, 8, BER_FLAGS_OPTIONAL, dissect_krb5_srealm },
+       { BER_CLASS_CON, 9, BER_FLAGS_OPTIONAL, dissect_krb5_sname },
+       { BER_CLASS_CON, 10, BER_FLAGS_OPTIONAL, dissect_krb5_HostAddresses },
+       { 0, 0, 0, NULL }
+};
+static int
+dissect_krb5_KrbCredInfo(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
 
-       offset=dissect_ber_sequence(FALSE, pinfo, tree, tvb, offset, PRIV_BODY_sequence, hf_krb_PRIV_BODY, ett_krb_PRIV);
+       offset=dissect_ber_old_sequence(FALSE, actx, tree, tvb, offset, KrbCredInfo_sequence, hf_krb_KrbCredInfo, ett_krb_KrbCredInfo);
 
        return offset;
 }
 
+static ber_old_sequence_t KrbCredInfo_sequence_of[1] = {
+  { BER_CLASS_UNI, BER_UNI_TAG_SEQUENCE, BER_FLAGS_NOOWNTAG, dissect_krb5_KrbCredInfo },
+};
+static int
+dissect_krb5_KrbCredInfo_sequence_of(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
+{
+       offset=dissect_ber_old_sequence_of(FALSE, actx, tree, tvb, offset, KrbCredInfo_sequence_of, hf_krb_KrbCredInfos, ett_krb_KrbCredInfos);
 
+       return offset;
+}
+static const ber_old_sequence_t EncKrbCredPart_sequence[] = {
+       { BER_CLASS_CON, 0, 0, dissect_krb5_KrbCredInfo_sequence_of },
+       { BER_CLASS_CON, 1, BER_FLAGS_OPTIONAL, dissect_krb5_nonce },
+       { BER_CLASS_CON, 2, BER_FLAGS_OPTIONAL, dissect_krb5_ctime },
+       { BER_CLASS_CON, 3, BER_FLAGS_OPTIONAL, dissect_krb5_cusec },
+       { BER_CLASS_CON, 4, BER_FLAGS_OPTIONAL, dissect_krb5_s_address },
+       { BER_CLASS_CON, 5, BER_FLAGS_OPTIONAL, dissect_krb5_r_address },
+       { 0, 0, 0, NULL }
+};
+
+static int
+dissect_krb5_EncKrbCredPart(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
+{
+       offset=dissect_ber_old_sequence(FALSE, actx, tree, tvb, offset, EncKrbCredPart_sequence, hf_krb_EncKrbCredPart, ett_krb_EncKrbCredPart);
+
+       return offset;
+}
+
+#ifdef HAVE_KERBEROS
 static int
-dissect_krb5_SAFE_BODY_user_data(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_decrypt_EncKrbCredPart (proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
+{
+       guint8 *plaintext=NULL;
+       int length;
+
+       length=tvb_length_remaining(tvb, offset);
+
+       /* RFC4120 :
+        * EncKrbCredPart encrypted with usage
+        * == 14
+        */
+       if(!plaintext){
+               plaintext=decrypt_krb5_data(tree, actx->pinfo, 14, length, tvb_get_ptr(tvb, offset, length), EncKrbCredPart_etype);
+       }
+
+       if(plaintext){
+               tvbuff_t *next_tvb;
+               next_tvb = tvb_new_real_data (plaintext,
+                                          length,
+                                          length);
+               tvb_set_free_cb(next_tvb, g_free);
+               tvb_set_child_real_data_tvbuff(tvb, next_tvb);
+
+               /* Add the decrypted data to the data source list. */
+               add_new_data_source(actx->pinfo, next_tvb, "EncKrbCredPart");
+
+               offset=dissect_ber_old_choice(actx, tree, next_tvb, 0, kerberos_applications_choice, -1, -1, NULL);
+       }
+       return offset;
+}
+#endif
+
+static int
+dissect_krb5_encrypted_CRED_data(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
+{
+#ifdef HAVE_KERBEROS
+       offset=dissect_ber_old_octet_string_wcb(FALSE, actx, tree, tvb, offset, hf_krb_encrypted_EncKrbCredPart, dissect_krb5_decrypt_EncKrbCredPart);
+#else
+       offset=dissect_ber_old_octet_string_wcb(FALSE, actx, tree, tvb, offset, hf_krb_encrypted_EncKrbCredPart, NULL);
+#endif
+       return offset;
+}
+
+static ber_old_sequence_t encrypted_CRED_sequence[] = {
+       { BER_CLASS_CON, 0, 0,
+               dissect_krb5_EncKrbCredPart_etype },
+       { BER_CLASS_CON, 1, BER_FLAGS_OPTIONAL,
+               dissect_krb5_kvno },
+       { BER_CLASS_CON, 2, 0,
+               dissect_krb5_encrypted_CRED_data },
+       { 0, 0, 0, NULL }
+};
+static int
+dissect_krb5_encrypted_CRED(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
+{
+       offset=dissect_ber_old_sequence(FALSE, actx, tree, tvb, offset, encrypted_CRED_sequence, hf_krb_CRED_enc, ett_krb_CRED_enc);
+
+       return offset;
+}
+
+static ber_old_sequence_t CRED_BODY_sequence[] = {
+       { BER_CLASS_CON, 0, 0,
+               dissect_krb5_pvno },
+       { BER_CLASS_CON, 1, 0,
+               dissect_krb5_msg_type },
+       { BER_CLASS_CON, 2, 0,
+               dissect_krb5_sq_tickets },
+       { BER_CLASS_CON, 3, 0,
+               dissect_krb5_encrypted_CRED },
+       { 0, 0, 0, NULL }
+};
+static int
+dissect_krb5_CRED(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
+{
+
+       offset=dissect_ber_old_sequence(FALSE, actx, tree, tvb, offset, CRED_BODY_sequence, hf_krb_CRED_BODY, ett_krb_CRED);
+
+       return offset;
+}
+
+
+static int
+dissect_krb5_SAFE_BODY_user_data(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
        tvbuff_t *new_tvb;
-       offset=dissect_ber_octet_string(FALSE, pinfo, tree, tvb, offset, hf_krb_SAFE_BODY_user_data, &new_tvb);
-       call_kerberos_callbacks(pinfo, tree, new_tvb, KRB_CBTAG_SAFE_USER_DATA);
+       offset=dissect_ber_octet_string(FALSE, actx, tree, tvb, offset, hf_krb_SAFE_BODY_user_data, &new_tvb);
+       if (new_tvb)
+               call_kerberos_callbacks(actx->pinfo, tree, new_tvb, KRB_CBTAG_SAFE_USER_DATA);
        return offset;
 }
 static int
-dissect_krb5_SAFE_BODY_timestamp(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_SAFE_BODY_timestamp(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_GeneralizedTime(FALSE, pinfo, tree, tvb, offset, hf_krb_SAFE_BODY_timestamp);
+       offset=dissect_ber_GeneralizedTime(FALSE, actx, tree, tvb, offset, hf_krb_SAFE_BODY_timestamp);
        return offset;
 }
 
 static int
-dissect_krb5_SAFE_BODY_usec(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_SAFE_BODY_usec(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_integer(FALSE, pinfo, tree, tvb, offset, hf_krb_SAFE_BODY_usec, NULL);
+       offset=dissect_ber_integer(FALSE, actx, tree, tvb, offset, hf_krb_SAFE_BODY_usec, NULL);
        return offset;
 }
 
-static ber_sequence_t SAFE_BODY_sequence[] = {
+static ber_old_sequence_t SAFE_BODY_sequence[] = {
        { BER_CLASS_CON, 0, 0,
                dissect_krb5_SAFE_BODY_user_data },
        { BER_CLASS_CON, 1, BER_FLAGS_OPTIONAL,
@@ -2948,17 +3722,17 @@ static ber_sequence_t SAFE_BODY_sequence[] = {
        { 0, 0, 0, NULL }
 };
 static int
-dissect_krb5_SAFE_BODY(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_SAFE_BODY(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
 
-       offset=dissect_ber_sequence(FALSE, pinfo, tree, tvb, offset, SAFE_BODY_sequence, -1, -1);
+       offset=dissect_ber_old_sequence(FALSE, actx, tree, tvb, offset, SAFE_BODY_sequence, -1, -1);
 
        return offset;
 }
 
 
 
-static ber_sequence_t SAFE_sequence[] = {
+static ber_old_sequence_t SAFE_sequence[] = {
        { BER_CLASS_CON, 0, 0,
                dissect_krb5_pvno },
        { BER_CLASS_CON, 1, 0,
@@ -2970,14 +3744,97 @@ static ber_sequence_t SAFE_sequence[] = {
        { 0, 0, 0, NULL }
 };
 static int
-dissect_krb5_SAFE(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_SAFE(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
 
-       offset=dissect_ber_sequence(FALSE, pinfo, tree, tvb, offset, SAFE_sequence, -1, -1);
+       offset=dissect_ber_old_sequence(FALSE, actx, tree, tvb, offset, SAFE_sequence, -1, -1);
 
        return offset;
 }
 
+#ifdef HAVE_KERBEROS
+static guint32 enc_authorization_data_etype;
+
+static int
+dissect_krb5_decrypt_enc_authorization_data(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
+{
+       guint8 *plaintext=NULL;
+       int length;
+
+       length=tvb_length_remaining(tvb, offset);
+
+       /*
+       RFC 4120 : 5.4.1
+       The key usage value used when encrypting is 5
+       if a sub-session key is used, or 4 if the session key is used.
+       */
+       if(!plaintext){
+               plaintext=decrypt_krb5_data(tree, actx->pinfo, 4, length, tvb_get_ptr(tvb, offset, length), enc_authorization_data_etype);
+       }
+       if(!plaintext){
+               plaintext=decrypt_krb5_data(tree, actx->pinfo, 5, length, tvb_get_ptr(tvb, offset, length), enc_authorization_data_etype);
+       }
+
+       if(plaintext){
+               tvbuff_t *next_tvb;
+               next_tvb = tvb_new_real_data (plaintext,
+                                          length,
+                                          length);
+               tvb_set_free_cb(next_tvb, g_free);
+               tvb_set_child_real_data_tvbuff(tvb, next_tvb);
+
+               /* Add the decrypted data to the data source list. */
+               add_new_data_source(actx->pinfo, next_tvb, "Decrypted Krb5");
+
+
+               proto_tree_add_text(tree, next_tvb, 0, length, "AtuhorizationData for TGS_REQ not implemented yet");
+
+       }
+       return offset;
+}
+#endif
+
+static int
+dissect_krb5_encrypted_enc_authorization_data(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
+{
+#ifdef HAVE_KERBEROS
+       offset=dissect_ber_old_octet_string_wcb(FALSE, actx, tree, tvb, offset, hf_krb_encrypted_enc_authorization_data, dissect_krb5_decrypt_enc_authorization_data);
+#else
+       offset=dissect_ber_old_octet_string_wcb(FALSE, actx, tree, tvb, offset, hf_krb_encrypted_enc_authorization_data, NULL);
+#endif
+       return offset;
+}
+
+static int
+dissect_krb5_enc_authorization_data_etype(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
+{
+#ifndef HAVE_KERBEROS
+       guint32 enc_authorization_data_etype;
+#endif
+       offset=dissect_ber_integer(FALSE, actx, tree, tvb, offset, hf_krb_etype, &enc_authorization_data_etype);
+       if(tree){
+               proto_item_append_text(tree, " %s",
+                       val_to_str(enc_authorization_data_etype, krb5_encryption_types,
+                       "%#x"));
+       }
+       return offset;
+}
+static ber_old_sequence_t enc_authorization_data_sequence[] = {
+       { BER_CLASS_CON, 0, 0,
+               dissect_krb5_enc_authorization_data_etype },
+       { BER_CLASS_CON, 1, BER_FLAGS_OPTIONAL,
+               dissect_krb5_kvno },
+       { BER_CLASS_CON, 2, 0,
+               dissect_krb5_encrypted_enc_authorization_data },
+       { 0, 0, 0, NULL }
+};
+static int
+dissect_krb5_enc_authorization_data(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
+{
+       offset=dissect_ber_old_sequence(FALSE, actx, tree, tvb, offset, enc_authorization_data_sequence, -1, -1);
+
+       return offset;
+}
 
 /*
  * KDC-REQ-BODY ::=   SEQUENCE {
@@ -3000,7 +3857,7 @@ dissect_krb5_SAFE(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offse
  * }
  *
  */
-static ber_sequence_t KDC_REQ_BODY_sequence[] = {
+static ber_old_sequence_t KDC_REQ_BODY_sequence[] = {
        { BER_CLASS_CON, 0, 0,
                dissect_krb5_KDCOptions },
        { BER_CLASS_CON, 1, BER_FLAGS_OPTIONAL,
@@ -3026,11 +3883,14 @@ static ber_sequence_t KDC_REQ_BODY_sequence[] = {
                dissect_krb5_etype_sequence_of },
        { BER_CLASS_CON, 9, BER_FLAGS_OPTIONAL,
                dissect_krb5_HostAddresses },
-/* XXX [10] and [11] enc-authorization-data and additional-tickets should be added */
+       { BER_CLASS_CON, 10, BER_FLAGS_OPTIONAL,
+               dissect_krb5_enc_authorization_data },
+       { BER_CLASS_CON, 11, BER_FLAGS_OPTIONAL,
+               dissect_krb5_sq_tickets },
        { 0, 0, 0, NULL }
 };
 static int
-dissect_krb5_KDC_REQ_BODY(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_KDC_REQ_BODY(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
        conversation_t *conversation;
 
@@ -3042,17 +3902,17 @@ dissect_krb5_KDC_REQ_BODY(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, i
         * Ref: Section 7.2.1 of
         * http://www.ietf.org/internet-drafts/draft-ietf-krb-wg-kerberos-clarifications-07.txt
         */
-       if (pinfo->destport == UDP_PORT_KERBEROS && pinfo->ptype == PT_UDP) {
-               conversation = find_conversation(&pinfo->src, &pinfo->dst, PT_UDP,
-                       pinfo->srcport, 0, NO_PORT_B);
+       if (actx->pinfo->destport == UDP_PORT_KERBEROS && actx->pinfo->ptype == PT_UDP) {
+               conversation = find_conversation(actx->pinfo->fd->num, &actx->pinfo->src, &actx->pinfo->dst, PT_UDP,
+                       actx->pinfo->srcport, 0, NO_PORT_B);
                if (conversation == NULL) {
-                       conversation = conversation_new(&pinfo->src, &pinfo->dst, PT_UDP,
-                               pinfo->srcport, 0, NO_PORT2);
+                       conversation = conversation_new(actx->pinfo->fd->num, &actx->pinfo->src, &actx->pinfo->dst, PT_UDP,
+                               actx->pinfo->srcport, 0, NO_PORT2);
                        conversation_set_dissector(conversation, kerberos_handle_udp);
                }
        }
 
-       offset=dissect_ber_sequence(FALSE, pinfo, tree, tvb, offset, KDC_REQ_BODY_sequence, hf_krb_KDC_REQ_BODY, ett_krb_request);
+       offset=dissect_ber_old_sequence(FALSE, actx, tree, tvb, offset, KDC_REQ_BODY_sequence, hf_krb_KDC_REQ_BODY, ett_krb_request);
 
        return offset;
 }
@@ -3067,7 +3927,7 @@ dissect_krb5_KDC_REQ_BODY(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, i
  *          req-body[4]           KDC-REQ-BODY
  * }
  */
-static ber_sequence_t KDC_REQ_sequence[] = {
+static ber_old_sequence_t KDC_REQ_sequence[] = {
        { BER_CLASS_CON, 1, 0,
                dissect_krb5_pvno },
        { BER_CLASS_CON, 2, 0,
@@ -3079,9 +3939,9 @@ static ber_sequence_t KDC_REQ_sequence[] = {
        { 0, 0, 0, NULL }
 };
 static int
-dissect_krb5_KDC_REQ(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_KDC_REQ(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_sequence(FALSE, pinfo, tree, tvb, offset, KDC_REQ_sequence, -1, -1);
+       offset=dissect_ber_old_sequence(FALSE, actx, tree, tvb, offset, KDC_REQ_sequence, -1, -1);
 
        return offset;
 }
@@ -3089,7 +3949,7 @@ dissect_krb5_KDC_REQ(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int of
 
 #ifdef HAVE_KERBEROS
 static int
-dissect_krb5_decrypt_authenticator_data (packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_decrypt_authenticator_data (proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
        guint8 *plaintext=NULL;
        int length;
@@ -3103,10 +3963,10 @@ dissect_krb5_decrypt_authenticator_data (packet_info *pinfo, proto_tree *tree, t
         * == 11
         */
        if(!plaintext){
-               plaintext=decrypt_krb5_data(tree, pinfo, 7, length, tvb_get_ptr(tvb, offset, length), authenticator_etype);
+               plaintext=decrypt_krb5_data(tree, actx->pinfo, 7, length, tvb_get_ptr(tvb, offset, length), authenticator_etype);
        }
        if(!plaintext){
-               plaintext=decrypt_krb5_data(tree, pinfo, 11, length, tvb_get_ptr(tvb, offset, length), authenticator_etype);
+               plaintext=decrypt_krb5_data(tree, actx->pinfo, 11, length, tvb_get_ptr(tvb, offset, length), authenticator_etype);
        }
 
        if(plaintext){
@@ -3114,13 +3974,14 @@ dissect_krb5_decrypt_authenticator_data (packet_info *pinfo, proto_tree *tree, t
                next_tvb = tvb_new_real_data (plaintext,
                                           length,
                                           length);
+               tvb_set_free_cb(next_tvb, g_free);
                tvb_set_child_real_data_tvbuff(tvb, next_tvb);
 
                /* Add the decrypted data to the data source list. */
-               add_new_data_source(pinfo, next_tvb, "Decrypted Krb5");
+               add_new_data_source(actx->pinfo, next_tvb, "Decrypted Krb5");
 
 
-               offset=dissect_ber_choice(pinfo, tree, next_tvb, 0, kerberos_applications_choice, -1, -1);
+               offset=dissect_ber_old_choice(actx, tree, next_tvb, 0, kerberos_applications_choice, -1, -1, NULL);
 
        }
        return offset;
@@ -3136,16 +3997,16 @@ dissect_krb5_decrypt_authenticator_data (packet_info *pinfo, proto_tree *tree, t
  *  }
  */
 static int
-dissect_krb5_encrypted_authenticator_data(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_encrypted_authenticator_data(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
 #ifdef HAVE_KERBEROS
-       offset=dissect_ber_octet_string_wcb(FALSE, pinfo, tree, tvb, offset, hf_krb_encrypted_authenticator_data, dissect_krb5_decrypt_authenticator_data);
+       offset=dissect_ber_old_octet_string_wcb(FALSE, actx, tree, tvb, offset, hf_krb_encrypted_authenticator_data, dissect_krb5_decrypt_authenticator_data);
 #else
-       offset=dissect_ber_octet_string_wcb(FALSE, pinfo, tree, tvb, offset, hf_krb_encrypted_authenticator_data, NULL);
+       offset=dissect_ber_old_octet_string_wcb(FALSE, actx, tree, tvb, offset, hf_krb_encrypted_authenticator_data, NULL);
 #endif
        return offset;
 }
-static ber_sequence_t encrypted_authenticator_sequence[] = {
+static ber_old_sequence_t encrypted_authenticator_sequence[] = {
        { BER_CLASS_CON, 0, 0,
                dissect_krb5_authenticator_etype },
        { BER_CLASS_CON, 1, BER_FLAGS_OPTIONAL,
@@ -3155,9 +4016,9 @@ static ber_sequence_t encrypted_authenticator_sequence[] = {
        { 0, 0, 0, NULL }
 };
 static int
-dissect_krb5_encrypted_authenticator(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_encrypted_authenticator(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_sequence(FALSE, pinfo, tree, tvb, offset, encrypted_authenticator_sequence, hf_krb_authenticator_enc, ett_krb_authenticator_enc);
+       offset=dissect_ber_old_sequence(FALSE, actx, tree, tvb, offset, encrypted_authenticator_sequence, hf_krb_authenticator_enc, ett_krb_authenticator_enc);
 
        return offset;
 }
@@ -3166,16 +4027,16 @@ dissect_krb5_encrypted_authenticator(packet_info *pinfo, proto_tree *tree, tvbuf
 
 
 static int
-dissect_krb5_tkt_vno(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_tkt_vno(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_integer(FALSE, pinfo, tree, tvb, offset, hf_krb_tkt_vno, NULL);
+       offset=dissect_ber_integer(FALSE, actx, tree, tvb, offset, hf_krb_tkt_vno, NULL);
        return offset;
 }
 
 
 #ifdef HAVE_KERBEROS
 static int
-dissect_krb5_decrypt_Ticket_data (packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_decrypt_Ticket_data (proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
        guint8 *plaintext;
        int length;
@@ -3186,18 +4047,19 @@ dissect_krb5_decrypt_Ticket_data (packet_info *pinfo, proto_tree *tree, tvbuff_t
         * 7.5.1
         * All Ticket encrypted parts use usage == 2
         */
-       if( (plaintext=decrypt_krb5_data(tree, pinfo, 2, length, tvb_get_ptr(tvb, offset, length), Ticket_etype)) ){
+       if( (plaintext=decrypt_krb5_data(tree, actx->pinfo, 2, length, tvb_get_ptr(tvb, offset, length), Ticket_etype)) ){
                tvbuff_t *next_tvb;
                next_tvb = tvb_new_real_data (plaintext,
                                           length,
                                           length);
+               tvb_set_free_cb(next_tvb, g_free);
                tvb_set_child_real_data_tvbuff(tvb, next_tvb);
 
                /* Add the decrypted data to the data source list. */
-               add_new_data_source(pinfo, next_tvb, "Decrypted Krb5");
+               add_new_data_source(actx->pinfo, next_tvb, "Decrypted Krb5");
 
 
-               offset=dissect_ber_choice(pinfo, tree, next_tvb, 0, kerberos_applications_choice, -1, -1);
+               offset=dissect_ber_old_choice(actx, tree, next_tvb, 0, kerberos_applications_choice, -1, -1, NULL);
 
        }
        return offset;
@@ -3205,16 +4067,16 @@ dissect_krb5_decrypt_Ticket_data (packet_info *pinfo, proto_tree *tree, tvbuff_t
 #endif
 
 static int
-dissect_krb5_encrypted_Ticket_data(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_encrypted_Ticket_data(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
 #ifdef HAVE_KERBEROS
-       offset=dissect_ber_octet_string_wcb(FALSE, pinfo, tree, tvb, offset, hf_krb_encrypted_Ticket_data, dissect_krb5_decrypt_Ticket_data);
+       offset=dissect_ber_old_octet_string_wcb(FALSE, actx, tree, tvb, offset, hf_krb_encrypted_Ticket_data, dissect_krb5_decrypt_Ticket_data);
 #else
-       offset=dissect_ber_octet_string_wcb(FALSE, pinfo, tree, tvb, offset, hf_krb_encrypted_Ticket_data, NULL);
+       offset=dissect_ber_old_octet_string_wcb(FALSE, actx, tree, tvb, offset, hf_krb_encrypted_Ticket_data, NULL);
 #endif
        return offset;
 }
-static ber_sequence_t encrypted_Ticket_sequence[] = {
+static ber_old_sequence_t encrypted_Ticket_sequence[] = {
        { BER_CLASS_CON, 0, 0,
                dissect_krb5_Ticket_etype },
        { BER_CLASS_CON, 1, BER_FLAGS_OPTIONAL,
@@ -3224,14 +4086,14 @@ static ber_sequence_t encrypted_Ticket_sequence[] = {
        { 0, 0, 0, NULL }
 };
 static int
-dissect_krb5_Ticket_encrypted(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_Ticket_encrypted(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_sequence(FALSE, pinfo, tree, tvb, offset, encrypted_Ticket_sequence, hf_krb_ticket_enc, ett_krb_ticket_enc);
+       offset=dissect_ber_old_sequence(FALSE, actx, tree, tvb, offset, encrypted_Ticket_sequence, hf_krb_ticket_enc, ett_krb_ticket_enc);
 
        return offset;
 }
 
-static ber_sequence_t Application_1_sequence[] = {
+static ber_old_sequence_t Application_1_sequence[] = {
        { BER_CLASS_CON, 0, 0,
                dissect_krb5_tkt_vno },
        { BER_CLASS_CON, 1, 0,
@@ -3243,24 +4105,24 @@ static ber_sequence_t Application_1_sequence[] = {
        { 0, 0, 0, NULL }
 };
 static int
-dissect_krb5_Application_1(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_Application_1(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_sequence(FALSE, pinfo, tree, tvb, offset, Application_1_sequence, hf_krb_ticket, ett_krb_ticket);
+       offset=dissect_ber_old_sequence(FALSE, actx, tree, tvb, offset, Application_1_sequence, hf_krb_ticket, ett_krb_ticket);
 
        return offset;
 }
 
 
 
-static const ber_choice_t Ticket_choice[] = {
+static const ber_old_choice_t Ticket_choice[] = {
        { 1, BER_CLASS_APP, 1,  0,
                dissect_krb5_Application_1 },
        { 0, 0, 0, 0, NULL }
 };
 static int
-dissect_krb5_Ticket(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_Ticket(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_choice(pinfo, tree, tvb, offset, Ticket_choice, -1, -1);
+       offset=dissect_ber_old_choice(actx, tree, tvb, offset, Ticket_choice, -1, -1, NULL);
 
        return offset;
 }
@@ -3277,7 +4139,7 @@ dissect_krb5_Ticket(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int off
  *                  authenticator[4]              EncryptedData
  *  }
  */
-static ber_sequence_t AP_REQ_sequence[] = {
+static ber_old_sequence_t AP_REQ_sequence[] = {
        { BER_CLASS_CON, 0, 0,
                dissect_krb5_pvno },
        { BER_CLASS_CON, 1, 0,
@@ -3291,9 +4153,9 @@ static ber_sequence_t AP_REQ_sequence[] = {
        { 0, 0, 0, NULL }
 };
 static int
-dissect_krb5_AP_REQ(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_AP_REQ(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_sequence(FALSE, pinfo, tree, tvb, offset, AP_REQ_sequence, -1, -1);
+       offset=dissect_ber_old_sequence(FALSE, actx, tree, tvb, offset, AP_REQ_sequence, -1, -1);
 
        return offset;
 }
@@ -3303,7 +4165,7 @@ dissect_krb5_AP_REQ(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int off
 
 #ifdef HAVE_KERBEROS
 static int
-dissect_krb5_decrypt_AP_REP_data(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_decrypt_AP_REP_data(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
        guint8 *plaintext=NULL;
        int length;
@@ -3317,7 +4179,7 @@ dissect_krb5_decrypt_AP_REP_data(packet_info *pinfo, proto_tree *tree, tvbuff_t
         * == 11
         */
        if(!plaintext){
-               plaintext=decrypt_krb5_data(tree, pinfo, 12, length, tvb_get_ptr(tvb, offset, length), AP_REP_etype);
+               plaintext=decrypt_krb5_data(tree, actx->pinfo, 12, length, tvb_get_ptr(tvb, offset, length), AP_REP_etype);
        }
 
        if(plaintext){
@@ -3325,13 +4187,14 @@ dissect_krb5_decrypt_AP_REP_data(packet_info *pinfo, proto_tree *tree, tvbuff_t
                next_tvb = tvb_new_real_data (plaintext,
                                           length,
                                           length);
+               tvb_set_free_cb(next_tvb, g_free);
                tvb_set_child_real_data_tvbuff(tvb, next_tvb);
 
                /* Add the decrypted data to the data source list. */
-               add_new_data_source(pinfo, next_tvb, "Decrypted Krb5");
+               add_new_data_source(actx->pinfo, next_tvb, "Decrypted Krb5");
 
 
-               offset=dissect_ber_choice(pinfo, tree, next_tvb, 0, kerberos_applications_choice, -1, -1);
+               offset=dissect_ber_old_choice(actx, tree, next_tvb, 0, kerberos_applications_choice, -1, -1, NULL);
 
        }
        return offset;
@@ -3340,16 +4203,16 @@ dissect_krb5_decrypt_AP_REP_data(packet_info *pinfo, proto_tree *tree, tvbuff_t
 
 
 static int
-dissect_krb5_encrypted_AP_REP_data(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_encrypted_AP_REP_data(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
 #ifdef HAVE_KERBEROS
-       offset=dissect_ber_octet_string_wcb(FALSE, pinfo, tree, tvb, offset, hf_krb_encrypted_AP_REP_data, dissect_krb5_decrypt_AP_REP_data);
+       offset=dissect_ber_old_octet_string_wcb(FALSE, actx, tree, tvb, offset, hf_krb_encrypted_AP_REP_data, dissect_krb5_decrypt_AP_REP_data);
 #else
-       offset=dissect_ber_octet_string_wcb(FALSE, pinfo, tree, tvb, offset, hf_krb_encrypted_AP_REP_data, NULL);
+       offset=dissect_ber_old_octet_string_wcb(FALSE, actx, tree, tvb, offset, hf_krb_encrypted_AP_REP_data, NULL);
 #endif
        return offset;
 }
-static ber_sequence_t encrypted_AP_REP_sequence[] = {
+static ber_old_sequence_t encrypted_AP_REP_sequence[] = {
        { BER_CLASS_CON, 0, 0,
                dissect_krb5_AP_REP_etype },
        { BER_CLASS_CON, 1, BER_FLAGS_OPTIONAL,
@@ -3359,9 +4222,9 @@ static ber_sequence_t encrypted_AP_REP_sequence[] = {
        { 0, 0, 0, NULL }
 };
 static int
-dissect_krb5_encrypted_AP_REP(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_encrypted_AP_REP(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_sequence(FALSE, pinfo, tree, tvb, offset, encrypted_AP_REP_sequence, hf_krb_AP_REP_enc, ett_krb_AP_REP_enc);
+       offset=dissect_ber_old_sequence(FALSE, actx, tree, tvb, offset, encrypted_AP_REP_sequence, hf_krb_AP_REP_enc, ett_krb_AP_REP_enc);
 
        return offset;
 }
@@ -3373,7 +4236,7 @@ dissect_krb5_encrypted_AP_REP(packet_info *pinfo, proto_tree *tree, tvbuff_t *tv
  *             enc-part[2]               EncryptedData
  *  }
  */
-static ber_sequence_t AP_REP_sequence[] = {
+static ber_old_sequence_t AP_REP_sequence[] = {
        { BER_CLASS_CON, 0, 0,
                dissect_krb5_pvno },
        { BER_CLASS_CON, 1, 0,
@@ -3383,9 +4246,9 @@ static ber_sequence_t AP_REP_sequence[] = {
        { 0, 0, 0, NULL }
 };
 static int
-dissect_krb5_AP_REP(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_AP_REP(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_sequence(FALSE, pinfo, tree, tvb, offset, AP_REP_sequence, -1, -1);
+       offset=dissect_ber_old_sequence(FALSE, actx, tree, tvb, offset, AP_REP_sequence, -1, -1);
 
        return offset;
 }
@@ -3396,9 +4259,9 @@ dissect_krb5_AP_REP(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int off
 
 static guint32 KDC_REP_etype;
 static int
-dissect_krb5_KDC_REP_etype(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_KDC_REP_etype(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_integer(FALSE, pinfo, tree, tvb, offset, hf_krb_etype, &KDC_REP_etype);
+       offset=dissect_ber_integer(FALSE, actx, tree, tvb, offset, hf_krb_etype, &KDC_REP_etype);
        if(tree){
                proto_item_append_text(tree, " %s",
                        val_to_str(KDC_REP_etype, krb5_encryption_types,
@@ -3409,7 +4272,7 @@ dissect_krb5_KDC_REP_etype(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb,
 
 #ifdef HAVE_KERBEROS
 static int
-dissect_krb5_decrypt_KDC_REP_data (packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_decrypt_KDC_REP_data (proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
        guint8 *plaintext=NULL;
        int length;
@@ -3421,16 +4284,16 @@ dissect_krb5_decrypt_KDC_REP_data (packet_info *pinfo, proto_tree *tree, tvbuff_
         * ASREP/TGSREP encryptedparts are encrypted with usage
         * == 3 or
         * == 8 or
-         * == 9
+     * == 9
         */
        if(!plaintext){
-               plaintext=decrypt_krb5_data(tree, pinfo, 3, length, tvb_get_ptr(tvb, offset, length), KDC_REP_etype);
+               plaintext=decrypt_krb5_data(tree, actx->pinfo, 3, length, tvb_get_ptr(tvb, offset, length), KDC_REP_etype);
        }
        if(!plaintext){
-               plaintext=decrypt_krb5_data(tree, pinfo, 8, length, tvb_get_ptr(tvb, offset, length), KDC_REP_etype);
+               plaintext=decrypt_krb5_data(tree, actx->pinfo, 8, length, tvb_get_ptr(tvb, offset, length), KDC_REP_etype);
        }
        if(!plaintext){
-               plaintext=decrypt_krb5_data(tree, pinfo, 9, length, tvb_get_ptr(tvb, offset, length), KDC_REP_etype);
+               plaintext=decrypt_krb5_data(tree, actx->pinfo, 9, length, tvb_get_ptr(tvb, offset, length), KDC_REP_etype);
        }
 
        if(plaintext){
@@ -3438,13 +4301,14 @@ dissect_krb5_decrypt_KDC_REP_data (packet_info *pinfo, proto_tree *tree, tvbuff_
                next_tvb = tvb_new_real_data (plaintext,
                                           length,
                                           length);
+               tvb_set_free_cb(next_tvb, g_free);
                tvb_set_child_real_data_tvbuff(tvb, next_tvb);
 
                /* Add the decrypted data to the data source list. */
-               add_new_data_source(pinfo, next_tvb, "Decrypted Krb5");
+               add_new_data_source(actx->pinfo, next_tvb, "Decrypted Krb5");
 
 
-               offset=dissect_ber_choice(pinfo, tree, next_tvb, 0, kerberos_applications_choice, -1, -1);
+               offset=dissect_ber_old_choice(actx, tree, next_tvb, 0, kerberos_applications_choice, -1, -1, NULL);
 
        }
        return offset;
@@ -3453,16 +4317,16 @@ dissect_krb5_decrypt_KDC_REP_data (packet_info *pinfo, proto_tree *tree, tvbuff_
 
 
 static int
-dissect_krb5_encrypted_KDC_REP_data(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_encrypted_KDC_REP_data(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
 #ifdef HAVE_KERBEROS
-       offset=dissect_ber_octet_string_wcb(FALSE, pinfo, tree, tvb, offset, hf_krb_encrypted_KDC_REP_data, dissect_krb5_decrypt_KDC_REP_data);
+       offset=dissect_ber_old_octet_string_wcb(FALSE, actx, tree, tvb, offset, hf_krb_encrypted_KDC_REP_data, dissect_krb5_decrypt_KDC_REP_data);
 #else
-       offset=dissect_ber_octet_string_wcb(FALSE, pinfo, tree, tvb, offset, hf_krb_encrypted_KDC_REP_data, NULL);
+       offset=dissect_ber_old_octet_string_wcb(FALSE, actx, tree, tvb, offset, hf_krb_encrypted_KDC_REP_data, NULL);
 #endif
        return offset;
 }
-static ber_sequence_t encrypted_KDC_REP_sequence[] = {
+static ber_old_sequence_t encrypted_KDC_REP_sequence[] = {
        { BER_CLASS_CON, 0, 0,
                dissect_krb5_KDC_REP_etype },
        { BER_CLASS_CON, 1, BER_FLAGS_OPTIONAL,
@@ -3472,9 +4336,9 @@ static ber_sequence_t encrypted_KDC_REP_sequence[] = {
        { 0, 0, 0, NULL }
 };
 static int
-dissect_krb5_encrypted_KDC_REP(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_encrypted_KDC_REP(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_sequence(FALSE, pinfo, tree, tvb, offset, encrypted_KDC_REP_sequence, hf_krb_KDC_REP_enc, ett_krb_KDC_REP_enc);
+       offset=dissect_ber_old_sequence(FALSE, actx, tree, tvb, offset, encrypted_KDC_REP_sequence, hf_krb_KDC_REP_enc, ett_krb_KDC_REP_enc);
 
        return offset;
 }
@@ -3490,7 +4354,7 @@ dissect_krb5_encrypted_KDC_REP(packet_info *pinfo, proto_tree *tree, tvbuff_t *t
  *                enc-part[6]                EncryptedData
  *  }
  */
-static ber_sequence_t KDC_REP_sequence[] = {
+static ber_old_sequence_t KDC_REP_sequence[] = {
        { BER_CLASS_CON, 0, 0,
                dissect_krb5_pvno },
        { BER_CLASS_CON, 1, 0,
@@ -3508,9 +4372,9 @@ static ber_sequence_t KDC_REP_sequence[] = {
        { 0, 0, 0, NULL }
 };
 static int
-dissect_krb5_KDC_REP(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_KDC_REP(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_sequence(FALSE, pinfo, tree, tvb, offset, KDC_REP_sequence, -1, -1);
+       offset=dissect_ber_old_sequence(FALSE, actx, tree, tvb, offset, KDC_REP_sequence, -1, -1);
 
        return offset;
 }
@@ -3519,22 +4383,33 @@ dissect_krb5_KDC_REP(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int of
 
 
 static int
-dissect_krb5_e_text(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_e_text(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_GeneralString(pinfo, tree, tvb, offset, hf_krb_e_text, NULL, 0);
+       offset=dissect_ber_GeneralString(actx, tree, tvb, offset, hf_krb_e_text, NULL, 0);
        return offset;
 }
 
 static int
-dissect_krb5_e_data(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_e_data(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
        switch(krb5_errorcode){
+       case KRB5_ET_KRB5KDC_ERR_BADOPTION:
+       case KRB5_ET_KRB5KDC_ERR_CLIENT_REVOKED:
+       case KRB5_ET_KRB5KDC_ERR_KEY_EXP:
+       case KRB5_ET_KRB5KDC_ERR_POLICY:
+               /* ms windows kdc sends e-data of this type containing a "salt"
+                * that contains the nt_status code for these error codes.
+                */
+               offset=dissect_ber_old_octet_string_wcb(FALSE, actx, tree, tvb, offset, hf_krb_e_data, dissect_krb5_PA_DATA);
+               break;
        case KRB5_ET_KRB5KDC_ERR_PREAUTH_REQUIRED:
-               offset=dissect_ber_octet_string_wcb(FALSE, pinfo, tree, tvb, offset, hf_krb_e_data, dissect_krb5_padata);
+       case KRB5_ET_KRB5KDC_ERR_PREAUTH_FAILED:
+       case KRB5_ET_KRB5KDC_ERR_ETYPE_NOSUPP:
+               offset=dissect_ber_old_octet_string_wcb(FALSE, actx, tree, tvb, offset, hf_krb_e_data, dissect_krb5_padata);
 
                break;
        default:
-               offset=dissect_ber_octet_string(FALSE, pinfo, tree, tvb, offset, hf_krb_e_data, NULL);
+               offset=dissect_ber_octet_string(FALSE, actx, tree, tvb, offset, hf_krb_e_data, NULL);
        }
        return offset;
 }
@@ -3544,9 +4419,9 @@ dissect_krb5_e_data(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int off
  * PacketCable still use.
  */
 static int
-dissect_krb5_e_checksum(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+dissect_krb5_e_checksum(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_sequence(FALSE, pinfo, tree, tvb, offset, Checksum_sequence, hf_krb_e_checksum, ett_krb_e_checksum);
+       offset=dissect_ber_old_sequence(FALSE, actx, tree, tvb, offset, Checksum_sequence, hf_krb_e_checksum, ett_krb_e_checksum);
 
        return offset;
 }
@@ -3577,7 +4452,7 @@ dissect_krb5_e_checksum(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int
  *            authentication method and optionally containing data for
  *            the method:
  */
-static ber_sequence_t ERROR_sequence[] = {
+static ber_old_sequence_t ERROR_sequence[] = {
        { BER_CLASS_CON, 0, 0,
                dissect_krb5_pvno },
        { BER_CLASS_CON, 1, 0,
@@ -3608,56 +4483,76 @@ static ber_sequence_t ERROR_sequence[] = {
                dissect_krb5_e_checksum }, /* used by PacketCable */
        { 0, 0, 0, NULL }
 };
-static int
-dissect_krb5_ERROR(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int offset)
+int
+dissect_krb5_ERROR(proto_tree *tree, tvbuff_t *tvb, int offset, asn1_ctx_t *actx _U_)
 {
-       offset=dissect_ber_sequence(FALSE, pinfo, tree, tvb, offset, ERROR_sequence, -1, -1);
+       offset=dissect_ber_old_sequence(FALSE, actx, tree, tvb, offset, ERROR_sequence, -1, -1);
 
        return offset;
 }
 
 
 
-static struct { char *set; char *unset; } bitval = { "Set", "Not set" };
+static struct { const char *set; const char *unset; } bitval = { "Set", "Not set" };
 
-static void dissect_kerberos_udp(tvbuff_t *tvb, packet_info *pinfo,
+static gint dissect_kerberos_udp(tvbuff_t *tvb, packet_info *pinfo,
                                 proto_tree *tree);
 static void dissect_kerberos_tcp(tvbuff_t *tvb, packet_info *pinfo,
                                 proto_tree *tree);
 static gint dissect_kerberos_common(tvbuff_t *tvb, packet_info *pinfo,
-                                       proto_tree *tree, int do_col_info,
+                                       proto_tree *tree, gboolean do_col_info,
+                                       gboolean do_col_protocol,
                                        gboolean have_rm,
                                        kerberos_callbacks *cb);
-static gint kerberos_rm_to_reclen(guint krb_rm);
 static void dissect_kerberos_tcp_pdu(tvbuff_t *tvb, packet_info *pinfo,
                                proto_tree *tree);
-static guint get_krb_pdu_len(tvbuff_t *tvb, int offset);
-
 
 
 gint
 dissect_kerberos_main(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, int do_col_info, kerberos_callbacks *cb)
 {
-    return (dissect_kerberos_common(tvb, pinfo, tree, do_col_info, FALSE, cb));
+    return (dissect_kerberos_common(tvb, pinfo, tree, do_col_info, FALSE, FALSE, cb));
 }
 
-static void
+guint32
+kerberos_output_keytype(void)
+{
+  return keytype;
+}
+
+static gint
 dissect_kerberos_udp(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
 {
-    if (check_col(pinfo->cinfo, COL_PROTOCOL))
-        col_set_str(pinfo->cinfo, COL_PROTOCOL, "KRB5");
+    /* Some weird kerberos implementation apparently do krb4 on the krb5 port.
+       Since all (except weirdo transarc krb4 stuff) use
+       an opcode <=16 in the first byte, use this to see if it might
+       be krb4.
+       All krb5 commands start with an APPL tag and thus is >=0x60
+       so if first byte is <=16  just blindly assume it is krb4 then
+    */
+    if(tvb_length(tvb) >= 1 && tvb_get_guint8(tvb, 0)<=0x10){
+      if(krb4_handle){
+       gboolean res;
+
+       res=call_dissector_only(krb4_handle, tvb, pinfo, tree);
+       return res;
+      }else{
+        return 0;
+      }
+    }
 
-    (void)dissect_kerberos_common(tvb, pinfo, tree, TRUE, FALSE, NULL);
+
+    return dissect_kerberos_common(tvb, pinfo, tree, TRUE, TRUE, FALSE, NULL);
 }
 
-static gint
+gint
 kerberos_rm_to_reclen(guint krb_rm)
 {
     return (krb_rm & KRB_RM_RECLEN);
 }
 
-static guint
-get_krb_pdu_len(tvbuff_t *tvb, int offset)
+guint
+get_krb_pdu_len(packet_info *pinfo _U_, tvbuff_t *tvb, int offset)
 {
     guint krb_rm;
     gint pdulen;
@@ -3671,7 +4566,7 @@ static void
 dissect_kerberos_tcp_pdu(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
 {
     pinfo->fragmented = TRUE;
-    if (dissect_kerberos_common(tvb, pinfo, tree, TRUE, TRUE, NULL) < 0) {
+    if (dissect_kerberos_common(tvb, pinfo, tree, TRUE, TRUE, TRUE, NULL) < 0) {
        /*
         * The dissector failed to recognize this as a valid
         * Kerberos message.  Mark it as a continuation packet.
@@ -3687,6 +4582,8 @@ dissect_kerberos_tcp(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
 {
     if (check_col(pinfo->cinfo, COL_PROTOCOL))
         col_set_str(pinfo->cinfo, COL_PROTOCOL, "KRB5");
+    if (check_col(pinfo->cinfo, COL_INFO))
+        col_clear(pinfo->cinfo, COL_INFO);
 
     tcp_dissect_pdus(tvb, pinfo, tree, krb_desegment, 4, get_krb_pdu_len,
        dissect_kerberos_tcp_pdu);
@@ -3695,7 +4592,7 @@ dissect_kerberos_tcp(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
 /*
  * Display the TCP record mark.
  */
-static void
+void
 show_krb_recordmark(proto_tree *tree, tvbuff_t *tvb, gint start, guint32 krb_rm)
 {
     gint rec_len;
@@ -3716,12 +4613,14 @@ show_krb_recordmark(proto_tree *tree, tvbuff_t *tvb, gint start, guint32 krb_rm)
 
 static gint
 dissect_kerberos_common(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree,
-    int dci, gboolean have_rm, kerberos_callbacks *cb)
+    gboolean dci, gboolean do_col_protocol, gboolean have_rm,
+    kerberos_callbacks *cb)
 {
-    int offset = 0;
-    proto_tree *kerberos_tree = NULL;
-    proto_item *item = NULL;
+    volatile int offset = 0;
+    proto_tree *volatile kerberos_tree = NULL;
+    proto_item *volatile item = NULL;
     void *saved_private_data;
+       asn1_ctx_t asn1_ctx;
 
     /* TCP record mark and length */
     guint32 krb_rm = 0;
@@ -3731,11 +4630,6 @@ dissect_kerberos_common(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree,
     pinfo->private_data=cb;
     do_col_info=dci;
 
-    if (tree) {
-        item = proto_tree_add_item(tree, proto_kerberos, tvb, 0, -1, FALSE);
-        kerberos_tree = proto_item_add_subtree(item, ett_krb_kerberos);
-    }
-
     if (have_rm) {
        krb_rm = tvb_get_ntohl(tvb, offset);
        krb_reclen = kerberos_rm_to_reclen(krb_rm);
@@ -3746,18 +4640,83 @@ dissect_kerberos_common(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree,
            pinfo->private_data=saved_private_data;
            return (-1);
        }
+       if (do_col_protocol) {
+            if (check_col(pinfo->cinfo, COL_PROTOCOL))
+                col_set_str(pinfo->cinfo, COL_PROTOCOL, "KRB5");
+       }
+        if (tree) {
+            item = proto_tree_add_item(tree, proto_kerberos, tvb, 0, -1, FALSE);
+            kerberos_tree = proto_item_add_subtree(item, ett_krb_kerberos);
+        }
        show_krb_recordmark(kerberos_tree, tvb, offset, krb_rm);
        offset += 4;
+    } else {
+        /* Do some sanity checking here,
+         * All krb5 packets start with a TAG class that is BER_CLASS_APP
+         * and a tag value that is either of the values below:
+         * If it doesnt look like kerberos, return 0 and let someone else have
+         * a go at it.
+         */
+        gint8 tmp_class;
+        gboolean tmp_pc;
+        gint32 tmp_tag;
+
+       get_ber_identifier(tvb, offset, &tmp_class, &tmp_pc, &tmp_tag);
+        if(tmp_class!=BER_CLASS_APP){
+           pinfo->private_data=saved_private_data;
+            return 0;
+        }
+        switch(tmp_tag){
+            case KRB5_MSG_TICKET:
+            case KRB5_MSG_AUTHENTICATOR:
+            case KRB5_MSG_ENC_TICKET_PART:
+            case KRB5_MSG_AS_REQ:
+            case KRB5_MSG_AS_REP:
+            case KRB5_MSG_TGS_REQ:
+            case KRB5_MSG_TGS_REP:
+            case KRB5_MSG_AP_REQ:
+            case KRB5_MSG_AP_REP:
+            case KRB5_MSG_ENC_AS_REP_PART:
+            case KRB5_MSG_ENC_TGS_REP_PART:
+            case KRB5_MSG_ENC_AP_REP_PART:
+            case KRB5_MSG_ENC_KRB_PRIV_PART:
+            case KRB5_MSG_ENC_KRB_CRED_PART:
+            case KRB5_MSG_SAFE:
+            case KRB5_MSG_PRIV:
+            case KRB5_MSG_ERROR:
+                break;
+            default:
+                pinfo->private_data=saved_private_data;
+                return 0;
+        }
+       if (do_col_protocol) {
+            if (check_col(pinfo->cinfo, COL_PROTOCOL))
+                col_set_str(pinfo->cinfo, COL_PROTOCOL, "KRB5");
+       }
+       if (do_col_info) {
+            if (check_col(pinfo->cinfo, COL_INFO))
+                col_clear(pinfo->cinfo, COL_INFO);
+        }
+        if (tree) {
+            item = proto_tree_add_item(tree, proto_kerberos, tvb, 0, -1, FALSE);
+            kerberos_tree = proto_item_add_subtree(item, ett_krb_kerberos);
+        }
     }
+       asn1_ctx_init(&asn1_ctx, ASN1_ENC_BER, TRUE, pinfo);
 
-    offset=dissect_ber_choice(pinfo, kerberos_tree, tvb, offset, kerberos_applications_choice, -1, -1);
+    TRY {
+       offset=dissect_ber_old_choice(&asn1_ctx, kerberos_tree, tvb, offset, kerberos_applications_choice, -1, -1, NULL);
+    } CATCH_ALL {
+       pinfo->private_data=saved_private_data;
+       RETHROW;
+    } ENDTRY;
 
     proto_item_set_len(item, offset);
     pinfo->private_data=saved_private_data;
     return offset;
 }
 
-void
+static void
 kerberos_prefs_apply_cb(void) {
 #ifdef HAVE_LIBNETTLE
        clear_keytab();
@@ -3817,6 +4776,9 @@ proto_register_kerberos(void)
        { &hf_krb_address_ip, {
            "IP Address", "kerberos.addr_ip", FT_IPv4, BASE_NONE,
            NULL, 0, "IP Address", HFILL }},
+       { &hf_krb_address_ipv6, {
+           "IPv6 Address", "kerberos.addr_ipv6", FT_IPv6, BASE_NONE,
+           NULL, 0, "IPv6 Address", HFILL }},
        { &hf_krb_address_netbios, {
            "NetBIOS Address", "kerberos.addr_nb", FT_STRING, BASE_NONE,
            NULL, 0, "NetBIOS Address and type", HFILL }},
@@ -3883,9 +4845,18 @@ proto_register_kerberos(void)
        { &hf_krb_e_text, {
            "e-text", "kerberos.e_text", FT_STRING, BASE_NONE,
            NULL, 0, "Additional (human readable) error description", HFILL }},
+       { &hf_krb_s4u2self_auth, {
+           "S4U2Self Auth", "kerberos.s4u2self.auth", FT_STRING, BASE_NONE,
+           NULL, 0, "S4U2Self authentication string", HFILL }},
        { &hf_krb_realm, {
            "Realm", "kerberos.realm", FT_STRING, BASE_NONE,
            NULL, 0, "Name of the Kerberos Realm", HFILL }},
+       { &hf_krb_srealm, {
+           "SRealm", "kerberos.srealm", FT_STRING, BASE_NONE,
+           NULL, 0, "Name of the Kerberos SRealm", HFILL }},
+       { &hf_krb_prealm, {
+           "Delegated Principal Realm", "kerberos.prealm", FT_STRING, BASE_NONE,
+           NULL, 0, "Name of the Kerberos PRealm", HFILL }},
        { &hf_krb_crealm, {
            "Client Realm", "kerberos.crealm", FT_STRING, BASE_NONE,
            NULL, 0, "Name of the Clients Kerberos Realm", HFILL }},
@@ -3955,6 +4926,9 @@ proto_register_kerberos(void)
        { &hf_krb_PRIV_BODY, {
            "PRIV_BODY", "kerberos.priv_body", FT_NONE, BASE_NONE,
            NULL, 0, "Kerberos PRIVate BODY", HFILL }},
+       { &hf_krb_CRED_BODY, {
+           "CRED_BODY", "kerberos.cred_body", FT_NONE, BASE_NONE,
+           NULL, 0, "Kerberos CREDential BODY", HFILL }},
        { &hf_krb_encrypted_PRIV, {
            "Encrypted PRIV", "kerberos.enc_priv", FT_NONE, BASE_NONE,
            NULL, 0, "Kerberos Encrypted PRIVate blob data", HFILL }},
@@ -3979,6 +4953,9 @@ proto_register_kerberos(void)
        { &hf_krb_KDCOptions_renewable, {
            "Renewable", "kerberos.kdcoptions.renewable", FT_BOOLEAN, 32,
            TFS(&krb5_kdcoptions_renewable), 0x00800000, "Whether this ticket is renewable or not", HFILL }},
+       { &hf_krb_KDCOptions_constrained_delegation, {
+           "Constrained Delegation", "kerberos.kdcoptions.constrained_delegation", FT_BOOLEAN, 32,
+           TFS(&krb5_kdcoptions_constrained_delegation), 0x00020000, "Do we want a PAC containing constrained delegation info or not", HFILL }},
        { &hf_krb_KDCOptions_canonicalize, {
            "Canonicalize", "kerberos.kdcoptions.canonicalize", FT_BOOLEAN, 32,
            TFS(&krb5_kdcoptions_canonicalize), 0x00010000, "Do we want the KDC to canonicalize the principal or not", HFILL }},
@@ -4015,9 +4992,15 @@ proto_register_kerberos(void)
        { &hf_krb_encrypted_authenticator_data, {
            "Authenticator data", "kerberos.authenticator.data", FT_BYTES, BASE_HEX,
            NULL, 0, "Data content of an encrypted authenticator", HFILL }},
+       { &hf_krb_encrypted_EncKrbCredPart, {
+           "enc EncKrbCredPart", "kerberos.EncKrbCredPart.encrypted", FT_BYTES, BASE_HEX,
+           NULL, 0, "Encrypted EncKrbCredPart blob", HFILL }},
        { &hf_krb_encrypted_PA_ENC_TIMESTAMP, {
            "enc PA_ENC_TIMESTAMP", "kerberos.PA_ENC_TIMESTAMP.encrypted", FT_BYTES, BASE_HEX,
            NULL, 0, "Encrypted PA-ENC-TIMESTAMP blob", HFILL }},
+       { &hf_krb_encrypted_enc_authorization_data, {
+           "enc-authorization-data", "kerberos.enc_authorization_data.encrypted", FT_BYTES, BASE_HEX,
+           NULL, 0, "", HFILL }},
        { &hf_krb_PAC_LOGON_INFO, {
            "PAC_LOGON_INFO", "kerberos.PAC_LOGON_INFO", FT_BYTES, BASE_HEX,
            NULL, 0, "PAC_LOGON_INFO structure", HFILL }},
@@ -4033,6 +5016,12 @@ proto_register_kerberos(void)
        { &hf_krb_PAC_CLIENT_INFO_TYPE, {
            "PAC_CLIENT_INFO_TYPE", "kerberos.PAC_CLIENT_INFO_TYPE", FT_BYTES, BASE_HEX,
            NULL, 0, "PAC_CLIENT_INFO_TYPE structure", HFILL }},
+       { &hf_krb_PAC_CONSTRAINED_DELEGATION, {
+           "PAC_CONSTRAINED_DELEGATION", "kerberos.PAC_CONSTRAINED_DELEGATION", FT_BYTES, BASE_HEX,
+           NULL, 0, "PAC_CONSTRAINED_DELEGATION structure", HFILL }},
+       { &hf_krb_PAC_UPN_DNS_INFO, {
+           "UPN_DNS_INFO", "kerberos.PAC_UPN_DNS_INFO", FT_BYTES, BASE_HEX,
+           NULL, 0, "UPN_DNS_INFO structure", HFILL }},
        { &hf_krb_checksum_checksum, {
            "checksum", "kerberos.checksum.checksum", FT_BYTES, BASE_HEX,
            NULL, 0, "Kerberos Checksum", HFILL }},
@@ -4054,9 +5043,18 @@ proto_register_kerberos(void)
        { &hf_krb_etype_info_salt, {
            "Salt", "kerberos.etype_info.salt", FT_BYTES, BASE_HEX,
            NULL, 0, "Salt", HFILL }},
+       { &hf_krb_etype_info2_salt, {
+           "Salt", "kerberos.etype_info2.salt", FT_BYTES, BASE_HEX,
+           NULL, 0, "Salt", HFILL }},
+       { &hf_krb_etype_info2_s2kparams, {
+           "Salt", "kerberos.etype_info.s2kparams", FT_BYTES, BASE_HEX,
+           NULL, 0, "S2kparams", HFILL }},
        { &hf_krb_SAFE_BODY_user_data, {
            "User Data", "kerberos.SAFE_BODY.user_data", FT_BYTES, BASE_HEX,
            NULL, 0, "SAFE BODY userdata field", HFILL }},
+       { &hf_krb_PRIV_BODY_user_data, {
+           "User Data", "kerberos.PRIV_BODY.user_data", FT_BYTES, BASE_HEX,
+           NULL, 0, "PRIV BODY userdata field", HFILL }},
        { &hf_krb_pac_signature_signature, {
            "Signature", "kerberos.pac.signature.signature", FT_BYTES, BASE_HEX,
            NULL, 0, "A PAC signature blob", HFILL }},
@@ -4069,12 +5067,18 @@ proto_register_kerberos(void)
        { &hf_krb_tkt_vno, {
            "Tkt-vno", "kerberos.tkt_vno", FT_UINT32, BASE_DEC,
            NULL, 0, "Version number for the Ticket format", HFILL }},
+       { &hf_krb_KrbCredInfo, {
+           "KrbCredInfo", "kerberos.KrbCredInfo", FT_NONE, BASE_DEC,
+           NULL, 0, "This is a Kerberos KrbCredInfo", HFILL }},
        { &hf_krb_HostAddress, {
            "HostAddress", "kerberos.hostaddress", FT_NONE, BASE_DEC,
            NULL, 0, "This is a Kerberos HostAddress sequence", HFILL }},
        { &hf_krb_s_address, {
            "S-Address", "kerberos.s_address", FT_NONE, BASE_DEC,
            NULL, 0, "This is the Senders address", HFILL }},
+       { &hf_krb_r_address, {
+           "R-Address", "kerberos.r_address", FT_NONE, BASE_DEC,
+           NULL, 0, "This is the Recipient address", HFILL }},
        { &hf_krb_key, {
            "key", "kerberos.key", FT_NONE, BASE_DEC,
            NULL, 0, "This is a Kerberos EncryptionKey sequence", HFILL }},
@@ -4093,6 +5097,12 @@ proto_register_kerberos(void)
        { &hf_krb_EncAPRepPart, {
            "EncAPRepPart", "kerberos.EncAPRepPart", FT_NONE, BASE_DEC,
            NULL, 0, "This is a decrypted Kerberos EncAPRepPart sequence", HFILL }},
+       { &hf_krb_EncKrbPrivPart, {
+           "EncKrbPrivPart", "kerberos.EncKrbPrivPart", FT_NONE, BASE_DEC,
+           NULL, 0, "This is a decrypted Kerberos EncKrbPrivPart sequence", HFILL }},
+       { &hf_krb_EncKrbCredPart, {
+           "EncKrbCredPart", "kerberos.EncKrbCredPart", FT_NONE, BASE_DEC,
+           NULL, 0, "This is a decrypted Kerberos EncKrbCredPart sequence", HFILL }},
        { &hf_krb_EncKDCRepPart, {
            "EncKDCRepPart", "kerberos.EncKDCRepPart", FT_NONE, BASE_DEC,
            NULL, 0, "This is a decrypted Kerberos EncKDCRepPart sequence", HFILL }},
@@ -4114,18 +5124,30 @@ proto_register_kerberos(void)
        { &hf_krb_etypes, {
            "Encryption Types", "kerberos.etypes", FT_NONE, BASE_DEC,
            NULL, 0, "This is a list of Kerberos encryption types", HFILL }},
+       { &hf_krb_KrbCredInfos, {
+           "Sequence of KrbCredInfo", "kerberos.KrbCredInfos", FT_NONE, BASE_DEC,
+           NULL, 0, "This is a list of KrbCredInfo", HFILL }},
+       { &hf_krb_sq_tickets, {
+           "Tickets", "kerberos.sq.tickets", FT_NONE, BASE_DEC,
+           NULL, 0, "This is a list of Kerberos Tickets", HFILL }},
        { &hf_krb_LastReqs, {
            "LastReqs", "kerberos.LastReqs", FT_NONE, BASE_DEC,
            NULL, 0, "This is a list of LastReq structures", HFILL }},
        { &hf_krb_sname, {
            "Server Name", "kerberos.sname", FT_NONE, BASE_DEC,
            NULL, 0, "This is the name part server's identity", HFILL }},
+       { &hf_krb_pname, {
+           "Delegated Principal Name", "kerberos.pname", FT_NONE, BASE_DEC,
+           NULL, 0, "Identity of the delegated principal", HFILL }},
        { &hf_krb_cname, {
            "Client Name", "kerberos.cname", FT_NONE, BASE_DEC,
            NULL, 0, "The name part of the client principal identifier", HFILL }},
        { &hf_krb_authenticator_enc, {
            "Authenticator", "kerberos.authenticator", FT_NONE, BASE_DEC,
            NULL, 0, "Encrypted authenticator blob", HFILL }},
+       { &hf_krb_CRED_enc, {
+           "EncKrbCredPart", "kerberos.encrypted_cred", FT_NONE, BASE_DEC,
+           NULL, 0, "Encrypted Cred blob", HFILL }},
        { &hf_krb_ticket_enc, {
            "enc-part", "kerberos.ticket.enc_part", FT_NONE, BASE_DEC,
            NULL, 0, "The structure holding the encrypted part of a ticket", HFILL }},
@@ -4171,26 +5193,108 @@ proto_register_kerberos(void)
        { &hf_krb_pac_namelen, {
            "Name Length", "kerberos.pac.namelen", FT_UINT16, BASE_DEC,
            NULL, 0, "Length of client name", HFILL }},
+       { &hf_krb_pac_upn_flags, {
+           "Flags", "kerberos.pac.upn.flags", FT_UINT32, BASE_HEX,
+           NULL, 0, "UPN flags", HFILL }},
+       { &hf_krb_pac_upn_dns_offset, {
+           "DNS Offset", "kerberos.pac.upn.dns_offset", FT_UINT16, BASE_DEC,
+           NULL, 0, "", HFILL }},
+       { &hf_krb_pac_upn_dns_len, {
+           "DNS Len", "kerberos.pac.upn.dns_len", FT_UINT16, BASE_DEC,
+           NULL, 0, "", HFILL }},
+       { &hf_krb_pac_upn_upn_offset, {
+           "UPN Offset", "kerberos.pac.upn.upn_offset", FT_UINT16, BASE_DEC,
+           NULL, 0, "", HFILL }},
+       { &hf_krb_pac_upn_upn_len, {
+           "UPN Len", "kerberos.pac.upn.upn_len", FT_UINT16, BASE_DEC,
+           NULL, 0, "", HFILL }},
+       { &hf_krb_pac_upn_upn_name, {
+           "UPN Name", "kerberos.pac.upn.upn_name", FT_STRING, BASE_NONE,
+           NULL, 0, "", HFILL }},
+       { &hf_krb_pac_upn_dns_name, {
+           "DNS Name", "kerberos.pac.upn.dns_name", FT_STRING, BASE_NONE,
+           NULL, 0, "", HFILL }},
        { &hf_krb_e_checksum, {
            "e-checksum", "kerberos.e_checksum", FT_NONE, BASE_DEC,
            NULL, 0, "This is a Kerberos e-checksum", HFILL }},
+       { &hf_krb_gssapi_len, {
+           "Length", "kerberos.gssapi.len", FT_UINT32, BASE_DEC,
+           NULL, 0, "Length of GSSAPI Bnd field", HFILL }},
+       { &hf_krb_gssapi_bnd, {
+           "Bnd", "kerberos.gssapi.bdn", FT_BYTES, BASE_HEX,
+           NULL, 0, "GSSAPI Bnd field", HFILL }},
+       { &hf_krb_gssapi_c_flag_deleg, {
+           "Deleg", "kerberos.gssapi.checksum.flags.deleg", FT_BOOLEAN, 32,
+           TFS(&tfs_gss_flags_deleg), KRB5_GSS_C_DELEG_FLAG, "", HFILL }},
+       { &hf_krb_gssapi_c_flag_mutual, {
+           "Mutual", "kerberos.gssapi.checksum.flags.mutual", FT_BOOLEAN, 32,
+           TFS(&tfs_gss_flags_mutual), KRB5_GSS_C_MUTUAL_FLAG, "", HFILL }},
+       { &hf_krb_gssapi_c_flag_replay, {
+           "Replay", "kerberos.gssapi.checksum.flags.replay", FT_BOOLEAN, 32,
+           TFS(&tfs_gss_flags_replay), KRB5_GSS_C_REPLAY_FLAG, "", HFILL }},
+       { &hf_krb_gssapi_c_flag_sequence, {
+           "Sequence", "kerberos.gssapi.checksum.flags.sequence", FT_BOOLEAN, 32,
+           TFS(&tfs_gss_flags_sequence), KRB5_GSS_C_SEQUENCE_FLAG, "", HFILL }},
+       { &hf_krb_gssapi_c_flag_conf, {
+           "Conf", "kerberos.gssapi.checksum.flags.conf", FT_BOOLEAN, 32,
+           TFS(&tfs_gss_flags_conf), KRB5_GSS_C_CONF_FLAG, "", HFILL }},
+       { &hf_krb_gssapi_c_flag_integ, {
+           "Integ", "kerberos.gssapi.checksum.flags.integ", FT_BOOLEAN, 32,
+           TFS(&tfs_gss_flags_integ), KRB5_GSS_C_INTEG_FLAG, "", HFILL }},
+       { &hf_krb_gssapi_c_flag_dce_style, {
+           "DCE-style", "kerberos.gssapi.checksum.flags.dce-style", FT_BOOLEAN, 32,
+           TFS(&tfs_gss_flags_dce_style), KRB5_GSS_C_DCE_STYLE, "", HFILL }},
+       { &hf_krb_gssapi_dlgopt, {
+           "DlgOpt", "kerberos.gssapi.dlgopt", FT_UINT16, BASE_DEC,
+           NULL, 0, "GSSAPI DlgOpt", HFILL }},
+       { &hf_krb_gssapi_dlglen, {
+           "DlgLen", "kerberos.gssapi.dlglen", FT_UINT16, BASE_DEC,
+           NULL, 0, "GSSAPI DlgLen", HFILL }},
+       { &hf_krb_smb_nt_status,
+               { "NT Status", "kerberos.smb.nt_status", FT_UINT32, BASE_HEX,
+               VALS(NT_errors), 0, "NT Status code", HFILL }},
+       { &hf_krb_smb_unknown,
+               { "Unknown", "kerberos.smb.unknown", FT_UINT32, BASE_HEX,
+               NULL, 0, "unknown", HFILL }},
+       { &hf_krb_midl_blob_len,
+               { "Blob Length", "kerberos.midl_blob_len", FT_UINT64, BASE_DEC,
+               NULL, 0, "Length of NDR encoded data that follows", HFILL }},
+
+       { &hf_krb_midl_fill_bytes,
+               { "Fill bytes", "kerberos.midl.fill_bytes", FT_UINT32, BASE_HEX,
+               NULL, 0, "Just some fill bytes", HFILL }},
+
+       { &hf_krb_midl_version,
+               { "Version", "kerberos.midl.version", FT_UINT8, BASE_DEC,
+               NULL, 0, "Version of pickling", HFILL }},
+
+       { &hf_krb_midl_hdr_len,
+               { "HDR Length", "kerberos.midl.hdr_len", FT_UINT16, BASE_DEC,
+               NULL, 0, "Length of header", HFILL }},
+
     };
 
     static gint *ett[] = {
         &ett_krb_kerberos,
        &ett_krb_KDC_REP_enc,
         &ett_krb_sname,
+        &ett_krb_pname,
         &ett_krb_cname,
        &ett_krb_AP_REP_enc,
         &ett_krb_padata,
         &ett_krb_etypes,
+        &ett_krb_KrbCredInfos,
+        &ett_krb_sq_tickets,
         &ett_krb_LastReqs,
         &ett_krb_IF_RELEVANT,
        &ett_krb_PA_DATA_tree,
         &ett_krb_s_address,
+        &ett_krb_r_address,
+        &ett_krb_KrbCredInfo,
         &ett_krb_HostAddress,
         &ett_krb_HostAddresses,
        &ett_krb_authenticator_enc,
+       &ett_krb_CRED_enc,
         &ett_krb_AP_Options,
         &ett_krb_KDC_Options,
         &ett_krb_Ticket_Flags,
@@ -4198,10 +5302,13 @@ proto_register_kerberos(void)
         &ett_krb_recordmark,
         &ett_krb_ticket,
        &ett_krb_ticket_enc,
+        &ett_krb_CRED,
         &ett_krb_PRIV,
         &ett_krb_PRIV_enc,
         &ett_krb_EncTicketPart,
         &ett_krb_EncAPRepPart,
+        &ett_krb_EncKrbPrivPart,
+        &ett_krb_EncKrbCredPart,
         &ett_krb_EncKDCRepPart,
         &ett_krb_LastReq,
         &ett_krb_Authenticator,
@@ -4216,7 +5323,11 @@ proto_register_kerberos(void)
        &ett_krb_PAC_SERVER_CHECKSUM,
        &ett_krb_PAC_PRIVSVR_CHECKSUM,
        &ett_krb_PAC_CLIENT_INFO_TYPE,
+       &ett_krb_PAC_CONSTRAINED_DELEGATION,
        &ett_krb_e_checksum,
+       &ett_krb_PAC_MIDL_BLOB,
+       &ett_krb_PAC_DREP,
+       &ett_krb_PAC_UPN_DNS_INFO
     };
     module_t *krb_module;
 
@@ -4243,6 +5354,7 @@ proto_register_kerberos(void)
                                   "The keytab file containing all the secrets",
                                   &keytab_filename);
 #endif
+
 }
 
 static int wrap_dissect_gss_kerb(tvbuff_t *tvb, int offset, packet_info *pinfo,
@@ -4252,7 +5364,7 @@ static int wrap_dissect_gss_kerb(tvbuff_t *tvb, int offset, packet_info *pinfo,
 
        auth_tvb = tvb_new_subset(
                tvb, offset, tvb_length_remaining(tvb, offset),
-               tvb_length_remaining(tvb, offset));
+               tvb_reported_length_remaining(tvb, offset));
 
        dissect_kerberos_main(auth_tvb, pinfo, tree, FALSE, NULL);
 
@@ -4266,8 +5378,8 @@ static dcerpc_auth_subdissector_fns gss_kerb_auth_fns = {
        NULL,                                   /* AUTH3 */
        wrap_dissect_gssapi_verf,               /* Request verifier */
        wrap_dissect_gssapi_verf,               /* Response verifier */
-       NULL,                                   /* Request data */
-       NULL                                    /* Response data */
+       wrap_dissect_gssapi_payload,            /* Request data */
+       wrap_dissect_gssapi_payload             /* Response data */
 };
 
 
@@ -4276,13 +5388,19 @@ proto_reg_handoff_kerberos(void)
 {
     dissector_handle_t kerberos_handle_tcp;
 
-    kerberos_handle_udp = create_dissector_handle(dissect_kerberos_udp,
+    krb4_handle = find_dissector("krb4");
+
+    kerberos_handle_udp = new_create_dissector_handle(dissect_kerberos_udp,
        proto_kerberos);
     kerberos_handle_tcp = create_dissector_handle(dissect_kerberos_tcp,
        proto_kerberos);
     dissector_add("udp.port", UDP_PORT_KERBEROS, kerberos_handle_udp);
     dissector_add("tcp.port", TCP_PORT_KERBEROS, kerberos_handle_tcp);
 
+    register_dcerpc_auth_subdissector(DCE_C_AUTHN_LEVEL_PKT_INTEGRITY,
+                                     DCE_C_RPC_AUTHN_PROTOCOL_GSS_KERBEROS,
+                                     &gss_kerb_auth_fns);
+
     register_dcerpc_auth_subdissector(DCE_C_AUTHN_LEVEL_PKT_PRIVACY,
                                      DCE_C_RPC_AUTHN_PROTOCOL_GSS_KERBEROS,
                                      &gss_kerb_auth_fns);
@@ -4517,4 +5635,3 @@ proto_reg_handoff_kerberos(void)
       }
 
 */
-