From f04e09e1968c40483b8dc2f92b9c15bce0b0b55a Mon Sep 17 00:00:00 2001 From: Stefan Metzmacher Date: Tue, 23 Aug 2016 12:37:37 +0200 Subject: [PATCH 1/1] samba-tool:domain: use generate_random_machine_password() for machine passwords BUG: https://bugzilla.samba.org/show_bug.cgi?id=12262 Signed-off-by: Stefan Metzmacher Reviewed-by: Ralph Boehme --- python/samba/join.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/python/samba/join.py b/python/samba/join.py index b998997daf8..9b211ac8b6e 100644 --- a/python/samba/join.py +++ b/python/samba/join.py @@ -105,7 +105,7 @@ class dc_join(object): if machinepass is not None: ctx.acct_pass = machinepass else: - ctx.acct_pass = samba.generate_random_password(32, 40) + ctx.acct_pass = samba.generate_random_machine_password(128, 255) ctx.dnsdomain = ctx.samdb.domain_dns_name() if clone_only: @@ -684,7 +684,7 @@ class dc_join(object): pass ctx.net.set_password(account_name=ctx.samname, domain_name=ctx.domain_name, - newpassword=ctx.acct_pass) + newpassword=ctx.acct_pass.encode('utf-8')) res = ctx.samdb.search(base=ctx.acct_dn, scope=ldb.SCOPE_BASE, attrs=["msDS-KeyVersionNumber"]) -- 2.34.1