Stefan Metzmacher [Mon, 27 Feb 2012 12:18:42 +0000 (13:18 +0100)]
s3:torture/test_smb2: show that a session is valid during a multi-leg reauth
metze
Stefan Metzmacher [Mon, 27 Feb 2012 12:26:00 +0000 (13:26 +0100)]
s3:torture/test_smb2: fix missleading file name in reauth test
metze
Stefan Metzmacher [Mon, 27 Feb 2012 08:29:53 +0000 (09:29 +0100)]
libcli/smb/smb2_signing: pass down 'protocol' to smb2_signing_[sign|check]_pdu()
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Feb 27 14:26:32 CET 2012 on sn-devel-104
Stefan Metzmacher [Mon, 27 Feb 2012 08:27:51 +0000 (09:27 +0100)]
libcli/smb/smb2_signing: rename session_key to signing_key
metze
Stefan Metzmacher [Mon, 27 Feb 2012 08:24:38 +0000 (09:24 +0100)]
libcli/smb/smbXcli: remove unused if statement from smb2cli_conn_dispatch_incoming()
metze
Stefan Metzmacher [Mon, 27 Feb 2012 08:20:20 +0000 (09:20 +0100)]
s4:libcli/smb2: remove unused 'session_key' from struct smb2_session
metze
Stefan Metzmacher [Mon, 27 Feb 2012 08:16:28 +0000 (09:16 +0100)]
s4:librpc/dcerpc_smb2: make use of smb2cli_session_application_key()
metze
Stefan Metzmacher [Mon, 27 Feb 2012 08:03:54 +0000 (09:03 +0100)]
libcli/smb/smbXcli: add smb2cli_session_application_key()
metze
Stefan Metzmacher [Mon, 27 Feb 2012 07:48:55 +0000 (08:48 +0100)]
libcli/smb/smbXcli: maintain smb2 channel_signing_key separate from the signing_key
The signing_key is fix across all channels and is used for session setups
on a channel binding.
Note:
- the last session setup response is signed with the new channel signing key.
- the reauth session setups are signed with the channel signing key.
It's also not needed to remember the main session key.
metze
Stefan Metzmacher [Mon, 27 Feb 2012 08:58:53 +0000 (09:58 +0100)]
libcli/smb/smbXcli: remove unused checks from smb2cli_session_create_channel()
metze
Stefan Metzmacher [Mon, 27 Feb 2012 08:18:33 +0000 (09:18 +0100)]
s3:torture/test_smb2: remove explicit smb2_signing_check_pdu()
smb2cli_session_set_session_key() already checks the signature
and that function really knows the signing key.
metze
Stefan Metzmacher [Mon, 27 Feb 2012 10:52:50 +0000 (11:52 +0100)]
s3:torture/test_smb2: a reauth doesn't update the session/signing key
metze
Stefan Metzmacher [Wed, 22 Feb 2012 08:01:10 +0000 (09:01 +0100)]
lib/crypto: fix hmac_sha256_final() prototype
metze
Andrew Tridgell [Thu, 9 Feb 2012 03:10:41 +0000 (14:10 +1100)]
dbwrap: changed log level for information about lock order
we were filling our logs with lock ordering debug lines
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Mon Feb 27 12:50:29 CET 2012 on sn-devel-104
Andrew Bartlett [Mon, 13 Feb 2012 06:47:11 +0000 (17:47 +1100)]
selftest: up the default log level in s3
This may help show more detail when our tests fail.
Andrew Bartlett
Andrew Bartlett [Mon, 27 Feb 2012 05:29:14 +0000 (16:29 +1100)]
s3-selftest: avoid running LOCAL- tests twice
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Mon Feb 27 09:07:59 CET 2012 on sn-devel-104
Andrew Bartlett [Mon, 27 Feb 2012 03:24:30 +0000 (14:24 +1100)]
s3-param: Align lp_{max,min}protocol with lib/param names
This adds an alisas to ensure that both our loadparm systems know all
the names.
I would like to move to the 'server ..' name as canonical, and this
will be raised on the list.
Andrew Bartlett
Andrew Tridgell [Thu, 9 Feb 2012 04:14:10 +0000 (15:14 +1100)]
torture: don't check the NOINDEXED bit in attribute comparison
this bit is dependent on user settings on the filesystem
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Bartlett [Mon, 27 Feb 2012 04:36:45 +0000 (15:36 +1100)]
selftest: plugin_s4_dc can now handle kerberos properly
Andrew Bartlett [Mon, 27 Feb 2012 05:46:22 +0000 (16:46 +1100)]
s4-netlogond: Fix use of uninitialised value dns_name
The GET_CHECK_STR macro (now unrolled) did not initialise the trusts->array[n].dns_name
when the value was not set. New tests for our trusted domains code create
domain trusts without a DNS domain name. Found by the autobuild flakey build detector.
Andrew Bartlett
Rusty Russell [Mon, 27 Feb 2012 03:45:47 +0000 (14:15 +1030)]
lib/tdb2: rename tdb2.pc to tdb.pc
The library is called tdb, so the pc file must have the same name.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Autobuild-User: Rusty Russell <rusty@rustcorp.com.au>
Autobuild-Date: Mon Feb 27 06:59:58 CET 2012 on sn-devel-104
Jelmer Vernooij [Mon, 27 Feb 2012 02:50:37 +0000 (03:50 +0100)]
upgradehelpers: Simplify transaction handling.
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Mon Feb 27 05:25:04 CET 2012 on sn-devel-104
Jelmer Vernooij [Mon, 27 Feb 2012 01:46:31 +0000 (02:46 +0100)]
samba.xattr: Massively simplify copytree_with_xattrs.
Jelmer Vernooij [Sun, 26 Feb 2012 23:53:19 +0000 (00:53 +0100)]
upgradeprovision: Only backup sysvol directory if it exists.
This is not the case for standalone installations.
Bug: https://bugs.launchpad.net/samba/+bug/930370
Bug: https://bugzilla.samba.org/show_bug.cgi?id=8781
Jelmer Vernooij [Sun, 26 Feb 2012 23:50:00 +0000 (00:50 +0100)]
samba.xattr: Split copying of tree with extended attributes out into separate module.
Michael Adam [Thu, 23 Feb 2012 14:49:51 +0000 (15:49 +0100)]
s4:torture:smb2:durable-open: prevent using a disconnected handle in reopen4
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Mon Feb 27 03:44:16 CET 2012 on sn-devel-104
Michael Adam [Thu, 23 Feb 2012 22:43:18 +0000 (23:43 +0100)]
s4:torture:smb2:durable-open: introduce new variable for the new session
This is to clarify the code.
Michael Adam [Thu, 23 Feb 2012 22:25:18 +0000 (23:25 +0100)]
s4:torture:smb2:durable-open: make a comment more precise in the reopen4 test
Michael Adam [Thu, 23 Feb 2012 14:35:15 +0000 (15:35 +0100)]
s4:torture:smb2:durable_open: use the correct tree in the final close call
Jelmer Vernooij [Sun, 26 Feb 2012 22:15:48 +0000 (23:15 +0100)]
provision: Write configuration without help of templates.
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Mon Feb 27 00:52:46 CET 2012 on sn-devel-104
Jelmer Vernooij [Sun, 26 Feb 2012 21:43:15 +0000 (22:43 +0100)]
pyparam: fix formatting.
Jelmer Vernooij [Sun, 26 Feb 2012 21:23:27 +0000 (22:23 +0100)]
provision: Simplify make_smbconf a bit.
Jelmer Vernooij [Sun, 26 Feb 2012 21:09:44 +0000 (22:09 +0100)]
provision: Fix order for error formatting.
Jelmer Vernooij [Sun, 26 Feb 2012 20:47:50 +0000 (21:47 +0100)]
provision: Raise proper error when shares are missing rather than AssertionError.
Jelmer Vernooij [Sun, 26 Feb 2012 19:51:04 +0000 (20:51 +0100)]
provision: Share more code for determine_netbios_name() with samba.valid_netbios_name().
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Sun Feb 26 22:24:42 CET 2012 on sn-devel-104
Jelmer Vernooij [Sun, 26 Feb 2012 19:45:43 +0000 (20:45 +0100)]
provision/backend: Properly close all opened files.
Jelmer Vernooij [Sun, 26 Feb 2012 19:42:41 +0000 (20:42 +0100)]
provision: Properly close opened files.
Jelmer Vernooij [Sun, 26 Feb 2012 19:40:26 +0000 (20:40 +0100)]
provision: Reuse determine_netbios_name.
Jelmer Vernooij [Sun, 26 Feb 2012 19:39:13 +0000 (20:39 +0100)]
provision: Add tests for determine_netbios_name.
Jelmer Vernooij [Sun, 26 Feb 2012 19:38:50 +0000 (20:38 +0100)]
provision: Factor out determination of new netbios name.
Jelmer Vernooij [Sun, 26 Feb 2012 15:25:56 +0000 (16:25 +0100)]
join: Don't print provision results when they're just noise.
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Sun Feb 26 17:56:57 CET 2012 on sn-devel-104
Jelmer Vernooij [Sun, 26 Feb 2012 15:23:18 +0000 (16:23 +0100)]
provision: Split out result reporting for backends.
Jelmer Vernooij [Sun, 26 Feb 2012 15:07:21 +0000 (16:07 +0100)]
provision: Put adminpass details in ProvisionResult.
Jelmer Vernooij [Sun, 26 Feb 2012 14:56:52 +0000 (15:56 +0100)]
provision/tests: Test for phpldapadminconfig path.
Jelmer Vernooij [Sun, 26 Feb 2012 14:44:40 +0000 (15:44 +0100)]
provision: Leave result reporting up to caller.
Volker Lendecke [Sun, 26 Feb 2012 08:20:38 +0000 (09:20 +0100)]
s3: Remove pointless parentheses
Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Sun Feb 26 11:10:15 CET 2012 on sn-devel-104
Volker Lendecke [Sat, 25 Feb 2012 22:42:52 +0000 (23:42 +0100)]
s3-configure: Add CFLAGS_APPEND variable
This makes it possible to add some CFLAGS to the end of the CFLAGS list. I use
it for adding -Wno-unused-value when compiling with clang.
Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Sun Feb 26 01:21:49 CET 2012 on sn-devel-104
Volker Lendecke [Sat, 25 Feb 2012 20:27:28 +0000 (21:27 +0100)]
s3: Use the correct enum values
wbcIdType and id_type have the same values, but different names
Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Sat Feb 25 23:46:36 CET 2012 on sn-devel-104
Volker Lendecke [Sat, 25 Feb 2012 20:20:21 +0000 (21:20 +0100)]
nsswitch: Remove a pointless if-clause
gr->num_gr_mem is a uint32, so it can never be < 0
Volker Lendecke [Sat, 25 Feb 2012 20:17:40 +0000 (21:17 +0100)]
libcli: Remove a pointless check
"n" is size_t, so it is always >=0.
Jelmer Vernooij [Sat, 25 Feb 2012 19:04:57 +0000 (20:04 +0100)]
provision: Start splitting out provision result reporting from actual provisioning.
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Sat Feb 25 22:13:10 CET 2012 on sn-devel-104
Jelmer Vernooij [Sat, 25 Feb 2012 16:55:52 +0000 (17:55 +0100)]
provision: Properly close ldb transactions.
Jelmer Vernooij [Sat, 25 Feb 2012 16:50:14 +0000 (17:50 +0100)]
'samba-tool gpo': Properly close transaction.
Jelmer Vernooij [Sat, 25 Feb 2012 16:36:54 +0000 (17:36 +0100)]
ntacl: There is no 'secrets database' configuration option.
Jelmer Vernooij [Sat, 25 Feb 2012 16:35:41 +0000 (17:35 +0100)]
Factor out sanitize_server_role.
Jelmer Vernooij [Sat, 25 Feb 2012 14:56:25 +0000 (15:56 +0100)]
Partially revert
1f0298dd1b1a939cb215e7b474178b217f8347f4
It's fine to catch keyboard interrupts and other kinds of errors when it's done just for resource management, where the error is reraised later.
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Sat Feb 25 17:29:34 CET 2012 on sn-devel-104
Jelmer Vernooij [Sat, 25 Feb 2012 14:15:51 +0000 (15:15 +0100)]
provision: Remove unused imports.
Volker Lendecke [Sat, 25 Feb 2012 08:40:16 +0000 (09:40 +0100)]
s3: Fix a typo
Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Sat Feb 25 11:16:41 CET 2012 on sn-devel-104
Brad Smith [Sat, 25 Feb 2012 08:28:43 +0000 (09:28 +0100)]
s3: Fix bug 8777, sys_statvfs() wrapper support for OpenBSD/FreeBSD/DragonFly
Andrew Bartlett [Sat, 14 Jan 2012 23:49:07 +0000 (10:49 +1100)]
s3-auth rename vuid_serverinfo to session_info
This matches the name used elsewhere in the code.
Andrew Bartlett
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Sat Feb 25 05:24:19 CET 2012 on sn-devel-104
Ricky Nance [Fri, 10 Feb 2012 06:43:40 +0000 (00:43 -0600)]
s4-lib: Remove unused samdb_msg_set_value()
Found by callcatcher.
Ricky Nance
Ricky Nance [Fri, 10 Feb 2012 06:41:44 +0000 (00:41 -0600)]
s4-lib: Remove unused samdb_msg_set_string()
Found by callcatcher.
Ricky Nance
Ricky Nance [Fri, 10 Feb 2012 06:36:55 +0000 (00:36 -0600)]
s4-lib: Remove unused samdb_msg_set_int()
Found by callcatcher
Ricky Nance
Jeremy Allison [Sat, 25 Feb 2012 01:16:08 +0000 (17:16 -0800)]
Move dptr code over to TALLOC.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Sat Feb 25 03:50:24 CET 2012 on sn-devel-104
Jeremy Allison [Sat, 25 Feb 2012 01:12:52 +0000 (17:12 -0800)]
Make dptr_path() and dptr_wcard() const.
Jeremy Allison [Thu, 23 Feb 2012 22:49:02 +0000 (14:49 -0800)]
Fix const warnings.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Feb 24 23:10:56 CET 2012 on sn-devel-104
Jeremy Allison [Thu, 23 Feb 2012 22:46:45 +0000 (14:46 -0800)]
Remove unused function.
Volker Lendecke [Fri, 24 Feb 2012 15:16:23 +0000 (16:16 +0100)]
s3: Simplify smb_splice_chain
No code change, just remove a {} block left over as the else branch
from the previous commit
Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Fri Feb 24 18:07:48 CET 2012 on sn-devel-104
Volker Lendecke [Fri, 24 Feb 2012 15:16:23 +0000 (16:16 +0100)]
s3: Simplify smb_splice_chain
first_request won't be true anymore, we always splice fully existing
records in smbd
Volker Lendecke [Fri, 24 Feb 2012 15:16:23 +0000 (16:16 +0100)]
s3: Simplify smb_splice_chain
With the last commit, bytes_padding is not set anymore
Volker Lendecke [Fri, 24 Feb 2012 15:16:23 +0000 (16:16 +0100)]
s3: Simplify smb_splice_chain
bytes_alignment used to be used in libsmb, which uses different code
now
Volker Lendecke [Fri, 24 Feb 2012 15:16:23 +0000 (16:16 +0100)]
s3: Simplify smb_splice_chain
We use it in smbd/process.c only now. This only splices in finished
buffers, both callers used the same arguments. Pull that into the
routine itself.
Volker Lendecke [Fri, 24 Feb 2012 15:02:02 +0000 (16:02 +0100)]
s3: Turn some SMB_ASSERTS into proper return
We deal with the error properly further up
Volker Lendecke [Fri, 24 Feb 2012 14:45:37 +0000 (15:45 +0100)]
s3: Fix a DEBUG msg
Jelmer Vernooij [Fri, 24 Feb 2012 12:31:47 +0000 (13:31 +0100)]
upgradedns: Rename to less generic name samba_upgradedns.
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Fri Feb 24 15:07:27 CET 2012 on sn-devel-104
Andrew Bartlett [Fri, 24 Feb 2012 04:24:00 +0000 (15:24 +1100)]
on our way with Samba 4.0alpha19
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Fri Feb 24 07:20:10 CET 2012 on sn-devel-104
Andrew Bartlett [Thu, 16 Feb 2012 05:45:10 +0000 (16:45 +1100)]
prepare WHATSNEW for Samba 4.0alpha18 release and mark as release.
Andrew Bartlett [Fri, 24 Feb 2012 01:36:23 +0000 (12:36 +1100)]
s3-libsmb: Remove unused spnego_parse_auth_and_mic
Andrew Bartlett [Fri, 24 Feb 2012 01:19:27 +0000 (12:19 +1100)]
s3-selftest: Verify GK and GF flag behaviour
At least this ensures that the helper has not crashed, it will require
a little more to ensure that the values are correct.
Andrew Bartlett
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Fri Feb 24 03:53:38 CET 2012 on sn-devel-104
Andrew Bartlett [Fri, 24 Feb 2012 01:12:48 +0000 (12:12 +1100)]
s3-selftest: run ntlm_auth against winbindd in make test
Andrew Bartlett [Tue, 7 Feb 2012 06:47:42 +0000 (17:47 +1100)]
auth: Remove plugable password-check functions from gensec_ntlmssp
The auth4_context layer now provides the plugability here.
Andrew Bartlett
Andrew Bartlett [Tue, 7 Feb 2012 06:12:19 +0000 (17:12 +1100)]
auth: consolidate gensec_ntlmssp_server wrapper functions
Andrew Bartlett [Tue, 7 Feb 2012 06:07:52 +0000 (17:07 +1100)]
s3-libsmb: Remove unused ntlmssp_server_start()
Andrew Bartlett [Tue, 7 Feb 2012 06:02:14 +0000 (17:02 +1100)]
s3-ntlm_auth: Convert ntlm_auth to use gensec_ntlmssp server-side
This uses the common gensec_ntlmssp server code for ntlm_auth, removing
the last non-gensec use of the NTLMSSP server.
Andrew Bartlett
Andrew Bartlett [Fri, 3 Feb 2012 12:32:26 +0000 (23:32 +1100)]
s3-auth: Provide helper routine to check password and return session_info
Andrew Bartlett [Fri, 3 Feb 2012 05:33:44 +0000 (16:33 +1100)]
auth: Rename some elements of auth4_context
These operate on NTLM authentication, so make that clear.
Andrew Bartlett
Andrew Bartlett [Fri, 3 Feb 2012 05:14:42 +0000 (16:14 +1100)]
s3-auth: Add a way to get an auth4_context from the auth stack
This will allow us to use the same layer that auth_ntlmssp does
in the non-SPNEGO session setup, which will in turn make the
authentication code more consistent in the AD server case.
Andrew Bartlett
Andreas Schneider [Thu, 23 Feb 2012 10:05:09 +0000 (11:05 +0100)]
waf: Make sure libraries are installed with the execute flag set.
There are two reasons for that. The first is that libraries are
executables and can have main functions (see libc). The second reason is
that rpm script to extract debuginfo are looking for executables and
then check if it is the right file to extract the info.
Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Thu Feb 23 20:57:11 CET 2012 on sn-devel-104
Andreas Schneider [Thu, 23 Feb 2012 08:24:02 +0000 (09:24 +0100)]
s4-heimdal: Remove the execute flag of cfx.c.
The scripts which are extracting debuginfo are looking for files with
the executable bit and find cfx.c which isn't a executable.
Matthias Dieter Wallnöfer [Thu, 23 Feb 2012 10:41:11 +0000 (11:41 +0100)]
s3:smbd/utmp.c - fix the build on FreeBSD 9 without utmp.h
https://bugzilla.samba.org/show_bug.cgi?id=8709
Reviewed-by: Jelmer
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Thu Feb 23 19:17:25 CET 2012 on sn-devel-104
Jelmer Vernooij [Thu, 23 Feb 2012 13:51:00 +0000 (14:51 +0100)]
dcerpc_server: Add 'modulesdir' variable to pkg-config file.
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Thu Feb 23 16:26:25 CET 2012 on sn-devel-104
Volker Lendecke [Thu, 23 Feb 2012 09:50:46 +0000 (10:50 +0100)]
s3: smb_request->vwv can be const
Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Thu Feb 23 12:37:23 CET 2012 on sn-devel-104
Andrew Bartlett [Thu, 23 Feb 2012 05:34:47 +0000 (16:34 +1100)]
selftest: Do not skip environments that fail to start up
This is a regression in
70f4a96c68e91e407651e2487cc3c66a80262fa2.
Andrew Bartlett
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Thu Feb 23 10:55:20 CET 2012 on sn-devel-104
Andrew Bartlett [Thu, 23 Feb 2012 05:36:33 +0000 (16:36 +1100)]
s4-provision: Fix typo in
9b9fdeefb47f2657c9bb4c2f48318550da510209
This was not found to to a bug in the selftest system.
Andrew Bartlett
Andrew Bartlett [Thu, 9 Feb 2012 04:59:38 +0000 (15:59 +1100)]
s3-libads: Remove unused ads_set_machine_password()
Found by callcatcher.
Andrew Bartlett
Andrew Bartlett [Thu, 9 Feb 2012 05:04:30 +0000 (16:04 +1100)]
s3-libads: Remove unused ads_pull_sids_from_extendeddn()
Found by callcatcher.
Andrew Bartlett
Andrew Bartlett [Thu, 9 Feb 2012 05:07:06 +0000 (16:07 +1100)]
s3-utils: Remove unused connect_to_ipc_krb5()
Found by callcatcher.
Andrew Bartlett
Andrew Bartlett [Tue, 21 Feb 2012 00:55:50 +0000 (11:55 +1100)]
wintest: Change to a new Win2008R2 VM
Andrew Bartlett [Mon, 20 Feb 2012 06:03:25 +0000 (17:03 +1100)]
s3-libsmb: Remove unused spnego functions
Andrew Bartlett [Mon, 20 Feb 2012 05:42:20 +0000 (16:42 +1100)]
s3-rpc_server Remove unused function auth_generic_server_start()
git.samba.org / nivanova / samba-autobuild / .git / log