nivanova/samba-autobuild/.git
11 years agoselftest: Remove tests for security=server
Andrew Bartlett [Mon, 14 May 2012 23:43:03 +0000 (09:43 +1000)]
selftest: Remove tests for security=server

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agosamba-upgradedns: Use the correct magic incantation of sys.path.insert()
Amitay Isaacs [Tue, 15 May 2012 00:56:21 +0000 (10:56 +1000)]
samba-upgradedns: Use the correct magic incantation of sys.path.insert()

This replaces "bin/python" with the correct path for python libraries. The
pattern requires double quotes (") instead of single quotes (').

Autobuild-User: Amitay Isaacs <amitay@samba.org>
Autobuild-Date: Tue May 15 05:19:46 CEST 2012 on sn-devel-104

11 years agos3: talloc_zero is not needed for structs we ndr_pull into
Volker Lendecke [Mon, 7 May 2012 09:26:39 +0000 (11:26 +0200)]
s3: talloc_zero is not needed for structs we ndr_pull into

Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Mon May 14 18:59:07 CEST 2012 on sn-devel-104

11 years agolibcli/smb: move smb2cli_logoff_* from source3 to the top level
Stefan Metzmacher [Mon, 14 May 2012 07:47:05 +0000 (09:47 +0200)]
libcli/smb: move smb2cli_logoff_* from source3 to the top level

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon May 14 17:02:46 CEST 2012 on sn-devel-104

11 years agolibcli/smb: git mv smb2_session.c smb2cli_session.c
Stefan Metzmacher [Mon, 14 May 2012 07:41:10 +0000 (09:41 +0200)]
libcli/smb: git mv smb2_session.c smb2cli_session.c

metze

11 years agos3:libsmb: s/\<event_context/tevent_context/gc in smb2cli_write.c
Stefan Metzmacher [Mon, 14 May 2012 07:56:47 +0000 (09:56 +0200)]
s3:libsmb: s/\<event_context/tevent_context/gc in smb2cli_write.c

metze

11 years agos3:libsmb: s/\<event_context/tevent_context/gc in smb2cli_session.c
Stefan Metzmacher [Mon, 14 May 2012 07:56:47 +0000 (09:56 +0200)]
s3:libsmb: s/\<event_context/tevent_context/gc in smb2cli_session.c

metze

11 years agos3:libsmb: s/\<event_context/tevent_context/gc in smb2cli_read.c
Stefan Metzmacher [Mon, 14 May 2012 07:56:47 +0000 (09:56 +0200)]
s3:libsmb: s/\<event_context/tevent_context/gc in smb2cli_read.c

metze

11 years agos3:libsmb: s/\<event_context/tevent_context/gc in smb2cli_query_directory.c
Stefan Metzmacher [Mon, 14 May 2012 07:56:47 +0000 (09:56 +0200)]
s3:libsmb: s/\<event_context/tevent_context/gc in smb2cli_query_directory.c

metze

11 years agos3:libsmb: s/\<event_context/tevent_context/gc in smb2cli_ioctl.c
Stefan Metzmacher [Mon, 14 May 2012 07:56:47 +0000 (09:56 +0200)]
s3:libsmb: s/\<event_context/tevent_context/gc in smb2cli_ioctl.c

metze

11 years agos3:libsmb: s/\<event_context/tevent_context/gc in smb2cli_flush.c
Stefan Metzmacher [Mon, 14 May 2012 07:56:47 +0000 (09:56 +0200)]
s3:libsmb: s/\<event_context/tevent_context/gc in smb2cli_flush.c

metze

11 years agos3:libsmb: s/\<event_context/tevent_context/gc in smb2cli_create.c
Stefan Metzmacher [Mon, 14 May 2012 07:56:47 +0000 (09:56 +0200)]
s3:libsmb: s/\<event_context/tevent_context/gc in smb2cli_create.c

metze

11 years agos3:libsmb: s/\<event_context/tevent_context/gc in smb2cli_close.c
Stefan Metzmacher [Mon, 14 May 2012 07:56:47 +0000 (09:56 +0200)]
s3:libsmb: s/\<event_context/tevent_context/gc in smb2cli_close.c

metze

11 years agos3:libsmb: s/\<event_context/tevent_context/gc in smb2cli_tcon.c
Stefan Metzmacher [Mon, 14 May 2012 07:55:42 +0000 (09:55 +0200)]
s3:libsmb: s/\<event_context/tevent_context/gc in smb2cli_tcon.c

metze

11 years agolib/util: move tevent_req_poll_ntstatus() to tevent_ntstatus.c
Stefan Metzmacher [Mon, 14 May 2012 08:02:24 +0000 (10:02 +0200)]
lib/util: move tevent_req_poll_ntstatus() to tevent_ntstatus.c

metze

11 years agos3:torture: add #include "lib/util/tevent_ntstatus.h" to test_addrchange.c
Stefan Metzmacher [Mon, 14 May 2012 09:47:22 +0000 (11:47 +0200)]
s3:torture: add #include "lib/util/tevent_ntstatus.h" to test_addrchange.c

metze

11 years agos3:lib/util: use map_nt_error_from_unix_common() in tevent_req_poll_ntstatus()
Stefan Metzmacher [Mon, 14 May 2012 07:58:56 +0000 (09:58 +0200)]
s3:lib/util: use map_nt_error_from_unix_common() in tevent_req_poll_ntstatus()

metze

11 years agolib/util: add missing 'errors' dependency to 'tevent-util'
Stefan Metzmacher [Mon, 14 May 2012 09:46:39 +0000 (11:46 +0200)]
lib/util: add missing 'errors' dependency to 'tevent-util'

metze

11 years agos4:lib/events: no longer define TEVENT_COMPAT_DEFINES
Stefan Metzmacher [Mon, 14 May 2012 09:50:52 +0000 (11:50 +0200)]
s4:lib/events: no longer define TEVENT_COMPAT_DEFINES

metze

11 years agos4:lib/events: remove unused event_context_find() prototype
Stefan Metzmacher [Mon, 14 May 2012 09:49:52 +0000 (11:49 +0200)]
s4:lib/events: remove unused event_context_find() prototype

metze

11 years agolibcli/nbt: no longer use old 'event_' tevent compat symbols
Stefan Metzmacher [Mon, 14 May 2012 09:48:50 +0000 (11:48 +0200)]
libcli/nbt: no longer use old 'event_' tevent compat symbols

metze

11 years agolib/tevent/testsuite: no longer use 'compat' symbols
Stefan Metzmacher [Mon, 14 May 2012 09:48:00 +0000 (11:48 +0200)]
lib/tevent/testsuite: no longer use 'compat' symbols

metze

11 years agos3:smb2_close: make the top level code async using
Stefan Metzmacher [Mon, 14 May 2012 11:08:34 +0000 (13:08 +0200)]
s3:smb2_close: make the top level code async using

metze

11 years agos3:smb2_close: add add smbd_smb2_close_send/recv as wrapper
Stefan Metzmacher [Mon, 14 May 2012 10:57:15 +0000 (12:57 +0200)]
s3:smb2_close: add add smbd_smb2_close_send/recv as wrapper

metze

11 years agos3:smb2_close: don't do any marshalling in smbd_smb2_close() let the caller to it
Stefan Metzmacher [Mon, 14 May 2012 10:43:52 +0000 (12:43 +0200)]
s3:smb2_close: don't do any marshalling in smbd_smb2_close() let the caller to it

metze

11 years agos3:smb2_tcon: make the top level code async using
Stefan Metzmacher [Mon, 14 May 2012 06:41:03 +0000 (08:41 +0200)]
s3:smb2_tcon: make the top level code async using

metze

11 years agos3:smb2_tcon: add smbd_smb2_tree_connect_send/recv as wrapper
Stefan Metzmacher [Sun, 13 May 2012 15:47:07 +0000 (17:47 +0200)]
s3:smb2_tcon: add smbd_smb2_tree_connect_send/recv as wrapper

metze

11 years agos3: Fix Coverity ID 241320 Array compared against 0
Volker Lendecke [Wed, 9 May 2012 14:36:55 +0000 (16:36 +0200)]
s3: Fix Coverity ID 241320 Array compared against 0

domain->alt_name is an array, not a pointer

Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Mon May 14 15:11:47 CEST 2012 on sn-devel-104

11 years agos3: Make SMB_QUERY_FILE_UNIX_BASIC's devno work for files
Volker Lendecke [Fri, 11 May 2012 11:31:36 +0000 (13:31 +0200)]
s3: Make SMB_QUERY_FILE_UNIX_BASIC's devno work for files

According to susv3, st_rdev is valid exactly for char and block devices. Normal
files have st_dev set.

11 years agomove the dbwrap library to the top level
Michael Adam [Fri, 11 May 2012 20:11:42 +0000 (22:11 +0200)]
move the dbwrap library to the top level

Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Mon May 14 04:04:55 CEST 2012 on sn-devel-104

11 years agos3:build: move lib/dbwrap/dbwrap_util.o to the other dbwrap objects...
Michael Adam [Sun, 13 May 2012 23:52:09 +0000 (01:52 +0200)]
s3:build: move lib/dbwrap/dbwrap_util.o to the other dbwrap objects...

11 years agos3:lib:dbwrap: use [u]int[num]_t consistently in dbwrap_tdb.c
Michael Adam [Fri, 11 May 2012 19:56:03 +0000 (21:56 +0200)]
s3:lib:dbwrap: use [u]int[num]_t consistently in dbwrap_tdb.c

11 years agos3:lib:dbwrap: use [u]int[num]_t consistently in dbwrap_rbt.c
Michael Adam [Fri, 11 May 2012 19:54:46 +0000 (21:54 +0200)]
s3:lib:dbwrap: use [u]int[num]_t consistently in dbwrap_rbt.c

11 years agos3:lib:dbwrap: use [u]int[num]_t consistently in dbwrap_ctdb.c
Michael Adam [Fri, 11 May 2012 19:53:13 +0000 (21:53 +0200)]
s3:lib:dbwrap: use [u]int[num]_t consistently in dbwrap_ctdb.c

11 years agos3:lib:dbwrap: use [u]int[num]_t consistently in dbwrap_file.c
Michael Adam [Fri, 11 May 2012 19:49:40 +0000 (21:49 +0200)]
s3:lib:dbwrap: use [u]int[num]_t consistently in dbwrap_file.c

11 years agos3:lib:dbwrap: use [u]int[num]_t consistently in dbwrap_util.c
Michael Adam [Fri, 11 May 2012 19:46:23 +0000 (21:46 +0200)]
s3:lib:dbwrap: use [u]int[num]_t consistently in dbwrap_util.c

11 years agos3:dbwrap: move definition of dbwrap_lock_order to dbwrap.h
Michael Adam [Fri, 11 May 2012 19:36:48 +0000 (21:36 +0200)]
s3:dbwrap: move definition of dbwrap_lock_order to dbwrap.h

This is needed in all of the library, not only in the dbwrap_open part.

11 years agotevent: fix indentation in the wscript
Michael Adam [Fri, 11 May 2012 16:27:01 +0000 (18:27 +0200)]
tevent: fix indentation in the wscript

(accidentially commited in 5e8dee8d96a7522cdcde57dbbf93fbe9c614992e)

11 years agos3:smb2_sesssetup: make the top level code async using
Stefan Metzmacher [Sat, 12 May 2012 08:20:55 +0000 (10:20 +0200)]
s3:smb2_sesssetup: make the top level code async using

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Sun May 13 17:59:39 CEST 2012 on sn-devel-104

11 years agos3:smb2_sesssetup: add smbd_smb2_session_setup_send/recv as wrapper
Stefan Metzmacher [Sat, 12 May 2012 08:16:41 +0000 (10:16 +0200)]
s3:smb2_sesssetup: add smbd_smb2_session_setup_send/recv as wrapper

This just adds smbd_smb2_session_setup_send/recv as wrapper to
the sync smbd_smb2_session_setup function.

This will allow us to change to top level code to work async,
then we can have a 2nd step where we remove the sync
smbd_smb2_session_setup function.

metze

11 years agos3:smb2_sesssetup: pass down in_flags to smbd_smb2_session_setup()
Stefan Metzmacher [Sat, 12 May 2012 07:48:19 +0000 (09:48 +0200)]
s3:smb2_sesssetup: pass down in_flags to smbd_smb2_session_setup()

metze

11 years agos3:smb2_sesssetup: pass down in_previous_session_id to all layers
Stefan Metzmacher [Wed, 18 Apr 2012 13:00:06 +0000 (15:00 +0200)]
s3:smb2_sesssetup: pass down in_previous_session_id to all layers

metze

11 years agolib/socket_wrapper only enable python_socket and socket.py with socket_wrapper
Andrew Bartlett [Sun, 13 May 2012 06:02:22 +0000 (16:02 +1000)]
lib/socket_wrapper only enable python_socket and socket.py with socket_wrapper

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Sun May 13 10:41:27 CEST 2012 on sn-devel-104

11 years agolibreplace: Fix symbol names for snprintf/asprintf/vasprintf.
Jelmer Vernooij [Sun, 13 May 2012 01:21:34 +0000 (03:21 +0200)]
libreplace: Fix symbol names for snprintf/asprintf/vasprintf.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Sun May 13 05:16:28 CEST 2012 on sn-devel-104

11 years agos3:smb2_ioctl: implement FSCTL_VALIDATE_NEGOTIATE_INFO
Stefan Metzmacher [Fri, 11 May 2012 15:45:16 +0000 (17:45 +0200)]
s3:smb2_ioctl: implement FSCTL_VALIDATE_NEGOTIATE_INFO

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Sat May 12 02:50:42 CEST 2012 on sn-devel-104

11 years agos3:smb2_ioctl: implement FSCTL_VALIDATE_NEGOTIATE_INFO_224
Stefan Metzmacher [Fri, 11 May 2012 15:45:16 +0000 (17:45 +0200)]
s3:smb2_ioctl: implement FSCTL_VALIDATE_NEGOTIATE_INFO_224

metze

11 years agos3:smbd: introduce struct smbXsrv_connection
Stefan Metzmacher [Thu, 15 Dec 2011 13:45:56 +0000 (14:45 +0100)]
s3:smbd: introduce struct smbXsrv_connection

This will represent a transport connection for SMB 1 or 2
in the server. smbd_server_connection will slowly be moved
to the SMB_VFS layer to satisfy the existing modules,
but it will hopefully be protocol independend in future.

metze

11 years agos3:smb2_negprot: setup the protocol at the end of the negprot with a real dialect
Stefan Metzmacher [Fri, 11 May 2012 13:19:20 +0000 (15:19 +0200)]
s3:smb2_negprot: setup the protocol at the end of the negprot with a real dialect

metze

11 years agos3/libsmb: Generalise cli_state in smb2 logoff calls
Luk Claes [Thu, 10 May 2012 16:39:11 +0000 (18:39 +0200)]
s3/libsmb: Generalise cli_state in smb2 logoff calls

Signed-off-by: Luk Claes <luk@debian.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agos3/libsmb: Generalise cli_state in smb2 write calls
Luk Claes [Thu, 10 May 2012 16:40:56 +0000 (18:40 +0200)]
s3/libsmb: Generalise cli_state in smb2 write calls

Signed-off-by: Luk Claes <luk@debian.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agos3/libsmb: Generalise cli_state in smb2 query_directory calls
Luk Claes [Thu, 10 May 2012 16:37:43 +0000 (18:37 +0200)]
s3/libsmb: Generalise cli_state in smb2 query_directory calls

Signed-off-by: Luk Claes <luk@debian.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agos3/libsmb: Generalise cli_state in smb2 ioctl calls
Luk Claes [Thu, 10 May 2012 16:36:47 +0000 (18:36 +0200)]
s3/libsmb: Generalise cli_state in smb2 ioctl calls

Signed-off-by: Luk Claes <luk@debian.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agos3/libsmb: Generalise cli_state in smb2 flush calls
Luk Claes [Thu, 10 May 2012 16:35:50 +0000 (18:35 +0200)]
s3/libsmb: Generalise cli_state in smb2 flush calls

Signed-off-by: Luk Claes <luk@debian.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agos3/libsmb: Generalise cli_state in smb2 create calls
Luk Claes [Thu, 10 May 2012 16:34:40 +0000 (18:34 +0200)]
s3/libsmb: Generalise cli_state in smb2 create calls

Signed-off-by: Luk Claes <luk@debian.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agos3/libsmb: Generalise cli_state in smb2 close calls
Luk Claes [Thu, 10 May 2012 16:32:49 +0000 (18:32 +0200)]
s3/libsmb: Generalise cli_state in smb2 close calls

Signed-off-by: Luk Claes <luk@debian.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agos3-libsmb: Generalise cli_state in smb2 read calls
Luk Claes [Thu, 10 May 2012 16:30:25 +0000 (18:30 +0200)]
s3-libsmb: Generalise cli_state in smb2 read calls

Signed-off-by: Luk Claes <luk@debian.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agosmbconf: remove python shebang from wscript_build
Michael Adam [Fri, 11 May 2012 17:13:36 +0000 (19:13 +0200)]
smbconf: remove python shebang from wscript_build

Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Fri May 11 22:05:32 CEST 2012 on sn-devel-104

11 years agos4:lib: remove unused wscript_build file
Michael Adam [Fri, 11 May 2012 16:05:36 +0000 (18:05 +0200)]
s4:lib: remove unused wscript_build file

This only contains a "GENCACHE" subsystem that is not
referenced anywhere.

11 years agoutil: use SMB_ASSERT with panic also in non-developer builds !!!
Michael Adam [Fri, 11 May 2012 14:42:33 +0000 (16:42 +0200)]
util: use SMB_ASSERT with panic also in non-developer builds !!!

This has been around since a long time: In non-developer builds,
we don't panic in SMB_ASSERT but happly continue with the error
condition, which is ridiculous and dangerous...

11 years agoutil: reformat the DEVELOPER definition of SMB_ASSERT
Michael Adam [Fri, 11 May 2012 14:41:18 +0000 (16:41 +0200)]
util: reformat the DEVELOPER definition of SMB_ASSERT

11 years agos3:smb2_ioctl: allow functions to disconnect the smb connection
Stefan Metzmacher [Thu, 10 May 2012 11:47:46 +0000 (13:47 +0200)]
s3:smb2_ioctl: allow functions to disconnect the smb connection

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Fri May 11 20:15:37 CEST 2012 on sn-devel-104

11 years agolibcli/smb/smb_constants: add FSCTL_VALIDATE_NEGOTIATE_INFO*
Stefan Metzmacher [Wed, 9 May 2012 19:32:33 +0000 (21:32 +0200)]
libcli/smb/smb_constants: add FSCTL_VALIDATE_NEGOTIATE_INFO*

metze

11 years agos3:smb2_ioctl: FSCTL_SRV_ENUMERATE_SNAPSHOTS is handles in SMB_VFS_FSCTL()
Stefan Metzmacher [Thu, 10 May 2012 16:33:12 +0000 (18:33 +0200)]
s3:smb2_ioctl: FSCTL_SRV_ENUMERATE_SNAPSHOTS is handles in SMB_VFS_FSCTL()

metze

11 years agos3:smb2_ioctl: call SMB_VFS_FSCTL() as fallback for non SMB2 specific functions
Stefan Metzmacher [Thu, 10 May 2012 15:43:36 +0000 (17:43 +0200)]
s3:smb2_ioctl: call SMB_VFS_FSCTL() as fallback for non SMB2 specific functions

metze

11 years agosamba4: When running samba_dnsupdate during tests, use the test
Jelmer Vernooij [Fri, 11 May 2012 14:01:33 +0000 (16:01 +0200)]
samba4: When running samba_dnsupdate during tests, use the test
smb.conf.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Fri May 11 18:18:53 CEST 2012 on sn-devel-104

11 years agoFix bug #8922.
Jeremy Allison [Fri, 11 May 2012 10:27:01 +0000 (03:27 -0700)]
Fix bug #8922.

Looking at the do_list status returns was historically
ignored, allowing tar to continue after NT_STATUS_ACCESS_DENIED.
Return to this state.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri May 11 14:55:53 CEST 2012 on sn-devel-104

11 years agos3-loadparm: Add synonym "private directory".
Karolin Seeger [Thu, 10 May 2012 14:48:04 +0000 (16:48 +0200)]
s3-loadparm: Add synonym "private directory".

Karolin

Autobuild-User: Karolin Seeger <kseeger@samba.org>
Autobuild-Date: Fri May 11 13:04:03 CEST 2012 on sn-devel-104

11 years agoFix bug 8920, null dereference
Steve Langasek [Wed, 9 May 2012 05:56:00 +0000 (07:56 +0200)]
Fix bug 8920, null dereference

Description: Avoid null dereference in initialize_password_db()
 When initialize_password_db() is called with reload=True, it's assumed that
 the free_private_data member of pdb_methods is non-null.  This is not
 necessarily the case, as the tdb backend has no private data and therefore
 no free function.  Check to see if we have private data that needs freed
 before calling.
Author: Steve Langasek <steve.langasek@ubuntu.com>
Bug-Ubuntu: https://bugs.launchpad.net/bugs/829221

Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Thu May 10 11:07:27 CEST 2012 on sn-devel-104

11 years agos3: Fix Coverity ID 242714 Uninitialized scalar variable
Volker Lendecke [Wed, 9 May 2012 08:56:54 +0000 (10:56 +0200)]
s3: Fix Coverity ID 242714 Uninitialized scalar variable

In an error path we are closing domain_handle without opening it

11 years agos3: Fix Coverity ID 242715 Uninitialized scalar variable
Volker Lendecke [Wed, 9 May 2012 08:56:54 +0000 (10:56 +0200)]
s3: Fix Coverity ID 242715 Uninitialized scalar variable

In an error path we are closing hive_hnd without opening it

11 years agos3: Fix Coverity ID 242716 Uninitialized scalar variable
Volker Lendecke [Wed, 9 May 2012 08:56:54 +0000 (10:56 +0200)]
s3: Fix Coverity ID 242716 Uninitialized scalar variable

In an error path we are closing key_hnd without opening it

11 years agos3: Fix Coverity ID 242717 Uninitialized scalar variable
Volker Lendecke [Wed, 9 May 2012 08:56:54 +0000 (10:56 +0200)]
s3: Fix Coverity ID 242717 Uninitialized scalar variable

In an error path we are closing domain_pol without opening it

11 years agos3: Fix Coverity ID 242718 Uninitialized scalar variable
Volker Lendecke [Wed, 9 May 2012 08:56:54 +0000 (10:56 +0200)]
s3: Fix Coverity ID 242718 Uninitialized scalar variable

In an error path we are closing user_pol without opening it

11 years agos3: Fix Coverity ID 242719 Uninitialized scalar variable
Volker Lendecke [Wed, 9 May 2012 08:56:54 +0000 (10:56 +0200)]
s3: Fix Coverity ID 242719 Uninitialized scalar variable

In an error path we are closing domain_pol without opening it

11 years agos3: Fix Coverity ID 242720 Uninitialized scalar variable
Volker Lendecke [Wed, 9 May 2012 08:56:54 +0000 (10:56 +0200)]
s3: Fix Coverity ID 242720 Uninitialized scalar variable

In an error path we are closing domain_pol without opening it

11 years agos3: Fix Coverity ID 242721 Uninitialized scalar variable
Volker Lendecke [Wed, 9 May 2012 08:56:54 +0000 (10:56 +0200)]
s3: Fix Coverity ID 242721 Uninitialized scalar variable

In an error path we are closing domain_pol without opening it

11 years agos3: Fix Coverity ID 242722 Uninitialized scalar variable
Volker Lendecke [Wed, 9 May 2012 08:56:54 +0000 (10:56 +0200)]
s3: Fix Coverity ID 242722 Uninitialized scalar variable

In an error path we are closing domain_handle without opening it

11 years agos3: Fix Coverity ID 242723 Uninitialized scalar variable
Volker Lendecke [Wed, 9 May 2012 08:56:54 +0000 (10:56 +0200)]
s3: Fix Coverity ID 242723 Uninitialized scalar variable

In an error path we are closing hnd without opening it

11 years agos3: Fix Coverity ID 241961 Uninitialized scalar variable
Volker Lendecke [Wed, 9 May 2012 08:59:49 +0000 (10:59 +0200)]
s3: Fix Coverity ID 241961 Uninitialized scalar variable

11 years agos3: Fix Coverity ID 242724 Uninitialized scalar variable
Volker Lendecke [Wed, 9 May 2012 08:56:54 +0000 (10:56 +0200)]
s3: Fix Coverity ID 242724 Uninitialized scalar variable

In an error path we are closing pol without opening it

11 years agos3: Fix Coverity ID 242725 Uninitialized scalar variable
Volker Lendecke [Wed, 9 May 2012 08:51:54 +0000 (10:51 +0200)]
s3: Fix Coverity ID 242725 Uninitialized scalar variable

Not a functional bug, but we copy all of the "key" structure inside
dcerpc_winreg_CreateKey.

11 years agos3: Fix Coverity ID 242726 Uninitialized scalar variable
Volker Lendecke [Wed, 9 May 2012 08:51:54 +0000 (10:51 +0200)]
s3: Fix Coverity ID 242726 Uninitialized scalar variable

Not a functional bug, but we copy all of the "key" structure inside
dcerpc_winreg_OpenKey.

11 years agos3: Fix Coverity ID 242754 Dereference null return value
Volker Lendecke [Wed, 9 May 2012 08:41:06 +0000 (10:41 +0200)]
s3: Fix Coverity ID 242754 Dereference null return value

11 years agos3: Fix Coverity ID 242184 Dereference after null check
Volker Lendecke [Wed, 9 May 2012 08:30:47 +0000 (10:30 +0200)]
s3: Fix Coverity ID 242184 Dereference after null check

rpc_query_user unconditionally dereferences user_info if successfull

11 years agos3: Fix Coverity ID 242691 Dereference before null check
Volker Lendecke [Wed, 9 May 2012 07:16:54 +0000 (09:16 +0200)]
s3: Fix Coverity ID 242691 Dereference before null check

winreg_printer_openkey above already dereferences winreg_handle

11 years agos3: Fix Coverity ID 242692 Dereference before null check
Volker Lendecke [Wed, 9 May 2012 07:16:54 +0000 (09:16 +0200)]
s3: Fix Coverity ID 242692 Dereference before null check

winreg_printer_openkey above already dereferences winreg_handle

11 years agos3: Fix Coverity ID 242693 Dereference before null check
Volker Lendecke [Wed, 9 May 2012 07:16:54 +0000 (09:16 +0200)]
s3: Fix Coverity ID 242693 Dereference before null check

winreg_printer_openkey above already dereferences winreg_handle

11 years agos3: Fix Coverity ID 242694 Dereference before null check
Volker Lendecke [Wed, 9 May 2012 07:16:54 +0000 (09:16 +0200)]
s3: Fix Coverity ID 242694 Dereference before null check

winreg_printer_openkey above already dereferences winreg_handle

11 years agos3: Fix Coverity ID 242695 Dereference before null check
Volker Lendecke [Wed, 9 May 2012 07:16:54 +0000 (09:16 +0200)]
s3: Fix Coverity ID 242695 Dereference before null check

winreg_printer_openkey above already dereferences winreg_handle

11 years agos3: Fix Coverity ID 242696 Dereference before null check
Volker Lendecke [Wed, 9 May 2012 07:16:54 +0000 (09:16 +0200)]
s3: Fix Coverity ID 242696 Dereference before null check

winreg_printer_openkey above already dereferences winreg_handle

11 years agos3: Fix Coverity ID 242697 Dereference before null check
Volker Lendecke [Wed, 9 May 2012 07:16:54 +0000 (09:16 +0200)]
s3: Fix Coverity ID 242697 Dereference before null check

winreg_printer_openkey above already dereferences winreg_handle

11 years agos3: Fix Coverity ID 242698 Dereference before null check
Volker Lendecke [Wed, 9 May 2012 07:16:54 +0000 (09:16 +0200)]
s3: Fix Coverity ID 242698 Dereference before null check

winreg_printer_openkey above already dereferences winreg_handle

11 years agos3: Fix Coverity ID 242699 Dereference before null check
Volker Lendecke [Wed, 9 May 2012 07:16:54 +0000 (09:16 +0200)]
s3: Fix Coverity ID 242699 Dereference before null check

winreg_printer_openkey above already dereferences winreg_handle

11 years agos3: Fix Coverity ID 242700 Dereference before null check
Volker Lendecke [Wed, 9 May 2012 07:16:54 +0000 (09:16 +0200)]
s3: Fix Coverity ID 242700 Dereference before null check

winreg_printer_openkey above already dereferences winreg_handle

11 years agos3: Fix Coverity ID 242701 Dereference before null check
Volker Lendecke [Wed, 9 May 2012 07:16:54 +0000 (09:16 +0200)]
s3: Fix Coverity ID 242701 Dereference before null check

winreg_printer_openkey above already dereferences winreg_handle

11 years agos3: Fix Coverity ID 242702 Dereference before null check
Volker Lendecke [Wed, 9 May 2012 07:16:54 +0000 (09:16 +0200)]
s3: Fix Coverity ID 242702 Dereference before null check

winreg_printer_openkey above already dereferences winreg_handle

11 years agos3: Fix Coverity ID 242703 Dereference before null check
Volker Lendecke [Wed, 9 May 2012 07:16:54 +0000 (09:16 +0200)]
s3: Fix Coverity ID 242703 Dereference before null check

winreg_printer_openkey above already dereferences winreg_handle

11 years agos3: Fix Coverity ID 242704 Dereference before null check
Volker Lendecke [Wed, 9 May 2012 07:16:54 +0000 (09:16 +0200)]
s3: Fix Coverity ID 242704 Dereference before null check

winreg_printer_openkey above already dereferences winreg_handle

11 years agos3: Fix Coverity ID 242705 Dereference before null check
Volker Lendecke [Wed, 9 May 2012 07:16:54 +0000 (09:16 +0200)]
s3: Fix Coverity ID 242705 Dereference before null check

winreg_printer_openkey above already dereferences winreg_handle

11 years agos3: Fix Coverity ID 242706 Dereference before null check
Volker Lendecke [Wed, 9 May 2012 07:16:54 +0000 (09:16 +0200)]
s3: Fix Coverity ID 242706 Dereference before null check

winreg_printer_openkey above already dereferences winreg_handle