Jeremy Allison [Tue, 29 Aug 2006 01:11:02 +0000 (01:11 +0000)]
r17902: Fix possible null deref caught by Stanford checker.
Jeremy.
(This used to be commit
e8b0649fe167c3446eb6121ed666254fdf53aa58)
Jeremy Allison [Tue, 29 Aug 2006 01:04:25 +0000 (01:04 +0000)]
r17901: Stanford checker fix. cookie here can't be null or we'd
deref null. Make interface explicit.
Jeremy.
(This used to be commit
4e99606ec16b978a76219b5362a23a7b06ee5468)
Jeremy Allison [Tue, 29 Aug 2006 00:56:08 +0000 (00:56 +0000)]
r17900: Fix from Michael Adam <ma@sernet.de> - make internal_resolve_name
do what it's supposed to.
Jeremy.
(This used to be commit
4b7387a054bfc1587e0b9b7088f420a5bcf0bad9)
Jeremy Allison [Tue, 29 Aug 2006 00:53:28 +0000 (00:53 +0000)]
r17899: Fix Stanford checker bug - possible null deref.
Jeremy.
(This used to be commit
e77949175144cbe4cfa58788d13acc704eebc251)
Jeremy Allison [Mon, 28 Aug 2006 23:01:30 +0000 (23:01 +0000)]
r17897: Store the uid in the memory creds. Don't request the
krb5 refresh creds when doing cached NTLM auth, request
the memory creds instead.
Jeremy.
(This used to be commit
310ac0b226edcfd5bedc2c3305a05993db20c7af)
Volker Lendecke [Mon, 28 Aug 2006 18:25:55 +0000 (18:25 +0000)]
r17896: Reformatting. I did not want to do it anymore, but these ones looked just
silly :-)
Volker
(This used to be commit
8b6f5937db4b18db711dd0c4f1ae904087249000)
Volker Lendecke [Mon, 28 Aug 2006 09:19:30 +0000 (09:19 +0000)]
r17881: Another microstep towards better error reporting: Make get_sorted_dc_list
return NTSTATUS.
If we want to differentiate different name resolution problems we might want
to introduce yet another error class for Samba-internal errors. Things like no
route to host to the WINS server, a DNS server explicitly said host not found
etc might be worth passing up.
Because we can not stash everything into the existing NT_STATUS codes, what
about a Samba-specific error class like NT_STATUS_DOS and NT_STATUS_LDAP?
Volker
(This used to be commit
60a166f0347170dff38554bed46193ce1226c8c1)
Volker Lendecke [Mon, 28 Aug 2006 07:56:15 +0000 (07:56 +0000)]
r17880: On host "tridge" in the build farm the tests fail because smbd hangs in in
'connecting to cups server on localhost'. There is no cups on that host, but
the TCP connection hangs in SYN_SENT. Probably some firewall rule.
Work around that.
Volker
(This used to be commit
ab4e7b34da00c2a8f3244d84f08037ddfadf85d5)
Jeremy Allison [Mon, 28 Aug 2006 05:41:32 +0000 (05:41 +0000)]
r17879: Make it explicit that we can never pass NULL for buflen or stringlen.
Stanford Checker fix.
Jeremy.
(This used to be commit
2d8bdd2dce633253780a5b0378f229893d049666)
Jeremy Allison [Mon, 28 Aug 2006 05:35:27 +0000 (05:35 +0000)]
r17878: Fix possible null deref found by Stanford checker.
Jeremy.
(This used to be commit
ae20201494f44cb98e58ba98531a79feeeb82b47)
Jeremy Allison [Mon, 28 Aug 2006 05:27:30 +0000 (05:27 +0000)]
r17877: Make it explicit to the checker that we can never pass
in NULL as ctr to a void returning fn.
Jeremy.
(This used to be commit
397ab2b1ab72093ba0572493b2e97a93dfc75478)
Jeremy Allison [Mon, 28 Aug 2006 05:22:10 +0000 (05:22 +0000)]
r17875: Fix (rather theoretical, but still...) null deref found by
Stanford checker.
Jeremy.
(This used to be commit
45d77ae12235e6b39cc30845d69ac3777d3eefd0)
Jeremy Allison [Mon, 28 Aug 2006 05:10:56 +0000 (05:10 +0000)]
r17874: Fix possible null deref found by Stanford checker.
Jeremy.
(This used to be commit
2894310cc8cddaec2a67f1af0ab62cc559283e77)
Jeremy Allison [Mon, 28 Aug 2006 04:55:05 +0000 (04:55 +0000)]
r17873: Fix possible null deref found by Stanford checker.
Jeremy.
(This used to be commit
1adb3b2432187e9a19b78cfa5762c3e05a357392)
Jeremy Allison [Mon, 28 Aug 2006 04:52:36 +0000 (04:52 +0000)]
r17872: Fix possible null deref found by the Stanford checker.
Jeremy.
(This used to be commit
ac06fc42cb9b1e2304d44653614aeaa7c537f34b)
Jeremy Allison [Mon, 28 Aug 2006 03:15:06 +0000 (03:15 +0000)]
r17869: More sensible fix for Stanford Checker null deref.
Jeremy.
(This used to be commit
2a73e82f9663fc0e14b4c2af94de3b4216f1eece)
Jeremy Allison [Mon, 28 Aug 2006 02:29:36 +0000 (02:29 +0000)]
r17867: Fix null deref in error code path. Found by the
Stanford checker.
Jeremy.
(This used to be commit
09652dc71ce13bd305e653557e43731378398dd6)
Jeremy Allison [Mon, 28 Aug 2006 02:27:49 +0000 (02:27 +0000)]
r17866: Fix possible null deref - found by Stanford checker.
Jeremy.
(This used to be commit
84e8cc0593c20b1262965a320d89b72a3dc9b402)
Jeremy Allison [Mon, 28 Aug 2006 02:24:15 +0000 (02:24 +0000)]
r17865: Fix what the Stanford checker reported as a possible
deref. I think this is a false positive, but it's
an easy extra check to add here.
Jeremy.
(This used to be commit
7d3b11ab18e2c793d43b6eed1803f2183b7b2daa)
Jeremy Allison [Mon, 28 Aug 2006 02:13:50 +0000 (02:13 +0000)]
r17864: Fix possible null deref if client doesn't give us
an answer record. Found by the Stanford checker.
Jeremy.
(This used to be commit
1ec77c50118de808f710b17f878b1e80d4e351d5)
Jeremy Allison [Mon, 28 Aug 2006 01:56:17 +0000 (01:56 +0000)]
r17863: Fix unneeded NULL check on pointer parameters causing the
Stanford checker to flag null deref.
Jeremy.
(This used to be commit
b7fc023e9025127855fab71002d556e5f84e00b4)
Jeremy Allison [Mon, 28 Aug 2006 01:48:04 +0000 (01:48 +0000)]
r17862: Fix possible NULL deref (like rev 17861) found by the
Stanford group.
Jeremy.
(This used to be commit
cfd39c2804df3f67637adf223542daa208c893c7)
Jeremy Allison [Mon, 28 Aug 2006 01:44:40 +0000 (01:44 +0000)]
r17861: Fix inconsistency found in checking for NULL in DLIST_REMOVE
macro. Don't check for NULL if we would have already derefed.
Jeremy.
(This used to be commit
1cb379315a45a0c47feab0df1f07ec5d808a4259)
Volker Lendecke [Sun, 27 Aug 2006 17:36:17 +0000 (17:36 +0000)]
r17855: Fix the build on systems without LDAP
(This used to be commit
2e9f5c520a843ad22088388d155a172a63c140d5)
Volker Lendecke [Sun, 27 Aug 2006 17:24:31 +0000 (17:24 +0000)]
r17854: Steal the LDAP in NTSTATUS trick from Samba4
Thanks to Michael Adam <ma@sernet.de>
Volker
(This used to be commit
91878f9b6fbe5187fb7d0464008ea0abe7f11a73)
Volker Lendecke [Sun, 27 Aug 2006 16:50:10 +0000 (16:50 +0000)]
r17853: Fix an uninitialized variable (m_time2). Jeremy, please check.
Thanks,
Volker
(This used to be commit
389910b2d376bc5795b0afacb86e45d7a6987491)
Volker Lendecke [Sun, 27 Aug 2006 16:24:03 +0000 (16:24 +0000)]
r17852: Remove a pointless NULL assignment
(This used to be commit
9f27824257924485a39bb60f00c9de02f869c4ff)
Volker Lendecke [Sun, 27 Aug 2006 16:14:31 +0000 (16:14 +0000)]
r17851: Fix a warning & attempt to fix the Tru64 build
(This used to be commit
b05cac3cb5b35fa305f3d881012cc8e7eca87bd8)
Volker Lendecke [Sun, 27 Aug 2006 14:55:46 +0000 (14:55 +0000)]
r17850: Another dummy checkin for the build farm to retry
(This used to be commit
ac7087a6516fa7e0d10523a892acae852a80e29e)
Volker Lendecke [Sat, 26 Aug 2006 22:59:58 +0000 (22:59 +0000)]
r17847: Dummy commit
(This used to be commit
cdcea36095a50a92ec1311979b8b2c572b971eaf)
Volker Lendecke [Sat, 26 Aug 2006 20:56:49 +0000 (20:56 +0000)]
r17845: Remove a Solaris warning
(This used to be commit
ec42ec31c05afb785adbe3c14f903889178df184)
Jeremy Allison [Sat, 26 Aug 2006 02:53:45 +0000 (02:53 +0000)]
r17837: Split out the storing of memory cached credentials
from the krb5 ticket renewal code. This allows cached
credentials to be stored for single sign-on via ntlm_auth
for machines in a domain still using NTLM. Also (hopefully)
fixes the reference counting problem with pam_logon/logoff
so multiple logons/logoffs won't lose cached credentials.
This compiles, but I'm intending to test it over the weekend
so don't complain too much :-). I also want it in the tree
so Coverity can scan it for errors. Guenther, check this over
please - I ran through the architecture with Jerry and he's
ok with it, but this is modifying your code a lot.
Jeremy.
(This used to be commit
679eeeb91155dad3942efde6ae9f8d81faf18c5b)
Volker Lendecke [Fri, 25 Aug 2006 19:13:37 +0000 (19:13 +0000)]
r17836: Don't create zombies in the children, thanks to Jeremy!
Volker
(This used to be commit
c0767c08d01a429e1abf7205c14acec5e103ca91)
Volker Lendecke [Fri, 25 Aug 2006 18:24:43 +0000 (18:24 +0000)]
r17835: Fix Coverity bugs 306, 309, 310.
Jeremy, you might want to look at the trans2 one.
Volker
(This used to be commit
d727fc681c073a1b09accd31a07341b58e10eebb)
Jeremy Allison [Fri, 25 Aug 2006 16:25:09 +0000 (16:25 +0000)]
r17834: Another bug found by Volker's tests in the build farm !
Correctly map large nt timevals to TIME_T_MAX.
Jeremy.
(This used to be commit
63b13d28795bbce6d9fe9e0aa4f518ef94c44f18)
Volker Lendecke [Fri, 25 Aug 2006 15:08:05 +0000 (15:08 +0000)]
r17833: Next step to fix the build farm.
Jerry, why don't you include "includes.h"?
Thanks,
Volker
(This used to be commit
c02970c27251d7cd1f5a14a8ac7671d8e4325f5d)
Volker Lendecke [Fri, 25 Aug 2006 14:52:30 +0000 (14:52 +0000)]
r17832: Fix bug 4050
(This used to be commit
0504cf6d13c81d90a2457a01a78630d105af0ebc)
Volker Lendecke [Fri, 25 Aug 2006 14:25:06 +0000 (14:25 +0000)]
r17831: Attempt to fix the build farm: 0x7fffffffffffffff needs special casing too I
think. This broke 'make test' because the newly created user was set to be
kicked off Mi, 22 Jan 1975 23:55:33 CET (unix time
159663333) with the
setuserinfo21 call.
I'm not 100% sure that 0x7ff... means max time as I do it here, I vaguely
remember it to mean "don't touch".
Does anybody know that for sure?
Jeremy, please check this.
Thanks,
Volker
(This used to be commit
872d1299ebffb7b7d696013fc676820f1fa1777c)
Jelmer Vernooij [Fri, 25 Aug 2006 03:17:47 +0000 (03:17 +0000)]
r17819: Add some more ignores.
(This used to be commit
8ffe17893092d95e767ca0baa5f766b106a1eed8)
Jeremy Allison [Thu, 24 Aug 2006 23:39:37 +0000 (23:39 +0000)]
r17818: Fixup uint64 time calc. NT time is a 64 bit number,
not high value seconds, low value 100ns units.
Jeremy.
(This used to be commit
ead75870d5d3c690fabd131a9dd8776e854638dc)
Jelmer Vernooij [Thu, 24 Aug 2006 23:21:43 +0000 (23:21 +0000)]
r17817: Disable compilation of LIBNDR (it uses uint64_t).
(This used to be commit
4928d560b0fbad31e0245178ce8f6fed36a488ca)
Jelmer Vernooij [Thu, 24 Aug 2006 22:10:59 +0000 (22:10 +0000)]
r17816: Merge my cupsprot branch. It is now possible to (optionally) specify :port in
the "cups server" smb.conf parameter.
(This used to be commit
3f665f4ec4cda80cc20e050458e150c086dc1412)
Gerald Carter [Thu, 24 Aug 2006 22:10:42 +0000 (22:10 +0000)]
r17815: Revert Volker's change in 16014. I really do not believe
the this should be necessary. If there is still a bug,
I believe that setting thr group RID from the passdb is
masking it. Not fixing it. It is very likely that
the change was necessary before but is no longer
with the recent changes. But I'm not taking the chance
of merging it to 3.0.23c. :-)
(This used to be commit
1a5b90f3c1aa5dcaa29a9d62288d9e4dbc596f96)
Jelmer Vernooij [Thu, 24 Aug 2006 22:08:02 +0000 (22:08 +0000)]
r17814: Add .bzrignore file
(This used to be commit
5018bb91e704407a97515cdf74cccb6d7c30f027)
Gerald Carter [Thu, 24 Aug 2006 22:05:53 +0000 (22:05 +0000)]
r17813: Remove another instance of manually setting the group SID.
The would have been primaryly used when adding a user to
an smbpasswd file, but could have been introduce to other
backends by using pdbedit -i -e.
The symptom was
[2006/08/09 13:07:43, 0] rpc_parse/parse_samr.c:init_sam_user_info21A(6276)
init_sam_user_info_21A: User nobody has Primary Group SID S-1-22-2-99,
which conflicts with the domain sid S-1-5-21-
1825997848-
4107600307-
1754506280.
Failing operation.
(This used to be commit
0a3aa8b43ace8c635423c2df10827e81d145b58f)
Jeremy Allison [Thu, 24 Aug 2006 21:37:10 +0000 (21:37 +0000)]
r17812: Fix bad unsigned comparisons with TIME_T_MIN/TIME_T_MAX.
Jeremy.
(This used to be commit
bd1fbdfb824883060b02be969a10f999d387973f)
Jelmer Vernooij [Thu, 24 Aug 2006 20:52:43 +0000 (20:52 +0000)]
r17810: Use datarootdir variable generated by newer autoconf versions. (fixes warning)
(This used to be commit
836f04134f95d8452cee58a72438b4387103ce11)
Jeremy Allison [Thu, 24 Aug 2006 20:51:57 +0000 (20:51 +0000)]
r17809: Add in 64-bit integer time calculations (taken from
Samba4) for machines that have 64-bit integers. Leave
the (double) code for machines that don't. Needs
testing.... :-).
Jeremy.
(This used to be commit
9e65c175b0794bea3082785b5da6f5b281887ce7)
Volker Lendecke [Thu, 24 Aug 2006 20:42:31 +0000 (20:42 +0000)]
r17807: Fix a file descriptor leak pointed out by John Malmberg. Thanks!
Volker
(This used to be commit
fac007ccbec75f5ee9ff2769d8add4d27e62167d)
Jelmer Vernooij [Thu, 24 Aug 2006 20:27:42 +0000 (20:27 +0000)]
r17806: Make NTTIME a UINT64_S rather than a separate structure consisting of
two uint32s.
(This used to be commit
3556a9c26cf7728e2435bb28e69958751e883ab9)
Volker Lendecke [Thu, 24 Aug 2006 20:17:59 +0000 (20:17 +0000)]
r17805: Sorry Jerry, I could not stand the warnings... :-)
(This used to be commit
f5fcafd77e8a749659ef90296402c5130f45419b)
Volker Lendecke [Thu, 24 Aug 2006 19:56:20 +0000 (19:56 +0000)]
r17804: Fix a enum/int mixup found by the IRIX compiler.
Volker
(This used to be commit
3a1cf623765cd8b6615ad317d25cebc379c762a2)
Gerald Carter [Thu, 24 Aug 2006 18:48:44 +0000 (18:48 +0000)]
r17803: finally get the new libaddns code to build on Solaris 9
(This used to be commit
6a4f4ce016dc47ff4b433208266c4616be7e2770)
Gerald Carter [Thu, 24 Aug 2006 18:09:05 +0000 (18:09 +0000)]
r17802: trying to fix more build farm hosts
(This used to be commit
d16fea385aba11b6dad141298694320c803bf3eb)
Gerald Carter [Thu, 24 Aug 2006 16:56:36 +0000 (16:56 +0000)]
r17801: bad merge ? No sure how the second half of the LIBNDR_OBJ value got cut...
(This used to be commit
3662f86f41b83a5c944294ca02b6e216ee87f88c)
Jeremy Allison [Thu, 24 Aug 2006 16:44:00 +0000 (16:44 +0000)]
r17800: Start using struct timespec internally for file times
on the wire. This allows us to go to nsec resolution
for systems that support it. It should also now be
easy to add a correct "create time" (birth time)
for systems that support it (*BSD). I'll be watching
the build farm closely after this one for breakage :-).
Jeremy.
(This used to be commit
425280a1d23f97ef0b0be77462386d619f47b21d)
Gerald Carter [Thu, 24 Aug 2006 16:33:50 +0000 (16:33 +0000)]
r17799: Start fixing the building carnage. Only include calls to
uuid lib fucntions when WITH_DNS_UPDATES is defined.
(This used to be commit
3c547202856378cb1b6895b8c5dd0c9e43c66a1f)
Gerald Carter [Thu, 24 Aug 2006 15:43:32 +0000 (15:43 +0000)]
r17798: Beginnings of a standalone libaddns library released under
the LGPL. Original code by Krishna Ganugapati <krishnag@centeris.com>.
Additional work by me.
It's still got some warts, but non-secure updates do
currently work. There are at least four things left to
really clean up.
1. Change the memory management to use talloc() rather than
malloc() and cleanup the leaks.
2. Fix the error code reporting (see initial changes to
dnserr.h)
3. Fix the secure updates
4. Define a public interface in addns.h
5. Move the code in libads/dns.c into the libaddns/ directory
(and under the LGPL).
A few notes:
* Enable the new code by compiling with --with-dnsupdate
* Also adds the command 'net ads dns register'
* Requires -luuid (included in the e2fsprogs-devel package).
* Has only been tested on Linux platforms so there may be portability
issues.
(This used to be commit
36f04674aeefd93c5a0408b8967dcd48b86fdbc1)
Gerald Carter [Thu, 24 Aug 2006 12:49:18 +0000 (12:49 +0000)]
r17797: Just say "ok" when trying to rename a local group to its same name.
(This used to be commit
e6e54125003373f83e6900668ceb9981e8620776)
Gerald Carter [Thu, 24 Aug 2006 12:13:57 +0000 (12:13 +0000)]
r17795: Finally track down the "ads_connect: Interrupted system call"
error. Fix our DNS SRV lookup code to deal with multi-homed hosts.
We were noly remembering one IP address per host from the Additional
records section in the SRV response which could have been an unreachable
address.
(This used to be commit
899179d2b9fba13cc6f4dab6efc3c22e44e062bc)
Jeremy Allison [Thu, 24 Aug 2006 01:34:33 +0000 (01:34 +0000)]
r17767: Argggg. Broke the build. Need to fix callers of put_long_date()
and interpret_long_date() first. Reverting...
Jeremy.
(This used to be commit
5d9c308e7b780c956f9810c9f345d1ef32d0f528)
Jeremy Allison [Thu, 24 Aug 2006 01:31:00 +0000 (01:31 +0000)]
r17766: Getting ready to properly expose 100ns times on
the wire. Move the internals of nt_time functions
to use struct timespecs.
Jeremy.
(This used to be commit
4ece92f7ef070c86ee7c6f523a207cfaccf84478)
Jeremy Allison [Wed, 23 Aug 2006 22:33:50 +0000 (22:33 +0000)]
r17761: Handle times consistently across all client utils.
Fixes bugs reported in libsmbclient.
Jeremy.
(This used to be commit
42a417fb75313b093948602c3be8e2f386048b5f)
Gerald Carter [Wed, 23 Aug 2006 21:04:47 +0000 (21:04 +0000)]
r17760: The DNS SRV lookup already sorts by priority and weight so don't
use the generic IP list sort in get_sorted_dc_list().
(This used to be commit
03a767539d5b09ebd6564c0c9157de2a6e0e6b89)
Gerald Carter [Wed, 23 Aug 2006 02:45:45 +0000 (02:45 +0000)]
r17736: Apply the Unix group patch when creating the token for a
username map.
(This used to be commit
0298a3466bc6c5e322db7dac386e4e5eef0e2702)
Gerald Carter [Tue, 22 Aug 2006 22:53:08 +0000 (22:53 +0000)]
r17723: * BUG 3969: Fix unsigned time comparison with expiration policy from AD DC
* Merge patches from SLES10 to make sure we talk to the correct
winbindd process when performing pam_auth (and pull the password policy info).
(This used to be commit
43bd8c00abb38eb23a1497a255d194fb1bbffffb)
Gerald Carter [Tue, 22 Aug 2006 16:01:24 +0000 (16:01 +0000)]
r17710: Thanks to Thomas Bork for testing and continued feedback on this.
Comments from the patch:
/* Add the "Unix Group" SID for each gid to catch mapped groups
and their Unix equivalent. This is to solve the backwards
compatibility problem of 'valid users = +ntadmin' where
ntadmin has been paired with "Domain Admins" in the group
mapping table. Otherwise smb.conf would need to be changed
to 'valid user = "Domain Admins"'. --jerry */
(This used to be commit
3848199287c5829aef66d0dee38a79056fe1ff5c)
Gerald Carter [Tue, 22 Aug 2006 15:18:13 +0000 (15:18 +0000)]
r17709: Fix cut-n-paste error with the name of gid_to_unix_group_sid().
(This used to be commit
dda0b8bce6b7e0146badd8aeb52b5cce6289de21)
Günther Deschner [Tue, 22 Aug 2006 00:36:31 +0000 (00:36 +0000)]
r17677: There is no need for a 2nd krb5_to_nt_status function, is there?
Michael Adam/Volker, please check.
Guenther
(This used to be commit
d0feb85781f69325ee70aff98370cfac037c4cc2)
Jeremy Allison [Mon, 21 Aug 2006 23:30:39 +0000 (23:30 +0000)]
r17676: Fix printing bug found by kukks. Don't copy a return
value into an auto on the stack that gets removed when
we return from the frame :-).
Jeremy.
(This used to be commit
85bf8a16116e5eb9d4400e809531737d45890abb)
Gerald Carter [Mon, 21 Aug 2006 21:53:02 +0000 (21:53 +0000)]
r17673: volker's patch for re-adding Getpwnam() lookups to smbpasswd backend (I hate username level)
(This used to be commit
0939b6e20c6aef7a203c92fb0afa207c9fa779dd)
Gerald Carter [Mon, 21 Aug 2006 21:25:17 +0000 (21:25 +0000)]
r17672: remove duplicate description on NT_STATUS_INVALID_PARAMETER (from Michael Adam <ma@sernet.de>)
(This used to be commit
7b51e27d026f2511edcde054f0d2deb9932d2fe8)
Gerald Carter [Mon, 21 Aug 2006 20:04:01 +0000 (20:04 +0000)]
r17669: Remove RID algorithm support from unmapped users and groups
when using smbpasswd
(This used to be commit
dde552336c732ddd6076a6a32575a37cb51aa94c)
Jeremy Allison [Mon, 21 Aug 2006 20:03:32 +0000 (20:03 +0000)]
r17668: Fix the miscalculations in pushing announces. Fixes
problems Kukks reported.
Jeremy.
(This used to be commit
426d722029b245e239f0ee39b6be249c59e1918c)
Jeremy Allison [Mon, 21 Aug 2006 17:58:41 +0000 (17:58 +0000)]
r17667: Merge snprintf fixes from tridge (Samba4).
Jeremy.
----------
several replacement snprintf() fixes.
1) when running the testsuite, actually test against the system
sprintf(), not against ourselves (doh!)
2) fix the buffer termination to terminate buf2 as well
3) fix handling of %llu, and add a simple test
This fixes a bug with password expiry on solaris
----------
(This used to be commit
64fd96666f391101c41b7a564fd20ab2e93e3923)
Jeremy Allison [Sun, 20 Aug 2006 20:05:49 +0000 (20:05 +0000)]
r17630: Looks like getpeerid() is a system function on
FreeBSD. Change to sys_getpeerid(). Thanks to
vl for pointing this out.
Jeremy.
(This used to be commit
dd0069cfcabb25dc7dc0d336696a5f2580abb5a1)
Volker Lendecke [Sun, 20 Aug 2006 17:55:06 +0000 (17:55 +0000)]
r17626: Some C++ Warnings
(This used to be commit
09e7c010f03ac3c621f7a7fad44685d278c1481a)
Volker Lendecke [Sun, 20 Aug 2006 17:46:20 +0000 (17:46 +0000)]
r17625: Fix the build
(This used to be commit
76ef8af881843685a5b14c9017cba32f6867bd28)
Volker Lendecke [Sun, 20 Aug 2006 17:30:27 +0000 (17:30 +0000)]
r17623: Revert accidential commit
(This used to be commit
8dcc4e7dd6dd879f341b58fc04cb1308c0463862)
Volker Lendecke [Sun, 20 Aug 2006 17:29:00 +0000 (17:29 +0000)]
r17622: Add a framework for a printing backend designed to support the build farm. If
we want to walk more printing code in the build farm I think doing that with a
customized printing backend is much easier than with a set of shell scripts.
Jerry, comments?
Volker
(This used to be commit
949cd6b992364d2bc60fd59051b6ac1c4cc4288c)
Volker Lendecke [Sun, 20 Aug 2006 17:08:37 +0000 (17:08 +0000)]
r17620: Fix two C++ Warnings and a memleak
(This used to be commit
d7246284e0117f7a97b3cbb80ff45b532559bf63)
Jeremy Allison [Sun, 20 Aug 2006 03:56:27 +0000 (03:56 +0000)]
r17618: Not using a cache version number (yet). We really should...
Jeremy
(This used to be commit
b711587f6e33bc5781b15da7bc49b31db4653073)
Jeremy Allison [Sun, 20 Aug 2006 03:53:42 +0000 (03:53 +0000)]
r17617: Take Andrew Bartletts excellent advice and don't store
the nt hash directly in the winbindd cache, store a
salted version (MD5 of salt + nt_hash). This is what
we do in the LDAP password history code. We store
this salted cache entry under the same name as an old
entry (CRED/<sid>) but detect it on read by checking
if there are 17 bytes of data after the first stored
hash (1 byte len, 16 bytes hash). GD PLEASE CHECK.
Jeremy.
(This used to be commit
89d0163a97edaa46049406ea3e2152bee4e0d1b2)
Jeremy Allison [Sun, 20 Aug 2006 01:25:26 +0000 (01:25 +0000)]
r17616: Add the lm and nt hashes to the cached credentials
stored - only store the password if we're going to
be doing a krb5 refresh. GD please review this change !
Now to add code to reference count the cached creds
(to allow multiple pam_logon/pam_logoffs to keep the
creds around), ensure that the cred cache is called
on all successful pam_logons (if we have winbindd cache
pam credentials = true, set this by default) and finally
ensure the creds cache is changed on successful password
change. GD - you *really* need to review this :-).
Jeremy.
(This used to be commit
017e7e14958d29246a1b221e33755bb91e96b08f)
Jeremy Allison [Sat, 19 Aug 2006 20:42:04 +0000 (20:42 +0000)]
r17612: Modify NTLMSSP session code so that it doesn't store
a copy of the plaintext password, only the NT and LM
hashes (all it needs). Fix smbencrypt to expose hash
verions of plaintext function. Andrew Bartlett, you
might want to look at this for gensec.
This should make it easier for winbindd to store
cached credentials without having to store plaintext
passwords in an NTLM-only environment (non krb5).
Jeremy.
(This used to be commit
629faa530f0422755823644f1c23bea74830912f)
Jeremy Allison [Sat, 19 Aug 2006 01:04:54 +0000 (01:04 +0000)]
r17610: Added the ability for firefox to drive the winbindd
ntlm_auth module to allow it to use winbindd cached
credentials.The credentials are currently only stored
in a krb5 MIT environment - we need to add an option to
winbindd to allow passwords to be stored even in an NTLM-only
environment.
Patch from Robert O'Callahan, modified with some fixes
by me.
Jeremy.
(This used to be commit
ae7cc298a113d8984557684bd6ad216cbb27cff3)
Volker Lendecke [Fri, 18 Aug 2006 16:25:09 +0000 (16:25 +0000)]
r17607: Adapt the Samba4 directory structure for tdb. Makes it easier to diff.
Let's see what it breaks. For me it works :-)
Volker
(This used to be commit
337be14b432e5dfd80c7418b2db4fe0087259b77)
Volker Lendecke [Fri, 18 Aug 2006 15:10:46 +0000 (15:10 +0000)]
r17606: Introduce krb5_to_ntstatus.
Thanks to Michael Adam <ma@sernet.de>
Volker
(This used to be commit
6e641c90b8f52a822a83701cdf305c60416d7f0c)
Volker Lendecke [Fri, 18 Aug 2006 14:05:25 +0000 (14:05 +0000)]
r17605: Some C++ warnings
(This used to be commit
05268d7a731861b10ce8556fd32a004808383923)
Volker Lendecke [Fri, 18 Aug 2006 13:37:36 +0000 (13:37 +0000)]
r17604: Fix a bug caught by g++.
Jeremy, please check this!
Volker
(This used to be commit
8117a7b3bf3f273dd018c42864b3136dec47ec79)
Volker Lendecke [Fri, 18 Aug 2006 12:45:51 +0000 (12:45 +0000)]
r17603: Make net_ads_join_ok return NTSTATUS.
Thanks to Michael Adam <ma@sernet.de>
hop, hop, hop... ;-)
Volker
(This used to be commit
47facab798bdc6e20b2620972f1b8f2338fac239)
Volker Lendecke [Fri, 18 Aug 2006 12:39:21 +0000 (12:39 +0000)]
r17602: Make check_ads_config return NTSTATUS, set some error codes in net_ads_join.
Thanks to Michael Adam <ma@sernet.de>
Volker
(This used to be commit
27cca861507afa9caf694ef89e543c86de01c2cd)
Jeremy Allison [Thu, 17 Aug 2006 19:49:54 +0000 (19:49 +0000)]
r17595: Fix from Ben Winslow <rain@bluecherry.net> to allow
client smb signing to be correctly turned off.
Jeremy.
(This used to be commit
61f052b0a67b8a05b5d925bf8bbad73369ac03bd)
Volker Lendecke [Thu, 17 Aug 2006 15:04:53 +0000 (15:04 +0000)]
r17592: Remove some unused functions pointed out by John E. Malmberg, make
do_file_lock static to pdb_smbpasswd.c, the only user of it.
Volker
(This used to be commit
543f77a45f0a75ede48b0f2c674a0abdd386fed5)
Volker Lendecke [Thu, 17 Aug 2006 14:38:59 +0000 (14:38 +0000)]
r17591: machine_account is unused, and ctx must be freed. Thanks Michael
(This used to be commit
a347f8a9c480cf09abac9144e04ab2b13457e3b0)
Volker Lendecke [Thu, 17 Aug 2006 14:28:03 +0000 (14:28 +0000)]
r17590: Some C++ Warnings
(This used to be commit
b7ec240880af0072ef20b2c0d688ef3cc386d484)
Volker Lendecke [Thu, 17 Aug 2006 13:46:02 +0000 (13:46 +0000)]
r17589: Check in the really uncontroversial patch from Michael
(This used to be commit
de76217cfb9d20431189e838999a634e4de067a9)
Volker Lendecke [Thu, 17 Aug 2006 12:44:59 +0000 (12:44 +0000)]
r17585: Don't let ads_status throw away the error information.
Thanks to Michael Adam <ma@sernet.de>.
Volker
(This used to be commit
ea3a4142a0f2140d8743a50518ae94df2d84d972)
Volker Lendecke [Thu, 17 Aug 2006 11:54:23 +0000 (11:54 +0000)]
r17584: Some C++ Warnings
(This used to be commit
f6194cf4b263454bbdf180a7d014ffc3498df497)
Volker Lendecke [Thu, 17 Aug 2006 10:01:48 +0000 (10:01 +0000)]
r17583: Change internal cli_session_setup functions to NTSTATUS.
Volker
(This used to be commit
990da03f0940371d20f89c145b7ebdbe8e9bf4c4)