nivanova/samba-autobuild/.git
2 years agos4/pyrpc_util: appropriately decrement refcounts on failure
Douglas Bagnall [Wed, 2 May 2018 21:53:56 +0000 (09:53 +1200)]
s4/pyrpc_util: appropriately decrement refcounts on failure

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
2 years agos3/py_passdb: maintain correct refcount on allocation failure
Douglas Bagnall [Wed, 2 May 2018 21:39:18 +0000 (09:39 +1200)]
s3/py_passdb: maintain correct refcount on allocation failure

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
2 years agopython/modules: maintain correct refcount for path items
Douglas Bagnall [Wed, 2 May 2018 22:45:39 +0000 (10:45 +1200)]
python/modules: maintain correct refcount for path items

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
2 years agotests: don't rely on implicit int return type
David Disseldorp [Sun, 27 Jan 2019 12:31:16 +0000 (13:31 +0100)]
tests: don't rely on implicit int return type

Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Tue Jan 29 03:47:27 CET 2019 on sn-devel-144

2 years agos3/lib: clean up have_syscall() formatting
David Disseldorp [Sat, 26 Jan 2019 23:41:28 +0000 (00:41 +0100)]
s3/lib: clean up have_syscall() formatting

Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2 years agos3/lib: don't rely on implicit int return type
David Disseldorp [Sat, 26 Jan 2019 23:41:28 +0000 (00:41 +0100)]
s3/lib: don't rely on implicit int return type

C99 removed this behaviour.

Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2 years agos4:torture: Enforce Printer Class
Justin Stephenson [Tue, 20 Nov 2018 16:25:49 +0000 (11:25 -0500)]
s4:torture: Enforce Printer Class

Ensure that the provided inf defines Class=Printer for driver installation
to succeed.

Some driver packages(HP Universal Print Driver) include inf files with
other device types such as Class=USB. Attempting to install these will fail
when tested against Windows Server 2016 Print server using
iremotewinspool RPC calls.

Signed-off-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Bjoern Jacke <bjacke@samba.org>
Autobuild-User(master): Björn Jacke <bjacke@samba.org>
Autobuild-Date(master): Mon Jan 28 19:34:41 CET 2019 on sn-devel-144

2 years agos4:torture: Uninstall driver and cleanup
Justin Stephenson [Mon, 15 Oct 2018 21:02:03 +0000 (17:02 -0400)]
s4:torture: Uninstall driver and cleanup

Uninstall and remove the print driver packages to cleanup
after the install. Cleanup and remove smb directory created
inside print$.

Signed-off-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Bjoern Jacke <bjacke@samba.org>
2 years agos4:torture: Add test_ValidatePrinterDriverInstalled
Justin Stephenson [Mon, 15 Oct 2018 21:01:21 +0000 (17:01 -0400)]
s4:torture: Add test_ValidatePrinterDriverInstalled

Perform checks against the print driver registry information
to ensure the driver was installed as expected.

Signed-off-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Bjoern Jacke <bjacke@samba.org>
2 years agos4:torture: Add test_InstallPrinterDriverFromPackage
Justin Stephenson [Fri, 14 Sep 2018 19:51:44 +0000 (15:51 -0400)]
s4:torture: Add test_InstallPrinterDriverFromPackage

Install a previous uploaded driver package.

Signed-off-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Bjoern Jacke <bjacke@samba.org>
2 years agos4:torture: Add test_UploadPrinterDriverPackage
Justin Stephenson [Tue, 11 Sep 2018 19:57:14 +0000 (15:57 -0400)]
s4:torture: Add test_UploadPrinterDriverPackage

Add test to Upload Print Driver, a prerequisite RPC call before
installing the print driver. The inf driver file to use in this test
will be provided using torture option:inf_file

Signed-off-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Bjoern Jacke <bjacke@samba.org>
2 years agos4:torture: Add test_CopyDriverFiles
Justin Stephenson [Mon, 27 Aug 2018 15:32:29 +0000 (11:32 -0400)]
s4:torture: Add test_CopyDriverFiles

Add test to copy driver files from a torture option provided local driver_path
to the print$ share of //server/.

Signed-off-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Bjoern Jacke <bjacke@samba.org>
2 years agos4:torture: Add test_init_driver_info function
Justin Stephenson [Mon, 15 Oct 2018 17:55:37 +0000 (13:55 -0400)]
s4:torture: Add test_init_driver_info function

Validate torture options, obtain and retrieve driver information, and
call driver parsing function to retrieve driver info needed for
performing the test.

Signed-off-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Bjoern Jacke <bjacke@samba.org>
2 years agos4:torture: Add driver parsing wrapper
Justin Stephenson [Mon, 15 Oct 2018 17:28:01 +0000 (13:28 -0400)]
s4:torture: Add driver parsing wrapper

Add wrapper function to parse inf driver file and get
validated driver information.

Signed-off-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Bjoern Jacke <bjacke@samba.org>
2 years agolib:printer_driver: Retrieve Class value
Justin Stephenson [Tue, 20 Nov 2018 16:24:34 +0000 (11:24 -0500)]
lib:printer_driver: Retrieve Class value

Retrieve the Class value from the inf file [Version] section.

Signed-off-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Bjoern Jacke <bjacke@samba.org>
2 years agolib:printer_driver: Don't overwrite printprocessor
Justin Stephenson [Fri, 16 Nov 2018 21:53:33 +0000 (16:53 -0500)]
lib:printer_driver: Don't overwrite printprocessor

If the printprocessor is parsed from the inf file in the codepath:

setup_driver_name
  find_driver_files
    process_driver_section_printprocessor

Don't overwrite the value later on in setup_driver_name with the default "winprint"

Signed-off-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Bjoern Jacke <bjacke@samba.org>
2 years agolib:printer_driver: Parse SourceDisksNames section
Justin Stephenson [Fri, 16 Nov 2018 21:11:02 +0000 (16:11 -0500)]
lib:printer_driver: Parse SourceDisksNames section

This allows a driver inf with a [SourceDisksNames] section
excluding the system architecture to be parsed.

https://docs.microsoft.com/en-us/windows-hardware/drivers/install/inf-sourcedisksnames-section?f=255&MSPPError=-2147217396

Signed-off-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Bjoern Jacke <bjacke@samba.org>
2 years agolib:printer_driver: Handle PrintProcessor string
Justin Stephenson [Fri, 16 Nov 2018 21:03:00 +0000 (16:03 -0500)]
lib:printer_driver: Handle PrintProcessor string

This fixes an issue parsing the section of a certain HP
driver inf file:

PrintProcessor=%PRINT_PROCESSOR%

where %PRINT_PROCESSOR% is a [Strings] substituted value,
gp_inifile_getstring_ext() performs the substitution correctly.

Signed-off-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Bjoern Jacke <bjacke@samba.org>
2 years agolib:printer_driver: Add printer_driver library to parse printer driver inf files
Guenther Deschner [Mon, 8 Oct 2018 15:14:37 +0000 (11:14 -0400)]
lib:printer_driver: Add printer_driver library to parse printer driver inf files

Pair-Programmed-With: Justin Stephenson <jstephen@redhat.com>
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Bjoern Jacke <bjacke@samba.org>
2 years agoutils:libgpo: re-add libgpo as library, it should not be part of gpext
Günther Deschner [Fri, 8 Jun 2018 14:13:22 +0000 (16:13 +0200)]
utils:libgpo: re-add libgpo as library, it should not be part of gpext

It was initially removed in 78fd02cf31dfe72d596030f342aebefba1e72263 but
is needed by the inf file parsing.

Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Bjoern Jacke <bjacke@samba.org>
2 years agoutil: Add file tree walk interface
Andreas Schneider [Mon, 10 Sep 2018 13:20:03 +0000 (15:20 +0200)]
util: Add file tree walk interface

Add tftw() utility to emulate nftw() behavior with a userdata pointer.
This is repurposed from the csync project custom file tree walker.

Signed-off-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Bjoern Jacke <bjacke@samba.org>
2 years agos4:torture: Use test client user and machine name defaults
Justin Stephenson [Fri, 21 Sep 2018 13:45:33 +0000 (09:45 -0400)]
s4:torture: Use test client user and machine name defaults

Use "testclient_machine" and "testclient_user" in open printer calls.

Signed-off-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Bjoern Jacke <bjacke@samba.org>
2 years agos4:torture: Add iremotewinspool driver torture template
Justin Stephenson [Fri, 24 Aug 2018 18:28:05 +0000 (14:28 -0400)]
s4:torture: Add iremotewinspool driver torture template

Add the template with setup and teardown functions
for the iremotewinspool_driver torture suite, and
add this to the list of torture tests

Signed-off-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Bjoern Jacke <bjacke@samba.org>
2 years agolibrpc:idl: Fix pszDestInfPath winspool parameter type
Justin Stephenson [Mon, 17 Sep 2018 15:19:02 +0000 (11:19 -0400)]
librpc:idl: Fix pszDestInfPath winspool parameter type

The in/out type of pszDestInfPath needs to be a string type for
RPC call UploadPrinterDriverPackage.

Per the Spec:

[in, out, unique, size_is(*pcchDestInfPath)] wchar_t* pszDestInfPath,

 pszDestInfPath: A pointer to a buffer that receives a string that
 specifies the full path of the directory to which the driver
 installation control file was copied.

Signed-off-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Bjoern Jacke <bjacke@samba.org>
2 years agos4:torture: Seperate out function calls inside params
Justin Stephenson [Fri, 24 Aug 2018 13:36:55 +0000 (09:36 -0400)]
s4:torture: Seperate out function calls inside params

Minor change to allow for easier debugging

Signed-off-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Bjoern Jacke <bjacke@samba.org>
2 years agos4:torture: Share test iremotewinspool functions
Justin Stephenson [Thu, 23 Aug 2018 17:16:40 +0000 (13:16 -0400)]
s4:torture: Share test iremotewinspool functions

Create iremotewinspool_common.c and iremotewinspool_common.h to make
test functions available for additional tests

Signed-off-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Bjoern Jacke <bjacke@samba.org>
2 years agos3:nmbd: small improvements in --help strings
Douglas Bagnall [Fri, 18 Jan 2019 00:15:36 +0000 (13:15 +1300)]
s3:nmbd: small improvements in --help strings

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Mon Jan 28 14:28:29 CET 2019 on sn-devel-144

2 years agolibgpo: remove 404 link in comment
Douglas Bagnall [Thu, 17 Jan 2019 23:09:15 +0000 (12:09 +1300)]
libgpo: remove 404 link in comment

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andreas Schneider <asn@samba.org>
2 years agolibgpo: remove duplicate entry in value table
Douglas Bagnall [Thu, 17 Jan 2019 23:07:55 +0000 (12:07 +1300)]
libgpo: remove duplicate entry in value table

previously added a few lines up.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andreas Schneider <asn@samba.org>
2 years agopyrpc: typo in transfer syntax docstring
Douglas Bagnall [Thu, 17 Jan 2019 21:57:51 +0000 (10:57 +1300)]
pyrpc: typo in transfer syntax docstring

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andreas Schneider <asn@samba.org>
2 years agolibcli:smb: Use C99 initializer for derivation in smbXcli_base
Andreas Schneider [Tue, 15 Jan 2019 14:42:09 +0000 (15:42 +0100)]
libcli:smb: Use C99 initializer for derivation in smbXcli_base

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2 years agos4:cifsdd: Use C99 initializers for cifsdd argdef
Andreas Schneider [Tue, 8 Jan 2019 10:49:28 +0000 (11:49 +0100)]
s4:cifsdd: Use C99 initializers for cifsdd argdef

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2 years agos4:torture: Fix C99 initializers for vfs fruit tests
Andreas Schneider [Tue, 8 Jan 2019 10:26:16 +0000 (11:26 +0100)]
s4:torture: Fix C99 initializers for vfs fruit tests

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2 years agos4:torture: Use C99 initializers in gentest
Andreas Schneider [Tue, 8 Jan 2019 10:37:32 +0000 (11:37 +0100)]
s4:torture: Use C99 initializers in gentest

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2 years agos4:torture: Add missing C99 initializer for torture_rpc_samlogon
Andreas Schneider [Mon, 7 Jan 2019 16:19:27 +0000 (17:19 +0100)]
s4:torture: Add missing C99 initializer for torture_rpc_samlogon

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2 years agos4:torture: Use C99 initializer in test_SecurityDescriptorsSecInfo
Andreas Schneider [Mon, 7 Jan 2019 16:11:42 +0000 (17:11 +0100)]
s4:torture: Use C99 initializer in test_SecurityDescriptorsSecInfo

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2 years agos4:torture: Use C99 initializer for last element in get_and_set_info
Andreas Schneider [Thu, 13 Dec 2018 12:53:45 +0000 (13:53 +0100)]
s4:torture: Use C99 initializer for last element in get_and_set_info

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2 years agos4:torture: Complete C99 initializers for levels in raw qfileinfo test
Andreas Schneider [Thu, 13 Dec 2018 11:30:15 +0000 (12:30 +0100)]
s4:torture: Complete C99 initializers for levels in raw qfileinfo test

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2 years agos4:torture: Use C99 initializers for file_levels in smb2 getinfo test
Andreas Schneider [Thu, 13 Dec 2018 12:42:23 +0000 (13:42 +0100)]
s4:torture: Use C99 initializers for file_levels in smb2 getinfo test

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2 years agos4:torture: Use C99 initializers for level in smb2 dir test
Andreas Schneider [Thu, 13 Dec 2018 12:40:19 +0000 (13:40 +0100)]
s4:torture: Use C99 initializers for level in smb2 dir test

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2 years agos4:torture: Use C99 initializers for hold_sharemode_table in smb2 sharemode test
Andreas Schneider [Thu, 13 Dec 2018 12:13:11 +0000 (13:13 +0100)]
s4:torture: Use C99 initializers for hold_sharemode_table in smb2 sharemode test

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2 years agos4:torture: Use C99 initializers for dirs in smb2 oplock test
Andreas Schneider [Thu, 13 Dec 2018 12:10:49 +0000 (13:10 +0100)]
s4:torture: Use C99 initializers for dirs in smb2 oplock test

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2 years agos4:torture: Use C99 initializers for levels in raw notify test
Andreas Schneider [Thu, 13 Dec 2018 12:08:42 +0000 (13:08 +0100)]
s4:torture: Use C99 initializers for levels in raw notify test

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2 years agos4:torture: Use C99 initializers for levels in raw search test
Andreas Schneider [Thu, 13 Dec 2018 12:03:29 +0000 (13:03 +0100)]
s4:torture: Use C99 initializers for levels in raw search test

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2 years agos4:torture: Use C99 initializers for dirs in smb2 notify test
Andreas Schneider [Thu, 13 Dec 2018 11:50:54 +0000 (12:50 +0100)]
s4:torture: Use C99 initializers for dirs in smb2 notify test

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2 years agos4:torture: Use C99 initializers for levels in qfsinfo test
Andreas Schneider [Thu, 13 Dec 2018 11:43:14 +0000 (12:43 +0100)]
s4:torture: Use C99 initializers for levels in qfsinfo test

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2 years agos4:torture: Use C99 initializers for dirs in oplock test
Andreas Schneider [Thu, 13 Dec 2018 11:53:39 +0000 (12:53 +0100)]
s4:torture: Use C99 initializers for dirs in oplock test

Yes, this was already valid C99 but the compiler on Ubuntu 14.04 simply
sucks. This doesn't happen with this gcc version on other Linux systems.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2 years agos4:samdb: Use C99 initializer for last element of ldb_map_objectclass
Andreas Schneider [Thu, 13 Dec 2018 10:43:52 +0000 (11:43 +0100)]
s4:samdb: Use C99 initializer for last element of ldb_map_objectclass

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2 years agos4:dsdb: Use C99 initializer in util
Andreas Schneider [Mon, 14 Jan 2019 12:13:09 +0000 (13:13 +0100)]
s4:dsdb: Use C99 initializer in util

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2 years agos3:utils: Use C99 initializer in functable in net
Andreas Schneider [Mon, 14 Jan 2019 09:53:24 +0000 (10:53 +0100)]
s3:utils: Use C99 initializer in functable in net

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2 years agos3:utils: Use C99 initializer in functable in net_lookup
Andreas Schneider [Mon, 14 Jan 2019 09:50:33 +0000 (10:50 +0100)]
s3:utils: Use C99 initializer in functable in net_lookup

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2 years agos3:utils: Use C99 initializer for msg_types in smbcontrol
Andreas Schneider [Fri, 11 Jan 2019 13:22:15 +0000 (14:22 +0100)]
s3:utils: Use C99 initializer for msg_types in smbcontrol

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2 years agos3:torture: Use C99 initializer for torture_ops
Andreas Schneider [Tue, 8 Jan 2019 14:39:54 +0000 (15:39 +0100)]
s3:torture: Use C99 initializer for torture_ops

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2 years agos3:smbd: Use C99 initializer for RAP api_commands
Andreas Schneider [Wed, 12 Dec 2018 20:43:34 +0000 (21:43 +0100)]
s3:smbd: Use C99 initializer for RAP api_commands

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2 years agos3:lib: Use C99 initializer for audit_category_tab
Andreas Schneider [Wed, 12 Dec 2018 20:32:47 +0000 (21:32 +0100)]
s3:lib: Use C99 initializer for audit_category_tab

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2 years agos3:registry: Use C99 initializer for BOM
Andreas Schneider [Wed, 12 Dec 2018 20:31:42 +0000 (21:31 +0100)]
s3:registry: Use C99 initializer for BOM

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2 years agosddl: Use C99 initializer for sid_codes
Andreas Schneider [Wed, 12 Dec 2018 20:18:32 +0000 (21:18 +0100)]
sddl: Use C99 initializer for sid_codes

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2 years agolibrpc:rpc: Use C99 initializer for last element in dcerpc_faults
Andreas Schneider [Wed, 12 Dec 2018 20:33:40 +0000 (21:33 +0100)]
librpc:rpc: Use C99 initializer for last element in dcerpc_faults

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2 years agolibgpo: Use C99 initializer for gp_extension_reg_table
Andreas Schneider [Thu, 13 Dec 2018 10:07:24 +0000 (11:07 +0100)]
libgpo: Use C99 initializer for gp_extension_reg_table

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2 years agolib:util: Use C99 initializer in tfork test
Andreas Schneider [Mon, 7 Jan 2019 16:33:57 +0000 (17:33 +0100)]
lib:util: Use C99 initializer in tfork test

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2 years agolib:util: Use C99 initializer for weird_table in charset
Andreas Schneider [Wed, 12 Dec 2018 20:28:14 +0000 (21:28 +0100)]
lib:util: Use C99 initializer for weird_table in charset

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2 years agolib:util: Use C99 initializer for builtin_functions in iconv
Andreas Schneider [Wed, 12 Dec 2018 20:25:37 +0000 (21:25 +0100)]
lib:util: Use C99 initializer for builtin_functions in iconv

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2 years agolib:tevent: Use correct C99 initializer for tevent_req
Andreas Schneider [Mon, 14 Jan 2019 10:59:59 +0000 (11:59 +0100)]
lib:tevent: Use correct C99 initializer for tevent_req

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2 years agolib:tdb: Use C99 initializer for tdb_logging_context
Andreas Schneider [Thu, 13 Dec 2018 10:24:12 +0000 (11:24 +0100)]
lib:tdb: Use C99 initializer for tdb_logging_context

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2 years agolib:tdb: Use C99 initializer for tdb_header
Andreas Schneider [Wed, 12 Dec 2018 20:26:35 +0000 (21:26 +0100)]
lib:tdb: Use C99 initializer for tdb_header

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2 years agolib:ldb: Use correct C99 initializer for 'struct tm'
Andreas Schneider [Mon, 14 Jan 2019 11:10:34 +0000 (12:10 +0100)]
lib:ldb: Use correct C99 initializer for 'struct tm'

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2 years agolib:ldb: Use C99 initializer for tdb_logging_context
Andreas Schneider [Thu, 13 Dec 2018 10:35:25 +0000 (11:35 +0100)]
lib:ldb: Use C99 initializer for tdb_logging_context

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2 years agoctdb:tools: Use correct C99 initializer for ltdb_header
Andreas Schneider [Mon, 14 Jan 2019 11:07:40 +0000 (12:07 +0100)]
ctdb:tools: Use correct C99 initializer for ltdb_header

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2 years agoctdb:common: Use C99 initializer for 'struct ifreq'
Andreas Schneider [Thu, 13 Dec 2018 09:57:55 +0000 (10:57 +0100)]
ctdb:common: Use C99 initializer for 'struct ifreq'

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2 years agoctdb: Use C99 initializer for last element of tunables
Andreas Schneider [Thu, 13 Dec 2018 09:34:11 +0000 (10:34 +0100)]
ctdb: Use C99 initializer for last element of tunables

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2 years agoauth:gensec: Use C99 initializer in schannel
Andreas Schneider [Mon, 14 Jan 2019 12:44:40 +0000 (13:44 +0100)]
auth:gensec: Use C99 initializer in schannel

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2 years agoauth:creds: Use C99 initializer for PyMethodDef
Andreas Schneider [Thu, 13 Dec 2018 10:20:41 +0000 (11:20 +0100)]
auth:creds: Use C99 initializer for PyMethodDef

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2 years agos4:pyparam: Use C99 initializer for PyGetSetDef
Andreas Schneider [Thu, 13 Dec 2018 10:10:40 +0000 (11:10 +0100)]
s4:pyparam: Use C99 initializer for PyGetSetDef

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2 years agos4:lib: Use C99 initializer for PyGetSetDef in pymessaging
Andreas Schneider [Thu, 13 Dec 2018 11:13:04 +0000 (12:13 +0100)]
s4:lib: Use C99 initializer for PyGetSetDef in pymessaging

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2 years agos4:librpc: Use C99 initializer for PyGetSetDef in pyrpc
Andreas Schneider [Thu, 13 Dec 2018 10:38:43 +0000 (11:38 +0100)]
s4:librpc: Use C99 initializer for PyGetSetDef in pyrpc

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2 years agos3:passdb: Use C99 initializer for PyGetSetDef in py_passdb
Andreas Schneider [Tue, 8 Jan 2019 16:20:43 +0000 (17:20 +0100)]
s3:passdb: Use C99 initializer for PyGetSetDef in py_passdb

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2 years agolib:ldb: Use C99 initializer for PyGetSetDef in pyldb
Andreas Schneider [Thu, 13 Dec 2018 10:34:37 +0000 (11:34 +0100)]
lib:ldb: Use C99 initializer for PyGetSetDef in pyldb

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2 years agolib:tdb: Use C99 initializer for PyGetSetDef in pytdb
Andreas Schneider [Thu, 13 Dec 2018 10:29:09 +0000 (11:29 +0100)]
lib:tdb: Use C99 initializer for PyGetSetDef in pytdb

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2 years agos3:rpcclient: Use C99 initializer for cmd_set in cmd_shutdown
Andreas Schneider [Mon, 14 Jan 2019 08:51:05 +0000 (09:51 +0100)]
s3:rpcclient: Use C99 initializer for cmd_set in cmd_shutdown

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2 years agos3:rpcclient: Use C99 initializer for cmd_set in cmd_epmapper
Andreas Schneider [Mon, 14 Jan 2019 08:48:06 +0000 (09:48 +0100)]
s3:rpcclient: Use C99 initializer for cmd_set in cmd_epmapper

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2 years agos3:rpcclient: Use C99 initializer for cmd_set in cmd_test
Andreas Schneider [Mon, 14 Jan 2019 08:42:17 +0000 (09:42 +0100)]
s3:rpcclient: Use C99 initializer for cmd_set in cmd_test

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2 years agos3:rpcclient: Use C99 initializer for cmd_set in cmd_eventlog
Andreas Schneider [Fri, 11 Jan 2019 13:57:21 +0000 (14:57 +0100)]
s3:rpcclient: Use C99 initializer for cmd_set in cmd_eventlog

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2 years agos3:rpcclient: Use C99 initializer for cmd_set in cmd_witness
Andreas Schneider [Fri, 11 Jan 2019 13:47:02 +0000 (14:47 +0100)]
s3:rpcclient: Use C99 initializer for cmd_set in cmd_witness

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2 years agos3:rpcclient: Use C99 initializer for cmd_set in rpcclient
Andreas Schneider [Fri, 11 Jan 2019 13:16:11 +0000 (14:16 +0100)]
s3:rpcclient: Use C99 initializer for cmd_set in rpcclient

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2 years agos3:rpcclient: Use C99 initializer for cmd_set in cmd_lsarpc
Andreas Schneider [Fri, 11 Jan 2019 13:05:57 +0000 (14:05 +0100)]
s3:rpcclient: Use C99 initializer for cmd_set in cmd_lsarpc

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2 years agos3:rpcclient: Use C99 initializer for cmd_set in cmd_samr
Andreas Schneider [Fri, 11 Jan 2019 12:43:24 +0000 (13:43 +0100)]
s3:rpcclient: Use C99 initializer for cmd_set in cmd_samr

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2 years agos3:rpcclient: Use C99 initializer for cmd_set in cmd_clusapi
Andreas Schneider [Wed, 9 Jan 2019 15:31:51 +0000 (16:31 +0100)]
s3:rpcclient: Use C99 initializer for cmd_set in cmd_clusapi

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2 years agos3:rpcclient: Use C99 initializer for cmd_set in cmd_ntsvcvs
Andreas Schneider [Wed, 9 Jan 2019 15:29:06 +0000 (16:29 +0100)]
s3:rpcclient: Use C99 initializer for cmd_set in cmd_ntsvcvs

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2 years agos3:rpcclient: Use C99 initializer for cmd_set in cmd_iremotewinspool
Andreas Schneider [Wed, 9 Jan 2019 15:21:34 +0000 (16:21 +0100)]
s3:rpcclient: Use C99 initializer for cmd_set in cmd_iremotewinspool

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2 years agos3:rpcclient: Use C99 initializer for cmd_set in cmd_winreg
Andreas Schneider [Wed, 9 Jan 2019 14:16:35 +0000 (15:16 +0100)]
s3:rpcclient: Use C99 initializer for cmd_set in cmd_winreg

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2 years agos3:rpcclient: Use C99 initializer for cmd_set in cmd_fss
Andreas Schneider [Wed, 9 Jan 2019 14:15:18 +0000 (15:15 +0100)]
s3:rpcclient: Use C99 initializer for cmd_set in cmd_fss

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2 years agos3:rpcclient: Use C99 initializer for cmd_set in cmd_wkssvc
Andreas Schneider [Wed, 9 Jan 2019 14:14:05 +0000 (15:14 +0100)]
s3:rpcclient: Use C99 initializer for cmd_set in cmd_wkssvc

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2 years agos3:rpcclient: Use C99 initializer for cmd_set in cmd_dssetup
Andreas Schneider [Wed, 9 Jan 2019 14:12:23 +0000 (15:12 +0100)]
s3:rpcclient: Use C99 initializer for cmd_set in cmd_dssetup

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2 years agos3:rpcclient: Use C99 initializer for cmd_set in cmd_drsuapi
Andreas Schneider [Wed, 9 Jan 2019 14:11:01 +0000 (15:11 +0100)]
s3:rpcclient: Use C99 initializer for cmd_set in cmd_drsuapi

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2 years agos3:rpcclient: Use C99 initializer for cmd_set in cmd_echo
Andreas Schneider [Wed, 9 Jan 2019 12:27:03 +0000 (13:27 +0100)]
s3:rpcclient: Use C99 initializer for cmd_set in cmd_echo

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2 years agos3:rpcclient: Use C99 initializer for cmd_set in cmd_srvsvc
Andreas Schneider [Tue, 8 Jan 2019 17:06:43 +0000 (18:06 +0100)]
s3:rpcclient: Use C99 initializer for cmd_set in cmd_srvsvc

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2 years agos3:rpcclient: Use C99 initializer for cmd_set in cmd_netlogon
Andreas Schneider [Tue, 8 Jan 2019 17:01:42 +0000 (18:01 +0100)]
s3:rpcclient: Use C99 initializer for cmd_set in cmd_netlogon

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2 years agos3:rpcclient: Use C99 initializer for cmd_set in cmd_dfs
Andreas Schneider [Tue, 8 Jan 2019 16:57:26 +0000 (17:57 +0100)]
s3:rpcclient: Use C99 initializer for cmd_set in cmd_dfs

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2 years agos3:rpcclient: Use C99 initializer for cmd_set in cmd_spoolss
Andreas Schneider [Tue, 8 Jan 2019 16:50:20 +0000 (17:50 +0100)]
s3:rpcclient: Use C99 initializer for cmd_set in cmd_spoolss

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2 years agos3:torture: Use C99 initializer for cmd_set in vfstest
Andreas Schneider [Tue, 8 Jan 2019 16:11:57 +0000 (17:11 +0100)]
s3:torture: Use C99 initializer for cmd_set in vfstest

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>