Volker Lendecke [Tue, 23 Jan 2007 20:38:14 +0000 (20:38 +0000)]
r20982: Fix a segfault -- I wonder why my make test did not show this earlier...
(This used to be commit
4984b0627c84cc192868238c0936ca1a38628cd8)
Volker Lendecke [Tue, 23 Jan 2007 16:50:27 +0000 (16:50 +0000)]
r20979: Fix description, thanks to Michael Adam <ma@sernet.de>
(This used to be commit
4610465d7f8b1d145b4923f03bd1559c79ad8e70)
Günther Deschner [Tue, 23 Jan 2007 10:51:35 +0000 (10:51 +0000)]
r20970: Allow to define workstation for samlogon in rpcclient (for testing).
Guenther
(This used to be commit
5d4747fdf2e5874cb5d2238ee62e4fcac1676134)
James Peach [Tue, 23 Jan 2007 04:12:51 +0000 (04:12 +0000)]
r20966: Only attempt to reload the config file atfer the fork point if we
are in daemon mode. If we are in inetd mode, there's really no point
in rechecking it so soon.
(This used to be commit
029d4bb5e3ea02a8a396adc3ca564a714bcdfdb8)
James Peach [Tue, 23 Jan 2007 03:03:24 +0000 (03:03 +0000)]
r20965: Fix spelling.
(This used to be commit
0eb19b57286f176dd4b7e86504d004e1450f6a10)
Gerald Carter [Mon, 22 Jan 2007 16:54:02 +0000 (16:54 +0000)]
r20951: Remove the DOM_SID field in the struct idmap_domain and bounce
domain SID lookups through the struct winbindd_domain *domain_list
by searching by name.
Refactor the order lookup when searching for the correct idmap_domain
to a single function and remove the requirement that the default
domain be listed first in the config file.
I would still like to make the idmap_domain array a linked list and
remove the existing code which makes use of indexes into the list.
Basic testing with tdb pans out ok.
(This used to be commit
e6c300829ff08dd354f6e9460d396261681e4809)
Volker Lendecke [Sun, 21 Jan 2007 16:25:25 +0000 (16:25 +0000)]
r20933: Fix the build without inotify
(This used to be commit
4587d8097255c8b8fb8990bc8a13f8145986d29d)
Volker Lendecke [Sun, 21 Jan 2007 16:05:49 +0000 (16:05 +0000)]
r20932: This is the basic infrastructure for inotify support. This is far from being
complete, in particular the various mask bits are not correctly supported
yet. Checkin in now, I want to see how the build farm likes it.
Volker
(This used to be commit
c9a5d011a91359b242f6c26f46e96ecea6a44a3b)
Volker Lendecke [Sun, 21 Jan 2007 11:49:00 +0000 (11:49 +0000)]
r20931: This changes the notify infrastructure from a polling-based to an event-driven
based approach. The only remaining hook into the backend is now
void *(*notify_add)(TALLOC_CTX *mem_ctx,
struct event_context *event_ctx,
files_struct *fsp, uint32 *filter);
(Should we put this through the VFS, so that others can more easily plug in?)
The trick here is that the backend can pick filter bits that the main smbd
should not handle anymore. Thanks to tridge for this idea.
The backend can notify the main smbd process via
void notify_fsp(files_struct *fsp, uint32 action, char *name);
The core patch is not big, what makes this more than 1800 lines are the
individual backends that are considerably changed but can be reviewed
one by one.
Based on this I'll continue with inotify now.
Volker
(This used to be commit
9cd6a8a82792b7b6967141565d043b6337836a5d)
Jeremy Allison [Fri, 19 Jan 2007 23:08:20 +0000 (23:08 +0000)]
r20917: Fix missing error returns pointed out by "Li, Ying (ESG)" <ying.li2@hp.com>
Jeremy.
(This used to be commit
78387b3cd2e4eff8f09b6c498ca37b016ed9ecbc)
Jeremy Allison [Fri, 19 Jan 2007 21:46:12 +0000 (21:46 +0000)]
r20916: Add in the delete on close final fix - but only enabled
with -DDEVELOPER.
Jeremy.
(This used to be commit
7f817067a70930ee3502ea3373173e0c23733253)
Jeremy Allison [Fri, 19 Jan 2007 21:29:46 +0000 (21:29 +0000)]
r20915: Fixed the bad merge from 3.0.24.
Jeremy.
(This used to be commit
018d7805b5ecb17e21e1a55b6cc65efaab4b3f63)
Jeremy Allison [Fri, 19 Jan 2007 20:05:02 +0000 (20:05 +0000)]
r20914: Sync up incorrect differences between 3.0.24 and 3.0
Jeremy.
(This used to be commit
a2222a565c658fe5154d9321edab69a95ddeed15)
Jeremy Allison [Fri, 19 Jan 2007 20:00:44 +0000 (20:00 +0000)]
r20913: Fix the build.
Jeremy.
(This used to be commit
dce98dae2d18126d8380f92595f315b96d48a7df)
Jeremy Allison [Fri, 19 Jan 2007 19:41:34 +0000 (19:41 +0000)]
r20912: Ensure the list always remains sorted even when
moving events around.
Jeremy.
(This used to be commit
6fee874ab420b4c406e38b5e189a6d6ea8594fc9)
Gerald Carter [Fri, 19 Jan 2007 18:13:53 +0000 (18:13 +0000)]
r20911: Fix copyright message in winbindd to use the macro from smb.h
(This used to be commit
e635bad00ecf083c34da339e3616c945a140e478)
Gerald Carter [Fri, 19 Jan 2007 14:54:05 +0000 (14:54 +0000)]
r20905: Windows 2000 returns NT_STATUS_ACCOUNT_RESTRICTION if the pw
chnage fails due to policy settings where as 2003 (the chgpasswd3()
request) fails with NT_STATUS_PASSWORD_RESTRICTION. Thunk down
to the same return code so we correctly retreive the password policy
in both cases.
(This used to be commit
262bb80e9cf7fb6dbf93144ae0b939c84ec0ea04)
Gerald Carter [Fri, 19 Jan 2007 14:33:36 +0000 (14:33 +0000)]
r20904: This is a placeholder fix. Apparently Windows 2000
is sharing the IDL for the SAMR pipe with Windows 2003
but returning NT_STATUS_NOT_SUPPORTED rather than a DCE/RCE
fault. We need to catch this in the general sense
by looking at the returned PDU size. But this immediate
change fixes password changes via pam_winbind against Windows 2000
DCs.
(This used to be commit
a3602cc6d4926852a21b13d4b731419f70477f5c)
Gerald Carter [Fri, 19 Jan 2007 14:29:42 +0000 (14:29 +0000)]
r20903: Replace the hardcoded "smb.conf" string with the dyn_CONFIGFILE
(This used to be commit
ff8f27108d247aa9e46176f2b29fc8d2da103906)
Gerald Carter [Thu, 18 Jan 2007 22:08:38 +0000 (22:08 +0000)]
r20884: patch from Michael Adam <ma@sernet.de> to add new sambaTrustedDomainPassword object class
(This used to be commit
a209c3084913c69d1978cb31818f2db99e216c9a)
Jeremy Allison [Thu, 18 Jan 2007 21:51:52 +0000 (21:51 +0000)]
r20883: W00t! I now understand how "delete on close" really
works - even with the strange "initial delete on close"
semantics. The "initial delete on close" flag isn't
committed to the share mode db until the handle is
closed, and is discarded if any real "delete on close"
was set. This allows me to remove the "initial_delete_on_close"
flag from the share db, and move it into a BOOL in files_struct.
Warning ! You must do a make clean after this. Cope with
the wrinkle in directory delete on close which is done
differently from files. We now pass all Samba4 smbtortute
BASE-DELETE tests except for the one checking that files
can't be created in a directory which has the delete on
close set (possibly expensive to fix).
Jeremy.
(This used to be commit
f2df77a1497958c1ea791f1d2f4446b5fc3389b3)
Jeremy Allison [Thu, 18 Jan 2007 19:18:43 +0000 (19:18 +0000)]
r20880: Fix memory leak in new sitename code. You got *really*
close Guenther, then you forgot to use "key" :-) :-).
Jeremy.
(This used to be commit
56842b59d00d531b0c9c22639603dc721eab50b4)
Volker Lendecke [Thu, 18 Jan 2007 15:51:51 +0000 (15:51 +0000)]
r20878: Fix build with --enable-profiling
(This used to be commit
eb14d0ea83273c60aee900557aa5dceb77bb8127)
Volker Lendecke [Thu, 18 Jan 2007 12:49:59 +0000 (12:49 +0000)]
r20877: Random notify fixes
(This used to be commit
2f1bfc53733ac3debc6a8b51642ab191869cd792)
Volker Lendecke [Thu, 18 Jan 2007 11:31:38 +0000 (11:31 +0000)]
r20876: Fix bug 4346 -- Thanks to YAMASAKI Hiroyuki
(This used to be commit
a7a66eb4eb2e518007b791457694c39dfff90705)
Jelmer Vernooij [Thu, 18 Jan 2007 10:18:59 +0000 (10:18 +0000)]
r20875: Pass DCE/RPC server call arguments as a struct rather than as separate arguments.
This makes it a bit more similar to the Samba4 code.
(This used to be commit
0596badb410a58e7a715e2b17bc0bef0489a2448)
Günther Deschner [Thu, 18 Jan 2007 09:58:57 +0000 (09:58 +0000)]
r20874: We need to distinguish client sitenames per realm. We were overwriting
the stored client sitename with the sitename from each sucessfull CLDAP
connection.
Guenther
(This used to be commit
6a13e878b5d299cb3b3d7cb33ee0d51089d9228d)
Jeremy Allison [Thu, 18 Jan 2007 06:19:24 +0000 (06:19 +0000)]
r20873: Some correctness fixes w.r.t. Samba4 torture BASE-DELETE.
Allow us to correctly refuse to set delete on close on a
non-empty directory. There are still some delete-on-close
wrinkles to be fixed, but I understand how to do that better
now. I'll fix this tomorrow.
Jeremy.
(This used to be commit
029635885825a5562e7974a6f5675cce3bf1b5dc)
Günther Deschner [Wed, 17 Jan 2007 19:20:11 +0000 (19:20 +0000)]
r20862: When in disconnected mode there is no need to try a fallback to a site
less DNS query. This speeds up offline detection slightly.
Guenther
(This used to be commit
eda76ecf07a4d2f9bb5544e2c031cfad14d93e85)
Günther Deschner [Wed, 17 Jan 2007 19:14:34 +0000 (19:14 +0000)]
r20861: We only use sitespecific DNS lookups when looking for DCs or KDCs, not
for a PDC.
Guenther
(This used to be commit
0944c7861004bee2a9d0ac787f022f5bf1d181ac)
Günther Deschner [Wed, 17 Jan 2007 19:11:45 +0000 (19:11 +0000)]
r20860: Adding some small tweaks. When we have no sitename, there is no need to
ask for the list of DCs twice.
Guenther
(This used to be commit
a9baf27e1348dd6dadd7a2fafdf9c269087b80ac)
Volker Lendecke [Wed, 17 Jan 2007 18:26:37 +0000 (18:26 +0000)]
r20858: change_notify_reply_packet is static
(This used to be commit
a1d0644d156c360d52fb837d3eecddb202135ebe)
Jeremy Allison [Wed, 17 Jan 2007 18:25:35 +0000 (18:25 +0000)]
r20857: Silence gives assent :-). Checking in the fix for
site support in a network where many DC's are down.
I heard via Volker there is still a bug w.r.t the
wrong site being chosen with trusted domains but
we'll have to layer that fix on top of this.
Gd - complain if this doesn't work for you.
Jeremy.
(This used to be commit
97e248f89ac6548274f03f2ae7583a255da5ddb3)
Volker Lendecke [Wed, 17 Jan 2007 18:23:37 +0000 (18:23 +0000)]
r20856: Make "struct notify_mid_map" private to notify.c
(This used to be commit
beecef0c70521d28dd88552d661281d9c585eb22)
Volker Lendecke [Wed, 17 Jan 2007 16:23:45 +0000 (16:23 +0000)]
r20854: Ok, now I think we're at a point where looking at notify starts to make sense
again :-)
Volker
(This used to be commit
5533cdeec1b0cdee39b1d89e2320587dc9281ee6)
Volker Lendecke [Wed, 17 Jan 2007 15:47:36 +0000 (15:47 +0000)]
r20851: To read account policies from LDAP we need root.
Volker
(This used to be commit
b48ea4d7775dfc3216771fd328640c2c100a014d)
Günther Deschner [Wed, 17 Jan 2007 14:09:14 +0000 (14:09 +0000)]
r20848: Minor typo.
Guenther
(This used to be commit
fb730e1e7bb83d7dcf8a78302268e384fb9676ee)
Volker Lendecke [Wed, 17 Jan 2007 12:59:14 +0000 (12:59 +0000)]
r20846: Before this gets out of control...
This add a struct event_context and infrastructure for fd events to smbd. This
is step zero to import lib/events.
Jeremy, I rely on you to watch the change in receive_message_or_smb()
closely. For the normal code path this should be the only relevant change. The
rest is either not yet used or is cosmetic.
Volker
(This used to be commit
cd07f93a8aecb24c056e33b1ad3447a41959810f)
Jeremy Allison [Wed, 17 Jan 2007 02:44:27 +0000 (02:44 +0000)]
r20845: Somehow I missed this one - should have been part of the
previous commit :-(.
Jeremy.
(This used to be commit
8fe3829e8a884ce2ddb91121d46b7a3a385874c1)
Jeremy Allison [Wed, 17 Jan 2007 02:09:37 +0000 (02:09 +0000)]
r20844: Somewhat radical change - this may break the build (I will
watch carefully - so I'm doing it in one transaction so I can
roll back).
Change check_name(), reduce_name() and dptr_create() to
return NTSTATUS. This helps a lot in error path processing
and especially in reduce_name() allows us to ditch the flaky
and error-prone saving of errno and return errors directly.
Jeremy.
(This used to be commit
6133a694aa429d638320e39ffe1c49d172583ccf)
Jeremy Allison [Tue, 16 Jan 2007 21:04:30 +0000 (21:04 +0000)]
r20843: Get rid of last BOOL ok.
Jeremy.
(This used to be commit
a36d446fb612f87654c645f6507d413b95efaf21)
Jeremy Allison [Tue, 16 Jan 2007 20:53:50 +0000 (20:53 +0000)]
r20842: Only one more BOOL ok to go...
Jeremy.
(This used to be commit
de0bf477dab1d57b5f7bc6bf70d8e76f9bfac63f)
Jeremy Allison [Tue, 16 Jan 2007 20:49:51 +0000 (20:49 +0000)]
r20841: Remove more BOOL ok.
Jeremy.
(This used to be commit
c6b651966039b1c21facd4c4789bf873b5b49426)
Jeremy Allison [Tue, 16 Jan 2007 20:32:39 +0000 (20:32 +0000)]
r20840: Keep removing the old BOOL ok logic.
Jeremy.
(This used to be commit
224ff059915b2c92ec86d2c3c4b10c3bc552ffa2)
Jelmer Vernooij [Tue, 16 Jan 2007 18:26:02 +0000 (18:26 +0000)]
r20839: Fix other C++ warnings
(This used to be commit
d948d828d591b3467945f5a85a561ebb07299d9f)
Jeremy Allison [Tue, 16 Jan 2007 18:05:37 +0000 (18:05 +0000)]
r20838: Small fix from Jiri.Sasek@Sun.COM to fix null
pointer deref.
Jeremy
(This used to be commit
34d891c81ad4226bb1f0e26902c4e4afaba6d62f)
Jelmer Vernooij [Tue, 16 Jan 2007 17:48:59 +0000 (17:48 +0000)]
r20837: Use real type name, to fix compilation with -WC++-compat
(This used to be commit
840485686d2b3765bd01fbe442f712803d1f4c0f)
Volker Lendecke [Tue, 16 Jan 2007 15:50:25 +0000 (15:50 +0000)]
r20833: Reformatting
(This used to be commit
2c2d5308a23df0b6b078bc647ad550c43b51ee1e)
Jelmer Vernooij [Tue, 16 Jan 2007 15:42:03 +0000 (15:42 +0000)]
r20832: Remove extra pointers previously added to unique [out] pointers. Instead,
add [ref] pointers where necessary (top-level [ref] pointers,
by spec, don't appear on the wire).
This brings us closer to the DCE/RPC standard again.
(This used to be commit
580f2a7197b1bc9db14a643fdd112b40ef37aaef)
Günther Deschner [Tue, 16 Jan 2007 11:15:10 +0000 (11:15 +0000)]
r20828: Fix the build with libnscd.
Guenther
(This used to be commit
8284396faffbe0f58741ecacd62ba86e3ca645c6)
Volker Lendecke [Tue, 16 Jan 2007 10:59:17 +0000 (10:59 +0000)]
r20827: Increment the interface version.
Wilco: Existing modules should continue to work, they just must be recompiled.
Volker
(This used to be commit
f5babdce9b79ba6abed5d6f57daecc0ed1e14e15)
Volker Lendecke [Tue, 16 Jan 2007 08:17:26 +0000 (08:17 +0000)]
r20824: Send access to the trusted domain passwords through the pdb backend, so that
in the next step we can store them in LDAP to be replicated across DCs.
Thanks to Michael Adam <ma@sernet.de>
Volker
(This used to be commit
3c879745cfc39be6128b63a88ecdbfa3d9ce6c2d)
Stefan Metzmacher [Mon, 15 Jan 2007 19:28:02 +0000 (19:28 +0000)]
r20820: merge from samba4:
- include system/aio.h
- use full prototype for main
- use ifdef instead if
metze
(This used to be commit
024dd7d7c95bcf8d77914dc2063f16220358e690)
Stefan Metzmacher [Mon, 15 Jan 2007 19:10:54 +0000 (19:10 +0000)]
r20817: sync lib/replace with samba4
metze
(This used to be commit
352ee730308bbc151a742938818c9b8b3a6e8014)
Stefan Metzmacher [Mon, 15 Jan 2007 18:01:25 +0000 (18:01 +0000)]
r20811: fix comment
metze
(This used to be commit
1f49b9c387ca91da233b0d3bf7a50ef3f6d81f98)
Volker Lendecke [Mon, 15 Jan 2007 09:17:11 +0000 (09:17 +0000)]
r20796: Fix the same problem Jeremy has fixed (improper handling of deferred opens)
for delete_driver_files. Proper fix pending... :-)
Jeremy, please check.
Volker
(This used to be commit
21b8f15dd5ad567efeacf5ba22dc4d8c64b09b76)
Stefan Metzmacher [Mon, 15 Jan 2007 07:17:02 +0000 (07:17 +0000)]
r20789: merge from samba4:
- remove the epoll configure checks from libreplace
metze
(This used to be commit
3061c333eca4aaff6af4b200cfe07d17f87018b2)
Jeremy Allison [Sun, 14 Jan 2007 19:43:06 +0000 (19:43 +0000)]
r20781: Fix a couple of paths found by Volker where we weren't
correctly handling deferred opens.
Jeremy.
(This used to be commit
e47b79d1cef279a1de1128d114d423c1fd2b1e8d)
Simo Sorce [Sun, 14 Jan 2007 17:58:24 +0000 (17:58 +0000)]
r20774: I thought I committed this before Xmas holidays ...
This change is needed to make it possible to not expire
caches in disconnected mode.
Jerry, please can you look at this and confirm it is ok?
Simo.
(This used to be commit
9e8715e4e15d9cede8f4aa9652642995392617e6)
Volker Lendecke [Sun, 14 Jan 2007 11:25:42 +0000 (11:25 +0000)]
r20759: Dummy checkin to let the build farm pick up the new smbtorture4
(This used to be commit
14c88b560e5c8fd59b84333e92337805620ccd7c)
Simo Sorce [Sun, 14 Jan 2007 00:08:31 +0000 (00:08 +0000)]
r20745: Commit Finnish transalation of SWAT after review
(This used to be commit
a971374117772ab0288faae6a33bce929ea117fa)
Jeremy Allison [Sat, 13 Jan 2007 22:26:46 +0000 (22:26 +0000)]
r20744: Fix the build (I missed some chkpth -> checkpath renames).
Jeremy.
(This used to be commit
89b7a0630de0bd95a56263b36d433b4e73517a70)
Jeremy Allison [Sat, 13 Jan 2007 22:22:32 +0000 (22:22 +0000)]
r20743: Remove another BOOL ok from reply_getatr.
Jeremy.
(This used to be commit
c154f430710a4646fac42774817dfed7b936b087)
Jeremy Allison [Sat, 13 Jan 2007 22:10:18 +0000 (22:10 +0000)]
r20742: Rename chkpth -> checkpath for sanity's sake :-).
Start removing unneeded "BOOL ok" from this reply.c
(this logic is old, old, old..... :-).
Jeremy.
(This used to be commit
3d52268095c605a80dfcd371769198a332baa0a5)
Volker Lendecke [Sat, 13 Jan 2007 20:26:53 +0000 (20:26 +0000)]
r20740: Get rid of some if-statements
(This used to be commit
db93c1b98d5445071ad0af229afed1f11ab0a862)
Volker Lendecke [Sat, 13 Jan 2007 19:55:37 +0000 (19:55 +0000)]
r20738: Remove unused variable
(This used to be commit
c16ce9ebaab0175e7f1dc13798d5599388fa35d6)
Volker Lendecke [Sat, 13 Jan 2007 10:40:09 +0000 (10:40 +0000)]
r20725: Get rid of a bool passed down -- gd, please check
(This used to be commit
1ef910f423a9ec69af6abf5a4e2137e8a4e81755)
Jeremy Allison [Sat, 13 Jan 2007 02:34:43 +0000 (02:34 +0000)]
r20724: Get closer to passing RAW-OPEN. If the client is using
create disposition of FILE_CREATE then there's no need
to check can_delete_file_in_directory().
Jeremy.
(This used to be commit
eb32b60efc4c332295ff6fc7e5d575f4b40e8ff6)
Jeremy Allison [Sat, 13 Jan 2007 02:13:45 +0000 (02:13 +0000)]
r20722: RAW-CHKPATH should now pass, build farm should
go back to normal. Sorry about that.
Jeremy.
(This used to be commit
d4127034fb89185fe7464d57c9f56f7914da6141)
Jeremy Allison [Sat, 13 Jan 2007 01:29:10 +0000 (01:29 +0000)]
r20721: Fix the search unix_convert error returns. Only open
to go...
Jeremy.
(This used to be commit
89f03a8db40365f99c6755ff19a4bfbf8d1bd316)
Jeremy Allison [Sat, 13 Jan 2007 01:07:39 +0000 (01:07 +0000)]
r20720: Fix the chkpath problem, still looking at findfirst.
Jeremy.
(This used to be commit
c5be0082ef60cd041121a9c36f4af934cd60562d)
Jeremy Allison [Fri, 12 Jan 2007 23:47:16 +0000 (23:47 +0000)]
r20718: Sync up the filename path parsing changes from SAMBA_3_0_24.
The only difference between the two trees now w.r.t file
serving are the changes to smbd/open.c in this branch I need
to review.
Jeremy.
(This used to be commit
f4474edf6a0c71001dbd01429ef70bafad6abd74)
Jim McDonough [Fri, 12 Jan 2007 21:56:25 +0000 (21:56 +0000)]
r20717: Merge sharemode patch from Mathias Dietz <MDIETZ@de.ibm.com>.
The patch fixes the behaviour of GPFS sharemodes when
the access mask is no_access.
(This used to be commit
799967c66879b4d6e28f1af6ba27c67f0b1deaeb)
Volker Lendecke [Fri, 12 Jan 2007 14:16:30 +0000 (14:16 +0000)]
r20707: Clean up pdb_interface.c a bit -- patch from Michael Adam <ma@sernet.de>
(This used to be commit
d78c18a9fa494a2b3ef48db0abd987c740556e50)
Volker Lendecke [Fri, 12 Jan 2007 09:29:44 +0000 (09:29 +0000)]
r20700: In the main processing loop we select() on the fam socket. If it fires, it
might be possible that we hang in the receive_smb() although that socket is
not the reason for the select() to return.
This immediately reacts to the fam socket to become readable, and goes into
the select loop again. This fixes delays in files showing up in Windows.
Jeremy, James please review this and merge to 3_0_24 if appropriate.
Thanks,
Volker
(This used to be commit
c846153b2ed2f9aca82491888e391ccbe239e88a)
Volker Lendecke [Fri, 12 Jan 2007 08:49:09 +0000 (08:49 +0000)]
r20699: This is an attempt to fix bug 4326.
James, can you please confirm this and merge it to 3_0_24? For me it fixes the
segfault.
Thanks,
Volker
(This used to be commit
a841b7659ba7b76b2da7993e1f4402aa0e11716f)
Jeremy Allison [Fri, 12 Jan 2007 02:58:01 +0000 (02:58 +0000)]
r20695: Remove duplication of constants.
Jeremy.
(This used to be commit
66cca893e1aa035fa0aa05c0d542848f084fac31)
Jeremy Allison [Fri, 12 Jan 2007 02:48:37 +0000 (02:48 +0000)]
r20694: To get this right we need to do signed 64-bit
comparisons here, not unsigned as we're eventually
casting into what it normall a signed 32 bit
value. Guenther please check (but I think I'm right here).
Jeremy.
(This used to be commit
31f8e0edc0c3e76654728b2c204faa70830e1f1b)
Jeremy Allison [Fri, 12 Jan 2007 02:12:15 +0000 (02:12 +0000)]
r20692: Fix bug found by Guenther -
Just try to log on in offline mode without the fix: all accounts are expired,
although they are set to never expire in the PAC/info3.
NTTIME "Never" needs to get (time_t) -1.
We were casting a uint64 to time_t before
comparing, and we should have been doing it
the other way around.
Guenther please check this fixes things.
Jeremy.
(This used to be commit
f4e898b6224fd82d9805da771ef6040065de7b12)
Andrew Tridgell [Thu, 11 Jan 2007 23:10:16 +0000 (23:10 +0000)]
r20690: fix a bug that causes smbd to 'hang' intermittently.
The problem occurs like this:
1) running smbd as a domain member without winbindd
2) client1 connects, during auth smbd-1 calls update_trustdom_cache()
3) smbd-1 takes the trustdom cache timestamp lock, then starts
enumerate_domain_trusts
4) enumerate_domain_trusts hangs for some unknown reason
5) other clients connect, all block waiting for read lock on trustdom
cache
6) samba is now hung
The problem is the lock, and really its just trying to avoid a race
where the cure is worse than the problem. A race in updating the
trutdom cache is not a big issue. So I've just removed the lock.
It is still an open question why enumerate_domain_trusts() can
hang. Unfortunately I've not in a position to get a sniff at the site
that is affected. I suspect a full fix will involve ensuring that all
the rpc code paths have appropriate timeouts.
(This used to be commit
ab8d41053347a5b342ed5b59a0b0dd4983ca91e6)
Günther Deschner [Thu, 11 Jan 2007 15:41:02 +0000 (15:41 +0000)]
r20687: Implement grace logons for offline authentications in pam_winbind.
In case a user authenticated sucessfully and his password just expired
while beeing disconnected, we should allow a user to logon (given a
clear warning). We currently forced the user into a password change
dialogue in that scenario; this did not make much sense while offline.
Guenther
(This used to be commit
668b278653acfc4de7807834988f7af557e608a5)
Jelmer Vernooij [Thu, 11 Jan 2007 01:47:22 +0000 (01:47 +0000)]
r20674: Regenerate NDR parsers after pidl changes. This should fix a couple of
coverity warnings.
(This used to be commit
5f86d006debd880ec35db4ebe7db0663c5cb220f)
Lars Müller [Wed, 10 Jan 2007 21:46:39 +0000 (21:46 +0000)]
r20668: Also do not install the smbumount man page if we don't build smbumount.
(This used to be commit
82ce272b2464f06e8bcbed6452621daa05e12b5d)
Lars Müller [Wed, 10 Jan 2007 20:08:25 +0000 (20:08 +0000)]
r20666: Also do not install the smbmnt man page if SMBMOUNT_PROGS is not set.
(This used to be commit
aa122be8f7a33ebceeb43e4f0c5362047560b199)
Lars Müller [Wed, 10 Jan 2007 19:54:49 +0000 (19:54 +0000)]
r20664: Set the environment variable _before_ calling the shell.
(This used to be commit
9cecd62654d22b47d938a44a8aed63c558d511ad)
Lars Müller [Wed, 10 Jan 2007 19:16:59 +0000 (19:16 +0000)]
r20663: Do not install smbmount man page if we didn't called configure
--with-smbmount.
(This used to be commit
ee12348cf1e93d0e75714f3883bfea6525797dc1)
Volker Lendecke [Wed, 10 Jan 2007 15:31:42 +0000 (15:31 +0000)]
r20654: Fix from Karolin Seeger <ks@sernet.de>: Accept "forever", "off" and "never" as
key words for -1 as policy values for net sam policy.
Volker
(This used to be commit
b6347751d8f67dcaac5c1bcbc07f03073278f6fb)
Günther Deschner [Wed, 10 Jan 2007 12:34:24 +0000 (12:34 +0000)]
r20651: Fix "password expires soon" warning message for pam_winbind.
We were incorrectly calculating the days until the password expires and
we also need to look at the info3 pass_must_change_time for expiry
calculation.
Guenther
(This used to be commit
22d79237127a064a934928d175182adecc6300de)
Volker Lendecke [Wed, 10 Jan 2007 07:56:43 +0000 (07:56 +0000)]
r20644: Make some functions static, thanks to Michael Adam <ma@sernet.de> for the hint.
(This used to be commit
f1f5d035db067b85e55b1c4009407b47dedcf975)
Volker Lendecke [Tue, 9 Jan 2007 20:04:46 +0000 (20:04 +0000)]
r20636: Remove notify leftover
(This used to be commit
a174b49173e7185abb89e605e667e64e8dd87454)
Jeremy Allison [Tue, 9 Jan 2007 18:48:38 +0000 (18:48 +0000)]
r20635: Add placeholder to ensure we don't go into the
wcard unlink if bad_path was set. The error
returned here is almost certainly incorrect
and will need testing properly with smbtorture,
but I don't want to forget about this path
(yes Volker I know this is currently incorrect :-).
Jeremy.
(This used to be commit
06e20c287898d21e437ab117eb5eeeaf2420ba78)
Volker Lendecke [Tue, 9 Jan 2007 16:12:54 +0000 (16:12 +0000)]
r20634: A *LOT* more work is necessary before touching notify remotely starts to make
sense. Until then, remove it from the tree to keep the diff between 3_0_24 and
3_0 small.
Volker
(This used to be commit
f146a85e74c84e78a11e616a1cbeaeef4693a0e0)
Volker Lendecke [Tue, 9 Jan 2007 15:50:40 +0000 (15:50 +0000)]
r20632: The extended RAW-SAMBA3BADPATH test led me to some wrong assumptions, in
particular the NT_STATUS_INVALID_PARAMETER thing was badly wrong. Remove the
changes based on it. Using gentest is much more effective in this respect, but
it will take a while to figure out the wildcard error handling of W2k3.
Volker
(This used to be commit
58b8a242a7f08c1292d24fc73df170dbcd68c10d)
Günther Deschner [Tue, 9 Jan 2007 13:24:33 +0000 (13:24 +0000)]
r20630: Fix some trivial memleaks.
Guenther
(This used to be commit
3bb94a081888eca69796b14057b551b078ee9a77)
Volker Lendecke [Tue, 9 Jan 2007 09:03:33 +0000 (09:03 +0000)]
r20628: Looks bigger than it is. This is just re-indenting the if (dirname) that we've
taken care of above.
Volker
(This used to be commit
5e1da363bb3f2675beb9fd9240301bb432e5239b)
Volker Lendecke [Tue, 9 Jan 2007 08:56:24 +0000 (08:56 +0000)]
r20627: orig_name is not needed anymore, and slightly simplify logic by doing early
returns.
Volker
(This used to be commit
614651c6a72742173de5fa8723403880acc37c09)
Volker Lendecke [Tue, 9 Jan 2007 08:19:05 +0000 (08:19 +0000)]
r20626: Fix a memleak found by the IBM checker -- not on 3.0.24
(This used to be commit
9d0a789e32e6a6501421edb25bc8197c9e06846d)
Volker Lendecke [Mon, 8 Jan 2007 21:13:27 +0000 (21:13 +0000)]
r20619: bad_path is handled somewhere else, so can_delete does not need it anymore
(This used to be commit
1798987128be579a1a4574294a7c3094040ebaf2)
Volker Lendecke [Mon, 8 Jan 2007 21:08:31 +0000 (21:08 +0000)]
r20618: Fix a bug in bad_path handling that also exists in 3.0.23: For reply_unlink
under Linux we returned NT_STATUS_NOT_A_DIRECTORY. This is because in the
bad_path==True condition lstat(2) returns ENOTDIR and not ENOENT.
Not sure if we want to necessarily replicate the INVALID_PARAMETER here, but
this is what W2k3 does.
Jeremy, I tried to call you, but you were not around. So I'll leave it up to
you to merge this.
Volker
(This used to be commit
b1edc3d053104204b966eed67d070ad5da40f17b)
Volker Lendecke [Mon, 8 Jan 2007 20:06:36 +0000 (20:06 +0000)]
r20617: Do not notify if the delete failed
(This used to be commit
c86fbdf8cc8f6f17b23e647bd1f4714c6095b860)