nivanova/samba-autobuild/.git
7 years agoparam: harmonise wins parameters
Andrew Bartlett [Thu, 12 Apr 2012 07:47:08 +0000 (17:47 +1000)]
param: harmonise wins parameters

7 years agolib/param: swap preferred name for 'lock dir' to match s3
Andrew Bartlett [Thu, 12 Apr 2012 07:39:24 +0000 (17:39 +1000)]
lib/param: swap preferred name for 'lock dir' to match s3

7 years agoparam: Merge common param elements by adding .flags
Andrew Bartlett [Thu, 12 Apr 2012 07:37:19 +0000 (17:37 +1000)]
param: Merge common param elements by adding .flags

This removes the difference between many of the key elements of the global
parameters table, and makes it easier to merge the two tables.

Andrew Bartlett

7 years agos3-param: make FN_GLOBAL macros consistent, add lp_ using the macro
Andrew Bartlett [Thu, 12 Apr 2012 07:10:36 +0000 (17:10 +1000)]
s3-param: make FN_GLOBAL macros consistent, add lp_ using the macro

This will make it easier to share the parameter tables between this
and lib/param.

Andrew Bartlett

7 years agoparam: Change from _lp to lp__ as the prefix for internal parameter wrappers
Andrew Bartlett [Thu, 12 Apr 2012 07:03:38 +0000 (17:03 +1000)]
param: Change from _lp to lp__ as the prefix for internal parameter wrappers

This will make a merge with the lib/param param code easier, as we can then paste lp_ to the front of
all parameters unconditionally.

Andrew Bartlett

7 years agomake _lp_readraw() and _lp_writeraw() static
Andrew Bartlett [Thu, 12 Apr 2012 06:58:40 +0000 (16:58 +1000)]
make _lp_readraw() and _lp_writeraw() static

7 years agoparam: harmonsise logfile parameter
Andrew Bartlett [Thu, 12 Apr 2012 06:51:54 +0000 (16:51 +1000)]
param: harmonsise logfile parameter

7 years agoparam: Merge common param elements by adding .flags
Andrew Bartlett [Thu, 12 Apr 2012 06:29:21 +0000 (16:29 +1000)]
param: Merge common param elements by adding .flags

This removes the difference between many of the key elements of the global
parameters table, and makes it easier to merge the two tables.

Andrew Bartlett

7 years agos4-provision: Update configuration lines for dlz_bind9
Amitay Isaacs [Thu, 5 Apr 2012 06:51:24 +0000 (16:51 +1000)]
s4-provision: Update configuration lines for dlz_bind9

This adds configuration lines for BIND versions 9.8.x and 9.9.x.

Autobuild-User: Amitay Isaacs <amitay@samba.org>
Autobuild-Date: Mon Apr 16 03:52:14 CEST 2012 on sn-devel-104

7 years agodlz_bind9: Build shared libraries for both BIND versions 9.8 and 9.9
Amitay Isaacs [Thu, 5 Apr 2012 06:45:01 +0000 (16:45 +1000)]
dlz_bind9: Build shared libraries for both BIND versions 9.8 and 9.9

This adds #define BIND_VERSION_9_8 and keeps the current version as 9.9, so
shared libraries can be built for both BIND versions.

7 years agodlz_bind9: changes to make dlz_bind9 work with BIND 9.9.0
Amitay Isaacs [Thu, 8 Mar 2012 07:34:04 +0000 (18:34 +1100)]
dlz_bind9: changes to make dlz_bind9 work with BIND 9.9.0

The main changes are:
  DLZ_DLOPEN_VERSION changed from 1 to 2
  isc_boolean_t changed from bool to int
  dlz_lookup() now takes 2 additional arguments

7 years agowaf: samba-specific methods should have capitalized names, change process_separate_ru...
Alexander Bokovoy [Sat, 14 Apr 2012 05:16:20 +0000 (08:16 +0300)]
waf: samba-specific methods should have capitalized names, change process_separate_rule to follow

Changing process_separate_rule to PROCESS_SEPARATE_RULE.

Thanks Thomas Nagy for review.

Autobuild-User: Alexander Bokovoy <ab@samba.org>
Autobuild-Date: Sat Apr 14 08:55:43 CEST 2012 on sn-devel-104

7 years agodocs: add a vfs_tsmsm manpage
Michael Adam [Thu, 22 Mar 2012 22:15:58 +0000 (23:15 +0100)]
docs: add a vfs_tsmsm manpage

Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Sat Apr 14 01:54:13 CEST 2012 on sn-devel-104

7 years agos4-auth: Make sure ldb context is initialized even if not passed by Python code
Alexander Bokovoy [Fri, 13 Apr 2012 20:44:52 +0000 (23:44 +0300)]
s4-auth: Make sure ldb context is initialized even if not passed by Python code

Autobuild-User: Alexander Bokovoy <ab@samba.org>
Autobuild-Date: Sat Apr 14 00:21:00 CEST 2012 on sn-devel-104

7 years agorely on sys/inotify.h for inotify
Adrian Bunk [Mon, 9 Apr 2012 18:16:12 +0000 (21:16 +0300)]
rely on sys/inotify.h for inotify

sys/inotify.h was added to glibc 2.4 in 2006.

Signed-off-by: Jeremy Allison <jra@samba.org>
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Apr 13 21:15:00 CEST 2012 on sn-devel-104

7 years agowafsamba: add support for separate rules in stages
Alexander Bokovoy [Fri, 13 Apr 2012 14:53:04 +0000 (17:53 +0300)]
wafsamba: add support for separate rules in stages

bld.process_separate_rule(rule) and conf.process_separate_rule(rule)
will cause WAF to import wscript_<stage>_<rule> script into current
context.

Files wscript_<configure|build>_<rule> should exist in the current
directory.

This can be used to provide rules specific for alternative
implementations of certain libraries

Autobuild-User: Alexander Bokovoy <ab@samba.org>
Autobuild-Date: Fri Apr 13 18:34:39 CEST 2012 on sn-devel-104

7 years agoWrong assertion/comparison: Compare value not pointer
Olaf Flebbe [Thu, 12 Apr 2012 09:29:41 +0000 (11:29 +0200)]
Wrong assertion/comparison: Compare value not pointer

Signed-off-by: Jeremy Allison <jra@samba.org>
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Apr 13 02:23:36 CEST 2012 on sn-devel-104

7 years agoWe never cancel SMB1 aio, only SMB2 aio - and in this case we always return a value.
Jeremy Allison [Thu, 12 Apr 2012 22:11:22 +0000 (15:11 -0700)]
We never cancel SMB1 aio, only SMB2 aio - and in this case we always return a value.

So pass_cancel is no longer needed.

7 years agoRemove cancel_aio_by_fsp(). It can never work and could lead to memory corruption
Jeremy Allison [Thu, 12 Apr 2012 22:04:42 +0000 (15:04 -0700)]
Remove cancel_aio_by_fsp(). It can never work and could lead to memory corruption
as outstanding IO's complete. Also we never have any aio's on a call to close_normal_file()
with close_type ERROR_CLOSE.

7 years agoFix return_fn when aio was cancelled. We need to return -1, errno = ECANCELED.
Jeremy Allison [Thu, 12 Apr 2012 22:04:08 +0000 (15:04 -0700)]
Fix return_fn when aio was cancelled. We need to return -1, errno = ECANCELED.

7 years agoMove the counting of outstanding_aio_calls into the lifecycle of the aio_extra struct.
Jeremy Allison [Thu, 12 Apr 2012 20:48:29 +0000 (13:48 -0700)]
Move the counting of outstanding_aio_calls into the lifecycle of the aio_extra struct.
This way we can't end up with a mismatch between outstanding events and the counter.

We may still have problems with canceling and not correctly freeing the aio
struct, but at least the counter won't get out of sync anymore.

7 years agoFix the same bug reported by Kirill Malkin <kirill.malkin@starboardstorage.com> and
Jeremy Allison [Thu, 12 Apr 2012 20:15:23 +0000 (13:15 -0700)]
Fix the same bug reported by Kirill Malkin <kirill.malkin@starboardstorage.com>  and
fixed by Volker for vfs_aio_fork as ref 0aacdbfada46329e0ad9dacfa90041a1c7dbf3e8.

From that change:

    aio_suspend does not signal the main process with a signal, it just waits. The
    aio_fork module does not use the signal at all, it directly calls back into the
    main smbd by calling smbd_aio_complete_aio_ex. This is an abstraction
    violation, but the alternative would have been to use signals where they are
    not needed. However, in wait_for_aio_completion this bites us: With aio_fork we
    call handle_aio_completed twice on the same aio_ex struct: Once from the call
    to handle_aio_completion within the aio_fork module and once from the code in
    wait_for_aio_completion.

Fix this differently here by not calling directly back into smbd,
but using a new function aio_linux_setup_returns() to setup the
return values that wait_for_aio_completion() in the main smbd
will pick up by calling handle_aio_completd().

7 years agos3: Fix a typo
Volker Lendecke [Thu, 12 Apr 2012 19:59:31 +0000 (21:59 +0200)]
s3: Fix a typo

Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Thu Apr 12 23:38:24 CEST 2012 on sn-devel-104

7 years agos3: Fix a segfault with debug level 3 on Solaris
Volker Lendecke [Thu, 12 Apr 2012 10:15:50 +0000 (12:15 +0200)]
s3: Fix a segfault with debug level 3 on Solaris

printf can not deal with NULL strings

7 years agos4-libnet: split export_keytab in a separate python module to avoid pulling in HDB...
Alexander Bokovoy [Tue, 10 Apr 2012 09:09:20 +0000 (12:09 +0300)]
s4-libnet: split export_keytab in a separate python module to avoid pulling in HDB dependency

Signed-off-by: Andreas Schneider <asn@samba.org>
Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Thu Apr 12 15:23:19 CEST 2012 on sn-devel-104

7 years agoWAF: Add support for stopping processing before end of wscript{_*}
Alexander Bokovoy [Tue, 3 Apr 2012 08:22:15 +0000 (11:22 +0300)]
WAF: Add support for stopping processing before end of wscript{_*}

WAF scripts are written in Python and Python has no simple way
to stop program execution other than using exceptions.

This change adds WscriptCheckSkipped exception and its handling in
core WAF code. When any of wscript{_*} throws WscriptCheckSkipped
exception, WAF simply continues to process next wscript in queue
rather than breaking build.

WscriptCheckSkipped exception can be used to perform early bail out
of configuration/build target checks if certain dependency is not available
when the default checks are way more numerous than a check for this
particular dependency. This is to avoid 'if ...' indenting for large
blocks of existing code which also muddens git history for nothing.

Signed-off-by: Andreas Schneider <asn@samba.org>
7 years agoclikrb5: Move pure krb wrapper functions from libads to clikrb5.
Simo Sorce [Tue, 3 Apr 2012 03:41:32 +0000 (23:41 -0400)]
clikrb5: Move pure krb wrapper functions from libads to clikrb5.

Signed-off-by: Andreas Schneider <asn@samba.org>
7 years agogse: Remove unnecessary header.
Simo Sorce [Mon, 2 Apr 2012 14:20:24 +0000 (10:20 -0400)]
gse: Remove unnecessary header.

Signed-off-by: Andreas Schneider <asn@samba.org>
7 years agosrv_keytab: Pass krb5_context directly, it's all we use anyways.
Simo Sorce [Sun, 1 Apr 2012 23:08:15 +0000 (19:08 -0400)]
srv_keytab: Pass krb5_context directly, it's all we use anyways.

Signed-off-by: Andreas Schneider <asn@samba.org>
7 years agokrb5_wrap: krb5_string_to_key / krb5_encrypt_block are deprecated.
Simo Sorce [Sun, 1 Apr 2012 21:28:19 +0000 (17:28 -0400)]
krb5_wrap: krb5_string_to_key / krb5_encrypt_block are deprecated.

Remove checks and replace with krb5_c_string_to_key().

Signed-off-by: Andreas Schneider <asn@samba.org>
7 years agoauth-krb: Move pac related util functions in a single place.
Simo Sorce [Sun, 1 Apr 2012 02:09:22 +0000 (22:09 -0400)]
auth-krb: Move pac related util functions in a single place.

Signed-off-by: Andreas Schneider <asn@samba.org>
7 years agoauth-krb: Make functions static.
Simo Sorce [Sun, 1 Apr 2012 01:48:06 +0000 (21:48 -0400)]
auth-krb: Make functions static.

The remaining gssapi_parse functions were used exclusively in
gensec_krb5.  Move them there and make them static.

Signed-off-by: Andreas Schneider <asn@samba.org>
7 years agoauth-krb: Use simpler method to extract keytype.
Simo Sorce [Mon, 2 Apr 2012 02:48:21 +0000 (22:48 -0400)]
auth-krb: Use simpler method to extract keytype.

Signed-off-by: Andreas Schneider <asn@samba.org>
7 years agoauth-krb: Nove oid packet check to gensec_util.
Simo Sorce [Sun, 1 Apr 2012 01:37:56 +0000 (21:37 -0400)]
auth-krb: Nove oid packet check to gensec_util.

This is clearly a utiliy function generic to gensec.  Also the 3 callers
had identical implementations. Provide a generic implementation for all
of them and avoid duplicating the code everywhere.

Signed-off-by: Andreas Schneider <asn@samba.org>
7 years agos4-auth-krb: Remove dependency on credentials too.
Simo Sorce [Sat, 31 Mar 2012 09:19:59 +0000 (05:19 -0400)]
s4-auth-krb: Remove dependency on credentials too.

Signed-off-by: Andreas Schneider <asn@samba.org>
7 years agos4-auth-krb: Remove unneded dependency on kerberos_util.
Simo Sorce [Sat, 31 Mar 2012 07:23:19 +0000 (03:23 -0400)]
s4-auth-krb: Remove unneded dependency on kerberos_util.

Signed-off-by: Andreas Schneider <asn@samba.org>
7 years agos4-auth-krb: Simplify salt_princ handling.
Simo Sorce [Sat, 31 Mar 2012 05:27:02 +0000 (01:27 -0400)]
s4-auth-krb: Simplify salt_princ handling.

This allows us to make parse_principal static in kerbeors_util again and
avoid a silly game where we alloc containers and set destrcutors only to
release the whole thing at the end of the function.

Signed-off-by: Andreas Schneider <asn@samba.org>
7 years agos4-auth-krb: Move function to db-glue.c and make it static.
Simo Sorce [Sat, 31 Mar 2012 05:15:36 +0000 (01:15 -0400)]
s4-auth-krb: Move function to db-glue.c and make it static.

kerberos_enctype_to_bitmap is not used anywhere else, so just move it there and
make it static, one less dependency to worry about.

Signed-off-by: Andreas Schneider <asn@samba.org>
7 years agos4-auth-krb: Move keytab functions in a separate file.
Simo Sorce [Fri, 30 Mar 2012 23:33:53 +0000 (19:33 -0400)]
s4-auth-krb: Move keytab functions in a separate file.

Confine ldb dependency.

Signed-off-by: Andreas Schneider <asn@samba.org>
7 years agos4-auth-krb: Streamline and cleanup code to make it readable.
Simo Sorce [Fri, 30 Mar 2012 22:33:41 +0000 (18:33 -0400)]
s4-auth-krb: Streamline and cleanup code to make it readable.

Signed-off-by: Andreas Schneider <asn@samba.org>
7 years agos4-auth-krb: streamline and rename enctype functions
Simo Sorce [Fri, 30 Mar 2012 22:32:07 +0000 (18:32 -0400)]
s4-auth-krb: streamline and rename enctype functions

better express what is being done in the function name.

7 years agos4-auth-krb: Make kerberos_enctype_bitmap_to_enctype static.
Simo Sorce [Fri, 30 Mar 2012 22:29:26 +0000 (18:29 -0400)]
s4-auth-krb: Make kerberos_enctype_bitmap_to_enctype static.

It's a helper function not used anywhere else.

Signed-off-by: Andreas Schneider <asn@samba.org>
7 years agos4-auth-krb: Make kerberos_enctype_bitmap_to_enctypes static.
Simo Sorce [Fri, 30 Mar 2012 21:32:12 +0000 (17:32 -0400)]
s4-auth-krb: Make kerberos_enctype_bitmap_to_enctypes static.

It is not used anywhere else.

Signed-off-by: Andreas Schneider <asn@samba.org>
7 years agos4-auth-krb: Move function into more appropriate header.
Simo Sorce [Fri, 30 Mar 2012 21:17:07 +0000 (17:17 -0400)]
s4-auth-krb: Move function into more appropriate header.

Signed-off-by: Andreas Schneider <asn@samba.org>
7 years agos4-auth-krb: Make cli_credentials_invalidate_client_gss_creds static.
Simo Sorce [Fri, 30 Mar 2012 21:11:02 +0000 (17:11 -0400)]
s4-auth-krb: Make cli_credentials_invalidate_client_gss_creds static.

It's not used anywhere else.

Signed-off-by: Andreas Schneider <asn@samba.org>
7 years agos4-auth-krb: Make impersonate_principal_from_credentials static.
Simo Sorce [Fri, 30 Mar 2012 20:51:58 +0000 (16:51 -0400)]
s4-auth-krb: Make impersonate_principal_from_credentials static.

It's not used anywhere else.

Signed-off-by: Andreas Schneider <asn@samba.org>
7 years agogensec_gssapi: keep private header file close to the actual code
Simo Sorce [Fri, 30 Mar 2012 19:48:54 +0000 (15:48 -0400)]
gensec_gssapi: keep private header file close to the actual code

Signed-off-by: Andreas Schneider <asn@samba.org>
7 years agokrb5_wrap: remove duplicate declaration and dead ifdef
Simo Sorce [Sat, 31 Mar 2012 04:11:02 +0000 (00:11 -0400)]
krb5_wrap: remove duplicate declaration and dead ifdef

Signed-off-by: Andreas Schneider <asn@samba.org>
7 years agos4-ldb: use KRB5_KEY macros to access key elements.
Günther Deschner [Fri, 30 Mar 2012 13:25:59 +0000 (15:25 +0200)]
s4-ldb: use KRB5_KEY macros to access key elements.

Guenther

Signed-off-by: Andreas Schneider <asn@samba.org>
7 years agowafsamba: point out that local heimdal paths are not included when
Günther Deschner [Fri, 30 Mar 2012 13:19:14 +0000 (15:19 +0200)]
wafsamba: point out that local heimdal paths are not included when
USING_SYSTEM_KRB5 gets set.

Guenther

Signed-off-by: Andreas Schneider <asn@samba.org>
7 years agowaf: when USING_SYSTEM_KRB5 environment variable is set, dont configure local
Günther Deschner [Fri, 30 Mar 2012 13:18:16 +0000 (15:18 +0200)]
waf: when USING_SYSTEM_KRB5 environment variable is set, dont configure local
heimdal.

Guenther

Signed-off-by: Andreas Schneider <asn@samba.org>
7 years agowaf: when building with system krb5, we do not need to build local heimdal.
Günther Deschner [Fri, 30 Mar 2012 13:16:43 +0000 (15:16 +0200)]
waf: when building with system krb5, we do not need to build local heimdal.

Guenther

Signed-off-by: Andreas Schneider <asn@samba.org>
7 years agos3-waf: remove requirement of having --enable-developer for running system krb5 checks.
Günther Deschner [Tue, 27 Mar 2012 15:07:02 +0000 (17:07 +0200)]
s3-waf: remove requirement of having --enable-developer for running system krb5 checks.

When you know about "with_mit_krb5_checks" you are most likely a developer
already.

Guenther

Signed-off-by: Andreas Schneider <asn@samba.org>
7 years agoRemove overly complex attemt to define blkcnt_t and blksize_t. AC_CHECK_TYPE should...
Jeremy Allison [Thu, 12 Apr 2012 00:50:54 +0000 (17:50 -0700)]
Remove overly complex attemt to define blkcnt_t and blksize_t. AC_CHECK_TYPE should just do it.

Still trying to fix the buildfarm.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Apr 12 04:28:29 CEST 2012 on sn-devel-104

7 years agoTry and fix autoconf on the build farm. Always include sys/types.h when working out...
Jeremy Allison [Thu, 12 Apr 2012 00:10:27 +0000 (17:10 -0700)]
Try and fix autoconf on the build farm. Always include sys/types.h when working out sizeof(blkcnt_t).

7 years agos3:smbd only care about missing level2 support if kernel oplocks are enabled
Christian Ambach [Fri, 30 Mar 2012 14:11:08 +0000 (16:11 +0200)]
s3:smbd only care about missing level2 support if kernel oplocks are enabled

if kernel oplocks are not enabled for that share, we can grant level2 oplocks

Signed-off-by: Jeremy Allison <jra@samba.org>
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Apr 11 22:45:21 CEST 2012 on sn-devel-104

7 years agos3:smbd only initialize kernel oplocks if they are enabled for a share
Christian Ambach [Fri, 30 Mar 2012 14:00:15 +0000 (16:00 +0200)]
s3:smbd only initialize kernel oplocks if they are enabled for a share

Signed-off-by: Jeremy Allison <jra@samba.org>
7 years agos3:smbd add seperate function to initialize kernel oplocks
Christian Ambach [Fri, 30 Mar 2012 13:51:25 +0000 (15:51 +0200)]
s3:smbd add seperate function to initialize kernel oplocks

Signed-off-by: Jeremy Allison <jra@samba.org>
7 years agodocs: update kernel oplocks documentation
Christian Ambach [Fri, 30 Mar 2012 14:11:37 +0000 (16:11 +0200)]
docs: update kernel oplocks documentation

Signed-off-by: Jeremy Allison <jra@samba.org>
7 years agos3:param convert kernel oplocks to share parameter
Christian Ambach [Fri, 30 Mar 2012 13:31:19 +0000 (15:31 +0200)]
s3:param convert kernel oplocks to share parameter

Signed-off-by: Jeremy Allison <jra@samba.org>
7 years agobuild: Fix spelling of tevent
Andrew Bartlett [Wed, 11 Apr 2012 05:16:05 +0000 (15:16 +1000)]
build: Fix spelling of tevent

Found by metze.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Wed Apr 11 17:36:19 CEST 2012 on sn-devel-104

7 years agobuild: use include paths for pkg-config found libraries
Andrew Bartlett [Wed, 11 Apr 2012 08:40:27 +0000 (18:40 +1000)]
build: use include paths for pkg-config found libraries

7 years agolib/tdb_compat: Do not define BUILD_TDB2 if we are not building tdb2
Andrew Bartlett [Wed, 11 Apr 2012 12:18:34 +0000 (22:18 +1000)]
lib/tdb_compat: Do not define BUILD_TDB2 if we are not building tdb2

The simple fact that this was defined at all, even to false, caused some
of the tdb2 build code to run.

Andrew Bartlett

7 years agos4-smb2: Fix a talloc crash bug.
Andreas Schneider [Wed, 11 Apr 2012 12:15:54 +0000 (14:15 +0200)]
s4-smb2: Fix a talloc crash bug.

The talloc context needs to be initialzed or NULL. So move
talloc_steal() to the position where req is initialized.

Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Wed Apr 11 15:59:39 CEST 2012 on sn-devel-104

7 years agoSimplify the logic around doing an immediate event reschedule.
Jeremy Allison [Wed, 11 Apr 2012 03:47:14 +0000 (20:47 -0700)]
Simplify the logic around doing an immediate event reschedule.

We don't need to do a talloc here, we already have a long-lived
pointer we can pass in as the private data.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Apr 11 08:05:47 CEST 2012 on sn-devel-104

7 years agos4:dsdb/samdb/ldb_modules/schema.c - move "get_last_structural_class()" into "util.c"
Matthias Dieter Wallnöfer [Wed, 4 Apr 2012 20:24:16 +0000 (22:24 +0200)]
s4:dsdb/samdb/ldb_modules/schema.c - move "get_last_structural_class()" into "util.c"

And remove this helper module - it does not have much sense keeping it.

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Wed Apr 11 06:31:51 CEST 2012 on sn-devel-104

7 years agos4:dsdb/samdb/ldb_modules/schema.c - inline "get_oc_guid_from_message()" to its only...
Matthias Dieter Wallnöfer [Wed, 4 Apr 2012 19:58:04 +0000 (21:58 +0200)]
s4:dsdb/samdb/ldb_modules/schema.c - inline "get_oc_guid_from_message()" to its only user

Reduce the number of not to be shared functions in "schema.c". Change it
to make use of "get_last_structural_class()".

7 years agos4:dsdb - introduce a only constant-time "get_last_structural_class()" call
Matthias Dieter Wallnöfer [Wed, 4 Apr 2012 16:55:40 +0000 (18:55 +0200)]
s4:dsdb - introduce a only constant-time "get_last_structural_class()" call

With the redesign of the previous patches this has become possible.

7 years agos4:dsdb/samdb/ldb_modules/schema.c - inline "acl_check_access_on_class" to its only...
Matthias Dieter Wallnöfer [Wed, 4 Apr 2012 10:29:58 +0000 (12:29 +0200)]
s4:dsdb/samdb/ldb_modules/schema.c - inline "acl_check_access_on_class" to its only user

Reduce the number of not to be shared functions in "schema.c".

7 years agos4:dsdb - move "objectclass_sort()" out from the objectclass LDB module into the...
Matthias Dieter Wallnöfer [Wed, 4 Apr 2012 16:40:00 +0000 (18:40 +0200)]
s4:dsdb - move "objectclass_sort()" out from the objectclass LDB module into the schema code

This allows it to be useful for the dbchecker utility in respect to
object class problems.
Fix up the API to only work with standardised LDB "ldb_message_element"
structures which do allow much easier interoperations. As a consequence this
leads to some changes in the objectclass module as well.

7 years agos4:acl LDB module - remove set but unused variables
Matthias Dieter Wallnöfer [Wed, 4 Apr 2012 18:27:30 +0000 (20:27 +0200)]
s4:acl LDB module - remove set but unused variables

7 years agos4:objectclass LDB module - remove unneeded build dependencies
Matthias Dieter Wallnöfer [Wed, 4 Apr 2012 16:48:23 +0000 (18:48 +0200)]
s4:objectclass LDB module - remove unneeded build dependencies

7 years agoLDB:ldb_msg.c - add another OOM check in "ldb_msg_copy()"
Matthias Dieter Wallnöfer [Wed, 4 Apr 2012 14:05:50 +0000 (16:05 +0200)]
LDB:ldb_msg.c - add another OOM check in "ldb_msg_copy()"

7 years agos4:schema/schema_query.c - fix a comment
Matthias Dieter Wallnöfer [Thu, 5 Apr 2012 19:55:07 +0000 (21:55 +0200)]
s4:schema/schema_query.c - fix a comment

7 years agos4:schema/schema_init.c - better use "ldb_attr_cmp" instead of "strcasecmp"
Matthias Dieter Wallnöfer [Thu, 5 Apr 2012 19:38:14 +0000 (21:38 +0200)]
s4:schema/schema_init.c - better use "ldb_attr_cmp" instead of "strcasecmp"

LDB convention

7 years agos4:dsdb/pydsdb.c - fix indentation
Matthias Dieter Wallnöfer [Wed, 4 Apr 2012 10:14:12 +0000 (12:14 +0200)]
s4:dsdb/pydsdb.c - fix indentation

7 years agoon our way with Samba 4.0alpha20
Andrew Bartlett [Tue, 10 Apr 2012 21:33:26 +0000 (07:33 +1000)]
on our way with Samba 4.0alpha20

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Wed Apr 11 04:04:18 CEST 2012 on sn-devel-104

7 years agoprepare WHATSNEW for Samba 4.0alpha19 release and mark as release. samba-4.0.0alpha19
Andrew Bartlett [Tue, 10 Apr 2012 21:32:43 +0000 (07:32 +1000)]
prepare WHATSNEW for Samba 4.0alpha19 release and mark as release.

7 years agoccan: Fix failtest on Fedora 16 as stdlib.h does not imply malloc.h
Andrew Bartlett [Tue, 10 Apr 2012 22:27:14 +0000 (08:27 +1000)]
ccan: Fix failtest on Fedora 16 as stdlib.h does not imply malloc.h

The issue is that there are two different sources of the malloc
prototype, and they both need to be included otherwise the failtest
overrides chokes on the headers.

Andrew Bartlett

7 years agoremove --enable-developer from samba4-libs autobuild
Andrew Bartlett [Tue, 10 Apr 2012 22:01:47 +0000 (08:01 +1000)]
remove --enable-developer from samba4-libs autobuild

This will ensure everything works for end users without --enable-developer.

Andrew Bartlett

7 years agoremove --enable-developer from recursive waf build in autoconf build
Andrew Bartlett [Tue, 10 Apr 2012 21:59:01 +0000 (07:59 +1000)]
remove --enable-developer from recursive waf build in autoconf build

wanting to run make test does not make you a developer in need of ABI checking.

Andrew Bartlett

7 years agobuildtools: Add --enable-debug option
Andrew Bartlett [Tue, 10 Apr 2012 22:08:44 +0000 (08:08 +1000)]
buildtools: Add --enable-debug option

7 years ago.gitignore: ignore MYMETA.yml
Andrew Bartlett [Tue, 10 Apr 2012 21:56:00 +0000 (07:56 +1000)]
.gitignore: ignore MYMETA.yml

7 years agobuild: search for talloc, tdb, tevent in non-standard system locations
Andrew Bartlett [Tue, 10 Apr 2012 23:36:12 +0000 (09:36 +1000)]
build: search for talloc, tdb, tevent in non-standard system locations

This is needed because the s3 includes.h directly mentions these
headers, but not every part of s3 depends on these directly.

Andrew Bartlett

7 years agobuild: Add tevent deps for users of tevent calls
Andrew Bartlett [Tue, 10 Apr 2012 23:09:56 +0000 (09:09 +1000)]
build: Add tevent deps for users of tevent calls

This isn't strictly required - this isn't a build break at the moment,
but is a good practice to directly depend on the major libraries we
use, and helps us to have more fine-grained rather than global
dependencies.

Andrew Bartlett

7 years agoAdd a new module, aio_linux which implements Linux kernel aio support. Docs to follow.
Jeremy Allison [Tue, 10 Apr 2012 22:45:55 +0000 (15:45 -0700)]
Add a new module, aio_linux which implements Linux kernel aio support. Docs to follow.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Apr 11 02:29:04 CEST 2012 on sn-devel-104

7 years agopidl/NDR/Parser: also do range checks on the array size
Stefan Metzmacher [Thu, 15 Mar 2012 16:03:05 +0000 (17:03 +0100)]
pidl/NDR/Parser: also do range checks on the array size

metze

Autobuild-User: Karolin Seeger <kseeger@samba.org>
Autobuild-Date: Tue Apr 10 18:21:59 CEST 2012 on sn-devel-104

7 years agopidl/NDR/Parser: do array range validation in ParseArrayPullGetLength()
Stefan Metzmacher [Thu, 15 Mar 2012 12:14:48 +0000 (13:14 +0100)]
pidl/NDR/Parser: do array range validation in ParseArrayPullGetLength()

metze

7 years agopidl/NDR/Parser: use helper variables for array size and length
Stefan Metzmacher [Thu, 15 Mar 2012 12:13:20 +0000 (13:13 +0100)]
pidl/NDR/Parser: use helper variables for array size and length

metze

7 years agopidl/NDR/Parser: remember if we already know the array length
Stefan Metzmacher [Thu, 15 Mar 2012 14:07:08 +0000 (15:07 +0100)]
pidl/NDR/Parser: remember if we already know the array length

metze

7 years agopidl/NDR/Parser: use ParseArrayPullGetLength() to get the number of array elements...
Stefan Metzmacher [Thu, 15 Mar 2012 12:07:47 +0000 (13:07 +0100)]
pidl/NDR/Parser: use ParseArrayPullGetLength() to get the number of array elements (bug #8815 / CVE-2012-1182)

An anonymous researcher and Brian Gorenc (HP DVLabs) working
with HP's Zero Day Initiative program have found this and notified us.

metze

7 years agopidl/NDR/Parser: split off ParseArrayPullGetSize() and ParseArrayPullGetLength()
Stefan Metzmacher [Thu, 15 Mar 2012 12:05:39 +0000 (13:05 +0100)]
pidl/NDR/Parser: split off ParseArrayPullGetSize() and ParseArrayPullGetLength()

metze

7 years agopidl/NDR/Parser: simplify logic in DeclareArrayVariables*()
Stefan Metzmacher [Thu, 15 Mar 2012 12:12:04 +0000 (13:12 +0100)]
pidl/NDR/Parser: simplify logic in DeclareArrayVariables*()

metze

7 years agopidl/NDR/Parser: declare all union helper variables in ParseUnionPull()
Stefan Metzmacher [Thu, 15 Mar 2012 12:09:51 +0000 (13:09 +0100)]
pidl/NDR/Parser: declare all union helper variables in ParseUnionPull()

metze

7 years agos3: Use talloc_get_size instead of strlen
Volker Lendecke [Sat, 7 Apr 2012 12:17:25 +0000 (14:17 +0200)]
s3: Use talloc_get_size instead of strlen

We've just talloc_asprintf'ed the fullpath, so talloc_get_size knows the
strlen.

Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Tue Apr 10 13:20:22 CEST 2012 on sn-devel-104

7 years agoldb-tools: Place the whole of an ldif file in a transaction ldb-1.1.5
Andrew Bartlett [Wed, 4 Apr 2012 05:17:32 +0000 (15:17 +1000)]
ldb-tools: Place the whole of an ldif file in a transaction

This ensures that when operating ldbadd and ldbmodify against local
ldb files, either an ldif file succeeds or fails as a whole.

Also tests to verify that this is working correctly, and an ABI bump
due to the extra (private, but exported to ldb* tools) symbol and
behaviour change.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Tue Apr 10 11:14:43 CEST 2012 on sn-devel-104

7 years agoldb: Allow access to the line number while reading ldif from a file
Andrew Bartlett [Tue, 10 Apr 2012 07:29:11 +0000 (17:29 +1000)]
ldb: Allow access to the line number while reading ldif from a file

7 years agoldb: Detect failures in ldb.base again
Andrew Bartlett [Wed, 4 Apr 2012 08:52:25 +0000 (18:52 +1000)]
ldb: Detect failures in ldb.base again

We need to wrap the ldb tests in the subunit blackbox helpers.

We also needed to change to the right directory, or else the :< file://
syntax check does not work, as samba4.png is not found.

Andrew Bartlett

7 years agoRevert "ldb: Permit desactivation of autocomit for every ldb_xxx_ctrl function"
Andrew Bartlett [Wed, 4 Apr 2012 02:51:00 +0000 (12:51 +1000)]
Revert "ldb: Permit desactivation of autocomit for every ldb_xxx_ctrl function"

This reverts commit 40a4aea8918c2637703af03383f440d068820e48.

Autocommit is important, as otherwise an ldb module could error out
during an operation, and leave an corrupt database.

Andrew Bartlett

7 years agoOn advice from Jelmer and Andrew, move the blksize_t and blkcnt_t tests into librepla...
Jeremy Allison [Mon, 9 Apr 2012 22:31:23 +0000 (15:31 -0700)]
On advice from Jelmer and Andrew, move the blksize_t and blkcnt_t tests into libreplace to make it standalone.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Tue Apr 10 04:07:11 CEST 2012 on sn-devel-104