Andreas Schneider [Tue, 8 Mar 2011 16:04:44 +0000 (17:04 +0100)]
tevent: Fixed tevent_wakeup_send code example.
Andrew Bartlett [Wed, 2 Mar 2011 08:06:15 +0000 (19:06 +1100)]
librpc/ndr use hyper for uid_t/gid_t rather than udlong
This has 8 byte alignment, which is what was specified in pidl for
these types.
Andrew Bartlett
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Wed Mar 9 09:03:09 CET 2011 on sn-devel-104
Volker Lendecke [Tue, 8 Mar 2011 19:59:59 +0000 (20:59 +0100)]
s3: Use talloc_tos() in idmap_nss_sids_to_unixids
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Tue Mar 8 21:51:58 CET 2011 on sn-devel-104
Volker Lendecke [Tue, 8 Mar 2011 19:39:40 +0000 (20:39 +0100)]
s3: "dom_name" is not needed in idmap_nss_sids_to_unixids
Volker Lendecke [Tue, 8 Mar 2011 19:37:30 +0000 (20:37 +0100)]
s3: "ctx" is not needed in idmap_nss_unixids_to_sids
Günther Deschner [Tue, 8 Mar 2011 13:00:35 +0000 (14:00 +0100)]
s3-selftest: only run smbtorture4 tests when smbtorture4 is available.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue Mar 8 14:51:18 CET 2011 on sn-devel-104
Günther Deschner [Sat, 5 Mar 2011 00:28:02 +0000 (01:28 +0100)]
s3-selftest: add pattern test of dcerpc binding options (using rpc.lsa.lookupsids).
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue Mar 8 12:29:21 CET 2011 on sn-devel-104
Günther Deschner [Sat, 5 Mar 2011 00:26:55 +0000 (01:26 +0100)]
s3-waf: fix the build.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Günther Deschner [Sat, 5 Mar 2011 00:26:13 +0000 (01:26 +0100)]
s3-epmd: remove some unused variables.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Günther Deschner [Sat, 5 Mar 2011 00:25:28 +0000 (01:25 +0100)]
s3-epmap: fix uninitialized variable in ep_register()
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Günther Deschner [Fri, 4 Mar 2011 15:05:35 +0000 (16:05 +0100)]
s3-selftest: no need to run rpc.samba3.netlogon twice.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Mon, 7 Mar 2011 16:26:42 +0000 (17:26 +0100)]
s3-rpc_server: Added IPv6 support for epmapper.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Mon, 7 Mar 2011 12:12:47 +0000 (13:12 +0100)]
s3-rpc_server: Free unused memory.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Thu, 3 Mar 2011 14:31:04 +0000 (15:31 +0100)]
s3-winbind: Fixed the accept() for new_connection.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Thu, 3 Mar 2011 14:07:16 +0000 (15:07 +0100)]
s3-rpc_server: Fixed the accept() for ncalrpc_listener.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Thu, 3 Mar 2011 14:07:02 +0000 (15:07 +0100)]
s3-rpc_server: Fixed the accept() for tcpip_listener.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Thu, 3 Mar 2011 14:06:45 +0000 (15:06 +0100)]
s3-rpc_server: Fixed the accept() for named_pipe_listener.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Wed, 2 Mar 2011 14:28:25 +0000 (15:28 +0100)]
s3-librpc: Register NCALRPC pipes.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Wed, 2 Mar 2011 14:07:27 +0000 (15:07 +0100)]
s3-rpc_server: Create the ncalrpc endpoints.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Wed, 2 Mar 2011 09:56:46 +0000 (10:56 +0100)]
s3-rpc_server: Add server support for NCALRPC system user pipe.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Tue, 1 Mar 2011 18:10:02 +0000 (19:10 +0100)]
s3-rpc_server: Improved the dcerpc_ncacn_accept switch.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Fri, 25 Feb 2011 12:50:37 +0000 (13:50 +0100)]
s3-rpc_server: Remove unneeded ncacn wrappers.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Fri, 25 Feb 2011 13:26:29 +0000 (14:26 +0100)]
s3-rpc_server: Fixed ncalrpc connection accept.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Fri, 25 Feb 2011 11:06:19 +0000 (12:06 +0100)]
s3-rpc_server: Only allow epm insert and delete on NCALRPC.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Thu, 3 Mar 2011 13:20:26 +0000 (14:20 +0100)]
s3-rpc_server: Introduce transport in pipe_struct.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Thu, 24 Feb 2011 11:06:54 +0000 (12:06 +0100)]
s3-rpc_server: Start the Endpoint Mapper Dameon if enabled.
Endpoint Mapper is still disabled by default!
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Thu, 24 Feb 2011 09:24:16 +0000 (10:24 +0100)]
s3-rpc_server: Created an Endpoint Mapper Daemon.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Wed, 23 Feb 2011 14:39:33 +0000 (15:39 +0100)]
s3-librpc: Register endpoints using ncalrpc.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Wed, 2 Mar 2011 14:27:12 +0000 (15:27 +0100)]
selftest: Added ncalrpc dir to config.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Tue, 1 Mar 2011 10:49:20 +0000 (11:49 +0100)]
s3-rpc_client: Added DCERPC_AUTH_TYPE_NCALRPC bind.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Wed, 23 Feb 2011 14:38:14 +0000 (15:38 +0100)]
s3-rpc_server: Added prototype to setup a ncalrpc socket.
Signed-off-by: Günther Deschner <gd@samba.org>
Simo Sorce [Wed, 23 Feb 2011 01:40:54 +0000 (20:40 -0500)]
s3-epmap: add ncalrpc listener code
Signed-off-by: Günther Deschner <gd@samba.org>
Simo Sorce [Wed, 23 Feb 2011 01:40:24 +0000 (20:40 -0500)]
sr-epmap: Minor cleanups and fixes
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Tue, 22 Feb 2011 15:48:43 +0000 (16:48 +0100)]
s3-epmap: Return the correct ip address.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Tue, 22 Feb 2011 15:48:15 +0000 (16:48 +0100)]
s3-rpc_server: Added server address to pipes struct.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Tue, 22 Feb 2011 14:14:34 +0000 (15:14 +0100)]
s3-rpc_server: Set client and server connection info.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Tue, 22 Feb 2011 12:06:54 +0000 (13:06 +0100)]
s3-rpc_server: Added tcpip listener for each rpc service.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Tue, 22 Feb 2011 11:15:09 +0000 (12:15 +0100)]
s3-librpc: Free memory we don't need.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Tue, 22 Feb 2011 10:53:35 +0000 (11:53 +0100)]
s3-librpc: Added tcpip support for dcerpc_binding_vector_create.
Signed-off-by: Günther Deschner <gd@samba.org>
Günther Deschner [Mon, 7 Mar 2011 23:15:25 +0000 (00:15 +0100)]
s3-idmap: fix the build of idmap_tdb2.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue Mar 8 10:51:04 CET 2011 on sn-devel-104
Volker Lendecke [Mon, 7 Mar 2011 19:04:48 +0000 (20:04 +0100)]
s3: state->ev is not needed in winbindd_lookupsid
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Mon Mar 7 20:52:53 CET 2011 on sn-devel-104
Jeremy Allison [Mon, 7 Mar 2011 12:46:20 +0000 (04:46 -0800)]
Fix the examples/VFS build.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Mon Mar 7 15:11:25 CET 2011 on sn-devel-104
Gregor Beck [Mon, 7 Mar 2011 08:57:10 +0000 (09:57 +0100)]
s3-docs: manpage for "net idmap delete"
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Mon Mar 7 14:26:42 CET 2011 on sn-devel-104
Gregor Beck [Mon, 7 Mar 2011 08:56:48 +0000 (09:56 +0100)]
s3-docs: manpage for "smbcontrol xx idmap"
Jeremy Allison [Mon, 7 Mar 2011 11:53:11 +0000 (03:53 -0800)]
Fix examples/VFS to use correct prototypes for is_offline() and set_offline().
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Mon Mar 7 13:39:17 CET 2011 on sn-devel-104
Volker Lendecke [Sun, 6 Mar 2011 11:02:05 +0000 (12:02 +0100)]
s3: Remove close_fn from idmap_methods
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Mar 6 13:37:13 CET 2011 on sn-devel-104
Volker Lendecke [Sun, 6 Mar 2011 11:16:00 +0000 (12:16 +0100)]
s3-idmap-hash: Make "hashed_domains" properly talloced
Volker Lendecke [Sun, 6 Mar 2011 10:53:49 +0000 (11:53 +0100)]
s3: Replace idmap_ad_close by a destructor
Volker Lendecke [Sun, 6 Mar 2011 10:47:19 +0000 (11:47 +0100)]
s3-idmap-ad: Make ad_schema properly talloced
Volker Lendecke [Sat, 26 Feb 2011 12:55:41 +0000 (13:55 +0100)]
s3-idmap-tdb: private_data is a talloc child of dom
Volker Lendecke [Sat, 26 Feb 2011 12:53:12 +0000 (13:53 +0100)]
s3-idmap-ldap: private_data is a talloc child of dom
Volker Lendecke [Sat, 26 Feb 2011 12:49:37 +0000 (13:49 +0100)]
s3-idmap-rid: private_data is a talloc child of dom
Volker Lendecke [Sat, 26 Feb 2011 12:43:55 +0000 (13:43 +0100)]
s3: Remove an unnecessary if-statement
Volker Lendecke [Sat, 26 Feb 2011 11:59:53 +0000 (12:59 +0100)]
s3: Remove an obsolete comment
Volker Lendecke [Sat, 26 Feb 2011 11:55:34 +0000 (12:55 +0100)]
s3: Remove some unused code
Volker Lendecke [Sat, 26 Feb 2011 11:54:26 +0000 (12:54 +0100)]
s3: Remove unused args from nss_get_info_cached
Volker Lendecke [Sat, 26 Feb 2011 11:52:20 +0000 (12:52 +0100)]
s3: Remove unused args from nss_get_info
Volker Lendecke [Sat, 26 Feb 2011 11:50:46 +0000 (12:50 +0100)]
s3: Remove unused args from get_nss_info
Volker Lendecke [Sun, 6 Mar 2011 08:31:40 +0000 (09:31 +0100)]
s3: Move EXOP definitions to smbldap.h
This attempts to fix the build on Solaris
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Mar 6 10:45:16 CET 2011 on sn-devel-104
Volker Lendecke [Sat, 5 Mar 2011 16:37:53 +0000 (17:37 +0100)]
s3: Fix uninitialized variables
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat Mar 5 17:25:43 CET 2011 on sn-devel-104
Volker Lendecke [Fri, 4 Mar 2011 19:27:57 +0000 (20:27 +0100)]
Fix some nonempty blank lines
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat Mar 5 15:16:02 CET 2011 on sn-devel-104
Volker Lendecke [Fri, 4 Mar 2011 05:02:35 +0000 (06:02 +0100)]
wbinfo: Use wbcSidToStringBuf
Volker Lendecke [Fri, 4 Mar 2011 04:55:23 +0000 (05:55 +0100)]
wbinfo: Fix a debug message
Volker Lendecke [Fri, 4 Mar 2011 04:53:10 +0000 (05:53 +0100)]
s3-net: Use wbcSidToStringBuf
Volker Lendecke [Fri, 4 Mar 2011 04:49:20 +0000 (05:49 +0100)]
pam_winbind: Use wbcSidToStringBuf
Volker Lendecke [Fri, 4 Mar 2011 04:44:23 +0000 (05:44 +0100)]
libwbclient: Use wbcSidToStringBuf
Volker Lendecke [Fri, 4 Mar 2011 04:38:04 +0000 (05:38 +0100)]
libwbclient: Add wbcSidToStringBuf
Volker Lendecke [Thu, 3 Mar 2011 21:29:39 +0000 (22:29 +0100)]
nsswitch: wbcFreeMemory deals fine with NULL
Volker Lendecke [Sat, 5 Mar 2011 11:57:59 +0000 (12:57 +0100)]
s3: Fix a memory leak in check_sam_security_info3
Abartlet, this commit makes check_sam_security_info3 use talloc_tos() and also
cleans up the temporary talloc stackframe.
The old code created a temporary talloc context off "mem_ctx" but failed to
clean up the tmp_ctx in all but one return paths.
talloc_stackframe()/talloc_tos() is designed as a defense against exactly this
error: Even if we failed to free the frame when returning from the routine, it
would be cleaned up very soon, in our main event loop.
Please check this patch!
Thanks,
Volker
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat Mar 5 14:08:37 CET 2011 on sn-devel-104
Michael Adam [Fri, 4 Mar 2011 23:58:19 +0000 (00:58 +0100)]
s3:test: the registry roundtrip test passes now
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Sat Mar 5 02:19:33 CET 2011 on sn-devel-104
Michael Adam [Fri, 4 Mar 2011 23:55:27 +0000 (00:55 +0100)]
s3:test: mark vanished parameter "postscript" invalid in net registry roundtrip test
Michael Adam [Fri, 4 Mar 2011 23:54:28 +0000 (00:54 +0100)]
s3:test: in net registry roundtrip test, mark "lock dir" as invalid parameter
This is a synonym of lock directory which is already marked invalid.
Michael Adam [Fri, 4 Mar 2011 23:50:21 +0000 (00:50 +0100)]
s3:test: in net registry roundtrip test, exclude the files from exclude/logon
These files are not samba config files...
Michael Adam [Fri, 4 Mar 2011 22:53:44 +0000 (23:53 +0100)]
s3:registry: fix invalid write in iconvert_talloc()
For a non-preallocated dest-string and sourcestring of len < 2,
(one or both of the) final two two zero-bytes would be written
after the end of the allocated dest-string. The sourcelen did
not include the source string terminator. For longer strings,
this was not a problem because the dest-string would have been
reallocated in the convert-loop. This is fixed now by allocating
two extra bytes for the terminating 0-bytes that are needed anyways
in the initial allocation.
Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>
Michael Adam [Fri, 4 Mar 2011 22:17:02 +0000 (23:17 +0100)]
s3:test: correctly react to each failing step in the net registry roundtrip tests
Michael Adam [Fri, 4 Mar 2011 22:12:08 +0000 (23:12 +0100)]
s3:test: improve logging in the net registry roundtrip test steps
Matthias Dieter Wallnöfer [Fri, 4 Mar 2011 22:02:29 +0000 (23:02 +0100)]
s4:operational LDB module - fix attribute names to be right up/down-cased
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Fri Mar 4 23:56:07 CET 2011 on sn-devel-104
Matthias Dieter Wallnöfer [Fri, 4 Mar 2011 21:49:46 +0000 (22:49 +0100)]
s4:ldap.py - rootdse tests should search for the rootDSE not the default DN
Reviewed by: Tridge
Matthias Dieter Wallnöfer [Fri, 4 Mar 2011 21:49:08 +0000 (22:49 +0100)]
s4:ldap.py - add a test in order to show the operational module fixed
Reviewed by: Tridge
Matthias Dieter Wallnöfer [Fri, 4 Mar 2011 21:39:42 +0000 (22:39 +0100)]
s4:operational LDB module - fix display of some constructed attributes
"structuralObjectClass", "createTimestamp" and "modifyTimestamp" weren't
displayed anymore.
Reviewed by: Tridge
Matthias Dieter Wallnöfer [Fri, 4 Mar 2011 21:30:15 +0000 (22:30 +0100)]
s4:operational LDB module - add "groupToken" as unsigned int (uint32_t)
Reviewed by: Tridge
Matthias Dieter Wallnöfer [Fri, 4 Mar 2011 21:14:11 +0000 (22:14 +0100)]
s4:operational LDB module - readd "structuralObjectClass" -> "objectClass" mapping
This has been removed accidentally by commit
a093e10896a4768dba0cd793a04b7d5d1366fee2.
Reviewed by: Tridge
Matthias Dieter Wallnöfer [Fri, 4 Mar 2011 19:51:07 +0000 (20:51 +0100)]
ldb:ldb_msg.c - use LDB result constants for checking return values
Reviewed by: Tridge
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Fri Mar 4 22:51:57 CET 2011 on sn-devel-104
Matthias Dieter Wallnöfer [Fri, 4 Mar 2011 08:27:51 +0000 (09:27 +0100)]
s4:ldap.py - other important RDN check testcases
Reviewed by: Tridge
Matthias Dieter Wallnöfer [Fri, 4 Mar 2011 08:26:40 +0000 (09:26 +0100)]
s4:ldap.py - remove a debug output
This has only been needed for developing this testcase and has been
forgotten to be removed afterwards.
Reviewed by: Tridge
Matthias Dieter Wallnöfer [Fri, 4 Mar 2011 10:11:08 +0000 (11:11 +0100)]
ldb:rdn_name LDB module - more RDN constraint checks (from AD)
Reviewed by: Tridge
Matthias Dieter Wallnöfer [Fri, 4 Mar 2011 09:49:47 +0000 (10:49 +0100)]
s4/ldb - remove now superflous "ldb_dn_validate" checks
If we immediately afterwards perform an LDB base operation then we don't
need an explicit "ldb_dn_validate" check anymore (only OOM makes sense).
Reviewed by: Tridge
Matthias Dieter Wallnöfer [Fri, 4 Mar 2011 09:44:22 +0000 (10:44 +0100)]
s4:dsdb - we don't need to check if a DN != NULL if we call "ldb_dn_validate"
"ldb_dn_validate" is NULL-safe and does the check implicitly.
Reviewed by: Tridge
Matthias Dieter Wallnöfer [Fri, 4 Mar 2011 09:15:59 +0000 (10:15 +0100)]
Revert "s4:objectclass LDB module - if we cannot find DN's parent then the DN itself is invalid"
This is not needed anymore with the new DN checking.
This reverts commit
5896b7299331aedd065397d2078c62d85bcf68f6.
Reviewed by: Tridge
Matthias Dieter Wallnöfer [Fri, 4 Mar 2011 09:14:14 +0000 (10:14 +0100)]
ldb:ldb_request - handle here the DN checks
This is a much better solution than we had before - so all important DN
checks are enforced for each type of LDB database (and not limited to DSDB).
Many "ldb_dn_validate" checks will now become obsolete.
Reviewed by: Tridge
Matthias Dieter Wallnöfer [Fri, 4 Mar 2011 08:33:52 +0000 (09:33 +0100)]
s4:objectclass LDB module - fix a comment
Reviewed by: Tridge
Matthias Dieter Wallnöfer [Fri, 4 Mar 2011 09:40:27 +0000 (10:40 +0100)]
s4:libnet/libnet_site.c - make use of LDB return constants
Reviewed by: Tridge
Christian Ambach [Fri, 4 Mar 2011 17:45:20 +0000 (18:45 +0100)]
s4:waf-build fix disable-shared build for smbtorture
building smbtorture4 with configure --disable-shared failed
with an error that ldb.h could not be found
Signed-off-by: Matthias Dieter Wallnöfer <mdw@samba.org>
Reviewed by: Tridge
Stefan Metzmacher [Fri, 4 Mar 2011 15:57:28 +0000 (16:57 +0100)]
s4:selftest: test using the machine account of the rodc against itself
This should test the non proxy rodc kdc path.
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Fri Mar 4 22:06:10 CET 2011 on sn-devel-104
Stefan Metzmacher [Fri, 4 Mar 2011 09:05:51 +0000 (10:05 +0100)]
selftest/target/Samba4: regenerate the krb5.conf after the rodc join
The RODC should be used as KDC, which will forward requests to the RWDC
if required.
metze
Stefan Metzmacher [Fri, 4 Mar 2011 09:05:13 +0000 (10:05 +0100)]
selftest/target/Samba4: splitout a mk_krb5_conf() function
metze
Stefan Metzmacher [Wed, 9 Feb 2011 11:17:23 +0000 (12:17 +0100)]
s4:kdc: split the kdc_tcp_proxy() logic from the main kdc logic
By having kdc_tcp_proxy_send/recv(), which just asks any writeable
dc for a reponse blob, we simplify the interaction between
client-local and local-writeable sockets.
This allows us to make kdc_socket, kdc_process_fn_t, kdc_tcp_call and kdc_tcp_socket
private to kdc.c again.
metze
Stefan Metzmacher [Wed, 9 Feb 2011 08:07:47 +0000 (09:07 +0100)]
s4:kdc: split the kdc_udp_proxy() logic from the main kdc logic
By having kdc_udp_proxy_send/recv(), which just asks any writeable
dc for a reponse blob, we simplify the interaction between
client-local and local-writeable sockets.
This allows us to make kdc_udp_call and kdc_udp_socket private to
kdc.c again.
metze
Stefan Metzmacher [Wed, 9 Feb 2011 08:06:20 +0000 (09:06 +0100)]
s4:kdc: add a kdc_proxy_unavailable_error() helper function
metze
Stefan Metzmacher [Fri, 4 Mar 2011 15:12:29 +0000 (16:12 +0100)]
s4:kdc: fix calculation of the rodc kvno
Bit shifting is non-trivial in C:-)
This
int32_t a = 0x12340000;
uint32_t b = (a >> 16);
results in 0x00001234, but this
int32_t a = 0xEDCB0000;
uint32_t b = (a >> 16);
results in 0xFFFFEDCB, while we expected 0x0000EDCB.
metze