nivanova/samba-autobuild/.git
9 years agos3-registry: avoid using registry_value union.
Günther Deschner [Tue, 29 Jun 2010 14:13:15 +0000 (16:13 +0200)]
s3-registry: avoid using registry_value union.

Just pull and push data as is.

Guenther

9 years agos4-ldb: fixed error handling in openldap backend
Andrew Tridgell [Fri, 2 Jul 2010 01:39:28 +0000 (11:39 +1000)]
s4-ldb: fixed error handling in openldap backend

fixed several bugs in error handling. the ldb context was used without
being initialised in the error paths, and several error paths did not
set an ldb error string.

9 years agos4-ldb: fixed the parsing of references in the openldap backend
Andrew Tridgell [Fri, 2 Jul 2010 01:37:50 +0000 (11:37 +1000)]
s4-ldb: fixed the parsing of references in the openldap backend

We need to use ldap_parse_reference() not ldap_parse_result()

9 years agos4-dsdb: fixed use after free of sasl mechanisms opaque
Andrew Tridgell [Wed, 30 Jun 2010 03:49:05 +0000 (13:49 +1000)]
s4-dsdb: fixed use after free of sasl mechanisms opaque

the supportedSASLMechanisms opaque must live for at least as long as
the ldb, or we can crash when the first connection is torn down

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

9 years agos4-dsdb: fixed spelling of supportedSASLMechanisms
Andrew Tridgell [Wed, 30 Jun 2010 03:47:29 +0000 (13:47 +1000)]
s4-dsdb: fixed spelling of supportedSASLMechanisms

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

9 years agos4:dsdb Ensure we free old schema copies
Andrew Bartlett [Wed, 30 Jun 2010 13:25:32 +0000 (23:25 +1000)]
s4:dsdb Ensure we free old schema copies

It was reported by aatanasov that we kept around one whole schema per
modification made.  This does not fix that, but I hope moves us closer
to a fix

The most important part of the fix is that:

- if (schema_out != schema_in) {
- talloc_unlink(schema_in, ldb);
- }

was the wrong way around.  This is now handled in the schema_set calls.

Andrew Bartlett

9 years agos4/dsdb: Assert DSDB_FLAG_*_MODULE is always passed in function call
Kamen Mazdrashki [Thu, 1 Jul 2010 20:47:02 +0000 (23:47 +0300)]
s4/dsdb: Assert DSDB_FLAG_*_MODULE is always passed in function call

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
9 years agos4-source4/dsdb/samdb/ldb_modules/util.c Use DSDB_FLAG_NEXT_MODULE flag
Kamen Mazdrashki [Mon, 28 Jun 2010 18:29:05 +0000 (21:29 +0300)]
s4-source4/dsdb/samdb/ldb_modules/util.c Use DSDB_FLAG_NEXT_MODULE flag

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
9 years agos4-source4/dsdb/samdb/ldb_modules/subtree_delete.c: Use DSDB_FLAG_NEXT_MODULE flag
Kamen Mazdrashki [Mon, 28 Jun 2010 18:28:46 +0000 (21:28 +0300)]
s4-source4/dsdb/samdb/ldb_modules/subtree_delete.c: Use DSDB_FLAG_NEXT_MODULE flag

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
9 years agos4-source4/dsdb/samdb/ldb_modules/schema_load.c: Use DSDB_FLAG_NEXT_MODULE flag
Kamen Mazdrashki [Mon, 28 Jun 2010 18:28:30 +0000 (21:28 +0300)]
s4-source4/dsdb/samdb/ldb_modules/schema_load.c: Use DSDB_FLAG_NEXT_MODULE flag

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
9 years agos4-source4/dsdb/samdb/ldb_modules/samldb.c: Use DSDB_FLAG_NEXT_MODULE flag
Kamen Mazdrashki [Mon, 28 Jun 2010 18:28:10 +0000 (21:28 +0300)]
s4-source4/dsdb/samdb/ldb_modules/samldb.c: Use DSDB_FLAG_NEXT_MODULE flag

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
9 years agos4-source4/dsdb/samdb/ldb_modules/samba3sid.c: Use DSDB_FLAG_NEXT_MODULE flag
Kamen Mazdrashki [Mon, 28 Jun 2010 18:27:51 +0000 (21:27 +0300)]
s4-source4/dsdb/samdb/ldb_modules/samba3sid.c: Use DSDB_FLAG_NEXT_MODULE flag

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
9 years agos4-source4/dsdb/samdb/ldb_modules/rootdse.c: Use DSDB_FLAG_NEXT_MODULE flag
Kamen Mazdrashki [Mon, 28 Jun 2010 18:27:32 +0000 (21:27 +0300)]
s4-source4/dsdb/samdb/ldb_modules/rootdse.c: Use DSDB_FLAG_NEXT_MODULE flag

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
9 years agos4-source4/dsdb/samdb/ldb_modules/ridalloc.c: Use DSDB_FLAG_NEXT_MODULE flag
Kamen Mazdrashki [Mon, 28 Jun 2010 18:26:53 +0000 (21:26 +0300)]
s4-source4/dsdb/samdb/ldb_modules/ridalloc.c: Use DSDB_FLAG_NEXT_MODULE flag

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
9 years agos4-source4/dsdb/samdb/ldb_modules/repl_meta_data.c: Use DSDB_FLAG_NEXT_MODULE flag
Kamen Mazdrashki [Mon, 28 Jun 2010 18:26:07 +0000 (21:26 +0300)]
s4-source4/dsdb/samdb/ldb_modules/repl_meta_data.c: Use DSDB_FLAG_NEXT_MODULE flag

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
9 years agos4-dsdb/samdb/ldb_modules/linked_attributes.c: make use of DSDB_FLAG_NEXT_MODULE...
Kamen Mazdrashki [Mon, 28 Jun 2010 18:25:28 +0000 (21:25 +0300)]
s4-dsdb/samdb/ldb_modules/linked_attributes.c: make use of DSDB_FLAG_NEXT_MODULE flag

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
9 years agos4/dsdb: Add DSDB_FLAG_NEXT_MODULE flag
Kamen Mazdrashki [Mon, 28 Jun 2010 18:07:51 +0000 (21:07 +0300)]
s4/dsdb: Add DSDB_FLAG_NEXT_MODULE flag

Although it is not currently used in implementation,
my intention is for callers to clearly state what
action they want to execute.

Currently when a caller wants to pass the call to the next
module in the chain, this flag is either omitted or 0 is used
(which is somewhat hacky, isn't it)

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
9 years agos3:auth Fix switch statement referencing a uninitialized variable
Simo Sorce [Thu, 1 Jul 2010 21:47:46 +0000 (17:47 -0400)]
s3:auth Fix switch statement referencing a uninitialized variable

Looking at the original commit (9a747d500fad699038ecf75615c680a9fd9e4cc7)
this seem the right solution.

Andrew please check.

9 years agos3-nss_info: only include nss_info.h where needed.
Günther Deschner [Wed, 30 Jun 2010 22:44:15 +0000 (00:44 +0200)]
s3-nss_info: only include nss_info.h where needed.

Guenther

9 years agos3-libads: move ldap posix schema defines to their own header file.
Günther Deschner [Wed, 30 Jun 2010 21:48:34 +0000 (23:48 +0200)]
s3-libads: move ldap posix schema defines to their own header file.

Guenther

9 years agos3-libads: move spnego defines to their appropriate header file.
Günther Deschner [Wed, 30 Jun 2010 21:47:03 +0000 (23:47 +0200)]
s3-libads: move spnego defines to their appropriate header file.

Guenther

9 years agos3-libads: only include libds flags where needed.
Günther Deschner [Wed, 30 Jun 2010 21:38:57 +0000 (23:38 +0200)]
s3-libads: only include libds flags where needed.

Guenther

9 years agos3-libads: move keytab macros out of ads.h.
Günther Deschner [Wed, 30 Jun 2010 21:20:22 +0000 (23:20 +0200)]
s3-libads: move keytab macros out of ads.h.

Guenther

9 years agos3-libads: move ads_dns out of main includes.
Günther Deschner [Wed, 30 Jun 2010 20:36:40 +0000 (22:36 +0200)]
s3-libads: move ads_dns out of main includes.

Guenther

9 years agos3-libads: move ads_status to a separate header file.
Günther Deschner [Mon, 31 May 2010 10:51:58 +0000 (12:51 +0200)]
s3-libads: move ads_status to a separate header file.

Guenther

9 years agos3-libads: move ads_protos.h to ads_ldap_protos.h.
Günther Deschner [Mon, 31 May 2010 10:51:29 +0000 (12:51 +0200)]
s3-libads: move ads_protos.h to ads_ldap_protos.h.

Guenther

9 years agos3-waf: fix the build after smbd/change_trust_pw.c removal.
Günther Deschner [Thu, 1 Jul 2010 21:15:13 +0000 (23:15 +0200)]
s3-waf: fix the build after smbd/change_trust_pw.c removal.

Guenther

9 years agotdb: fix the build on mac os x 10.6.4.
Günther Deschner [Thu, 3 Jun 2010 17:05:43 +0000 (19:05 +0200)]
tdb: fix the build on mac os x 10.6.4.

Guenther

9 years agos3-libnet_join: small IDL enhancement.
Günther Deschner [Wed, 30 Jun 2010 23:19:39 +0000 (01:19 +0200)]
s3-libnet_join: small IDL enhancement.

Guenther

9 years agos3-libads: use shared well known guids.
Günther Deschner [Wed, 30 Jun 2010 21:09:05 +0000 (23:09 +0200)]
s3-libads: use shared well known guids.

Guenther

9 years agos3-libads: move KRB5_ENV_CCNAME to separate header krb5_env.h.
Günther Deschner [Wed, 30 Jun 2010 20:32:00 +0000 (22:32 +0200)]
s3-libads: move KRB5_ENV_CCNAME to separate header krb5_env.h.

Guenther

9 years agos4:dsdb/tests/python/passwords.py - add the right result codes for user password...
Matthias Dieter Wallnöfer [Thu, 1 Jul 2010 15:23:01 +0000 (17:23 +0200)]
s4:dsdb/tests/python/passwords.py - add the right result codes for user password changes

They will be enabled once the ACL modules supports it. It was my fault to not
import them earlier.

9 years agos4:lib/registry/ldb.c - free some "msg" objects earlier through explicit "talloc_free"s
Matthias Dieter Wallnöfer [Thu, 1 Jul 2010 14:35:12 +0000 (16:35 +0200)]
s4:lib/registry/ldb.c - free some "msg" objects earlier through explicit "talloc_free"s

No other functional change

9 years agos4:registry - move some common constraint checks to the "local" backend
Matthias Dieter Wallnöfer [Tue, 29 Jun 2010 14:10:32 +0000 (16:10 +0200)]
s4:registry - move some common constraint checks to the "local" backend

They should also be enforced when we don't use "ldb".

9 years agos4:lib/registry/tests/registry.c - test recursive key generation
Matthias Dieter Wallnöfer [Tue, 29 Jun 2010 16:27:49 +0000 (18:27 +0200)]
s4:lib/registry/tests/registry.c - test recursive key generation

9 years agos4:registry - on key add operations we have to handle with paths not always only...
Matthias Dieter Wallnöfer [Tue, 29 Jun 2010 16:08:47 +0000 (18:08 +0200)]
s4:registry - on key add operations we have to handle with paths not always only a name

Recursive key generations are allowed.

9 years agos4:lib/registry/local.c - support recursive key generation
Matthias Dieter Wallnöfer [Tue, 29 Jun 2010 13:45:37 +0000 (15:45 +0200)]
s4:lib/registry/local.c - support recursive key generation

Code taken from "local_open_key".

9 years agos4:lib/registry/ldb.c - refactor "reg_path_to_ldb"
Matthias Dieter Wallnöfer [Thu, 24 Jun 2010 19:12:19 +0000 (21:12 +0200)]
s4:lib/registry/ldb.c - refactor "reg_path_to_ldb"

This makes it easier to understand and would also support splitting in more
DN components.

9 years agos4:lib/registry/ldb.c - use "ldb_path" rather than "ldap_path" as LDB key varibale...
Matthias Dieter Wallnöfer [Tue, 29 Jun 2010 15:37:45 +0000 (17:37 +0200)]
s4:lib/registry/ldb.c - use "ldb_path" rather than "ldap_path" as LDB key varibale identifiers

9 years agos4:lib/registry/ldb.c - "ldb_add_key" - fix talloc handling
Matthias Dieter Wallnöfer [Tue, 29 Jun 2010 13:52:19 +0000 (15:52 +0200)]
s4:lib/registry/ldb.c - "ldb_add_key" - fix talloc handling

- free "msg" when possible
- prevent "talloc_strdup"s where not necessary

9 years agos3-printing: Fix Bug #7541, %D in "printer admin" causing smbd crash.
Günther Deschner [Thu, 1 Jul 2010 11:46:55 +0000 (13:46 +0200)]
s3-printing: Fix Bug #7541, %D in "printer admin" causing smbd crash.

Guenther

9 years agos3-registry: fix malloc/talloc mismatch upon free in reg_enumvalue().
Günther Deschner [Wed, 30 Jun 2010 23:22:11 +0000 (01:22 +0200)]
s3-registry: fix malloc/talloc mismatch upon free in reg_enumvalue().

Guenther

9 years agos4-smbtorture: in extended setvalue winreg test, reduce max random buffer length...
Günther Deschner [Wed, 30 Jun 2010 15:13:42 +0000 (17:13 +0200)]
s4-smbtorture: in extended setvalue winreg test, reduce max random buffer length to 16 bytes.

Guenther

9 years agos3-docs: try to make "default case" explanation a little clearer.
Günther Deschner [Wed, 30 Jun 2010 11:25:28 +0000 (13:25 +0200)]
s3-docs: try to make "default case" explanation a little clearer.

Guenther

9 years agos3-libsmb: move change_trust_account_password out of smbd into libsmb.
Günther Deschner [Wed, 30 Jun 2010 10:10:55 +0000 (12:10 +0200)]
s3-libsmb: move change_trust_account_password out of smbd into libsmb.

Guenther

9 years agos4-smbtorture: enable QueryMultipleValues{2} torture tests against samba3.
Günther Deschner [Wed, 30 Jun 2010 00:07:15 +0000 (02:07 +0200)]
s4-smbtorture: enable QueryMultipleValues{2} torture tests against samba3.

Guenther

9 years agos3-winreg: implement _winreg_QueryMultipleValues().
Günther Deschner [Wed, 30 Jun 2010 14:31:46 +0000 (16:31 +0200)]
s3-winreg: implement _winreg_QueryMultipleValues().

Guenther

9 years agos3-winreg: implement _winreg_QueryMultipleValues2().
Günther Deschner [Wed, 30 Jun 2010 00:03:27 +0000 (02:03 +0200)]
s3-winreg: implement _winreg_QueryMultipleValues2().

Guenther

9 years agos3-registry: add reg_querymultiplevalues() to reg_api.
Günther Deschner [Wed, 30 Jun 2010 00:02:43 +0000 (02:02 +0200)]
s3-registry: add reg_querymultiplevalues() to reg_api.

Guenther

9 years agos4-smbtorture: add some more multiple_values_tests to RPC-WINREG.
Günther Deschner [Wed, 30 Jun 2010 15:13:14 +0000 (17:13 +0200)]
s4-smbtorture: add some more multiple_values_tests to RPC-WINREG.

Guenther

9 years agos4:dsdb: move dsdb python tests from lib/ldb/ to dsdb/
Stefan Metzmacher [Wed, 30 Jun 2010 09:09:10 +0000 (11:09 +0200)]
s4:dsdb: move dsdb python tests from lib/ldb/ to dsdb/

metze

9 years agos4:ldb/python: make it possible to run tests standalone
Stefan Metzmacher [Wed, 30 Jun 2010 08:57:37 +0000 (10:57 +0200)]
s4:ldb/python: make it possible to run tests standalone

metze

9 years agolibcli: Fixed a build warning for a missing prototype.
Andreas Schneider [Wed, 30 Jun 2010 08:19:07 +0000 (10:19 +0200)]
libcli: Fixed a build warning for a missing prototype.

9 years agos4:auth/session.c - suppress a warning when freeing "group_string"
Matthias Dieter Wallnöfer [Wed, 30 Jun 2010 07:37:08 +0000 (09:37 +0200)]
s4:auth/session.c - suppress a warning when freeing "group_string"

9 years agos4:schema/schema_set.c - free LDB message diffs
Anatoliy Atanasov [Thu, 24 Jun 2010 17:48:07 +0000 (20:48 +0300)]
s4:schema/schema_set.c - free LDB message diffs

Especially the "free"s after "ldb_msg_diff" are very important since the diff
message is allocated on the long-living LDB context.

Signed-off-by: Matthias Dieter Wallnöfer <mdw@samba.org>
9 years agos4:auth/session.c - free "group_string" when not needed
Anatoliy Atanasov [Thu, 24 Jun 2010 17:48:07 +0000 (20:48 +0300)]
s4:auth/session.c - free "group_string" when not needed

Signed-off-by: Matthias Dieter Wallnöfer <mdw@samba.org>
9 years agos4:dsdb Fix possible schema segfaults for DRS-replication based schema
Andrew Bartlett [Wed, 30 Jun 2010 00:20:11 +0000 (10:20 +1000)]
s4:dsdb Fix possible schema segfaults for DRS-replication based schema

The problem here is that if the schema has been modified on the source
domain, there may be attributes that appear over DRS with 0 values (to
indicate that any existing values on the target should be deleted).
This would confuse the previous version of this macro.

Andrew Bartlett

9 years agos4-smbtorture: remove duplicate torture_assert_sid_equal macro.
Günther Deschner [Tue, 29 Jun 2010 21:35:45 +0000 (23:35 +0200)]
s4-smbtorture: remove duplicate torture_assert_sid_equal macro.

Guenther

9 years agos4-smbtorture: fix incorrect IDL for QueryMultipleValue (aka RVALENT).
Günther Deschner [Tue, 29 Jun 2010 21:10:47 +0000 (23:10 +0200)]
s4-smbtorture: fix incorrect IDL for QueryMultipleValue (aka RVALENT).

Found by torture test.

Guenther

9 years agos4-smbtorture: add more sophisticated tests for winreg_QueryMultipleValues{2}.
Günther Deschner [Tue, 29 Jun 2010 19:53:00 +0000 (21:53 +0200)]
s4-smbtorture: add more sophisticated tests for winreg_QueryMultipleValues{2}.

Guenther

9 years agos4:ntvfs/ipc/vfs_ipc.c - remove unused code
Matthias Dieter Wallnöfer [Tue, 29 Jun 2010 20:30:05 +0000 (22:30 +0200)]
s4:ntvfs/ipc/vfs_ipc.c - remove unused code

Spotted by the Solaris 10 compiler

9 years agos4:ntvfs/ipc/vfs_ipc.c - add casts to suppress warnings on Solaris 10
Matthias Dieter Wallnöfer [Tue, 29 Jun 2010 20:33:32 +0000 (22:33 +0200)]
s4:ntvfs/ipc/vfs_ipc.c - add casts to suppress warnings on Solaris 10

9 years agos4:ntp_signd/ntp_signd.c - add casts to suppress warnings on Solaris 10
Matthias Dieter Wallnöfer [Tue, 29 Jun 2010 20:33:32 +0000 (22:33 +0200)]
s4:ntp_signd/ntp_signd.c - add casts to suppress warnings on Solaris 10

9 years agos4:rpc_server/browser.c - remove unused code
Matthias Dieter Wallnöfer [Tue, 29 Jun 2010 20:30:05 +0000 (22:30 +0200)]
s4:rpc_server/browser.c - remove unused code

Spotted by the Solaris 10 compiler

9 years agos4:smb_server/smb2/find.c - remove unused code
Matthias Dieter Wallnöfer [Tue, 29 Jun 2010 20:30:05 +0000 (22:30 +0200)]
s4:smb_server/smb2/find.c - remove unused code

Spotted by the Solaris 10 compiler

9 years agos4:smb_server/blob.c - remove unused code
Matthias Dieter Wallnöfer [Tue, 29 Jun 2010 20:30:05 +0000 (22:30 +0200)]
s4:smb_server/blob.c - remove unused code

Spotted by the Solaris 10 compiler

9 years agos4:dsdb/new_partition.c - remove the "ldb_next_request" call which we find also below...
Matthias Dieter Wallnöfer [Tue, 29 Jun 2010 20:23:15 +0000 (22:23 +0200)]
s4:dsdb/new_partition.c - remove the "ldb_next_request" call which we find also below the "if" block

9 years agoldb:ldb_map_outbound.c - "ldb_parse_tree_collect_attrs" - remove unneeded return...
Matthias Dieter Wallnöfer [Tue, 29 Jun 2010 20:21:22 +0000 (22:21 +0200)]
ldb:ldb_map_outbound.c - "ldb_parse_tree_collect_attrs" - remove unneeded return value

9 years agoldb:ldb_modules.c - "ldb_dso_load_symbol" - remove unneeded caste before "dlsym"
Matthias Dieter Wallnöfer [Tue, 29 Jun 2010 20:16:15 +0000 (22:16 +0200)]
ldb:ldb_modules.c - "ldb_dso_load_symbol" - remove unneeded caste before "dlsym"

9 years agos4:ldb - "ldb_dn_update_components" - fix free of invalid DN parts
Matthias Dieter Wallnöfer [Tue, 29 Jun 2010 20:10:14 +0000 (22:10 +0200)]
s4:ldb - "ldb_dn_update_components" - fix free of invalid DN parts

Use "LDB_FREE" for such free operations and in addition wipe also the casefolded
DN out.

9 years agoldb:ldb_dn.c - "ldb_dn_set_extended_component" - free the linearized string when...
Matthias Dieter Wallnöfer [Tue, 29 Jun 2010 20:07:51 +0000 (22:07 +0200)]
ldb:ldb_dn.c - "ldb_dn_set_extended_component" - free the linearized string when the components change

9 years agos4:ldb_dn.c - make the code parts which free extended components consistent
Matthias Dieter Wallnöfer [Tue, 29 Jun 2010 20:04:24 +0000 (22:04 +0200)]
s4:ldb_dn.c - make the code parts which free extended components consistent

Cosmetic

9 years agoldb:ldb_dn - "ldb_dn_explode" - move the "dn->comp_num" initalisation upwards and...
Matthias Dieter Wallnöfer [Tue, 29 Jun 2010 19:59:37 +0000 (21:59 +0200)]
ldb:ldb_dn - "ldb_dn_explode" - move the "dn->comp_num" initalisation upwards and use "LDB_FREE" for freeing "dn->components"

Mostly cosmetic - no behaviour change

9 years agos4-smbtorture: remove some pointless mem_equal tests in LOCAL-NDR-WINREG testsuite.
Günther Deschner [Tue, 29 Jun 2010 17:57:06 +0000 (19:57 +0200)]
s4-smbtorture: remove some pointless mem_equal tests in LOCAL-NDR-WINREG testsuite.

Guenther

9 years agos4-smbtorture: handle NT_STATUS_NOT_IMPLEMENTED in GetForestTrustInformation test.
Günther Deschner [Tue, 29 Jun 2010 15:19:28 +0000 (17:19 +0200)]
s4-smbtorture: handle NT_STATUS_NOT_IMPLEMENTED in GetForestTrustInformation test.

When skipping over it, we can at least verify the credential chain.

Guenther

9 years agos4-smbtorture: use TEST_MACHINE_NAME in test_netr_GetForestTrustInformation().
Günther Deschner [Tue, 29 Jun 2010 15:16:25 +0000 (17:16 +0200)]
s4-smbtorture: use TEST_MACHINE_NAME in test_netr_GetForestTrustInformation().

Guenther

9 years agos4-smbtorture: add netr_GetForestTrustInformation test to RPC-NETLOGON.
Günther Deschner [Tue, 29 Jun 2010 15:13:01 +0000 (17:13 +0200)]
s4-smbtorture: add netr_GetForestTrustInformation test to RPC-NETLOGON.

Guenther

9 years agos3-utils: remove rpccheck.
Günther Deschner [Tue, 29 Jun 2010 12:54:43 +0000 (14:54 +0200)]
s3-utils: remove rpccheck.

Impossible to get this to compile after the conversion to pidl.

Guenther

9 years agoRevert "s4/dsdb: Fixed partition_search() not to pass special DN's to LDAP backend."
Matthias Dieter Wallnöfer [Tue, 29 Jun 2010 12:48:25 +0000 (14:48 +0200)]
Revert "s4/dsdb: Fixed partition_search() not to pass special DN's to LDAP backend."

This reverts commit ed4c107bc1eac8531fdd8d09f7698efcbc7ecb14.

See post "Endi's Bug 7530 patches (LDAP backend)" on samba-technical.

9 years agoRevert "s4/auth: Fixed authsam_expand_nested_groups() to find entry SID if not availa...
Matthias Dieter Wallnöfer [Tue, 29 Jun 2010 12:52:43 +0000 (14:52 +0200)]
Revert "s4/auth: Fixed authsam_expand_nested_groups() to find entry SID if not available in the DN."

This reverts commit fa9557fee3ca546878d99b77f1ff37f724c37024.

See post "Endi's Bug 7530 patches (LDAP backend)" on samba-technical.

9 years agos4-smbtorture: add NDR torture test for winreg_QueryMultipleValues2.
Günther Deschner [Tue, 29 Jun 2010 10:26:24 +0000 (12:26 +0200)]
s4-smbtorture: add NDR torture test for winreg_QueryMultipleValues2.

Guenther

9 years agos4-smbtorture: add RPC torture test for winreg_QueryMultipleValues2.
Günther Deschner [Tue, 29 Jun 2010 10:14:02 +0000 (12:14 +0200)]
s4-smbtorture: add RPC torture test for winreg_QueryMultipleValues2.

Guenther

9 years agowinreg: fix winreg_QueryMultipleValues2 IDL.
Günther Deschner [Tue, 29 Jun 2010 10:04:56 +0000 (12:04 +0200)]
winreg: fix winreg_QueryMultipleValues2 IDL.

Guenther

9 years agowinreg: fix winreg_QueryMultipleValues() IDL and torture tests.
Günther Deschner [Tue, 29 Jun 2010 09:40:24 +0000 (11:40 +0200)]
winreg: fix winreg_QueryMultipleValues() IDL and torture tests.

Guenther

9 years agos3-client: Make sure we only write to an opened file.
Andreas Schneider [Tue, 29 Jun 2010 08:42:36 +0000 (10:42 +0200)]
s3-client: Make sure we only write to an opened file.

Found by clang-analyzer.

9 years agos3-winbind: Make sure we crash if domain is really not found.
Andreas Schneider [Tue, 29 Jun 2010 08:34:17 +0000 (10:34 +0200)]
s3-winbind: Make sure we crash if domain is really not found.

Found by clang-analyzer.

9 years agos3-net: Make sure we don't call free on garbage.
Andreas Schneider [Tue, 29 Jun 2010 08:07:22 +0000 (10:07 +0200)]
s3-net: Make sure we don't call free on garbage.

Found by clang-analyzer.

9 years agos3-net: Use talloc_asprintf and return if file is in wrong format.
Andreas Schneider [Mon, 28 Jun 2010 11:20:18 +0000 (13:20 +0200)]
s3-net: Use talloc_asprintf and return if file is in wrong format.

Found by clang-analyzer.

9 years agos3-librpc: Fixed GUID_from_data_blob() with length of 32.
Andreas Schneider [Mon, 28 Jun 2010 19:00:30 +0000 (21:00 +0200)]
s3-librpc: Fixed GUID_from_data_blob() with length of 32.

If we hit the case that the blob length is 32. The code goes to the end
of the function and generates a GUID with garbage.
So try to convert the blob to the GUID and return.

9 years agoFixed incorrect use of cn instead of lDAPDisplayName
Nadezhda Ivanova [Tue, 29 Jun 2010 08:46:22 +0000 (11:46 +0300)]
Fixed incorrect use of cn instead of lDAPDisplayName

9 years agos4:secrets Ensure secrets.ldb uses the same hooks as the rest of Samba
Andrew Bartlett [Wed, 23 Jun 2010 11:15:43 +0000 (21:15 +1000)]
s4:secrets Ensure secrets.ldb uses the same hooks as the rest of Samba

This ensures that, for example, the utf8 functions are the same,
the GUID handler is the same and the NOSYNC flag is applied.

Andrew Bartlett

9 years agos4:selftest Split out PKINIT tests from test_kinit.sh and test enc types
Andrew Bartlett [Wed, 23 Jun 2010 23:42:40 +0000 (09:42 +1000)]
s4:selftest Split out PKINIT tests from test_kinit.sh and test enc types

This allows us to run the PKINIT tests only against the main DC (for
which the certificates were generated), while testing the available
encryption types in each functional level.

In particular, we need to assert that AES encryption is available in
the 2008 functional level.

Andrew Bartlett

9 years agos4:kdc Rework the 'allowed enc types' calculation
Andrew Bartlett [Wed, 23 Jun 2010 23:40:16 +0000 (09:40 +1000)]
s4:kdc Rework the 'allowed enc types' calculation

This changes the calculation to apply the allowed enc types to all
uses of the key (no point allowing a weak kinit to a key the server
wanted strongly protected).  It also ensures that all the non-DES keys
are available on the krbtgt in particular, even as it does not have a
msds-SupportedEncryptionTypes attributes.

Andrew Bartlett

9 years agos4:auth Query LDB for msds-SupportedEncryptionTypes for the KDC
Andrew Bartlett [Thu, 24 Jun 2010 00:03:29 +0000 (10:03 +1000)]
s4:auth Query LDB for msds-SupportedEncryptionTypes for the KDC

The KDC needs this to determine what encryption types an entry supports

Andrew Bartlett

9 years agos4:kerberos Add functions to convert msDS-SupportedEncryptionTypes
Andrew Bartlett [Mon, 28 Jun 2010 13:19:16 +0000 (23:19 +1000)]
s4:kerberos Add functions to convert msDS-SupportedEncryptionTypes

This will allow us to interpret this attibute broadly in Samba.

Andrew Bartlett

9 years agos4:libnet_join Fix typo in msDS-SupportedEncryptionTypes
Andrew Bartlett [Mon, 28 Jun 2010 13:17:28 +0000 (23:17 +1000)]
s4:libnet_join Fix typo in msDS-SupportedEncryptionTypes

9 years agos4:provision Add an msDS-SupportedEncryptionTypes entry to our DC
Andrew Bartlett [Mon, 28 Jun 2010 13:14:23 +0000 (23:14 +1000)]
s4:provision Add an msDS-SupportedEncryptionTypes entry to our DC

This ensures that our DC will use all the available encyption types.

(The KDC reads this entry to determine what the server supports)

Andrew Bartlett

9 years agobuild: only use git when found by configure
Andrew Tridgell [Mon, 28 Jun 2010 03:40:32 +0000 (13:40 +1000)]
build: only use git when found by configure

this rebuilds version.h whenever the git version changes, so we always
get the right version with samba -V. That adds about 15s to the build
time on each git commit, which shouldn't be too onerous

9 years agobuild: allow LOAD_ENVIRONMENT() to pass when no configure has been run
Andrew Tridgell [Mon, 28 Jun 2010 03:39:00 +0000 (13:39 +1000)]
build: allow LOAD_ENVIRONMENT() to pass when no configure has been run

this returns an empty environment

9 years agobuild: allow always=True/False on SAMBA_GENERATOR()
Andrew Tridgell [Mon, 28 Jun 2010 02:07:55 +0000 (12:07 +1000)]
build: allow always=True/False on SAMBA_GENERATOR()

this allows us to force a rule to always run. Will be used by
samba_version

Signed-off-by: Andrew Bartlett <abartlet@samba.org>