nivanova/samba-autobuild/.git
10 years agoMerge branch 'master' of ssh://git.samba.org/data/git/samba
Andrew Tridgell [Wed, 3 Dec 2008 06:47:39 +0000 (17:47 +1100)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba

10 years agoAdd support for OneFS ACLs
Steven Danneman [Wed, 3 Dec 2008 04:15:34 +0000 (20:15 -0800)]
Add support for OneFS ACLs

Add to the OneFS VFS module, support for NTFS ACLs through the calls:

SMB_VFS_FGET_NT_ACL()
SMB_VFS_GET_NT_ACL()
SMB_VFS_FSET_NT_ACL()

Also create several new onefs specific smb.conf parameters in onefs.h

10 years agoAdd OneFS VFS module skeleton.
Tim Prouty [Fri, 24 Oct 2008 03:49:55 +0000 (20:49 -0700)]
Add OneFS VFS module skeleton.

Also set configure to autodetect OneFS OS and build this VFS module.

10 years agodocs: Add default value for "writeable" to man smb.conf.
Karolin Seeger [Tue, 2 Dec 2008 19:50:02 +0000 (20:50 +0100)]
docs: Add default value for "writeable" to man smb.conf.

Karolin

10 years agoImplement type multi_sz for "net registry setvalue"
Volker Lendecke [Tue, 2 Dec 2008 14:04:45 +0000 (15:04 +0100)]
Implement type multi_sz for "net registry setvalue"

10 years agos3-net: allow to list a keytab generated using net rpc vampire.
Günther Deschner [Tue, 2 Dec 2008 11:57:02 +0000 (12:57 +0100)]
s3-net: allow to list a keytab generated using net rpc vampire.

Guenther

10 years agoconfigure.in: Fix smbtorture_s3 tests.
Kai Blin [Tue, 2 Dec 2008 09:26:42 +0000 (10:26 +0100)]
configure.in: Fix smbtorture_s3 tests.

Seems like Jeremy forgot to fix configure.in when importing d448132 to master
in 8d674e35. Generate the vfs_streams_depot module so make test works again.

10 years agos3-samr: simplify _samr_QueryUserInfo a lot and fix some few potential memleaks.
Günther Deschner [Tue, 2 Dec 2008 01:08:05 +0000 (02:08 +0100)]
s3-samr: simplify _samr_QueryUserInfo a lot and fix some few potential memleaks.

Guenther

10 years agos3-samr: fix samr_SetUserInfo{2} level 23.
Günther Deschner [Mon, 1 Dec 2008 23:58:53 +0000 (00:58 +0100)]
s3-samr: fix samr_SetUserInfo{2} level 23.

Do not just start decoding/setting passwords when fields_present
do not indicate there is a password to be set.

Guenther

10 years agoAttempt to fix a build failure on AIX
Volker Lendecke [Tue, 2 Dec 2008 08:51:46 +0000 (09:51 +0100)]
Attempt to fix a build failure on AIX

10 years agos3: Fix 'ctx' might be used unitialized warnings
Tim Prouty [Tue, 2 Dec 2008 05:56:59 +0000 (21:56 -0800)]
s3: Fix 'ctx' might be used unitialized warnings

10 years agoDon't treat the DN+binary syntax as a DN.
Andrew Bartlett [Tue, 2 Dec 2008 03:22:24 +0000 (14:22 +1100)]
Don't treat the DN+binary syntax as a DN.

This should fix the OpenLDAP backend

10 years agoUse the direct pointer to the syntax
Andrew Bartlett [Tue, 2 Dec 2008 03:13:41 +0000 (14:13 +1100)]
Use the direct pointer to the syntax

This rather than manually searching for it, and is inspired by a
similar commit in dsdb/schema/schema_description.c by metze

Andrew Bartlett

10 years agos3-samr: _samr_EnumDomainUsers always returns a sam array (even w/o users).
Günther Deschner [Mon, 1 Dec 2008 23:08:56 +0000 (00:08 +0100)]
s3-samr: _samr_EnumDomainUsers always returns a sam array (even w/o users).

Guenther

10 years agos3-passdb: remove unused (now samr.idl) ACCT_NT/LM_PWD_SET flags.
Günther Deschner [Sat, 29 Nov 2008 00:51:38 +0000 (01:51 +0100)]
s3-passdb: remove unused (now samr.idl) ACCT_NT/LM_PWD_SET flags.

Guenther

10 years agos3-samr: refuse do process UserSetInfo with 0 fields_present.
Günther Deschner [Fri, 28 Nov 2008 23:23:16 +0000 (00:23 +0100)]
s3-samr: refuse do process UserSetInfo with 0 fields_present.

Guenther

10 years agos3-samr: use samr_DomainServerState in client tools.
Günther Deschner [Mon, 1 Dec 2008 23:12:39 +0000 (00:12 +0100)]
s3-samr: use samr_DomainServerState in client tools.

Guenther

10 years agore-run make samba3-idl.
Günther Deschner [Mon, 1 Dec 2008 23:14:02 +0000 (00:14 +0100)]
re-run make samba3-idl.

Guenther

10 years agos4-samr: use samr_DomainServerState in samr server.
Günther Deschner [Mon, 1 Dec 2008 23:16:05 +0000 (00:16 +0100)]
s4-samr: use samr_DomainServerState in samr server.

Guenther

10 years agosamr: add samr_DomainServerState.
Günther Deschner [Mon, 1 Dec 2008 11:53:59 +0000 (12:53 +0100)]
samr: add samr_DomainServerState.

Guenther

10 years agoRAW-STREAMS: test stream renames
Stefan Metzmacher [Mon, 1 Dec 2008 22:45:06 +0000 (14:45 -0800)]
RAW-STREAMS: test stream renames

metze

10 years agoRAW-STREAMS: some more tests...
Stefan Metzmacher [Mon, 1 Dec 2008 22:44:42 +0000 (14:44 -0800)]
RAW-STREAMS: some more tests...

metze

10 years agoRAW-STREAMS: test valid character in the range of 0x01 => 0x7F
Stefan Metzmacher [Mon, 1 Dec 2008 22:43:58 +0000 (14:43 -0800)]
RAW-STREAMS: test valid character in the range of 0x01 => 0x7F

metze

10 years agoRAW-STREAMS: check some strange stream name combinations
Stefan Metzmacher [Mon, 1 Dec 2008 22:43:23 +0000 (14:43 -0800)]
RAW-STREAMS: check some strange stream name combinations

metze

10 years agoRAW-CHKPATH: test every character in the range of 0x01 => 0x7F
Stefan Metzmacher [Mon, 1 Dec 2008 22:42:48 +0000 (14:42 -0800)]
RAW-CHKPATH: test every character in the range of 0x01 => 0x7F

metze

10 years agos4:libcli/clideltree: work against servers without NTSTATUS support
Stefan Metzmacher [Mon, 1 Dec 2008 22:42:07 +0000 (14:42 -0800)]
s4:libcli/clideltree: work against servers without NTSTATUS support

metze

10 years agos4:pvfs: correctly check stream names
Stefan Metzmacher [Mon, 1 Dec 2008 22:41:29 +0000 (14:41 -0800)]
s4:pvfs: correctly check stream names

metze

10 years agos4:pvfs: return the correct error code for invalid names
Stefan Metzmacher [Mon, 1 Dec 2008 22:40:51 +0000 (14:40 -0800)]
s4:pvfs: return the correct error code for invalid names

metze

10 years agos3:selftest: test the streams_depot module as it passes make test
Stefan Metzmacher [Mon, 1 Dec 2008 22:37:13 +0000 (14:37 -0800)]
s3:selftest: test the streams_depot module as it passes make test

The streams_xattr module only passes sometimes on my laptop.

metze

10 years agos3:smbd: close the low level fd of the base_fsp, if the file was created
Stefan Metzmacher [Mon, 1 Dec 2008 22:28:27 +0000 (14:28 -0800)]
s3:smbd: close the low level fd of the base_fsp, if the file was created

metze

10 years agos3:streams_xattr: fstat should do a stat on the base file
Stefan Metzmacher [Mon, 1 Dec 2008 22:26:58 +0000 (14:26 -0800)]
s3:streams_xattr: fstat should do a stat on the base file

The behavior of stat and fstat should be the same.

metze

10 years agos3:streams_xattr: recheck fsp->fsp_name after a rename
Stefan Metzmacher [Mon, 1 Dec 2008 22:25:20 +0000 (14:25 -0800)]
s3:streams_xattr: recheck fsp->fsp_name after a rename

metze

10 years agos3:smbd: give the correct error when trying to replace a stream
Stefan Metzmacher [Mon, 1 Dec 2008 22:23:30 +0000 (14:23 -0800)]
s3:smbd: give the correct error when trying to replace a stream

metze

10 years agos3:vfs: fix FCHMOD_ACL macros
Stefan Metzmacher [Mon, 1 Dec 2008 22:21:34 +0000 (14:21 -0800)]
s3:vfs: fix FCHMOD_ACL macros

metze

10 years agos3:streams_depot: add an option to disable the xattr checks
Stefan Metzmacher [Mon, 1 Dec 2008 22:20:21 +0000 (14:20 -0800)]
s3:streams_depot: add an option to disable the xattr checks

streams_depot:check_valid=no is useful when the filesystem
has no xattr support and files are only published via samba.

metze

10 years agos3:streams_depot: fix valgrind bug lp_parm_const_string() doesn't talloc the default...
Stefan Metzmacher [Mon, 1 Dec 2008 22:11:33 +0000 (14:11 -0800)]
s3:streams_depot: fix valgrind bug lp_parm_const_string() doesn't talloc the default value

metze

10 years agos3:streams_depot: add support for stream renames
Stefan Metzmacher [Mon, 1 Dec 2008 22:10:04 +0000 (14:10 -0800)]
s3:streams_depot: add support for stream renames

metze

10 years agos3:streams_depot: map 'file::$DATA' to just 'file'
Stefan Metzmacher [Mon, 1 Dec 2008 21:59:21 +0000 (13:59 -0800)]
s3:streams_depot: map 'file::$DATA' to just 'file'

metze

10 years agos3:streams_xattr: add support for renaming streams
Stefan Metzmacher [Mon, 1 Dec 2008 21:54:53 +0000 (13:54 -0800)]
s3:streams_xattr: add support for renaming streams

metze

10 years agos3:smbd: only try and fallback to open a directory if it's not a stream open
Stefan Metzmacher [Mon, 1 Dec 2008 21:52:28 +0000 (13:52 -0800)]
s3:smbd: only try and fallback to open a directory if it's not a stream open

metze

10 years agos3:smbd: write times should be set on the base file instead of the stream name
Stefan Metzmacher [Mon, 1 Dec 2008 21:45:55 +0000 (13:45 -0800)]
s3:smbd: write times should be set on the base file instead of the stream name

metze

10 years agos3:smbd: return DELETE_PENDING on path based operations on streams, when the main...
Stefan Metzmacher [Mon, 1 Dec 2008 21:35:28 +0000 (13:35 -0800)]
s3:smbd: return DELETE_PENDING on path based operations on streams, when the main file was deleted.

metze

10 years agoMerge branch 'master' of ssh://jra@git.samba.org/data/git/samba
Jeremy Allison [Mon, 1 Dec 2008 21:32:35 +0000 (13:32 -0800)]
Merge branch 'master' of ssh://jra@git.samba.org/data/git/samba

10 years agos3:smbd: construct the correct newname for stream renames
Stefan Metzmacher [Mon, 1 Dec 2008 21:31:43 +0000 (13:31 -0800)]
s3:smbd: construct the correct newname for stream renames

The Windows Explorer creates temporary streams and renames
them later via SFILEINFO_RENAME_INFO. The newname comes
in as ":Stream:$DATA".

metze

10 years agos3-samr: fix various potential memleaks in samr_SetUserInfo.
Günther Deschner [Mon, 1 Dec 2008 21:20:41 +0000 (22:20 +0100)]
s3-samr: fix various potential memleaks in samr_SetUserInfo.

Was there any reason why we did all these individual TALLOC_FREEs ?

Guenther

10 years agos3:smbd: wildcard characters are allowed in stream names
Stefan Metzmacher [Mon, 1 Dec 2008 21:27:47 +0000 (13:27 -0800)]
s3:smbd: wildcard characters are allowed in stream names

We only check the filename of the basefile now.

metze

10 years agos3:smbd: correctly verify stream names to pass RAW-STREAMS
Stefan Metzmacher [Mon, 1 Dec 2008 21:22:55 +0000 (13:22 -0800)]
s3:smbd: correctly verify stream names to pass RAW-STREAMS

metze

10 years agos3:smbd: '|' isn't allowed in windows filenames
Stefan Metzmacher [Mon, 1 Dec 2008 21:01:09 +0000 (13:01 -0800)]
s3:smbd: '|' isn't allowed in windows filenames

metze

10 years agos3-samr: avoid code duplication for identical code in _samr_Connect2, 4 and 5.
Günther Deschner [Mon, 1 Dec 2008 18:51:27 +0000 (19:51 +0100)]
s3-samr: avoid code duplication for identical code in _samr_Connect2, 4 and 5.

Guenther

10 years agos3-samr: modify logging in _samr_Connect2 so that it can be called from other calls...
Günther Deschner [Mon, 1 Dec 2008 18:50:26 +0000 (19:50 +0100)]
s3-samr: modify logging in _samr_Connect2 so that it can be called from other calls as well.

Guenther

10 years agoFix a debug message, append the correct \n
Volker Lendecke [Mon, 1 Dec 2008 16:35:19 +0000 (17:35 +0100)]
Fix a debug message, append the correct \n

10 years agoFix script installmo.sh when no .po file exists
Bo Yang [Tue, 2 Dec 2008 00:37:27 +0000 (08:37 +0800)]
Fix script installmo.sh when no .po file exists

10 years agos3:vfs_tsmsm: fix potential segfault (freeing uninitialized buffer)
Michael Adam [Mon, 1 Dec 2008 05:20:22 +0000 (06:20 +0100)]
s3:vfs_tsmsm: fix potential segfault (freeing uninitialized buffer)

Michael

10 years agoMake nt4_compatible_acls() non-static for use by VFS ACL modules.
Steven Danneman [Mon, 1 Dec 2008 00:26:10 +0000 (16:26 -0800)]
Make nt4_compatible_acls() non-static for use by VFS ACL modules.

10 years agos3:winbindd/nss_info: remove unused variable from nss_init()
Michael Adam [Mon, 1 Dec 2008 03:22:33 +0000 (04:22 +0100)]
s3:winbindd/nss_info: remove unused variable from nss_init()

Michael

10 years agos3:winbindd/nss_info: make nss_domain_list_add_domain() static
Michael Adam [Mon, 1 Dec 2008 03:22:02 +0000 (04:22 +0100)]
s3:winbindd/nss_info: make nss_domain_list_add_domain() static

Michael

10 years agos3:winbindd/nss_info: fix default backend handling for ad backends.
Michael Adam [Mon, 1 Dec 2008 01:01:44 +0000 (02:01 +0100)]
s3:winbindd/nss_info: fix default backend handling for ad backends.

This fixes "winbind nss info = rfc2307" (or sfu or sfu20).
Originally, only explicitly configured domains (like "rfc2307:domain")
worked with the ad module, since the domain name was not passed
backe to the module. This is fixed by recording the first backend
listed without domain in the "winbind nss info" parameter as the
default backend, and creating new nss_domain entries (using this default
backend) on the fly as requests for domains which are not explicitly
configured are encountered.

Michael

10 years agos3:winbindd/nss_info: whitespace cleanup.
Michael Adam [Sun, 30 Nov 2008 23:56:50 +0000 (00:56 +0100)]
s3:winbindd/nss_info: whitespace cleanup.

Remove trailing spaces and fix tab / space mixup.

Michael

10 years agos3:winbindd_cache: add debugging to get_nss_info_cached()
Michael Adam [Sun, 30 Nov 2008 22:00:19 +0000 (23:00 +0100)]
s3:winbindd_cache: add debugging to get_nss_info_cached()

Michael

10 years agos3:winbindd/nss_info: add entry debug message to nss_get_info()
Michael Adam [Sun, 30 Nov 2008 21:57:41 +0000 (22:57 +0100)]
s3:winbindd/nss_info: add entry debug message to nss_get_info()

Michael

10 years agos3:winbindd/nss_info: add debugging to nss_init()
Michael Adam [Sun, 30 Nov 2008 21:54:42 +0000 (22:54 +0100)]
s3:winbindd/nss_info: add debugging to nss_init()

Michael

10 years agos3:winbindd/idmap_ad: add entry debug message to nss_ad_get_info()
Michael Adam [Sun, 30 Nov 2008 21:50:26 +0000 (22:50 +0100)]
s3:winbindd/idmap_ad: add entry debug message to nss_ad_get_info()

Michael

10 years agos3:winbindd/idmap_ad: add support for trusted domains to idmap_ad (bug #3661)
Michael Adam [Wed, 26 Nov 2008 22:09:49 +0000 (23:09 +0100)]
s3:winbindd/idmap_ad: add support for trusted domains to idmap_ad (bug #3661)

This initial fix does at least work for explicitly configured domains.

The patch has a few disadvantages:

1. It does work only for explicitly configured domains, not with
   the default backend (idmap backend = ad), since it relies on the
   domain name being passed in via the idmap_domain. One workaround
   for this would be to create clones of the default idmap_domain
   for domains not explicitly configured.

2. It calls find_domain_from_name_noinit() from idmap_ad_cached_connection.
   The problem here is that only the NetBIOS domain name (workgroup
   name) is passed in via the idmap_domain struct, and the module
   has to establish a connection to the domain based on that information.
   find_domain_from_name_noinit() has the disadvantage that it uses the state
   of the domain list at fork time (unless used from the main winbindd).
   But this should be ok as long as the primary domain was reachable at
   start time.

For nss_info, the situation is similar - This will only work for domains
explicitly configured in smb.conf as follows:
"winbind nss info = rfc2307:dom1 sfu:dom2 rfc2307:dom3 template:dom4"
Setting the default nss info to one of the ad backends (rfc2307, sfu, sfu20)
will fail since the domain name is not passed in with the nss_domain_entry.

Michael

10 years agos3:winbindd/idmap_ad: refactor core of nss_{sfu|sfu20|rfc2307}_init to common function.
Michael Adam [Wed, 26 Nov 2008 21:23:34 +0000 (22:23 +0100)]
s3:winbindd/idmap_ad: refactor core of nss_{sfu|sfu20|rfc2307}_init to common function.

Michael

10 years agos3:winbindd/idmap_ad: rename ctx to mem_ctx in nss_ad_get_info()
Michael Adam [Wed, 26 Nov 2008 14:16:22 +0000 (15:16 +0100)]
s3:winbindd/idmap_ad: rename ctx to mem_ctx in nss_ad_get_info()

in preparation to using the idmap_ad_context there

Michael

10 years agos3:winbindd/idmap: add diagnostic entry debug msg to idmap_backends_sid_to_unixid
Michael Adam [Fri, 28 Nov 2008 09:40:42 +0000 (10:40 +0100)]
s3:winbindd/idmap: add diagnostic entry debug msg to idmap_backends_sid_to_unixid

Michael

10 years agos3:winbindd/idmap: add diagnostic entry debug msg to idmap_backends_unixid_to_sid
Michael Adam [Fri, 28 Nov 2008 09:40:01 +0000 (10:40 +0100)]
s3:winbindd/idmap: add diagnostic entry debug msg to idmap_backends_unixid_to_sid

Michael

10 years agos3:winbindd/idmap: add diagnostic entry debug msg to idmap_find_domain().
Michael Adam [Fri, 28 Nov 2008 09:08:46 +0000 (10:08 +0100)]
s3:winbindd/idmap: add diagnostic entry debug msg to idmap_find_domain().

Michael

10 years agos3:winbindd/idmap_util: unify entering debug messages and add ouput of domain
Michael Adam [Fri, 28 Nov 2008 09:05:19 +0000 (10:05 +0100)]
s3:winbindd/idmap_util: unify entering debug messages and add ouput of domain

Michael

10 years agos3:winbindd/nss_info: change nss_map_{to|from}_alias to take nss_domain_entry
Michael Adam [Mon, 1 Dec 2008 03:17:55 +0000 (04:17 +0100)]
s3:winbindd/nss_info: change nss_map_{to|from}_alias to take nss_domain_entry

instead of just the domain name

Michael

10 years agoSet PRESENT flag when returning NULL [SD]ACL like Windows does.
Steven Danneman [Sun, 30 Nov 2008 23:51:38 +0000 (15:51 -0800)]
Set PRESENT flag when returning NULL [SD]ACL like Windows does.

This could also be handled inside each ACL VFS module, by setting the PRESENT
flag when a NULL [SD]ACL is created.

10 years agoremove the explicit mem_ctx from ntlmssp_state, use the state itself
Volker Lendecke [Sun, 30 Nov 2008 11:54:32 +0000 (12:54 +0100)]
remove the explicit mem_ctx from ntlmssp_state, use the state itself

10 years agofix nonempty blank lines
Volker Lendecke [Sun, 30 Nov 2008 11:43:12 +0000 (12:43 +0100)]
fix nonempty blank lines

10 years agoDo not build the session request if it si not used anyway
Volker Lendecke [Sun, 30 Nov 2008 11:30:00 +0000 (12:30 +0100)]
Do not build the session request if it si not used anyway

10 years agofix nonempty blank lines
Volker Lendecke [Sun, 30 Nov 2008 11:25:17 +0000 (12:25 +0100)]
fix nonempty blank lines

10 years agos3-libnetjoin: Fix bug #5749. Re-set acctflags while joining. fix from metze.
Günther Deschner [Fri, 28 Nov 2008 23:12:26 +0000 (00:12 +0100)]
s3-libnetjoin: Fix bug #5749. Re-set acctflags while joining. fix from metze.

Guenther

10 years agos3-libnetjoin: remove unused md4_trust_password, found by metze.
Günther Deschner [Fri, 28 Nov 2008 23:10:18 +0000 (00:10 +0100)]
s3-libnetjoin: remove unused md4_trust_password, found by metze.

Guenther

10 years agos4-smbtorture: add some more testcases to pwdlastset test.
Günther Deschner [Fri, 28 Nov 2008 21:01:18 +0000 (22:01 +0100)]
s4-smbtorture: add some more testcases to pwdlastset test.

Guenther

10 years agos4-smbtorture: fix RPC-SAMR-PASSWORDS-PWDLASTSET with samba3 option.
Günther Deschner [Fri, 28 Nov 2008 20:58:25 +0000 (21:58 +0100)]
s4-smbtorture: fix RPC-SAMR-PASSWORDS-PWDLASTSET with samba3 option.

Guenther

10 years agos3-samr: add init_samr_user_info25 and init_samr_user_info26.
Günther Deschner [Fri, 28 Nov 2008 10:15:29 +0000 (11:15 +0100)]
s3-samr: add init_samr_user_info25 and init_samr_user_info26.

Guenther

10 years agoselftest: s4 does not have a pwdlastset implementation yet.
Günther Deschner [Thu, 27 Nov 2008 16:25:13 +0000 (17:25 +0100)]
selftest: s4 does not have a pwdlastset implementation yet.

Guenther

10 years agos4-smbtorture: allow to disable full testing of all possible opcode combinations.
Günther Deschner [Fri, 28 Nov 2008 11:10:56 +0000 (12:10 +0100)]
s4-smbtorture: allow to disable full testing of all possible opcode combinations.

Guenther

10 years agos4-smbtorture: move test to SAMR-PASSWORDS-PWDLASTSET.
Günther Deschner [Thu, 27 Nov 2008 11:09:39 +0000 (12:09 +0100)]
s4-smbtorture: move test to SAMR-PASSWORDS-PWDLASTSET.

Guenther

10 years agos4-smbtorture: add test for samr password_expired flag while setting passwords.
Günther Deschner [Tue, 25 Nov 2008 01:46:25 +0000 (02:46 +0100)]
s4-smbtorture: add test for samr password_expired flag while setting passwords.

Guenther

10 years agos4-smbtorture: add test_SetUserPass_level_ex.
Günther Deschner [Fri, 28 Nov 2008 11:04:09 +0000 (12:04 +0100)]
s4-smbtorture: add test_SetUserPass_level_ex.

Guenther

10 years agos4-smbtorture: add samr_rand_pass_silent.
Günther Deschner [Fri, 28 Nov 2008 00:56:09 +0000 (01:56 +0100)]
s4-smbtorture: add samr_rand_pass_silent.

Guenther

10 years agos4-samr: fix samr passwdord_expired callers.
Günther Deschner [Thu, 27 Nov 2008 16:45:01 +0000 (17:45 +0100)]
s4-samr: fix samr passwdord_expired callers.

Guenther

10 years agos3-samr: fix init_samr_user_info{23,24} callers.
Günther Deschner [Mon, 24 Nov 2008 17:49:37 +0000 (18:49 +0100)]
s3-samr: fix init_samr_user_info{23,24} callers.

Guenther

10 years agos3-build: re-run make samba3-idl.
Günther Deschner [Mon, 24 Nov 2008 15:32:18 +0000 (16:32 +0100)]
s3-build: re-run make samba3-idl.

Guenther

10 years agosamr: fix samr_UserInfo24 and samr_UserInfo26.
Günther Deschner [Mon, 24 Nov 2008 15:31:49 +0000 (16:31 +0100)]
samr: fix samr_UserInfo24 and samr_UserInfo26.

Guenther

10 years agoRemove "conn" parameter from np_open, smb_request contains it
Volker Lendecke [Sun, 9 Nov 2008 16:25:40 +0000 (17:25 +0100)]
Remove "conn" parameter from np_open, smb_request contains it

10 years agoRemove inbuf references from the trans2ioctl code
Volker Lendecke [Sun, 9 Nov 2008 11:07:57 +0000 (12:07 +0100)]
Remove inbuf references from the trans2ioctl code

10 years agoConsolidate the buffer checks for the reply_trans style functions
Volker Lendecke [Sat, 8 Nov 2008 16:08:57 +0000 (17:08 +0100)]
Consolidate the buffer checks for the reply_trans style functions

This is the one where I found the problem that led to 3.2.5. So if there is one
checkin in the last year that I would like others to review and *understand*,
it is this one :-)

Volker

10 years agoMove cli_trans_oob to lib/util.c
Volker Lendecke [Sat, 8 Nov 2008 15:48:20 +0000 (16:48 +0100)]
Move cli_trans_oob to lib/util.c

Rename it to trans_oob, it will be used in the server routines.

10 years agoRemove the variable "size" from reply_nttrans
Volker Lendecke [Sat, 8 Nov 2008 15:14:12 +0000 (16:14 +0100)]
Remove the variable "size" from reply_nttrans

This converts the range checks for the setup[] array to rely on req->wct being
set correctly in init_smb_request. As that already verifies the vwv array to be
in the range of the smb_request inbuf, we don't have to do overflow checks here
anymore.

Jeremy, please check thoroughly! :-)

Thanks,

Volker

10 years agoRemove the variable "size" from reply_trans
Volker Lendecke [Sat, 8 Nov 2008 15:14:12 +0000 (16:14 +0100)]
Remove the variable "size" from reply_trans

This converts the range checks for the setup[] array to rely on req->wct being
set correctly in init_smb_request. As that already verifies the vwv array to be
in the range of the smb_request inbuf, we don't have to do overflow checks here
anymore.

Jeremy, please check thoroughly! :-)

Thanks,

Volker

10 years agoRemove an unused variable
Volker Lendecke [Sat, 8 Nov 2008 15:03:07 +0000 (16:03 +0100)]
Remove an unused variable

10 years agoRemove two direct inbuf references from reply_sesssetup_and_X_spnego()
Volker Lendecke [Sat, 8 Nov 2008 14:44:20 +0000 (15:44 +0100)]
Remove two direct inbuf references from reply_sesssetup_and_X_spnego()

10 years agos3-samr: never allow to alter pwdlastset directly.
Günther Deschner [Thu, 27 Nov 2008 16:29:30 +0000 (17:29 +0100)]
s3-samr: never allow to alter pwdlastset directly.

Guenther

10 years agos3-samr: fix return code for invalid password sets in SetUserInfo.
Günther Deschner [Thu, 27 Nov 2008 00:25:46 +0000 (01:25 +0100)]
s3-samr: fix return code for invalid password sets in SetUserInfo.

Guenther