Stefan Metzmacher [Fri, 6 Mar 2009 15:18:50 +0000 (16:18 +0100)]
s3:libsmb: smb signing works the same for extented and non-extended security
This is only cosmetic, but it makes it easier to understand.
metze
Günther Deschner [Fri, 6 Mar 2009 13:58:49 +0000 (14:58 +0100)]
s3-spoolss: Fix Coverity ID #891 (UNINIT).
Guenther
Günther Deschner [Fri, 6 Mar 2009 11:04:47 +0000 (12:04 +0100)]
s3-spoolss: remove old _spoolss_EnumForms.
Guenther
Günther Deschner [Fri, 6 Mar 2009 11:01:54 +0000 (12:01 +0100)]
s3-spoolss: use form flags from idl in rpcclient and net.
Guenther
Günther Deschner [Fri, 6 Mar 2009 11:01:14 +0000 (12:01 +0100)]
s3-spoolss: use pidl for _spoolss_EnumForms.
Guenther
Günther Deschner [Fri, 6 Mar 2009 13:24:20 +0000 (14:24 +0100)]
s3: re-run make samba3-idl.
Guenther
Günther Deschner [Fri, 6 Mar 2009 11:05:25 +0000 (12:05 +0100)]
spoolss: flag spoolss_FormInfo1 and 2 with [public,gensize].
Guenther
Günther Deschner [Fri, 6 Mar 2009 09:55:09 +0000 (10:55 +0100)]
s3-spoolss: remove old rpccli_spoolss_enumforms.
Guenther
Günther Deschner [Fri, 6 Mar 2009 10:02:27 +0000 (11:02 +0100)]
s3-net: use new rpccli_spoolss_enumforms wrapper.
Guenther
Günther Deschner [Fri, 6 Mar 2009 09:55:41 +0000 (10:55 +0100)]
s3-rpcclient: use new rpccli_spoolss_enumforms wrapper.
Guenther
Günther Deschner [Fri, 6 Mar 2009 09:54:19 +0000 (10:54 +0100)]
s3-spoolss: add convencience wrapper around rpccli_spoolss_EnumForms.
Guenther
Günther Deschner [Fri, 6 Mar 2009 13:23:44 +0000 (14:23 +0100)]
s3: re-run make samba3-idl.
Guenther
Günther Deschner [Thu, 5 Mar 2009 17:35:47 +0000 (18:35 +0100)]
spoolss: fix [size_is] declaration for enum calls.
This took me ages to find. Thanks metze!
Guenther
Günther Deschner [Mon, 2 Mar 2009 17:02:04 +0000 (18:02 +0100)]
s4-spoolss: fix spoolss server enum calls after pointer changes.
Guenther
Günther Deschner [Fri, 6 Mar 2009 11:24:23 +0000 (12:24 +0100)]
s4-smbtorture: exit early in test_EnumPorts when no port info has been returned.
Guenther
Günther Deschner [Fri, 6 Mar 2009 11:20:14 +0000 (12:20 +0100)]
s4-smbtorture: fix s3 flavor rpc spoolss test.
Guenther
Günther Deschner [Mon, 2 Mar 2009 16:58:13 +0000 (17:58 +0100)]
s4-smbtorture: fix RPC-SPOOLSS-WIN.
Guenther
Günther Deschner [Mon, 2 Mar 2009 16:32:24 +0000 (17:32 +0100)]
s4-smbtorture: fix RPC-SPOOLSS test after enum out info pointer changes.
Guenther
Günther Deschner [Fri, 6 Mar 2009 12:52:39 +0000 (13:52 +0100)]
spoolss: fix spoolss enum calls helper macro code after pointer changes.
Guenther
Günther Deschner [Mon, 2 Mar 2009 16:31:29 +0000 (17:31 +0100)]
s3: re-run make samba3-idl.
Guenther
Günther Deschner [Mon, 2 Mar 2009 16:29:15 +0000 (17:29 +0100)]
spoolss: make all enum out info pointers a pointer to an array.
Without this we never can get a reasonable s3 cli_spoolss fn for the enum calls.
Guenther
Stefan Metzmacher [Fri, 6 Mar 2009 06:15:13 +0000 (07:15 +0100)]
s4:errormap: map ECANCELED to NT_STATUS_CANCELLED
metze
Jeremy Allison [Fri, 6 Mar 2009 06:00:22 +0000 (22:00 -0800)]
Get the sense of the integer wrap test the right way around. Sorry.
Jeremy.
Jeremy Allison [Fri, 6 Mar 2009 05:06:48 +0000 (21:06 -0800)]
Now we're allowing a lower bound for auth_len, ensure we
also check for an upper one (integer wrap).
Jeremy.
Jeremy Allison [Fri, 6 Mar 2009 01:19:18 +0000 (17:19 -0800)]
Fix bug #6161 - smbclient corrupts source path in tar mode
This was my fault. I broke the smbclient tar argument processing
in creating the string for chdir when removing pstrings.
Jeremy.
Jeremy Allison [Thu, 5 Mar 2009 23:18:18 +0000 (15:18 -0800)]
Last part of fix for #6154 - zfs does not honor admin users.
Jeremy.
Volker Lendecke [Thu, 5 Mar 2009 21:20:55 +0000 (22:20 +0100)]
Complete the fix for bug 6100
According to [MS-RPCE].pdf, section 2.2.2.11:
----
A client or a server that (during composing of a PDU) has allocated more space
for the authentication token than the security provider fills in SHOULD fill in
the rest of the allocated space with zero octets. These zero octets are still
considered to belong to the authentication token part of the PDU.<36>
----
RPC implementations are allowed to send padding bytes at the end of an auth
footer. Windows 7 makes use of this.
Thanks to Nick Meier <nmeier@microsoft.com>
Volker
Jeremy Allison [Thu, 5 Mar 2009 17:04:16 +0000 (09:04 -0800)]
Fix bug #6160 - Office 2007 fails saving files to a Samba mapped drive.
Confirmed by reporters.
Jeremy.
Tim Prouty [Thu, 5 Mar 2009 02:29:18 +0000 (18:29 -0800)]
librpc: Re-run make idl_full from source3
Tim Prouty [Tue, 3 Mar 2009 21:04:14 +0000 (13:04 -0800)]
pidl: Don't generate variables declarations for pointless array counters.
Code isn't generated to iterate over arrays of length 0, but the
variable declarations still are. The result is 'unused variable'
warnings. This only seems to be happening in one place right now, so I
targeted the fix to this case, but refactoring could be done to make
all variable declarations do this zero length check. Making it the
default would be a much more invasive fix.
Jelmer, please check!
Tim Prouty [Wed, 4 Mar 2009 03:27:50 +0000 (19:27 -0800)]
s3 OneFS: Use the public open_streams_for_delete
Tim Prouty [Wed, 4 Mar 2009 03:23:33 +0000 (19:23 -0800)]
s3: Change open_streams_for_delete to call through the vfs layer
This eliminates the last direct caller of create_file_unixpath
Bo Yang [Thu, 5 Mar 2009 01:26:57 +0000 (17:26 -0800)]
Fix careless mistake in winbindd_setup_sig_usr2_handler
Jeremy Allison [Thu, 5 Mar 2009 01:17:43 +0000 (17:17 -0800)]
Second part of fix for #6154, ensure we return max access
if admin user.
Jeremy.
Jeremy Allison [Thu, 5 Mar 2009 00:57:37 +0000 (16:57 -0800)]
Fix bug #6154 - zfs does not honor admin users.
Jeremy
Andrew Bartlett [Thu, 5 Mar 2009 00:11:19 +0000 (11:11 +1100)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba into master-devel
Andrew Bartlett [Thu, 5 Mar 2009 00:07:35 +0000 (11:07 +1100)]
Remove parse_control from header, long after the function was removed
Simo reminded me that when (long ago) I moved parse_controls away from
this place, I forgot to update the manually maintained header file.
Andrew Bartlett
Andrew Bartlett [Wed, 4 Mar 2009 23:46:46 +0000 (10:46 +1100)]
Update talloc version so we don't fail on system talloc 1.2.0
The problem is that talloc in the Samba tree now includes
talloc_get_type_abort(), which is not present on Fedora 10 or ubuntu's
talloc 1.2.0.
Andrew Bartlett
Jeremy Allison [Wed, 4 Mar 2009 22:48:33 +0000 (14:48 -0800)]
Fix crashes when running RAW-ACLs against system with tdb ACL modules
(caused by the POSIX pathname fixes).
Jeremy.
Michael Adam [Wed, 4 Mar 2009 21:05:17 +0000 (22:05 +0100)]
s3:dbwrap_ctdb_marshall_add: don't leak the ctdb_rec_data to the outside
Michael
Michael Adam [Wed, 4 Mar 2009 21:02:07 +0000 (22:02 +0100)]
s3:smbconf: move smbconf_share_exists checks into backend
Michael
Michael Adam [Wed, 4 Mar 2009 20:46:32 +0000 (21:46 +0100)]
s3:net conf: reduce memory usage of "net conf import".
"net conf import" was wrapped in one big transaction.
This lead to MAX_TALLOC_SIZE being exceeded at roughly
1500 shares. This patch resolves that problem by
limiting the top level transactions in "net conf import"
to 100 shares.
Michael
Tim Prouty [Wed, 4 Mar 2009 20:59:16 +0000 (12:59 -0800)]
socket wrapper: Fix 'might be used uninitialized' warning
Steven Danneman [Wed, 4 Mar 2009 19:04:31 +0000 (11:04 -0800)]
s3: Remove madvise support
This reverts
193be432. The MADVISE_PROTECT is inherited by all child
processes and cannot be unset. The intention of the original patch was
to protect the parent process, but allow children to be killed in low
memory. Since this isn't possible with the current API, reverting the
whole feature.
Volker Lendecke [Wed, 4 Mar 2009 11:21:26 +0000 (12:21 +0100)]
Attempt to fix the build on IRIX
Volker Lendecke [Mon, 2 Mar 2009 13:56:01 +0000 (14:56 +0100)]
Make use of gpfs_get_real_filename optional
Michael Adam [Fri, 27 Feb 2009 14:28:52 +0000 (15:28 +0100)]
s3: Fix a memleak in dbwrap_rbt.
The SMB_MALLOC'ed rbt node data was not free'd on talloc free of
the db context. This is a quick fix using talloc instead of malloc
for allocation of the node data.
Since malloc was originally used for performance reasons, one
might want to reverse to malloc and create a talloc destructor
that walks the tree and frees all the node data if this talloc
approach proves to be too slow..
Michael
Stefan Metzmacher [Tue, 3 Mar 2009 15:45:41 +0000 (16:45 +0100)]
socket_wrapper: add multiple interface support for ipv6
We use FD00::5357:5FXX in the same way we use 127.0.0.XX
metze
Stefan Metzmacher [Tue, 3 Mar 2009 14:43:22 +0000 (15:43 +0100)]
socket_wrapper: add ipv6 pcap support
metze
Stefan Metzmacher [Tue, 3 Mar 2009 14:17:26 +0000 (15:17 +0100)]
socket_wrapper: pass down sockaddr instead of sockaddr_in to prepare pcap support for ipv6
metze
Stefan Metzmacher [Tue, 3 Mar 2009 13:58:53 +0000 (14:58 +0100)]
socket_wrapper: prepare pcap support for ipv6 traffic
metze
Stefan Metzmacher [Tue, 3 Mar 2009 18:23:25 +0000 (19:23 +0100)]
s4:blackbox/test_ldb: make use of the $VALGRIND envvar
metze
Stefan Metzmacher [Tue, 3 Mar 2009 18:20:43 +0000 (19:20 +0100)]
socket_wrapper: don't crash if we get EAGAIN from real_recv()
This fixes a crash in the ldaps tests with socket wrapper pcap support.
metze
Andrew Bartlett [Wed, 4 Mar 2009 03:10:41 +0000 (14:10 +1100)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba into abartlet-devel
Andrew Bartlett [Wed, 4 Mar 2009 03:06:11 +0000 (14:06 +1100)]
Pull in all the schema information during DRS schema fetch
This includes things such as allowed attributes, which were not
populated into the schema structure before.
Andrew Bartlett
Andrew Bartlett [Wed, 4 Mar 2009 03:02:35 +0000 (14:02 +1100)]
Don't print the admin password if we don't set one.
For example, if we don't create the admin user (perhaps expecting
users to be in LDAP already, or we are due an incoming replication) we
should not confuse the administrator by printing a unused password.
Andrew Bartlett
Andrew Bartlett [Wed, 4 Mar 2009 02:58:07 +0000 (13:58 +1100)]
Allow 'net vampire' to work without an existing smb.conf
Now the provision can generate one based on the detected settings from
the target domain.
Andrew Bartlett
Tim Prouty [Wed, 4 Mar 2009 00:47:48 +0000 (16:47 -0800)]
s3 passdb: Add back some useful debug statements
Originally removed in
be1dfff02d562e42a7847bd02fed8538630d3f41
Jeremy Allison [Wed, 4 Mar 2009 00:08:56 +0000 (16:08 -0800)]
Fix bug #6155 - "force group" is no longer working as expected.
We need to store the "force group" uid separately from the
conn->server_info token as we need to apply it separately also.
Volker PLEASE CHECK !
Jeremy.
Tim Prouty [Sat, 28 Feb 2009 00:25:31 +0000 (16:25 -0800)]
s3 OneFS: Add parameter to ignore streams
Stefan Metzmacher [Tue, 3 Mar 2009 17:03:57 +0000 (18:03 +0100)]
lib/util: remove samba specific talloc_get_type_abort()
metze
Stefan Metzmacher [Tue, 3 Mar 2009 17:01:01 +0000 (18:01 +0100)]
talloc: add talloc_get_type_abort()
metze
Jeremy Allison [Tue, 3 Mar 2009 16:50:35 +0000 (08:50 -0800)]
Fix "ignore return" warning.
Jeremy.
Dan Sledz [Tue, 3 Mar 2009 00:50:19 +0000 (16:50 -0800)]
It appears that the first time we see a uid/gid that winbind can't map,
we end up returning the null sid instead of falling back to the legacy
code. Next time through the code we'll hit the negative cache and do
the right thing, but we still fail the first time.
If we fail the winbind id to sid mapping, call the legacy version. This
catches the case where we don't have a negative cache entry for the mapping.
This is better than returning the NULL sid to the caller.
Bo Yang [Mon, 2 Mar 2009 06:19:50 +0000 (14:19 +0800)]
More fix to initialize idmap statuses
Björn Jacke [Mon, 2 Mar 2009 16:01:37 +0000 (17:01 +0100)]
use test -f, Solaris /bin/sh doesn't know test -e
Simo Sorce [Mon, 2 Mar 2009 20:38:45 +0000 (15:38 -0500)]
Fix wbclient.c wrt tevent_req changes too.
Volker Lendecke [Mon, 2 Mar 2009 19:10:13 +0000 (20:10 +0100)]
Attempt to fix the build
Simo, with which compiler did you build this? I'd be curious to learn about the
compiler settings that make this build.
Thanks,
Volker
Simo Sorce [Sat, 28 Feb 2009 20:44:30 +0000 (15:44 -0500)]
Make struct tevent_req opaque
Move struct tevent_req in tevent_internal, and ad getters and setters
for private data and the callback function.
This patch also renames 'private_state' into 'data'. What is held in this
pointer is in fact data and not a state like enum tevent_req_state.
Calling it 'state' is confusing.
The functions addedd are:
tevent_req_set_callback() - sets req->async.fn and req->async.private_data
tevent_req_set_print_fn() - sets req->private_print
tevent_req_callback_data() - gets req->async.private_data
tevent_req_data() - gets rea->data
This way it is much simpler to keep API/ABI compatibility in the future.
Günther Deschner [Mon, 2 Mar 2009 12:09:19 +0000 (13:09 +0100)]
s3-spoolss: PRINTER_STATUS_OK has been moved to IDL.
Guenther
Günther Deschner [Mon, 2 Mar 2009 10:21:26 +0000 (11:21 +0100)]
s3-rpcclient: zero out devmode and secdesc in setdriver and setprinter command.
Guenther
Günther Deschner [Mon, 2 Mar 2009 13:23:42 +0000 (14:23 +0100)]
s3: re-run make samba3-idl.
Guenther
Günther Deschner [Mon, 2 Mar 2009 12:08:55 +0000 (13:08 +0100)]
spoolss: move up printer and job status codes.
Guenther
Günther Deschner [Mon, 2 Mar 2009 10:19:57 +0000 (11:19 +0100)]
spoolss: use dummy pointers for truncated devmode and secdesc in SetJobInfo2/4.
Guenther
Günther Deschner [Mon, 2 Mar 2009 12:07:46 +0000 (13:07 +0100)]
error-codes: add WERR_DEVICE_NOT_CONNECTED.
Guenther
Björn Jacke [Sun, 1 Mar 2009 20:08:33 +0000 (21:08 +0100)]
make man page (un)install more portable
Björn Jacke [Sun, 1 Mar 2009 20:38:31 +0000 (21:38 +0100)]
some shells are picky about ^ without quotes
Karolin Seeger [Fri, 27 Feb 2009 10:09:59 +0000 (11:09 +0100)]
s3/docs: Add missing full stop.
Karolin
Stefan Metzmacher [Mon, 2 Mar 2009 11:05:43 +0000 (12:05 +0100)]
libcli/security: fix the source4 build
metze
Stefan Metzmacher [Mon, 2 Mar 2009 07:55:00 +0000 (08:55 +0100)]
libcli/security: fix the source3 build
metze
Jelmer Vernooij [Mon, 2 Mar 2009 04:07:30 +0000 (05:07 +0100)]
Fix test_surrounding in samba4.rpcecho.python.
Jelmer Vernooij [Mon, 2 Mar 2009 04:04:07 +0000 (05:04 +0100)]
Use samba3's own iconv implementation for now, until all changes are
merged.
Jelmer Vernooij [Mon, 2 Mar 2009 03:15:11 +0000 (04:15 +0100)]
Merge branch 'master' of git://git.samba.org/samba into convenience
Jelmer Vernooij [Mon, 2 Mar 2009 03:12:57 +0000 (04:12 +0100)]
Import ISO-8859-1, 646 from Samba 3 iconv.
Tim Prouty [Sun, 1 Mar 2009 21:58:46 +0000 (13:58 -0800)]
s3: Fix incompatible type warnings
Tim Prouty [Fri, 27 Feb 2009 22:47:47 +0000 (14:47 -0800)]
s3 OneFS: Refactor config code and cleanup includes
Jelmer Vernooij [Sun, 1 Mar 2009 21:31:10 +0000 (22:31 +0100)]
Use shared header file for character sets, remove old definitions from samba3 smb.h.
Jelmer Vernooij [Sun, 1 Mar 2009 21:25:57 +0000 (22:25 +0100)]
Merge branch 'master' of git://git.samba.org/samba into convenience
Jelmer Vernooij [Sun, 1 Mar 2009 21:24:34 +0000 (22:24 +0100)]
Use common header file for character set handling in Samba 3 and Samba 4.
Jelmer Vernooij [Sun, 1 Mar 2009 19:06:55 +0000 (20:06 +0100)]
Add header files for secace and secacl.
Jelmer Vernooij [Sun, 1 Mar 2009 18:55:46 +0000 (19:55 +0100)]
s4: Use same function signature for convert_* as s3.
Jelmer Vernooij [Sun, 1 Mar 2009 17:15:36 +0000 (18:15 +0100)]
Move secacl to top-level.
Jelmer Vernooij [Sun, 1 Mar 2009 17:15:15 +0000 (18:15 +0100)]
dom_sid.h: Include dependency security.h that provides the dom_sid struct.
Jelmer Vernooij [Sun, 1 Mar 2009 17:05:22 +0000 (18:05 +0100)]
Also re-add removed codepoint_t; I'm clearly not having my day today.
Jelmer Vernooij [Sun, 1 Mar 2009 17:02:24 +0000 (18:02 +0100)]
Keep using Samba3's charset.h for now.
Jelmer Vernooij [Sun, 1 Mar 2009 16:59:30 +0000 (17:59 +0100)]
Move secace.c to top-level.
Jelmer Vernooij [Sun, 1 Mar 2009 16:29:04 +0000 (17:29 +0100)]
Merge branch 'master' of git://git.samba.org/samba into convenience
Jelmer Vernooij [Sun, 1 Mar 2009 16:13:10 +0000 (17:13 +0100)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba into talloc-next
Jelmer Vernooij [Sun, 1 Mar 2009 16:09:45 +0000 (17:09 +0100)]
Rerun pidl.
Jelmer Vernooij [Sun, 1 Mar 2009 16:09:07 +0000 (17:09 +0100)]
Don't generate array iterators when the length of the array is always 0.
(bug #6140)