Andrew Tridgell [Tue, 17 Aug 2010 04:11:24 +0000 (14:11 +1000)]
s4-drs: fixed check for SECURITY_RO_DOMAIN_CONTROLLER
check more than the user_sid, and also check for the right rid value
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Tue, 17 Aug 2010 04:10:34 +0000 (14:10 +1000)]
s4-dsdb: added support for UF_PARTIAL_SECRETS_ACCOUNT
when this is in user_account_control the account is a RODC, and we
need to set the primaryGroupID to be DOMAIN_RID_READONLY_DCS
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Tue, 17 Aug 2010 03:19:53 +0000 (13:19 +1000)]
s4-dsdb: cope with cracknames of form dnsdomain\account
this is used by w2k8r2 when doing a RODC dcpromo
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Tue, 17 Aug 2010 02:06:24 +0000 (12:06 +1000)]
s4-dsdb: set LDB_FLAG_INTERNAL_DISABLE_VALIDATION for msDS-SecondaryKrbTgtNumber
msDS-SecondaryKrbTgtNumber is setup with a value that is outside the
range allowed by the schema (the schema has
rangeLower==rangeUpper==65536). We need to mark this element as being
internally generated to avoid the range checks
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Tue, 17 Aug 2010 02:04:45 +0000 (12:04 +1000)]
s4-ldb: added LDB_FLAG_INTERNAL_DISABLE_VALIDATION
When this flag is set on an element in an add/modify request then the
normal validate_ldb() call that checks the element against schema
constraints is disabled
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Tue, 17 Aug 2010 02:03:47 +0000 (12:03 +1000)]
s4-ldb: added LDB_FLAG_INTERNAL_MASK
This ensures that internal bits for the element flags in add/modify
requests are not set via the ldb API
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Tue, 17 Aug 2010 01:21:11 +0000 (11:21 +1000)]
s4-ldb: use LDB_FLAG_MOD_TYPE() to extract element type from messages
The flags field of message elements is part of a set of flags. We had
LDB_FLAG_MOD_MASK for extracting the type, but it was only rarely
being used (only 1 call used it correctly). This adds
LDB_FLAG_MOD_MASK() to make it more obvious what is going on.
This will allow us to use some of the other flags bits for internal
markers on elements
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Tue, 17 Aug 2010 01:13:59 +0000 (11:13 +1000)]
s4-dsdb: support LDB_CONTROL_RODC_DCPROMO_OID for nTDSDSA add
this control disables the system only check for nTDSDSA add operations
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Tue, 17 Aug 2010 01:12:54 +0000 (11:12 +1000)]
s4-dsdb: fixed test for LDB_CONTROL_RODC_DCPROMO_OID
the ldb_msg_add_fmt() call returns LDB_SUCCESS on success
Andrew Tridgell [Tue, 17 Aug 2010 01:12:09 +0000 (11:12 +1000)]
s4-ldapserver: support controls on ldap add and rename
we need to pass the controls down to the add and rename ldb operations
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Mon, 16 Aug 2010 23:59:18 +0000 (09:59 +1000)]
s4-dsdb: added support for LDB_CONTROL_RODC_DCPROMO_OID
this control adds a unique msDS-SecondaryKrbTgtNumber attribute to a
user object.
There is some 'interesting' interaction with the rangeLower and
rangeUpper attributes and this add. We don't implementat
rangeLower/rangeUpper yet, but when we do we'll need an override for
this control (or be careful about module ordering).
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Mon, 16 Aug 2010 23:17:17 +0000 (09:17 +1000)]
s4-ldap: use common functions for ldap flag controls encode/decode
many controls are simple present/not-present flags, and don't need
their own parsers
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Günther Deschner [Tue, 17 Aug 2010 11:18:34 +0000 (13:18 +0200)]
s3-dcerpc: try to fix the non gssapi build.
Guenther
Günther Deschner [Tue, 17 Aug 2010 11:06:36 +0000 (13:06 +0200)]
s3-dcerpc: fix c++ build warning.
Guenther
Günther Deschner [Tue, 17 Aug 2010 11:06:13 +0000 (13:06 +0200)]
s3-dcerpc: fix uninitialized variable in cli_get_session_key().
Simo, please check.
Guenther
Günther Deschner [Tue, 17 Aug 2010 11:03:58 +0000 (13:03 +0200)]
s3-util: remove unused variable.
Guenther
Simo Sorce [Tue, 17 Aug 2010 10:40:38 +0000 (06:40 -0400)]
s3-ads: Remove unused function and file
Stefan Metzmacher [Tue, 17 Aug 2010 06:02:46 +0000 (08:02 +0200)]
s3:winbindd: don't ignore 'result' in wb_dsgetdcname_done()
Ignoring it could cause a segfault in winbindd_getdcname_recv()
metze
Volker Lendecke [Sun, 15 Aug 2010 14:02:37 +0000 (16:02 +0200)]
s3: Remove smbd_server_fd() from write_data()
This completely removes the DEBUG(0, ..) error message from write_data(). I've
gone through all callers of write_data() and made sure that they have their own
equivalent error message printing.
Simo Sorce [Tue, 3 Aug 2010 09:11:28 +0000 (05:11 -0400)]
s3-dcerpc: Use common send functions for ntlmssp too
Remove unused function.
Simo Sorce [Mon, 2 Aug 2010 16:15:43 +0000 (12:15 -0400)]
s3-dcerpc: properly implement gse/spnego_get_session_key
Simo Sorce [Mon, 2 Aug 2010 16:05:45 +0000 (12:05 -0400)]
s3-dcerpc: Check data and return appropriate error
Simo Sorce [Mon, 2 Aug 2010 16:18:58 +0000 (12:18 -0400)]
s3-dcerpc: Remove unused function
Simo Sorce [Mon, 2 Aug 2010 14:28:10 +0000 (10:28 -0400)]
s3-dcerpc: make a few local functions as static
Simo Sorce [Mon, 2 Aug 2010 14:14:02 +0000 (10:14 -0400)]
Change debug statements to use __location__
Simo Sorce [Mon, 2 Aug 2010 14:03:04 +0000 (10:03 -0400)]
s3-dcerpc: Pull packet in the caller, before validation
Simo Sorce [Mon, 2 Aug 2010 13:47:01 +0000 (09:47 -0400)]
Add my (c)
Andreas Schneider [Fri, 13 Aug 2010 13:56:49 +0000 (15:56 +0200)]
s3-samr: Fixed some build warnings.
Volker Lendecke [Tue, 17 Aug 2010 06:45:22 +0000 (08:45 +0200)]
s3: Fix a ton of type-punned warnings
Brad Hards [Mon, 16 Aug 2010 22:43:28 +0000 (08:43 +1000)]
build fix
Andrew Tridgell [Mon, 16 Aug 2010 01:38:26 +0000 (11:38 +1000)]
s4-ldb: test the 'displayName=a,b' bug
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Tue, 3 Aug 2010 07:15:10 +0000 (17:15 +1000)]
s3-provision: cope with the policy directory already existing
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Mon, 16 Aug 2010 01:03:58 +0000 (11:03 +1000)]
s4-ldb: fixed the ldb 'displayName=a,b' indexing bug
the problem was the inconsistency between the key form of DNs between
the itdb used for indexing and the on disk form
Thanks to Matthieu Patou for finding this bug!
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Mon, 16 Aug 2010 01:00:41 +0000 (11:00 +1000)]
s4-ldb: add some comments explaining the ltdb_index_idxptr() function
this function copes with alignment sensitive CPUs
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Volker Lendecke [Sun, 15 Aug 2010 09:43:46 +0000 (11:43 +0200)]
s3: Remove smbd_server_fd() from smbd_process
Volker Lendecke [Sun, 15 Aug 2010 09:41:08 +0000 (11:41 +0200)]
s3: Remove smbd_server_fd() from smbd_echo_loop
Volker Lendecke [Sun, 15 Aug 2010 09:40:28 +0000 (11:40 +0200)]
s3: Remove smbd_server_fd() from smbd_echo_reader
Volker Lendecke [Sun, 15 Aug 2010 09:39:09 +0000 (11:39 +0200)]
s3: Remove smbd_server_fd() from smbd_echo_reply
Volker Lendecke [Sun, 15 Aug 2010 09:36:27 +0000 (11:36 +0200)]
s3: Remove smbd_server_fd() from keepalive_fn
Volker Lendecke [Sun, 15 Aug 2010 09:35:23 +0000 (11:35 +0200)]
s3: Remove smbd_server_fd() from smbd_server_connection_handler
Volker Lendecke [Sun, 15 Aug 2010 09:34:48 +0000 (11:34 +0200)]
s3: Remove smbd_server_fd() from smbd_server_connection_read_handler
Volker Lendecke [Sun, 15 Aug 2010 09:33:53 +0000 (11:33 +0200)]
s3: Remove smbd_server_fd() from chain_reply
Volker Lendecke [Sun, 15 Aug 2010 09:33:05 +0000 (11:33 +0200)]
s3: Remove smbd_server_fd() from construct_reply
Volker Lendecke [Sun, 15 Aug 2010 09:31:51 +0000 (11:31 +0200)]
s3: Remove smbd_server_fd() from switch_message
Volker Lendecke [Sun, 15 Aug 2010 09:31:13 +0000 (11:31 +0200)]
s3: Remove smbd_server_fd() from smbd_server_connection_loop_once
Volker Lendecke [Sun, 15 Aug 2010 09:29:44 +0000 (11:29 +0200)]
s3: Remove smbd_server_fd() from receive_smb_raw_talloc_partial_read
Volker Lendecke [Sun, 15 Aug 2010 09:10:13 +0000 (11:10 +0200)]
s3: Remove smbd_server_fd() from make_connection
Volker Lendecke [Sun, 15 Aug 2010 09:05:18 +0000 (11:05 +0200)]
s3: Remove smbd_server_fd() from share_sanity_checks
Volker Lendecke [Sun, 15 Aug 2010 07:24:30 +0000 (09:24 +0200)]
s3: Remove smbd_server_fd() from setup_new_vc_session
Volker Lendecke [Sun, 15 Aug 2010 07:24:17 +0000 (09:24 +0200)]
s3: Remove smbd_server_fd() from make_connection_snum
Volker Lendecke [Sun, 15 Aug 2010 06:59:19 +0000 (08:59 +0200)]
s3: Remove smbd_server_fd() from reply_echo
Volker Lendecke [Sun, 15 Aug 2010 06:57:26 +0000 (08:57 +0200)]
s3: Remove smbd_server_fd() from reply_writebraw
Volker Lendecke [Sun, 15 Aug 2010 06:56:18 +0000 (08:56 +0200)]
s3: Remove smbd_server_fd() from send_file_readX
Volker Lendecke [Sun, 15 Aug 2010 06:54:23 +0000 (08:54 +0200)]
s3: Remove smbd_server_fd() from send_file_readbraw
Volker Lendecke [Sun, 15 Aug 2010 06:52:01 +0000 (08:52 +0200)]
s3: Remove smbd_server_fd() from reply_readbraw_error
Volker Lendecke [Sun, 15 Aug 2010 06:51:28 +0000 (08:51 +0200)]
s3: Remove smbd_server_fd() from sendfile_short_send
Volker Lendecke [Sun, 15 Aug 2010 06:50:26 +0000 (08:50 +0200)]
s3: Remove smbd_server_fd() from fake_sendfile
Volker Lendecke [Sun, 15 Aug 2010 06:48:54 +0000 (08:48 +0200)]
s3: Remove smbd_server_fd from netbios_session_retarget
Volker Lendecke [Sat, 14 Aug 2010 21:14:26 +0000 (23:14 +0200)]
s3: Remove smbd_server_fd from vfs_pwrite_data
Volker Lendecke [Sat, 14 Aug 2010 21:14:16 +0000 (23:14 +0200)]
s3: Remove smbd_server_fd from vfs_write_data
Volker Lendecke [Sat, 14 Aug 2010 21:13:28 +0000 (23:13 +0200)]
s3: Remove smbd_server_fd from send_trans2_replies
Volker Lendecke [Sat, 14 Aug 2010 21:13:11 +0000 (23:13 +0200)]
s3: Remove smbd_server_fd from smbd_initialize_smb2
Volker Lendecke [Sat, 14 Aug 2010 21:12:46 +0000 (23:12 +0200)]
s3: Remove smbd_server_fd from reply_special
Volker Lendecke [Sat, 14 Aug 2010 21:12:21 +0000 (23:12 +0200)]
s3: Remove smbd_server_fd from pipe_write_done
Volker Lendecke [Sat, 14 Aug 2010 21:12:01 +0000 (23:12 +0200)]
s3: Remove smbd_server_fd from send_break_message_smb1
Volker Lendecke [Sat, 14 Aug 2010 21:11:43 +0000 (23:11 +0200)]
s3: Remove smbd_server_fd from api_dcerpc_cmd_read/write_done
Volker Lendecke [Sat, 14 Aug 2010 21:11:23 +0000 (23:11 +0200)]
s3: Remove smbd_server_fd from send_trans_reply
Volker Lendecke [Sat, 14 Aug 2010 21:10:45 +0000 (23:10 +0200)]
s3: Remove smbd_server_fd from send_nt_replies
Volker Lendecke [Sat, 14 Aug 2010 21:10:18 +0000 (23:10 +0200)]
s3: Remove smbd_server_fd from blocking_lock_reply_error
Volker Lendecke [Sat, 14 Aug 2010 21:10:01 +0000 (23:10 +0200)]
s3: Remove smbd_server_fd from generic_blocking_lock_error
Volker Lendecke [Sat, 14 Aug 2010 12:54:13 +0000 (14:54 +0200)]
s3: Remove smbd_server_fd from handle_aio_read/write_complete
Volker Lendecke [Sat, 14 Aug 2010 12:53:45 +0000 (14:53 +0200)]
s3: Remove smbd_server_fd from schedule_aio_write_and_X
Volker Lendecke [Sat, 14 Aug 2010 12:52:59 +0000 (14:52 +0200)]
s3: Add "sock" to smbd_server_connection
Andreas Schneider [Mon, 16 Aug 2010 19:40:04 +0000 (21:40 +0200)]
s3-waf: Added missing client option to pidl list for wbint.
Volker Lendecke [Sat, 14 Aug 2010 12:30:07 +0000 (14:30 +0200)]
s3: Simplify the logic of check_access by an early return
Volker Lendecke [Sat, 14 Aug 2010 10:11:07 +0000 (12:11 +0200)]
s3: Lift smbd_server_fd() from read_target_host
Andreas Schneider [Mon, 16 Aug 2010 19:30:26 +0000 (21:30 +0200)]
s3-waf: Try to fix the idl build.
Andreas Schneider [Mon, 16 Aug 2010 18:35:31 +0000 (20:35 +0200)]
s3-waf: Create a variable for LIBNDR_NTPRINTING_SRC.
Andreas Schneider [Mon, 16 Aug 2010 18:25:46 +0000 (20:25 +0200)]
waf: Generate the ntprinting ndr functions.
Andreas Schneider [Mon, 16 Aug 2010 18:35:16 +0000 (20:35 +0200)]
s3-waf: Fixed the rpc_client build.
Volker Lendecke [Mon, 16 Aug 2010 19:12:52 +0000 (21:12 +0200)]
Fix a typo
Andreas Schneider [Mon, 16 Aug 2010 18:18:20 +0000 (20:18 +0200)]
s3-waf: Fixed the build.
Jim McDonough [Mon, 16 Aug 2010 18:07:44 +0000 (14:07 -0400)]
s3-printing: fix BUG 7280 - auto printers not loading with registry
config
Matthias Dieter Wallnöfer [Mon, 16 Aug 2010 16:45:26 +0000 (18:45 +0200)]
s4:samdb_set_password_sid - fix comment
Add more possible result NTSTATUS codes
Günther Deschner [Mon, 16 Aug 2010 14:40:12 +0000 (16:40 +0200)]
s3-selftest: fix make oldtest (testparm_s3 tests use $LOCAL_PATH).
Guenther
Stefan Metzmacher [Thu, 12 Aug 2010 13:28:27 +0000 (15:28 +0200)]
s3:winbindd: remove rpc_pipe_client references from winbind_dual_ndr code
metze
Stefan Metzmacher [Thu, 12 Aug 2010 13:13:54 +0000 (15:13 +0200)]
s3:winbindd: use dcerpc_wbint_* functions instead of rpccli_wbint_*
metze
Stefan Metzmacher [Thu, 12 Aug 2010 13:12:11 +0000 (15:12 +0200)]
s3:winbindd: add binding_handle to struct winbindd_child
metze
Stefan Metzmacher [Thu, 12 Aug 2010 12:50:47 +0000 (14:50 +0200)]
s3:include: remove unused dispatch* fn pointers from rpc_pipe_client
metze
Stefan Metzmacher [Thu, 12 Aug 2010 12:49:47 +0000 (14:49 +0200)]
s3:winbindd: remove unused wb_ndr_dispatch* functions
metze
Stefan Metzmacher [Thu, 12 Aug 2010 12:48:27 +0000 (14:48 +0200)]
s3:rpc_server: remove unused rpc_pipe_internal_dispatch()
metze
Stefan Metzmacher [Thu, 12 Aug 2010 12:46:24 +0000 (14:46 +0200)]
s3:rpc_client: remove unused cli_do_rpc_ndr* functions
metze
Stefan Metzmacher [Thu, 12 Aug 2010 12:39:42 +0000 (14:39 +0200)]
s3:rpc_client: remove unused rpc_pipe_open_local()
metze
Volker Lendecke [Mon, 16 Aug 2010 11:53:10 +0000 (13:53 +0200)]
s3-printing: Lift the use of smbd_server_fd from job_submit.
Signed-off-by: Andreas Schneider <asn@samba.org>
Günther Deschner [Mon, 16 Aug 2010 11:42:23 +0000 (13:42 +0200)]
s3-param: also remove lp_update_encrypted from loadparm.
Andreas, please check.
Guenther
Volker Lendecke [Sat, 14 Aug 2010 12:26:20 +0000 (14:26 +0200)]
s3: Fix some type-punned warnings
Günther Deschner [Mon, 16 Aug 2010 11:30:00 +0000 (13:30 +0200)]
s3-smbtorture: fix printf statement in ioctl test.
Guenther
Volker Lendecke [Mon, 16 Aug 2010 06:11:00 +0000 (08:11 +0200)]
s3: Remove an unused struct definition
Volker Lendecke [Sat, 14 Aug 2010 08:22:12 +0000 (10:22 +0200)]
s3: Remove get_client_fd()
Andreas Schneider [Thu, 29 Jul 2010 11:18:35 +0000 (13:18 +0200)]
s3-auth: Remove docs about obsolete 'update encrypted' option.