nivanova/samba-autobuild/.git
9 years agos3-printing: follow force user/group for driver IO
David Disseldorp [Wed, 2 Mar 2011 13:34:28 +0000 (14:34 +0100)]
s3-printing: follow force user/group for driver IO

Configuring force user/group settings for the print$ share currently has
unexpected results, this is explained by how the driver upload/add
process takes place. Consider the following example:

[print$]
        path = /print-drv
        write list = $DRIVER_UPLOAD_USER
        force group = ntadmin

- the client connects to the [print$] share and uploads all driver
  files to the /print-drv/W32X86 directory.

- This is permitted, as /print-drv/W32X86 is owned by group ntadmin, and
  the "force group = ntadmin" takes effect for the [print$] session.

- Once all files are uploaded, the client connects to the [ipc$]
  share and issues an AddPrinterDriverEx spoolss request.

- In handling this request move_driver_to_download_area() is called,
  which attempts to create the directory /print-drv/W32X86/3

- The create directory fails, as it is done as the user connected to
  the [ipc$] share which does not have permission to write to the driver
  directory. The [print$] "force group = ntadmin" has no effect.

This is a regression from previous behaviour prior to the commit:
783ab04 Convert move_driver_to_download_area to use create_conn_struct.

https://bugzilla.samba.org/show_bug.cgi?id=7921
Signed-off-by: Andreas Schneider <asn@samba.org>
9 years agoldb:ldb tools - remove a superflous "return" (usage internally calls "exit")
Matthias Dieter Wallnöfer [Wed, 2 Mar 2011 21:46:03 +0000 (22:46 +0100)]
ldb:ldb tools - remove a superflous "return" (usage internally calls "exit")

Reviewed by: Tridge

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Fri Mar  4 09:39:22 CET 2011 on sn-devel-104

9 years agoldb:ldb tools - return LDB_ERR_INVALID_DN_SYNTAX on wrong DN parameters
Matthias Dieter Wallnöfer [Wed, 2 Mar 2011 21:40:13 +0000 (22:40 +0100)]
ldb:ldb tools - return LDB_ERR_INVALID_DN_SYNTAX on wrong DN parameters

Not all LDB databases have further DN checks.

Reviewed by: Tridge

9 years agoldb:ldb tools - ldbtest - convert other result values to LDB codes as well
Matthias Dieter Wallnöfer [Wed, 2 Mar 2011 21:28:27 +0000 (22:28 +0100)]
ldb:ldb tools - ldbtest - convert other result values to LDB codes as well

I've forgotten this in my first patchset.

Reviewed by: Tridge

9 years agos4:LDAP server - remove validation checks of input DNs
Matthias Dieter Wallnöfer [Wed, 2 Mar 2011 18:14:01 +0000 (19:14 +0100)]
s4:LDAP server - remove validation checks of input DNs

We should rather try to let the LDB modules perform these checks
otherwise different backends behaviour differently.

Reviewed by: Tridge

9 years agos4:objectclass LDB module - if we cannot find DN's parent then the DN itself is invalid
Matthias Dieter Wallnöfer [Wed, 2 Mar 2011 17:50:11 +0000 (18:50 +0100)]
s4:objectclass LDB module - if we cannot find DN's parent then the DN itself is invalid

ERR_INVALID_DN_SYNTAX fits better than ERR_OPERATION_ERROR in this case. This
one gets triggered if we perform "add" requests without the LDAP server.

Reviewed by: Tridge

9 years agodebug: fixed a valgrind error
Andrew Tridgell [Fri, 4 Mar 2011 01:23:16 +0000 (12:23 +1100)]
debug: fixed a valgrind error

Thanks to Volker for spotting this one!

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Fri Mar  4 03:09:52 CET 2011 on sn-devel-104

9 years agos3-waf: add wildcard commands from main wscript.
Günther Deschner [Wed, 2 Mar 2011 22:13:29 +0000 (23:13 +0100)]
s3-waf: add wildcard commands from main wscript.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Mar  4 02:11:11 CET 2011 on sn-devel-104

9 years agos3-nterr: use strcasecmp in nt_status_string_to_code().
Günther Deschner [Thu, 3 Mar 2011 00:11:43 +0000 (01:11 +0100)]
s3-nterr: use strcasecmp in nt_status_string_to_code().

Guenther

9 years agos4-nterr: move auth_nt_status_squash to nt_status_squash and move to nterr.c
Günther Deschner [Thu, 3 Mar 2011 00:05:33 +0000 (01:05 +0100)]
s4-nterr: move auth_nt_status_squash to nt_status_squash and move to nterr.c

Guenther

9 years agos4-nterr: some minor cosmetic edits to further match s3 nterr.
Günther Deschner [Wed, 2 Mar 2011 23:41:11 +0000 (00:41 +0100)]
s4-nterr: some minor cosmetic edits to further match s3 nterr.

Guenther

9 years agos3-nterr: within nt_errstr() compare codes using NT_STATUS_V().
Günther Deschner [Wed, 2 Mar 2011 23:39:44 +0000 (00:39 +0100)]
s3-nterr: within nt_errstr() compare codes using NT_STATUS_V().

This is to avoid future very special NT_STATUS_EQUAL semantics within s4.

Guenther

9 years agonterr: make sure both nt_err_desc structs are the same.
Günther Deschner [Wed, 2 Mar 2011 23:06:13 +0000 (00:06 +0100)]
nterr: make sure both nt_err_desc structs are the same.

Guenther

9 years agonterr: make sure both nt_errs structs are the same.
Günther Deschner [Wed, 2 Mar 2011 22:51:56 +0000 (23:51 +0100)]
nterr: make sure both nt_errs structs are the same.

Guenther

9 years agos4-nterr: add _N macro handling as in s3-nterr.
Günther Deschner [Wed, 2 Mar 2011 22:40:58 +0000 (23:40 +0100)]
s4-nterr: add _N macro handling as in s3-nterr.

Guenther

9 years agos3-nterr: make nt_err_desc static const.
Günther Deschner [Wed, 2 Mar 2011 22:40:05 +0000 (23:40 +0100)]
s3-nterr: make nt_err_desc static const.

Guenther

9 years agonterr: remove space indents (use tabs instead), following coding standards.
Günther Deschner [Thu, 3 Mar 2011 00:16:22 +0000 (01:16 +0100)]
nterr: remove space indents (use tabs instead), following coding standards.

Guenther

9 years agonterr: remove trailing whitespace.
Günther Deschner [Wed, 2 Mar 2011 22:16:35 +0000 (23:16 +0100)]
nterr: remove trailing whitespace.

Guenther

9 years agos3-waf: add check for SEEKDIR_RETURNS_VOID.
Günther Deschner [Thu, 3 Mar 2011 21:55:09 +0000 (22:55 +0100)]
s3-waf: add check for SEEKDIR_RETURNS_VOID.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Mar  4 01:13:54 CET 2011 on sn-devel-104

9 years agos3-waf: add check for HAVE_FUNCTION_ATTRIBUTE_DESTRUCTOR.
Günther Deschner [Thu, 3 Mar 2011 21:10:40 +0000 (22:10 +0100)]
s3-waf: add check for HAVE_FUNCTION_ATTRIBUTE_DESTRUCTOR.

Guenther

9 years agolibreplace: move "struct timespec" checks into libreplace (where timespec is already...
Günther Deschner [Thu, 3 Mar 2011 15:26:48 +0000 (16:26 +0100)]
libreplace: move "struct timespec" checks into libreplace (where timespec is already used).

Bjoern, Metze, please check.

Guenther

9 years agosocket_wrapper: use swrap_sendmsg_before()/after() in swrap_writev()
Stefan Metzmacher [Sat, 30 Oct 2010 14:23:49 +0000 (16:23 +0200)]
socket_wrapper: use swrap_sendmsg_before()/after() in swrap_writev()

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Mar  3 23:43:39 CET 2011 on sn-devel-104

9 years agosocket_wrapper: use swrap_sendmsg_before()/after() in swrap_sendmsg()
Stefan Metzmacher [Sat, 30 Oct 2010 14:23:49 +0000 (16:23 +0200)]
socket_wrapper: use swrap_sendmsg_before()/after() in swrap_sendmsg()

This also adds the same logic for broadcast as in swrap_sendto()
for SOCK_DGRAM.

metze

9 years agosocket_wrapper: use swrap_sendmsg_before()/after() in swrap_send()
Stefan Metzmacher [Sat, 30 Oct 2010 14:23:49 +0000 (16:23 +0200)]
socket_wrapper: use swrap_sendmsg_before()/after() in swrap_send()

metze

9 years agosocket_wrapper: use swrap_sendmsg_before()/after() in swrap_sendto()
Stefan Metzmacher [Sat, 30 Oct 2010 14:23:49 +0000 (16:23 +0200)]
socket_wrapper: use swrap_sendmsg_before()/after() in swrap_sendto()

metze

9 years agosocket_wrapper: add swrap_sendmsg_before/after helper functions
Stefan Metzmacher [Sat, 30 Oct 2010 14:08:49 +0000 (16:08 +0200)]
socket_wrapper: add swrap_sendmsg_before/after helper functions

Currently have almost the same logic in swrap_send(), swrap_sendto(),
swrap_writev() and swrap_sendmsg(), this helper functions
let combine all the logic in 2 places.

metze

9 years agosocket_wrapper: replace recvmsg() correctly
Stefan Metzmacher [Thu, 3 Mar 2011 14:37:17 +0000 (15:37 +0100)]
socket_wrapper: replace recvmsg() correctly

metze

9 years agosocket_wrapper: readv() should only work on connected sockets
Stefan Metzmacher [Sat, 30 Oct 2010 14:28:23 +0000 (16:28 +0200)]
socket_wrapper: readv() should only work on connected sockets

metze

9 years agosocket_wrapper: move swrap_ioctl() above the send*/recv* functions
Stefan Metzmacher [Sat, 30 Oct 2010 14:19:33 +0000 (16:19 +0200)]
socket_wrapper: move swrap_ioctl() above the send*/recv* functions

metze

9 years agosocket_wrapper: fix compiler warnings
Stefan Metzmacher [Wed, 2 Mar 2011 19:46:45 +0000 (20:46 +0100)]
socket_wrapper: fix compiler warnings

metze

9 years agosocket_wrapper: don't allow connect() to the broadcast address
Stefan Metzmacher [Sat, 30 Oct 2010 14:07:31 +0000 (16:07 +0200)]
socket_wrapper: don't allow connect() to the broadcast address

This will simplify other code later.

metze

9 years agos3: Use dom_sid_string_buf in sid_to_fstring
Volker Lendecke [Thu, 3 Mar 2011 16:02:40 +0000 (17:02 +0100)]
s3: Use dom_sid_string_buf in sid_to_fstring

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu Mar  3 22:56:57 CET 2011 on sn-devel-104

9 years agoAdd dom_sid_string_buf
Volker Lendecke [Thu, 3 Mar 2011 15:59:39 +0000 (16:59 +0100)]
Add dom_sid_string_buf

This prints into a fixed buffer with the same overflow semantics as snprintf
has: Return required string length, regardless of whether it fit or not.

9 years agos3: Use dom_sid_string in _lsa_lookup_sids_internal
Volker Lendecke [Thu, 3 Mar 2011 15:20:56 +0000 (16:20 +0100)]
s3: Use dom_sid_string in _lsa_lookup_sids_internal

9 years agos3: Remove an obsolete comment
Volker Lendecke [Thu, 3 Mar 2011 14:26:12 +0000 (15:26 +0100)]
s3: Remove an obsolete comment

9 years agos3: Fix some nonempty blank lines
Volker Lendecke [Thu, 3 Mar 2011 11:51:57 +0000 (12:51 +0100)]
s3: Fix some nonempty blank lines

9 years agolib/util: LIBCRYPTO is in common already, so add it to samba-util-common.
Günther Deschner [Thu, 3 Mar 2011 16:02:55 +0000 (17:02 +0100)]
lib/util: LIBCRYPTO is in common already, so add it to samba-util-common.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu Mar  3 18:08:30 CET 2011 on sn-devel-104

9 years agos3-includes: remove global include of system/readline.h.
Günther Deschner [Fri, 25 Feb 2011 15:18:33 +0000 (16:18 +0100)]
s3-includes: remove global include of system/readline.h.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Mar  2 23:06:17 CET 2011 on sn-devel-104

9 years agos3-proto: fix some inline comments.
Günther Deschner [Fri, 25 Feb 2011 23:28:38 +0000 (00:28 +0100)]
s3-proto: fix some inline comments.

Guenther

9 years agos3-libds: use already existing ../libds/common/flag_mapping.h header.
Günther Deschner [Fri, 25 Feb 2011 23:17:33 +0000 (00:17 +0100)]
s3-libds: use already existing ../libds/common/flag_mapping.h header.

Guenther

9 years agos3: Pass the aio_force operation through vfs_gpfs
Volker Lendecke [Fri, 25 Feb 2011 13:55:28 +0000 (06:55 -0700)]
s3: Pass the aio_force operation through vfs_gpfs

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Mar  2 19:24:27 CET 2011 on sn-devel-104

9 years agos3: Ask GPFS for the IS_OFFLINE operation
Volker Lendecke [Fri, 25 Feb 2011 13:50:19 +0000 (06:50 -0700)]
s3: Ask GPFS for the IS_OFFLINE operation

9 years agos3: Announce HSM in the gpfs module
Volker Lendecke [Fri, 25 Feb 2011 14:18:46 +0000 (07:18 -0700)]
s3: Announce HSM in the gpfs module

9 years agos3: Pass smb_filename through the set_offline vfs op
Volker Lendecke [Fri, 25 Feb 2011 13:43:52 +0000 (06:43 -0700)]
s3: Pass smb_filename through the set_offline vfs op

9 years agos3: Pass smb_filename through the is_offline vfs op
Volker Lendecke [Fri, 25 Feb 2011 13:37:34 +0000 (06:37 -0700)]
s3: Pass smb_filename through the is_offline vfs op

9 years agos3: Fix operation names in vfs_full_audit.c
Volker Lendecke [Fri, 25 Feb 2011 13:28:30 +0000 (06:28 -0700)]
s3: Fix operation names in vfs_full_audit.c

9 years agos3: Print all flags in "smbclient allinfo"
Volker Lendecke [Wed, 2 Mar 2011 16:55:31 +0000 (09:55 -0700)]
s3: Print all flags in "smbclient allinfo"

9 years agos4:torture/rap/rap.c - remove unused variable "i"
Matthias Dieter Wallnöfer [Wed, 2 Mar 2011 16:49:49 +0000 (17:49 +0100)]
s4:torture/rap/rap.c - remove unused variable "i"

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Wed Mar  2 18:38:58 CET 2011 on sn-devel-104

9 years agos3:idmap_cache: remove an leftover wip comment
Michael Adam [Wed, 2 Mar 2011 12:58:37 +0000 (13:58 +0100)]
s3:idmap_cache: remove an leftover wip comment

Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Wed Mar  2 14:55:20 CET 2011 on sn-devel-104

9 years agos3: adjust loglevel for idmap_cache
Gregor Beck [Tue, 1 Mar 2011 16:18:31 +0000 (17:18 +0100)]
s3: adjust loglevel for idmap_cache

Signed-off-by: Michael Adam <obnox@samba.org>
9 years agolibrpc/idl: remove unused string defines from idl_types.h
Stefan Metzmacher [Tue, 1 Mar 2011 15:44:22 +0000 (16:44 +0100)]
librpc/idl: remove unused string defines from idl_types.h

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Mar  2 14:09:44 CET 2011 on sn-devel-104

9 years agolibrpc/rpc: let ndr_pull_spoolss_EnumPrinterDataEx() use a subcontext
Stefan Metzmacher [Tue, 1 Mar 2011 16:41:27 +0000 (17:41 +0100)]
librpc/rpc: let ndr_pull_spoolss_EnumPrinterDataEx() use a subcontext

This is not strictly needed, but it's good to have the logic
in common with the other Enum* calls.

This also allows us to play with the NDR_RELATIVE_REVERSE flag.

metze

9 years agos3-sessionid: avoid global include of sessionid.h
Günther Deschner [Thu, 24 Feb 2011 22:14:15 +0000 (23:14 +0100)]
s3-sessionid: avoid global include of sessionid.h

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Mar  2 12:58:12 CET 2011 on sn-devel-104

9 years agos3-lanman: talk to srvsvc dcerpc server in api_RNetSessionEnum().
Günther Deschner [Fri, 25 Feb 2011 11:40:45 +0000 (12:40 +0100)]
s3-lanman: talk to srvsvc dcerpc server in api_RNetSessionEnum().

Guenther

9 years agos4-smbtorture: add netsessionenum rap torture test.
Günther Deschner [Wed, 2 Mar 2011 09:57:26 +0000 (10:57 +0100)]
s4-smbtorture: add netsessionenum rap torture test.

Guenther

9 years agos4-smbtorture: add smbcli_rap_netsessionenum().
Günther Deschner [Wed, 2 Mar 2011 09:53:24 +0000 (10:53 +0100)]
s4-smbtorture: add smbcli_rap_netsessionenum().

Guenther

9 years agorap: add rap_NetSessionEnum to IDL.
Günther Deschner [Wed, 2 Mar 2011 09:44:45 +0000 (10:44 +0100)]
rap: add rap_NetSessionEnum to IDL.

Guenther

9 years agos3-server_id: only include server_id where needed.
Günther Deschner [Thu, 24 Feb 2011 22:05:57 +0000 (23:05 +0100)]
s3-server_id: only include server_id where needed.

Guenther

9 years agos3: Attempt to fix the build on IRIX
Volker Lendecke [Wed, 2 Mar 2011 09:44:14 +0000 (10:44 +0100)]
s3: Attempt to fix the build on IRIX

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Mar  2 11:33:05 CET 2011 on sn-devel-104

9 years agos3: GPFS can't deal with mangled names
Volker Lendecke [Thu, 24 Feb 2011 09:50:46 +0000 (02:50 -0700)]
s3: GPFS can't deal with mangled names

In getrealfilename, avoid calling the GPFS function

9 years agobuild: fixed the ELF name for private libraries
Andrew Tridgell [Wed, 2 Mar 2011 00:40:33 +0000 (11:40 +1100)]
build: fixed the ELF name for private libraries

thanks to Simo and rpmbuild for spotting this!

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Wed Mar  2 02:49:34 CET 2011 on sn-devel-104

9 years agos4-dsdb: Ensure we permit multi-valued backlinks on single-valued attributes
Andrew Bartlett [Tue, 1 Mar 2011 11:47:33 +0000 (22:47 +1100)]
s4-dsdb: Ensure we permit multi-valued backlinks on single-valued attributes

This was already done in repl_meta_data, but it needs to be done here
as well to cope with Windows 2000 level links.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Wed Mar  2 02:03:58 CET 2011 on sn-devel-104

9 years agos3-printing: vfs_connect prior to driver/dfs IO
David Disseldorp [Tue, 1 Mar 2011 18:17:49 +0000 (19:17 +0100)]
s3-printing: vfs_connect prior to driver/dfs IO

samba3.posix_s3.rpc.spoolss.driver fails with the xattr_tdb vfs module
loaded as a part of make test. The (now checked) create_directory() call
in move_driver_to_download_area() fails, uncovering another bug in the
printer driver upload code path.

move_driver_to_download_area() creates a new conn_struct for
manipulating files in [print$]. The VFS layer is plumbed through with
the call to create_conn_struct(), however SMB_VFS_CONNECT() is never
called. Many vfs modules expect state stored at connect time with
SMB_VFS_HANDLE_SET_DATA() to be available on any IO operation and fail
if this is not the case.

This fix adds a call to SMB_VFS_CONNECT() in create_conn_struct() prior
to IO.

https://bugzilla.samba.org/show_bug.cgi?id=7976

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Mar  2 01:16:30 CET 2011 on sn-devel-104

9 years agos3-printing: clean up get_correct_cversion error paths
David Disseldorp [Tue, 1 Mar 2011 18:17:48 +0000 (19:17 +0100)]
s3-printing: clean up get_correct_cversion error paths

Remove an unneeded variable and simplify error paths.

9 years agos3-printing: fix move_driver_to_download_area() error paths
David Disseldorp [Tue, 1 Mar 2011 18:17:47 +0000 (19:17 +0100)]
s3-printing: fix move_driver_to_download_area() error paths

WERR_ACCESS_DENIED errors are mapped to WERR_UNKNOWN_PRINTER_DRIVER,
resulting in incorrect error messages on Windows clients.

move_driver_to_download_area() returns the same error status values
to the caller via the *perr argument as well as the return value.

The create_directory() call is not checked for error.

9 years agos3: remove superfluous debug messages from msg_idmap
Gregor Beck [Tue, 1 Mar 2011 16:20:16 +0000 (17:20 +0100)]
s3: remove superfluous debug messages from msg_idmap

Signed-off-by: Michael Adam <obnox@samba.org>
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Wed Mar  2 00:30:41 CET 2011 on sn-devel-104

9 years agoRevert "examples/LDAP: remove overoutdated samba-schema.IBMSecureWay"
Björn Jacke [Tue, 1 Mar 2011 21:55:39 +0000 (22:55 +0100)]
Revert "examples/LDAP: remove overoutdated samba-schema.IBMSecureWay"

This reverts commit 90b0f86d81d4c68bf326c3e7c2247d9dabd75058.

this isn't that outdated at all. Got confused by the splitted oc/at files

Autobuild-User: Björn Jacke <bj@sernet.de>
Autobuild-Date: Tue Mar  1 23:43:51 CET 2011 on sn-devel-104

9 years agoexamples/LDAP: remove overoutdated samba-schema.IBMSecureWay
Björn Jacke [Tue, 1 Mar 2011 21:46:53 +0000 (22:46 +0100)]
examples/LDAP: remove overoutdated samba-schema.IBMSecureWay

9 years agoexamples/LDAP: delete unmaintained samba-schema-netscapeds4.x
Björn Jacke [Tue, 1 Mar 2011 21:38:35 +0000 (22:38 +0100)]
examples/LDAP: delete unmaintained samba-schema-netscapeds4.x

9 years agolibds/common/flag_mapping.c - fix another build dependency
Sean Finney [Tue, 1 Mar 2011 17:07:18 +0000 (18:07 +0100)]
libds/common/flag_mapping.c - fix another build dependency

Signed-off-by: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Tue Mar  1 18:53:40 CET 2011 on sn-devel-104

9 years agos4:drsuapi RPC server - this resembles more "samdb_is_gc"
Matthias Dieter Wallnöfer [Tue, 1 Mar 2011 13:06:23 +0000 (14:06 +0100)]
s4:drsuapi RPC server - this resembles more "samdb_is_gc"

Reviewed by: Jelmer

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Tue Mar  1 17:57:47 CET 2011 on sn-devel-104

9 years agolibrpc/ndr: handle NOALIGN flag for relative pointers and alignment DATA_BLOBs
Stefan Metzmacher [Tue, 1 Mar 2011 13:20:32 +0000 (14:20 +0100)]
librpc/ndr: handle NOALIGN flag for relative pointers and alignment DATA_BLOBs

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Tue Mar  1 17:11:03 CET 2011 on sn-devel-104

9 years agos4:netlogon RPC server - "LogonGetDomainInfo" - check for NULL attributes
Matthias Dieter Wallnöfer [Tue, 1 Mar 2011 12:06:19 +0000 (13:06 +0100)]
s4:netlogon RPC server - "LogonGetDomainInfo" - check for NULL attributes

This is needed to complete the transition from "samdb_msg_add_string" to
"ldb_msg_add_string".
And this patch yields better NTSTATUS error results than before
(INVALID_PARAMETER rather than OUT_OF_MEMORY).

Reviewed-by: Jelmer
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Tue Mar  1 14:42:15 CET 2011 on sn-devel-104

9 years agos4:drsuapi RPC server - check for the "SPN" attribute != NULL
Matthias Dieter Wallnöfer [Tue, 1 Mar 2011 12:03:59 +0000 (13:03 +0100)]
s4:drsuapi RPC server - check for the "SPN" attribute != NULL

The SPN attribute could derive from an untrusted source (client).

Reviewed-by: Jelmer
9 years agos4:dsdb - always handle the attribute "options" as 32bit unsigned integer
Matthias Dieter Wallnöfer [Tue, 1 Mar 2011 10:40:23 +0000 (11:40 +0100)]
s4:dsdb - always handle the attribute "options" as 32bit unsigned integer

It is defined as LDAP syntax 2.5.5.9 so no need at all to treat it as
64-bit integer.

Reviewed by: Kamenim and Metze

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Tue Mar  1 12:46:15 CET 2011 on sn-devel-104

9 years agolibcli/security Add unix_token and unix_info to auth_session_info too
Andrew Bartlett [Sat, 12 Feb 2011 00:21:03 +0000 (11:21 +1100)]
libcli/security Add unix_token and unix_info to auth_session_info too

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Tue Mar  1 07:13:43 CET 2011 on sn-devel-104

9 years agos3-auth struct security_unix_token replaces UNIX_USER_TOKEN
Andrew Bartlett [Fri, 11 Feb 2011 07:49:15 +0000 (18:49 +1100)]
s3-auth struct security_unix_token replaces UNIX_USER_TOKEN

9 years agolibrpc/idl Add helper structures for use by samba3 in auth_session_info
Andrew Bartlett [Fri, 11 Feb 2011 07:47:21 +0000 (18:47 +1100)]
librpc/idl Add helper structures for use by samba3 in auth_session_info

The unix info and in particular unix token needs to be preserved into
the struct auth_session_info.

Andrew Bartlett

9 years agopidl Add support for uid_t and gid_t types
Andrew Bartlett [Fri, 11 Feb 2011 07:45:32 +0000 (18:45 +1100)]
pidl Add support for uid_t and gid_t types

These are mapped to uint64_t, which should be big enough.  This is
proposed to be used for internal Samba representations, where it would
be more painful to convert all the callers to an uint64_t calling
convention.

Andrew Bartlett

9 years agos3-rpc_server Handle session key as a constant buffer
Andrew Bartlett [Thu, 10 Feb 2011 10:37:51 +0000 (21:37 +1100)]
s3-rpc_server Handle session key as a constant buffer

This way, we don't have to check for memory allocation failures.

Andrew Bartlett

9 years agos4:dsdb/common/util.c - remove "samdb_find_or_add_value"
Matthias Dieter Wallnöfer [Wed, 23 Feb 2011 09:18:03 +0000 (10:18 +0100)]
s4:dsdb/common/util.c - remove "samdb_find_or_add_value"

This isn't used anymore.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
9 years agos4:dsdb/common/util.c - fully remove "samdb_msg_add_string"
Matthias Dieter Wallnöfer [Wed, 23 Feb 2011 09:13:56 +0000 (10:13 +0100)]
s4:dsdb/common/util.c - fully remove "samdb_msg_add_string"

This isn't needed anymore and will be substituted by
"ldb_msg_add_string".

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
9 years agos4:libnet/libnet_samsync_ldb.c - add a "samdb_msg_add_string" wrapper
Matthias Dieter Wallnöfer [Wed, 23 Feb 2011 09:24:34 +0000 (10:24 +0100)]
s4:libnet/libnet_samsync_ldb.c - add a "samdb_msg_add_string" wrapper

Add this in order to allow the "ADD_OR_DEL" macros to work.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
9 years agos4:remove many invocations of "samdb_msg_add_string"
Matthias Dieter Wallnöfer [Thu, 14 Oct 2010 20:26:44 +0000 (22:26 +0200)]
s4:remove many invocations of "samdb_msg_add_string"

This call can be substituted by "ldb_msg_add_string". We only need to be
careful on local objects or talloc'ed ones which live shorter than the message.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
9 years agoautobuild: enabled samba3-waf build
Andrew Tridgell [Tue, 1 Mar 2011 00:53:49 +0000 (01:53 +0100)]
autobuild: enabled samba3-waf build

this is just a build check for now. See the mailing list discussion.

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Tue Mar  1 06:22:07 CET 2011 on sn-devel-104

9 years agolib/util: new merged debug system
Andrew Bartlett [Thu, 24 Feb 2011 05:14:03 +0000 (16:14 +1100)]
lib/util: new merged debug system

This is the s3 debug system, with a number of changes to tidy it up
for common use.  The debug class system is simplified by the removal of the
ISSET table, the system no longer attempts to cope with assignment of
DEBUGLEVEL, and the full class table is always available (rather than
just DEBUGLEVEL_CLASS[DBCG_ALL]) from startup.  It is also no longer
confusingly described as a hack, but as the initial table.

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Tue Mar  1 04:32:12 CET 2011 on sn-devel-104

9 years agolib/util move debug.[ch] out of the way
Andrew Bartlett [Mon, 28 Feb 2011 20:40:22 +0000 (07:40 +1100)]
lib/util move debug.[ch] out of the way

This will allow a modified version of the s3 debug system to be the
new common debug system.

Andrew Bartlett

9 years agos4-libnet_vampire: Ignore some attributes when building working schema cache
Kamen Mazdrashki [Tue, 1 Mar 2011 00:32:19 +0000 (02:32 +0200)]
s4-libnet_vampire: Ignore some attributes when building working schema cache

Working schema cache will be used to convert replicated Schema objects
again later, i.e. used as reference, so we don't need to resolve all
attribute OIDs for working Schema cache to be usable.

Autobuild-User: Kamen Mazdrashki <kamenim@samba.org>
Autobuild-Date: Tue Mar  1 03:45:16 CET 2011 on sn-devel-104

9 years agos4-repl/working_schema: Ignore some attributes when bulding working schema cache
Kamen Mazdrashki [Tue, 1 Mar 2011 00:30:12 +0000 (02:30 +0200)]
s4-repl/working_schema: Ignore some attributes when bulding working schema cache

We don't need all object attributes resolved and converted for a working
schema to be functional.

9 years agos4-replicated_objects: Implement a mechanism to relax some attributes conversion
Kamen Mazdrashki [Tue, 1 Mar 2011 00:25:24 +0000 (02:25 +0200)]
s4-replicated_objects: Implement a mechanism to relax some attributes conversion

during replicated object convert stage.
The problem is that we may have loops in schema graph and we can't
resolve those loops in just one pass. Ignoring some attributes
conversion will allow us to have a functional schema cache that we
can use later to resolve all attribute OIDs on another pass

9 years agos3-debug Always use C99 true/false rather than True and False
Andrew Bartlett [Mon, 28 Feb 2011 21:52:25 +0000 (08:52 +1100)]
s3-debug Always use C99 true/false rather than True and False

This will help with the merge into the common code.

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Tue Mar  1 02:58:55 CET 2011 on sn-devel-104

9 years agos3-build __FUNCTION__ is always available, always use it
Andrew Bartlett [Mon, 28 Feb 2011 13:46:30 +0000 (00:46 +1100)]
s3-build __FUNCTION__ is always available, always use it

This avoids duplication between FUNCTION_NAME and __FUNCTION__

9 years agolib/util/time: Merge time functions from source3/lib/time.c
Andrew Bartlett [Tue, 22 Feb 2011 06:59:51 +0000 (17:59 +1100)]
lib/util/time: Merge time functions from source3/lib/time.c

9 years agospoolss.idl: align spoolss_DriverFileInfo relative pointer to 4 byte
Stefan Metzmacher [Tue, 22 Feb 2011 14:56:30 +0000 (15:56 +0100)]
spoolss.idl: align spoolss_DriverFileInfo relative pointer to 4 byte

metze

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Tue Mar  1 02:12:37 CET 2011 on sn-devel-104

9 years agospoolss.idl: align spoolss_PrinterEnumValues 'data' based on the type
Stefan Metzmacher [Tue, 22 Feb 2011 18:23:33 +0000 (19:23 +0100)]
spoolss.idl: align spoolss_PrinterEnumValues 'data' based on the type

metze

9 years agoTODO test/review librpc/ndr: remove align2 hack for relative pointers
Stefan Metzmacher [Tue, 22 Feb 2011 14:58:45 +0000 (15:58 +0100)]
TODO test/review librpc/ndr: remove align2 hack for relative pointers

metze

9 years agoTODO test/review librpc: align nstring and nstring_array to 2 byte
Stefan Metzmacher [Tue, 22 Feb 2011 14:57:21 +0000 (15:57 +0100)]
TODO test/review librpc: align nstring and nstring_array to 2 byte

metze

9 years agolibrpc/ndr: ndr align relative pointers based on the given flags
Stefan Metzmacher [Tue, 22 Feb 2011 14:45:44 +0000 (15:45 +0100)]
librpc/ndr: ndr align relative pointers based on the given flags

We used to do this only for the reverse relative pointers
and now we always do it.

metze

9 years agoTODO test/review librpc/ndr: let ndr_push/pull_DATA_BLOB() look at LIBNDR_FLAG_REMAIN...
Stefan Metzmacher [Tue, 22 Feb 2011 17:19:13 +0000 (18:19 +0100)]
TODO test/review librpc/ndr: let ndr_push/pull_DATA_BLOB() look at LIBNDR_FLAG_REMAINING before LIBNDR_ALIGN_FLAGS

metze

9 years agoRevert "Fix alignment issues in SPOOLSS "BUFFER" marshalling."
Stefan Metzmacher [Tue, 22 Feb 2011 10:00:07 +0000 (11:00 +0100)]
Revert "Fix alignment issues in SPOOLSS "BUFFER" marshalling."

This reverts commit 187f695469071d0550613e037b36170facb85460.

This is the wrong fix.

metze