nivanova/samba-autobuild/.git
16 years agoMake usage message for net sam rights list a little more precise.
Michael Adam [Mon, 17 Dec 2007 10:57:14 +0000 (11:57 +0100)]
Make usage message for net sam rights list a little more precise.

Michael
(This used to be commit d466a5136d5151e2a3cae7464cb346f0db650554)

16 years agoFix for bug #4801: Correctly implement lsa lookup levels for lookupnames.
Michael Adam [Wed, 12 Dec 2007 17:03:20 +0000 (18:03 +0100)]
Fix for bug #4801: Correctly implement lsa lookup levels for lookupnames.

This patch is still incomplete in that winbindd does not walk
the the trusted domains to lookup unqualified names here.
Apart from that this fix should be pretty much complete.

Michael
(This used to be commit f7efc0eca9426e63b751c07a90265a12bb39cf95)

16 years agoFix flags in caller of lookup_name() in create_builtin_administrators().
Michael Adam [Mon, 17 Dec 2007 09:54:05 +0000 (10:54 +0100)]
Fix flags in caller of lookup_name() in create_builtin_administrators().

Michael
(This used to be commit 46bfbf5c8af6c030e67219a29c49fd2d40003b18)

16 years agoFix flags in all callers of lookup_name() in net_sam.c.
Michael Adam [Mon, 17 Dec 2007 10:55:05 +0000 (11:55 +0100)]
Fix flags in all callers of lookup_name() in net_sam.c.

Michael
(This used to be commit 6d0db17a9e255235d40eabc63e91c9f5d4febcde)

16 years agoFix flags in call of lookup_name() in srv_samr_nt.c: can_create().
Michael Adam [Mon, 17 Dec 2007 10:32:21 +0000 (11:32 +0100)]
Fix flags in call of lookup_name() in srv_samr_nt.c: can_create().

Use LOOKUP_NAME_LOCAL instead of LOOKUP_NAME_ISOLATED.

Michael
(This used to be commit 1d4e0ad1142c61de402c925306f02f5de2c872f6)

16 years agoFix flags in call of lookup_name() in pdb_default_create_alias().
Michael Adam [Mon, 17 Dec 2007 09:55:37 +0000 (10:55 +0100)]
Fix flags in call of lookup_name() in pdb_default_create_alias().

Use new flag LOOKUP_NAME_LOCAL.

Michael
(This used to be commit 280d6cb6c8e834ce0a08769e9187b0f40321716f)

16 years agoAdd combined flag LOOKUP_NAME_LOCAL.
Michael Adam [Mon, 17 Dec 2007 10:28:56 +0000 (11:28 +0100)]
Add combined flag LOOKUP_NAME_LOCAL.

Presence of LOOKUP_NAME_ISOLATED as the only flag is not the sign
for doing local lookups only but the sign for allowing lookups
of unqualified names. The correct sign is absence of the flag
LOOKUP_NAME_REMOTE.

Michael
(This used to be commit cd8c0057446a1311a860f6cc3876a113568f6c30)

16 years agoRemove t_doschar.c
Volker Lendecke [Mon, 17 Dec 2007 06:18:30 +0000 (07:18 +0100)]
Remove t_doschar.c
(This used to be commit b89f87242b9c949401f3fa9b352211906cb76895)

16 years agoRemove another static string and static passwd.
Jeremy Allison [Mon, 17 Dec 2007 02:32:03 +0000 (18:32 -0800)]
Remove another static string and static passwd.
Jeremy.
(This used to be commit 2a700c5a57a417add3b1975b2c396d20c8a5f301)

16 years agoRemove a static fstring.
Jeremy Allison [Mon, 17 Dec 2007 02:02:32 +0000 (18:02 -0800)]
Remove a static fstring.
Jeremy.
(This used to be commit 898c56c0ead6331721de9645ce55608cbe7cf34d)

16 years agoget rid of doschar_table[]
Volker Lendecke [Sat, 15 Dec 2007 23:25:49 +0000 (00:25 +0100)]
get rid of doschar_table[]

If I'm not completely blind, then check_dos_char is *only* used in the case
when we can't mmap() valid.dat. To me this looks as if we initialize the 65536
bits in doschar_table[] with check_dos_char_slowly, use it once to initialize
valid_table[] and *never* use them again. I think there's no point in keeping
these 8k of modified memory around for an unlikely case (no "valid.dat") and
even that only to use it exactly once.
(This used to be commit 0bfea7259e4091c6d914528a0e65fc10d8a56fb8)

16 years agoTiny fixes to init_valid_table()
Volker Lendecke [Sat, 15 Dec 2007 23:19:42 +0000 (00:19 +0100)]
Tiny fixes to init_valid_table()
(This used to be commit a8948e0727b100945ab730d4d144ccbe219bbc94)

16 years agoMake init_doschar_table() static
Volker Lendecke [Sat, 15 Dec 2007 23:17:41 +0000 (00:17 +0100)]
Make init_doschar_table() static

It's only called directly before init_valid_table() anyway, so move it there.
(This used to be commit b6d1d2428866712a550a354732e2386b4f87b67b)

16 years agoMake check_dos_char static
Volker Lendecke [Sat, 15 Dec 2007 23:15:34 +0000 (00:15 +0100)]
Make check_dos_char static

It's only called in t_doschar, a pretty bogus test program that is not compiled
by default
(This used to be commit 99c59e809ef3c5abcdfb796d50be7c40f7033787)

16 years agomake use of unmarshall_sec_desc
Volker Lendecke [Sun, 16 Dec 2007 13:15:16 +0000 (14:15 +0100)]
make use of unmarshall_sec_desc
(This used to be commit ced0c42f055a672f6b4ab6ba809b0f63c83b431e)

16 years agomake use of [un]marshall_sec_desc, allow for fd==-1 in get/set_secdesc
Volker Lendecke [Sun, 25 Nov 2007 17:26:52 +0000 (18:26 +0100)]
make use of [un]marshall_sec_desc, allow for fd==-1 in get/set_secdesc
(This used to be commit 585f5f8831f13260808a82611656fc6ca5caee81)

16 years agoCut down memory usage of registry initialization
Volker Lendecke [Thu, 13 Dec 2007 21:20:58 +0000 (22:20 +0100)]
Cut down memory usage of registry initialization
(This used to be commit 264d5dfe9fe97db0b69d7cd04086ad8ed9f78e74)

16 years agoRemove a static fstring
Volker Lendecke [Sat, 15 Dec 2007 23:03:56 +0000 (00:03 +0100)]
Remove a static fstring
(This used to be commit a9c62c57db9e580640d0265b08b3178496de76a8)

16 years agoMake smb_np_struct talloc'ed
Volker Lendecke [Sun, 16 Dec 2007 11:58:07 +0000 (12:58 +0100)]
Make smb_np_struct talloc'ed

Convert "name" from string to a talloc'ed char *
(This used to be commit e82069f921b3a22295db91e092c22c459ccd7215)

16 years agoRemove unused code
Volker Lendecke [Sun, 16 Dec 2007 11:57:06 +0000 (12:57 +0100)]
Remove unused code
(This used to be commit fcd45ad6fb8d89bf6106fbed101060dbe422661a)

16 years agoDoh, fix typo in error exit.
Jeremy Allison [Sun, 16 Dec 2007 07:32:28 +0000 (23:32 -0800)]
Doh, fix typo in error exit.
Jeremy.
(This used to be commit 44918f39c0598eec681eb9e5c65452f04809c375)

16 years agoAdded patch originally by Andreas Schneider <anschneider@suse.de>
Jeremy Allison [Sun, 16 Dec 2007 07:22:25 +0000 (23:22 -0800)]
Added patch originally by Andreas Schneider <anschneider@suse.de>
to cause us to behave like Vista when looking for remote
machine principal. Modified by me.
Jeremy.
(This used to be commit d0e33840fb4cfc85990d3ee327428b0854a22722)

16 years agoCope with valgrind > 3.2.x.
Jeremy Allison [Sun, 16 Dec 2007 07:05:30 +0000 (23:05 -0800)]
Cope with valgrind > 3.2.x.
Jeremy.
(This used to be commit e799eb8da6f5e7a2173ba6b8fb040430fd1c6f34)

16 years agoMore work on bug #5082, use LC_ALL as this takes
Jeremy Allison [Sun, 16 Dec 2007 06:28:38 +0000 (22:28 -0800)]
More work on bug #5082, use LC_ALL as this takes
precedence.
Jeremy.
(This used to be commit 446ebae76d6796b30e4c71ff7190337c28637be6)

16 years agos/sid_to_string/sid_to_fstring/
Volker Lendecke [Sat, 15 Dec 2007 21:47:30 +0000 (22:47 +0100)]
s/sid_to_string/sid_to_fstring/

least surprise for callers
(This used to be commit eb523ba77697346a365589101aac379febecd546)

16 years agoUse dom_sid_string for sid_string_talloc
Volker Lendecke [Sat, 15 Dec 2007 21:33:52 +0000 (22:33 +0100)]
Use dom_sid_string for sid_string_talloc

Remove some code duplication, but introduce one more dependency on librpc/ndr.
Easily turned around so that librpc/ndr depends on lib/util_sid if necessary
(This used to be commit 3a0b1b2060facd5f1ac1461b23dd86c75cdd9458)

16 years agosid_string_static is no more :-)
Volker Lendecke [Sat, 15 Dec 2007 21:08:09 +0000 (22:08 +0100)]
sid_string_static is no more :-)

We now have four ways to do sid_to_string:

sid_to_string: Convert it into an existing fstring, when you have one

sid_string_talloc: The obvious thing

sid_string_tos: For the lazy, use only with care

sid_string_dbg: The one to use in DEBUG statements
(This used to be commit 7b8276aaa48852270c6b70b081c3f28e316a7a2c)

16 years agoReplace sid_string_static with sid_to_string
Volker Lendecke [Sat, 15 Dec 2007 21:00:39 +0000 (22:00 +0100)]
Replace sid_string_static with sid_to_string

This adds 28 fstrings on the stack, but I think an fstring on the stack is
still far better than a static one.
(This used to be commit c7c885078be8fd3024c186044ac28275d7609679)

16 years agoUse sid_to_string directly
Volker Lendecke [Sat, 15 Dec 2007 20:58:28 +0000 (21:58 +0100)]
Use sid_to_string directly

It seems a bit pointless to do a fstrcpy(dst, sid_string_static(src))
(This used to be commit c221c246b10e2dbbd54a9af2dc45de2eae237380)

16 years agoReplace sid_string_static with sid_string_tos
Volker Lendecke [Sat, 15 Dec 2007 20:53:26 +0000 (21:53 +0100)]
Replace sid_string_static with sid_string_tos

In utils/ I was a bit lazy...
(This used to be commit 60e830b0f4571bd5d9039f2edd199534f2a4c341)

16 years agoUse sid_string_talloc where we have a tmp talloc ctx
Volker Lendecke [Sat, 15 Dec 2007 20:49:15 +0000 (21:49 +0100)]
Use sid_string_talloc where we have a tmp talloc ctx
(This used to be commit 0a911d38b8f4be382a9df60f9c6de0c500464b3a)

16 years agoReplace sid_string_static by sid_string_dbg in DEBUGs
Volker Lendecke [Sat, 15 Dec 2007 20:11:36 +0000 (21:11 +0100)]
Replace sid_string_static by sid_string_dbg in DEBUGs
(This used to be commit bb35e794ec129805e874ceba882bcc1e84791a09)

16 years agoAdd sid_string_dbg
Volker Lendecke [Sat, 15 Dec 2007 20:06:20 +0000 (21:06 +0100)]
Add sid_string_dbg

This makes use of the just added debug_ctx and will kill many
sid_string_static() calls
(This used to be commit 3e4148c280efe154c3f8d552731c8b29d6977507)

16 years agoAdd debug_ctx according to an idea by Tridge
Volker Lendecke [Sat, 15 Dec 2007 20:05:11 +0000 (21:05 +0100)]
Add debug_ctx according to an idea by Tridge

Sorry, Jeremy, I think for debug messages this is just the right way to do it.
(This used to be commit 6312016e2727c2b5b1a4964a98cfb9585d77cc8c)

16 years agoUse sid_string_talloc where we have a tmp talloc ctx
Volker Lendecke [Sat, 15 Dec 2007 20:10:58 +0000 (21:10 +0100)]
Use sid_string_talloc where we have a tmp talloc ctx
(This used to be commit f00ab810d2540679bec109498ac89e1eafe18f03)

16 years agoadd sid_string_talloc
Volker Lendecke [Sat, 15 Dec 2007 18:00:42 +0000 (19:00 +0100)]
add sid_string_talloc
(This used to be commit 9e3ef0923d71cc06b8445be2625ebd8dfed1b42d)

16 years agoFix a segfault
Volker Lendecke [Sat, 15 Dec 2007 10:38:28 +0000 (11:38 +0100)]
Fix a segfault

sid_to_string still expects a fstring
(This used to be commit 1f352cdd1976ad36484e146165df585b88ec5527)

16 years agoFix for bug #5082 from Mathias Gug <mathiaz@ubuntu.com>, Steve Langasek <vorlon@debia...
Jeremy Allison [Sat, 15 Dec 2007 01:02:50 +0000 (17:02 -0800)]
Fix for bug #5082 from Mathias Gug <mathiaz@ubuntu.com>, Steve Langasek <vorlon@debian.org>.
Recent versions of Linux-PAM support localization of user prompts,
so Samba must use the C locale when invoking PAM (directly or via
/usr/bin/passwd) to ensure that password chat values match the prompts in a
locale-invariant fashion.
Jeremy.
(This used to be commit bc13e939546a5bcb78925a6b117e89fde20f6451)

16 years agoselftest: reenable wbinfo tests and pass --configfile instead of -s
Stefan Metzmacher [Fri, 14 Dec 2007 18:39:49 +0000 (19:39 +0100)]
selftest: reenable wbinfo tests and pass --configfile instead of -s

metze
(This used to be commit 56251f78524416435299e26fca405e77d0f42043)

16 years agowbinfo: use POPT_COMMON_CONFIGFILE
Stefan Metzmacher [Fri, 14 Dec 2007 18:38:23 +0000 (19:38 +0100)]
wbinfo: use POPT_COMMON_CONFIGFILE

We can't use POPT_COMMON_SAMBA as the -s option is
already used by -s, --sid-to-name=SID.

Also load the config file after processing the cmdline options

metze
(This used to be commit 33cbd6903e8b468a782fb5d6913eb82824d3b347)

16 years agoadd POPT_COMMON_CONFIGFILE which only provides --configfile (not -s)
Stefan Metzmacher [Fri, 14 Dec 2007 18:36:14 +0000 (19:36 +0100)]
add POPT_COMMON_CONFIGFILE which only provides --configfile (not -s)

metze
(This used to be commit af3392cc20942158ac9e0a533799c5904ff23347)

16 years agoselftest: disable wbinfo tests
Stefan Metzmacher [Fri, 14 Dec 2007 17:02:05 +0000 (18:02 +0100)]
selftest: disable wbinfo tests

wbinfo needs to take --config-file to work...

metze
(This used to be commit a8a74fc88cb6f4be1efdc1afab9b91defcd015ae)

16 years agoselftest: add a bunch of wbinfo based tests for winbindd
Stefan Metzmacher [Fri, 14 Dec 2007 15:54:01 +0000 (16:54 +0100)]
selftest: add a bunch of wbinfo based tests for winbindd

metze
(This used to be commit 88b6d2c0e83f515e2f83e5b4edc0728c434c7294)

16 years agoselftest: move workgroup name into WORKGROUP envvar
Stefan Metzmacher [Fri, 14 Dec 2007 15:14:32 +0000 (16:14 +0100)]
selftest: move workgroup name into WORKGROUP envvar

metze
(This used to be commit 8ace8fa82c2ccd6fdb9ca076fb2d6fed203c8126)

16 years agoRevert smbclient changes.
Karolin Seeger [Fri, 14 Dec 2007 11:02:49 +0000 (12:02 +0100)]
Revert smbclient changes.

Patch broke option -p.
Sorry for breaking the build!

Karolin
(This used to be commit 81dab4145ffaf21d5d2176b16b5989f4035dd791)

16 years agoMake smbclient to display error message and usage in the case of invalid options.
Karolin Seeger [Fri, 14 Dec 2007 09:52:31 +0000 (10:52 +0100)]
Make smbclient to display error message and usage in the case of invalid options.
(This used to be commit 04131b26de08b3cea948ef89921c56561d69dd1d)

16 years agowinbindd: move domain child specific stuff into its own file
Stefan Metzmacher [Thu, 13 Dec 2007 11:27:57 +0000 (12:27 +0100)]
winbindd: move domain child specific stuff into its own file

metze
(This used to be commit 075d315e0f72d506b70040da10940e4af131b4e2)

16 years agoRevert "Fix for bug #4801: Correctly implement lsa lookup levels for lookupnames."
Stefan Metzmacher [Fri, 14 Dec 2007 06:47:07 +0000 (07:47 +0100)]
Revert "Fix for bug #4801: Correctly implement lsa lookup levels for lookupnames."

As it breaks all tests which try to join a new machine account.
So more testing is needed...

metze

This reverts commit dd320c0924ce393a89b1cab020fd5cffc5b80380.
(This used to be commit cccb80b7b7980fbe1298ce266375e51bacb4a425)

16 years agodebug: fix crash bug when DEBUG() is used before setup_logging()
Stefan Metzmacher [Fri, 14 Dec 2007 07:21:59 +0000 (08:21 +0100)]
debug: fix crash bug when DEBUG() is used before setup_logging()

this was introduced by the pstring removal
(1ea3ac80146b83c2522b69e7747c823366a2b47d)

metze
(This used to be commit a412e6c7c676a054acd9db371221a50078cfe1d9)

16 years agoMove dns_sd.h include to fix the build.
James Peach [Fri, 14 Dec 2007 06:12:21 +0000 (22:12 -0800)]
Move dns_sd.h include to fix the build.
(This used to be commit cf221a94bd8794add508a2b9305b8c0d40c3346a)

16 years agoMerge branch 'v3-2-test' of git://git.samba.org/samba into v3-2-test
James Peach [Fri, 14 Dec 2007 04:56:53 +0000 (20:56 -0800)]
Merge branch 'v3-2-test' of git://git.samba.org/samba into v3-2-test
(This used to be commit 0de2b3eb515f2da21ffd1ce54979bb1f8063024b)

16 years agoRegister the smb service with mDNS if mSDN is supported.
Rishi Srivatsavai [Fri, 14 Dec 2007 04:56:29 +0000 (20:56 -0800)]
Register the smb service with mDNS if mSDN is supported.

If mDNS is supported, attempt to register the first port we are
listening on for the _smb._tcp service. This provides more reliable
service discovery than NetBIOS browsing.
(This used to be commit 1e7241517d1f55d60af22570e0c9feb280e3fdb5)

16 years agoWe don't need to call endpwent if we never call getpwent.
Jeremy Allison [Fri, 14 Dec 2007 01:25:26 +0000 (17:25 -0800)]
We don't need to call endpwent if we never call getpwent.
Jeremy.
(This used to be commit 27078d1292e8588956ae78e4cddb1bcebbe84478)

16 years agoAdd a varient of Steve Langasek <vorlon@debian.org> patch
Jeremy Allison [Fri, 14 Dec 2007 01:18:48 +0000 (17:18 -0800)]
Add a varient of Steve Langasek <vorlon@debian.org> patch
for bug #4780. Cause user mounts to inherit uid= and gid= from the
calling user when called as non-root, except when overridden on the
commandline.
Jeremy.
(This used to be commit 7fad5f38ea86ef76dc8e0853926b3248230616be)

16 years agoMerge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test
Jeremy Allison [Fri, 14 Dec 2007 00:46:42 +0000 (16:46 -0800)]
Merge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test
(This used to be commit c9496e97cf91c5f29f19c123377f03f44d1a32f6)

16 years agoArg. The fix for CVE-2007-6015 hadn't been merged into 3.2.
Jeremy Allison [Fri, 14 Dec 2007 00:44:24 +0000 (16:44 -0800)]
Arg. The fix for CVE-2007-6015 hadn't been merged into 3.2.
Do so now....
Jeremy.
(This used to be commit 6b1246c29a0241c8e4bb98d659d847d010826b36)

16 years agoFix typo in debug statement.
Michael Adam [Thu, 13 Dec 2007 13:38:05 +0000 (14:38 +0100)]
Fix typo in debug statement.

Michael
(This used to be commit da23684261f40c06dea30ab2df0c878ebb0d0d81)

16 years agoFix codepagedir to follow predefined libdir when using FHS. Fixes x86_64 build.
Alexander Bokovoy [Thu, 13 Dec 2007 11:23:04 +0000 (14:23 +0300)]
Fix codepagedir to follow predefined libdir when using FHS. Fixes x86_64 build.
(This used to be commit b8e582c9941d2466a403e476c52026f4b4201062)

16 years agoMerge branch 'v3-2-test' of ssh://git.samba.org/data/git/samba into v3-2-test
Alexander Bokovoy [Thu, 13 Dec 2007 09:57:24 +0000 (12:57 +0300)]
Merge branch 'v3-2-test' of ssh://git.samba.org/data/git/samba into v3-2-test
(This used to be commit 45636efa39cbcc2ecf7af4dfd1ac6a90f197ba01)

16 years agoFix pam_smbpass build
Alexander Bokovoy [Thu, 13 Dec 2007 09:55:32 +0000 (12:55 +0300)]
Fix pam_smbpass build
(This used to be commit fbc510f1717fe82338262c18c252d18987c55b5c)

16 years agoAdd flags for correctly implementing lsa_lookup_name levels.
Michael Adam [Wed, 28 Nov 2007 01:15:37 +0000 (02:15 +0100)]
Add flags for correctly implementing lsa_lookup_name levels.

(Prepare fix for Bug #4801.)

Michael
(This used to be commit 537b12647e25adcb7da3581f18d2e9feca1caf0c)

16 years agoMake cm_connect_sam() try harder to connect autheticated.
Michael Adam [Tue, 11 Dec 2007 15:34:39 +0000 (16:34 +0100)]
Make cm_connect_sam() try harder to connect autheticated.

Even if the session setup was anonymous, try and collect
trust creds with get_trust_creds() and use these before
falling back to schannel.

This is the first attempt to fix interdomain trusts.
(get password policy and stuff)

Michael
(This used to be commit e180bbd45452435e981192028a0ad90078c04236)

16 years agoRefactor out assembling of trust creds (pw, account name, principal).
Michael Adam [Tue, 11 Dec 2007 15:32:38 +0000 (16:32 +0100)]
Refactor out assembling of trust creds (pw, account name, principal).

Michael
(This used to be commit 481f18b20d6d5ee12c62120a3559bb16cc98e465)

16 years agoStreamline and fix logic of cm_prepare_connection().
Michael Adam [Tue, 11 Dec 2007 14:39:36 +0000 (15:39 +0100)]
Streamline and fix logic of cm_prepare_connection().

Do not attempt to do a session setup when in a trusted domain
situation (this gives STATUS_NOLOGON_TRUSTED_DOMAIN_ACCOUNT).

Use get_trust_pw_clear to get machine trust account.
Only call this when the results is really used.
Use the proper domain and account name for session setup.

Michael
(This used to be commit 18c66a364e0ddc4960769871ca190944f7fe5c44)

16 years agoRefactoring out get_schannel_session_key logic.
Michael Adam [Tue, 11 Dec 2007 13:36:11 +0000 (14:36 +0100)]
Refactoring out get_schannel_session_key logic.

Refactor the actual retrieval of the session key through the
established netlogon pipe out of get_schannel_session_key()
and get_schannel_session_key_auth_ntlmssp() into a new
function get_schannel_session_key_common().
(To avoid code duplication.)

Michael
(This used to be commit e77c4022cfbb868e608edcb06b676658b0e201ad)

16 years agoPass NULL instead of unneeded &sid: pdb_get_trusteddom_pw() checks.
Michael Adam [Tue, 11 Dec 2007 13:12:49 +0000 (14:12 +0100)]
Pass NULL instead of unneeded &sid: pdb_get_trusteddom_pw() checks.

Michael
(This used to be commit b2e12365b56f24586a7dfcb845f4de51f0b0e7d5)

16 years agoRename get_trust_pw() to get_trust_pw_hash().
Michael Adam [Tue, 11 Dec 2007 13:07:32 +0000 (14:07 +0100)]
Rename get_trust_pw() to get_trust_pw_hash().

Michael
(This used to be commit 0cde7ac9cb39a0026a38ccf66dbecefc12931074)

16 years agoExport logic of get_trust_pw() to new function get_trust_pw_clear().
Michael Adam [Tue, 11 Dec 2007 12:59:54 +0000 (13:59 +0100)]
Export logic of get_trust_pw() to new function get_trust_pw_clear().

get_trust_pw() just now computes the md4 hash of the result of
get_trust_pw_clear() if that was successful. As a last resort,
in the non-trusted-domain-situation, get_trust_pw() now tries to
directly obtain the hashed version of the password out of secrets.tdb.

Michael
(This used to be commit 4562342eb84e6fdcec15d8b7ae83aa146aabe2b7)

16 years agoRefactor the lagacy part of secrets_fetch_trust_account_password() out
Michael Adam [Tue, 11 Dec 2007 13:02:45 +0000 (14:02 +0100)]
Refactor the lagacy part of secrets_fetch_trust_account_password() out

into a new function secrets_fetch_trust_account_password_legacy() that
does only try to obtain the hashed version of the machine password directly
from secrets.tdb.

Michael
(This used to be commit 91da12b751b3168dc40049f3e90c10d840393efc)

16 years agoLet get_trust_pw() determine the machine_account_name to use.
Michael Adam [Tue, 11 Dec 2007 12:05:44 +0000 (13:05 +0100)]
Let get_trust_pw() determine the machine_account_name to use.

Up to now each caller used its own logic.

This eliminates code paths where there was a special treatment
of the following situation: the domain given is not our workgroup
(i.e. our own domain) and we are not a DC (i.e. it is not a typical
trusted domain situation). In situation the given domain name was
previously used as the machine account name, resulting in an account
name of DOMAIN\\DOMAIN$, which does not seem very reasonable to me.
get_trust_pw would not have obtained a password in this situation
anyways.

I hope I have not missed an important point here!

Michael
(This used to be commit 6ced4a7f88798dc449a667d63bc29bf6c569291f)

16 years agoStreamline logic in cm_connect_netlogon()
Michael Adam [Tue, 11 Dec 2007 11:47:28 +0000 (12:47 +0100)]
Streamline logic in cm_connect_netlogon()

by retrieving trust password only, when it will be used.

Michael
(This used to be commit cdc60d8ae8c0ef804206b20b451e9557f97d4439)

16 years agoIn cm_prepare_connection(), only get auth user creds if we need to.
Michael Adam [Tue, 11 Dec 2007 07:52:20 +0000 (08:52 +0100)]
In cm_prepare_connection(), only get auth user creds if we need to.

Michael
(This used to be commit 164bfb25d7b5cfeffeb4d81958b7629a11ca5d5e)

16 years agoRemove two unneeded functions.
Michael Adam [Mon, 10 Dec 2007 22:53:55 +0000 (23:53 +0100)]
Remove two unneeded functions.

secrets_store_trust_account_password() and trust_password_delete()
are the write access functions to the SECRETS/$MACHINE.ACC/domain keys
in secrets.tdb, the md4 hashed machine passwords. These are not used
any more: Current code always writes the clear text password.

Michael
(This used to be commit 4788fe392427901f6b1c505e3a743136ac8a91ca)

16 years agoFix for bug #4801: Correctly implement lsa lookup levels for lookupnames.
Michael Adam [Wed, 12 Dec 2007 17:03:20 +0000 (18:03 +0100)]
Fix for bug #4801: Correctly implement lsa lookup levels for lookupnames.

This is a first patch aimed at fixing bug #4801.
It is still incomplete in that winbindd does not walk
the the trusted domains to lookup unqualified names here.
Apart from that this fix should be pretty much complete.

Michael
(This used to be commit dd320c0924ce393a89b1cab020fd5cffc5b80380)

16 years agoFix typo.
James Peach [Thu, 13 Dec 2007 06:12:10 +0000 (22:12 -0800)]
Fix typo.
(This used to be commit c8468a1bb49535f0467e1a83b4c8bc5c8dce834e)

16 years agoAutoconf support for detecting DNS Service Discovery support.
James Peach [Sat, 13 Oct 2007 05:16:22 +0000 (22:16 -0700)]
Autoconf support for detecting DNS Service Discovery support.

Patch from Rishi Srivatsavai <rishisv@gmail.com>, with some
adaptations.
(This used to be commit 2dfe9525b9e6e7dcbac191c1fb6288e166d171e5)

16 years agoMissed one strcpy call.
Jeremy Allison [Thu, 13 Dec 2007 03:12:18 +0000 (19:12 -0800)]
Missed one strcpy call.
Jeremy.
(This used to be commit b215fb1ad0d5bb3fa7084c2773845ce1dffb2173)

16 years agoAdd a portable version of strlcpy and strlcat and convert
Jeremy Allison [Thu, 13 Dec 2007 03:06:04 +0000 (19:06 -0800)]
Add a portable version of strlcpy and strlcat and convert
all strncpy/strcat calls to them.
Convert all sprintf calls to snprintf. Safety first !
Jeremy.
(This used to be commit eff2b368e891d523de38b43ced95798b74ae101e)

16 years agoFix bug #4784. Patch from Steve Langasek <vorlon@debian.org>.
Jeremy Allison [Thu, 13 Dec 2007 02:45:13 +0000 (18:45 -0800)]
Fix bug #4784. Patch from Steve Langasek <vorlon@debian.org>.
Jeremy.
(This used to be commit 4f503ea8912eb787209c8df364bfdb161dbb212c)

16 years agoDeveloper doesn't cut it - need #define test for NSS_WRAPPER.
Jeremy Allison [Thu, 13 Dec 2007 02:38:52 +0000 (18:38 -0800)]
Developer doesn't cut it - need #define test for NSS_WRAPPER.
Hopefully this should fix the buildfarm.
Jeremy.
(This used to be commit 087489b7f2a8cd5868b54dbed3f3eed5d0709ba7)

16 years agoOnly add the non-root escape on !developer.
Jeremy Allison [Thu, 13 Dec 2007 02:07:02 +0000 (18:07 -0800)]
Only add the non-root escape on !developer.
Jeremy.
(This used to be commit a50c2d159c754c6ff88649ed859f2b3f9c24f6a1)

16 years agoFix the buildfarm until I figure out how to allow
Jeremy Allison [Thu, 13 Dec 2007 01:56:28 +0000 (17:56 -0800)]
Fix the buildfarm until I figure out how to allow
smbpasswd -L for non-root on the buildfarm only.
Jeremy.
(This used to be commit 1bb5ce824f800d967e2a92e946dd6ce7c4580b93)

16 years agoFix bug #3727 with patch from Steve Langasek <vorlon@debian.org>
Jeremy Allison [Thu, 13 Dec 2007 01:26:49 +0000 (17:26 -0800)]
Fix bug #3727 with patch from Steve Langasek <vorlon@debian.org>
Jeremy.
(This used to be commit 0723760ba47a465d2ff5a22a680f1b5196eca7d8)

16 years agoMake heimdal and MIT happy when iterating through auth data.
Günther Deschner [Wed, 12 Dec 2007 17:57:45 +0000 (18:57 +0100)]
Make heimdal and MIT happy when iterating through auth data.

Guenther
(This used to be commit 507247dcbf0ef02825a6c5c5f313813714df2d99)

16 years agoVista SP1-rc1 appears to break against Samba-3.0.27a
Guenther Deschner [Wed, 12 Dec 2007 12:38:28 +0000 (13:38 +0100)]
Vista SP1-rc1 appears to break against Samba-3.0.27a

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Jason,

Jason Haar wrote:
> Patched 3.0.28, compiled, installed and here's the log file.
>
> Hope it helps. BTW I don't think it matters, but this is on 32bit
> CentOS4.5 systems.

yes, it helps. Thanks for that.

Very interesting, there are two auth data structures where the first one
is a PAC and the second something unknown (yet).

Can you please try the attached fix ? It should make it work again.

Guenther
- --
Günther Deschner                    GPG-ID: 8EE11688
Red Hat                         gdeschner@redhat.com
Samba Team                              gd@samba.org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iD8DBQFHX9ZESOk3aI7hFogRAivSAJ9bMcD+PcsIzjYYLtAUoLNfVVEl1QCfV/Qd
MPsZW4G31VOVu64SPjgnJiI=
=Co+H
-----END PGP SIGNATURE-----
(This used to be commit c9adc07ca2a3bb1e0ea98e3b4f68e1a87e5c0196)

16 years agoFix logic and prevent segfaults in secrets trustdom tdb pack code.
Michael Adam [Wed, 12 Dec 2007 12:50:48 +0000 (13:50 +0100)]
Fix logic and prevent segfaults in secrets trustdom tdb pack code.

New size calculation logic in tdb_trusted_dom_pass_pack()
and tdb_sid_pack() used accumulated sizes as successive offsets
to buffer pointer.

Michael
(This used to be commit 9c24713b402978e74dc8691be5cab71d8666eb41)

16 years agoFix secrets_store_trusted_domain_password() after pstring removal.
Michael Adam [Wed, 12 Dec 2007 12:37:46 +0000 (13:37 +0100)]
Fix secrets_store_trusted_domain_password() after pstring removal.

Jeremy, this small "&" sign has given me a headache... :-)

Michael
(This used to be commit 7590b12a994cc3c5f299ce7f3299c76adad1c599)

16 years agoAllow cliconnect to loop through multiple ip addresses
Jeremy Allison [Wed, 12 Dec 2007 17:42:58 +0000 (09:42 -0800)]
Allow cliconnect to loop through multiple ip addresses
for a server. We should have been doing this for a while,
but it's more critical with IPv6.
Original patch fixed up by James.
Jeremy.
(This used to be commit 5c7f7629a97ef0929e00e52f1fae4386c984000b)

16 years agoDon't restart winbind if a corrupted tdb is found during initialization.
Andreas Schneider [Fri, 23 Nov 2007 09:54:48 +0000 (10:54 +0100)]
Don't restart winbind if a corrupted tdb is found during initialization.

The tdb is validated before it gets initialized. Since then sighandlers changed
a restart isn't needed anymore.
(This used to be commit aabe9b33fcaed8af98b1ed6b736253e196d87d48)

16 years agowinbindd: remove unused WINBINDD_DUMP_MAPS support
Stefan Metzmacher [Wed, 12 Dec 2007 08:51:56 +0000 (09:51 +0100)]
winbindd: remove unused WINBINDD_DUMP_MAPS support

Also the design of this function was really bad,
instead do the dump into a file, the client should get
back the list of mappings.

metze
(This used to be commit ce7fe8acf41e90553431c7cda6823700701835c7)

16 years agowinbindd: remove unused WINBINDD_DUAL_NAME2*ID and WINBINDD_DUAL_*ID2NAME calls
Stefan Metzmacher [Wed, 12 Dec 2007 08:02:23 +0000 (09:02 +0100)]
winbindd: remove unused WINBINDD_DUAL_NAME2*ID and WINBINDD_DUAL_*ID2NAME calls

WINBINDD_DUAL_UID2NAME
WINBINDD_DUAL_NAME2UID
WINBINDD_DUAL_GID2NAME
WINBINDD_DUAL_NAME2GID

metze
(This used to be commit fd4499ee438e4947990200db529363d51bd2c956)

16 years agoAdd lp_include_registry_globals().
Günther Deschner [Tue, 11 Dec 2007 16:40:52 +0000 (17:40 +0100)]
Add lp_include_registry_globals().

Guenther
(This used to be commit d30b945e99390761e405492e40c90e84da4fe482)

16 years agoSome cleanups for "net dom join".
Günther Deschner [Tue, 11 Dec 2007 20:22:04 +0000 (21:22 +0100)]
Some cleanups for "net dom join".

Guenther
(This used to be commit 3f426f394f3b1454c52d92331c14f41dd1474516)

16 years agoAdd split_domain_user() (not to mix with winbind variants).
Günther Deschner [Tue, 11 Dec 2007 23:42:22 +0000 (00:42 +0100)]
Add split_domain_user() (not to mix with winbind variants).

Guenther
(This used to be commit bd5308e5f63e4f692761557d0ecdee7226b66a15)

16 years agoMake decode_wkssvc_join_password_buffer() return WERRORs.
Günther Deschner [Tue, 11 Dec 2007 23:44:10 +0000 (00:44 +0100)]
Make decode_wkssvc_join_password_buffer() return WERRORs.

Guenther
(This used to be commit 88e9da2f14b41a62bdb478f9ffc2de66643bbf14)

16 years agoFix warning message about data type always true.
Jeremy Allison [Tue, 11 Dec 2007 23:10:37 +0000 (15:10 -0800)]
Fix warning message about data type always true.
Jeremy.
(This used to be commit 0a3be0aad7220eb97fe39460e20f36c8ae9ce474)

16 years agoAdd patches for bug #4866 from jiri sasek - Sun Microsystems - Prague Czech Republic...
Jeremy Allison [Tue, 11 Dec 2007 21:16:35 +0000 (13:16 -0800)]
Add patches for bug #4866 from jiri sasek - Sun Microsystems - Prague Czech Republic <Jiri.Sasek@Sun.COM>
- slightly modified - Jiri please check !  to allow Solaris to get passwords > 8 chars.
Jeremy.
(This used to be commit 657bf8c3479d6192f269e3daef1517e77a9fa9cb)

16 years agowinbindd: pass const char *logfile to winbindd_dump_maps_async()
Stefan Metzmacher [Tue, 11 Dec 2007 14:08:18 +0000 (15:08 +0100)]
winbindd: pass const char *logfile to winbindd_dump_maps_async()

metze
(This used to be commit a52237e3a10aa4ac15cd9e7b859a54c46bfa9cdf)

16 years agoConvert the posix_pending_close_db to dbwrap_rbt
Volker Lendecke [Mon, 10 Dec 2007 20:36:28 +0000 (21:36 +0100)]
Convert the posix_pending_close_db to dbwrap_rbt
(This used to be commit 841f4ccbfb5f79ac4f447342e9dd6ef73cacbc65)

16 years agoseparate out create_file_unixpath()
Volker Lendecke [Tue, 11 Dec 2007 10:14:30 +0000 (11:14 +0100)]
separate out create_file_unixpath()
(This used to be commit deaacf971e0fbffd0e5fe24f225ebf645a77e133)