Jeremy Allison [Fri, 6 Apr 2007 01:09:19 +0000 (01:09 +0000)]
r22097: Add detection for linux readahead() syscall.
Jeremy.
Jeremy Allison [Thu, 5 Apr 2007 23:56:10 +0000 (23:56 +0000)]
r22096: become_root_uid_only() is unneeded - it's only used in
messages.c. Refactor to use become_root() instead and
make it local to messages.c
Jeremy.
Gerald Carter [Thu, 5 Apr 2007 19:56:08 +0000 (19:56 +0000)]
r22095: BUG 4484: Add more checks to set %a for Vista clients (based on absence of native OS and Lanman strings in the session setup request)
James Peach [Thu, 5 Apr 2007 19:49:29 +0000 (19:49 +0000)]
r22094: Clarify that SMB_VFS_LOCK should not be used to get lock status.
Stefan Metzmacher [Thu, 5 Apr 2007 12:36:10 +0000 (12:36 +0000)]
r22093: send also the correct OID_KERBEROS5 not only the broken
OID_KERBEROS_OLD one.
metze
Stefan Metzmacher [Thu, 5 Apr 2007 12:30:23 +0000 (12:30 +0000)]
r22092: - make spnego_parse_auth_response() more generic and
not specific for NTLMSSP
- it's possible that the server sends a mechOID and authdata
if negResult != SPNEGO_NEG_RESULT_INCOMPLETE, but we still
force the mechOID to be present if negResult == SPNEGO_NEG_RESULT_INCOMPLETE
metze
Volker Lendecke [Thu, 5 Apr 2007 11:13:25 +0000 (11:13 +0000)]
r22091: Fix an uninitialized variable warning
Jeremy Allison [Wed, 4 Apr 2007 23:33:07 +0000 (23:33 +0000)]
r22080: Fix directory recycle module bug #4486.
Jeremy.
Jeremy Allison [Wed, 4 Apr 2007 17:38:12 +0000 (17:38 +0000)]
r22079: Tsk, tsk, Metze didn't compile before check-in :-).
Merge the memory leak fix (with fix :-) to 3.0.25.
Jeremy.
Stefan Metzmacher [Wed, 4 Apr 2007 14:50:39 +0000 (14:50 +0000)]
r22078: fix memory leak in not often used code, we only use it if the server
doesn't support GSS-SPNEGO in SASL
can someone please review this, maybe it's also for 3.0.25
metze
Andrew Bartlett [Wed, 4 Apr 2007 06:03:54 +0000 (06:03 +0000)]
r22071: Make the error message for incorrect use of '-c' show the parameter as used.
This means that smbpasswd -c user (which in htpasswd creates a new file)
and smbpasswd -c /not/my/smb.conf should give errors an admin will
think to chase down.
Andrew Bartlett
Gerald Carter [Wed, 4 Apr 2007 04:28:28 +0000 (04:28 +0000)]
r22069: BUG 4447: Fix compile failure on AIX 5.2 (patch from William Jojo <jojowil@hvcc.edu>)
Stefan Metzmacher [Wed, 4 Apr 2007 03:54:30 +0000 (03:54 +0000)]
r22067: - fix --with-fhs, where confdir is set to \${sysconfdir}
but sysconfdir wasn't defined in our Makefile
- add localstatedir for completeness
metze
Gerald Carter [Wed, 4 Apr 2007 02:57:01 +0000 (02:57 +0000)]
r22066: Ensure that winbind can resolve SIDs in the S-1-22-{1,2}
domain to a uid.gid using the idmap_passdb backend.
Jeremy Allison [Wed, 4 Apr 2007 00:03:12 +0000 (00:03 +0000)]
r22065: First logic change I've found :-(. We were being too
restrictive about strings being NULL. If an info level
doesn't use a subformat the subformat string may be
missing (null). Add debug statements to help track
this.
Jeremy
Jeremy Allison [Tue, 3 Apr 2007 22:59:55 +0000 (22:59 +0000)]
r22064: Fix the DFS code to work better with Vista clients. Allow
"host msdfs = true" to be set in the [global] section
and allow Vista to see shares with "msdfs root = yes"
and "msdfs root = no" off the same server. Down
to an error message really :-).
Jeremy.
Jeremy Allison [Tue, 3 Apr 2007 19:47:19 +0000 (19:47 +0000)]
r22062: Fix the parsing of info level 3. Flags is not a flags
field, but an offset. Fixed 64-bit display of ACLs on
printers.
Jeremy.
Gerald Carter [Tue, 3 Apr 2007 18:32:25 +0000 (18:32 +0000)]
r22061: Fix the krb5 user ticket refresh event timeout in winbindd
Jeremy Allison [Tue, 3 Apr 2007 17:10:52 +0000 (17:10 +0000)]
r22060: Fix for AIX quotas from Heinrich Mislik <Heinrich.Mislik@univie.ac.at>.
Jeremy.
Volker Lendecke [Tue, 3 Apr 2007 14:16:56 +0000 (14:16 +0000)]
r22059: Over-allocate and NULL out 100 bytes for lanman.c.
Volker
Günther Deschner [Tue, 3 Apr 2007 13:30:43 +0000 (13:30 +0000)]
r22058: Add test_nss_modules to check NSS modules for unresolved symbols.
Guenther
Günther Deschner [Tue, 3 Apr 2007 13:25:14 +0000 (13:25 +0000)]
r22056: Adding some missing proto_exists calls (for PAM and NSS modules)
Guenther
Jelmer Vernooij [Tue, 3 Apr 2007 12:28:40 +0000 (12:28 +0000)]
r22055: Port the endpoint mapper (and functions it requires) to Samba 3.
Stefan Metzmacher [Tue, 3 Apr 2007 10:15:15 +0000 (10:15 +0000)]
r22054: merge from samba4:
remove broken samba3 specific stuff from tdbtool
metze
Stefan Metzmacher [Tue, 3 Apr 2007 07:00:53 +0000 (07:00 +0000)]
r22051: use libreplace headers
metze
Jeremy Allison [Tue, 3 Apr 2007 04:52:09 +0000 (04:52 +0000)]
r22050: Fix a couple of off-by-one errors in the rap
call patch. Jerry, this works now for displaying
shares on Win9x (and hopefully everything else
as well :-).
Jeremy.
Jeremy Allison [Mon, 2 Apr 2007 23:07:06 +0000 (23:07 +0000)]
r22049: HPUX build fixes from <don.mccall@hp.com>.
Jeremy.
Jeremy Allison [Mon, 2 Apr 2007 20:10:21 +0000 (20:10 +0000)]
r22045: As Volker noticed, skip_string's last argument is
redundent. Remove it.
Jeremy.
Volker Lendecke [Mon, 2 Apr 2007 20:04:05 +0000 (20:04 +0000)]
r22044: Remove the only skip_string(...,2) caller
Volker Lendecke [Mon, 2 Apr 2007 19:46:27 +0000 (19:46 +0000)]
r22043: Comparing lanman.c with -r22013 is now MUCH easier, thanks! This looks much
easier to review! Damn close to what I had in my tree, just the fn names were
slightly different.
This removes one unnecessary dupe.
Next thing is to get rid of the parameter "n" of skip_string, there is only
one (!) caller that does not pass in 1....
Volker
Jeremy Allison [Mon, 2 Apr 2007 19:04:57 +0000 (19:04 +0000)]
r22042: Try and clean up my own mess using the API Volker
suggested. I now use :
BOOL is_offset_safe(const char *buf_base, size_t buf_len, char *ptr, size_t off)
char *get_safe_ptr(const char *buf_base, size_t buf_len, char *ptr, size_t off)
char *get_safe_str_ptr(const char *buf_base, size_t buf_len, char *ptr, size_t off)
int get_safe_SVAL(const char *buf_base, size_t buf_len, char *ptr, size_t off, int failval)
int get_safe_IVAL(const char *buf_base, size_t buf_len, char *ptr, size_t off, int failval)
Volker, please criticize and comment. Thanks,
Jeremy.
Stefan Metzmacher [Mon, 2 Apr 2007 18:42:56 +0000 (18:42 +0000)]
r22039: fix compiler warnings
metze
Stefan Metzmacher [Mon, 2 Apr 2007 17:16:14 +0000 (17:16 +0000)]
r22033: remove useless line
metze
Andrew Bartlett [Mon, 2 Apr 2007 12:52:08 +0000 (12:52 +0000)]
r22026: Missed in my last commit, another case where we need to copy, not reference.
Andrew Bartlett
Andrew Bartlett [Mon, 2 Apr 2007 06:57:37 +0000 (06:57 +0000)]
r22024: Don't leak, actually use the provided memory context...
Andrew Bartlett [Mon, 2 Apr 2007 06:26:16 +0000 (06:26 +0000)]
r22023: I don't like this cache, but I think Jeremy is right, the consequences
of the talloc heirarchy created are too subtle, particularly with
callers picking out individual members.
This might fix the faults on the build farm.
Andrew Bartlett
Andrew Bartlett [Mon, 2 Apr 2007 05:53:34 +0000 (05:53 +0000)]
r22022: - Clarify the comments
- make sure never to free an uninitialised variable
- ensure to free result on getpwnam_alloc failure
Andrew Bartlett
Andrew Bartlett [Mon, 2 Apr 2007 03:46:13 +0000 (03:46 +0000)]
r22020: Make it more clear that both the vuser struct and it's contents are
talloc_free()'ed at the end of a session.
Rework the passwd cache code to use talloc_unlink and
talloc_reference, to more carefully manage the cache.
Andrew Bartlett
Volker Lendecke [Sun, 1 Apr 2007 13:50:02 +0000 (13:50 +0000)]
r22019: Jeremy, this hopefully fixes the build farm currently. But I think we need
another get_safe_offset call that also includes the required buffer size.
Volker
Herb Lewis [Sat, 31 Mar 2007 03:11:02 +0000 (03:11 +0000)]
r22018: fix compile error
Jeremy Allison [Sat, 31 Mar 2007 01:14:00 +0000 (01:14 +0000)]
r22017: After changing 2000 lines of this I think this is needed :-).
Jeremy.
Jeremy Allison [Fri, 30 Mar 2007 23:23:45 +0000 (23:23 +0000)]
r22016: Try and fix the build - move things out of proto.h
Jeremy.
Jeremy Allison [Fri, 30 Mar 2007 22:35:35 +0000 (22:35 +0000)]
r22015: Fix for memory leak from Steven Danneman <steven.danneman@isilon.com>
Jeremy.
Jeremy Allison [Fri, 30 Mar 2007 22:25:08 +0000 (22:25 +0000)]
r22014: Make us pass RANDOMIPC test again :-(. This is an ugly check-in,
but I've no option.
Jeremy.
Jeremy Allison [Fri, 30 Mar 2007 22:19:51 +0000 (22:19 +0000)]
r22013: Move to SSPI framing (sig first in NTLM).
Jeremy
Jeremy Allison [Thu, 29 Mar 2007 22:12:28 +0000 (22:12 +0000)]
r22012: Ensure we use the same technique to pull the share mode
data out that locking/locking.c does.
Jeremy.
Jeremy Allison [Thu, 29 Mar 2007 19:46:34 +0000 (19:46 +0000)]
r22011: As Metze suggested, use 0xFF 'E' <enc ctx> instead
of 0xFF 'S' <enc ctx>.
Jeremy.
Jeremy Allison [Thu, 29 Mar 2007 19:40:59 +0000 (19:40 +0000)]
r22010: Now I'm looking at mangling again, make sure
that we mangle any illegal names before doing
any wildcard matches. That way lies least
suprises. Don't merge this for 3.0.25, too
dangerous. Thanks.
Jeremy.
Stefan Metzmacher [Thu, 29 Mar 2007 09:35:51 +0000 (09:35 +0000)]
r22009: change TDB_DATA from char * to unsigned char *
and fix all compiler warnings in the users
metze
Stefan Metzmacher [Thu, 29 Mar 2007 08:24:15 +0000 (08:24 +0000)]
r22008: use string_term_tdb_data()
metze
Stefan Metzmacher [Thu, 29 Mar 2007 08:08:52 +0000 (08:08 +0000)]
r22007: make string_tdb_data(NULL) possible...
metze
Stefan Metzmacher [Thu, 29 Mar 2007 07:30:22 +0000 (07:30 +0000)]
r22006: use string_term_tdb_data()...
metze
Jeremy Allison [Wed, 28 Mar 2007 19:47:59 +0000 (19:47 +0000)]
r22003: Fix from Jiri.Sasek@Sun.COM to wrap our krb5_locate_kdc
call as smb_krb5_locate_kdc to prevent incorrect linking
and crashes on Solaris.
Jeremy.
Simo Sorce [Wed, 28 Mar 2007 14:16:34 +0000 (14:16 +0000)]
r22002: Fix bug #3974, there are still open issues with -N behavior (doc fix next)
and -T argument parsing behavior (which is just insane but a separate bug)
Stefan Metzmacher [Wed, 28 Mar 2007 13:34:59 +0000 (13:34 +0000)]
r22001: change prototype of dump_data(), so that it takes unsigned char * now,
which matches what samba4 has.
also fix all the callers to prevent compiler warnings
metze
Stefan Metzmacher [Wed, 28 Mar 2007 13:31:52 +0000 (13:31 +0000)]
r22000: remove useless casts
metze
Stefan Metzmacher [Wed, 28 Mar 2007 13:26:43 +0000 (13:26 +0000)]
r21999: remove useless casts
metze
Günther Deschner [Wed, 28 Mar 2007 10:00:42 +0000 (10:00 +0000)]
r21998: Fix tdb keynames in netsamlogon_clear_cached_user().
No point in deleting U/DOMAIN/RID and UG/DOMAIN/RID keys if we only store U/SID
and UG/SID keys :-)
Next we need to verify the need of calling netsamlogon_clear_cached_user() at all.
Guenther
Jeremy Allison [Wed, 28 Mar 2007 01:11:27 +0000 (01:11 +0000)]
r21997: Implement the server side of gss seal negotiate.
Jeremy.
Jeremy Allison [Tue, 27 Mar 2007 22:37:42 +0000 (22:37 +0000)]
r21994: Ignore keepalives in the correct buffer (out not in :-).
Jeremy.
Jeremy Allison [Tue, 27 Mar 2007 22:27:06 +0000 (22:27 +0000)]
r21993: Don't let keepalives interferece with sign or seal
in the client code.
Jeremy.
Jeremy Allison [Tue, 27 Mar 2007 21:55:43 +0000 (21:55 +0000)]
r21992: Fix keepalive processing when encryption turned on.
Jeremy.
Jeremy Allison [Tue, 27 Mar 2007 21:13:31 +0000 (21:13 +0000)]
r21991: I hate Steve French :-). Add support for encryption
contexts....
Jeremy.
Jeremy Allison [Tue, 27 Mar 2007 18:04:36 +0000 (18:04 +0000)]
r21990: Stop messing with the signing engine just because
we're encrypted. This will make further changes and
spec much more clear.
Jeremy.
Stefan Metzmacher [Tue, 27 Mar 2007 11:22:07 +0000 (11:22 +0000)]
r21989: make use of tdb_*_bystring() and string_term_tdb_data()
to avoid creating the TDB_DATA struct from strings "by hand"
metze
Stefan Metzmacher [Tue, 27 Mar 2007 11:20:55 +0000 (11:20 +0000)]
r21988: make use of string_tdb_data()
to avoid creating the TDB_DATA struct from strings "by hand"
metze
Stefan Metzmacher [Tue, 27 Mar 2007 11:15:59 +0000 (11:15 +0000)]
r21987: split tdb_prs_*() functions in version which take a keystr and a TDB_DATA key
metze
Stefan Metzmacher [Tue, 27 Mar 2007 11:01:37 +0000 (11:01 +0000)]
r21986: make use of tdb_*_bystring() and string_term_tdb_data()
to avoid creating the TDB_DATA struct from strings "by hand"
metze
Stefan Metzmacher [Tue, 27 Mar 2007 10:59:03 +0000 (10:59 +0000)]
r21985: make use of string_tdb_data()
to avoid creating the TDB_DATA struct from strings "by hand"
metze
Stefan Metzmacher [Tue, 27 Mar 2007 10:50:32 +0000 (10:50 +0000)]
r21984: make use of tdb_*_bystring() and string_term_tdb_data()
to avoid creating the TDB_DATA struct from strings "by hand"
metze
Stefan Metzmacher [Tue, 27 Mar 2007 10:46:20 +0000 (10:46 +0000)]
r21983: make use of tdb_*_bystring() and string_term_tdb_data()
to avoid creating the TDB_DATA struct from strings "by hand"
metze
Stefan Metzmacher [Tue, 27 Mar 2007 10:43:32 +0000 (10:43 +0000)]
r21982: make use of tdb_*_bystring() and string_term_tdb_data()
to avoid creating the TDB_DATA struct from strings "by hand"
metze
Stefan Metzmacher [Tue, 27 Mar 2007 10:41:30 +0000 (10:41 +0000)]
r21981: as we use tdb_trans_store(), we should also use tdb_trans_delete()
metze
Stefan Metzmacher [Tue, 27 Mar 2007 10:20:50 +0000 (10:20 +0000)]
r21980: make use of tdb_*_bystring() and string_term_tdb_data() in smbd/
to avoid creating the TDB_DATA struct from strings "by hand"
metze
Stefan Metzmacher [Tue, 27 Mar 2007 10:15:45 +0000 (10:15 +0000)]
r21979: make use of string_tdb_data()
to avoid creating the TDB_DATA struct from strings "by hand"
note: we can't use the tdb_*_bystring functions here, as the key isn't
null-terminated here...
metze
Stefan Metzmacher [Tue, 27 Mar 2007 10:13:53 +0000 (10:13 +0000)]
r21978: make use of tdb_*_bystring()
to avoid creating the TDB_DATA struct from strings "by hand"
metze
Stefan Metzmacher [Tue, 27 Mar 2007 10:05:20 +0000 (10:05 +0000)]
r21977: little cosmetic change to remove a local var that's not really needed
metze
Stefan Metzmacher [Tue, 27 Mar 2007 09:59:32 +0000 (09:59 +0000)]
r21976: make use of tdb_*_bystring() and string_term_tdb_data() in lib/
to avoid creating the TDB_DATA struct from strings "by hand"
metze
Stefan Metzmacher [Tue, 27 Mar 2007 09:30:40 +0000 (09:30 +0000)]
r21975: if we use the _bystring() version when storing, we should use it on fetch too...
metze
Stefan Metzmacher [Tue, 27 Mar 2007 09:17:31 +0000 (09:17 +0000)]
r21974: make use of tdb_*_bystring() and string_term_tdb_data() in groupdb/
to avoid creating the TDB_DATA struct from strings "by hand"
metze
Stefan Metzmacher [Tue, 27 Mar 2007 09:12:47 +0000 (09:12 +0000)]
r21973: make use of tdb_*_bystring() and string_term_tdb_data()
to avoid creating the TDB_DATA struct from strings "by hand"
metze
Stefan Metzmacher [Tue, 27 Mar 2007 08:41:45 +0000 (08:41 +0000)]
r21972: - add string_term_tdb_data() it creates a null-terminates tdb key from a string
(the current string_tdb_data() creates a non-terminates tdb key from a string!)
- pass TDB_DATA instead of const char *, size_t len to some functions
metze
Jeremy Allison [Tue, 27 Mar 2007 00:50:53 +0000 (00:50 +0000)]
r21969: Start working on the gss-side of the server negotiation.
Jeremy.
Jeremy Allison [Tue, 27 Mar 2007 00:29:46 +0000 (00:29 +0000)]
r21968: Don't use gss-types in proto headers.
Jeremy.
Jeremy Allison [Tue, 27 Mar 2007 00:00:50 +0000 (00:00 +0000)]
r21967: Add conversion from gss errors to nt status.
Jeremy
Stefan Metzmacher [Mon, 26 Mar 2007 16:40:29 +0000 (16:40 +0000)]
r21965: fix compiler warning
metze
Volker Lendecke [Mon, 26 Mar 2007 10:57:48 +0000 (10:57 +0000)]
r21964: Add tdbtorture target to main makefile -- Thanks to Karolin Seeger
Jeremy Allison [Sun, 25 Mar 2007 02:17:05 +0000 (02:17 +0000)]
r21963: Fix another uninitialized buffer used in test write - valgrind
fix.
Jeremy.
Volker Lendecke [Sat, 24 Mar 2007 21:29:53 +0000 (21:29 +0000)]
r21962: Make pdbedit use the configfile specified by -s
Jeremy Allison [Sat, 24 Mar 2007 18:22:20 +0000 (18:22 +0000)]
r21961: Repair bug introduced by rev. 21960.
We need to do the initial strtok to set up the internal state.
Jeremy.
Volker Lendecke [Sat, 24 Mar 2007 18:14:46 +0000 (18:14 +0000)]
r21960: Fix bugs 4463,4464,4465,4466. Thanks Jason :-)
Volker Lendecke [Sat, 24 Mar 2007 18:01:39 +0000 (18:01 +0000)]
r21959: Merge a comment fix from Michael Adam -- more to come :-)
Volker Lendecke [Sat, 24 Mar 2007 10:32:34 +0000 (10:32 +0000)]
r21958: Fix Coverity ID 343 (dead code)
Herb Lewis [Fri, 23 Mar 2007 23:10:46 +0000 (23:10 +0000)]
r21957: minor formatting fix
Jeremy Allison [Fri, 23 Mar 2007 22:23:09 +0000 (22:23 +0000)]
r21956: Fix bug reported by don.mccall@hp.com for platforms
without utimes() call (only utime()).
Jeremy.
Jeremy Allison [Fri, 23 Mar 2007 22:11:26 +0000 (22:11 +0000)]
r21954: Someone misused a '!' instead of a '~' for a binary NOT
command. Jerry, Simo, please check.
Jeremy.
Jeremy Allison [Fri, 23 Mar 2007 21:50:44 +0000 (21:50 +0000)]
r21953: One format fix, clarify a condition that the IBM
checker was worried about.
Jeremy.
Jeremy Allison [Fri, 23 Mar 2007 21:11:08 +0000 (21:11 +0000)]
r21952: Fix critical (!) error found by IBM checker.
Missing break statements meant that no info
levels would ever be returned correctly from
POSIX open/mkdir.
Jeremy.
James Peach [Fri, 23 Mar 2007 19:31:11 +0000 (19:31 +0000)]
r21950: After discussion with the Apple and Linux client maintainers,
changing the FindFirst response for the UNIX_INFO2 level to include
a length field before the name. The name is not required to be null
terminated. The length field does not count any null.
Also add call to chflags(2) in the default VFS module so that this
will work be default on BSD-derived platform. Add UNIX-INFO2 test
to the build farm to get some non-BSD coverage.
Jeremy and Jerry, please review for inclusion in 3.0.25.
Jeremy Allison [Fri, 23 Mar 2007 19:12:08 +0000 (19:12 +0000)]
r21948: Fix valgrind error in build farm samba3 smbtorture. We were
using an uninitialized buffer for read/write tests.
Jeremy.