From: Volker Lendecke Date: Sun, 20 Oct 2013 15:29:29 +0000 (+0200) Subject: ldb: Fix CID 240798 Uninitialized pointer read X-Git-Tag: tevent-0.9.20~552 X-Git-Url: http://git.samba.org/samba.git/?p=nivanova%2Fsamba-autobuild%2F.git;a=commitdiff_plain;h=4e06c61b41fdde21fafaeee3c4fb3366744de9d9 ldb: Fix CID 240798 Uninitialized pointer read Not called right now, because nobody tries multiple sort attributes. But if someone did, build_response would have looked at the uninitialized controls. Signed-off-by: Volker Lendecke Reviewed-by: Jeremy Allison Autobuild-User(master): Jeremy Allison Autobuild-Date(master): Tue Oct 22 03:28:20 CEST 2013 on sn-devel-104 --- diff --git a/lib/ldb/modules/sort.c b/lib/ldb/modules/sort.c index c6fce2d96e0..1b762f7e51b 100644 --- a/lib/ldb/modules/sort.c +++ b/lib/ldb/modules/sort.c @@ -252,7 +252,6 @@ static int server_sort_search(struct ldb_module *module, struct ldb_request *req struct ldb_control *control; struct ldb_server_sort_control **sort_ctrls; struct ldb_control **saved_controls; - struct ldb_control **controls; struct ldb_request *down_req; struct sort_context *ac; struct ldb_context *ldb; @@ -286,6 +285,7 @@ static int server_sort_search(struct ldb_module *module, struct ldb_request *req if (sort_ctrls[1] != NULL) { if (control->critical) { + struct ldb_control **controls = NULL; /* callback immediately */ ret = build_response(req, &controls,