rpc_server4: Use dom_sid_str_buf
authorVolker Lendecke <vl@samba.org>
Thu, 18 Oct 2018 03:55:24 +0000 (05:55 +0200)
committerJeremy Allison <jra@samba.org>
Fri, 2 Nov 2018 20:21:14 +0000 (21:21 +0100)
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
source4/rpc_server/samr/dcesrv_samr.c

index eccf9d2b8c0c1b29d8de0f1b81025013bb1ba385..3df0c51dfee947fd70a15ddd94675cbdc030b577 100644 (file)
@@ -1532,7 +1532,6 @@ static NTSTATUS dcesrv_samr_GetAliasMembership(struct dcesrv_call_state *dce_cal
        struct ldb_message **res;
        uint32_t i;
        int count = 0;
-       char membersidstr[DOM_SID_STR_BUFLEN];
 
        DCESRV_PULL_HANDLE(h, r->in.domain_handle, SAMR_HANDLE_DOMAIN);
 
@@ -1548,11 +1547,13 @@ static NTSTATUS dcesrv_samr_GetAliasMembership(struct dcesrv_call_state *dce_cal
        }
 
        for (i=0; i<r->in.sids->num_sids; i++) {
-               dom_sid_string_buf(r->in.sids->sids[i].sid,
-                                  membersidstr, sizeof(membersidstr));
+               struct dom_sid_buf buf;
+
+               filter = talloc_asprintf_append(
+                       filter,
+                       "(member=<SID=%s>)",
+                       dom_sid_str_buf(r->in.sids->sids[i].sid, &buf));
 
-               filter = talloc_asprintf_append(filter, "(member=<SID=%s>)",
-                                               membersidstr);
                if (filter == NULL) {
                        return NT_STATUS_NO_MEMORY;
                }