gencache: Avoid a duplicate call to string_term_tdb_data

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Mon Sep  9 17:02:28 CEST 2013 on sn-devel-104

diff --git a/source3/lib/gencache.c b/source3/lib/gencache.c
index 2c5e9ab4245635cff14a153a66a98decd6aae81d..835f5e17d5ef8333346aad2866beba790ecf17f7 100644 (file)
--- a/source3/lib/gencache.c
+++ b/source3/lib/gencache.c
@@ -443,21 +443,19 @@ bool gencache_parse(const char *keystr,
                    void *private_data)
 {
        struct gencache_parse_state state;
-       TDB_DATA key;
+       TDB_DATA key = string_term_tdb_data(keystr);
        int ret;
 
        if (keystr == NULL) {
                return false;
        }
-       if (tdb_data_cmp(string_term_tdb_data(keystr),
-                        last_stabilize_key()) == 0) {
+       if (tdb_data_cmp(key, last_stabilize_key()) == 0) {
                return false;
        }
        if (!gencache_init()) {
                return false;
        }
 
-       key = string_term_tdb_data(keystr);
        state.parser = parser;
        state.private_data = private_data;