rodc/dns: Do not put a trailing dot at end of a DNS record

This causes RESOLV_WRAPPER to not detect the record correctly (while
also creating inconsistent and possibly breaking records).

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

diff --git a/source4/dsdb/dns/dns_update.c b/source4/dsdb/dns/dns_update.c
index 0591e346824720c470fc353b20e0bb54f1a20e63..959223dc6f8b13d73f7d0107d7b0ccc77902cd64 100644 (file)
--- a/source4/dsdb/dns/dns_update.c
+++ b/source4/dsdb/dns/dns_update.c
@@ -531,36 +531,35 @@ static NTSTATUS dnsupdate_dnsupdate_RODC(struct irpc_message *msg,
                return NT_STATUS_OK;
        }
 
-
        for (i=0; i<st->r->in.dns_names->count; i++) {
                struct NL_DNS_NAME_INFO *n = &r->in.dns_names->names[i];
                switch (n->type) {
                case NlDnsLdapAtSite:
-                       dprintf(st->fd, "SRV _ldap._tcp.%s._sites.%s. %s %u\n",
+                       dprintf(st->fd, "SRV _ldap._tcp.%s._sites.%s %s %u\n",
                                site, dnsdomain, hostname, n->port);
                        break;
                case NlDnsGcAtSite:
-                       dprintf(st->fd, "SRV _ldap._tcp.%s._sites.gc._msdcs.%s. %s %u\n",
+                       dprintf(st->fd, "SRV _ldap._tcp.%s._sites.gc._msdcs.%s %s %u\n",
                                site, dnsdomain, hostname, n->port);
                        break;
                case NlDnsDsaCname:
-                       dprintf(st->fd, "CNAME %s._msdcs.%s. %s\n",
+                       dprintf(st->fd, "CNAME %s._msdcs.%s %s\n",
                                ntdsguid, dnsforest, hostname);
                        break;
                case NlDnsKdcAtSite:
-                       dprintf(st->fd, "SRV _kerberos._tcp.%s._sites.dc._msdcs.%s. %s %u\n",
+                       dprintf(st->fd, "SRV _kerberos._tcp.%s._sites.dc._msdcs.%s %s %u\n",
                                site, dnsdomain, hostname, n->port);
                        break;
                case NlDnsDcAtSite:
-                       dprintf(st->fd, "SRV _ldap._tcp.%s._sites.dc._msdcs.%s. %s %u\n",
+                       dprintf(st->fd, "SRV _ldap._tcp.%s._sites.dc._msdcs.%s %s %u\n",
                                site, dnsdomain, hostname, n->port);
                        break;
                case NlDnsRfc1510KdcAtSite:
-                       dprintf(st->fd, "SRV _kerberos._tcp.%s._sites.%s. %s %u\n",
+                       dprintf(st->fd, "SRV _kerberos._tcp.%s._sites.%s %s %u\n",
                                site, dnsdomain, hostname, n->port);
                        break;
                case NlDnsGenericGcAtSite:
-                       dprintf(st->fd, "SRV _gc._tcp.%s._sites.%s. %s %u\n",
+                       dprintf(st->fd, "SRV _gc._tcp.%s._sites.%s %s %u\n",
                                site, dnsforest, hostname, n->port);
                        break;
                }