smbd - allow updates on directory write times on open handles.

If we set a non-null 'old timestamp' in the share mode database
when creating a directory handle, this prevents mtime (write time)
updates from being seen by clients, as we will always return the
timestamp stored in the database whilst the handle is open.

For files this is ok, as we update the stored timestamp
ourselves when we write to the handle. For directories
we should just rely on the mtime value from the underlying
filesystem.

Torture test to follow.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=9870

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>

diff --git a/source3/smbd/open.c b/source3/smbd/open.c
index 2d866bbce52047df4ac0e042e8cad75fcc78b32e..200c1ce08ce1d16d30a2b989a86022416673ac6c 100644 (file)
--- a/source3/smbd/open.c
+++ b/source3/smbd/open.c
@@ -3202,7 +3202,14 @@ static NTSTATUS open_directory(connection_struct *conn,
                return status;
        }
 
-       mtimespec = smb_dname->st.st_ex_mtime;
+       /* Don't store old timestamps for directory
+          handles in the internal database. We don't
+          update them in there if new objects
+          are creaded in the directory. Currently
+          we only update timestamps on file writes.
+          See bug #9870.
+       */
+       ZERO_STRUCT(mtimespec);
 
 #ifdef O_DIRECTORY
        status = fd_open(conn, fsp, O_RDONLY|O_DIRECTORY, 0);