Fix wbinfo --group-info if the winbind separator set to non \
authorVolker Lendecke <vl@samba.org>
Tue, 22 Apr 2008 13:41:25 +0000 (15:41 +0200)
committerVolker Lendecke <vl@samba.org>
Tue, 22 Apr 2008 13:42:09 +0000 (15:42 +0200)
In getgrsid_lookupsid_recv() we use parse_domain_user which itself looks at
lp_winbind_separator(). Thus when building up that group name we should better
use it as well.
(This used to be commit 5df75578ef1da41164936cd11b14114889201d47)

WHATSNEW.txt
source3/winbindd/winbindd_group.c

index 001f0f8..364b3fe 100644 (file)
@@ -292,6 +292,7 @@ o   Volker Lendecke <vl@samba.org>
     * Make winbind use NetSamLogonEx when possible.
     * Merge fixes in the 3-0-ctdb cluster code.
     * Fix a segfault in snprintf replacement code.
+    * Fix a regression for wbinfo --group-info if winbind separator is set
 
 
 o   Derrell Lipman <derrell@samba.org>
index d5d3acc..63fde9f 100644 (file)
@@ -806,8 +806,10 @@ static void getgrsid_lookupsid_recv( void *private_data, bool success,
 }
 
        if ( (s->group_name = talloc_asprintf( s->state->mem_ctx, 
-                                              "%s\\%s", 
-                                              dom_name, name )) == NULL )
+                                               "%s%c%s",
+                                               dom_name,
+                                              *lp_winbind_separator(),
+                                               name)) == NULL )
 {
                DEBUG(1, ("getgrsid_lookupsid_recv: talloc_asprintf() Failed!\n"));
                request_error(s->state);