s4-ldb: fixed a uninitialised el->flags in ldb_tdb

this caused an intermittent failure in some tests

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

diff --git a/source4/lib/ldb/ldb_tdb/ldb_tdb.c b/source4/lib/ldb/ldb_tdb/ldb_tdb.c
index 831361c547377c368d56560f232036ba97df013c..2f7f22208607741e534380671cb428bac17eb289 100644 (file)
--- a/source4/lib/ldb/ldb_tdb/ldb_tdb.c
+++ b/source4/lib/ldb/ldb_tdb/ldb_tdb.c
@@ -705,8 +705,7 @@ int ltdb_modify_internal(struct ldb_module *module,
                                        ret = LDB_ERR_OTHER;
                                        goto done;
                                }
-                               el->name = msg->elements[i].name;
-                               el->num_values = msg->elements[i].num_values;
+                               *el = msg->elements[i];
                                el->values = talloc_array(el, struct ldb_val, el->num_values);
                                if (el->values == NULL) {
                                        ret = LDB_ERR_OTHER;