Never second guess tridge.... (always talloc an internal pointer... ).

Jeremy.

diff --git a/source/rpc_parse/parse_samr.c b/source/rpc_parse/parse_samr.c
index 2146ccec91f63f1aecc643a30f6eddfa8bac49c5..47bf3f390dd48c7d7d21dff417adbb3878fcaf90 100644 (file)
--- a/source/rpc_parse/parse_samr.c
+++ b/source/rpc_parse/parse_samr.c
@@ -4614,16 +4614,14 @@ BOOL samr_io_r_query_aliasmem(const char *desc, SAMR_R_QUERY_ALIASMEM * r_u,
                return False;
 
        if (r_u->ptr != 0 && r_u->num_sids != 0) {
-               uint32 *ptr_sid;
+               uint32 *ptr_sid = NULL;
 
                if(!prs_uint32("num_sids1", ps, depth, &r_u->num_sids1))
                        return False;
 
-               if (UNMARSHALLING(ps)) {
-                       ptr_sid = talloc(ps->mem_ctx, sizeof(uint32) * r_u->num_sids1);
-                       if (!ptr_sid) {
-                               return False;
-                       }
+               ptr_sid = talloc(ps->mem_ctx, sizeof(uint32) * r_u->num_sids1);
+               if (!ptr_sid) {
+                       return False;
                }
                
                for (i = 0; i < r_u->num_sids1; i++) {