ctdb-common: Improve error handling in run_event

If event script directory does not exist, then return ENOTDIR.  If a
directory gets removed at runtime, report error from scandir in
get_script_list().

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>

diff --git a/ctdb/common/run_event.c b/ctdb/common/run_event.c
index 9487d2d4cf72d85a98e1924dff17e825bbf83350..9ff18707715199ae28f143e4f21e2029fde546fd 100644 (file)
--- a/ctdb/common/run_event.c
+++ b/ctdb/common/run_event.c
@@ -70,7 +70,6 @@ static int get_script_list(TALLOC_CTX *mem_ctx,
                                  script_dir, ret);
                }
                *out = NULL;
-               ret = 0;
                goto done;
        }
 
@@ -296,7 +295,7 @@ int run_event_init(TALLOC_CTX *mem_ctx, struct run_proc_context *run_proc_ctx,
 
        if (! S_ISDIR(st.st_mode)) {
                talloc_free(run_ctx);
-               return EINVAL;
+               return ENOTDIR;
        }
 
        run_ctx->script_dir = talloc_strdup(run_ctx, script_dir);