s4:py_net: PyArg_ParseTuple("i") requires an 'int' argument
authorStefan Metzmacher <metze@samba.org>
Mon, 8 Aug 2011 12:31:40 +0000 (14:31 +0200)
committerStefan Metzmacher <metze@samba.org>
Mon, 8 Aug 2011 14:45:27 +0000 (16:45 +0200)
If we pass variable references we don't get implicit casting!

metze

source4/libnet/py_net.c

index 895d2772b3894e6a10cc152912436b901459eaa1..b43f69bf0f9c56ba2ceb5ceaca0d6ae197fac68d 100644 (file)
@@ -44,6 +44,7 @@ typedef struct {
 static PyObject *py_net_join_member(py_net_Object *self, PyObject *args, PyObject *kwargs)
 {
        struct libnet_Join_member r;
+       int _level = 0;
        NTSTATUS status;
        PyObject *result;
        TALLOC_CTX *mem_ctx;
@@ -51,8 +52,10 @@ static PyObject *py_net_join_member(py_net_Object *self, PyObject *args, PyObjec
 
        if (!PyArg_ParseTupleAndKeywords(args, kwargs, "ssi:Join", discard_const_p(char *, kwnames),
                                         &r.in.domain_name, &r.in.netbios_name, 
-                                        &r.in.level))
+                                        &_level)) {
                return NULL;
+       }
+       r.in.level = _level;
 
        mem_ctx = talloc_new(self->mem_ctx);
        if (mem_ctx == NULL) {