s3: Fix a pointer error
authorVolker Lendecke <vl@samba.org>
Mon, 4 Oct 2010 09:39:51 +0000 (11:39 +0200)
committerVolker Lendecke <vl@samba.org>
Mon, 4 Oct 2010 09:43:47 +0000 (11:43 +0200)
It is not universally guaranteed that an enum is represented as a uint32_t.

This starts to be THE BUG (tm) in Samba. What can I do to explain this
to people a bit better? It seems that the verbose explanations I put into
the recent checkins fixing similar bugs are not clear enough.

Anybody who does is not 100% clear about what this patch fixes please
contact me directly so that we can talk it through on the phone to agree
on a wording that everybody can understand.

Thanks,

Volker

source3/printing/nt_printing.c

index 59af598d17277dada721a844d8fe0d250c10c325..10804046bca68b6f35901f01eb9e8c8d1d345eac 100644 (file)
@@ -751,7 +751,7 @@ static WERROR clean_up_driver_struct_level(TALLOC_CTX *mem_ctx,
                                           const char **config_file,
                                           const char **help_file,
                                           struct spoolss_StringArray *dependent_files,
-                                          uint32_t *version)
+                                          enum spoolss_DriverOSVersion *version)
 {
        const char *short_architecture;
        int i;