Fixed test and wording for long share names.
authorChristopher R. Hertel <crh@samba.org>
Mon, 15 Sep 2003 17:01:45 +0000 (17:01 +0000)
committerChristopher R. Hertel <crh@samba.org>
Mon, 15 Sep 2003 17:01:45 +0000 (17:01 +0000)
The RAP NetShareEnum() call has a length limit of 12 characters (not 8, as
previously tested).  Took DaveCB's suggested and added a note listing some
of the client systems that might be affected.
(This used to be commit cdfc0fc383ab63f47ddd547fddc4c28bbfddf5e5)

source3/utils/testparm.c

index 0a87b4bc1eacd86c2a96d7114fa1ca87c9475abc..34c25480d94f49db907ecbc2b97b76bc95f88f84 100644 (file)
@@ -248,9 +248,10 @@ via the %%o substitution. With encrypted passwords this is not possible.\n", lp_
 
        for (s=0;s<1000;s++) {
                if (VALID_SNUM(s))
-                       if (strlen(lp_servicename(s)) > 8) {
-                               printf("WARNING: You have some share names that are longer than 8 chars\n");
-                               printf("These may give errors while browsing or may not be accessible\nto some older clients\n");
+                       if (strlen(lp_servicename(s)) > 12) {
+                               printf( "WARNING: You have some share names that are longer than 12 characters.\n" );
+                               printf( "These may not be accessible to some older clients.\n" );
+                               printf( "(Eg. Windows9x, WindowsMe, and smbclient prior to Samba 3.0.)\n" );
                                break;
                        }
        }