s4-drsuapi: Change REPL_SECRET error code to match Windows
authorTim Beale <timbeale@catalyst.net.nz>
Wed, 16 Aug 2017 03:09:55 +0000 (15:09 +1200)
committerAndrew Bartlett <abartlet@samba.org>
Tue, 29 Aug 2017 05:23:28 +0000 (07:23 +0200)
The existing SOURCE_DISABLED error code doesn't seem to make a lot of
sense. Window sends back an ACCESS_DENIED error in the same situation,
which seems more appropriate.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
source4/rpc_server/drsuapi/getncchanges.c

index 705d0686f34bec334b1c45d22c465dc9d0dc5239..1b39c171cc300e087845999f75af444e512c3d49 100644 (file)
@@ -1178,7 +1178,7 @@ static WERROR getncchanges_repl_secret(struct drsuapi_bind_state *b_state,
        if (b_state->sam_ctx_system == NULL) {
                /* this operation needs system level access */
                ctr6->extended_ret = DRSUAPI_EXOP_ERR_ACCESS_DENIED;
-               return WERR_DS_DRA_SOURCE_DISABLED;
+               return WERR_DS_DRA_ACCESS_DENIED;
        }
 
        /*