Fix valgrind error when running under share level security. plaintext_password
authorJeremy Allison <jra@samba.org>
Mon, 22 Mar 2010 20:05:29 +0000 (13:05 -0700)
committerJeremy Allison <jra@samba.org>
Mon, 22 Mar 2010 20:05:29 +0000 (13:05 -0700)
is a data blob with a data pointer pointing to an allocation of length zero.

Jeremy.

source3/auth/auth_util.c

index 6ec19da61a7d088f18828a43d0a6937ec7975d46..02eaf9d8c1099f74e9f9c69d8fa27672e6b79482 100644 (file)
@@ -420,7 +420,7 @@ bool make_user_info_for_reply(struct auth_usersupplied_info **user_info,
        DEBUG(5,("make_user_info_for_reply: User passwords not in encrypted "
                 "format.\n"));
 
-       if (plaintext_password.data) {
+       if (plaintext_password.data && plaintext_password.length) {
                unsigned char local_lm_response[24];
 
 #ifdef DEBUG_PASSWORD
@@ -448,7 +448,7 @@ bool make_user_info_for_reply(struct auth_usersupplied_info **user_info,
                local_lm_blob.data ? &local_lm_blob : NULL,
                local_nt_blob.data ? &local_nt_blob : NULL,
                NULL, NULL,
-               plaintext_password.data ? &plaintext_password : NULL, 
+               plaintext_password.data && plaintext_password.length ? &plaintext_password : NULL, 
                False);
 
        data_blob_free(&local_lm_blob);