git.samba.org / nivanova / samba-autobuild / .git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 388bddf) | patch
python/samba/gp_parse: PY3 open file non-binary mode for write_binary
authorNoel Power <noel.power@suse.com>
Wed, 5 Sep 2018 11:52:30 +0000 (12:52 +0100)
committerNoel Power <npower@samba.org>
Mon, 5 Nov 2018 19:05:23 +0000 (20:05 +0100)
commitd40ef736d5ee34ad5b575dc32f89d0f4cc1885b8
tree280f69da0748e5f29a1717a2631c1c3f354415d9tree
parent388bddf4a6471f17f32af209bec36713f0b75d20commit | diff
python/samba/gp_parse: PY3 open file non-binary mode for write_binary

Although this is unintuitive it's because we are writing unicode
not bytes (both in PY2 & PY3). using the 'b' mode causes an error in
PY3.

In PY3 we can define the encoding, but not in PY2.

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
python/samba/gp_parse/gp_csv.py diff | blob | history
Unnamed repository; edit this file 'description' to name the repository.