getncchanges: Tie destination DSA GUID to authenticating RODC for REPL_SECRET
[nivanova/samba-autobuild/.git] / source4 / rpc_server / drsuapi / getncchanges.c
index c04a8c7450356a1bcc9288a1c88187c29b20a25d..ad13f8234bb1d330cddc8b3f7a394b32feaacd9b 100644 (file)
@@ -4,8 +4,9 @@
    implement the DSGetNCChanges call
 
    Copyright (C) Anatoliy Atanasov 2009
-   Copyright (C) Andrew Tridgell 2009
-   
+   Copyright (C) Andrew Tridgell 2009-2010
+   Copyright (C) Andrew Bartlett 2010-2016
+
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
    the Free Software Foundation; either version 3 of the License, or
 #include "librpc/gen_ndr/ndr_drsblobs.h"
 #include "librpc/gen_ndr/ndr_drsuapi.h"
 #include "librpc/gen_ndr/ndr_security.h"
+#include "libcli/security/security.h"
+#include "libcli/security/session.h"
 #include "rpc_server/drsuapi/dcesrv_drsuapi.h"
 #include "rpc_server/dcerpc_server_proto.h"
 #include "../libcli/drsuapi/drsuapi.h"
-#include "libcli/security/security.h"
 #include "lib/util/binsearch.h"
 #include "lib/util/tsort.h"
 #include "auth/session.h"
 #include "dsdb/common/util.h"
+#include "lib/dbwrap/dbwrap.h"
+#include "lib/dbwrap/dbwrap_rbt.h"
+#include "librpc/gen_ndr/ndr_misc.h"
+
+/* state of a partially completed getncchanges call */
+struct drsuapi_getncchanges_state {
+       struct db_context *anc_cache;
+       struct GUID *guids;
+       uint32_t num_records;
+       uint32_t num_processed;
+       struct ldb_dn *ncRoot_dn;
+       struct GUID ncRoot_guid;
+       bool is_schema_nc;
+       uint64_t min_usn;
+       uint64_t max_usn;
+       struct drsuapi_DsReplicaHighWaterMark last_hwm;
+       struct ldb_dn *last_dn;
+       struct drsuapi_DsReplicaHighWaterMark final_hwm;
+       struct drsuapi_DsReplicaCursor2CtrEx *final_udv;
+       struct drsuapi_DsReplicaLinkedAttribute *la_list;
+       uint32_t la_count;
+       struct la_for_sorting *la_sorted;
+       uint32_t la_idx;
+};
+
+/* We must keep the GUIDs in NDR form for sorting */
+struct la_for_sorting {
+       struct drsuapi_DsReplicaLinkedAttribute *link;
+       uint8_t target_guid[16];
+        uint8_t source_guid[16];
+};
+
+static int drsuapi_DsReplicaHighWaterMark_cmp(const struct drsuapi_DsReplicaHighWaterMark *h1,
+                                             const struct drsuapi_DsReplicaHighWaterMark *h2)
+{
+       if (h1->highest_usn < h2->highest_usn) {
+               return -1;
+       } else if (h1->highest_usn > h2->highest_usn) {
+               return 1;
+       } else if (h1->tmp_highest_usn < h2->tmp_highest_usn) {
+               return -1;
+       } else if (h1->tmp_highest_usn > h2->tmp_highest_usn) {
+               return 1;
+       } else if (h1->reserved_usn < h2->reserved_usn) {
+               return -1;
+       } else if (h1->reserved_usn > h2->reserved_usn) {
+               return 1;
+       }
+
+       return 0;
+}
 
 /*
   build a DsReplicaObjectIdentifier from a ldb msg
  */
 static struct drsuapi_DsReplicaObjectIdentifier *get_object_identifier(TALLOC_CTX *mem_ctx,
-                                                                      struct ldb_message *msg)
+                                                                      const struct ldb_message *msg)
 {
        struct drsuapi_DsReplicaObjectIdentifier *identifier;
        struct dom_sid *sid;
@@ -76,39 +129,158 @@ static bool udv_filter(const struct drsuapi_DsReplicaCursorCtrEx *udv,
 {
        const struct drsuapi_DsReplicaCursor *c;
        if (udv == NULL) return false;
-       BINARY_ARRAY_SEARCH(udv->cursors, udv->count, source_dsa_invocation_id, 
+       BINARY_ARRAY_SEARCH(udv->cursors, udv->count, source_dsa_invocation_id,
                            originating_invocation_id, udv_compare, c);
        if (c && originating_usn <= c->highest_usn) {
                return true;
        }
        return false;
-       
+
 }
 
-static int attid_cmp(enum drsuapi_DsAttributeId a1, enum drsuapi_DsAttributeId a2)
+static int uint32_t_cmp(uint32_t a1, uint32_t a2)
 {
        if (a1 == a2) return 0;
-       return ((uint32_t)a1) > ((uint32_t)a2) ? 1 : -1;
+       return a1 > a2 ? 1 : -1;
 }
 
-/*
-  check if an attribute is in a partial_attribute_set
- */
-static bool check_partial_attribute_set(const struct dsdb_attribute *sa,
-                                       struct drsuapi_DsPartialAttributeSet *pas)
+static int uint32_t_ptr_cmp(uint32_t *a1, uint32_t *a2, void *unused)
+{
+       if (*a1 == *a2) return 0;
+       return *a1 > *a2 ? 1 : -1;
+}
+
+static WERROR getncchanges_attid_remote_to_local(const struct dsdb_schema *schema,
+                                                const struct dsdb_syntax_ctx *ctx,
+                                                enum drsuapi_DsAttributeId remote_attid_as_enum,
+                                                enum drsuapi_DsAttributeId *local_attid_as_enum,
+                                                const struct dsdb_attribute **_sa)
 {
-       enum drsuapi_DsAttributeId *result;
-       BINARY_ARRAY_SEARCH_V(pas->attids, pas->num_attids, (enum drsuapi_DsAttributeId)sa->attributeID_id,
-                             attid_cmp, result);
-       return result != NULL;
+       WERROR werr;
+       const struct dsdb_attribute *sa = NULL;
+
+       if (ctx->pfm_remote == NULL) {
+               DEBUG(7, ("No prefixMap supplied, falling back to local prefixMap.\n"));
+               goto fail;
+       }
+
+       werr = dsdb_attribute_drsuapi_remote_to_local(ctx,
+                                                     remote_attid_as_enum,
+                                                     local_attid_as_enum,
+                                                     _sa);
+       if (!W_ERROR_IS_OK(werr)) {
+               DEBUG(3, ("WARNING: Unable to resolve remote attid, falling back to local prefixMap.\n"));
+               goto fail;
+       }
+
+       return werr;
+fail:
+
+       sa = dsdb_attribute_by_attributeID_id(schema, remote_attid_as_enum);
+       if (sa == NULL) {
+               return WERR_DS_DRA_SCHEMA_MISMATCH;
+       } else {
+               if (local_attid_as_enum != NULL) {
+                       *local_attid_as_enum = sa->attributeID_id;
+               }
+               if (_sa != NULL) {
+                       *_sa = sa;
+               }
+               return WERR_OK;
+       }
 }
 
+static WERROR getncchanges_update_revealed_list(struct ldb_context *sam_ctx,
+                                               TALLOC_CTX *mem_ctx,
+                                               struct ldb_message **msg,
+                                               struct ldb_dn *object_dn,
+                                               const struct dsdb_attribute *sa,
+                                               struct replPropertyMetaData1 *meta_data,
+                                               struct ldb_message *revealed_users)
+{
+       enum ndr_err_code ndr_err;
+       int ldb_err;
+       unsigned i;
+       char *attr_str = NULL;
+       char *attr_hex = NULL;
+       DATA_BLOB attr_blob;
+       struct ldb_message_element *existing = NULL, *el_add = NULL, *el_del = NULL;
+       const char * const * secret_attributes = ldb_get_opaque(sam_ctx, "LDB_SECRET_ATTRIBUTE_LIST");
+
+       if (!ldb_attr_in_list(secret_attributes,
+                             sa->lDAPDisplayName)) {
+               return WERR_OK;
+       }
+
+
+       ndr_err = ndr_push_struct_blob(&attr_blob, mem_ctx, meta_data, (ndr_push_flags_fn_t)ndr_push_replPropertyMetaData1);
+       if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
+               return WERR_DS_DRA_INTERNAL_ERROR;
+       }
+
+       attr_hex = hex_encode_talloc(mem_ctx, attr_blob.data, attr_blob.length);
+       if (attr_hex == NULL) {
+               return WERR_NOT_ENOUGH_MEMORY;
+       }
+
+       attr_str = talloc_asprintf(mem_ctx, "B:%zd:%s:%s", attr_blob.length*2, attr_hex, ldb_dn_get_linearized(object_dn));
+       if (attr_str == NULL) {
+               return WERR_NOT_ENOUGH_MEMORY;
+       }
+
+       existing = ldb_msg_find_element(revealed_users, "msDS-RevealedUsers");
+       if (existing != NULL) {
+               /* Replace the old value (if one exists) with the current one */
+               for (i = 0; i < existing->num_values; i++) {
+                       struct dsdb_dn *existing_dn = dsdb_dn_parse_trusted(mem_ctx, sam_ctx, &existing->values[i], DSDB_SYNTAX_BINARY_DN);
+                       if (ldb_dn_compare(object_dn, existing_dn->dn) == 0) {
+                               struct replPropertyMetaData1 existing_meta_data;
+                               ndr_err = ndr_pull_struct_blob_all_noalloc(&existing_dn->extra_part,
+                                                              &existing_meta_data,
+                                                              (ndr_pull_flags_fn_t)ndr_pull_replPropertyMetaData1);
+                               if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
+                                       return WERR_DS_DRA_INTERNAL_ERROR;
+                               }
+
+                               if (existing_meta_data.attid == sa->attributeID_id) {
+                                       ldb_err = ldb_msg_add_empty(*msg, "msDS-RevealedUsers", LDB_FLAG_MOD_DELETE, &el_del);
+                                       if (ldb_err != LDB_SUCCESS) {
+                                               return WERR_DS_DRA_INTERNAL_ERROR;
+                                       }
+
+                                       el_del->values = talloc_array((*msg)->elements, struct ldb_val, 1);
+                                       if (el_del->values == NULL) {
+                                               return WERR_NOT_ENOUGH_MEMORY;
+                                       }
+                                       el_del->values[0] = existing->values[i];
+                                       el_del->num_values = 1;
+                               }
+                       }
+               }
+       }
+
+       ldb_err = ldb_msg_add_empty(*msg, "msDS-RevealedUsers", LDB_FLAG_MOD_ADD, &el_add);
+       if (ldb_err != LDB_SUCCESS) {
+               return WERR_DS_DRA_INTERNAL_ERROR;
+       }
+
+       el_add->values = talloc_array((*msg)->elements, struct ldb_val, 1);
+       if (el_add->values == NULL) {
+               return WERR_NOT_ENOUGH_MEMORY;
+
+       }
+
+       el_add->values[0] = data_blob_string_const(attr_str);
+       el_add->num_values = 1;
+
+       return WERR_OK;
+}
 
 /* 
   drsuapi_DsGetNCChanges for one object
 */
 static WERROR get_nc_changes_build_object(struct drsuapi_DsReplicaObjectListItemEx *obj,
-                                         struct ldb_message *msg,
+                                         const struct ldb_message *msg,
                                          struct ldb_context *sam_ctx,
                                          struct ldb_dn *ncRoot_dn,
                                          bool   is_schema_nc,
@@ -118,23 +290,33 @@ static WERROR get_nc_changes_build_object(struct drsuapi_DsReplicaObjectListItem
                                          uint32_t replica_flags,
                                          struct drsuapi_DsPartialAttributeSet *partial_attribute_set,
                                          struct drsuapi_DsReplicaCursorCtrEx *uptodateness_vector,
-                                         enum drsuapi_DsExtendedOperation extended_op)
+                                         enum drsuapi_DsExtendedOperation extended_op,
+                                         bool force_object_return,
+                                         uint32_t *local_pas,
+                                         struct ldb_dn *machine_dn)
 {
        const struct ldb_val *md_value;
-       unsigned int i, n;
+       uint32_t i, n;
        struct replPropertyMetaDataBlob md;
        uint32_t rid = 0;
+       int ldb_err;
        enum ndr_err_code ndr_err;
        uint32_t *attids;
        const char *rdn;
        const struct dsdb_attribute *rdn_sa;
+       uint64_t uSNChanged;
        unsigned int instanceType;
        struct dsdb_syntax_ctx syntax_ctx;
+       struct ldb_result *res = NULL;
+       struct ldb_message *revealed_list_msg = NULL, *existing_revealed_list_msg = NULL;
+       WERROR werr;
+       int ret;
 
        /* make dsdb sytanx context for conversions */
        dsdb_syntax_ctx_init(&syntax_ctx, sam_ctx, schema);
        syntax_ctx.is_schema_nc = is_schema_nc;
 
+       uSNChanged = ldb_msg_find_attr_as_uint64(msg, "uSNChanged", 0);
        instanceType = ldb_msg_find_attr_as_uint(msg, "instanceType", 0);
        if (instanceType & INSTANCE_TYPE_IS_NC_HEAD) {
                obj->is_nc_prefix = true;
@@ -153,7 +335,7 @@ static WERROR get_nc_changes_build_object(struct drsuapi_DsReplicaObjectListItem
                }
        }
        obj->next_object = NULL;
-       
+
        md_value = ldb_msg_find_ldb_val(msg, "replPropertyMetaData");
        if (!md_value) {
                /* nothing to send */
@@ -165,12 +347,17 @@ static WERROR get_nc_changes_build_object(struct drsuapi_DsReplicaObjectListItem
                return WERR_OK;
        }
 
+       if (uSNChanged <= highest_usn) {
+               /* nothing to send */
+               return WERR_OK;
+       }
+
        ndr_err = ndr_pull_struct_blob(md_value, obj, &md,
                                       (ndr_pull_flags_fn_t)ndr_pull_replPropertyMetaDataBlob);
        if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
                return WERR_DS_DRA_INTERNAL_ERROR;
        }
-       
+
        if (md.version != 1) {
                return WERR_DS_DRA_INTERNAL_ERROR;
        }
@@ -183,7 +370,7 @@ static WERROR get_nc_changes_build_object(struct drsuapi_DsReplicaObjectListItem
 
        rdn_sa = dsdb_attribute_by_lDAPDisplayName(schema, rdn);
        if (rdn_sa == NULL) {
-               DEBUG(0,(__location__ ": Can't find dsds_attribute for rDN %s in %s\n", 
+               DEBUG(0,(__location__ ": Can't find dsds_attribute for rDN %s in %s\n",
                         rdn, ldb_dn_get_linearized(msg->dn)));
                return WERR_DS_DRA_INTERNAL_ERROR;
        }
@@ -193,11 +380,30 @@ static WERROR get_nc_changes_build_object(struct drsuapi_DsReplicaObjectListItem
 
        obj->object.identifier = get_object_identifier(obj, msg);
        if (obj->object.identifier == NULL) {
-               return WERR_NOMEM;
+               return WERR_NOT_ENOUGH_MEMORY;
        }
        dom_sid_split_rid(NULL, &obj->object.identifier->sid, NULL, &rid);
-       
+
        obj->meta_data_ctr->meta_data = talloc_array(obj, struct drsuapi_DsReplicaMetaData, md.ctr.ctr1.count);
+
+       if (extended_op == DRSUAPI_EXOP_REPL_SECRET) {
+               /* Get the existing revealed users for the destination */
+               static const char *machine_attrs[] = { "msDS-RevealedUsers", NULL };
+
+               revealed_list_msg = ldb_msg_new(sam_ctx);
+               if (revealed_list_msg == NULL) {
+                       return WERR_NOT_ENOUGH_MEMORY;
+               }
+               revealed_list_msg->dn = machine_dn;
+
+               ldb_err = dsdb_search_dn(sam_ctx, obj, &res, machine_dn, machine_attrs, 0);
+               if (ldb_err != LDB_SUCCESS || res->count != 1) {
+                       return WERR_DS_DRA_INTERNAL_ERROR;
+               }
+
+               existing_revealed_list_msg = res->msgs[0];
+       }
+
        for (n=i=0; i<md.ctr.ctr1.count; i++) {
                const struct dsdb_attribute *sa;
                bool force_attribute = false;
@@ -206,17 +412,17 @@ static WERROR get_nc_changes_build_object(struct drsuapi_DsReplicaObjectListItem
                   instanceType then don't include it */
                if (md.ctr.ctr1.array[i].local_usn < highest_usn &&
                    extended_op != DRSUAPI_EXOP_REPL_SECRET &&
-                   md.ctr.ctr1.array[i].attid != DRSUAPI_ATTRIBUTE_instanceType) continue;
+                   md.ctr.ctr1.array[i].attid != DRSUAPI_ATTID_instanceType) continue;
 
                /* don't include the rDN */
                if (md.ctr.ctr1.array[i].attid == rdn_sa->attributeID_id) continue;
 
                sa = dsdb_attribute_by_attributeID_id(schema, md.ctr.ctr1.array[i].attid);
                if (!sa) {
-                       DEBUG(0,(__location__ ": Failed to find attribute in schema for attrid %u mentioned in replPropertyMetaData of %s\n", 
-                                (unsigned int)md.ctr.ctr1.array[i].attid, 
+                       DEBUG(0,(__location__ ": Failed to find attribute in schema for attrid %u mentioned in replPropertyMetaData of %s\n",
+                                (unsigned int)md.ctr.ctr1.array[i].attid,
                                 ldb_dn_get_linearized(msg->dn)));
-                       return WERR_DS_DRA_INTERNAL_ERROR;              
+                       return WERR_DS_DRA_INTERNAL_ERROR;
                }
 
                if (sa->linkID) {
@@ -233,20 +439,33 @@ static WERROR get_nc_changes_build_object(struct drsuapi_DsReplicaObjectListItem
                        force_attribute = true;
                        DEBUG(4,("Forcing attribute %s in %s\n",
                                 sa->lDAPDisplayName, ldb_dn_get_linearized(msg->dn)));
+                       werr = getncchanges_update_revealed_list(sam_ctx, obj,
+                                                                &revealed_list_msg,
+                                                                msg->dn, sa,
+                                                                &md.ctr.ctr1.array[i],
+                                                                existing_revealed_list_msg);
+                       if (!W_ERROR_IS_OK(werr)) {
+                               return werr;
+                       }
                }
 
                /* filter by uptodateness_vector */
-               if (md.ctr.ctr1.array[i].attid != DRSUAPI_ATTRIBUTE_instanceType &&
+               if (md.ctr.ctr1.array[i].attid != DRSUAPI_ATTID_instanceType &&
                    !force_attribute &&
                    udv_filter(uptodateness_vector,
-                              &md.ctr.ctr1.array[i].originating_invocation_id, 
+                              &md.ctr.ctr1.array[i].originating_invocation_id,
                               md.ctr.ctr1.array[i].originating_usn)) {
                        continue;
                }
 
                /* filter by partial_attribute_set */
-               if (partial_attribute_set && !check_partial_attribute_set(sa, partial_attribute_set)) {
-                       continue;
+               if (partial_attribute_set && !force_attribute) {
+                       uint32_t *result = NULL;
+                       BINARY_ARRAY_SEARCH_V(local_pas, partial_attribute_set->num_attids, sa->attributeID_id,
+                                             uint32_t_cmp, result);
+                       if (result == NULL) {
+                               continue;
+                       }
                }
 
                obj->meta_data_ctr->meta_data[n].originating_change_time = md.ctr.ctr1.array[i].originating_change_time;
@@ -254,14 +473,47 @@ static WERROR get_nc_changes_build_object(struct drsuapi_DsReplicaObjectListItem
                obj->meta_data_ctr->meta_data[n].originating_invocation_id = md.ctr.ctr1.array[i].originating_invocation_id;
                obj->meta_data_ctr->meta_data[n].originating_usn = md.ctr.ctr1.array[i].originating_usn;
                attids[n] = md.ctr.ctr1.array[i].attid;
+
                n++;
        }
 
+       if (revealed_list_msg != NULL) {
+               ret = ldb_transaction_start(sam_ctx);
+               if (ret != LDB_SUCCESS) {
+                       DEBUG(0,(__location__ ": Failed transaction start - %s\n",
+                                ldb_errstring(sam_ctx)));
+                       return WERR_DS_DRA_INTERNAL_ERROR;
+               }
+
+               ret = ldb_modify(sam_ctx, revealed_list_msg);
+               if (ret != LDB_SUCCESS) {
+                       DEBUG(0,(__location__ ": Failed to commit revealed links - %s\n",
+                                ldb_errstring(sam_ctx)));
+                       ldb_transaction_cancel(sam_ctx);
+                       return WERR_DS_DRA_INTERNAL_ERROR;
+               }
+
+               ret = ldb_transaction_commit(sam_ctx);
+               if (ret != LDB_SUCCESS) {
+                       DEBUG(0,(__location__ ": Failed transaction commit - %s\n",
+                                ldb_errstring(sam_ctx)));
+                       return WERR_DS_DRA_INTERNAL_ERROR;
+               }
+       }
+
        /* ignore it if its an empty change. Note that renames always
         * change the 'name' attribute, so they won't be ignored by
-        * this */
+        * this
+
+        * the force_object_return check is used to force an empty
+        * object return when we timeout in the getncchanges loop.
+        * This allows us to return an empty object, which keeps the
+        * client happy while preventing timeouts
+        */
        if (n == 0 ||
-           (n == 1 && attids[0] == DRSUAPI_ATTRIBUTE_instanceType)) {
+           (n == 1 &&
+            attids[0] == DRSUAPI_ATTID_instanceType &&
+            !force_object_return)) {
                talloc_free(obj->meta_data_ctr);
                obj->meta_data_ctr = NULL;
                return WERR_OK;
@@ -273,6 +525,9 @@ static WERROR get_nc_changes_build_object(struct drsuapi_DsReplicaObjectListItem
        obj->object.attribute_ctr.num_attributes = obj->meta_data_ctr->count;
        obj->object.attribute_ctr.attributes = talloc_array(obj, struct drsuapi_DsReplicaAttribute,
                                                            obj->object.attribute_ctr.num_attributes);
+       if (obj->object.attribute_ctr.attributes == NULL) {
+               return WERR_NOT_ENOUGH_MEMORY;
+       }
 
        /*
         * Note that the meta_data array and the attributes array must
@@ -280,9 +535,8 @@ static WERROR get_nc_changes_build_object(struct drsuapi_DsReplicaObjectListItem
         */
        for (i=0; i<obj->object.attribute_ctr.num_attributes; i++) {
                struct ldb_message_element *el;
-               WERROR werr;
                const struct dsdb_attribute *sa;
-       
+
                sa = dsdb_attribute_by_attributeID_id(schema, attids[i]);
                if (!sa) {
                        DEBUG(0,("Unable to find attributeID %u in schema\n", attids[i]));
@@ -301,8 +555,9 @@ static WERROR get_nc_changes_build_object(struct drsuapi_DsReplicaObjectListItem
                        werr = sa->syntax->ldb_to_drsuapi(&syntax_ctx, sa, el, obj,
                                                          &obj->object.attribute_ctr.attributes[i]);
                        if (!W_ERROR_IS_OK(werr)) {
-                               DEBUG(0,("Unable to convert %s to DRS object - %s\n", 
-                                        sa->lDAPDisplayName, win_errstr(werr)));
+                               DEBUG(0,("Unable to convert %s on %s to DRS object - %s\n",
+                                        sa->lDAPDisplayName, ldb_dn_get_linearized(msg->dn),
+                                        win_errstr(werr)));
                                return werr;
                        }
                        /* if DRSUAPI_DRS_SPECIAL_SECRET_PROCESSING is set
@@ -317,17 +572,27 @@ static WERROR get_nc_changes_build_object(struct drsuapi_DsReplicaObjectListItem
                        werr = drsuapi_encrypt_attribute(obj, session_key, rid, 
                                                         &obj->object.attribute_ctr.attributes[i]);
                        if (!W_ERROR_IS_OK(werr)) {
-                               DEBUG(0,("Unable to encrypt %s in DRS object - %s\n", 
-                                        sa->lDAPDisplayName, win_errstr(werr)));
+                               DEBUG(0,("Unable to encrypt %s on %s in DRS object - %s\n",
+                                        sa->lDAPDisplayName, ldb_dn_get_linearized(msg->dn),
+                                        win_errstr(werr)));
                                return werr;
                        }
                }
+               if (attids[i] != obj->object.attribute_ctr.attributes[i].attid) {
+                       DEBUG(0, ("Unable to replicate attribute %s on %s via DRS, incorrect attributeID:  "
+                                 "0x%08x vs 0x%08x "
+                                 "Run dbcheck!\n",
+                                 sa->lDAPDisplayName,
+                                 ldb_dn_get_linearized(msg->dn),
+                                 attids[i],
+                                 obj->object.attribute_ctr.attributes[i].attid));
+                       return WERR_DS_DATABASE_ERROR;
+               }
        }
 
        return WERR_OK;
 }
 
-
 /*
   add one linked attribute from an object to the list of linked
   attributes in a getncchanges request
@@ -336,10 +601,11 @@ static WERROR get_nc_changes_add_la(TALLOC_CTX *mem_ctx,
                                    struct ldb_context *sam_ctx,
                                    const struct dsdb_schema *schema,
                                    const struct dsdb_attribute *sa,
-                                   struct ldb_message *msg,
+                                   const struct ldb_message *msg,
                                    struct dsdb_dn *dsdb_dn,
                                    struct drsuapi_DsReplicaLinkedAttribute **la_list,
-                                   uint32_t *la_count)
+                                   uint32_t *la_count,
+                                   bool is_schema_nc)
 {
        struct drsuapi_DsReplicaLinkedAttribute *la;
        bool active;
@@ -356,30 +622,95 @@ static WERROR get_nc_changes_add_la(TALLOC_CTX *mem_ctx,
 
        active = (dsdb_dn_rmd_flags(dsdb_dn->dn) & DSDB_RMD_FLAG_DELETED) == 0;
 
-       la->attid = sa->attributeID_id;
+       if (!active) {
+               /* We have to check that the inactive link still point to an existing object */
+               struct GUID guid;
+               struct ldb_dn *tdn;
+               int ret;
+               const char *v;
+
+               v = ldb_msg_find_attr_as_string(msg, "isDeleted", "FALSE");
+               if (strncmp(v, "TRUE", 4) == 0) {
+                       /*
+                         * Note: we skip the transmition of the deleted link even if the other part used to
+                         * know about it because when we transmit the deletion of the object, the link will
+                         * be deleted too due to deletion of object where link points and Windows do so.
+                         */
+                       if (dsdb_functional_level(sam_ctx) >= DS_DOMAIN_FUNCTION_2008_R2) {
+                               v = ldb_msg_find_attr_as_string(msg, "isRecycled", "FALSE");
+                               /*
+                                * On Windows 2008R2 isRecycled is always present even if FL or DL are < FL 2K8R2
+                                * if it join an existing domain with deleted objets, it firsts impose to have a
+                                * schema with the is-Recycled object and for all deleted objects it adds the isRecycled
+                                * either during initial replication or after the getNCChanges.
+                                * Behavior of samba has been changed to always have this attribute if it's present in the schema.
+                                *
+                                * So if FL <2K8R2 isRecycled might be here or not but we don't care, it's meaning less.
+                                * If FL >=2K8R2 we are sure that this attribute will be here.
+                                * For this kind of forest level we do not return the link if the object is recycled
+                                * (isRecycled = true).
+                                */
+                               if (strncmp(v, "TRUE", 4) == 0) {
+                                       DEBUG(2, (" object %s is recycled, not returning linked attribute !\n",
+                                                               ldb_dn_get_linearized(msg->dn)));
+                                       return WERR_OK;
+                               }
+                       } else {
+                               return WERR_OK;
+                       }
+               }
+               status = dsdb_get_extended_dn_guid(dsdb_dn->dn, &guid, "GUID");
+               if (!NT_STATUS_IS_OK(status)) {
+                       DEBUG(0,(__location__ " Unable to extract GUID in linked attribute '%s' in '%s'\n",
+                               sa->lDAPDisplayName, ldb_dn_get_linearized(msg->dn)));
+                       return ntstatus_to_werror(status);
+               }
+               ret = dsdb_find_dn_by_guid(sam_ctx, mem_ctx, &guid, 0, &tdn);
+               if (ret == LDB_ERR_NO_SUCH_OBJECT) {
+                       DEBUG(2, (" Search of guid %s returned 0 objects, skipping it !\n",
+                                               GUID_string(mem_ctx, &guid)));
+                       return WERR_OK;
+               } else if (ret != LDB_SUCCESS) {
+                       DEBUG(0, (__location__ " Search of guid %s failed with error code %d\n",
+                                               GUID_string(mem_ctx, &guid),
+                                               ret));
+                       return WERR_OK;
+               }
+       }
+       la->attid = dsdb_attribute_get_attid(sa, is_schema_nc);
        la->flags = active?DRSUAPI_DS_LINKED_ATTRIBUTE_FLAG_ACTIVE:0;
 
-       status = dsdb_get_extended_dn_nttime(dsdb_dn->dn, &la->originating_add_time, "RMD_ADDTIME");
-       if (!NT_STATUS_IS_OK(status)) {
-               return ntstatus_to_werror(status);
-       }
        status = dsdb_get_extended_dn_uint32(dsdb_dn->dn, &la->meta_data.version, "RMD_VERSION");
        if (!NT_STATUS_IS_OK(status)) {
+               DEBUG(0,(__location__ " No RMD_VERSION in linked attribute '%s' in '%s'\n",
+                        sa->lDAPDisplayName, ldb_dn_get_linearized(msg->dn)));
                return ntstatus_to_werror(status);
        }
        status = dsdb_get_extended_dn_nttime(dsdb_dn->dn, &la->meta_data.originating_change_time, "RMD_CHANGETIME");
        if (!NT_STATUS_IS_OK(status)) {
+               DEBUG(0,(__location__ " No RMD_CHANGETIME in linked attribute '%s' in '%s'\n",
+                        sa->lDAPDisplayName, ldb_dn_get_linearized(msg->dn)));
                return ntstatus_to_werror(status);
        }
        status = dsdb_get_extended_dn_guid(dsdb_dn->dn, &la->meta_data.originating_invocation_id, "RMD_INVOCID");
        if (!NT_STATUS_IS_OK(status)) {
+               DEBUG(0,(__location__ " No RMD_INVOCID in linked attribute '%s' in '%s'\n",
+                        sa->lDAPDisplayName, ldb_dn_get_linearized(msg->dn)));
                return ntstatus_to_werror(status);
        }
        status = dsdb_get_extended_dn_uint64(dsdb_dn->dn, &la->meta_data.originating_usn, "RMD_ORIGINATING_USN");
        if (!NT_STATUS_IS_OK(status)) {
+               DEBUG(0,(__location__ " No RMD_ORIGINATING_USN in linked attribute '%s' in '%s'\n",
+                        sa->lDAPDisplayName, ldb_dn_get_linearized(msg->dn)));
                return ntstatus_to_werror(status);
        }
 
+       status = dsdb_get_extended_dn_nttime(dsdb_dn->dn, &la->originating_add_time, "RMD_ADDTIME");
+       if (!NT_STATUS_IS_OK(status)) {
+               /* this is possible for upgraded links */
+               la->originating_add_time = la->meta_data.originating_change_time;
+       }
+
        werr = dsdb_dn_la_to_blob(sam_ctx, sa, schema, *la_list, dsdb_dn, &la->value.blob);
        W_ERROR_NOT_OK_RETURN(werr);
 
@@ -395,17 +726,34 @@ static WERROR get_nc_changes_add_la(TALLOC_CTX *mem_ctx,
 static WERROR get_nc_changes_add_links(struct ldb_context *sam_ctx,
                                       TALLOC_CTX *mem_ctx,
                                       struct ldb_dn *ncRoot_dn,
+                                      bool is_schema_nc,
                                       struct dsdb_schema *schema,
                                       uint64_t highest_usn,
                                       uint32_t replica_flags,
-                                      struct ldb_message *msg,
+                                      const struct ldb_message *msg,
                                       struct drsuapi_DsReplicaLinkedAttribute **la_list,
                                       uint32_t *la_count,
                                       struct drsuapi_DsReplicaCursorCtrEx *uptodateness_vector)
 {
        unsigned int i;
-       TALLOC_CTX *tmp_ctx = talloc_new(mem_ctx);
-       uint64_t uSNChanged = ldb_msg_find_attr_as_int(msg, "uSNChanged", -1);
+       TALLOC_CTX *tmp_ctx = NULL;
+       uint64_t uSNChanged = ldb_msg_find_attr_as_uint64(msg, "uSNChanged", 0);
+       bool is_critical = ldb_msg_find_attr_as_bool(msg, "isCriticalSystemObject", false);
+
+       if (replica_flags & DRSUAPI_DRS_CRITICAL_ONLY) {
+               if (!is_critical) {
+                       return WERR_OK;
+               }
+       }
+
+       if (uSNChanged <= highest_usn) {
+               return WERR_OK;
+       }
+
+       tmp_ctx = talloc_new(mem_ctx);
+       if (tmp_ctx == NULL) {
+               return WERR_NOT_ENOUGH_MEMORY;
+       }
 
        for (i=0; i<msg->num_elements; i++) {
                struct ldb_message_element *el = &msg->elements[i];
@@ -428,8 +776,10 @@ static WERROR get_nc_changes_add_links(struct ldb_context *sam_ctx,
                for (j=0; j<el->num_values; j++) {
                        struct dsdb_dn *dsdb_dn;
                        uint64_t local_usn;
-                       NTSTATUS status;
+                       uint64_t originating_usn;
+                       NTSTATUS status, status2;
                        WERROR werr;
+                       struct GUID originating_invocation_id;
 
                        dsdb_dn = dsdb_dn_parse(tmp_ctx, sam_ctx, &el->values[j], sa->syntax->ldap_oid);
                        if (dsdb_dn == NULL) {
@@ -454,12 +804,28 @@ static WERROR get_nc_changes_add_links(struct ldb_context *sam_ctx,
                                return WERR_DS_DRA_INTERNAL_ERROR;
                        }
 
-                       if (local_usn < highest_usn) {
+                       if (local_usn <= highest_usn) {
                                continue;
                        }
 
-                       werr = get_nc_changes_add_la(mem_ctx, sam_ctx, schema, sa, msg,
-                                                    dsdb_dn, la_list, la_count);
+                       status = dsdb_get_extended_dn_guid(dsdb_dn->dn,
+                                                          &originating_invocation_id,
+                                                          "RMD_INVOCID");
+                       status2 = dsdb_get_extended_dn_uint64(dsdb_dn->dn,
+                                                             &originating_usn,
+                                                             "RMD_ORIGINATING_USN");
+
+                       if (NT_STATUS_IS_OK(status) && NT_STATUS_IS_OK(status2)) {
+                               if (udv_filter(uptodateness_vector,
+                                              &originating_invocation_id,
+                                              originating_usn)) {
+                                       continue;
+                               }
+                       }
+
+                       werr = get_nc_changes_add_la(mem_ctx, sam_ctx, schema,
+                                                    sa, msg, dsdb_dn, la_list,
+                                                    la_count, is_schema_nc);
                        if (!W_ERROR_IS_OK(werr)) {
                                talloc_free(tmp_ctx);
                                return werr;
@@ -490,104 +856,72 @@ static WERROR get_nc_changes_udv(struct ldb_context *sam_ctx,
                         ldb_dn_get_linearized(ncRoot_dn), ldb_errstring(sam_ctx)));
                return WERR_DS_DRA_INTERNAL_ERROR;
        }
-       
+
        return WERR_OK;
 }
 
 
 /* comparison function for linked attributes - see CompareLinks() in
  * MS-DRSR section 4.1.10.5.17 */
-static int linked_attribute_compare(const struct drsuapi_DsReplicaLinkedAttribute *la1,
-                                   const struct drsuapi_DsReplicaLinkedAttribute *la2,
-                                   struct ldb_context *sam_ctx)
+static int linked_attribute_compare(const struct la_for_sorting *la1,
+                                   const struct la_for_sorting *la2,
+                                   void *opaque)
 {
        int c;
-       WERROR werr;
-       TALLOC_CTX *tmp_ctx;
-       const struct dsdb_schema *schema;
-       const struct dsdb_attribute *schema_attrib;
-       struct dsdb_dn *dn1, *dn2;
-       struct GUID guid1, guid2;
-       NTSTATUS status;
-
-       c = GUID_compare(&la1->identifier->guid,
-                        &la2->identifier->guid);
-       if (c != 0) return c;
+       c = memcmp(la1->source_guid,
+                  la2->source_guid, sizeof(la2->source_guid));
+       if (c != 0) {
+               return c;
+       }
 
-       if (la1->attid != la2->attid) {
-               return la1->attid < la2->attid? -1:1;
+       if (la1->link->attid != la2->link->attid) {
+               return la1->link->attid < la2->link->attid? -1:1;
        }
 
-       if ((la1->flags & DRSUAPI_DS_LINKED_ATTRIBUTE_FLAG_ACTIVE) !=
-           (la2->flags & DRSUAPI_DS_LINKED_ATTRIBUTE_FLAG_ACTIVE)) {
-               return (la1->flags & DRSUAPI_DS_LINKED_ATTRIBUTE_FLAG_ACTIVE)? 1:-1;
+       if ((la1->link->flags & DRSUAPI_DS_LINKED_ATTRIBUTE_FLAG_ACTIVE) !=
+           (la2->link->flags & DRSUAPI_DS_LINKED_ATTRIBUTE_FLAG_ACTIVE)) {
+               return (la1->link->flags &
+                       DRSUAPI_DS_LINKED_ATTRIBUTE_FLAG_ACTIVE)? 1:-1;
        }
 
-       /* we need to get the target GUIDs to compare */
-       tmp_ctx = talloc_new(sam_ctx);
+       return memcmp(la1->target_guid,
+                     la2->target_guid, sizeof(la2->target_guid));
+}
 
-       schema = dsdb_get_schema(sam_ctx, tmp_ctx);
-       schema_attrib = dsdb_attribute_by_attributeID_id(schema, la1->attid);
+struct drsuapi_changed_objects {
+       struct ldb_dn *dn;
+       struct GUID guid;
+       uint64_t usn;
+};
 
-       werr = dsdb_dn_la_from_blob(sam_ctx, schema_attrib, schema, tmp_ctx, la1->value.blob, &dn1);
-       if (!W_ERROR_IS_OK(werr)) {
-               DEBUG(0,(__location__ ": Bad la1 blob in sort\n"));
-               talloc_free(tmp_ctx);
-               return 0;
-       }
+/*
+  sort the objects we send first by uSNChanged
+ */
+static int site_res_cmp_usn_order(struct drsuapi_changed_objects *m1,
+                                 struct drsuapi_changed_objects *m2,
+                                 struct drsuapi_getncchanges_state *getnc_state)
+{
+       int ret;
 
-       werr = dsdb_dn_la_from_blob(sam_ctx, schema_attrib, schema, tmp_ctx, la2->value.blob, &dn2);
-       if (!W_ERROR_IS_OK(werr)) {
-               DEBUG(0,(__location__ ": Bad la2 blob in sort\n"));
-               talloc_free(tmp_ctx);
-               return 0;
+       ret = ldb_dn_compare(getnc_state->ncRoot_dn, m1->dn);
+       if (ret == 0) {
+               return -1;
        }
 
-       status = dsdb_get_extended_dn_guid(dn1->dn, &guid1, "GUID");
-       if (!NT_STATUS_IS_OK(status)) {
-               DEBUG(0,(__location__ ": Bad la1 guid in sort\n"));
-               talloc_free(tmp_ctx);
-               return 0;
-       }
-       status = dsdb_get_extended_dn_guid(dn2->dn, &guid2, "GUID");
-       if (!NT_STATUS_IS_OK(status)) {
-               DEBUG(0,(__location__ ": Bad la2 guid in sort\n"));
-               talloc_free(tmp_ctx);
-               return 0;
+       ret = ldb_dn_compare(getnc_state->ncRoot_dn, m2->dn);
+       if (ret == 0) {
+               return 1;
        }
 
-       talloc_free(tmp_ctx);
-
-       return GUID_compare(&guid1, &guid2);
-}
-
+       if (m1->usn == m2->usn) {
+               return ldb_dn_compare(m2->dn, m1->dn);
+       }
 
-/*
-  sort the objects we send by tree order
- */
-static int site_res_cmp_parent_order(struct ldb_message **m1, struct ldb_message **m2)
-{
-       return ldb_dn_compare((*m2)->dn, (*m1)->dn);
-}
+       if (m1->usn < m2->usn) {
+               return -1;
+       }
 
-/*
-  sort the objects we send first by uSNChanged
- */
-static int site_res_cmp_usn_order(struct ldb_message **m1, struct ldb_message **m2)
-{
-       unsigned usnchanged1, usnchanged2;
-       unsigned cn1, cn2;
-       cn1 = ldb_dn_get_comp_num((*m1)->dn);
-       cn2 = ldb_dn_get_comp_num((*m2)->dn);
-       if (cn1 != cn2) {
-               return cn1 > cn2 ? 1 : -1;
-       }
-       usnchanged1 = ldb_msg_find_attr_as_uint(*m1, "uSNChanged", 0);
-       usnchanged2 = ldb_msg_find_attr_as_uint(*m2, "uSNChanged", 0);
-       if (usnchanged1 == usnchanged2) {
-               return 0;
-       }
-       return usnchanged1 > usnchanged2 ? 1 : -1;
+       return 1;
 }
 
 
@@ -597,14 +931,15 @@ static int site_res_cmp_usn_order(struct ldb_message **m1, struct ldb_message **
 static WERROR getncchanges_rid_alloc(struct drsuapi_bind_state *b_state,
                                     TALLOC_CTX *mem_ctx,
                                     struct drsuapi_DsGetNCChangesRequest10 *req10,
-                                    struct drsuapi_DsGetNCChangesCtr6 *ctr6)
+                                    struct drsuapi_DsGetNCChangesCtr6 *ctr6,
+                                    struct ldb_dn **rid_manager_dn)
 {
-       struct ldb_dn *rid_manager_dn, *fsmo_role_dn, *req_dn;
+       struct ldb_dn *req_dn, *ntds_dn = NULL;
        int ret;
        struct ldb_context *ldb = b_state->sam_ctx;
        struct ldb_result *ext_res;
-       struct ldb_dn *base_dn;
        struct dsdb_fsmo_extended_op *exop;
+       bool is_us;
 
        /*
          steps:
@@ -612,17 +947,16 @@ static WERROR getncchanges_rid_alloc(struct drsuapi_bind_state *b_state,
            - verify that we are the RID Manager
         */
 
-       /* work out who is the RID Manager */
-       ret = samdb_rid_manager_dn(ldb, mem_ctx, &rid_manager_dn);
+       /* work out who is the RID Manager, also return to caller */
+       ret = samdb_rid_manager_dn(ldb, mem_ctx, rid_manager_dn);
        if (ret != LDB_SUCCESS) {
                DEBUG(0, (__location__ ": Failed to find RID Manager object - %s\n", ldb_errstring(ldb)));
                return WERR_DS_DRA_INTERNAL_ERROR;
        }
 
        req_dn = drs_ObjectIdentifier_to_dn(mem_ctx, ldb, req10->naming_context);
-       if (!req_dn ||
-           !ldb_dn_validate(req_dn) ||
-           ldb_dn_compare(req_dn, rid_manager_dn) != 0) {
+       if (!ldb_dn_validate(req_dn) ||
+           ldb_dn_compare(req_dn, *rid_manager_dn) != 0) {
                /* that isn't the RID Manager DN */
                DEBUG(0,(__location__ ": RID Alloc request for wrong DN %s\n",
                         drs_ObjectIdentifier_to_string(mem_ctx, req10->naming_context)));
@@ -630,16 +964,24 @@ static WERROR getncchanges_rid_alloc(struct drsuapi_bind_state *b_state,
                return WERR_OK;
        }
 
+       /* TODO: make sure ntds_dn is a valid nTDSDSA object */
+       ret = dsdb_find_dn_by_guid(ldb, mem_ctx, &req10->destination_dsa_guid, 0, &ntds_dn);
+       if (ret != LDB_SUCCESS) {
+               DEBUG(0, (__location__ ": Unable to find NTDS object for guid %s - %s\n",
+                         GUID_string(mem_ctx, &req10->destination_dsa_guid), ldb_errstring(ldb)));
+               ctr6->extended_ret = DRSUAPI_EXOP_ERR_UNKNOWN_CALLER;
+               return WERR_OK;
+       }
+
        /* find the DN of the RID Manager */
-       ret = samdb_reference_dn(ldb, mem_ctx, rid_manager_dn, "fSMORoleOwner", &fsmo_role_dn);
+       ret = samdb_reference_dn_is_our_ntdsa(ldb, *rid_manager_dn, "fSMORoleOwner", &is_us);
        if (ret != LDB_SUCCESS) {
-               DEBUG(0,(__location__ ": Failed to find fSMORoleOwner in RID Manager object - %s\n",
-                        ldb_errstring(ldb)));
+               DEBUG(0,("Failed to find fSMORoleOwner in RID Manager object\n"));
                ctr6->extended_ret = DRSUAPI_EXOP_ERR_FSMO_NOT_OWNER;
                return WERR_DS_DRA_INTERNAL_ERROR;
        }
 
-       if (ldb_dn_compare(samdb_ntds_settings_dn(ldb), fsmo_role_dn) != 0) {
+       if (!is_us) {
                /* we're not the RID Manager - go away */
                DEBUG(0,(__location__ ": RID Alloc request when not RID Manager\n"));
                ctr6->extended_ret = DRSUAPI_EXOP_ERR_FSMO_NOT_OWNER;
@@ -659,15 +1001,6 @@ static WERROR getncchanges_rid_alloc(struct drsuapi_bind_state *b_state,
                return WERR_DS_DRA_INTERNAL_ERROR;
        }
 
-       /*
-        * FIXME (kim): this is a temp hack to return just few object,
-        * but not the whole domain NC.
-        * We should remove this hack and implement a 'scope'
-        * building function to return just the set of object
-        * documented for DRSUAPI_EXOP_FSMO_RID_ALLOC extended_op
-        */
-       ldb_sequence_number(ldb, LDB_SEQ_HIGHEST_SEQ, &req10->highwatermark.highest_usn);
-
        ret = ldb_extended(ldb, DSDB_EXTENDED_ALLOCATE_RID_POOL, exop, &ext_res);
        if (ret != LDB_SUCCESS) {
                DEBUG(0,(__location__ ": Failed extended allocation RID pool operation - %s\n",
@@ -685,8 +1018,6 @@ static WERROR getncchanges_rid_alloc(struct drsuapi_bind_state *b_state,
 
        talloc_free(ext_res);
 
-       base_dn = ldb_get_default_basedn(ldb);
-
        DEBUG(2,("Allocated RID pool for server %s\n",
                 GUID_string(mem_ctx, &req10->destination_dsa_guid)));
 
@@ -801,12 +1132,16 @@ static WERROR getncchanges_repl_secret(struct drsuapi_bind_state *b_state,
                                       TALLOC_CTX *mem_ctx,
                                       struct drsuapi_DsGetNCChangesRequest10 *req10,
                                       struct dom_sid *user_sid,
-                                      struct drsuapi_DsGetNCChangesCtr6 *ctr6)
+                                      struct drsuapi_DsGetNCChangesCtr6 *ctr6,
+                                      bool has_get_all_changes,
+                                      struct ldb_dn **machine_dn)
 {
        struct drsuapi_DsReplicaObjectIdentifier *ncRoot = req10->naming_context;
-       struct ldb_dn *obj_dn, *rodc_dn, *krbtgt_link_dn;
+       struct ldb_dn *obj_dn = NULL;
+       struct ldb_dn *ntds_dn = NULL, *server_dn = NULL;
+       struct ldb_dn *rodc_dn, *krbtgt_link_dn;
        int ret;
-       const char *rodc_attrs[] = { "msDS-KrbTgtLink", "msDS-NeverRevealGroup", "msDS-RevealOnDemandGroup", NULL };
+       const char *rodc_attrs[] = { "msDS-KrbTgtLink", "msDS-NeverRevealGroup", "msDS-RevealOnDemandGroup", "objectGUID", NULL };
        const char *obj_attrs[] = { "tokenGroups", "objectSid", "UserAccountControl", "msDS-KrbTgtLinkBL", NULL };
        struct ldb_result *rodc_res, *obj_res;
        const struct dom_sid **never_reveal_sids, **reveal_sids, **token_sids;
@@ -816,7 +1151,7 @@ static WERROR getncchanges_repl_secret(struct drsuapi_bind_state *b_state,
                 drs_ObjectIdentifier_to_string(mem_ctx, ncRoot)));
 
        /*
-        * we need to work out if we will allow this RODC to
+        * we need to work out if we will allow this DC to
         * replicate the secrets for this object
         *
         * see 4.1.10.5.14 GetRevealSecretsPolicyForUser for details
@@ -829,6 +1164,55 @@ static WERROR getncchanges_repl_secret(struct drsuapi_bind_state *b_state,
                return WERR_DS_DRA_SOURCE_DISABLED;
        }
 
+       /*
+        * Before we accept or deny, fetch the machine DN for the destination
+        * DSA GUID.
+        *
+        * If we are the RODC, we will check that this matches the SID.
+        */
+       ret = dsdb_find_dn_by_guid(b_state->sam_ctx_system, mem_ctx,
+                                  &req10->destination_dsa_guid, 0,
+                                  &ntds_dn);
+       if (ret != LDB_SUCCESS) {
+               goto failed;
+       }
+
+       server_dn = ldb_dn_get_parent(mem_ctx, ntds_dn);
+       if (server_dn == NULL) {
+               goto failed;
+       }
+
+       ret = samdb_reference_dn(b_state->sam_ctx_system, mem_ctx, server_dn,
+                                "serverReference", machine_dn);
+
+       if (ret != LDB_SUCCESS) {
+               goto failed;
+       }
+
+       /*
+        * In MS-DRSR.pdf 5.99 IsGetNCChangesPermissionGranted
+        *
+        * The pseudo code indicate
+        * revealsecrets = true
+        * if IsRevealSecretRequest(msgIn) then
+        *   if AccessCheckCAR(ncRoot, Ds-Replication-Get-Changes-All) = false
+        *   then
+        *     if (msgIn.ulExtendedOp = EXOP_REPL_SECRETS) then
+        *     <... check if this account is ok to be replicated on this DC ...>
+        *     <... and if not reveal secrets = no ...>
+        *     else
+        *       reveal secrets = false
+        *     endif
+        *   endif
+        * endif
+        *
+        * Which basically means that if you have GET_ALL_CHANGES rights (~== RWDC)
+        * then you can do EXOP_REPL_SECRETS
+        */
+       if (has_get_all_changes) {
+               goto allowed;
+       }
+
        obj_dn = drs_ObjectIdentifier_to_dn(mem_ctx, b_state->sam_ctx_system, ncRoot);
        if (!ldb_dn_validate(obj_dn)) goto failed;
 
@@ -850,6 +1234,14 @@ static WERROR getncchanges_repl_secret(struct drsuapi_bind_state *b_state,
                goto allowed;
        }
 
+       /*
+        * Must be an RODC account at this point, verify machine DN matches the
+        * SID account
+        */
+       if (ldb_dn_compare(rodc_res->msgs[0]->dn, *machine_dn) != 0) {
+               goto denied;
+       }
+
        /* an RODC is allowed to get its own krbtgt account secrets */
        krbtgt_link_dn = samdb_result_dn(b_state->sam_ctx_system, mem_ctx,
                                         rodc_res->msgs[0], "msDS-KrbTgtLink", NULL);
@@ -864,7 +1256,8 @@ static WERROR getncchanges_repl_secret(struct drsuapi_bind_state *b_state,
                goto denied;
        }
 
-       if (samdb_result_uint(obj_res->msgs[0], "UserAccountControl", 0) &
+       if (ldb_msg_find_attr_as_uint(obj_res->msgs[0],
+                                     "userAccountControl", 0) &
            UF_INTERDOMAIN_TRUST_ACCOUNT) {
                goto denied;
        }
@@ -899,26 +1292,26 @@ static WERROR getncchanges_repl_secret(struct drsuapi_bind_state *b_state,
 
        /* default deny */
 denied:
-       DEBUG(2,(__location__ ": Denied RODC secret replication for %s by RODC %s\n",
+       DEBUG(2,(__location__ ": Denied single object with secret replication for %s by RODC %s\n",
                 ldb_dn_get_linearized(obj_dn), ldb_dn_get_linearized(rodc_res->msgs[0]->dn)));
        ctr6->extended_ret = DRSUAPI_EXOP_ERR_NONE;
-       return WERR_DS_DRA_ACCESS_DENIED;
+       return WERR_DS_DRA_SECRETS_DENIED;
 
 allowed:
-       DEBUG(2,(__location__ ": Allowed RODC secret replication for %s by RODC %s\n",
-                ldb_dn_get_linearized(obj_dn), ldb_dn_get_linearized(rodc_res->msgs[0]->dn)));
+       DEBUG(2,(__location__ ": Allowed single object with secret replication for %s by %s %s\n",
+                ldb_dn_get_linearized(obj_dn), has_get_all_changes?"RWDC":"RODC",
+                ldb_dn_get_linearized(rodc_res->msgs[0]->dn)));
        ctr6->extended_ret = DRSUAPI_EXOP_ERR_SUCCESS;
        req10->highwatermark.highest_usn = 0;
        return WERR_OK;
 
 failed:
-       DEBUG(2,(__location__ ": Failed RODC secret replication for %s by RODC %s\n",
+       DEBUG(2,(__location__ ": Failed single secret replication for %s by RODC %s\n",
                 ldb_dn_get_linearized(obj_dn), dom_sid_string(mem_ctx, user_sid)));
        ctr6->extended_ret = DRSUAPI_EXOP_ERR_NONE;
        return WERR_DS_DRA_BAD_DN;
 }
 
-
 /*
   handle a DRSUAPI_EXOP_REPL_OBJ call
  */
@@ -934,7 +1327,6 @@ static WERROR getncchanges_repl_obj(struct drsuapi_bind_state *b_state,
                 drs_ObjectIdentifier_to_string(mem_ctx, ncRoot)));
 
        ctr6->extended_ret = DRSUAPI_EXOP_ERR_SUCCESS;
-       req10->highwatermark.highest_usn = 0;
        return WERR_OK;
 }
 
@@ -949,11 +1341,12 @@ static WERROR getncchanges_change_master(struct drsuapi_bind_state *b_state,
                                         struct drsuapi_DsGetNCChangesRequest10 *req10,
                                         struct drsuapi_DsGetNCChangesCtr6 *ctr6)
 {
-       struct ldb_dn *fsmo_role_dn, *req_dn, *ntds_dn;
+       struct ldb_dn *req_dn, *ntds_dn;
        int ret;
        unsigned int i;
        struct ldb_context *ldb = b_state->sam_ctx;
        struct ldb_message *msg;
+       bool is_us;
 
        /*
          steps:
@@ -962,8 +1355,7 @@ static WERROR getncchanges_change_master(struct drsuapi_bind_state *b_state,
         */
 
        req_dn = drs_ObjectIdentifier_to_dn(mem_ctx, ldb, req10->naming_context);
-       if (!req_dn ||
-           !ldb_dn_validate(req_dn)) {
+       if (!ldb_dn_validate(req_dn)) {
                /* that is not a valid dn */
                DEBUG(0,(__location__ ": FSMO role transfer request for invalid DN %s\n",
                         drs_ObjectIdentifier_to_string(mem_ctx, req10->naming_context)));
@@ -971,18 +1363,17 @@ static WERROR getncchanges_change_master(struct drsuapi_bind_state *b_state,
                return WERR_OK;
        }
 
-       /* retrieve the current role owner */
-       ret = samdb_reference_dn(ldb, mem_ctx, req_dn, "fSMORoleOwner", &fsmo_role_dn);
+       /* find the DN of the current role owner */
+       ret = samdb_reference_dn_is_our_ntdsa(ldb, req_dn, "fSMORoleOwner", &is_us);
        if (ret != LDB_SUCCESS) {
-               DEBUG(0,(__location__ ": Failed to find fSMORoleOwner in context - %s\n",
-                        ldb_errstring(ldb)));
+               DEBUG(0,("Failed to find fSMORoleOwner in RID Manager object\n"));
                ctr6->extended_ret = DRSUAPI_EXOP_ERR_FSMO_NOT_OWNER;
                return WERR_DS_DRA_INTERNAL_ERROR;
        }
 
-       if (ldb_dn_compare(samdb_ntds_settings_dn(ldb), fsmo_role_dn) != 0) {
-               /* we're not the current owner - go away */
-               DEBUG(0,(__location__ ": FSMO transfer request when not owner\n"));
+       if (!is_us) {
+               /* we're not the RID Manager or role owner - go away */
+               DEBUG(0,(__location__ ": FSMO role or RID manager transfer owner request when not role owner\n"));
                ctr6->extended_ret = DRSUAPI_EXOP_ERR_FSMO_NOT_OWNER;
                return WERR_OK;
        }
@@ -993,12 +1384,14 @@ static WERROR getncchanges_change_master(struct drsuapi_bind_state *b_state,
        msg->dn = drs_ObjectIdentifier_to_dn(msg, ldb, req10->naming_context);
        W_ERROR_HAVE_NO_MEMORY(msg->dn);
 
-       ret = dsdb_find_dn_by_guid(ldb, msg, &req10->destination_dsa_guid, &ntds_dn);
+       /* TODO: make sure ntds_dn is a valid nTDSDSA object */
+       ret = dsdb_find_dn_by_guid(ldb, msg, &req10->destination_dsa_guid, 0, &ntds_dn);
        if (ret != LDB_SUCCESS) {
                DEBUG(0, (__location__ ": Unable to find NTDS object for guid %s - %s\n",
                          GUID_string(mem_ctx, &req10->destination_dsa_guid), ldb_errstring(ldb)));
                talloc_free(msg);
-               return WERR_DS_DRA_INTERNAL_ERROR;
+               ctr6->extended_ret = DRSUAPI_EXOP_ERR_UNKNOWN_CALLER;
+               return WERR_OK;
        }
 
        ret = ldb_msg_add_string(msg, "fSMORoleOwner", ldb_dn_get_linearized(ntds_dn));
@@ -1038,32 +1431,18 @@ static WERROR getncchanges_change_master(struct drsuapi_bind_state *b_state,
        return WERR_OK;
 }
 
-/* state of a partially completed getncchanges call */
-struct drsuapi_getncchanges_state {
-       struct ldb_result *site_res;
-       uint32_t num_sent;
-       struct ldb_dn *ncRoot_dn;
-       bool is_schema_nc;
-       uint64_t min_usn;
-       uint64_t highest_usn;
-       struct ldb_dn *last_dn;
-       struct drsuapi_DsReplicaLinkedAttribute *la_list;
-       uint32_t la_count;
-       bool la_sorted;
-       uint32_t la_idx;
-       struct drsuapi_DsReplicaCursorCtrEx *uptodateness_vector;
-};
-
 /*
   see if this getncchanges request includes a request to reveal secret information
  */
 static WERROR dcesrv_drsuapi_is_reveal_secrets_request(struct drsuapi_bind_state *b_state,
                                                       struct drsuapi_DsGetNCChangesRequest10 *req10,
+                                                      struct dsdb_schema_prefixmap *pfm_remote,
                                                       bool *is_secret_request)
 {
        enum drsuapi_DsExtendedOperation exop;
-       int i;
+       uint32_t i;
        struct dsdb_schema *schema;
+       struct dsdb_syntax_ctx syntax_ctx;
 
        *is_secret_request = true;
 
@@ -1097,30 +1476,50 @@ static WERROR dcesrv_drsuapi_is_reveal_secrets_request(struct drsuapi_bind_state
        }
 
        schema = dsdb_get_schema(b_state->sam_ctx, NULL);
+       dsdb_syntax_ctx_init(&syntax_ctx, b_state->sam_ctx, schema);
+       syntax_ctx.pfm_remote = pfm_remote;
 
        /* check the attributes they asked for */
        for (i=0; i<req10->partial_attribute_set->num_attids; i++) {
                const struct dsdb_attribute *sa;
-               sa = dsdb_attribute_by_attributeID_id(schema, req10->partial_attribute_set->attids[i]);
-               if (sa == NULL) {
-                       return WERR_DS_DRA_SCHEMA_MISMATCH;
+               WERROR werr = getncchanges_attid_remote_to_local(schema,
+                                                                &syntax_ctx,
+                                                                req10->partial_attribute_set->attids[i],
+                                                                NULL,
+                                                                &sa);
+
+               if (!W_ERROR_IS_OK(werr)) {
+                       DEBUG(0,(__location__": attid 0x%08X not found: %s\n",
+                                req10->partial_attribute_set->attids[i], win_errstr(werr)));
+                       return werr;
                }
+
                if (!dsdb_attr_in_rodc_fas(sa)) {
                        *is_secret_request = true;
                        return WERR_OK;
                }
        }
 
-       /* check the attributes they asked for */
-       for (i=0; i<req10->partial_attribute_set_ex->num_attids; i++) {
-               const struct dsdb_attribute *sa;
-               sa = dsdb_attribute_by_attributeID_id(schema, req10->partial_attribute_set_ex->attids[i]);
-               if (sa == NULL) {
-                       return WERR_DS_DRA_SCHEMA_MISMATCH;
-               }
-               if (!dsdb_attr_in_rodc_fas(sa)) {
-                       *is_secret_request = true;
-                       return WERR_OK;
+       if (req10->partial_attribute_set_ex) {
+               /* check the extended attributes they asked for */
+               for (i=0; i<req10->partial_attribute_set_ex->num_attids; i++) {
+                       const struct dsdb_attribute *sa;
+                       WERROR werr = getncchanges_attid_remote_to_local(schema,
+                                                                        &syntax_ctx,
+                                                                        req10->partial_attribute_set_ex->attids[i],
+                                                                        NULL,
+                                                                        &sa);
+
+                       if (!W_ERROR_IS_OK(werr)) {
+                               DEBUG(0,(__location__": attid 0x%08X not found: %s\n",
+                                        req10->partial_attribute_set_ex->attids[i], win_errstr(werr)));
+                               return werr;
+                       }
+
+                       if (!dsdb_attr_in_rodc_fas(sa)) {
+                               *is_secret_request = true;
+                               return WERR_OK;
+                       }
                }
        }
 
@@ -1128,28 +1527,116 @@ static WERROR dcesrv_drsuapi_is_reveal_secrets_request(struct drsuapi_bind_state
        return WERR_OK;
 }
 
-
 /*
-  map from req8 to req10
+  see if this getncchanges request is only for attributes in the GC
+  partial attribute set
  */
-static struct drsuapi_DsGetNCChangesRequest10 *
-getncchanges_map_req8(TALLOC_CTX *mem_ctx,
-                     struct drsuapi_DsGetNCChangesRequest8 *req8)
+static WERROR dcesrv_drsuapi_is_gc_pas_request(struct drsuapi_bind_state *b_state,
+                                              struct drsuapi_DsGetNCChangesRequest10 *req10,
+                                              struct dsdb_schema_prefixmap *pfm_remote,
+                                              bool *is_gc_pas_request)
 {
-       struct drsuapi_DsGetNCChangesRequest10 *req10 = talloc_zero(mem_ctx,
-                                                                   struct drsuapi_DsGetNCChangesRequest10);
-       if (req10 == NULL) {
-               return NULL;
-       }
+       enum drsuapi_DsExtendedOperation exop;
+       uint32_t i;
+       struct dsdb_schema *schema;
+       struct dsdb_syntax_ctx syntax_ctx;
 
-       req10->destination_dsa_guid = req8->destination_dsa_guid;
-       req10->source_dsa_invocation_id = req8->source_dsa_invocation_id;
-       req10->naming_context = req8->naming_context;
-       req10->highwatermark = req8->highwatermark;
-       req10->uptodateness_vector = req8->uptodateness_vector;
-       req10->replica_flags = req8->replica_flags;
-       req10->max_object_count = req8->max_object_count;
-       req10->max_ndr_size = req8->max_ndr_size;
+       exop = req10->extended_op;
+
+       switch (exop) {
+       case DRSUAPI_EXOP_FSMO_REQ_ROLE:
+       case DRSUAPI_EXOP_FSMO_RID_ALLOC:
+       case DRSUAPI_EXOP_FSMO_RID_REQ_ROLE:
+       case DRSUAPI_EXOP_FSMO_REQ_PDC:
+       case DRSUAPI_EXOP_FSMO_ABANDON_ROLE:
+       case DRSUAPI_EXOP_REPL_SECRET:
+               *is_gc_pas_request = false;
+               return WERR_OK;
+       case DRSUAPI_EXOP_REPL_OBJ:
+       case DRSUAPI_EXOP_NONE:
+               break;
+       }
+
+       if (req10->partial_attribute_set == NULL) {
+               /* they want it all */
+               *is_gc_pas_request = false;
+               return WERR_OK;
+       }
+
+       schema = dsdb_get_schema(b_state->sam_ctx, NULL);
+       dsdb_syntax_ctx_init(&syntax_ctx, b_state->sam_ctx, schema);
+       syntax_ctx.pfm_remote = pfm_remote;
+
+       /* check the attributes they asked for */
+       for (i=0; i<req10->partial_attribute_set->num_attids; i++) {
+               const struct dsdb_attribute *sa;
+               WERROR werr = getncchanges_attid_remote_to_local(schema,
+                                                                &syntax_ctx,
+                                                                req10->partial_attribute_set->attids[i],
+                                                                NULL,
+                                                                &sa);
+
+               if (!W_ERROR_IS_OK(werr)) {
+                       DEBUG(0,(__location__": attid 0x%08X not found: %s\n",
+                                req10->partial_attribute_set->attids[i], win_errstr(werr)));
+                       return werr;
+               }
+
+               if (!sa->isMemberOfPartialAttributeSet) {
+                       *is_gc_pas_request = false;
+                       return WERR_OK;
+               }
+       }
+
+       if (req10->partial_attribute_set_ex) {
+               /* check the extended attributes they asked for */
+               for (i=0; i<req10->partial_attribute_set_ex->num_attids; i++) {
+                       const struct dsdb_attribute *sa;
+                       WERROR werr = getncchanges_attid_remote_to_local(schema,
+                                                                        &syntax_ctx,
+                                                                        req10->partial_attribute_set_ex->attids[i],
+                                                                        NULL,
+                                                                        &sa);
+
+                       if (!W_ERROR_IS_OK(werr)) {
+                               DEBUG(0,(__location__": attid 0x%08X not found: %s\n",
+                                        req10->partial_attribute_set_ex->attids[i], win_errstr(werr)));
+                               return werr;
+                       }
+
+                       if (!sa->isMemberOfPartialAttributeSet) {
+                               *is_gc_pas_request = false;
+                               return WERR_OK;
+                       }
+               }
+       }
+
+       *is_gc_pas_request = true;
+       return WERR_OK;
+}
+
+
+/*
+  map from req8 to req10
+ */
+static struct drsuapi_DsGetNCChangesRequest10 *
+getncchanges_map_req8(TALLOC_CTX *mem_ctx,
+                     struct drsuapi_DsGetNCChangesRequest8 *req8)
+{
+       struct drsuapi_DsGetNCChangesRequest10 *req10 = talloc_zero(mem_ctx,
+                                                                   struct drsuapi_DsGetNCChangesRequest10);
+       if (req10 == NULL) {
+               return NULL;
+       }
+
+       req10->destination_dsa_guid = req8->destination_dsa_guid;
+       req10->source_dsa_invocation_id = req8->source_dsa_invocation_id;
+       req10->naming_context = req8->naming_context;
+       req10->highwatermark = req8->highwatermark;
+       req10->uptodateness_vector = req8->uptodateness_vector;
+       req10->replica_flags = req8->replica_flags;
+       req10->max_object_count = req8->max_object_count;
+       req10->max_ndr_size = req8->max_ndr_size;
        req10->extended_op = req8->extended_op;
        req10->fsmo_info = req8->fsmo_info;
        req10->partial_attribute_set = req8->partial_attribute_set;
@@ -1159,6 +1646,328 @@ getncchanges_map_req8(TALLOC_CTX *mem_ctx,
        return req10;
 }
 
+static const char *collect_objects_attrs[] = { "uSNChanged",
+                                              "objectGUID" ,
+                                              NULL };
+
+/**
+ * Collects object for normal replication cycle.
+ */
+static WERROR getncchanges_collect_objects(struct drsuapi_bind_state *b_state,
+                                          TALLOC_CTX *mem_ctx,
+                                          struct drsuapi_DsGetNCChangesRequest10 *req10,
+                                          struct ldb_dn *search_dn,
+                                          const char *extra_filter,
+                                          struct ldb_result **search_res)
+{
+       int ret;
+       char* search_filter;
+       enum ldb_scope scope = LDB_SCOPE_SUBTREE;
+       struct drsuapi_getncchanges_state *getnc_state = b_state->getncchanges_state;
+       bool critical_only = false;
+
+       if (req10->replica_flags & DRSUAPI_DRS_CRITICAL_ONLY) {
+               critical_only = true;
+       }
+
+       if (req10->extended_op == DRSUAPI_EXOP_REPL_OBJ ||
+           req10->extended_op == DRSUAPI_EXOP_REPL_SECRET) {
+               scope = LDB_SCOPE_BASE;
+               critical_only = false;
+       }
+
+       /* Construct response. */
+       search_filter = talloc_asprintf(mem_ctx,
+                                       "(uSNChanged>=%llu)",
+                                       (unsigned long long)(getnc_state->min_usn+1));
+
+       if (extra_filter) {
+               search_filter = talloc_asprintf(mem_ctx, "(&%s(%s))", search_filter, extra_filter);
+       }
+
+       if (critical_only) {
+               search_filter = talloc_asprintf(mem_ctx,
+                                               "(&%s(isCriticalSystemObject=TRUE))",
+                                               search_filter);
+       }
+
+       if (req10->replica_flags & DRSUAPI_DRS_ASYNC_REP) {
+               scope = LDB_SCOPE_BASE;
+       }
+
+       if (!search_dn) {
+               search_dn = getnc_state->ncRoot_dn;
+       }
+
+       DEBUG(2,(__location__ ": getncchanges on %s using filter %s\n",
+                ldb_dn_get_linearized(getnc_state->ncRoot_dn), search_filter));
+       ret = drsuapi_search_with_extended_dn(b_state->sam_ctx, getnc_state, search_res,
+                                             search_dn, scope,
+                                             collect_objects_attrs,
+                                             search_filter);
+       if (ret != LDB_SUCCESS) {
+               return WERR_DS_DRA_INTERNAL_ERROR;
+       }
+
+       return WERR_OK;
+}
+
+/**
+ * Collects object for normal replication cycle.
+ */
+static WERROR getncchanges_collect_objects_exop(struct drsuapi_bind_state *b_state,
+                                               TALLOC_CTX *mem_ctx,
+                                               struct drsuapi_DsGetNCChangesRequest10 *req10,
+                                               struct drsuapi_DsGetNCChangesCtr6 *ctr6,
+                                               struct ldb_dn *search_dn,
+                                               const char *extra_filter,
+                                               struct ldb_result **search_res)
+{
+       /* we have nothing to do in case of ex-op failure */
+       if (ctr6->extended_ret != DRSUAPI_EXOP_ERR_SUCCESS) {
+               return WERR_OK;
+       }
+
+       switch (req10->extended_op) {
+       case DRSUAPI_EXOP_FSMO_RID_ALLOC:
+       {
+               int ret;
+               struct ldb_dn *ntds_dn = NULL;
+               struct ldb_dn *server_dn = NULL;
+               struct ldb_dn *machine_dn = NULL;
+               struct ldb_dn *rid_set_dn = NULL;
+               struct ldb_result *search_res2 = NULL;
+               struct ldb_result *search_res3 = NULL;
+               TALLOC_CTX *frame = talloc_stackframe();
+               /* get RID manager, RID set and server DN (in that order) */
+
+               /* This first search will get the RID Manager */
+               ret = drsuapi_search_with_extended_dn(b_state->sam_ctx, frame,
+                                                     search_res,
+                                                     search_dn, LDB_SCOPE_BASE,
+                                                     collect_objects_attrs,
+                                                     NULL);
+               if (ret != LDB_SUCCESS) {
+                       DEBUG(1, ("DRSUAPI_EXOP_FSMO_RID_ALLOC: Failed to get RID Manager object %s - %s",
+                                 ldb_dn_get_linearized(search_dn),
+                                 ldb_errstring(b_state->sam_ctx)));
+                       TALLOC_FREE(frame);
+                       return WERR_DS_DRA_INTERNAL_ERROR;
+               }
+
+               if ((*search_res)->count != 1) {
+                       DEBUG(1, ("DRSUAPI_EXOP_FSMO_RID_ALLOC: Failed to get RID Manager object %s - %u objects returned",
+                                 ldb_dn_get_linearized(search_dn),
+                                 (*search_res)->count));
+                       TALLOC_FREE(frame);
+                       return WERR_DS_DRA_INTERNAL_ERROR;
+               }
+
+               /* Now extend it to the RID set */
+
+               /* Find the computer account DN for the destination
+                * dsa GUID specified */
+
+               ret = dsdb_find_dn_by_guid(b_state->sam_ctx, frame,
+                                          &req10->destination_dsa_guid, 0,
+                                          &ntds_dn);
+               if (ret != LDB_SUCCESS) {
+                       DEBUG(1, ("DRSUAPI_EXOP_FSMO_RID_ALLOC: Unable to find NTDS object for guid %s - %s\n",
+                                 GUID_string(frame,
+                                             &req10->destination_dsa_guid),
+                                 ldb_errstring(b_state->sam_ctx)));
+                       TALLOC_FREE(frame);
+                       return WERR_DS_DRA_INTERNAL_ERROR;
+               }
+
+               server_dn = ldb_dn_get_parent(frame, ntds_dn);
+               if (!server_dn) {
+                       TALLOC_FREE(frame);
+                       return WERR_DS_DRA_INTERNAL_ERROR;
+               }
+
+               ret = samdb_reference_dn(b_state->sam_ctx, frame, server_dn,
+                                        "serverReference", &machine_dn);
+               if (ret != LDB_SUCCESS) {
+                       DEBUG(1, ("DRSUAPI_EXOP_FSMO_RID_ALLOC: Failed to find serverReference in %s - %s",
+                                 ldb_dn_get_linearized(server_dn),
+                                 ldb_errstring(b_state->sam_ctx)));
+                       TALLOC_FREE(frame);
+                       return WERR_DS_DRA_INTERNAL_ERROR;
+               }
+
+               ret = samdb_reference_dn(b_state->sam_ctx, frame, machine_dn,
+                                        "rIDSetReferences", &rid_set_dn);
+               if (ret != LDB_SUCCESS) {
+                       DEBUG(1, ("DRSUAPI_EXOP_FSMO_RID_ALLOC: Failed to find rIDSetReferences in %s - %s",
+                                 ldb_dn_get_linearized(server_dn),
+                                 ldb_errstring(b_state->sam_ctx)));
+                       TALLOC_FREE(frame);
+                       return WERR_DS_DRA_INTERNAL_ERROR;
+               }
+
+
+               /* This first search will get the RID Manager, now get the RID set */
+               ret = drsuapi_search_with_extended_dn(b_state->sam_ctx, frame,
+                                                     &search_res2,
+                                                     rid_set_dn, LDB_SCOPE_BASE,
+                                                     collect_objects_attrs,
+                                                     NULL);
+               if (ret != LDB_SUCCESS) {
+                       DEBUG(1, ("DRSUAPI_EXOP_FSMO_RID_ALLOC: Failed to get RID Set object %s - %s",
+                                 ldb_dn_get_linearized(rid_set_dn),
+                                 ldb_errstring(b_state->sam_ctx)));
+                       TALLOC_FREE(frame);
+                       return WERR_DS_DRA_INTERNAL_ERROR;
+               }
+
+               if (search_res2->count != 1) {
+                       DEBUG(1, ("DRSUAPI_EXOP_FSMO_RID_ALLOC: Failed to get RID Set object %s - %u objects returned",
+                                 ldb_dn_get_linearized(rid_set_dn),
+                                 search_res2->count));
+                       TALLOC_FREE(frame);
+                       return WERR_DS_DRA_INTERNAL_ERROR;
+               }
+
+               /* Finally get the server DN */
+               ret = drsuapi_search_with_extended_dn(b_state->sam_ctx, frame,
+                                                     &search_res3,
+                                                     machine_dn, LDB_SCOPE_BASE,
+                                                     collect_objects_attrs,
+                                                     NULL);
+               if (ret != LDB_SUCCESS) {
+                       DEBUG(1, ("DRSUAPI_EXOP_FSMO_RID_ALLOC: Failed to get server object %s - %s",
+                                 ldb_dn_get_linearized(server_dn),
+                                 ldb_errstring(b_state->sam_ctx)));
+                       TALLOC_FREE(frame);
+                       return WERR_DS_DRA_INTERNAL_ERROR;
+               }
+
+               if (search_res3->count != 1) {
+                       DEBUG(1, ("DRSUAPI_EXOP_FSMO_RID_ALLOC: Failed to get server object %s - %u objects returned",
+                                 ldb_dn_get_linearized(server_dn),
+                                 search_res3->count));
+                       TALLOC_FREE(frame);
+                       return WERR_DS_DRA_INTERNAL_ERROR;
+               }
+
+               /* Now extend the original search_res with these answers */
+               (*search_res)->count = 3;
+
+               (*search_res)->msgs = talloc_realloc(frame, (*search_res)->msgs,
+                                                    struct ldb_message *,
+                                                    (*search_res)->count);
+               if ((*search_res)->msgs == NULL) {
+                       TALLOC_FREE(frame);
+                       return WERR_NOT_ENOUGH_MEMORY;
+               }
+
+
+               talloc_steal(mem_ctx, *search_res);
+               (*search_res)->msgs[1] =
+                       talloc_steal((*search_res)->msgs, search_res2->msgs[0]);
+               (*search_res)->msgs[2] =
+                       talloc_steal((*search_res)->msgs, search_res3->msgs[0]);
+
+               TALLOC_FREE(frame);
+               return WERR_OK;
+       }
+       default:
+               /* TODO: implement extended op specific collection
+                * of objects. Right now we just normal procedure
+                * for collecting objects */
+               return getncchanges_collect_objects(b_state, mem_ctx, req10, search_dn, extra_filter, search_res);
+       }
+}
+
+static void dcesrv_drsuapi_update_highwatermark(const struct ldb_message *msg,
+                                               uint64_t max_usn,
+                                               struct drsuapi_DsReplicaHighWaterMark *hwm)
+{
+       uint64_t uSN = ldb_msg_find_attr_as_uint64(msg, "uSNChanged", 0);
+
+       if (uSN > max_usn) {
+               /*
+                * Only report the max_usn we had at the start
+                * of the replication cycle.
+                *
+                * If this object has changed lately we better
+                * let the destination dsa refetch the change.
+                * This is better than the risk of loosing some
+                * objects or linked attributes.
+                */
+               return;
+       }
+
+       if (uSN <= hwm->tmp_highest_usn) {
+               return;
+       }
+
+       hwm->tmp_highest_usn = uSN;
+       hwm->reserved_usn = 0;
+}
+
+static WERROR dcesrv_drsuapi_anc_cache_add(struct db_context *anc_cache,
+                                          const struct GUID *guid)
+{
+       enum ndr_err_code ndr_err;
+       uint8_t guid_buf[16] = { 0, };
+       DATA_BLOB b = {
+               .data = guid_buf,
+               .length = sizeof(guid_buf),
+       };
+       TDB_DATA key = {
+               .dptr = b.data,
+               .dsize = b.length,
+       };
+       TDB_DATA val = {
+               .dptr = NULL,
+               .dsize = 0,
+       };
+       NTSTATUS status;
+
+       ndr_err = ndr_push_struct_into_fixed_blob(&b, guid,
+                       (ndr_push_flags_fn_t)ndr_push_GUID);
+       if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
+               return WERR_DS_DRA_INTERNAL_ERROR;
+       }
+
+       status = dbwrap_store(anc_cache, key, val, TDB_REPLACE);
+       if (!NT_STATUS_IS_OK(status)) {
+               return WERR_DS_DRA_INTERNAL_ERROR;
+       }
+
+       return WERR_OK;
+}
+
+static WERROR dcesrv_drsuapi_anc_cache_exists(struct db_context *anc_cache,
+                                             const struct GUID *guid)
+{
+       enum ndr_err_code ndr_err;
+       uint8_t guid_buf[16] = { 0, };
+       DATA_BLOB b = {
+               .data = guid_buf,
+               .length = sizeof(guid_buf),
+       };
+       TDB_DATA key = {
+               .dptr = b.data,
+               .dsize = b.length,
+       };
+       bool exists;
+
+       ndr_err = ndr_push_struct_into_fixed_blob(&b, guid,
+                       (ndr_push_flags_fn_t)ndr_push_GUID);
+       if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
+               return WERR_DS_DRA_INTERNAL_ERROR;
+       }
+
+       exists = dbwrap_exists(anc_cache, key);
+       if (!exists) {
+               return WERR_OBJECT_NOT_FOUND;
+       }
+
+       return WERR_OBJECT_NAME_EXISTS;
+}
 
 /* 
   drsuapi_DsGetNCChanges
@@ -1170,25 +1979,15 @@ WERROR dcesrv_drsuapi_DsGetNCChanges(struct dcesrv_call_state *dce_call, TALLOC_
 {
        struct drsuapi_DsReplicaObjectIdentifier *ncRoot;
        int ret;
-       unsigned int i;
+       uint32_t i, k;
        struct dsdb_schema *schema;
        struct drsuapi_DsReplicaOIDMapping_Ctr *ctr;
        struct drsuapi_DsReplicaObjectListItemEx **currentObject;
        NTSTATUS status;
        DATA_BLOB session_key;
-       const char *attrs[] = { "*", "distinguishedName",
-                               "nTSecurityDescriptor",
-                               "parentGUID",
-                               "replPropertyMetaData",
-                               "unicodePwd",
-                               "dBCSPwd",
-                               "ntPwdHistory",
-                               "lmPwdHistory",
-                               "supplementalCredentials",
-                               NULL };
        WERROR werr;
        struct dcesrv_handle *h;
-       struct drsuapi_bind_state *b_state;     
+       struct drsuapi_bind_state *b_state;
        struct drsuapi_getncchanges_state *getnc_state;
        struct drsuapi_DsGetNCChangesRequest10 *req10;
        uint32_t options;
@@ -1203,21 +2002,38 @@ WERROR dcesrv_drsuapi_DsGetNCChanges(struct dcesrv_call_state *dce_call, TALLOC_
        struct ldb_context *sam_ctx;
        struct dom_sid *user_sid;
        bool is_secret_request;
+       bool is_gc_pas_request;
+       struct drsuapi_changed_objects *changes;
+       time_t max_wait;
+       time_t start = time(NULL);
+       bool max_wait_reached = false;
+       bool has_get_all_changes = false;
+       struct GUID invocation_id;
+       static const struct drsuapi_DsReplicaLinkedAttribute no_linked_attr;
+       struct dsdb_schema_prefixmap *pfm_remote = NULL;
+       bool full = true;
+       uint32_t *local_pas = NULL;
+       struct ldb_dn *machine_dn = NULL; /* Only used for REPL SECRET EXOP */
 
        DCESRV_PULL_HANDLE_WERR(h, r->in.bind_handle, DRSUAPI_BIND_HANDLE);
        b_state = h->data;
 
        sam_ctx = b_state->sam_ctx_system?b_state->sam_ctx_system:b_state->sam_ctx;
 
+       invocation_id = *(samdb_ntds_invocation_id(sam_ctx));
+
        *r->out.level_out = 6;
        /* TODO: linked attributes*/
        r->out.ctr->ctr6.linked_attributes_count = 0;
-       r->out.ctr->ctr6.linked_attributes = NULL;
+       r->out.ctr->ctr6.linked_attributes = discard_const_p(struct drsuapi_DsReplicaLinkedAttribute, &no_linked_attr);
 
        r->out.ctr->ctr6.object_count = 0;
        r->out.ctr->ctr6.nc_object_count = 0;
        r->out.ctr->ctr6.more_data = false;
        r->out.ctr->ctr6.uptodateness_vector = NULL;
+       r->out.ctr->ctr6.source_dsa_guid = *(samdb_ntds_objectGUID(sam_ctx));
+       r->out.ctr->ctr6.source_dsa_invocation_id = *(samdb_ntds_invocation_id(sam_ctx));
+       r->out.ctr->ctr6.first_object = NULL;
 
        /* a RODC doesn't allow for any replication */
        ret = samdb_rodc(sam_ctx, &am_rodc);
@@ -1232,7 +2048,7 @@ WERROR dcesrv_drsuapi_DsGetNCChanges(struct dcesrv_call_state *dce_call, TALLOC_
        case 8:
                req10 = getncchanges_map_req8(mem_ctx, &r->in.req->req8);
                if (req10 == NULL) {
-                       return WERR_NOMEM;
+                       return WERR_NOT_ENOUGH_MEMORY;
                }
                break;
        case 10:
@@ -1257,7 +2073,7 @@ WERROR dcesrv_drsuapi_DsGetNCChanges(struct dcesrv_call_state *dce_call, TALLOC_
        if (samdb_ntds_options(sam_ctx, &options) != LDB_SUCCESS) {
                return WERR_DS_DRA_INTERNAL_ERROR;
        }
-       
+
        if ((options & DS_NTDSDSA_OPT_DISABLE_OUTBOUND_REPL) &&
            !(req10->replica_flags & DRSUAPI_DRS_SYNC_FORCED)) {
                return WERR_DS_DRA_SOURCE_DISABLED;
@@ -1265,6 +2081,7 @@ WERROR dcesrv_drsuapi_DsGetNCChanges(struct dcesrv_call_state *dce_call, TALLOC_
 
        user_sid = &dce_call->conn->auth_state.session_info->security_token->sids[PRIMARY_USER_SID_INDEX];
 
+       /* all clients must have GUID_DRS_GET_CHANGES */
        werr = drs_security_access_check_nc_root(b_state->sam_ctx,
                                                 mem_ctx,
                                                 dce_call->conn->auth_state.session_info->security_token,
@@ -1274,21 +2091,72 @@ WERROR dcesrv_drsuapi_DsGetNCChanges(struct dcesrv_call_state *dce_call, TALLOC_
                return werr;
        }
 
-       werr = dcesrv_drsuapi_is_reveal_secrets_request(b_state, req10, &is_secret_request);
+       if (dsdb_functional_level(sam_ctx) >= DS_DOMAIN_FUNCTION_2008) {
+               full = req10->partial_attribute_set == NULL &&
+                      req10->partial_attribute_set_ex == NULL;
+       } else {
+               full = (options & DRSUAPI_DRS_WRIT_REP) != 0;
+       }
+
+       werr = dsdb_schema_pfm_from_drsuapi_pfm(&req10->mapping_ctr, true,
+                                               mem_ctx, &pfm_remote, NULL);
+
+       /* We were supplied a partial attribute set, without the prefix map! */
+       if (!full && !W_ERROR_IS_OK(werr)) {
+               if (req10->mapping_ctr.num_mappings == 0) {
+                       /*
+                        * Despite the fact MS-DRSR specifies that this shouldn't
+                        * happen, Windows RODCs will in fact not provide a prefixMap.
+                        */
+                       DEBUG(5,(__location__ ": Failed to provide a remote prefixMap,"
+                                " falling back to local prefixMap\n"));
+               } else {
+                       DEBUG(0,(__location__ ": Failed to decode remote prefixMap: %s\n",
+                                win_errstr(werr)));
+                       return werr;
+               }
+       }
+
+       /* allowed if the GC PAS and client has
+          GUID_DRS_GET_FILTERED_ATTRIBUTES */
+       werr = dcesrv_drsuapi_is_gc_pas_request(b_state, req10, pfm_remote, &is_gc_pas_request);
+       if (!W_ERROR_IS_OK(werr)) {
+               return werr;
+       }
+       if (is_gc_pas_request) {
+               werr = drs_security_access_check_nc_root(b_state->sam_ctx,
+                                                        mem_ctx,
+                                                        dce_call->conn->auth_state.session_info->security_token,
+                                                        req10->naming_context,
+                                                        GUID_DRS_GET_FILTERED_ATTRIBUTES);
+               if (W_ERROR_IS_OK(werr)) {
+                       goto allowed;
+               }
+       }
+
+       werr = dcesrv_drsuapi_is_reveal_secrets_request(b_state, req10,
+                                                       pfm_remote,
+                                                       &is_secret_request);
        if (!W_ERROR_IS_OK(werr)) {
                return werr;
        }
-       if (is_secret_request && req10->extended_op != DRSUAPI_EXOP_REPL_SECRET) {
+       if (is_secret_request) {
                werr = drs_security_access_check_nc_root(b_state->sam_ctx,
                                                         mem_ctx,
                                                         dce_call->conn->auth_state.session_info->security_token,
                                                         req10->naming_context,
                                                         GUID_DRS_GET_ALL_CHANGES);
                if (!W_ERROR_IS_OK(werr)) {
-                       return werr;
+                       /* Only bail if this is not a EXOP_REPL_SECRET */
+                       if (req10->extended_op != DRSUAPI_EXOP_REPL_SECRET) {
+                               return werr;
+                       }
+               } else {
+                       has_get_all_changes = true;
                }
        }
 
+allowed:
        /* for non-administrator replications, check that they have
           given the correct source_dsa_invocation_id */
        security_level = security_session_user_level(dce_call->conn->auth_state.session_info,
@@ -1303,7 +2171,19 @@ WERROR dcesrv_drsuapi_DsGetNCChanges(struct dcesrv_call_state *dce_call, TALLOC_
        if (req10->replica_flags & DRSUAPI_DRS_FULL_SYNC_PACKET) {
                /* Ignore the _in_ uptpdateness vector*/
                req10->uptodateness_vector = NULL;
-       } 
+       }
+
+       if (GUID_all_zero(&req10->source_dsa_invocation_id)) {
+               req10->source_dsa_invocation_id = invocation_id;
+       }
+
+       if (!GUID_equal(&req10->source_dsa_invocation_id, &invocation_id)) {
+               /*
+                * The given highwatermark is only valid relative to the
+                * specified source_dsa_invocation_id.
+                */
+               ZERO_STRUCT(req10->highwatermark);
+       }
 
        getnc_state = b_state->getncchanges_state;
 
@@ -1320,19 +2200,51 @@ WERROR dcesrv_drsuapi_DsGetNCChanges(struct dcesrv_call_state *dce_call, TALLOC_
                }
        }
 
+       if (getnc_state) {
+               ret = drsuapi_DsReplicaHighWaterMark_cmp(&getnc_state->last_hwm,
+                                                        &req10->highwatermark);
+               if (ret != 0) {
+                       DEBUG(0,(__location__ ": DsGetNCChanges 2nd replication "
+                                "on DN %s %s highwatermark (last_dn %s)\n",
+                                ldb_dn_get_linearized(getnc_state->ncRoot_dn),
+                                (ret > 0) ? "older" : "newer",
+                                ldb_dn_get_linearized(getnc_state->last_dn)));
+                       talloc_free(getnc_state);
+                       getnc_state = NULL;
+               }
+       }
+
        if (getnc_state == NULL) {
                getnc_state = talloc_zero(b_state, struct drsuapi_getncchanges_state);
                if (getnc_state == NULL) {
-                       return WERR_NOMEM;
+                       return WERR_NOT_ENOUGH_MEMORY;
                }
                b_state->getncchanges_state = getnc_state;
                getnc_state->ncRoot_dn = drs_ObjectIdentifier_to_dn(getnc_state, sam_ctx, ncRoot);
+               if (getnc_state->ncRoot_dn == NULL) {
+                       return WERR_NOT_ENOUGH_MEMORY;
+               }
+
+               ret = dsdb_find_guid_by_dn(b_state->sam_ctx_system,
+                                          getnc_state->ncRoot_dn,
+                                          &getnc_state->ncRoot_guid);
+               if (ret != LDB_SUCCESS) {
+                       DEBUG(0,(__location__ ": Failed to find GUID of ncRoot_dn %s\n",
+                                ldb_dn_get_linearized(getnc_state->ncRoot_dn)));
+                       return WERR_DS_DRA_INTERNAL_ERROR;
+               }
+               ncRoot->guid = getnc_state->ncRoot_guid;
 
                /* find out if we are to replicate Schema NC */
-               ret = ldb_dn_compare(getnc_state->ncRoot_dn,
-                                    ldb_get_schema_basedn(b_state->sam_ctx));
+               ret = ldb_dn_compare_base(ldb_get_schema_basedn(b_state->sam_ctx),
+                                         getnc_state->ncRoot_dn);
+
                getnc_state->is_schema_nc = (0 == ret);
 
+               if (req10->extended_op != DRSUAPI_EXOP_NONE) {
+                       r->out.ctr->ctr6.extended_ret = DRSUAPI_EXOP_ERR_SUCCESS;
+               }
+
                /*
                 * This is the first replication cycle and it is
                 * a good place to handle extended operations
@@ -1343,26 +2255,41 @@ WERROR dcesrv_drsuapi_DsGetNCChanges(struct dcesrv_call_state *dce_call, TALLOC_
                case DRSUAPI_EXOP_NONE:
                        break;
                case DRSUAPI_EXOP_FSMO_RID_ALLOC:
-                       werr = getncchanges_rid_alloc(b_state, mem_ctx, req10, &r->out.ctr->ctr6);
+                       werr = getncchanges_rid_alloc(b_state, mem_ctx, req10, &r->out.ctr->ctr6, &search_dn);
                        W_ERROR_NOT_OK_RETURN(werr);
-                       search_dn = ldb_get_default_basedn(sam_ctx);
+                       if (r->out.ctr->ctr6.extended_ret != DRSUAPI_EXOP_ERR_SUCCESS) {
+                               return WERR_OK;
+                       }
                        break;
                case DRSUAPI_EXOP_REPL_SECRET:
-                       werr = getncchanges_repl_secret(b_state, mem_ctx, req10, user_sid, &r->out.ctr->ctr6);
+                       werr = getncchanges_repl_secret(b_state, mem_ctx, req10,
+                                                       user_sid,
+                                                       &r->out.ctr->ctr6,
+                                                       has_get_all_changes,
+                                                       &machine_dn);
                        r->out.result = werr;
                        W_ERROR_NOT_OK_RETURN(werr);
                        break;
                case DRSUAPI_EXOP_FSMO_REQ_ROLE:
                        werr = getncchanges_change_master(b_state, mem_ctx, req10, &r->out.ctr->ctr6);
                        W_ERROR_NOT_OK_RETURN(werr);
+                       if (r->out.ctr->ctr6.extended_ret != DRSUAPI_EXOP_ERR_SUCCESS) {
+                               return WERR_OK;
+                       }
                        break;
                case DRSUAPI_EXOP_FSMO_RID_REQ_ROLE:
                        werr = getncchanges_change_master(b_state, mem_ctx, req10, &r->out.ctr->ctr6);
                        W_ERROR_NOT_OK_RETURN(werr);
+                       if (r->out.ctr->ctr6.extended_ret != DRSUAPI_EXOP_ERR_SUCCESS) {
+                               return WERR_OK;
+                       }
                        break;
                case DRSUAPI_EXOP_FSMO_REQ_PDC:
                        werr = getncchanges_change_master(b_state, mem_ctx, req10, &r->out.ctr->ctr6);
                        W_ERROR_NOT_OK_RETURN(werr);
+                       if (r->out.ctr->ctr6.extended_ret != DRSUAPI_EXOP_ERR_SUCCESS) {
+                               return WERR_OK;
+                       }
                        break;
                case DRSUAPI_EXOP_REPL_OBJ:
                        werr = getncchanges_repl_obj(b_state, mem_ctx, req10, user_sid, &r->out.ctr->ctr6);
@@ -1385,82 +2312,137 @@ WERROR dcesrv_drsuapi_DsGetNCChanges(struct dcesrv_call_state *dce_call, TALLOC_
                return WERR_DS_DRA_INVALID_PARAMETER;
        }
 
+       ncRoot->guid = getnc_state->ncRoot_guid;
+
        /* we need the session key for encrypting password attributes */
        status = dcesrv_inherited_session_key(dce_call->conn, &session_key);
        if (!NT_STATUS_IS_OK(status)) {
                DEBUG(0,(__location__ ": Failed to get session key\n"));
-               return WERR_DS_DRA_INTERNAL_ERROR;              
+               return WERR_DS_DRA_INTERNAL_ERROR;
        }
 
        /* 
           TODO: MS-DRSR section 4.1.10.1.1
           Work out if this is the start of a new cycle */
 
-       if (getnc_state->site_res == NULL) {
-               char* search_filter;
-               enum ldb_scope scope = LDB_SCOPE_SUBTREE;
+       if (getnc_state->guids == NULL) {
                const char *extra_filter;
-
-               if (req10->extended_op == DRSUAPI_EXOP_REPL_OBJ ||
-                   req10->extended_op == DRSUAPI_EXOP_REPL_SECRET) {
-                       scope = LDB_SCOPE_BASE;
-               }
+               struct ldb_result *search_res = NULL;
+               static const struct drsuapi_DsReplicaCursorCtrEx empty_udv;
+               const struct drsuapi_DsReplicaCursorCtrEx *udv = NULL;
 
                extra_filter = lpcfg_parm_string(dce_call->conn->dce_ctx->lp_ctx, NULL, "drs", "object filter");
 
-               getnc_state->min_usn = req10->highwatermark.highest_usn;
+               if (req10->uptodateness_vector != NULL) {
+                       udv = req10->uptodateness_vector;
+               } else {
+                       udv = &empty_udv;
+               }
 
-               /* Construct response. */
-               search_filter = talloc_asprintf(mem_ctx,
-                                               "(uSNChanged>=%llu)",
-                                               (unsigned long long)(getnc_state->min_usn+1));
-       
-               if (extra_filter) {
-                       search_filter = talloc_asprintf(mem_ctx, "(&%s(%s))", search_filter, extra_filter);
+               getnc_state->min_usn = req10->highwatermark.highest_usn;
+               for (i = 0; i < udv->count; i++) {
+                       bool match;
+                       const struct drsuapi_DsReplicaCursor *cur =
+                               &udv->cursors[i];
+
+                       match = GUID_equal(&invocation_id,
+                                          &cur->source_dsa_invocation_id);
+                       if (!match) {
+                               continue;
+                       }
+                       if (cur->highest_usn > getnc_state->min_usn) {
+                               getnc_state->min_usn = cur->highest_usn;
+                       }
+                       break;
                }
+               getnc_state->max_usn = getnc_state->min_usn;
 
-               if (req10->replica_flags & DRSUAPI_DRS_CRITICAL_ONLY) {
-                       search_filter = talloc_asprintf(mem_ctx,
-                                                       "(&%s(isCriticalSystemObject=TRUE))",
-                                                       search_filter);
+               getnc_state->final_udv = talloc_zero(getnc_state,
+                                       struct drsuapi_DsReplicaCursor2CtrEx);
+               if (getnc_state->final_udv == NULL) {
+                       return WERR_NOT_ENOUGH_MEMORY;
                }
-               
-               if (req10->replica_flags & DRSUAPI_DRS_ASYNC_REP) {
-                       scope = LDB_SCOPE_BASE;
+               werr = get_nc_changes_udv(sam_ctx, getnc_state->ncRoot_dn,
+                                         getnc_state->final_udv);
+               if (!W_ERROR_IS_OK(werr)) {
+                       return werr;
                }
-               
-               if (!search_dn) {
-                       search_dn = getnc_state->ncRoot_dn;
+
+               if (req10->extended_op == DRSUAPI_EXOP_NONE) {
+                       werr = getncchanges_collect_objects(b_state, mem_ctx, req10,
+                                                           search_dn, extra_filter,
+                                                           &search_res);
+               } else {
+                       werr = getncchanges_collect_objects_exop(b_state, mem_ctx, req10,
+                                                                &r->out.ctr->ctr6,
+                                                                search_dn, extra_filter,
+                                                                &search_res);
                }
+               W_ERROR_NOT_OK_RETURN(werr);
 
-               DEBUG(2,(__location__ ": getncchanges on %s using filter %s\n",
-                        ldb_dn_get_linearized(getnc_state->ncRoot_dn), search_filter));
-               ret = drsuapi_search_with_extended_dn(sam_ctx, getnc_state, &getnc_state->site_res,
-                                                     search_dn, scope, attrs,
-                                                     search_filter);
-               if (ret != LDB_SUCCESS) {
-                       return WERR_DS_DRA_INTERNAL_ERROR;
+               /* extract out the GUIDs list */
+               getnc_state->num_records = search_res ? search_res->count : 0;
+               getnc_state->guids = talloc_array(getnc_state, struct GUID, getnc_state->num_records);
+               W_ERROR_HAVE_NO_MEMORY(getnc_state->guids);
+
+               changes = talloc_array(getnc_state,
+                                      struct drsuapi_changed_objects,
+                                      getnc_state->num_records);
+               W_ERROR_HAVE_NO_MEMORY(changes);
+
+               for (i=0; i<getnc_state->num_records; i++) {
+                       changes[i].dn = search_res->msgs[i]->dn;
+                       changes[i].guid = samdb_result_guid(search_res->msgs[i], "objectGUID");
+                       changes[i].usn = ldb_msg_find_attr_as_uint64(search_res->msgs[i], "uSNChanged", 0);
+
+                       if (changes[i].usn > getnc_state->max_usn) {
+                               getnc_state->max_usn = changes[i].usn;
+                       }
                }
 
-               if (req10->replica_flags & DRSUAPI_DRS_GET_ANC) {
-                       TYPESAFE_QSORT(getnc_state->site_res->msgs,
-                                      getnc_state->site_res->count,
-                                      site_res_cmp_parent_order);
+               /* RID_ALLOC returns 3 objects in a fixed order */
+               if (req10->extended_op == DRSUAPI_EXOP_FSMO_RID_ALLOC) {
+                       /* Do nothing */
                } else {
-                       TYPESAFE_QSORT(getnc_state->site_res->msgs,
-                                      getnc_state->site_res->count,
-                                      site_res_cmp_usn_order);
+                       LDB_TYPESAFE_QSORT(changes,
+                                          getnc_state->num_records,
+                                          getnc_state,
+                                          site_res_cmp_usn_order);
+               }
+
+               for (i=0; i < getnc_state->num_records; i++) {
+                       getnc_state->guids[i] = changes[i].guid;
+                       if (GUID_all_zero(&getnc_state->guids[i])) {
+                               DEBUG(2,("getncchanges: bad objectGUID from %s\n",
+                                        ldb_dn_get_linearized(search_res->msgs[i]->dn)));
+                               return WERR_DS_DRA_INTERNAL_ERROR;
+                       }
                }
 
-               getnc_state->uptodateness_vector = talloc_steal(getnc_state, req10->uptodateness_vector);
-               if (getnc_state->uptodateness_vector) {
-                       /* make sure its sorted */
-                       TYPESAFE_QSORT(getnc_state->uptodateness_vector->cursors,
-                                      getnc_state->uptodateness_vector->count,
-                                      drsuapi_DsReplicaCursor_compare);
+               getnc_state->final_hwm.tmp_highest_usn = getnc_state->max_usn;
+               getnc_state->final_hwm.reserved_usn = 0;
+               getnc_state->final_hwm.highest_usn = getnc_state->max_usn;
+
+               talloc_free(search_res);
+               talloc_free(changes);
+
+               if (req10->extended_op != DRSUAPI_EXOP_NONE) {
+                       /* Do nothing */
+               } else if (req10->replica_flags & DRSUAPI_DRS_GET_ANC) {
+                       getnc_state->anc_cache = db_open_rbt(getnc_state);
+                       if (getnc_state->anc_cache == NULL) {
+                               return WERR_NOT_ENOUGH_MEMORY;
+                       }
                }
        }
 
+       if (req10->uptodateness_vector) {
+               /* make sure its sorted */
+               TYPESAFE_QSORT(req10->uptodateness_vector->cursors,
+                              req10->uptodateness_vector->count,
+                              drsuapi_DsReplicaCursor_compare);
+       }
+
        /* Prefix mapping */
        schema = dsdb_get_schema(sam_ctx, mem_ctx);
        if (!schema) {
@@ -1469,14 +2451,10 @@ WERROR dcesrv_drsuapi_DsGetNCChanges(struct dcesrv_call_state *dce_call, TALLOC_
        }
 
        r->out.ctr->ctr6.naming_context = talloc(mem_ctx, struct drsuapi_DsReplicaObjectIdentifier);
-       *r->out.ctr->ctr6.naming_context = *ncRoot;
-
-       if (dsdb_find_guid_by_dn(sam_ctx, getnc_state->ncRoot_dn,
-                                &r->out.ctr->ctr6.naming_context->guid) != LDB_SUCCESS) {
-               DEBUG(0,(__location__ ": Failed to find GUID of ncRoot_dn %s\n",
-                        ldb_dn_get_linearized(getnc_state->ncRoot_dn)));
-               return WERR_DS_DRA_INTERNAL_ERROR;
+       if (r->out.ctr->ctr6.naming_context == NULL) {
+               return WERR_NOT_ENOUGH_MEMORY;
        }
+       *r->out.ctr->ctr6.naming_context = *ncRoot;
 
        /* find the SID if there is one */
        dsdb_find_sid_by_dn(sam_ctx, getnc_state->ncRoot_dn, &r->out.ctr->ctr6.naming_context->sid);
@@ -1490,31 +2468,120 @@ WERROR dcesrv_drsuapi_DsGetNCChanges(struct dcesrv_call_state *dce_call, TALLOC_
        r->out.ctr->ctr6.old_highwatermark = req10->highwatermark;
        r->out.ctr->ctr6.new_highwatermark = req10->highwatermark;
 
-       r->out.ctr->ctr6.first_object = NULL;
        currentObject = &r->out.ctr->ctr6.first_object;
 
-       /* use this to force single objects at a time, which is useful
-        * for working out what object is giving problems
-        */
        max_objects = lpcfg_parm_int(dce_call->conn->dce_ctx->lp_ctx, NULL, "drs", "max object sync", 1000);
-       if (req10->max_object_count < max_objects) {
-               max_objects = req10->max_object_count;
+       /*
+        * The client control here only applies in normal replication, not extended
+        * operations, which return a fixed set, even if the caller
+        * sets max_object_count == 0
+        */
+       if (req10->extended_op == DRSUAPI_EXOP_NONE) {
+               /* use this to force single objects at a time, which is useful
+                * for working out what object is giving problems
+                */
+               if (req10->max_object_count < max_objects) {
+                       max_objects = req10->max_object_count;
+               }
        }
        /*
         * TODO: work out how the maximum should be calculated
         */
        max_links = lpcfg_parm_int(dce_call->conn->dce_ctx->lp_ctx, NULL, "drs", "max link sync", 1500);
 
-       for (i=getnc_state->num_sent;
-            i<getnc_state->site_res->count &&
+       /*
+        * Maximum time that we can spend in a getncchanges
+        * in order to avoid timeout of the other part.
+        * 10 seconds by default.
+        */
+       max_wait = lpcfg_parm_int(dce_call->conn->dce_ctx->lp_ctx, NULL, "drs", "max work time", 10);
+
+       if (req10->partial_attribute_set != NULL) {
+               struct dsdb_syntax_ctx syntax_ctx;
+               uint32_t j = 0;
+
+               dsdb_syntax_ctx_init(&syntax_ctx, b_state->sam_ctx, schema);
+               syntax_ctx.pfm_remote = pfm_remote;
+
+               local_pas = talloc_array(b_state, uint32_t, req10->partial_attribute_set->num_attids);
+
+               for (j = 0; j < req10->partial_attribute_set->num_attids; j++) {
+                       getncchanges_attid_remote_to_local(schema,
+                                                          &syntax_ctx,
+                                                          req10->partial_attribute_set->attids[j],
+                                                          (enum drsuapi_DsAttributeId *)&local_pas[j],
+                                                          NULL);
+               }
+
+               LDB_TYPESAFE_QSORT(local_pas,
+                                  req10->partial_attribute_set->num_attids,
+                                  NULL,
+                                  uint32_t_ptr_cmp);
+       }
+
+       for (i=getnc_state->num_processed;
+            i<getnc_state->num_records &&
                     !null_scope &&
-                    (r->out.ctr->ctr6.object_count < max_objects);
+                    (r->out.ctr->ctr6.object_count < max_objects)
+                    && !max_wait_reached;
            i++) {
-               int uSN;
+               struct drsuapi_DsReplicaObjectListItemEx *new_objs = NULL;
                struct drsuapi_DsReplicaObjectListItemEx *obj;
-               struct ldb_message *msg = getnc_state->site_res->msgs[i];
+               struct ldb_message *msg;
+               static const char * const msg_attrs[] = {
+                                           "*",
+                                           "nTSecurityDescriptor",
+                                           "parentGUID",
+                                           "replPropertyMetaData",
+                                           DSDB_SECRET_ATTRIBUTES,
+                                           NULL };
+               struct ldb_result *msg_res;
+               struct ldb_dn *msg_dn;
+               const struct GUID *next_anc_guid = NULL;
 
                obj = talloc_zero(mem_ctx, struct drsuapi_DsReplicaObjectListItemEx);
+               W_ERROR_HAVE_NO_MEMORY(obj);
+
+               msg_dn = ldb_dn_new_fmt(obj, sam_ctx, "<GUID=%s>", GUID_string(obj, &getnc_state->guids[i]));
+               W_ERROR_HAVE_NO_MEMORY(msg_dn);
+
+
+               /* by re-searching here we avoid having a lot of full
+                * records in memory between calls to getncchanges
+                */
+               ret = drsuapi_search_with_extended_dn(sam_ctx, obj, &msg_res,
+                                                     msg_dn,
+                                                     LDB_SCOPE_BASE, msg_attrs, NULL);
+               if (ret != LDB_SUCCESS) {
+                       if (ret != LDB_ERR_NO_SUCH_OBJECT) {
+                               DEBUG(1,("getncchanges: failed to fetch DN %s - %s\n",
+                                        ldb_dn_get_extended_linearized(obj, msg_dn, 1), ldb_errstring(sam_ctx)));
+                       }
+                       talloc_free(obj);
+                       continue;
+               }
+
+               msg = msg_res->msgs[0];
+
+               /*
+                * If it has already been added as an ancestor of
+                * an object, we don't need to do anything more,
+                * as we've already added the links.
+                */
+               if (getnc_state->anc_cache != NULL) {
+                       werr = dcesrv_drsuapi_anc_cache_exists(getnc_state->anc_cache,
+                                                              &getnc_state->guids[i]);
+                       if (W_ERROR_EQUAL(werr, WERR_OBJECT_NAME_EXISTS)) {
+                               dcesrv_drsuapi_update_highwatermark(msg,
+                                               getnc_state->max_usn,
+                                               &r->out.ctr->ctr6.new_highwatermark);
+                               /* no attributes to send */
+                               talloc_free(obj);
+                               continue;
+                       }
+               }
+
+               max_wait_reached = (time(NULL) - start > max_wait);
 
                werr = get_nc_changes_build_object(obj, msg,
                                                   sam_ctx, getnc_state->ncRoot_dn,
@@ -1522,31 +2589,30 @@ WERROR dcesrv_drsuapi_DsGetNCChanges(struct dcesrv_call_state *dce_call, TALLOC_
                                                   schema, &session_key, getnc_state->min_usn,
                                                   req10->replica_flags,
                                                   req10->partial_attribute_set,
-                                                  getnc_state->uptodateness_vector,
-                                                  req10->extended_op);
+                                                  req10->uptodateness_vector,
+                                                  req10->extended_op,
+                                                  max_wait_reached,
+                                                  local_pas, machine_dn);
                if (!W_ERROR_IS_OK(werr)) {
                        return werr;
                }
 
                werr = get_nc_changes_add_links(sam_ctx, getnc_state,
                                                getnc_state->ncRoot_dn,
+                                               getnc_state->is_schema_nc,
                                                schema, getnc_state->min_usn,
                                                req10->replica_flags,
                                                msg,
                                                &getnc_state->la_list,
                                                &getnc_state->la_count,
-                                               getnc_state->uptodateness_vector);
+                                               req10->uptodateness_vector);
                if (!W_ERROR_IS_OK(werr)) {
                        return werr;
                }
 
-               uSN = ldb_msg_find_attr_as_int(msg, "uSNChanged", -1);
-               if (uSN > r->out.ctr->ctr6.new_highwatermark.tmp_highest_usn) {
-                       r->out.ctr->ctr6.new_highwatermark.tmp_highest_usn = uSN;
-               }
-               if (uSN > getnc_state->highest_usn) {
-                       getnc_state->highest_usn = uSN;
-               }
+               dcesrv_drsuapi_update_highwatermark(msg,
+                                       getnc_state->max_usn,
+                                       &r->out.ctr->ctr6.new_highwatermark);
 
                if (obj->meta_data_ctr == NULL) {
                        DEBUG(8,(__location__ ": getncchanges skipping send of object %s\n",
@@ -1556,20 +2622,159 @@ WERROR dcesrv_drsuapi_DsGetNCChanges(struct dcesrv_call_state *dce_call, TALLOC_
                        continue;
                }
 
-               r->out.ctr->ctr6.object_count++;
-               
-               *currentObject = obj;
-               currentObject = &obj->next_object;
+               new_objs = obj;
 
-               talloc_free(getnc_state->last_dn);
-               getnc_state->last_dn = ldb_dn_copy(getnc_state, msg->dn);
+               if (getnc_state->anc_cache != NULL) {
+                       werr = dcesrv_drsuapi_anc_cache_add(getnc_state->anc_cache,
+                                                           &getnc_state->guids[i]);
+                       if (!W_ERROR_IS_OK(werr)) {
+                               return werr;
+                       }
+
+                       next_anc_guid = obj->parent_object_guid;
+               }
+
+               while (next_anc_guid != NULL) {
+                       struct drsuapi_DsReplicaObjectListItemEx *anc_obj = NULL;
+                       struct ldb_message *anc_msg = NULL;
+                       struct ldb_result *anc_res = NULL;
+                       struct ldb_dn *anc_dn = NULL;
+
+                       werr = dcesrv_drsuapi_anc_cache_exists(getnc_state->anc_cache,
+                                                              next_anc_guid);
+                       if (W_ERROR_EQUAL(werr, WERR_OBJECT_NAME_EXISTS)) {
+                               /*
+                                * We don't need to send it twice.
+                                */
+                               break;
+                       }
+                       if (W_ERROR_IS_OK(werr)) {
+                               return WERR_INTERNAL_ERROR;
+                       }
+                       if (!W_ERROR_EQUAL(werr, WERR_OBJECT_NOT_FOUND)) {
+                               return werr;
+                       }
+                       werr = WERR_OK;
+
+                       anc_obj = talloc_zero(mem_ctx,
+                                       struct drsuapi_DsReplicaObjectListItemEx);
+                       if (anc_obj == NULL) {
+                               return WERR_NOT_ENOUGH_MEMORY;
+                       }
+
+                       anc_dn = ldb_dn_new_fmt(anc_obj, sam_ctx, "<GUID=%s>",
+                                       GUID_string(anc_obj, next_anc_guid));
+                       if (anc_dn == NULL) {
+                               return WERR_NOT_ENOUGH_MEMORY;
+                       }
+
+                       ret = drsuapi_search_with_extended_dn(sam_ctx, anc_obj,
+                                                             &anc_res, anc_dn,
+                                                             LDB_SCOPE_BASE,
+                                                             msg_attrs, NULL);
+                       if (ret != LDB_SUCCESS) {
+                               const char *anc_str = NULL;
+                               const char *obj_str = NULL;
+
+                               anc_str = ldb_dn_get_extended_linearized(anc_obj,
+                                                                        anc_dn,
+                                                                        1);
+                               obj_str = ldb_dn_get_extended_linearized(anc_obj,
+                                                                        msg->dn,
+                                                                        1),
+
+                               DBG_ERR("getncchanges: failed to fetch ANC "
+                                       "DN %s for DN %s - %s\n",
+                                       anc_str, obj_str,
+                                       ldb_errstring(sam_ctx));
+                               return WERR_DS_DRA_INCONSISTENT_DIT;
+                       }
+
+                       anc_msg = anc_res->msgs[0];
+
+                       werr = get_nc_changes_build_object(anc_obj, anc_msg,
+                                                          sam_ctx,
+                                                          getnc_state->ncRoot_dn,
+                                                          getnc_state->is_schema_nc,
+                                                          schema, &session_key,
+                                                          getnc_state->min_usn,
+                                                          req10->replica_flags,
+                                                          req10->partial_attribute_set,
+                                                          req10->uptodateness_vector,
+                                                          req10->extended_op,
+                                                          false, /* force_object_return */
+                                                          local_pas,
+                                                          machine_dn);
+                       if (!W_ERROR_IS_OK(werr)) {
+                               return werr;
+                       }
+
+                       werr = get_nc_changes_add_links(sam_ctx, getnc_state,
+                                                       getnc_state->ncRoot_dn,
+                                                       getnc_state->is_schema_nc,
+                                                       schema, getnc_state->min_usn,
+                                                       req10->replica_flags,
+                                                       anc_msg,
+                                                       &getnc_state->la_list,
+                                                       &getnc_state->la_count,
+                                                       req10->uptodateness_vector);
+                       if (!W_ERROR_IS_OK(werr)) {
+                               return werr;
+                       }
+
+                       /*
+                        * Regardless of if we actually use it or not,
+                        * we add it to the cache so we don't look at it again
+                        */
+                       werr = dcesrv_drsuapi_anc_cache_add(getnc_state->anc_cache,
+                                                           next_anc_guid);
+                       if (!W_ERROR_IS_OK(werr)) {
+                               return werr;
+                       }
+
+                       /*
+                        * Any ancestors which are below the highwatermark
+                        * or uptodateness_vector shouldn't be added,
+                        * but we still look further up the
+                        * tree for ones which have been changed recently.
+                        */
+                       if (anc_obj->meta_data_ctr != NULL) {
+                               /*
+                                * prepend it to the list
+                                */
+                               anc_obj->next_object = new_objs;
+                               new_objs = anc_obj;
+                       }
+
+                       anc_msg = NULL;
+                       TALLOC_FREE(anc_res);
+                       TALLOC_FREE(anc_dn);
+
+                       /*
+                        * We may need to resolve more...
+                        */
+                       next_anc_guid = anc_obj->parent_object_guid;
+               }
+
+               *currentObject = new_objs;
+               while (new_objs != NULL) {
+                       r->out.ctr->ctr6.object_count += 1;
+                       if (new_objs->next_object == NULL) {
+                               currentObject = &new_objs->next_object;
+                       }
+                       new_objs = new_objs->next_object;
+               }
 
                DEBUG(8,(__location__ ": replicating object %s\n", ldb_dn_get_linearized(msg->dn)));
-       }
 
-       getnc_state->num_sent += r->out.ctr->ctr6.object_count;
+               talloc_free(getnc_state->last_dn);
+               getnc_state->last_dn = talloc_move(getnc_state, &msg->dn);
 
-       r->out.ctr->ctr6.nc_object_count = getnc_state->site_res->count;
+               talloc_free(msg_res);
+               talloc_free(msg_dn);
+       }
+
+       getnc_state->num_processed = i;
 
        /* the client can us to call UpdateRefs on its behalf to
           re-establish monitoring of the NC */
@@ -1579,19 +2784,25 @@ WERROR dcesrv_drsuapi_DsGetNCChanges(struct dcesrv_call_state *dce_call, TALLOC_
                DEBUG(3,("UpdateRefs on getncchanges for %s\n",
                         GUID_string(mem_ctx, &req10->destination_dsa_guid)));
                ureq.naming_context = ncRoot;
-               ureq.dest_dsa_dns_name = talloc_asprintf(mem_ctx, "%s._msdcs.%s",
-                                                        GUID_string(mem_ctx, &req10->destination_dsa_guid),
-                                                        lpcfg_dnsdomain(dce_call->conn->dce_ctx->lp_ctx));
+               ureq.dest_dsa_dns_name = samdb_ntds_msdcs_dns_name(b_state->sam_ctx, mem_ctx,
+                                                                  &req10->destination_dsa_guid);
                if (!ureq.dest_dsa_dns_name) {
-                       return WERR_NOMEM;
+                       return WERR_NOT_ENOUGH_MEMORY;
                }
                ureq.dest_dsa_guid = req10->destination_dsa_guid;
                ureq.options = DRSUAPI_DRS_ADD_REF |
                        DRSUAPI_DRS_ASYNC_OP |
                        DRSUAPI_DRS_GETCHG_CHECK;
+
+               /* we also need to pass through the
+                  DRSUAPI_DRS_REF_GCSPN bit so that repsTo gets flagged
+                  to send notifies using the GC SPN */
+               ureq.options |= (req10->replica_flags & DRSUAPI_DRS_REF_GCSPN);
+
                werr = drsuapi_UpdateRefs(b_state, mem_ctx, &ureq);
                if (!W_ERROR_IS_OK(werr)) {
-                       DEBUG(0,(__location__ ": Failed UpdateRefs in DsGetNCChanges - %s\n",
+                       DEBUG(0,(__location__ ": Failed UpdateRefs on %s for %s in DsGetNCChanges - %s\n",
+                                drs_ObjectIdentifier_to_string(mem_ctx, ncRoot), ureq.dest_dsa_dns_name,
                                 win_errstr(werr)));
                }
        }
@@ -1610,21 +2821,80 @@ WERROR dcesrv_drsuapi_DsGetNCChanges(struct dcesrv_call_state *dce_call, TALLOC_
 
        link_total = getnc_state->la_count;
 
-       if (i < getnc_state->site_res->count) {
+       if (i < getnc_state->num_records) {
                r->out.ctr->ctr6.more_data = true;
        } else {
                /* sort the whole array the first time */
-               if (!getnc_state->la_sorted) {
-                       LDB_TYPESAFE_QSORT(getnc_state->la_list, getnc_state->la_count,
-                                          sam_ctx, linked_attribute_compare);
-                       getnc_state->la_sorted = true;
+               if (getnc_state->la_sorted == NULL) {
+                       int j;
+                       struct la_for_sorting *guid_array = talloc_array(getnc_state, struct la_for_sorting, getnc_state->la_count);
+                       if (guid_array == NULL) {
+                               DEBUG(0, ("Out of memory allocating %u linked attributes for sorting", getnc_state->la_count));
+                               return WERR_NOT_ENOUGH_MEMORY;
+                       }
+                       for (j = 0; j < getnc_state->la_count; j++) {
+                               /* we need to get the target GUIDs to compare */
+                               struct dsdb_dn *dn;
+                               const struct drsuapi_DsReplicaLinkedAttribute *la = &getnc_state->la_list[j];
+                               const struct dsdb_attribute *schema_attrib;
+                               const struct ldb_val *target_guid;
+                               DATA_BLOB source_guid;
+                               TALLOC_CTX *frame = talloc_stackframe();
+
+                               schema_attrib = dsdb_attribute_by_attributeID_id(schema, la->attid);
+
+                               werr = dsdb_dn_la_from_blob(sam_ctx, schema_attrib, schema, frame, la->value.blob, &dn);
+                               if (!W_ERROR_IS_OK(werr)) {
+                                       DEBUG(0,(__location__ ": Bad la blob in sort\n"));
+                                       TALLOC_FREE(frame);
+                                       return werr;
+                               }
+
+                               /* Extract the target GUID in NDR form */
+                               target_guid = ldb_dn_get_extended_component(dn->dn, "GUID");
+                               if (target_guid == NULL
+                                   || target_guid->length != sizeof(guid_array[0].target_guid)) {
+                                       status = NT_STATUS_OBJECT_NAME_NOT_FOUND;
+                               } else {
+                                       /* Repack the source GUID as NDR for sorting */
+                                       status = GUID_to_ndr_blob(&la->identifier->guid,
+                                                                 frame,
+                                                                 &source_guid);
+                               }
+
+                               if (!NT_STATUS_IS_OK(status)
+                                   || source_guid.length != sizeof(guid_array[0].source_guid)) {
+                                       DEBUG(0,(__location__ ": Bad la guid in sort\n"));
+                                       TALLOC_FREE(frame);
+                                       return ntstatus_to_werror(status);
+                               }
+
+                               guid_array[j].link = &getnc_state->la_list[j];
+                               memcpy(guid_array[j].target_guid, target_guid->data,
+                                      sizeof(guid_array[j].target_guid));
+                               memcpy(guid_array[j].source_guid, source_guid.data,
+                                      sizeof(guid_array[j].source_guid));
+                               TALLOC_FREE(frame);
+                       }
+
+                       LDB_TYPESAFE_QSORT(guid_array, getnc_state->la_count, NULL, linked_attribute_compare);
+                       getnc_state->la_sorted = guid_array;
                }
 
                link_count = getnc_state->la_count - getnc_state->la_idx;
                link_count = MIN(max_links, link_count);
 
                r->out.ctr->ctr6.linked_attributes_count = link_count;
-               r->out.ctr->ctr6.linked_attributes = getnc_state->la_list + getnc_state->la_idx;
+               r->out.ctr->ctr6.linked_attributes = talloc_array(r->out.ctr, struct drsuapi_DsReplicaLinkedAttribute, link_count);
+               if (r->out.ctr->ctr6.linked_attributes == NULL) {
+                       DEBUG(0, ("Out of memory allocating %u linked attributes for output", link_count));
+                       return WERR_NOT_ENOUGH_MEMORY;
+               }
+
+               for (k = 0; k < link_count; k++) {
+                       r->out.ctr->ctr6.linked_attributes[k]
+                               = *getnc_state->la_sorted[getnc_state->la_idx + k].link;
+               }
 
                getnc_state->la_idx += link_count;
                link_given = getnc_state->la_idx;
@@ -1634,27 +2904,56 @@ WERROR dcesrv_drsuapi_DsGetNCChanges(struct dcesrv_call_state *dce_call, TALLOC_
                }
        }
 
+       if (req10->replica_flags & DRSUAPI_DRS_GET_NC_SIZE) {
+               /*
+                * TODO: This implementation is wrong
+                * we should find out the total number of
+                * objects and links in the whole naming context
+                * at the start of the cycle and return these
+                * values in each message.
+                *
+                * For now we keep our current strategy and return
+                * the number of objects for this cycle and the number
+                * of links we found so far during the cycle.
+                */
+               r->out.ctr->ctr6.nc_object_count = getnc_state->num_records;
+               r->out.ctr->ctr6.nc_linked_attributes_count = getnc_state->la_count;
+       }
+
        if (!r->out.ctr->ctr6.more_data) {
                talloc_steal(mem_ctx, getnc_state->la_list);
 
-               r->out.ctr->ctr6.uptodateness_vector = talloc(mem_ctx, struct drsuapi_DsReplicaCursor2CtrEx);
-               r->out.ctr->ctr6.new_highwatermark.highest_usn = r->out.ctr->ctr6.new_highwatermark.tmp_highest_usn;
-
-               werr = get_nc_changes_udv(sam_ctx, getnc_state->ncRoot_dn,
-                                         r->out.ctr->ctr6.uptodateness_vector);
-               if (!W_ERROR_IS_OK(werr)) {
-                       return werr;
-               }
+               r->out.ctr->ctr6.new_highwatermark = getnc_state->final_hwm;
+               r->out.ctr->ctr6.uptodateness_vector = talloc_move(mem_ctx,
+                                                       &getnc_state->final_udv);
 
                talloc_free(getnc_state);
                b_state->getncchanges_state = NULL;
+       } else {
+               ret = drsuapi_DsReplicaHighWaterMark_cmp(&r->out.ctr->ctr6.old_highwatermark,
+                                                        &r->out.ctr->ctr6.new_highwatermark);
+               if (ret == 0) {
+                       /*
+                        * We need to make sure that we never return the
+                        * same highwatermark within the same replication
+                        * cycle more than once. Otherwise we cannot detect
+                        * when the client uses an unexptected highwatermark.
+                        *
+                        * This is a HACK which is needed because our
+                        * object ordering is wrong and set tmp_highest_usn
+                        * to a value that is higher than what we already
+                        * sent to the client (destination dsa).
+                        */
+                       r->out.ctr->ctr6.new_highwatermark.reserved_usn += 1;
+               }
+
+               getnc_state->last_hwm = r->out.ctr->ctr6.new_highwatermark;
        }
 
        if (req10->extended_op != DRSUAPI_EXOP_NONE) {
                r->out.ctr->ctr6.uptodateness_vector = NULL;
                r->out.ctr->ctr6.nc_object_count = 0;
                ZERO_STRUCT(r->out.ctr->ctr6.new_highwatermark);
-               r->out.ctr->ctr6.extended_ret = DRSUAPI_EXOP_ERR_SUCCESS;
        }
 
        DEBUG(r->out.ctr->ctr6.more_data?4:2,
@@ -1662,7 +2961,7 @@ WERROR dcesrv_drsuapi_DsGetNCChanges(struct dcesrv_call_state *dce_call, TALLOC_
               (unsigned long long)(req10->highwatermark.highest_usn+1),
               req10->replica_flags, drs_ObjectIdentifier_to_string(mem_ctx, ncRoot),
               r->out.ctr->ctr6.object_count,
-              i, r->out.ctr->ctr6.more_data?getnc_state->site_res->count:i,
+              i, r->out.ctr->ctr6.more_data?getnc_state->num_records:i,
               r->out.ctr->ctr6.linked_attributes_count,
               link_given, link_total,
               dom_sid_string(mem_ctx, user_sid)));