gensec: Remove mem_ctx from calls that do not return memory
[nivanova/samba-autobuild/.git] / source4 / auth / gensec / spnego.c
index 461141cc84e6c99b4904ccfd3dc58f99279b2ed4..c48e87e8b5866063f775b1da79caef00718e54e7 100644 (file)
@@ -5,10 +5,11 @@
    
    Copyright (C) Jim McDonough <jmcd@us.ibm.com>      2003
    Copyright (C) Andrew Bartlett <abartlet@samba.org> 2004-2005
+   Copyright (C) Stefan Metzmacher <metze@samba.org>  2004-2008
 
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
-   the Free Software Foundation; either version 2 of the License, or
+   the Free Software Foundation; either version 3 of the License, or
    (at your option) any later version.
    
    This program is distributed in the hope that it will be useful,
 
    
    You should have received a copy of the GNU General Public License
-   along with this program; if not, write to the Free Software
-   Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
 
 #include "includes.h"
-#include "auth/auth.h"
+#include "../libcli/auth/spnego.h"
+#include "librpc/gen_ndr/ndr_dcerpc.h"
+#include "auth/credentials/credentials.h"
+#include "auth/gensec/gensec.h"
+#include "auth/gensec/gensec_proto.h"
+#include "auth/gensec/gensec_toplevel_proto.h"
+#include "param/param.h"
+
+_PUBLIC_ NTSTATUS gensec_spnego_init(void);
 
 enum spnego_state_position {
        SPNEGO_SERVER_START,
@@ -38,9 +46,11 @@ struct spnego_state {
        enum spnego_message_type expected_packet;
        enum spnego_state_position state_position;
        struct gensec_security *sub_sec_security;
-       BOOL no_response_expected;
+       bool no_response_expected;
 
        const char *neg_oid;
+
+       DATA_BLOB mech_types;
 };
 
 
@@ -48,7 +58,7 @@ static NTSTATUS gensec_spnego_client_start(struct gensec_security *gensec_securi
 {
        struct spnego_state *spnego_state;
 
-       spnego_state = talloc(gensec_security, struct spnego_state);            
+       spnego_state = talloc(gensec_security, struct spnego_state);
        if (!spnego_state) {
                return NT_STATUS_NO_MEMORY;
        }
@@ -56,7 +66,8 @@ static NTSTATUS gensec_spnego_client_start(struct gensec_security *gensec_securi
        spnego_state->expected_packet = SPNEGO_NEG_TOKEN_INIT;
        spnego_state->state_position = SPNEGO_CLIENT_START;
        spnego_state->sub_sec_security = NULL;
-       spnego_state->no_response_expected = False;
+       spnego_state->no_response_expected = false;
+       spnego_state->mech_types = data_blob(NULL, 0);
 
        gensec_security->private_data = spnego_state;
        return NT_STATUS_OK;
@@ -74,7 +85,8 @@ static NTSTATUS gensec_spnego_server_start(struct gensec_security *gensec_securi
        spnego_state->expected_packet = SPNEGO_NEG_TOKEN_INIT;
        spnego_state->state_position = SPNEGO_SERVER_START;
        spnego_state->sub_sec_security = NULL;
-       spnego_state->no_response_expected = False;
+       spnego_state->no_response_expected = false;
+       spnego_state->mech_types = data_blob(NULL, 0);
 
        gensec_security->private_data = spnego_state;
        return NT_STATUS_OK;
@@ -84,12 +96,11 @@ static NTSTATUS gensec_spnego_server_start(struct gensec_security *gensec_securi
   wrappers for the spnego_*() functions
 */
 static NTSTATUS gensec_spnego_unseal_packet(struct gensec_security *gensec_security, 
-                                           TALLOC_CTX *mem_ctx, 
                                            uint8_t *data, size_t length, 
                                            const uint8_t *whole_pdu, size_t pdu_length, 
                                            const DATA_BLOB *sig)
 {
-       struct spnego_state *spnego_state = gensec_security->private_data;
+       struct spnego_state *spnego_state = (struct spnego_state *)gensec_security->private_data;
 
        if (spnego_state->state_position != SPNEGO_DONE 
            && spnego_state->state_position != SPNEGO_FALLBACK) {
@@ -97,19 +108,17 @@ static NTSTATUS gensec_spnego_unseal_packet(struct gensec_security *gensec_secur
        }
        
        return gensec_unseal_packet(spnego_state->sub_sec_security, 
-                                   mem_ctx, 
                                    data, length, 
                                    whole_pdu, pdu_length,
                                    sig); 
 }
 
 static NTSTATUS gensec_spnego_check_packet(struct gensec_security *gensec_security, 
-                                          TALLOC_CTX *mem_ctx, 
                                           const uint8_t *data, size_t length, 
                                           const uint8_t *whole_pdu, size_t pdu_length, 
                                           const DATA_BLOB *sig)
 {
-       struct spnego_state *spnego_state = gensec_security->private_data;
+       struct spnego_state *spnego_state = (struct spnego_state *)gensec_security->private_data;
 
        if (spnego_state->state_position != SPNEGO_DONE 
            && spnego_state->state_position != SPNEGO_FALLBACK) {
@@ -117,7 +126,6 @@ static NTSTATUS gensec_spnego_check_packet(struct gensec_security *gensec_securi
        }
        
        return gensec_check_packet(spnego_state->sub_sec_security, 
-                                  mem_ctx, 
                                   data, length, 
                                   whole_pdu, pdu_length,
                                   sig);
@@ -129,7 +137,7 @@ static NTSTATUS gensec_spnego_seal_packet(struct gensec_security *gensec_securit
                                          const uint8_t *whole_pdu, size_t pdu_length, 
                                          DATA_BLOB *sig)
 {
-       struct spnego_state *spnego_state = gensec_security->private_data;
+       struct spnego_state *spnego_state = (struct spnego_state *)gensec_security->private_data;
 
        if (spnego_state->state_position != SPNEGO_DONE 
            && spnego_state->state_position != SPNEGO_FALLBACK) {
@@ -149,7 +157,7 @@ static NTSTATUS gensec_spnego_sign_packet(struct gensec_security *gensec_securit
                                          const uint8_t *whole_pdu, size_t pdu_length, 
                                          DATA_BLOB *sig)
 {
-       struct spnego_state *spnego_state = gensec_security->private_data;
+       struct spnego_state *spnego_state = (struct spnego_state *)gensec_security->private_data;
 
        if (spnego_state->state_position != SPNEGO_DONE 
            && spnego_state->state_position != SPNEGO_FALLBACK) {
@@ -168,7 +176,7 @@ static NTSTATUS gensec_spnego_wrap(struct gensec_security *gensec_security,
                                   const DATA_BLOB *in, 
                                   DATA_BLOB *out)
 {
-       struct spnego_state *spnego_state = gensec_security->private_data;
+       struct spnego_state *spnego_state = (struct spnego_state *)gensec_security->private_data;
 
        if (spnego_state->state_position != SPNEGO_DONE 
            && spnego_state->state_position != SPNEGO_FALLBACK) {
@@ -185,7 +193,7 @@ static NTSTATUS gensec_spnego_unwrap(struct gensec_security *gensec_security,
                                     const DATA_BLOB *in, 
                                     DATA_BLOB *out)
 {
-       struct spnego_state *spnego_state = gensec_security->private_data;
+       struct spnego_state *spnego_state = (struct spnego_state *)gensec_security->private_data;
 
        if (spnego_state->state_position != SPNEGO_DONE 
            && spnego_state->state_position != SPNEGO_FALLBACK) {
@@ -197,9 +205,62 @@ static NTSTATUS gensec_spnego_unwrap(struct gensec_security *gensec_security,
                             mem_ctx, in, out);
 }
 
+static NTSTATUS gensec_spnego_wrap_packets(struct gensec_security *gensec_security, 
+                                          TALLOC_CTX *mem_ctx, 
+                                          const DATA_BLOB *in, 
+                                          DATA_BLOB *out,
+                                          size_t *len_processed) 
+{
+       struct spnego_state *spnego_state = (struct spnego_state *)gensec_security->private_data;
+
+       if (spnego_state->state_position != SPNEGO_DONE 
+           && spnego_state->state_position != SPNEGO_FALLBACK) {
+               DEBUG(1, ("gensec_spnego_wrap: wrong state for wrap\n"));
+               return NT_STATUS_INVALID_PARAMETER;
+       }
+       
+       return gensec_wrap_packets(spnego_state->sub_sec_security, 
+                                  mem_ctx, in, out,
+                                  len_processed);
+}
+
+static NTSTATUS gensec_spnego_packet_full_request(struct gensec_security *gensec_security, 
+                                               DATA_BLOB blob, size_t *size)
+{
+       struct spnego_state *spnego_state = (struct spnego_state *)gensec_security->private_data;
+
+       if (spnego_state->state_position != SPNEGO_DONE 
+           && spnego_state->state_position != SPNEGO_FALLBACK) {
+               DEBUG(1, ("gensec_spnego_unwrap: wrong state for unwrap\n"));
+               return NT_STATUS_INVALID_PARAMETER;
+       }
+       
+       return gensec_packet_full_request(spnego_state->sub_sec_security, 
+                                         blob, size);
+}
+
+static NTSTATUS gensec_spnego_unwrap_packets(struct gensec_security *gensec_security, 
+                                            TALLOC_CTX *mem_ctx, 
+                                            const DATA_BLOB *in, 
+                                            DATA_BLOB *out,
+                                            size_t *len_processed) 
+{
+       struct spnego_state *spnego_state = (struct spnego_state *)gensec_security->private_data;
+
+       if (spnego_state->state_position != SPNEGO_DONE 
+           && spnego_state->state_position != SPNEGO_FALLBACK) {
+               DEBUG(1, ("gensec_spnego_unwrap: wrong state for unwrap\n"));
+               return NT_STATUS_INVALID_PARAMETER;
+       }
+       
+       return gensec_unwrap_packets(spnego_state->sub_sec_security, 
+                                    mem_ctx, in, out,
+                                    len_processed);
+}
+
 static size_t gensec_spnego_sig_size(struct gensec_security *gensec_security, size_t data_size) 
 {
-       struct spnego_state *spnego_state = gensec_security->private_data;
+       struct spnego_state *spnego_state = (struct spnego_state *)gensec_security->private_data;
 
        if (spnego_state->state_position != SPNEGO_DONE 
            && spnego_state->state_position != SPNEGO_FALLBACK) {
@@ -209,10 +270,34 @@ static size_t gensec_spnego_sig_size(struct gensec_security *gensec_security, si
        return gensec_sig_size(spnego_state->sub_sec_security, data_size);
 }
 
+static size_t gensec_spnego_max_input_size(struct gensec_security *gensec_security) 
+{
+       struct spnego_state *spnego_state = (struct spnego_state *)gensec_security->private_data;
+
+       if (spnego_state->state_position != SPNEGO_DONE 
+           && spnego_state->state_position != SPNEGO_FALLBACK) {
+               return 0;
+       }
+       
+       return gensec_max_input_size(spnego_state->sub_sec_security);
+}
+
+static size_t gensec_spnego_max_wrapped_size(struct gensec_security *gensec_security) 
+{
+       struct spnego_state *spnego_state = (struct spnego_state *)gensec_security->private_data;
+
+       if (spnego_state->state_position != SPNEGO_DONE 
+           && spnego_state->state_position != SPNEGO_FALLBACK) {
+               return 0;
+       }
+       
+       return gensec_max_wrapped_size(spnego_state->sub_sec_security);
+}
+
 static NTSTATUS gensec_spnego_session_key(struct gensec_security *gensec_security, 
                                          DATA_BLOB *session_key)
 {
-       struct spnego_state *spnego_state = gensec_security->private_data;
+       struct spnego_state *spnego_state = (struct spnego_state *)gensec_security->private_data;
        if (!spnego_state->sub_sec_security) {
                return NT_STATUS_INVALID_PARAMETER;
        }
@@ -224,7 +309,7 @@ static NTSTATUS gensec_spnego_session_key(struct gensec_security *gensec_securit
 static NTSTATUS gensec_spnego_session_info(struct gensec_security *gensec_security,
                                                                      struct auth_session_info **session_info) 
 {
-       struct spnego_state *spnego_state = gensec_security->private_data;
+       struct spnego_state *spnego_state = (struct spnego_state *)gensec_security->private_data;
        if (!spnego_state->sub_sec_security) {
                return NT_STATUS_INVALID_PARAMETER;
        }
@@ -246,19 +331,24 @@ static NTSTATUS gensec_spnego_server_try_fallback(struct gensec_security *gensec
                                                  const DATA_BLOB in, DATA_BLOB *out) 
 {
        int i,j;
-       const struct gensec_security_ops **all_ops
-               = cli_credentials_gensec_list(gensec_get_credentials(gensec_security));
+       struct gensec_security_ops **all_ops
+               = gensec_security_mechs(gensec_security, out_mem_ctx);
        for (i=0; all_ops[i]; i++) {
-               BOOL is_spnego;
+               bool is_spnego;
                NTSTATUS nt_status;
+
+               if (gensec_security != NULL && 
+                               !gensec_security_ops_enabled(all_ops[i], gensec_security))
+                   continue;
+
                if (!all_ops[i]->oid) {
                        continue;
                }
 
-               is_spnego = False;
+               is_spnego = false;
                for (j=0; all_ops[i]->oid[j]; j++) {
                        if (strcasecmp(GENSEC_OID_SPNEGO,all_ops[i]->oid[j]) == 0) {
-                               is_spnego = True;
+                               is_spnego = true;
                        }
                }
                if (is_spnego) {
@@ -312,16 +402,26 @@ static NTSTATUS gensec_spnego_parse_negTokenInit(struct gensec_security *gensec_
        int i;
        NTSTATUS nt_status = NT_STATUS_INVALID_PARAMETER;
        DATA_BLOB null_data_blob = data_blob(NULL,0);
+       bool ok;
 
        const struct gensec_security_ops_wrapper *all_sec
                = gensec_security_by_oid_list(gensec_security, 
                                              out_mem_ctx, 
                                              mechType,
                                              GENSEC_OID_SPNEGO);
+
+       ok = spnego_write_mech_types(spnego_state,
+                                    mechType,
+                                    &spnego_state->mech_types);
+       if (!ok) {
+               DEBUG(1, ("SPNEGO: Failed to write mechTypes\n"));
+               return NT_STATUS_NO_MEMORY;
+       }
+
        if (spnego_state->state_position == SPNEGO_SERVER_START) {
-               for (i=0; all_sec && all_sec[i].op; i++) {
-                       /* optomisitic token */
-                       if (strcmp(all_sec[i].oid, mechType[0]) == 0) {
+               uint32_t j;
+               for (j=0; mechType && mechType[j]; j++) {
+                       for (i=0; all_sec && all_sec[i].op; i++) {
                                nt_status = gensec_subcontext_start(spnego_state,
                                                                    gensec_security,
                                                                    &spnego_state->sub_sec_security);
@@ -336,15 +436,24 @@ static NTSTATUS gensec_spnego_parse_negTokenInit(struct gensec_security *gensec_
                                        spnego_state->sub_sec_security = NULL;
                                        break;
                                }
-                               
+
+                               if (j > 0) {
+                                       /* no optimistic token */
+                                       spnego_state->neg_oid = all_sec[i].oid;
+                                       *unwrapped_out = data_blob_null;
+                                       nt_status = NT_STATUS_MORE_PROCESSING_REQUIRED;
+                                       break;
+                               }
+
                                nt_status = gensec_update(spnego_state->sub_sec_security,
                                                          out_mem_ctx, 
                                                          unwrapped_in,
                                                          unwrapped_out);
-                               if (NT_STATUS_EQUAL(nt_status, NT_STATUS_INVALID_PARAMETER)) {
+                               if (NT_STATUS_EQUAL(nt_status, NT_STATUS_INVALID_PARAMETER) || 
+                                   NT_STATUS_EQUAL(nt_status, NT_STATUS_CANT_ACCESS_DOMAIN_INFO)) {
                                        /* Pretend we never started it (lets the first run find some incompatible demand) */
                                        
-                                       DEBUG(1, ("SPNEGO(%s) NEG_TOKEN_INIT failed to parse: %s\n", 
+                                       DEBUG(1, ("SPNEGO(%s) NEG_TOKEN_INIT failed to parse contents: %s\n", 
                                                  spnego_state->sub_sec_security->ops->name, nt_errstr(nt_status)));
                                        talloc_free(spnego_state->sub_sec_security);
                                        spnego_state->sub_sec_security = NULL;
@@ -352,10 +461,23 @@ static NTSTATUS gensec_spnego_parse_negTokenInit(struct gensec_security *gensec_
                                }
 
                                spnego_state->neg_oid = all_sec[i].oid;
+                               break;
+                       }
+                       if (spnego_state->sub_sec_security) {
+                               break;
                        }
                }
+
+               if (!spnego_state->sub_sec_security) {
+                       DEBUG(1, ("SPNEGO: Could not find a suitable mechtype in NEG_TOKEN_INIT\n"));
+                       return NT_STATUS_INVALID_PARAMETER;
+               }
        }
        
+       /* Having tried any optimistic token from the client (if we
+        * were the server), if we didn't get anywhere, walk our list
+        * in our preference order */
+       
        if (!spnego_state->sub_sec_security) {
                for (i=0; all_sec && all_sec[i].op; i++) {
                        nt_status = gensec_subcontext_start(spnego_state,
@@ -380,6 +502,27 @@ static NTSTATUS gensec_spnego_parse_negTokenInit(struct gensec_security *gensec_
                                                  out_mem_ctx, 
                                                  null_data_blob, 
                                                  unwrapped_out);
+
+                       /* it is likely that a NULL input token will
+                        * not be liked by most server mechs, but if
+                        * we are in the client, we want the first
+                        * update packet to be able to abort the use
+                        * of this mech */
+                       if (spnego_state->state_position != SPNEGO_SERVER_START) {
+                               if (NT_STATUS_EQUAL(nt_status, NT_STATUS_INVALID_PARAMETER) || 
+                                   NT_STATUS_EQUAL(nt_status, NT_STATUS_NO_LOGON_SERVERS) ||
+                                   NT_STATUS_EQUAL(nt_status, NT_STATUS_TIME_DIFFERENCE_AT_DC) ||
+                                   NT_STATUS_EQUAL(nt_status, NT_STATUS_CANT_ACCESS_DOMAIN_INFO)) {
+                                       /* Pretend we never started it (lets the first run find some incompatible demand) */
+                                       
+                                       DEBUG(1, ("SPNEGO(%s) NEG_TOKEN_INIT failed to parse: %s\n", 
+                                                 spnego_state->sub_sec_security->ops->name, nt_errstr(nt_status)));
+                                       talloc_free(spnego_state->sub_sec_security);
+                                       spnego_state->sub_sec_security = NULL;
+                                       continue;
+                               }
+                       }
+
                        break;
                }
        }
@@ -422,7 +565,7 @@ static NTSTATUS gensec_spnego_parse_negTokenInit(struct gensec_security *gensec_
         * support the first time.  Lets keep this code to
         * reality */
 
-       return NT_STATUS_INVALID_PARAMETER;
+       return nt_status;
 }
 
 /** create a negTokenInit 
@@ -440,7 +583,6 @@ static NTSTATUS gensec_spnego_create_negTokenInit(struct gensec_security *gensec
        const char **mechTypes = NULL;
        DATA_BLOB unwrapped_out = data_blob(NULL, 0);
        const struct gensec_security_ops_wrapper *all_sec;
-       const char *principal = NULL;
 
        mechTypes = gensec_security_oids(gensec_security, 
                                         out_mem_ctx, GENSEC_OID_SPNEGO);
@@ -451,6 +593,9 @@ static NTSTATUS gensec_spnego_create_negTokenInit(struct gensec_security *gensec
                                              GENSEC_OID_SPNEGO);
        for (i=0; all_sec && all_sec[i].op; i++) {
                struct spnego_data spnego_out;
+               const char **send_mech_types;
+               bool ok;
+
                nt_status = gensec_subcontext_start(spnego_state,
                                                    gensec_security,
                                                    &spnego_state->sub_sec_security);
@@ -486,22 +631,26 @@ static NTSTATUS gensec_spnego_create_negTokenInit(struct gensec_security *gensec
                }
 
                spnego_out.type = SPNEGO_NEG_TOKEN_INIT;
-               
+
+               send_mech_types = gensec_security_oids_from_ops_wrapped(out_mem_ctx,
+                                                                       &all_sec[i]);
+
+               ok = spnego_write_mech_types(spnego_state,
+                                            send_mech_types,
+                                            &spnego_state->mech_types);
+               if (!ok) {
+                       DEBUG(1, ("SPNEGO: Failed to write mechTypes\n"));
+                       return NT_STATUS_NO_MEMORY;
+               }
+
                /* List the remaining mechs as options */
-               spnego_out.negTokenInit.mechTypes = gensec_security_oids_from_ops_wrapped(out_mem_ctx, 
-                                                                                         &all_sec[i]);
-               spnego_out.negTokenInit.reqFlags = 0;
+               spnego_out.negTokenInit.mechTypes = send_mech_types;
+               spnego_out.negTokenInit.reqFlags = null_data_blob;
+               spnego_out.negTokenInit.reqFlagsPadding = 0;
                
                if (spnego_state->state_position == SPNEGO_SERVER_START) {
-                       /* server credentails */
-                       struct cli_credentials *creds = gensec_get_credentials(gensec_security);
-                       if (creds) {
-                               principal = cli_credentials_get_principal(creds, out_mem_ctx);
-                       }
-               }
-               if (principal) {
                        spnego_out.negTokenInit.mechListMIC
-                               = data_blob_string_const(principal);
+                               = data_blob_string_const(ADS_IGNORE_PRINCIPAL);
                } else {
                        spnego_out.negTokenInit.mechListMIC = null_data_blob;
                }
@@ -517,7 +666,7 @@ static NTSTATUS gensec_spnego_create_negTokenInit(struct gensec_security *gensec
                spnego_state->neg_oid = all_sec[i].oid;
                
                if (NT_STATUS_IS_OK(nt_status)) {
-                       spnego_state->no_response_expected = True;
+                       spnego_state->no_response_expected = true;
                }
 
                return NT_STATUS_MORE_PROCESSING_REQUIRED;
@@ -539,7 +688,9 @@ static NTSTATUS gensec_spnego_server_negTokenTarg(struct gensec_security *gensec
                                                  struct spnego_state *spnego_state,
                                                  TALLOC_CTX *out_mem_ctx, 
                                                  NTSTATUS nt_status,
-                                                 const DATA_BLOB unwrapped_out, DATA_BLOB *out) 
+                                                 const DATA_BLOB unwrapped_out,
+                                                 DATA_BLOB mech_list_mic,
+                                                 DATA_BLOB *out)
 {
        struct spnego_data spnego_out;
        DATA_BLOB null_data_blob = data_blob(NULL, 0);
@@ -559,6 +710,7 @@ static NTSTATUS gensec_spnego_server_negTokenTarg(struct gensec_security *gensec
                        spnego_out.negTokenTarg.supportedMech = spnego_state->neg_oid;
                }
                spnego_out.negTokenTarg.negResult = SPNEGO_ACCEPT_COMPLETED;
+               spnego_out.negTokenTarg.mechListMIC = mech_list_mic;
                spnego_state->state_position = SPNEGO_DONE;
        } else {
                spnego_out.negTokenTarg.negResult = SPNEGO_REJECT;
@@ -580,8 +732,9 @@ static NTSTATUS gensec_spnego_server_negTokenTarg(struct gensec_security *gensec
 static NTSTATUS gensec_spnego_update(struct gensec_security *gensec_security, TALLOC_CTX *out_mem_ctx, 
                                     const DATA_BLOB in, DATA_BLOB *out) 
 {
-       struct spnego_state *spnego_state = gensec_security->private_data;
+       struct spnego_state *spnego_state = (struct spnego_state *)gensec_security->private_data;
        DATA_BLOB null_data_blob = data_blob(NULL, 0);
+       DATA_BLOB mech_list_mic = data_blob(NULL, 0);
        DATA_BLOB unwrapped_out = data_blob(NULL, 0);
        struct spnego_data spnego_out;
        struct spnego_data spnego;
@@ -605,7 +758,7 @@ static NTSTATUS gensec_spnego_update(struct gensec_security *gensec_security, TA
                NTSTATUS nt_status;
                if (in.length) {
 
-                       len = spnego_read_data(in, &spnego);
+                       len = spnego_read_data(gensec_security, in, &spnego);
                        if (len == -1) {
                                return gensec_spnego_server_try_fallback(gensec_security, spnego_state, 
                                                                         out_mem_ctx, in, out);
@@ -632,7 +785,8 @@ static NTSTATUS gensec_spnego_update(struct gensec_security *gensec_security, TA
                                                                      spnego_state,
                                                                      out_mem_ctx,
                                                                      nt_status,
-                                                                     unwrapped_out, 
+                                                                     unwrapped_out,
+                                                                     null_data_blob,
                                                                      out);
                        
                        spnego_free_data(&spnego);
@@ -663,7 +817,7 @@ static NTSTATUS gensec_spnego_update(struct gensec_security *gensec_security, TA
                        return nt_status;
                }
                
-               len = spnego_read_data(in, &spnego);
+               len = spnego_read_data(gensec_security, in, &spnego);
                
                if (len == -1) {
                        DEBUG(1, ("Invalid SPNEGO request:\n"));
@@ -680,9 +834,12 @@ static NTSTATUS gensec_spnego_update(struct gensec_security *gensec_security, TA
                        return NT_STATUS_INVALID_PARAMETER;
                }
 
-               if (spnego.negTokenInit.targetPrincipal) {
+               if (spnego.negTokenInit.targetPrincipal
+                   && strcmp(spnego.negTokenInit.targetPrincipal, ADS_IGNORE_PRINCIPAL) != 0) {
                        DEBUG(5, ("Server claims it's principal name is %s\n", spnego.negTokenInit.targetPrincipal));
-                       gensec_set_target_principal(gensec_security, spnego.negTokenInit.targetPrincipal);
+                       if (lpcfg_client_use_spnego_principal(gensec_security->settings->lp_ctx)) {
+                               gensec_set_target_principal(gensec_security, spnego.negTokenInit.targetPrincipal);
+                       }
                }
 
                nt_status = gensec_spnego_parse_negTokenInit(gensec_security,
@@ -701,7 +858,8 @@ static NTSTATUS gensec_spnego_update(struct gensec_security *gensec_security, TA
                /* compose reply */
                spnego_out.type = SPNEGO_NEG_TOKEN_INIT;
                spnego_out.negTokenInit.mechTypes = my_mechs;
-               spnego_out.negTokenInit.reqFlags = 0;
+               spnego_out.negTokenInit.reqFlags = null_data_blob;
+               spnego_out.negTokenInit.reqFlagsPadding = 0;
                spnego_out.negTokenInit.mechListMIC = null_data_blob;
                spnego_out.negTokenInit.mechToken = unwrapped_out;
                
@@ -715,7 +873,7 @@ static NTSTATUS gensec_spnego_update(struct gensec_security *gensec_security, TA
                spnego_state->state_position = SPNEGO_CLIENT_TARG;
 
                if (NT_STATUS_IS_OK(nt_status)) {
-                       spnego_state->no_response_expected = True;
+                       spnego_state->no_response_expected = true;
                }
                
                spnego_free_data(&spnego);
@@ -724,11 +882,13 @@ static NTSTATUS gensec_spnego_update(struct gensec_security *gensec_security, TA
        case SPNEGO_SERVER_TARG:
        {
                NTSTATUS nt_status;
+               bool new_spnego = false;
+
                if (!in.length) {
                        return NT_STATUS_INVALID_PARAMETER;
                }
                
-               len = spnego_read_data(in, &spnego);
+               len = spnego_read_data(gensec_security, in, &spnego);
                
                if (len == -1) {
                        DEBUG(1, ("Invalid SPNEGO request:\n"));
@@ -755,12 +915,39 @@ static NTSTATUS gensec_spnego_update(struct gensec_security *gensec_security, TA
                                          out_mem_ctx, 
                                          spnego.negTokenTarg.responseToken,
                                          &unwrapped_out);
+               if (NT_STATUS_IS_OK(nt_status) && spnego.negTokenTarg.mechListMIC.length > 0) {
+                       new_spnego = true;
+                       nt_status = gensec_check_packet(spnego_state->sub_sec_security,
+                                                       spnego_state->mech_types.data,
+                                                       spnego_state->mech_types.length,
+                                                       spnego_state->mech_types.data,
+                                                       spnego_state->mech_types.length,
+                                                       &spnego.negTokenTarg.mechListMIC);
+                       if (!NT_STATUS_IS_OK(nt_status)) {
+                               DEBUG(2,("GENSEC SPNEGO: failed to verify mechListMIC: %s\n",
+                                       nt_errstr(nt_status)));
+                       }
+               }
+               if (NT_STATUS_IS_OK(nt_status) && new_spnego) {
+                       nt_status = gensec_sign_packet(spnego_state->sub_sec_security,
+                                                      out_mem_ctx,
+                                                      spnego_state->mech_types.data,
+                                                      spnego_state->mech_types.length,
+                                                      spnego_state->mech_types.data,
+                                                      spnego_state->mech_types.length,
+                                                      &mech_list_mic);
+                       if (!NT_STATUS_IS_OK(nt_status)) {
+                               DEBUG(2,("GENSEC SPNEGO: failed to sign mechListMIC: %s\n",
+                                       nt_errstr(nt_status)));
+                       }
+               }
 
                nt_status = gensec_spnego_server_negTokenTarg(gensec_security,
                                                              spnego_state,
                                                              out_mem_ctx, 
                                                              nt_status,
-                                                             unwrapped_out, 
+                                                             unwrapped_out,
+                                                             mech_list_mic,
                                                              out);
                
                spnego_free_data(&spnego);
@@ -774,7 +961,7 @@ static NTSTATUS gensec_spnego_update(struct gensec_security *gensec_security, TA
                        return NT_STATUS_INVALID_PARAMETER;
                }
                
-               len = spnego_read_data(in, &spnego);
+               len = spnego_read_data(gensec_security, in, &spnego);
                
                if (len == -1) {
                        DEBUG(1, ("Invalid SPNEGO request:\n"));
@@ -798,10 +985,11 @@ static NTSTATUS gensec_spnego_update(struct gensec_security *gensec_security, TA
 
                /* Server didn't like our choice of mech, and chose something else */
                if ((spnego.negTokenTarg.negResult == SPNEGO_ACCEPT_INCOMPLETE) &&
+                   spnego.negTokenTarg.supportedMech &&
                    strcmp(spnego.negTokenTarg.supportedMech, spnego_state->neg_oid) != 0) {
                        DEBUG(3,("GENSEC SPNEGO: client preferred mech (%s) not accepted, server wants: %s\n",
-                                gensec_get_name_by_oid(spnego.negTokenTarg.supportedMech), 
-                                gensec_get_name_by_oid(spnego_state->neg_oid)));
+                                gensec_get_name_by_oid(gensec_security, spnego.negTokenTarg.supportedMech), 
+                                gensec_get_name_by_oid(gensec_security, spnego_state->neg_oid)));
                        
                        talloc_free(spnego_state->sub_sec_security);
                        nt_status = gensec_subcontext_start(spnego_state,
@@ -834,14 +1022,46 @@ static NTSTATUS gensec_spnego_update(struct gensec_security *gensec_security, TA
                        } else {
                                nt_status = NT_STATUS_OK;
                        }
+                       if (NT_STATUS_IS_OK(nt_status) && spnego.negTokenTarg.mechListMIC.length > 0) {
+                               nt_status = gensec_check_packet(spnego_state->sub_sec_security,
+                                                               spnego_state->mech_types.data,
+                                                               spnego_state->mech_types.length,
+                                                               spnego_state->mech_types.data,
+                                                               spnego_state->mech_types.length,
+                                                               &spnego.negTokenTarg.mechListMIC);
+                               if (!NT_STATUS_IS_OK(nt_status)) {
+                                       DEBUG(2,("GENSEC SPNEGO: failed to verify mechListMIC: %s\n",
+                                               nt_errstr(nt_status)));
+                               }
+                       }
                } else {
+                       bool new_spnego = false;
+
                        nt_status = gensec_update(spnego_state->sub_sec_security,
                                                  out_mem_ctx, 
                                                  spnego.negTokenTarg.responseToken, 
                                                  &unwrapped_out);
 
+                       if (NT_STATUS_IS_OK(nt_status)
+                           && spnego.negTokenTarg.negResult != SPNEGO_ACCEPT_COMPLETED) {
+                               new_spnego = gensec_have_feature(spnego_state->sub_sec_security,
+                                                                GENSEC_FEATURE_NEW_SPNEGO);
+                       }
+                       if (NT_STATUS_IS_OK(nt_status) && new_spnego) {
+                               nt_status = gensec_sign_packet(spnego_state->sub_sec_security,
+                                                              out_mem_ctx,
+                                                              spnego_state->mech_types.data,
+                                                              spnego_state->mech_types.length,
+                                                              spnego_state->mech_types.data,
+                                                              spnego_state->mech_types.length,
+                                                              &mech_list_mic);
+                               if (!NT_STATUS_IS_OK(nt_status)) {
+                                       DEBUG(2,("GENSEC SPNEGO: failed to sign mechListMIC: %s\n",
+                                               nt_errstr(nt_status)));
+                               }
+                       }
                        if (NT_STATUS_IS_OK(nt_status)) {
-                               spnego_state->no_response_expected = True;
+                               spnego_state->no_response_expected = true;
                        }
                } 
                
@@ -855,13 +1075,13 @@ static NTSTATUS gensec_spnego_update(struct gensec_security *gensec_security, TA
                        return nt_status;
                }
 
-               if (unwrapped_out.length) {
+               if (unwrapped_out.length || mech_list_mic.length) {
                        /* compose reply */
                        spnego_out.type = SPNEGO_NEG_TOKEN_TARG;
                        spnego_out.negTokenTarg.negResult = SPNEGO_NONE_RESULT;
                        spnego_out.negTokenTarg.supportedMech = NULL;
                        spnego_out.negTokenTarg.responseToken = unwrapped_out;
-                       spnego_out.negTokenTarg.mechListMIC = null_data_blob;
+                       spnego_out.negTokenTarg.mechListMIC = mech_list_mic;
                        
                        if (spnego_write_data(out_mem_ctx, out, &spnego_out) == -1) {
                                DEBUG(1, ("Failed to write SPNEGO reply to NEG_TOKEN_TARG\n"));
@@ -893,12 +1113,26 @@ static NTSTATUS gensec_spnego_update(struct gensec_security *gensec_security, TA
        return NT_STATUS_INVALID_PARAMETER;
 }
 
-static BOOL gensec_spnego_have_feature(struct gensec_security *gensec_security,
+static void gensec_spnego_want_feature(struct gensec_security *gensec_security,
+                                      uint32_t feature)
+{
+       struct spnego_state *spnego_state = (struct spnego_state *)gensec_security->private_data;
+
+       if (!spnego_state || !spnego_state->sub_sec_security) {
+               gensec_security->want_features |= feature;
+               return;
+       }
+
+       gensec_want_feature(spnego_state->sub_sec_security,
+                           feature);
+}
+
+static bool gensec_spnego_have_feature(struct gensec_security *gensec_security,
                                       uint32_t feature) 
 {
-       struct spnego_state *spnego_state = gensec_security->private_data;
+       struct spnego_state *spnego_state = (struct spnego_state *)gensec_security->private_data;
        if (!spnego_state->sub_sec_security) {
-               return False;
+               return false;
        }
        
        return gensec_have_feature(spnego_state->sub_sec_security, 
@@ -911,27 +1145,34 @@ static const char *gensec_spnego_oids[] = {
 };
 
 static const struct gensec_security_ops gensec_spnego_security_ops = {
-       .name           = "spnego",
-       .sasl_name      = "GSS-SPNEGO",
-       .auth_type      = DCERPC_AUTH_TYPE_SPNEGO,
-       .oid            = gensec_spnego_oids,
-       .client_start   = gensec_spnego_client_start,
-       .server_start   = gensec_spnego_server_start,
-       .update         = gensec_spnego_update,
-       .seal_packet    = gensec_spnego_seal_packet,
-       .sign_packet    = gensec_spnego_sign_packet,
-       .sig_size       = gensec_spnego_sig_size,
-       .check_packet   = gensec_spnego_check_packet,
-       .unseal_packet  = gensec_spnego_unseal_packet,
-       .wrap           = gensec_spnego_wrap,
-       .unwrap         = gensec_spnego_unwrap,
-       .session_key    = gensec_spnego_session_key,
-       .session_info   = gensec_spnego_session_info,
-       .have_feature   = gensec_spnego_have_feature,
-       .enabled        = True
+       .name             = "spnego",
+       .sasl_name        = "GSS-SPNEGO",
+       .auth_type        = DCERPC_AUTH_TYPE_SPNEGO,
+       .oid              = gensec_spnego_oids,
+       .client_start     = gensec_spnego_client_start,
+       .server_start     = gensec_spnego_server_start,
+       .update           = gensec_spnego_update,
+       .seal_packet      = gensec_spnego_seal_packet,
+       .sign_packet      = gensec_spnego_sign_packet,
+       .sig_size         = gensec_spnego_sig_size,
+       .max_wrapped_size = gensec_spnego_max_wrapped_size,
+       .max_input_size   = gensec_spnego_max_input_size,
+       .check_packet     = gensec_spnego_check_packet,
+       .unseal_packet    = gensec_spnego_unseal_packet,
+       .packet_full_request = gensec_spnego_packet_full_request,
+       .wrap             = gensec_spnego_wrap,
+       .unwrap           = gensec_spnego_unwrap,
+       .wrap_packets     = gensec_spnego_wrap_packets,
+       .unwrap_packets   = gensec_spnego_unwrap_packets,
+       .session_key      = gensec_spnego_session_key,
+       .session_info     = gensec_spnego_session_info,
+       .want_feature     = gensec_spnego_want_feature,
+       .have_feature     = gensec_spnego_have_feature,
+       .enabled          = true,
+       .priority         = GENSEC_SPNEGO
 };
 
-NTSTATUS gensec_spnego_init(void)
+_PUBLIC_ NTSTATUS gensec_spnego_init(void)
 {
        NTSTATUS ret;
        ret = gensec_register(&gensec_spnego_security_ops);