s3: Remove unused "retry" from cli_full_connection
[nivanova/samba-autobuild/.git] / source3 / utils / smbcacls.c
index affebf38be53a5d1b44f02e7f9f053906d293586..2800ed982b66b7f518676efb83e5597862e634a3 100644 (file)
 */
 
 #include "includes.h"
+#include "popt_common.h"
+#include "../librpc/gen_ndr/ndr_lsa.h"
+#include "rpc_client/cli_lsarpc.h"
+#include "../libcli/security/security.h"
 
-static pstring owner_username;
-static fstring server;
-static int test_args = False;
-static TALLOC_CTX *ctx;
+static int test_args;
 
 #define CREATE_ACCESS_READ READ_CONTROL_ACCESS
 
 /* numeric is set when the user wants numeric SIDs and ACEs rather
    than going via LSA calls to resolve them */
-static bool numeric = False;
+static int numeric;
+
+static int sddl;
 
 enum acl_mode {SMB_ACL_SET, SMB_ACL_DELETE, SMB_ACL_MODIFY, SMB_ACL_ADD };
-enum chown_mode {REQUEST_NONE, REQUEST_CHOWN, REQUEST_CHGRP};
+enum chown_mode {REQUEST_NONE, REQUEST_CHOWN, REQUEST_CHGRP, REQUEST_INHERIT};
 enum exit_values {EXIT_OK, EXIT_FAILED, EXIT_PARSE_ERROR};
 
 struct perm_value {
@@ -62,115 +65,222 @@ static const struct perm_value standard_values[] = {
        { NULL, 0 },
 };
 
-static struct cli_state *global_hack_cli;
-static struct rpc_pipe_client *global_pipe_hnd;
-static POLICY_HND pol;
-static bool got_policy_hnd;
-
-static struct cli_state *connect_one(const char *share);
-
 /* Open cli connection and policy handle */
 
-static bool cacls_open_policy_hnd(void)
+static NTSTATUS cli_lsa_lookup_sid(struct cli_state *cli,
+                                  const struct dom_sid *sid,
+                                  TALLOC_CTX *mem_ctx,
+                                  enum lsa_SidType *type,
+                                  char **domain, char **name)
 {
-       /* Initialise cli LSA connection */
-
-       if (!global_hack_cli) {
-               NTSTATUS ret;
-               global_hack_cli = connect_one("IPC$");
-               global_pipe_hnd = cli_rpc_pipe_open_noauth(global_hack_cli, PI_LSARPC, &ret);
-               if (!global_pipe_hnd) {
-                               return False;
-               }
+       uint16 orig_cnum = cli->cnum;
+       struct rpc_pipe_client *p = NULL;
+       struct policy_handle handle;
+       NTSTATUS status;
+       TALLOC_CTX *frame = talloc_stackframe();
+       enum lsa_SidType *types;
+       char **domains;
+       char **names;
+
+       status = cli_tcon_andx(cli, "IPC$", "?????", "", 0);
+       if (!NT_STATUS_IS_OK(status)) {
+               return status;
        }
-       
-       /* Open policy handle */
 
-       if (!got_policy_hnd) {
+       status = cli_rpc_pipe_open_noauth(cli, &ndr_table_lsarpc.syntax_id,
+                                         &p);
+       if (!NT_STATUS_IS_OK(status)) {
+               goto fail;
+       }
 
-               /* Some systems don't support SEC_RIGHTS_MAXIMUM_ALLOWED,
-                  but NT sends 0x2000000 so we might as well do it too. */
+       status = rpccli_lsa_open_policy(p, talloc_tos(), True,
+                                       GENERIC_EXECUTE_ACCESS, &handle);
+       if (!NT_STATUS_IS_OK(status)) {
+               goto fail;
+       }
 
-               if (!NT_STATUS_IS_OK(rpccli_lsa_open_policy(global_pipe_hnd, global_hack_cli->mem_ctx, True, 
-                                                        GENERIC_EXECUTE_ACCESS, &pol))) {
-                       return False;
-               }
+       status = rpccli_lsa_lookup_sids(p, talloc_tos(), &handle, 1, sid,
+                                       &domains, &names, &types);
+       if (!NT_STATUS_IS_OK(status)) {
+               goto fail;
+       }
+
+       *type = types[0];
+       *domain = talloc_move(mem_ctx, &domains[0]);
+       *name = talloc_move(mem_ctx, &names[0]);
+
+       status = NT_STATUS_OK;
+ fail:
+       TALLOC_FREE(p);
+       cli_tdis(cli);
+       cli->cnum = orig_cnum;
+       TALLOC_FREE(frame);
+       return status;
+}
 
-               got_policy_hnd = True;
+static NTSTATUS cli_lsa_lookup_name(struct cli_state *cli,
+                                   const char *name,
+                                   enum lsa_SidType *type,
+                                   struct dom_sid *sid)
+{
+       uint16 orig_cnum = cli->cnum;
+       struct rpc_pipe_client *p;
+       struct policy_handle handle;
+       NTSTATUS status;
+       TALLOC_CTX *frame = talloc_stackframe();
+       struct dom_sid *sids;
+       enum lsa_SidType *types;
+
+       status = cli_tcon_andx(cli, "IPC$", "?????", "", 0);
+       if (!NT_STATUS_IS_OK(status)) {
+               return status;
        }
-       
-       return True;
+
+       status = cli_rpc_pipe_open_noauth(cli, &ndr_table_lsarpc.syntax_id,
+                                         &p);
+       if (!NT_STATUS_IS_OK(status)) {
+               goto fail;
+       }
+
+       status = rpccli_lsa_open_policy(p, talloc_tos(), True,
+                                       GENERIC_EXECUTE_ACCESS, &handle);
+       if (!NT_STATUS_IS_OK(status)) {
+               goto fail;
+       }
+
+       status = rpccli_lsa_lookup_names(p, talloc_tos(), &handle, 1, &name,
+                                        NULL, 1, &sids, &types);
+       if (!NT_STATUS_IS_OK(status)) {
+               goto fail;
+       }
+
+       *type = types[0];
+       *sid = sids[0];
+
+       status = NT_STATUS_OK;
+ fail:
+       TALLOC_FREE(p);
+       cli_tdis(cli);
+       cli->cnum = orig_cnum;
+       TALLOC_FREE(frame);
+       return status;
 }
 
 /* convert a SID to a string, either numeric or username/group */
-static void SidToString(fstring str, DOM_SID *sid)
+static void SidToString(struct cli_state *cli, fstring str, const struct dom_sid *sid)
 {
-       char **domains = NULL;
-       char **names = NULL;
-       enum lsa_SidType *types = NULL;
+       char *domain = NULL;
+       char *name = NULL;
+       enum lsa_SidType type;
+       NTSTATUS status;
 
-       sid_to_string(str, sid);
+       sid_to_fstring(str, sid);
 
-       if (numeric) return;
+       if (numeric) {
+               return;
+       }
 
-       /* Ask LSA to convert the sid to a name */
+       status = cli_lsa_lookup_sid(cli, sid, talloc_tos(), &type,
+                                   &domain, &name);
 
-       if (!cacls_open_policy_hnd() ||
-           !NT_STATUS_IS_OK(rpccli_lsa_lookup_sids(global_pipe_hnd, global_hack_cli->mem_ctx,  
-                                                &pol, 1, sid, &domains, 
-                                                &names, &types)) ||
-           !domains || !domains[0] || !names || !names[0]) {
+       if (!NT_STATUS_IS_OK(status)) {
                return;
        }
 
-       /* Converted OK */
-
-       slprintf(str, sizeof(fstring) - 1, "%s%s%s",
-                domains[0], lp_winbind_separator(),
-                names[0]);
-       
+       if (*domain) {
+               slprintf(str, sizeof(fstring) - 1, "%s%s%s",
+                       domain, lp_winbind_separator(), name);
+       } else {
+               fstrcpy(str, name);
+       }
 }
 
 /* convert a string to a SID, either numeric or username/group */
-static bool StringToSid(DOM_SID *sid, const char *str)
+static bool StringToSid(struct cli_state *cli, struct dom_sid *sid, const char *str)
 {
-       enum lsa_SidType *types = NULL;
-       DOM_SID *sids = NULL;
-       bool result = True;
+       enum lsa_SidType type;
 
-       if (strncmp(str, "S-", 2) == 0) {
-               return string_to_sid(sid, str);
+       if (string_to_sid(sid, str)) {
+               return true;
        }
 
-       if (!cacls_open_policy_hnd() ||
-           !NT_STATUS_IS_OK(rpccli_lsa_lookup_names(global_pipe_hnd, global_hack_cli->mem_ctx, 
-                                                 &pol, 1, &str, NULL, 1, &sids, 
-                                                 &types))) {
-               result = False;
-               goto done;
+       return NT_STATUS_IS_OK(cli_lsa_lookup_name(cli, str, &type, sid));
+}
+
+static void print_ace_flags(FILE *f, uint8_t flags)
+{
+       char *str = talloc_strdup(NULL, "");
+
+       if (!str) {
+               goto out;
        }
 
-       sid_copy(sid, &sids[0]);
- done:
+       if (flags & SEC_ACE_FLAG_OBJECT_INHERIT) {
+               str = talloc_asprintf(str, "%s%s",
+                               str, "OI|");
+               if (!str) {
+                       goto out;
+               }
+       }
+       if (flags & SEC_ACE_FLAG_CONTAINER_INHERIT) {
+               str = talloc_asprintf(str, "%s%s",
+                               str, "CI|");
+               if (!str) {
+                       goto out;
+               }
+       }
+       if (flags & SEC_ACE_FLAG_NO_PROPAGATE_INHERIT) {
+               str = talloc_asprintf(str, "%s%s",
+                               str, "NP|");
+               if (!str) {
+                       goto out;
+               }
+       }
+       if (flags & SEC_ACE_FLAG_INHERIT_ONLY) {
+               str = talloc_asprintf(str, "%s%s",
+                               str, "IO|");
+               if (!str) {
+                       goto out;
+               }
+       }
+       if (flags & SEC_ACE_FLAG_INHERITED_ACE) {
+               str = talloc_asprintf(str, "%s%s",
+                               str, "I|");
+               if (!str) {
+                       goto out;
+               }
+       }
+       /* Ignore define SEC_ACE_FLAG_SUCCESSFUL_ACCESS ( 0x40 )
+          and SEC_ACE_FLAG_FAILED_ACCESS ( 0x80 ) as they're
+          audit ace flags. */
 
-       return result;
-}
+       if (str[strlen(str)-1] == '|') {
+               str[strlen(str)-1] = '\0';
+               fprintf(f, "/%s/", str);
+       } else {
+               fprintf(f, "/0x%x/", flags);
+       }
+       TALLOC_FREE(str);
+       return;
 
+  out:
+       fprintf(f, "/0x%x/", flags);
+}
 
 /* print an ACE on a FILE, using either numeric or ascii representation */
-static void print_ace(FILE *f, SEC_ACE *ace)
+static void print_ace(struct cli_state *cli, FILE *f, struct security_ace *ace)
 {
        const struct perm_value *v;
        fstring sidstr;
        int do_print = 0;
        uint32 got_mask;
 
-       SidToString(sidstr, &ace->trustee);
+       SidToString(cli, sidstr, &ace->trustee);
 
        fprintf(f, "%s:", sidstr);
 
        if (numeric) {
-               fprintf(f, "%d/%d/0x%08x", 
+               fprintf(f, "%d/0x%x/0x%08x",
                        ace->type, ace->flags, ace->access_mask);
                return;
        }
@@ -185,9 +295,7 @@ static void print_ace(FILE *f, SEC_ACE *ace)
                fprintf(f, "%d", ace->type);
        }
 
-       /* Not sure what flags can be set in a file ACL */
-
-       fprintf(f, "/%d/", ace->flags);
+       print_ace_flags(f, ace->flags);
 
        /* Standard permissions */
 
@@ -223,22 +331,56 @@ static void print_ace(FILE *f, SEC_ACE *ace)
        }
 }
 
+static bool parse_ace_flags(const char *str, unsigned int *pflags)
+{
+       const char *p = str;
+       *pflags = 0;
+
+       while (*p) {
+               if (strnequal(p, "OI", 2)) {
+                       *pflags |= SEC_ACE_FLAG_OBJECT_INHERIT;
+                       p += 2;
+               } else if (strnequal(p, "CI", 2)) {
+                       *pflags |= SEC_ACE_FLAG_CONTAINER_INHERIT;
+                       p += 2;
+               } else if (strnequal(p, "NP", 2)) {
+                       *pflags |= SEC_ACE_FLAG_NO_PROPAGATE_INHERIT;
+                       p += 2;
+               } else if (strnequal(p, "IO", 2)) {
+                       *pflags |= SEC_ACE_FLAG_INHERIT_ONLY;
+                       p += 2;
+               } else if (*p == 'I') {
+                       *pflags |= SEC_ACE_FLAG_INHERITED_ACE;
+                       p += 1;
+               } else if (*p) {
+                       return false;
+               }
+
+               if (*p != '|' && *p != '\0') {
+                       return false;
+               }
+       }
+       return true;
+}
 
 /* parse an ACE in the same format as print_ace() */
-static bool parse_ace(SEC_ACE *ace, const char *orig_str)
+static bool parse_ace(struct cli_state *cli, struct security_ace *ace,
+                     const char *orig_str)
 {
        char *p;
        const char *cp;
-       fstring tok;
+       char *tok;
        unsigned int atype = 0;
        unsigned int aflags = 0;
        unsigned int amask = 0;
-       DOM_SID sid;
-       SEC_ACCESS mask;
+       struct dom_sid sid;
+       uint32_t mask;
        const struct perm_value *v;
        char *str = SMB_STRDUP(orig_str);
+       TALLOC_CTX *frame = talloc_stackframe();
 
        if (!str) {
+               TALLOC_FREE(frame);
                return False;
        }
 
@@ -247,6 +389,7 @@ static bool parse_ace(SEC_ACE *ace, const char *orig_str)
        if (!p) {
                printf("ACE '%s': missing ':'.\n", orig_str);
                SAFE_FREE(str);
+               TALLOC_FREE(frame);
                return False;
        }
        *p = '\0';
@@ -254,24 +397,26 @@ static bool parse_ace(SEC_ACE *ace, const char *orig_str)
        /* Try to parse numeric form */
 
        if (sscanf(p, "%i/%i/%i", &atype, &aflags, &amask) == 3 &&
-           StringToSid(&sid, str)) {
+           StringToSid(cli, &sid, str)) {
                goto done;
        }
 
        /* Try to parse text form */
 
-       if (!StringToSid(&sid, str)) {
+       if (!StringToSid(cli, &sid, str)) {
                printf("ACE '%s': failed to convert '%s' to SID\n",
                        orig_str, str);
                SAFE_FREE(str);
+               TALLOC_FREE(frame);
                return False;
        }
 
        cp = p;
-       if (!next_token(&cp, tok, "/", sizeof(fstring))) {
+       if (!next_token_talloc(frame, &cp, &tok, "/")) {
                printf("ACE '%s': failed to find '/' character.\n",
                        orig_str);
                SAFE_FREE(str);
+               TALLOC_FREE(frame);
                return False;
        }
 
@@ -283,23 +428,51 @@ static bool parse_ace(SEC_ACE *ace, const char *orig_str)
                printf("ACE '%s': missing 'ALLOWED' or 'DENIED' entry at '%s'\n",
                        orig_str, tok);
                SAFE_FREE(str);
+               TALLOC_FREE(frame);
                return False;
        }
 
        /* Only numeric form accepted for flags at present */
 
-       if (!(next_token(&cp, tok, "/", sizeof(fstring)) &&
-             sscanf(tok, "%i", &aflags))) {
-               printf("ACE '%s': bad integer flags entry at '%s'\n",
+       if (!next_token_talloc(frame, &cp, &tok, "/")) {
+               printf("ACE '%s': bad flags entry at '%s'\n",
                        orig_str, tok);
                SAFE_FREE(str);
+               TALLOC_FREE(frame);
                return False;
        }
 
-       if (!next_token(&cp, tok, "/", sizeof(fstring))) {
+       if (tok[0] < '0' || tok[0] > '9') {
+               if (!parse_ace_flags(tok, &aflags)) {
+                       printf("ACE '%s': bad named flags entry at '%s'\n",
+                               orig_str, tok);
+                       SAFE_FREE(str);
+                       TALLOC_FREE(frame);
+                       return False;
+               }
+       } else if (strnequal(tok, "0x", 2)) {
+               if (!sscanf(tok, "%x", &aflags)) {
+                       printf("ACE '%s': bad hex flags entry at '%s'\n",
+                               orig_str, tok);
+                       SAFE_FREE(str);
+                       TALLOC_FREE(frame);
+                       return False;
+               }
+       } else {
+               if (!sscanf(tok, "%i", &aflags)) {
+                       printf("ACE '%s': bad integer flags entry at '%s'\n",
+                               orig_str, tok);
+                       SAFE_FREE(str);
+                       TALLOC_FREE(frame);
+                       return False;
+               }
+       }
+
+       if (!next_token_talloc(frame, &cp, &tok, "/")) {
                printf("ACE '%s': missing / at '%s'\n",
                        orig_str, tok);
                SAFE_FREE(str);
+               TALLOC_FREE(frame);
                return False;
        }
 
@@ -308,6 +481,7 @@ static bool parse_ace(SEC_ACE *ace, const char *orig_str)
                        printf("ACE '%s': bad hex number at '%s'\n",
                                orig_str, tok);
                        SAFE_FREE(str);
+                       TALLOC_FREE(frame);
                        return False;
                }
                goto done;
@@ -336,12 +510,14 @@ static bool parse_ace(SEC_ACE *ace, const char *orig_str)
                        printf("ACE '%s': bad permission value at '%s'\n",
                                orig_str, p);
                        SAFE_FREE(str);
+                       TALLOC_FREE(frame);
                        return False;
                }
                p++;
        }
 
        if (*p) {
+               TALLOC_FREE(frame);
                SAFE_FREE(str);
                return False;
        }
@@ -349,43 +525,45 @@ static bool parse_ace(SEC_ACE *ace, const char *orig_str)
  done:
        mask = amask;
        init_sec_ace(ace, &sid, atype, mask, aflags);
+       TALLOC_FREE(frame);
        SAFE_FREE(str);
        return True;
 }
 
-/* add an ACE to a list of ACEs in a SEC_ACL */
-static bool add_ace(SEC_ACL **the_acl, SEC_ACE *ace)
+/* add an ACE to a list of ACEs in a struct security_acl */
+static bool add_ace(struct security_acl **the_acl, struct security_ace *ace)
 {
-       SEC_ACL *new_ace;
-       SEC_ACE *aces;
+       struct security_acl *new_ace;
+       struct security_ace *aces;
        if (! *the_acl) {
-               return (((*the_acl) = make_sec_acl(ctx, 3, 1, ace)) != NULL);
+               return (((*the_acl) = make_sec_acl(talloc_tos(), 3, 1, ace))
+                       != NULL);
        }
 
-       if (!(aces = SMB_CALLOC_ARRAY(SEC_ACE, 1+(*the_acl)->num_aces))) {
+       if (!(aces = SMB_CALLOC_ARRAY(struct security_ace, 1+(*the_acl)->num_aces))) {
                return False;
        }
-       memcpy(aces, (*the_acl)->aces, (*the_acl)->num_aces * sizeof(SEC_ACE));
-       memcpy(aces+(*the_acl)->num_aces, ace, sizeof(SEC_ACE));
-       new_ace = make_sec_acl(ctx,(*the_acl)->revision,1+(*the_acl)->num_aces, aces);
+       memcpy(aces, (*the_acl)->aces, (*the_acl)->num_aces * sizeof(struct
+       security_ace));
+       memcpy(aces+(*the_acl)->num_aces, ace, sizeof(struct security_ace));
+       new_ace = make_sec_acl(talloc_tos(),(*the_acl)->revision,1+(*the_acl)->num_aces, aces);
        SAFE_FREE(aces);
        (*the_acl) = new_ace;
        return True;
 }
 
 /* parse a ascii version of a security descriptor */
-static SEC_DESC *sec_desc_parse(char *str)
+static struct security_descriptor *sec_desc_parse(TALLOC_CTX *ctx, struct cli_state *cli, char *str)
 {
        const char *p = str;
-       fstring tok;
-       SEC_DESC *ret = NULL;
+       char *tok;
+       struct security_descriptor *ret = NULL;
        size_t sd_size;
-       DOM_SID *grp_sid=NULL, *owner_sid=NULL;
-       SEC_ACL *dacl=NULL;
+       struct dom_sid *grp_sid=NULL, *owner_sid=NULL;
+       struct security_acl *dacl=NULL;
        int revision=1;
 
-       while (next_token(&p, tok, "\t,\r\n", sizeof(tok))) {
-
+       while (next_token_talloc(ctx, &p, &tok, "\t,\r\n")) {
                if (strncmp(tok,"REVISION:", 9) == 0) {
                        revision = strtol(tok+9, NULL, 16);
                        continue;
@@ -396,9 +574,9 @@ static SEC_DESC *sec_desc_parse(char *str)
                                printf("Only specify owner once\n");
                                goto done;
                        }
-                       owner_sid = SMB_CALLOC_ARRAY(DOM_SID, 1);
+                       owner_sid = SMB_CALLOC_ARRAY(struct dom_sid, 1);
                        if (!owner_sid ||
-                           !StringToSid(owner_sid, tok+6)) {
+                           !StringToSid(cli, owner_sid, tok+6)) {
                                printf("Failed to parse owner sid\n");
                                goto done;
                        }
@@ -410,9 +588,9 @@ static SEC_DESC *sec_desc_parse(char *str)
                                printf("Only specify group once\n");
                                goto done;
                        }
-                       grp_sid = SMB_CALLOC_ARRAY(DOM_SID, 1);
+                       grp_sid = SMB_CALLOC_ARRAY(struct dom_sid, 1);
                        if (!grp_sid ||
-                           !StringToSid(grp_sid, tok+6)) {
+                           !StringToSid(cli, grp_sid, tok+6)) {
                                printf("Failed to parse group sid\n");
                                goto done;
                        }
@@ -420,8 +598,8 @@ static SEC_DESC *sec_desc_parse(char *str)
                }
 
                if (strncmp(tok,"ACL:", 4) == 0) {
-                       SEC_ACE ace;
-                       if (!parse_ace(&ace, tok+4)) {
+                       struct security_ace ace;
+                       if (!parse_ace(cli, &ace, tok+4)) {
                                goto done;
                        }
                        if(!add_ace(&dacl, &ace)) {
@@ -435,7 +613,7 @@ static SEC_DESC *sec_desc_parse(char *str)
                goto done;
        }
 
-       ret = make_sec_desc(ctx,revision, SEC_DESC_SELF_RELATIVE, owner_sid, grp_sid, 
+       ret = make_sec_desc(ctx,revision, SEC_DESC_SELF_RELATIVE, owner_sid, grp_sid,
                            NULL, dacl, &sd_size);
 
   done:
@@ -447,17 +625,18 @@ static SEC_DESC *sec_desc_parse(char *str)
 
 
 /* print a ascii version of a security descriptor on a FILE handle */
-static void sec_desc_print(FILE *f, SEC_DESC *sd)
+static void sec_desc_print(struct cli_state *cli, FILE *f, struct security_descriptor *sd)
 {
        fstring sidstr;
        uint32 i;
 
        fprintf(f, "REVISION:%d\n", sd->revision);
+       fprintf(f, "CONTROL:0x%x\n", sd->type);
 
        /* Print owner and group sid */
 
        if (sd->owner_sid) {
-               SidToString(sidstr, sd->owner_sid);
+               SidToString(cli, sidstr, sd->owner_sid);
        } else {
                fstrcpy(sidstr, "");
        }
@@ -465,7 +644,7 @@ static void sec_desc_print(FILE *f, SEC_DESC *sd)
        fprintf(f, "OWNER:%s\n", sidstr);
 
        if (sd->group_sid) {
-               SidToString(sidstr, sd->group_sid);
+               SidToString(cli, sidstr, sd->group_sid);
        } else {
                fstrcpy(sidstr, "");
        }
@@ -474,47 +653,124 @@ static void sec_desc_print(FILE *f, SEC_DESC *sd)
 
        /* Print aces */
        for (i = 0; sd->dacl && i < sd->dacl->num_aces; i++) {
-               SEC_ACE *ace = &sd->dacl->aces[i];
+               struct security_ace *ace = &sd->dacl->aces[i];
                fprintf(f, "ACL:");
-               print_ace(f, ace);
+               print_ace(cli, f, ace);
                fprintf(f, "\n");
        }
 
 }
 
-/***************************************************** 
-dump the acls for a file
+/*****************************************************
+get fileinfo for filename
 *******************************************************/
-static int cacl_dump(struct cli_state *cli, char *filename)
+static uint16 get_fileinfo(struct cli_state *cli, const char *filename)
 {
-       int result = EXIT_FAILED;
-       int fnum = -1;
-       SEC_DESC *sd;
+       uint16_t fnum = (uint16_t)-1;
+       uint16 mode;
 
-       if (test_args) 
-               return EXIT_OK;
+       /* The desired access below is the only one I could find that works
+          with NT4, W2KP and Samba */
+
+       if (!NT_STATUS_IS_OK(cli_ntcreate(cli, filename, 0, CREATE_ACCESS_READ,
+                                          0, FILE_SHARE_READ|FILE_SHARE_WRITE,
+                                          FILE_OPEN, 0x0, 0x0, &fnum))) {
+               printf("Failed to open %s: %s\n", filename, cli_errstr(cli));
+       }
+
+       if (!NT_STATUS_IS_OK(cli_qfileinfo_basic(
+                                    cli, fnum, &mode, NULL, NULL, NULL,
+                                    NULL, NULL, NULL))) {
+               printf("Failed to file info %s: %s\n", filename,
+                                                       cli_errstr(cli));
+        }
+
+       cli_close(cli, fnum);
+
+        return mode;
+}
+
+/*****************************************************
+get sec desc for filename
+*******************************************************/
+static struct security_descriptor *get_secdesc(struct cli_state *cli, const char *filename)
+{
+       uint16_t fnum = (uint16_t)-1;
+       struct security_descriptor *sd;
 
-       fnum = cli_nt_create(cli, filename, CREATE_ACCESS_READ);
+       /* The desired access below is the only one I could find that works
+          with NT4, W2KP and Samba */
 
-       if (fnum == -1) {
+       if (!NT_STATUS_IS_OK(cli_ntcreate(cli, filename, 0, CREATE_ACCESS_READ,
+                                          0, FILE_SHARE_READ|FILE_SHARE_WRITE,
+                                          FILE_OPEN, 0x0, 0x0, &fnum))) {
                printf("Failed to open %s: %s\n", filename, cli_errstr(cli));
-               goto done;
+               return NULL;
        }
 
-       sd = cli_query_secdesc(cli, fnum, ctx);
+       sd = cli_query_secdesc(cli, fnum, talloc_tos());
+
+       cli_close(cli, fnum);
 
        if (!sd) {
-               printf("ERROR: secdesc query failed: %s\n", cli_errstr(cli));
-               goto done;
+               printf("Failed to get security descriptor\n");
+               return NULL;
        }
+        return sd;
+}
 
-       sec_desc_print(stdout, sd);
+/*****************************************************
+set sec desc for filename
+*******************************************************/
+static bool set_secdesc(struct cli_state *cli, const char *filename,
+                        struct security_descriptor *sd)
+{
+       uint16_t fnum = (uint16_t)-1;
+        bool result=true;
 
-       result = EXIT_OK;
+       /* The desired access below is the only one I could find that works
+          with NT4, W2KP and Samba */
+
+       if (!NT_STATUS_IS_OK(cli_ntcreate(cli, filename, 0,
+                                          WRITE_DAC_ACCESS|WRITE_OWNER_ACCESS,
+                                          0, FILE_SHARE_READ|FILE_SHARE_WRITE,
+                                          FILE_OPEN, 0x0, 0x0, &fnum))) {
+               printf("Failed to open %s: %s\n", filename, cli_errstr(cli));
+               return false;
+       }
 
-done:
-       if (fnum != -1)
-               cli_close(cli, fnum);
+       if (!cli_set_secdesc(cli, fnum, sd)) {
+               printf("ERROR: security description set failed: %s\n",
+                       cli_errstr(cli));
+               result=false;
+       }
+
+       cli_close(cli, fnum);
+       return result;
+}
+
+/*****************************************************
+dump the acls for a file
+*******************************************************/
+static int cacl_dump(struct cli_state *cli, const char *filename)
+{
+       int result = EXIT_FAILED;
+       struct security_descriptor *sd;
+
+       if (test_args)
+               return EXIT_OK;
+
+       sd = get_secdesc(cli, filename);
+
+       if (sd) {
+               if (sddl) {
+                       printf("%s\n", sddl_encode(talloc_tos(), sd,
+                                          get_global_sam_sid()));
+               } else {
+                       sec_desc_print(cli, stdout, sd);
+               }
+               result = EXIT_OK;
+       }
 
        return result;
 }
@@ -525,88 +781,81 @@ because the NT docs say this can't be done :-). JRA.
 *******************************************************/
 
 static int owner_set(struct cli_state *cli, enum chown_mode change_mode, 
-                    char *filename, char *new_username)
+                       const char *filename, const char *new_username)
 {
-       int fnum;
-       DOM_SID sid;
-       SEC_DESC *sd, *old;
+       struct dom_sid sid;
+       struct security_descriptor *sd, *old;
        size_t sd_size;
 
-       fnum = cli_nt_create(cli, filename, CREATE_ACCESS_READ);
-
-       if (fnum == -1) {
-               printf("Failed to open %s: %s\n", filename, cli_errstr(cli));
-               return EXIT_FAILED;
-       }
-
-       if (!StringToSid(&sid, new_username))
+       if (!StringToSid(cli, &sid, new_username))
                return EXIT_PARSE_ERROR;
 
-       old = cli_query_secdesc(cli, fnum, ctx);
-
-       cli_close(cli, fnum);
+       old = get_secdesc(cli, filename);
 
        if (!old) {
-               printf("owner_set: Failed to query old descriptor\n");
                return EXIT_FAILED;
        }
 
-       sd = make_sec_desc(ctx,old->revision, old->type,
+       sd = make_sec_desc(talloc_tos(),old->revision, old->type,
                                (change_mode == REQUEST_CHOWN) ? &sid : NULL,
                                (change_mode == REQUEST_CHGRP) ? &sid : NULL,
                           NULL, NULL, &sd_size);
 
-       fnum = cli_nt_create(cli, filename, WRITE_OWNER_ACCESS);
-
-       if (fnum == -1) {
-               printf("Failed to open %s: %s\n", filename, cli_errstr(cli));
+       if (!set_secdesc(cli, filename, sd)) {
                return EXIT_FAILED;
        }
 
-       if (!cli_set_secdesc(cli, fnum, sd)) {
-               printf("ERROR: secdesc set failed: %s\n", cli_errstr(cli));
-       }
-
-       cli_close(cli, fnum);
-
        return EXIT_OK;
 }
 
 
-/* The MSDN is contradictory over the ordering of ACE entries in an ACL.
-   However NT4 gives a "The information may have been modified by a
-   computer running Windows NT 5.0" if denied ACEs do not appear before
-   allowed ACEs. */
+/* The MSDN is contradictory over the ordering of ACE entries in an
+   ACL.  However NT4 gives a "The information may have been modified
+   by a computer running Windows NT 5.0" if denied ACEs do not appear
+   before allowed ACEs. At
+   http://technet.microsoft.com/en-us/library/cc781716.aspx the
+   canonical order is specified as "Explicit Deny, Explicit Allow,
+   Inherited ACEs unchanged" */
 
-static int ace_compare(SEC_ACE *ace1, SEC_ACE *ace2)
+static int ace_compare(struct security_ace *ace1, struct security_ace *ace2)
 {
-       if (sec_ace_equal(ace1, ace2)) 
+       if (sec_ace_equal(ace1, ace2))
                return 0;
 
-       if (ace1->type != ace2->type) 
+       if ((ace1->flags & SEC_ACE_FLAG_INHERITED_ACE) &&
+                       !(ace2->flags & SEC_ACE_FLAG_INHERITED_ACE))
+               return 1;
+       if (!(ace1->flags & SEC_ACE_FLAG_INHERITED_ACE) &&
+                       (ace2->flags & SEC_ACE_FLAG_INHERITED_ACE))
+               return -1;
+       if ((ace1->flags & SEC_ACE_FLAG_INHERITED_ACE) &&
+                       (ace2->flags & SEC_ACE_FLAG_INHERITED_ACE))
+               return ace1 - ace2;
+
+       if (ace1->type != ace2->type)
                return ace2->type - ace1->type;
 
-       if (sid_compare(&ace1->trustee, &ace2->trustee)) 
-               return sid_compare(&ace1->trustee, &ace2->trustee);
+       if (dom_sid_compare(&ace1->trustee, &ace2->trustee))
+               return dom_sid_compare(&ace1->trustee, &ace2->trustee);
 
-       if (ace1->flags != ace2->flags) 
+       if (ace1->flags != ace2->flags)
                return ace1->flags - ace2->flags;
 
-       if (ace1->access_mask != ace2->access_mask) 
+       if (ace1->access_mask != ace2->access_mask)
                return ace1->access_mask - ace2->access_mask;
 
-       if (ace1->size != ace2->size) 
+       if (ace1->size != ace2->size)
                return ace1->size - ace2->size;
 
-       return memcmp(ace1, ace2, sizeof(SEC_ACE));
+       return memcmp(ace1, ace2, sizeof(struct security_ace));
 }
 
-static void sort_acl(SEC_ACL *the_acl)
+static void sort_acl(struct security_acl *the_acl)
 {
        uint32 i;
        if (!the_acl) return;
 
-       qsort(the_acl->aces, the_acl->num_aces, sizeof(the_acl->aces[0]), QSORT_CAST ace_compare);
+       TYPESAFE_QSORT(the_acl->aces, the_acl->num_aces, ace_compare);
 
        for (i=1;i<the_acl->num_aces;) {
                if (sec_ace_equal(&the_acl->aces[i-1], &the_acl->aces[i])) {
@@ -624,39 +873,30 @@ static void sort_acl(SEC_ACL *the_acl)
 /***************************************************** 
 set the ACLs on a file given an ascii description
 *******************************************************/
-static int cacl_set(struct cli_state *cli, char *filename, 
+
+static int cacl_set(struct cli_state *cli, const char *filename,
                    char *the_acl, enum acl_mode mode)
 {
-       int fnum;
-       SEC_DESC *sd, *old;
+       struct security_descriptor *sd, *old;
        uint32 i, j;
        size_t sd_size;
        int result = EXIT_OK;
 
-       sd = sec_desc_parse(the_acl);
+       if (sddl) {
+               sd = sddl_decode(talloc_tos(), the_acl, get_global_sam_sid());
+       } else {
+               sd = sec_desc_parse(talloc_tos(), cli, the_acl);
+       }
 
        if (!sd) return EXIT_PARSE_ERROR;
        if (test_args) return EXIT_OK;
 
-       /* The desired access below is the only one I could find that works
-          with NT4, W2KP and Samba */
-
-       fnum = cli_nt_create(cli, filename, CREATE_ACCESS_READ);
-
-       if (fnum == -1) {
-               printf("cacl_set failed to open %s: %s\n", filename, cli_errstr(cli));
-               return EXIT_FAILED;
-       }
-
-       old = cli_query_secdesc(cli, fnum, ctx);
+       old = get_secdesc(cli, filename);
 
        if (!old) {
-               printf("calc_set: Failed to query old descriptor\n");
                return EXIT_FAILED;
        }
 
-       cli_close(cli, fnum);
-
        /* the logic here is rather more complex than I would like */
        switch (mode) {
        case SMB_ACL_DELETE:
@@ -677,8 +917,8 @@ static int cacl_set(struct cli_state *cli, char *filename,
                        }
 
                        if (!found) {
-                               printf("ACL for ACE:"); 
-                               print_ace(stdout, &sd->dacl->aces[i]);
+                               printf("ACL for ACE:");
+                               print_ace(cli, stdout, &sd->dacl->aces[i]);
                                printf(" not found\n");
                        }
                }
@@ -689,7 +929,7 @@ static int cacl_set(struct cli_state *cli, char *filename,
                        bool found = False;
 
                        for (j=0;old->dacl && j<old->dacl->num_aces;j++) {
-                               if (sid_equal(&sd->dacl->aces[i].trustee,
+                               if (dom_sid_equal(&sd->dacl->aces[i].trustee,
                                              &old->dacl->aces[j].trustee)) {
                                        old->dacl->aces[j] = sd->dacl->aces[i];
                                        found = True;
@@ -699,7 +939,8 @@ static int cacl_set(struct cli_state *cli, char *filename,
                        if (!found) {
                                fstring str;
 
-                               SidToString(str, &sd->dacl->aces[i].trustee);
+                               SidToString(cli, str,
+                                           &sd->dacl->aces[i].trustee);
                                printf("ACL for SID %s not found\n", str);
                        }
                }
@@ -708,7 +949,7 @@ static int cacl_set(struct cli_state *cli, char *filename,
                        old->owner_sid = sd->owner_sid;
                }
 
-               if (sd->group_sid) { 
+               if (sd->group_sid) {
                        old->group_sid = sd->group_sid;
                }
 
@@ -737,58 +978,184 @@ static int cacl_set(struct cli_state *cli, char *filename,
           and W2K. JRA.
        */
 
-       sd = make_sec_desc(ctx,old->revision, old->type, old->owner_sid, old->group_sid,
+       sd = make_sec_desc(talloc_tos(),old->revision, old->type,
+                          old->owner_sid, old->group_sid,
                           NULL, old->dacl, &sd_size);
 
-       fnum = cli_nt_create(cli, filename, WRITE_DAC_ACCESS|WRITE_OWNER_ACCESS);
+       if (!set_secdesc(cli, filename, sd)) {
+               result = EXIT_FAILED;
+       }
+
+       return result;
+}
+
+/*****************************************************
+set the inherit on a file
+*******************************************************/
+static int inherit(struct cli_state *cli, const char *filename,
+                   const char *type)
+{
+       struct security_descriptor *old,*sd;
+       uint32 oldattr;
+       size_t sd_size;
+       int result = EXIT_OK;
 
-       if (fnum == -1) {
-               printf("cacl_set failed to open %s: %s\n", filename, cli_errstr(cli));
+       old = get_secdesc(cli, filename);
+
+       if (!old) {
                return EXIT_FAILED;
        }
 
-       if (!cli_set_secdesc(cli, fnum, sd)) {
-               printf("ERROR: secdesc set failed: %s\n", cli_errstr(cli));
-               result = EXIT_FAILED;
+        oldattr = get_fileinfo(cli,filename);
+
+       if (strcmp(type,"allow")==0) {
+               if ((old->type & SEC_DESC_DACL_PROTECTED) ==
+                    SEC_DESC_DACL_PROTECTED) {
+                       int i;
+                       char *parentname,*temp;
+                       struct security_descriptor *parent;
+                       temp = talloc_strdup(talloc_tos(), filename);
+
+                       old->type=old->type & (~SEC_DESC_DACL_PROTECTED);
+
+                       /* look at parent and copy in all its inheritable ACL's. */
+                       string_replace(temp, '\\', '/');
+                       if (!parent_dirname(talloc_tos(),temp,&parentname,NULL)) {
+                               return EXIT_FAILED;
+                       }
+                       string_replace(parentname, '/', '\\');
+                       parent = get_secdesc(cli,parentname);
+                       for (i=0;i<parent->dacl->num_aces;i++) {
+                               struct security_ace *ace=&parent->dacl->aces[i];
+                               /* Add inherited flag to all aces */
+                               ace->flags=ace->flags|
+                                          SEC_ACE_FLAG_INHERITED_ACE;
+                               if ((oldattr & aDIR) == aDIR) {
+                                       if ((ace->flags & SEC_ACE_FLAG_CONTAINER_INHERIT) ==
+                                           SEC_ACE_FLAG_CONTAINER_INHERIT) {
+                                               add_ace(&old->dacl, ace);
+                                       }
+                               } else {
+                                       if ((ace->flags & SEC_ACE_FLAG_OBJECT_INHERIT) ==
+                                           SEC_ACE_FLAG_OBJECT_INHERIT) {
+                                               /* clear flags for files */
+                                               ace->flags=0;
+                                               add_ace(&old->dacl, ace);
+                                       }
+                               }
+                       }
+                } else {
+                       printf("Already set to inheritable permissions.\n");
+                       return EXIT_FAILED;
+                }
+       } else if (strcmp(type,"remove")==0) {
+               if ((old->type & SEC_DESC_DACL_PROTECTED) !=
+                    SEC_DESC_DACL_PROTECTED) {
+                       old->type=old->type | SEC_DESC_DACL_PROTECTED;
+
+                       /* remove all inherited ACL's. */
+                       if (old->dacl) {
+                               int i;
+                               struct security_acl *temp=old->dacl;
+                               old->dacl=make_sec_acl(talloc_tos(), 3, 0, NULL);
+                               for (i=temp->num_aces-1;i>=0;i--) {
+                                       struct security_ace *ace=&temp->aces[i];
+                                       /* Remove all ace with INHERITED flag set */
+                                       if ((ace->flags & SEC_ACE_FLAG_INHERITED_ACE) !=
+                                           SEC_ACE_FLAG_INHERITED_ACE) {
+                                               add_ace(&old->dacl,ace);
+                                       }
+                               }
+                       }
+                } else {
+                       printf("Already set to no inheritable permissions.\n");
+                       return EXIT_FAILED;
+                }
+       } else if (strcmp(type,"copy")==0) {
+               if ((old->type & SEC_DESC_DACL_PROTECTED) !=
+                    SEC_DESC_DACL_PROTECTED) {
+                       old->type=old->type | SEC_DESC_DACL_PROTECTED;
+
+                       /* convert all inherited ACL's to non inherated ACL's. */
+                       if (old->dacl) {
+                               int i;
+                               for (i=0;i<old->dacl->num_aces;i++) {
+                                       struct security_ace *ace=&old->dacl->aces[i];
+                                       /* Remove INHERITED FLAG from all aces */
+                                       ace->flags=ace->flags&(~SEC_ACE_FLAG_INHERITED_ACE);
+                               }
+                       }
+                } else {
+                       printf("Already set to no inheritable permissions.\n");
+                       return EXIT_FAILED;
+                }
        }
 
-       /* Clean up */
+       /* Denied ACE entries must come before allowed ones */
+       sort_acl(old->dacl);
 
-       cli_close(cli, fnum);
+       sd = make_sec_desc(talloc_tos(),old->revision, old->type,
+                          old->owner_sid, old->group_sid,
+                          NULL, old->dacl, &sd_size);
+
+       if (!set_secdesc(cli, filename, sd)) {
+               result = EXIT_FAILED;
+       }
 
        return result;
 }
 
-
-/***************************************************** 
-return a connection to a server
+/*****************************************************
+ Return a connection to a server.
 *******************************************************/
-static struct cli_state *connect_one(const char *share)
+static struct cli_state *connect_one(struct user_auth_info *auth_info,
+                                    const char *server, const char *share)
 {
-       struct cli_state *c;
-       struct in_addr ip;
+       struct cli_state *c = NULL;
+       struct sockaddr_storage ss;
        NTSTATUS nt_status;
-       zero_ip_v4(&ip);
-       
-       if (!cmdline_auth_info.got_pass) {
-               char *pass = getpass("Password: ");
-               if (pass) {
-                       pstrcpy(cmdline_auth_info.password, pass);
-                       cmdline_auth_info.got_pass = True;
-               }
+       uint32_t flags = 0;
+
+       zero_sockaddr(&ss);
+
+       if (get_cmdline_auth_info_use_kerberos(auth_info)) {
+               flags |= CLI_FULL_CONNECTION_USE_KERBEROS |
+                        CLI_FULL_CONNECTION_FALLBACK_AFTER_KERBEROS;
        }
 
-       if (NT_STATUS_IS_OK(nt_status = cli_full_connection(&c, global_myname(), server, 
-                                                           &ip, 0,
-                                                           share, "?????",  
-                                                           cmdline_auth_info.username, lp_workgroup(),
-                                                           cmdline_auth_info.password, 0,
-                                                           cmdline_auth_info.signing_state, NULL))) {
-               return c;
-       } else {
+       if (get_cmdline_auth_info_use_machine_account(auth_info) &&
+           !set_cmdline_auth_info_machine_account_creds(auth_info)) {
+               return NULL;
+       }
+
+       set_cmdline_auth_info_getpass(auth_info);
+
+       nt_status = cli_full_connection(&c, global_myname(), server, 
+                               &ss, 0,
+                               share, "?????",
+                               get_cmdline_auth_info_username(auth_info),
+                               lp_workgroup(),
+                               get_cmdline_auth_info_password(auth_info),
+                               flags,
+                               get_cmdline_auth_info_signing_state(auth_info));
+       if (!NT_STATUS_IS_OK(nt_status)) {
                DEBUG(0,("cli_full_connection failed! (%s)\n", nt_errstr(nt_status)));
                return NULL;
        }
+
+       if (get_cmdline_auth_info_smb_encrypt(auth_info)) {
+               nt_status = cli_cm_force_encryption(c,
+                                       get_cmdline_auth_info_username(auth_info),
+                                       get_cmdline_auth_info_password(auth_info),
+                                       lp_workgroup(),
+                                       share);
+                if (!NT_STATUS_IS_OK(nt_status)) {
+                       cli_shutdown(c);
+                       c = NULL;
+                }
+       }
+
+       return c;
 }
 
 /****************************************************************************
@@ -802,8 +1169,8 @@ static struct cli_state *connect_one(const char *share)
        static char *the_acl = NULL;
        enum chown_mode change_mode = REQUEST_NONE;
        int result;
-       fstring path;
-       pstring filename;
+       char *path;
+       char *filename = NULL;
        poptContext pc;
        struct poptOption long_options[] = {
                POPT_AUTOHELP
@@ -813,32 +1180,41 @@ static struct cli_state *connect_one(const char *share)
                { "set", 'S', POPT_ARG_STRING, NULL, 'S', "Set acls", "ACLS" },
                { "chown", 'C', POPT_ARG_STRING, NULL, 'C', "Change ownership of a file", "USERNAME" },
                { "chgrp", 'G', POPT_ARG_STRING, NULL, 'G', "Change group ownership of a file", "GROUPNAME" },
-               { "numeric", 0, POPT_ARG_NONE, &numeric, True, "Don't resolve sids or masks to names" },
-               { "test-args", 't', POPT_ARG_NONE, &test_args, True, "Test arguments"},
+               { "inherit", 'I', POPT_ARG_STRING, NULL, 'I', "Inherit allow|remove|copy" },
+               { "numeric", 0, POPT_ARG_NONE, &numeric, 1, "Don't resolve sids or masks to names" },
+               { "sddl", 0, POPT_ARG_NONE, &sddl, 1, "Output and input acls in sddl format" },
+               { "test-args", 't', POPT_ARG_NONE, &test_args, 1, "Test arguments"},
                POPT_COMMON_SAMBA
+               POPT_COMMON_CONNECTION
                POPT_COMMON_CREDENTIALS
-               { NULL }
+               POPT_TABLEEND
        };
 
        struct cli_state *cli;
+       TALLOC_CTX *frame = talloc_stackframe();
+       const char *owner_username = "";
+       char *server;
+       struct user_auth_info *auth_info;
 
        load_case_tables();
 
-       ctx=talloc_stackframe();
-
        /* set default debug level to 1 regardless of what smb.conf sets */
-       setup_logging( "smbcacls", True );
-       DEBUGLEVEL_CLASS[DBGC_ALL] = 1;
-       dbf = x_stderr;
-       x_setbuf( x_stderr, NULL );
+       setup_logging( "smbcacls", DEBUG_STDERR);
+       lp_set_cmdline("log level", "1");
 
        setlinebuf(stdout);
 
-       lp_load(dyn_CONFIGFILE,True,False,False,True);
+       lp_load(get_dyn_CONFIGFILE(),True,False,False,True);
        load_interfaces();
 
+       auth_info = user_auth_info_init(frame);
+       if (auth_info == NULL) {
+               exit(1);
+       }
+       popt_common_set_auth_info(auth_info);
+
        pc = poptGetContext("smbcacls", argc, argv, long_options, 0);
-       
+
        poptSetOtherOptionHelp(pc, "//server1/share1 filename\nACLs look like: "
                "'ACL:user:[ALLOWED|DENIED]/flags/permissions'");
 
@@ -865,35 +1241,49 @@ static struct cli_state *connect_one(const char *share)
                        break;
 
                case 'C':
-                       pstrcpy(owner_username,poptGetOptArg(pc));
+                       owner_username = poptGetOptArg(pc);
                        change_mode = REQUEST_CHOWN;
                        break;
 
                case 'G':
-                       pstrcpy(owner_username,poptGetOptArg(pc));
+                       owner_username = poptGetOptArg(pc);
                        change_mode = REQUEST_CHGRP;
                        break;
+
+               case 'I':
+                       owner_username = poptGetOptArg(pc);
+                       change_mode = REQUEST_INHERIT;
+                       break;
                }
        }
 
        /* Make connection to server */
-       if(!poptPeekArg(pc)) { 
+       if(!poptPeekArg(pc)) {
                poptPrintUsage(pc, stderr, 0);
                return -1;
        }
-       
-       fstrcpy(path, poptGetArg(pc));
-       
-       if(!poptPeekArg(pc)) { 
-               poptPrintUsage(pc, stderr, 0);  
+
+       path = talloc_strdup(frame, poptGetArg(pc));
+       if (!path) {
                return -1;
        }
-       
-       pstrcpy(filename, poptGetArg(pc));
 
-       all_string_sub(path,"/","\\",0);
+       if(!poptPeekArg(pc)) {
+               poptPrintUsage(pc, stderr, 0);
+               return -1;
+       }
 
-       fstrcpy(server,path+2);
+       filename = talloc_strdup(frame, poptGetArg(pc));
+       if (!filename) {
+               return -1;
+       }
+
+       string_replace(path,'/','\\');
+
+       server = talloc_strdup(frame, path+2);
+       if (!server) {
+               return -1;
+       }
        share = strchr_m(server,'\\');
        if (!share) {
                printf("Invalid argument: %s\n", share);
@@ -904,26 +1294,29 @@ static struct cli_state *connect_one(const char *share)
        share++;
 
        if (!test_args) {
-               cli = connect_one(share);
+               cli = connect_one(auth_info, server, share);
                if (!cli) {
-                       talloc_destroy(ctx);
                        exit(EXIT_FAILED);
                }
        } else {
                exit(0);
        }
 
-       all_string_sub(filename, "/", "\\", 0);
+       string_replace(filename, '/', '\\');
        if (filename[0] != '\\') {
-               pstring s;
-               s[0] = '\\';
-               safe_strcpy(&s[1], filename, sizeof(pstring)-2);
-               pstrcpy(filename, s);
+               filename = talloc_asprintf(frame,
+                               "\\%s",
+                               filename);
+               if (!filename) {
+                       return -1;
+               }
        }
 
        /* Perform requested action */
 
-       if (change_mode != REQUEST_NONE) {
+       if (change_mode == REQUEST_INHERIT) {
+               result = inherit(cli, filename, owner_username);
+       } else if (change_mode != REQUEST_NONE) {
                result = owner_set(cli, change_mode, filename, owner_username);
        } else if (the_acl) {
                result = cacl_set(cli, filename, the_acl, mode);
@@ -931,7 +1324,7 @@ static struct cli_state *connect_one(const char *share)
                result = cacl_dump(cli, filename);
        }
 
-       talloc_destroy(ctx);
+       TALLOC_FREE(frame);
 
        return result;
 }