s3-talloc Change TALLOC_ZERO_P() to talloc_zero()

[nivanova/samba-autobuild/.git] / source3 / smbd / message.c

diff --git a/source3/smbd/message.c b/source3/smbd/message.c
index a870f03df98c945add02c81ba3b13b15292e3adb..63b08e126203148718bd3552f9a82b797ba26566 100644 (file)
--- a/source3/smbd/message.c
+++ b/source3/smbd/message.c
@@ -23,6 +23,9 @@
 
 
 #include "includes.h"
+#include "smbd/smbd.h"
+#include "smbd/globals.h"
+#include "smbprofile.h"
 
 extern userdom_struct current_user_info;
 
@@ -32,8 +35,6 @@ struct msg_state {
        char *msg;
 };
 
-static struct msg_state *smbd_msg_state;
-
 /****************************************************************************
  Deliver the message.
 ****************************************************************************/
@@ -45,7 +46,7 @@ static void msg_deliver(struct msg_state *state)
        int i;
        int fd;
        char *msg;
-       int len;
+       size_t len;
        ssize_t sz;
        fstring alpha_buf;
        char *s;
@@ -60,7 +61,7 @@ static void msg_deliver(struct msg_state *state)
        if (!name) {
                goto done;
        }
-       fd = smb_mkstemp(name);
+       fd = mkstemp(name);
 
        if (fd == -1) {
                DEBUG(1, ("can't open message file %s: %s\n", name,
@@ -72,18 +73,17 @@ static void msg_deliver(struct msg_state *state)
         * Incoming message is in DOS codepage format. Convert to UNIX.
         */
 
-       len = convert_string_talloc(
-               talloc_tos(), CH_DOS, CH_UNIX, state->msg,
-               talloc_get_size(state->msg), (void *)&msg, true);
-
-       if (len == -1) {
+       if (!convert_string_talloc(talloc_tos(), CH_DOS, CH_UNIX, state->msg,
+                                  talloc_get_size(state->msg), (void *)&msg,
+                                  &len)) {
                DEBUG(3, ("Conversion failed, delivering message in DOS "
                          "codepage format\n"));
                msg = state->msg;
        }
 
        for (i = 0; i < len; i++) {
-               if ((msg[i] == '\r') && (i < (len-1)) && (msg[i+1] == '\n')) {
+               if ((msg[i] == '\r') &&
+                   (i < (len-1)) && (msg[i+1] == '\n')) {
                        continue;
                }
                sz = write(fd, &msg[i], 1);
@@ -141,31 +141,29 @@ void reply_sends(struct smb_request *req)
 {
        struct msg_state *state;
        int len;
-       char *msg;
-       char *p;
+       const char *msg;
+       const char *p;
 
        START_PROFILE(SMBsends);
 
        if (!(*lp_msg_command())) {
-               reply_doserror(req, ERRSRV, ERRmsgoff);
+               reply_nterror(req, NT_STATUS_REQUEST_NOT_ACCEPTED);
                END_PROFILE(SMBsends);
                return;
        }
 
        state = talloc(talloc_tos(), struct msg_state);
 
-       p = smb_buf(req->inbuf)+1;
-       p += srvstr_pull_buf_talloc(
-               state, (char *)req->inbuf, req->flags2, &state->from, p,
-               STR_ASCII|STR_TERMINATE) + 1;
-       p += srvstr_pull_buf_talloc(
-               state, (char *)req->inbuf, req->flags2, &state->to, p,
-               STR_ASCII|STR_TERMINATE) + 1;
+       p = (const char *)req->buf + 1;
+       p += srvstr_pull_req_talloc(
+               state, req, &state->from, p, STR_ASCII|STR_TERMINATE) + 1;
+       p += srvstr_pull_req_talloc(
+               state, req, &state->to, p, STR_ASCII|STR_TERMINATE) + 1;
 
        msg = p;
 
        len = SVAL(msg,0);
-       len = MIN(len, smb_bufrem(req->inbuf, msg+2));
+       len = MIN(len, smbreq_bufrem(req, msg+2));
 
        state->msg = talloc_array(state, char, len);
 
@@ -192,19 +190,19 @@ void reply_sends(struct smb_request *req)
 
 void reply_sendstrt(struct smb_request *req)
 {
-       char *p;
+       const char *p;
 
        START_PROFILE(SMBsendstrt);
 
        if (!(*lp_msg_command())) {
-               reply_doserror(req, ERRSRV, ERRmsgoff);
+               reply_nterror(req, NT_STATUS_REQUEST_NOT_ACCEPTED);
                END_PROFILE(SMBsendstrt);
                return;
        }
 
        TALLOC_FREE(smbd_msg_state);
 
-       smbd_msg_state = TALLOC_ZERO_P(NULL, struct msg_state);
+       smbd_msg_state = talloc_zero(NULL, struct msg_state);
 
        if (smbd_msg_state == NULL) {
                reply_nterror(req, NT_STATUS_NO_MEMORY);
@@ -212,13 +210,13 @@ void reply_sendstrt(struct smb_request *req)
                return;
        }
 
-       p = smb_buf(req->inbuf)+1;
-       p += srvstr_pull_buf_talloc(
-               smbd_msg_state, (char *)req->inbuf, req->flags2,
-               &smbd_msg_state->from, p, STR_ASCII|STR_TERMINATE) + 1;
-       p += srvstr_pull_buf_talloc(
-               smbd_msg_state, (char *)req->inbuf, req->flags2,
-               &smbd_msg_state->to, p, STR_ASCII|STR_TERMINATE) + 1;
+       p = (const char *)req->buf+1;
+       p += srvstr_pull_req_talloc(
+               smbd_msg_state, req, &smbd_msg_state->from, p,
+               STR_ASCII|STR_TERMINATE) + 1;
+       p += srvstr_pull_req_talloc(
+               smbd_msg_state, req, &smbd_msg_state->to, p,
+               STR_ASCII|STR_TERMINATE) + 1;
 
        DEBUG( 3, ( "SMBsendstrt (from %s to %s)\n", smbd_msg_state->from,
                    smbd_msg_state->to ) );
@@ -237,31 +235,31 @@ void reply_sendstrt(struct smb_request *req)
 void reply_sendtxt(struct smb_request *req)
 {
        int len;
-       char *msg;
+       const char *msg;
        char *tmp;
        size_t old_len;
 
        START_PROFILE(SMBsendtxt);
 
        if (! (*lp_msg_command())) {
-               reply_doserror(req, ERRSRV, ERRmsgoff);
+               reply_nterror(req, NT_STATUS_REQUEST_NOT_ACCEPTED);
                END_PROFILE(SMBsendtxt);
                return;
        }
 
-       if (smbd_msg_state == NULL) {
+       if ((smbd_msg_state == NULL) || (req->buflen < 3)) {
                reply_nterror(req, NT_STATUS_INVALID_PARAMETER);
                END_PROFILE(SMBsendtxt);
                return;
        }
 
-       msg = smb_buf(req->inbuf) + 1;
+       msg = (const char *)req->buf + 1;
 
        old_len = talloc_get_size(smbd_msg_state->msg);
 
-       len = MIN(SVAL(msg, 0), smb_bufrem(req->inbuf, msg+2));
+       len = MIN(SVAL(msg, 0), smbreq_bufrem(req, msg+2));
 
-       tmp = TALLOC_REALLOC_ARRAY(smbd_msg_state, smbd_msg_state->msg,
+       tmp = talloc_realloc(smbd_msg_state, smbd_msg_state->msg,
                                   char, old_len + len);
 
        if (tmp == NULL) {
@@ -292,7 +290,7 @@ void reply_sendend(struct smb_request *req)
        START_PROFILE(SMBsendend);
 
        if (! (*lp_msg_command())) {
-               reply_doserror(req, ERRSRV, ERRmsgoff);
+               reply_nterror(req, NT_STATUS_REQUEST_NOT_ACCEPTED);
                END_PROFILE(SMBsendend);
                return;
        }