s3-secrets: only include secrets.h when needed.
[nivanova/samba-autobuild/.git] / source3 / rpc_server / srv_lsa_nt.c
index 0e9d12124217112162ae344e3c5e63bad3c1329b..68fc2b18f38f5debca425e2581e44d897975760c 100644 (file)
 /* This is the implementation of the lsa server code. */
 
 #include "includes.h"
+#include "../librpc/gen_ndr/srv_lsa.h"
+#include "secrets.h"
 
 #undef DBGC_CLASS
 #define DBGC_CLASS DBGC_RPC_SRV
 
+#define MAX_LOOKUP_SIDS 0x5000 /* 20480 */
+
 extern PRIVS privs[];
 
+enum lsa_handle_type { LSA_HANDLE_POLICY_TYPE = 1, LSA_HANDLE_ACCOUNT_TYPE };
+
 struct lsa_info {
-       DOM_SID sid;
+       struct dom_sid sid;
+       const char *name;
        uint32 access;
+       enum lsa_handle_type type;
+       struct security_descriptor *sd;
 };
 
-const struct generic_mapping lsa_generic_mapping = {
+const struct generic_mapping lsa_account_mapping = {
+       LSA_ACCOUNT_READ,
+       LSA_ACCOUNT_WRITE,
+       LSA_ACCOUNT_EXECUTE,
+       LSA_ACCOUNT_ALL_ACCESS
+};
+
+const struct generic_mapping lsa_policy_mapping = {
        LSA_POLICY_READ,
        LSA_POLICY_WRITE,
        LSA_POLICY_EXECUTE,
        LSA_POLICY_ALL_ACCESS
 };
 
+const struct generic_mapping lsa_secret_mapping = {
+       LSA_SECRET_READ,
+       LSA_SECRET_WRITE,
+       LSA_SECRET_EXECUTE,
+       LSA_SECRET_ALL_ACCESS
+};
+
+const struct generic_mapping lsa_trusted_domain_mapping = {
+       LSA_TRUSTED_DOMAIN_READ,
+       LSA_TRUSTED_DOMAIN_WRITE,
+       LSA_TRUSTED_DOMAIN_EXECUTE,
+       LSA_TRUSTED_DOMAIN_ALL_ACCESS
+};
+
 /***************************************************************************
  init_lsa_ref_domain_list - adds a domain if it's not already in, returns the index.
 ***************************************************************************/
@@ -54,7 +84,7 @@ const struct generic_mapping lsa_generic_mapping = {
 static int init_lsa_ref_domain_list(TALLOC_CTX *mem_ctx,
                                    struct lsa_RefDomainList *ref,
                                    const char *dom_name,
-                                   DOM_SID *dom_sid)
+                                   struct dom_sid *dom_sid)
 {
        int num = 0;
 
@@ -68,13 +98,13 @@ static int init_lsa_ref_domain_list(TALLOC_CTX *mem_ctx,
                num = ref->count;
        }
 
-       if (num >= MAX_REF_DOMAINS) {
+       if (num >= LSA_REF_DOMAIN_LIST_MULTIPLIER) {
                /* index not found, already at maximum domain limit */
                return -1;
        }
 
        ref->count = num + 1;
-       ref->max_size = MAX_REF_DOMAINS;
+       ref->max_size = LSA_REF_DOMAIN_LIST_MULTIPLIER;
 
        ref->domains = TALLOC_REALLOC_ARRAY(mem_ctx, ref->domains,
                                            struct lsa_DomainInfo, ref->count);
@@ -94,24 +124,13 @@ static int init_lsa_ref_domain_list(TALLOC_CTX *mem_ctx,
 }
 
 
-/*******************************************************************
- Function to free the per handle data.
- ********************************************************************/
-
-static void free_lsa_info(void *ptr)
-{
-       struct lsa_info *lsa = (struct lsa_info *)ptr;
-
-       SAFE_FREE(lsa);
-}
-
 /***************************************************************************
  initialize a lsa_DomainInfo structure.
  ***************************************************************************/
 
 static void init_dom_query_3(struct lsa_DomainInfo *r,
                             const char *name,
-                            DOM_SID *sid)
+                            struct dom_sid *sid)
 {
        init_lsa_StringLarge(&r->name, name);
        r->sid = sid;
@@ -123,7 +142,7 @@ static void init_dom_query_3(struct lsa_DomainInfo *r,
 
 static void init_dom_query_5(struct lsa_DomainInfo *r,
                             const char *name,
-                            DOM_SID *sid)
+                            struct dom_sid *sid)
 {
        init_lsa_StringLarge(&r->name, name);
        r->sid = sid;
@@ -149,7 +168,7 @@ static NTSTATUS lookup_lsa_rids(TALLOC_CTX *mem_ctx,
        *pmapped_count = 0;
 
        for (i = 0; i < num_entries; i++) {
-               DOM_SID sid;
+               struct dom_sid sid;
                uint32 rid;
                int dom_idx;
                const char *full_name;
@@ -158,9 +177,13 @@ static NTSTATUS lookup_lsa_rids(TALLOC_CTX *mem_ctx,
 
                /* Split name into domain and user component */
 
-               full_name = name[i].string;
-               if (full_name == NULL) {
-                       return NT_STATUS_NO_MEMORY;
+               /* follow w2k8 behavior and return the builtin domain when no
+                * input has been passed in */
+
+               if (name[i].string) {
+                       full_name = name[i].string;
+               } else {
+                       full_name = "BUILTIN";
                }
 
                DEBUG(5, ("lookup_lsa_rids: looking up name %s\n", full_name));
@@ -191,12 +214,18 @@ static NTSTATUS lookup_lsa_rids(TALLOC_CTX *mem_ctx,
                dom_idx = -1;
 
                if (type != SID_NAME_UNKNOWN) {
-                       sid_split_rid(&sid, &rid);
+                       if (type == SID_NAME_DOMAIN) {
+                               rid = (uint32_t)-1;
+                       } else {
+                               sid_split_rid(&sid, &rid);
+                       }
                        dom_idx = init_lsa_ref_domain_list(mem_ctx, ref, domain, &sid);
                        mapped_count++;
                }
 
-               init_lsa_translated_sid(&prid[i], type, rid, dom_idx);
+               prid[i].sid_type        = type;
+               prid[i].rid             = rid;
+               prid[i].sid_index       = dom_idx;
        }
 
        *pmapped_count = mapped_count;
@@ -223,7 +252,7 @@ static NTSTATUS lookup_lsa_sids(TALLOC_CTX *mem_ctx,
        *pmapped_count = 0;
 
        for (i = 0; i < num_entries; i++) {
-               DOM_SID sid;
+               struct dom_sid sid;
                uint32 rid;
                int dom_idx;
                const char *full_name;
@@ -267,7 +296,7 @@ static NTSTATUS lookup_lsa_sids(TALLOC_CTX *mem_ctx,
                dom_idx = -1;
 
                if (type != SID_NAME_UNKNOWN) {
-                       DOM_SID domain_sid;
+                       struct dom_sid domain_sid;
                        sid_copy(&domain_sid, &sid);
                        sid_split_rid(&domain_sid, &rid);
                        dom_idx = init_lsa_ref_domain_list(mem_ctx, ref, domain, &domain_sid);
@@ -284,26 +313,41 @@ static NTSTATUS lookup_lsa_sids(TALLOC_CTX *mem_ctx,
        return NT_STATUS_OK;
 }
 
-static NTSTATUS lsa_get_generic_sd(TALLOC_CTX *mem_ctx, SEC_DESC **sd, size_t *sd_size)
+static NTSTATUS make_lsa_object_sd(TALLOC_CTX *mem_ctx, struct security_descriptor **sd, size_t *sd_size,
+                                       const struct generic_mapping *map,
+                                       struct dom_sid *sid, uint32_t sid_access)
 {
-       DOM_SID local_adm_sid;
-       DOM_SID adm_sid;
+       struct dom_sid adm_sid;
+       struct security_ace ace[5];
+       size_t i = 0;
 
-       SEC_ACE ace[3];
+       struct security_acl *psa = NULL;
 
-       SEC_ACL *psa = NULL;
+       /* READ|EXECUTE access for Everyone */
 
-       init_sec_ace(&ace[0], &global_sid_World, SEC_ACE_TYPE_ACCESS_ALLOWED, LSA_POLICY_EXECUTE, 0);
+       init_sec_ace(&ace[i++], &global_sid_World, SEC_ACE_TYPE_ACCESS_ALLOWED,
+                       map->generic_execute | map->generic_read, 0);
 
-       sid_copy(&adm_sid, get_global_sam_sid());
-       sid_append_rid(&adm_sid, DOMAIN_GROUP_RID_ADMINS);
-       init_sec_ace(&ace[1], &adm_sid, SEC_ACE_TYPE_ACCESS_ALLOWED, LSA_POLICY_ALL_ACCESS, 0);
+       /* Add Full Access 'BUILTIN\Administrators' and 'BUILTIN\Account Operators */
 
-       sid_copy(&local_adm_sid, &global_sid_Builtin);
-       sid_append_rid(&local_adm_sid, BUILTIN_ALIAS_RID_ADMINS);
-       init_sec_ace(&ace[2], &local_adm_sid, SEC_ACE_TYPE_ACCESS_ALLOWED, LSA_POLICY_ALL_ACCESS, 0);
+       init_sec_ace(&ace[i++], &global_sid_Builtin_Administrators,
+                       SEC_ACE_TYPE_ACCESS_ALLOWED, map->generic_all, 0);
+       init_sec_ace(&ace[i++], &global_sid_Builtin_Account_Operators,
+                       SEC_ACE_TYPE_ACCESS_ALLOWED, map->generic_all, 0);
 
-       if((psa = make_sec_acl(mem_ctx, NT4_ACL_REVISION, 3, ace)) == NULL)
+       /* Add Full Access for Domain Admins */
+       sid_compose(&adm_sid, get_global_sam_sid(), DOMAIN_RID_ADMINS);
+       init_sec_ace(&ace[i++], &adm_sid, SEC_ACE_TYPE_ACCESS_ALLOWED,
+                       map->generic_all, 0);
+
+       /* If we have a sid, give it some special access */
+
+       if (sid) {
+               init_sec_ace(&ace[i++], sid, SEC_ACE_TYPE_ACCESS_ALLOWED,
+                       sid_access, 0);
+       }
+
+       if((psa = make_sec_acl(mem_ctx, NT4_ACL_REVISION, i, ace)) == NULL)
                return NT_STATUS_NO_MEMORY;
 
        if((*sd = make_sec_desc(mem_ctx, SECURITY_DESCRIPTOR_REVISION_1,
@@ -314,95 +358,55 @@ static NTSTATUS lsa_get_generic_sd(TALLOC_CTX *mem_ctx, SEC_DESC **sd, size_t *s
        return NT_STATUS_OK;
 }
 
-#if 0  /* AD DC work in ongoing in Samba 4 */
-
-/***************************************************************************
- Init_dns_dom_info.
-***************************************************************************/
-
-static void init_dns_dom_info(LSA_DNS_DOM_INFO *r_l, const char *nb_name,
-                             const char *dns_name, const char *forest_name,
-                             struct GUID *dom_guid, DOM_SID *dom_sid)
-{
-       if (nb_name && *nb_name) {
-               init_unistr2(&r_l->uni_nb_dom_name, nb_name, UNI_FLAGS_NONE);
-               init_uni_hdr(&r_l->hdr_nb_dom_name, &r_l->uni_nb_dom_name);
-               r_l->hdr_nb_dom_name.uni_max_len += 2;
-               r_l->uni_nb_dom_name.uni_max_len += 1;
-       }
-
-       if (dns_name && *dns_name) {
-               init_unistr2(&r_l->uni_dns_dom_name, dns_name, UNI_FLAGS_NONE);
-               init_uni_hdr(&r_l->hdr_dns_dom_name, &r_l->uni_dns_dom_name);
-               r_l->hdr_dns_dom_name.uni_max_len += 2;
-               r_l->uni_dns_dom_name.uni_max_len += 1;
-       }
-
-       if (forest_name && *forest_name) {
-               init_unistr2(&r_l->uni_forest_name, forest_name, UNI_FLAGS_NONE);
-               init_uni_hdr(&r_l->hdr_forest_name, &r_l->uni_forest_name);
-               r_l->hdr_forest_name.uni_max_len += 2;
-               r_l->uni_forest_name.uni_max_len += 1;
-       }
-
-       /* how do we init the guid ? probably should write an init fn */
-       if (dom_guid) {
-               memcpy(&r_l->dom_guid, dom_guid, sizeof(struct GUID));
-       }
-
-       if (dom_sid) {
-               r_l->ptr_dom_sid = 1;
-               init_dom_sid2(&r_l->dom_sid, dom_sid);
-       }
-}
-#endif /* AD DC work in ongoing in Samba 4 */
-
 
 /***************************************************************************
  _lsa_OpenPolicy2
  ***************************************************************************/
 
-NTSTATUS _lsa_OpenPolicy2(pipes_struct *p,
+NTSTATUS _lsa_OpenPolicy2(struct pipes_struct *p,
                          struct lsa_OpenPolicy2 *r)
 {
        struct lsa_info *info;
-       SEC_DESC *psd = NULL;
+       struct security_descriptor *psd = NULL;
        size_t sd_size;
        uint32 des_access = r->in.access_mask;
        uint32 acc_granted;
        NTSTATUS status;
 
+       /* Work out max allowed. */
+       map_max_allowed_access(p->server_info->ptok,
+                              &p->server_info->utok,
+                              &des_access);
 
        /* map the generic bits to the lsa policy ones */
-       se_map_generic(&des_access, &lsa_generic_mapping);
+       se_map_generic(&des_access, &lsa_policy_mapping);
 
        /* get the generic lsa policy SD until we store it */
-       lsa_get_generic_sd(p->mem_ctx, &psd, &sd_size);
-
-       if(!se_access_check(psd, p->pipe_user.nt_user_token, des_access, &acc_granted, &status)) {
-               if (p->pipe_user.ut.uid != sec_initial_uid()) {
-                       return status;
-               }
-               DEBUG(4,("ACCESS should be DENIED (granted: %#010x;  required: %#010x)\n",
-                        acc_granted, des_access));
-               DEBUGADD(4,("but overwritten by euid == 0\n"));
+       status = make_lsa_object_sd(p->mem_ctx, &psd, &sd_size, &lsa_policy_mapping,
+                       NULL, 0);
+       if (!NT_STATUS_IS_OK(status)) {
+               return status;
        }
 
-       /* This is needed for lsa_open_account and rpcclient .... :-) */
-
-       if (p->pipe_user.ut.uid == sec_initial_uid())
-               acc_granted = LSA_POLICY_ALL_ACCESS;
+       status = access_check_object(psd, p->server_info->ptok,
+                                    NULL, 0, des_access,
+                                    &acc_granted, "_lsa_OpenPolicy2" );
+       if (!NT_STATUS_IS_OK(status)) {
+               return status;
+       }
 
        /* associate the domain SID with the (unique) handle. */
-       if ((info = SMB_MALLOC_P(struct lsa_info)) == NULL)
+       info = TALLOC_ZERO_P(p->mem_ctx, struct lsa_info);
+       if (info == NULL) {
                return NT_STATUS_NO_MEMORY;
+       }
 
-       ZERO_STRUCTP(info);
        sid_copy(&info->sid,get_global_sam_sid());
        info->access = acc_granted;
+       info->type = LSA_HANDLE_POLICY_TYPE;
 
        /* set up the LSA QUERY INFO response */
-       if (!create_policy_hnd(p, r->out.handle, free_lsa_info, (void *)info))
+       if (!create_policy_hnd(p, r->out.handle, info))
                return NT_STATUS_OBJECT_NAME_NOT_FOUND;
 
        return NT_STATUS_OK;
@@ -412,46 +416,18 @@ NTSTATUS _lsa_OpenPolicy2(pipes_struct *p,
  _lsa_OpenPolicy
  ***************************************************************************/
 
-NTSTATUS _lsa_OpenPolicy(pipes_struct *p,
+NTSTATUS _lsa_OpenPolicy(struct pipes_struct *p,
                         struct lsa_OpenPolicy *r)
 {
-       struct lsa_info *info;
-       SEC_DESC *psd = NULL;
-       size_t sd_size;
-       uint32 des_access= r->in.access_mask;
-       uint32 acc_granted;
-       NTSTATUS status;
+       struct lsa_OpenPolicy2 o;
 
+       o.in.system_name        = NULL; /* should be ignored */
+       o.in.attr               = r->in.attr;
+       o.in.access_mask        = r->in.access_mask;
 
-       /* map the generic bits to the lsa policy ones */
-       se_map_generic(&des_access, &lsa_generic_mapping);
-
-       /* get the generic lsa policy SD until we store it */
-       lsa_get_generic_sd(p->mem_ctx, &psd, &sd_size);
-
-       if(!se_access_check(psd, p->pipe_user.nt_user_token, des_access, &acc_granted, &status)) {
-               if (geteuid() != 0) {
-                       return status;
-               }
-               DEBUG(4,("ACCESS should be DENIED (granted: %#010x;  required: %#010x)\n",
-                        acc_granted, des_access));
-               DEBUGADD(4,("but overwritten by euid == 0\n"));
-               acc_granted = des_access;
-       }
+       o.out.handle            = r->out.handle;
 
-       /* associate the domain SID with the (unique) handle. */
-       if ((info = SMB_MALLOC_P(struct lsa_info)) == NULL)
-               return NT_STATUS_NO_MEMORY;
-
-       ZERO_STRUCTP(info);
-       sid_copy(&info->sid,get_global_sam_sid());
-       info->access = acc_granted;
-
-       /* set up the LSA QUERY INFO response */
-       if (!create_policy_hnd(p, r->out.handle, free_lsa_info, (void *)info))
-               return NT_STATUS_OBJECT_NAME_NOT_FOUND;
-
-       return NT_STATUS_OK;
+       return _lsa_OpenPolicy2(p, &o);
 }
 
 /***************************************************************************
@@ -459,77 +435,74 @@ NTSTATUS _lsa_OpenPolicy(pipes_struct *p,
  ufff, done :)  mimir
  ***************************************************************************/
 
-NTSTATUS _lsa_EnumTrustDom(pipes_struct *p,
+NTSTATUS _lsa_EnumTrustDom(struct pipes_struct *p,
                           struct lsa_EnumTrustDom *r)
 {
        struct lsa_info *info;
-       uint32 next_idx;
+       uint32_t count;
        struct trustdom_info **domains;
-       struct lsa_DomainInfo *lsa_domains = NULL;
+       struct lsa_DomainInfo *entries;
        int i;
-
-       /*
-        * preferred length is set to 5 as a "our" preferred length
-        * nt sets this parameter to 2
-        * update (20.08.2002): it's not preferred length, but preferred size!
-        * it needs further investigation how to optimally choose this value
-        */
-       uint32 max_num_domains =
-               r->in.max_size < 5 ? r->in.max_size : 10;
-       uint32 num_domains;
        NTSTATUS nt_status;
-       uint32 num_thistime;
 
        if (!find_policy_by_hnd(p, r->in.handle, (void **)(void *)&info))
                return NT_STATUS_INVALID_HANDLE;
 
+       if (info->type != LSA_HANDLE_POLICY_TYPE) {
+               return NT_STATUS_INVALID_HANDLE;
+       }
+
        /* check if the user has enough rights */
        if (!(info->access & LSA_POLICY_VIEW_LOCAL_INFORMATION))
                return NT_STATUS_ACCESS_DENIED;
 
        become_root();
-       nt_status = pdb_enum_trusteddoms(p->mem_ctx, &num_domains, &domains);
+       nt_status = pdb_enum_trusteddoms(p->mem_ctx, &count, &domains);
        unbecome_root();
 
        if (!NT_STATUS_IS_OK(nt_status)) {
                return nt_status;
        }
 
-       if (*r->in.resume_handle < num_domains) {
-               num_thistime = MIN(num_domains, max_num_domains);
-
-               nt_status = STATUS_MORE_ENTRIES;
+       entries = TALLOC_ZERO_ARRAY(p->mem_ctx, struct lsa_DomainInfo, count);
+       if (!entries) {
+               return NT_STATUS_NO_MEMORY;
+       }
 
-               if (*r->in.resume_handle + num_thistime > num_domains) {
-                       num_thistime = num_domains - *r->in.resume_handle;
-                       nt_status = NT_STATUS_OK;
-               }
+       for (i=0; i<count; i++) {
+               init_lsa_StringLarge(&entries[i].name, domains[i]->name);
+               entries[i].sid = &domains[i]->sid;
+       }
 
-               next_idx = *r->in.resume_handle + num_thistime;
-       } else {
-               num_thistime = 0;
-               next_idx = 0xffffffff;
-               nt_status = NT_STATUS_NO_MORE_ENTRIES;
+       if (*r->in.resume_handle >= count) {
+               *r->out.resume_handle = -1;
+               TALLOC_FREE(entries);
+               return NT_STATUS_NO_MORE_ENTRIES;
        }
 
-       /* set up the lsa_enum_trust_dom response */
+       /* return the rest, limit by max_size. Note that we
+          use the w2k3 element size value of 60 */
+       r->out.domains->count = count - *r->in.resume_handle;
+       r->out.domains->count = MIN(r->out.domains->count,
+                                1+(r->in.max_size/LSA_ENUM_TRUST_DOMAIN_MULTIPLIER));
 
-       lsa_domains = TALLOC_ZERO_ARRAY(p->mem_ctx, struct lsa_DomainInfo,
-                                       num_thistime);
-       if (!lsa_domains) {
-               return NT_STATUS_NO_MEMORY;
-       }
+       r->out.domains->domains = entries + *r->in.resume_handle;
 
-       for (i=0; i<num_thistime; i++) {
-               init_lsa_StringLarge(&lsa_domains[i].name, domains[i]->name);
-               lsa_domains[i].sid = &domains[i]->sid;
+       if (r->out.domains->count < count - *r->in.resume_handle) {
+               *r->out.resume_handle = *r->in.resume_handle + r->out.domains->count;
+               return STATUS_MORE_ENTRIES;
        }
 
-       *r->out.resume_handle = next_idx;
-       r->out.domains->count = num_thistime;
-       r->out.domains->domains = lsa_domains;
+       /* according to MS-LSAD 3.1.4.7.8 output resume handle MUST
+        * always be larger than the previous input resume handle, in
+        * particular when hitting the last query it is vital to set the
+        * resume handle correctly to avoid infinite client loops, as
+        * seen e.g. with Windows XP SP3 when resume handle is 0 and
+        * status is NT_STATUS_OK - gd */
+
+       *r->out.resume_handle = (uint32_t)-1;
 
-       return nt_status;
+       return NT_STATUS_OK;
 }
 
 #define LSA_AUDIT_NUM_CATEGORIES_NT4   7
@@ -540,26 +513,104 @@ NTSTATUS _lsa_EnumTrustDom(pipes_struct *p,
  _lsa_QueryInfoPolicy
  ***************************************************************************/
 
-NTSTATUS _lsa_QueryInfoPolicy(pipes_struct *p,
+NTSTATUS _lsa_QueryInfoPolicy(struct pipes_struct *p,
                              struct lsa_QueryInfoPolicy *r)
 {
        NTSTATUS status = NT_STATUS_OK;
        struct lsa_info *handle;
-       DOM_SID domain_sid;
+       struct dom_sid domain_sid;
        const char *name;
-       DOM_SID *sid = NULL;
+       struct dom_sid *sid = NULL;
        union lsa_PolicyInformation *info = NULL;
+       uint32_t acc_required = 0;
 
        if (!find_policy_by_hnd(p, r->in.handle, (void **)(void *)&handle))
                return NT_STATUS_INVALID_HANDLE;
 
+       if (handle->type != LSA_HANDLE_POLICY_TYPE) {
+               return NT_STATUS_INVALID_HANDLE;
+       }
+
+       switch (r->in.level) {
+       case LSA_POLICY_INFO_AUDIT_LOG:
+       case LSA_POLICY_INFO_AUDIT_EVENTS:
+               acc_required = LSA_POLICY_VIEW_AUDIT_INFORMATION;
+               break;
+       case LSA_POLICY_INFO_DOMAIN:
+               acc_required = LSA_POLICY_VIEW_LOCAL_INFORMATION;
+               break;
+       case LSA_POLICY_INFO_PD:
+               acc_required = LSA_POLICY_GET_PRIVATE_INFORMATION;
+               break;
+       case LSA_POLICY_INFO_ACCOUNT_DOMAIN:
+               acc_required = LSA_POLICY_VIEW_LOCAL_INFORMATION;
+               break;
+       case LSA_POLICY_INFO_ROLE:
+       case LSA_POLICY_INFO_REPLICA:
+               acc_required = LSA_POLICY_VIEW_LOCAL_INFORMATION;
+               break;
+       case LSA_POLICY_INFO_QUOTA:
+               acc_required = LSA_POLICY_VIEW_LOCAL_INFORMATION;
+               break;
+       case LSA_POLICY_INFO_MOD:
+       case LSA_POLICY_INFO_AUDIT_FULL_SET:
+               /* according to MS-LSAD 3.1.4.4.3 */
+               return NT_STATUS_INVALID_PARAMETER;
+       case LSA_POLICY_INFO_AUDIT_FULL_QUERY:
+               acc_required = LSA_POLICY_VIEW_AUDIT_INFORMATION;
+               break;
+       case LSA_POLICY_INFO_DNS:
+       case LSA_POLICY_INFO_DNS_INT:
+       case LSA_POLICY_INFO_L_ACCOUNT_DOMAIN:
+               acc_required = LSA_POLICY_VIEW_LOCAL_INFORMATION;
+               break;
+       default:
+               break;
+       }
+
+       if (!(handle->access & acc_required)) {
+               /* return NT_STATUS_ACCESS_DENIED; */
+       }
+
        info = TALLOC_ZERO_P(p->mem_ctx, union lsa_PolicyInformation);
        if (!info) {
                return NT_STATUS_NO_MEMORY;
        }
 
        switch (r->in.level) {
-       case 0x02:
+       /* according to MS-LSAD 3.1.4.4.3 */
+       case LSA_POLICY_INFO_MOD:
+       case LSA_POLICY_INFO_AUDIT_FULL_SET:
+       case LSA_POLICY_INFO_AUDIT_FULL_QUERY:
+               return NT_STATUS_INVALID_PARAMETER;
+       case LSA_POLICY_INFO_AUDIT_LOG:
+               info->audit_log.percent_full            = 0;
+               info->audit_log.maximum_log_size        = 0;
+               info->audit_log.retention_time          = 0;
+               info->audit_log.shutdown_in_progress    = 0;
+               info->audit_log.time_to_shutdown        = 0;
+               info->audit_log.next_audit_record       = 0;
+               status = NT_STATUS_OK;
+               break;
+       case LSA_POLICY_INFO_PD:
+               info->pd.name.string                    = NULL;
+               status = NT_STATUS_OK;
+               break;
+       case LSA_POLICY_INFO_REPLICA:
+               info->replica.source.string             = NULL;
+               info->replica.account.string            = NULL;
+               status = NT_STATUS_OK;
+               break;
+       case LSA_POLICY_INFO_QUOTA:
+               info->quota.paged_pool                  = 0;
+               info->quota.non_paged_pool              = 0;
+               info->quota.min_wss                     = 0;
+               info->quota.max_wss                     = 0;
+               info->quota.pagefile                    = 0;
+               info->quota.unknown                     = 0;
+               status = NT_STATUS_OK;
+               break;
+       case LSA_POLICY_INFO_AUDIT_EVENTS:
                {
 
                uint32 policy_def = LSA_AUDIT_POLICY_ALL;
@@ -591,7 +642,7 @@ NTSTATUS _lsa_QueryInfoPolicy(pipes_struct *p,
 
                break;
                }
-       case 0x03:
+       case LSA_POLICY_INFO_DOMAIN:
                /* check if the user has enough rights */
                if (!(handle->access & LSA_POLICY_VIEW_LOCAL_INFORMATION))
                        return NT_STATUS_ACCESS_DENIED;
@@ -627,7 +678,7 @@ NTSTATUS _lsa_QueryInfoPolicy(pipes_struct *p,
                }
                init_dom_query_3(&info->domain, name, sid);
                break;
-       case 0x05:
+       case LSA_POLICY_INFO_ACCOUNT_DOMAIN:
                /* check if the user has enough rights */
                if (!(handle->access & LSA_POLICY_VIEW_LOCAL_INFORMATION))
                        return NT_STATUS_ACCESS_DENIED;
@@ -638,7 +689,7 @@ NTSTATUS _lsa_QueryInfoPolicy(pipes_struct *p,
 
                init_dom_query_5(&info->account_domain, name, sid);
                break;
-       case 0x06:
+       case LSA_POLICY_INFO_ROLE:
                /* check if the user has enough rights */
                if (!(handle->access & LSA_POLICY_VIEW_LOCAL_INFORMATION))
                        return NT_STATUS_ACCESS_DENIED;
@@ -649,17 +700,44 @@ NTSTATUS _lsa_QueryInfoPolicy(pipes_struct *p,
                                 * only a BDC is a backup controller
                                 * of the domain, it controls.
                                 */
-                               info->role.role = 2;
+                               info->role.role = LSA_ROLE_BACKUP;
                                break;
                        default:
                                /*
                                 * any other role is a primary
                                 * of the domain, it controls.
                                 */
-                               info->role.role = 3;
+                               info->role.role = LSA_ROLE_PRIMARY;
                                break;
                }
                break;
+       case LSA_POLICY_INFO_DNS:
+       case LSA_POLICY_INFO_DNS_INT: {
+               struct pdb_domain_info *dominfo;
+
+               if ((pdb_capabilities() & PDB_CAP_ADS) == 0) {
+                       DEBUG(10, ("Not replying to LSA_POLICY_INFO_DNS "
+                                  "without ADS passdb backend\n"));
+                       status = NT_STATUS_INVALID_INFO_CLASS;
+                       break;
+               }
+
+               dominfo = pdb_get_domain_info(info);
+               if (dominfo == NULL) {
+                       status = NT_STATUS_NO_MEMORY;
+                       break;
+               }
+
+               init_lsa_StringLarge(&info->dns.name,
+                                    dominfo->name);
+               init_lsa_StringLarge(&info->dns.dns_domain,
+                                    dominfo->dns_domain);
+               init_lsa_StringLarge(&info->dns.dns_forest,
+                                    dominfo->dns_forest);
+               info->dns.domain_guid = dominfo->guid;
+               info->dns.sid = &dominfo->sid;
+               break;
+       }
        default:
                DEBUG(0,("_lsa_QueryInfoPolicy: unknown info level in Lsa Query: %d\n",
                        r->in.level));
@@ -672,11 +750,33 @@ NTSTATUS _lsa_QueryInfoPolicy(pipes_struct *p,
        return status;
 }
 
+/***************************************************************************
+ _lsa_QueryInfoPolicy2
+ ***************************************************************************/
+
+NTSTATUS _lsa_QueryInfoPolicy2(struct pipes_struct *p,
+                              struct lsa_QueryInfoPolicy2 *r2)
+{
+       struct lsa_QueryInfoPolicy r;
+
+       if ((pdb_capabilities() & PDB_CAP_ADS) == 0) {
+               p->rng_fault_state = True;
+               return NT_STATUS_NOT_IMPLEMENTED;
+       }
+
+       ZERO_STRUCT(r);
+       r.in.handle = r2->in.handle;
+       r.in.level = r2->in.level;
+       r.out.info = r2->out.info;
+
+       return _lsa_QueryInfoPolicy(p, &r);
+}
+
 /***************************************************************************
  _lsa_lookup_sids_internal
  ***************************************************************************/
 
-static NTSTATUS _lsa_lookup_sids_internal(pipes_struct *p,
+static NTSTATUS _lsa_lookup_sids_internal(struct pipes_struct *p,
                                          TALLOC_CTX *mem_ctx,
                                          uint16_t level,                       /* input */
                                          int num_sids,                         /* input */
@@ -687,7 +787,7 @@ static NTSTATUS _lsa_lookup_sids_internal(pipes_struct *p,
 {
        NTSTATUS status;
        int i;
-       const DOM_SID **sids = NULL;
+       const struct dom_sid **sids = NULL;
        struct lsa_RefDomainList *ref = NULL;
        uint32 mapped_count = 0;
        struct lsa_dom_info *dom_infos = NULL;
@@ -702,7 +802,7 @@ static NTSTATUS _lsa_lookup_sids_internal(pipes_struct *p,
                return NT_STATUS_OK;
        }
 
-       sids = TALLOC_ARRAY(p->mem_ctx, const DOM_SID *, num_sids);
+       sids = TALLOC_ARRAY(p->mem_ctx, const struct dom_sid *, num_sids);
        ref = TALLOC_ZERO_P(p->mem_ctx, struct lsa_RefDomainList);
 
        if (sids == NULL || ref == NULL) {
@@ -725,7 +825,7 @@ static NTSTATUS _lsa_lookup_sids_internal(pipes_struct *p,
                return NT_STATUS_NO_MEMORY;
        }
 
-       for (i=0; i<MAX_REF_DOMAINS; i++) {
+       for (i=0; i<LSA_REF_DOMAIN_LIST_MULTIPLIER; i++) {
 
                if (!dom_infos[i].valid) {
                        break;
@@ -762,8 +862,10 @@ static NTSTATUS _lsa_lookup_sids_internal(pipes_struct *p,
                        mapped_count += 1;
                }
 
-               init_lsa_translated_name2(&names[i], name->type,
-                                         name->name, name->dom_idx, 0);
+               names[i].sid_type       = name->type;
+               names[i].name.string    = name->name;
+               names[i].sid_index      = name->dom_idx;
+               names[i].unknown        = 0;
        }
 
        status = NT_STATUS_NONE_MAPPED;
@@ -786,7 +888,7 @@ static NTSTATUS _lsa_lookup_sids_internal(pipes_struct *p,
  _lsa_LookupSids
  ***************************************************************************/
 
-NTSTATUS _lsa_LookupSids(pipes_struct *p,
+NTSTATUS _lsa_LookupSids(struct pipes_struct *p,
                         struct lsa_LookupSids *r)
 {
        NTSTATUS status;
@@ -806,6 +908,10 @@ NTSTATUS _lsa_LookupSids(pipes_struct *p,
                return NT_STATUS_INVALID_HANDLE;
        }
 
+       if (handle->type != LSA_HANDLE_POLICY_TYPE) {
+               return NT_STATUS_INVALID_HANDLE;
+       }
+
        /* check if the user has enough rights */
        if (!(handle->access & LSA_POLICY_LOOKUP_NAMES)) {
                return NT_STATUS_ACCESS_DENIED;
@@ -826,6 +932,18 @@ NTSTATUS _lsa_LookupSids(pipes_struct *p,
                                           &names,
                                           &mapped_count);
 
+       /* Only return here when there is a real error.
+          NT_STATUS_NONE_MAPPED is a special case as it indicates that none of
+          the requested sids could be resolved. Older versions of XP (pre SP3)
+          rely that we return with the string representations of those SIDs in
+          that case. If we don't, XP crashes - Guenther
+          */
+
+       if (NT_STATUS_IS_ERR(status) &&
+           !NT_STATUS_EQUAL(status, NT_STATUS_NONE_MAPPED)) {
+               return status;
+       }
+
        /* Convert from lsa_TranslatedName2 to lsa_TranslatedName */
        names_out = TALLOC_ARRAY(p->mem_ctx, struct lsa_TranslatedName,
                                 num_sids);
@@ -851,7 +969,7 @@ NTSTATUS _lsa_LookupSids(pipes_struct *p,
  _lsa_LookupSids2
  ***************************************************************************/
 
-NTSTATUS _lsa_LookupSids2(pipes_struct *p,
+NTSTATUS _lsa_LookupSids2(struct pipes_struct *p,
                          struct lsa_LookupSids2 *r)
 {
        NTSTATUS status;
@@ -862,7 +980,7 @@ NTSTATUS _lsa_LookupSids2(pipes_struct *p,
        struct lsa_TranslatedName2 *names = NULL;
        bool check_policy = true;
 
-       switch (p->hdr_req.opnum) {
+       switch (p->opnum) {
                case NDR_LSA_LOOKUPSIDS3:
                        check_policy = false;
                        break;
@@ -880,6 +998,10 @@ NTSTATUS _lsa_LookupSids2(pipes_struct *p,
                        return NT_STATUS_INVALID_HANDLE;
                }
 
+               if (handle->type != LSA_HANDLE_POLICY_TYPE) {
+                       return NT_STATUS_INVALID_HANDLE;
+               }
+
                /* check if the user has enough rights */
                if (!(handle->access & LSA_POLICY_LOOKUP_NAMES)) {
                        return NT_STATUS_ACCESS_DENIED;
@@ -913,13 +1035,13 @@ NTSTATUS _lsa_LookupSids2(pipes_struct *p,
  _lsa_LookupSids3
  ***************************************************************************/
 
-NTSTATUS _lsa_LookupSids3(pipes_struct *p,
+NTSTATUS _lsa_LookupSids3(struct pipes_struct *p,
                          struct lsa_LookupSids3 *r)
 {
        struct lsa_LookupSids2 q;
 
        /* No policy handle on this call. Restrict to crypto connections. */
-       if (p->auth.auth_type != PIPE_AUTH_TYPE_SCHANNEL) {
+       if (p->auth.auth_type != DCERPC_AUTH_TYPE_SCHANNEL) {
                DEBUG(0,("_lsa_LookupSids3: client %s not using schannel for netlogon\n",
                        get_remote_machine_name() ));
                return NT_STATUS_INVALID_PARAMETER;
@@ -928,8 +1050,8 @@ NTSTATUS _lsa_LookupSids3(pipes_struct *p,
        q.in.handle             = NULL;
        q.in.sids               = r->in.sids;
        q.in.level              = r->in.level;
-       q.in.unknown1           = r->in.unknown1;
-       q.in.unknown2           = r->in.unknown2;
+       q.in.lookup_options     = r->in.lookup_options;
+       q.in.client_revision    = r->in.client_revision;
        q.in.names              = r->in.names;
        q.in.count              = r->in.count;
 
@@ -943,23 +1065,24 @@ NTSTATUS _lsa_LookupSids3(pipes_struct *p,
 /***************************************************************************
  ***************************************************************************/
 
-static int lsa_lookup_level_to_flags(uint16 level)
+static int lsa_lookup_level_to_flags(enum lsa_LookupNamesLevel level)
 {
        int flags;
 
        switch (level) {
-               case 1:
+               case LSA_LOOKUP_NAMES_ALL: /* 1 */
                        flags = LOOKUP_NAME_ALL;
                        break;
-               case 2:
+               case LSA_LOOKUP_NAMES_DOMAINS_ONLY: /* 2 */
                        flags = LOOKUP_NAME_DOMAIN|LOOKUP_NAME_REMOTE|LOOKUP_NAME_ISOLATED;
                        break;
-               case 3:
+               case LSA_LOOKUP_NAMES_PRIMARY_DOMAIN_ONLY: /* 3 */
                        flags = LOOKUP_NAME_DOMAIN|LOOKUP_NAME_ISOLATED;
                        break;
-               case 4:
-               case 5:
-               case 6:
+               case LSA_LOOKUP_NAMES_UPLEVEL_TRUSTS_ONLY: /* 4 */
+               case LSA_LOOKUP_NAMES_FOREST_TRUSTS_ONLY: /* 5 */
+               case LSA_LOOKUP_NAMES_UPLEVEL_TRUSTS_ONLY2: /* 6 */
+               case LSA_LOOKUP_NAMES_RODC_REFERRAL_TO_FULL_DC: /* 7 */
                default:
                        flags = LOOKUP_NAME_NONE;
                        break;
@@ -972,7 +1095,7 @@ static int lsa_lookup_level_to_flags(uint16 level)
  _lsa_LookupNames
  ***************************************************************************/
 
-NTSTATUS _lsa_LookupNames(pipes_struct *p,
+NTSTATUS _lsa_LookupNames(struct pipes_struct *p,
                          struct lsa_LookupNames *r)
 {
        NTSTATUS status = NT_STATUS_NONE_MAPPED;
@@ -1012,6 +1135,10 @@ NTSTATUS _lsa_LookupNames(pipes_struct *p,
                goto done;
        }
 
+       if (handle->type != LSA_HANDLE_POLICY_TYPE) {
+               return NT_STATUS_INVALID_HANDLE;
+       }
+
        /* check if the user has enough rights */
        if (!(handle->access & LSA_POLICY_LOOKUP_NAMES)) {
                status = NT_STATUS_ACCESS_DENIED;
@@ -1046,7 +1173,7 @@ done:
  _lsa_LookupNames2
  ***************************************************************************/
 
-NTSTATUS _lsa_LookupNames2(pipes_struct *p,
+NTSTATUS _lsa_LookupNames2(struct pipes_struct *p,
                           struct lsa_LookupNames2 *r)
 {
        NTSTATUS status;
@@ -1076,6 +1203,7 @@ NTSTATUS _lsa_LookupNames2(pipes_struct *p,
 
        status = _lsa_LookupNames(p, &q);
 
+       sid_array2->count = sid_array->count;
        sid_array2->sids = TALLOC_ARRAY(p->mem_ctx, struct lsa_TranslatedSid2, sid_array->count);
        if (!sid_array2->sids) {
                return NT_STATUS_NO_MEMORY;
@@ -1097,7 +1225,7 @@ NTSTATUS _lsa_LookupNames2(pipes_struct *p,
  _lsa_LookupNames3
  ***************************************************************************/
 
-NTSTATUS _lsa_LookupNames3(pipes_struct *p,
+NTSTATUS _lsa_LookupNames3(struct pipes_struct *p,
                           struct lsa_LookupNames3 *r)
 {
        NTSTATUS status;
@@ -1110,7 +1238,7 @@ NTSTATUS _lsa_LookupNames3(pipes_struct *p,
        int flags = 0;
        bool check_policy = true;
 
-       switch (p->hdr_req.opnum) {
+       switch (p->opnum) {
                case NDR_LSA_LOOKUPNAMES4:
                        check_policy = false;
                        break;
@@ -1151,6 +1279,10 @@ NTSTATUS _lsa_LookupNames3(pipes_struct *p,
                        goto done;
                }
 
+               if (handle->type != LSA_HANDLE_POLICY_TYPE) {
+                       return NT_STATUS_INVALID_HANDLE;
+               }
+
                /* check if the user has enough rights */
                if (!(handle->access & LSA_POLICY_LOOKUP_NAMES)) {
                        status = NT_STATUS_ACCESS_DENIED;
@@ -1186,13 +1318,13 @@ done:
  _lsa_LookupNames4
  ***************************************************************************/
 
-NTSTATUS _lsa_LookupNames4(pipes_struct *p,
+NTSTATUS _lsa_LookupNames4(struct pipes_struct *p,
                           struct lsa_LookupNames4 *r)
 {
        struct lsa_LookupNames3 q;
 
        /* No policy handle on this call. Restrict to crypto connections. */
-       if (p->auth.auth_type != PIPE_AUTH_TYPE_SCHANNEL) {
+       if (p->auth.auth_type != DCERPC_AUTH_TYPE_SCHANNEL) {
                DEBUG(0,("_lsa_lookup_names4: client %s not using schannel for netlogon\n",
                        get_remote_machine_name() ));
                return NT_STATUS_INVALID_PARAMETER;
@@ -1202,8 +1334,8 @@ NTSTATUS _lsa_LookupNames4(pipes_struct *p,
        q.in.num_names          = r->in.num_names;
        q.in.names              = r->in.names;
        q.in.level              = r->in.level;
-       q.in.unknown1           = r->in.unknown1;
-       q.in.unknown2           = r->in.unknown2;
+       q.in.lookup_options     = r->in.lookup_options;
+       q.in.client_revision    = r->in.client_revision;
        q.in.sids               = r->in.sids;
        q.in.count              = r->in.count;
 
@@ -1218,7 +1350,7 @@ NTSTATUS _lsa_LookupNames4(pipes_struct *p,
  _lsa_close. Also weird - needs to check if lsa handle is correct. JRA.
  ***************************************************************************/
 
-NTSTATUS _lsa_Close(pipes_struct *p, struct lsa_Close *r)
+NTSTATUS _lsa_Close(struct pipes_struct *p, struct lsa_Close *r)
 {
        if (!find_policy_by_hnd(p, r->in.handle, NULL)) {
                return NT_STATUS_INVALID_HANDLE;
@@ -1232,7 +1364,7 @@ NTSTATUS _lsa_Close(pipes_struct *p, struct lsa_Close *r)
 /***************************************************************************
  ***************************************************************************/
 
-NTSTATUS _lsa_OpenSecret(pipes_struct *p, struct lsa_OpenSecret *r)
+NTSTATUS _lsa_OpenSecret(struct pipes_struct *p, struct lsa_OpenSecret *r)
 {
        return NT_STATUS_OBJECT_NAME_NOT_FOUND;
 }
@@ -1240,7 +1372,8 @@ NTSTATUS _lsa_OpenSecret(pipes_struct *p, struct lsa_OpenSecret *r)
 /***************************************************************************
  ***************************************************************************/
 
-NTSTATUS _lsa_OpenTrustedDomain(pipes_struct *p, struct lsa_OpenTrustedDomain *r)
+NTSTATUS _lsa_OpenTrustedDomain(struct pipes_struct *p,
+                               struct lsa_OpenTrustedDomain *r)
 {
        return NT_STATUS_OBJECT_NAME_NOT_FOUND;
 }
@@ -1248,7 +1381,8 @@ NTSTATUS _lsa_OpenTrustedDomain(pipes_struct *p, struct lsa_OpenTrustedDomain *r
 /***************************************************************************
  ***************************************************************************/
 
-NTSTATUS _lsa_CreateTrustedDomain(pipes_struct *p, struct lsa_CreateTrustedDomain *r)
+NTSTATUS _lsa_CreateTrustedDomain(struct pipes_struct *p,
+                                 struct lsa_CreateTrustedDomain *r)
 {
        return NT_STATUS_ACCESS_DENIED;
 }
@@ -1256,7 +1390,7 @@ NTSTATUS _lsa_CreateTrustedDomain(pipes_struct *p, struct lsa_CreateTrustedDomai
 /***************************************************************************
  ***************************************************************************/
 
-NTSTATUS _lsa_CreateSecret(pipes_struct *p, struct lsa_CreateSecret *r)
+NTSTATUS _lsa_CreateSecret(struct pipes_struct *p, struct lsa_CreateSecret *r)
 {
        return NT_STATUS_ACCESS_DENIED;
 }
@@ -1264,7 +1398,7 @@ NTSTATUS _lsa_CreateSecret(pipes_struct *p, struct lsa_CreateSecret *r)
 /***************************************************************************
  ***************************************************************************/
 
-NTSTATUS _lsa_SetSecret(pipes_struct *p, struct lsa_SetSecret *r)
+NTSTATUS _lsa_SetSecret(struct pipes_struct *p, struct lsa_SetSecret *r)
 {
        return NT_STATUS_ACCESS_DENIED;
 }
@@ -1273,17 +1407,44 @@ NTSTATUS _lsa_SetSecret(pipes_struct *p, struct lsa_SetSecret *r)
  _lsa_DeleteObject
  ***************************************************************************/
 
-NTSTATUS _lsa_DeleteObject(pipes_struct *p,
+NTSTATUS _lsa_DeleteObject(struct pipes_struct *p,
                           struct lsa_DeleteObject *r)
 {
-       return NT_STATUS_ACCESS_DENIED;
+       NTSTATUS status;
+       struct lsa_info *info = NULL;
+
+       if (!find_policy_by_hnd(p, r->in.handle, (void **)(void *)&info)) {
+               return NT_STATUS_INVALID_HANDLE;
+       }
+
+       if (!(info->access & SEC_STD_DELETE)) {
+               return NT_STATUS_ACCESS_DENIED;
+       }
+
+       switch (info->type) {
+       case LSA_HANDLE_ACCOUNT_TYPE:
+               status = privilege_delete_account(&info->sid);
+               if (!NT_STATUS_IS_OK(status)) {
+                       DEBUG(10,("_lsa_DeleteObject: privilege_delete_account gave: %s\n",
+                               nt_errstr(status)));
+                       return status;
+               }
+               break;
+       default:
+               return NT_STATUS_INVALID_HANDLE;
+       }
+
+       close_policy_hnd(p, r->in.handle);
+       ZERO_STRUCTP(r->out.handle);
+
+       return status;
 }
 
 /***************************************************************************
  _lsa_EnumPrivs
  ***************************************************************************/
 
-NTSTATUS _lsa_EnumPrivs(pipes_struct *p,
+NTSTATUS _lsa_EnumPrivs(struct pipes_struct *p,
                        struct lsa_EnumPrivs *r)
 {
        struct lsa_info *handle;
@@ -1291,7 +1452,7 @@ NTSTATUS _lsa_EnumPrivs(pipes_struct *p,
        uint32 enum_context = *r->in.resume_handle;
        int num_privs = count_all_privileges();
        struct lsa_PrivEntry *entries = NULL;
-       LUID_ATTR luid;
+       struct lsa_LUIDAttribute luid;
 
        /* remember that the enum_context starts at 0 and not 1 */
 
@@ -1304,6 +1465,10 @@ NTSTATUS _lsa_EnumPrivs(pipes_struct *p,
        if (!find_policy_by_hnd(p, r->in.handle, (void **)(void *)&handle))
                return NT_STATUS_INVALID_HANDLE;
 
+       if (handle->type != LSA_HANDLE_POLICY_TYPE) {
+               return NT_STATUS_INVALID_HANDLE;
+       }
+
        /* check if the user has enough rights
           I don't know if it's the right one. not documented.  */
 
@@ -1350,7 +1515,7 @@ NTSTATUS _lsa_EnumPrivs(pipes_struct *p,
  _lsa_LookupPrivDisplayName
  ***************************************************************************/
 
-NTSTATUS _lsa_LookupPrivDisplayName(pipes_struct *p,
+NTSTATUS _lsa_LookupPrivDisplayName(struct pipes_struct *p,
                                    struct lsa_LookupPrivDisplayName *r)
 {
        struct lsa_info *handle;
@@ -1360,6 +1525,10 @@ NTSTATUS _lsa_LookupPrivDisplayName(pipes_struct *p,
        if (!find_policy_by_hnd(p, r->in.handle, (void **)(void *)&handle))
                return NT_STATUS_INVALID_HANDLE;
 
+       if (handle->type != LSA_HANDLE_POLICY_TYPE) {
+               return NT_STATUS_INVALID_HANDLE;
+       }
+
        /* check if the user has enough rights */
 
        /*
@@ -1395,11 +1564,11 @@ NTSTATUS _lsa_LookupPrivDisplayName(pipes_struct *p,
  _lsa_EnumAccounts
  ***************************************************************************/
 
-NTSTATUS _lsa_EnumAccounts(pipes_struct *p,
+NTSTATUS _lsa_EnumAccounts(struct pipes_struct *p,
                           struct lsa_EnumAccounts *r)
 {
        struct lsa_info *handle;
-       DOM_SID *sid_list;
+       struct dom_sid *sid_list;
        int i, j, num_entries;
        NTSTATUS status;
        struct lsa_SidPtr *sids = NULL;
@@ -1407,6 +1576,10 @@ NTSTATUS _lsa_EnumAccounts(pipes_struct *p,
        if (!find_policy_by_hnd(p, r->in.handle, (void **)(void *)&handle))
                return NT_STATUS_INVALID_HANDLE;
 
+       if (handle->type != LSA_HANDLE_POLICY_TYPE) {
+               return NT_STATUS_INVALID_HANDLE;
+       }
+
        if (!(handle->access & LSA_POLICY_VIEW_LOCAL_INFORMATION))
                return NT_STATUS_ACCESS_DENIED;
 
@@ -1429,14 +1602,14 @@ NTSTATUS _lsa_EnumAccounts(pipes_struct *p,
                sids = TALLOC_ZERO_ARRAY(p->mem_ctx, struct lsa_SidPtr,
                                         num_entries - *r->in.resume_handle);
                if (!sids) {
-                       SAFE_FREE(sid_list);
+                       talloc_free(sid_list);
                        return NT_STATUS_NO_MEMORY;
                }
 
                for (i = *r->in.resume_handle, j = 0; i < num_entries; i++, j++) {
                        sids[j].sid = sid_dup_talloc(p->mem_ctx, &sid_list[i]);
                        if (!sids[j].sid) {
-                               SAFE_FREE(sid_list);
+                               talloc_free(sid_list);
                                return NT_STATUS_NO_MEMORY;
                        }
                }
@@ -1455,13 +1628,23 @@ NTSTATUS _lsa_EnumAccounts(pipes_struct *p,
  _lsa_GetUserName
  ***************************************************************************/
 
-NTSTATUS _lsa_GetUserName(pipes_struct *p,
+NTSTATUS _lsa_GetUserName(struct pipes_struct *p,
                          struct lsa_GetUserName *r)
 {
        const char *username, *domname;
        struct lsa_String *account_name = NULL;
        struct lsa_String *authority_name = NULL;
 
+       if (r->in.account_name &&
+          *r->in.account_name) {
+               return NT_STATUS_INVALID_PARAMETER;
+       }
+
+       if (r->in.authority_name &&
+          *r->in.authority_name) {
+               return NT_STATUS_INVALID_PARAMETER;
+       }
+
        if (p->server_info->guest) {
                /*
                 * I'm 99% sure this is not the right place to do this,
@@ -1474,24 +1657,27 @@ NTSTATUS _lsa_GetUserName(pipes_struct *p,
                }
        } else {
                username = p->server_info->sanitized_username;
-               domname = pdb_get_domain(p->server_info->sam_account);
+               domname = p->server_info->info3->base.domain.string;
        }
 
-       account_name = TALLOC_ZERO_P(p->mem_ctx, struct lsa_String);
+       account_name = TALLOC_P(p->mem_ctx, struct lsa_String);
        if (!account_name) {
                return NT_STATUS_NO_MEMORY;
        }
+       init_lsa_String(account_name, username);
 
-       authority_name = TALLOC_ZERO_P(p->mem_ctx, struct lsa_String);
-       if (!authority_name) {
-               return NT_STATUS_NO_MEMORY;
+       if (r->out.authority_name) {
+               authority_name = TALLOC_P(p->mem_ctx, struct lsa_String);
+               if (!authority_name) {
+                       return NT_STATUS_NO_MEMORY;
+               }
+               init_lsa_String(authority_name, domname);
        }
 
-       init_lsa_String(account_name, username);
-       init_lsa_String(authority_name, domname);
-
        *r->out.account_name = account_name;
-       *r->out.authority_name = authority_name;
+       if (r->out.authority_name) {
+               *r->out.authority_name = authority_name;
+       }
 
        return NT_STATUS_OK;
 }
@@ -1500,73 +1686,121 @@ NTSTATUS _lsa_GetUserName(pipes_struct *p,
  _lsa_CreateAccount
  ***************************************************************************/
 
-NTSTATUS _lsa_CreateAccount(pipes_struct *p,
+NTSTATUS _lsa_CreateAccount(struct pipes_struct *p,
                            struct lsa_CreateAccount *r)
 {
+       NTSTATUS status;
        struct lsa_info *handle;
        struct lsa_info *info;
+       uint32_t acc_granted;
+       struct security_descriptor *psd;
+       size_t sd_size;
 
        /* find the connection policy handle. */
        if (!find_policy_by_hnd(p, r->in.handle, (void **)(void *)&handle))
                return NT_STATUS_INVALID_HANDLE;
 
+       if (handle->type != LSA_HANDLE_POLICY_TYPE) {
+               return NT_STATUS_INVALID_HANDLE;
+       }
+
        /* check if the user has enough rights */
 
-       /*
-        * I don't know if it's the right one. not documented.
-        * but guessed with rpcclient.
-        */
-       if (!(handle->access & LSA_POLICY_GET_PRIVATE_INFORMATION))
+       if (!(handle->access & LSA_POLICY_CREATE_ACCOUNT)) {
                return NT_STATUS_ACCESS_DENIED;
+       }
 
-       /* check to see if the pipe_user is a Domain Admin since
-          account_pol.tdb was already opened as root, this is all we have */
+       /* Work out max allowed. */
+       map_max_allowed_access(p->server_info->ptok,
+                              &p->server_info->utok,
+                              &r->in.access_mask);
 
-       if ( !nt_token_check_domain_rid( p->pipe_user.nt_user_token, DOMAIN_GROUP_RID_ADMINS ) )
-               return NT_STATUS_ACCESS_DENIED;
+       /* map the generic bits to the lsa policy ones */
+       se_map_generic(&r->in.access_mask, &lsa_account_mapping);
+
+       status = make_lsa_object_sd(p->mem_ctx, &psd, &sd_size,
+                                   &lsa_account_mapping,
+                                   r->in.sid, LSA_POLICY_ALL_ACCESS);
+       if (!NT_STATUS_IS_OK(status)) {
+               return status;
+       }
+
+       status = access_check_object(psd, p->server_info->ptok,
+                                    NULL, 0, r->in.access_mask,
+                                    &acc_granted, "_lsa_CreateAccount");
+       if (!NT_STATUS_IS_OK(status)) {
+               return status;
+       }
 
        if ( is_privileged_sid( r->in.sid ) )
                return NT_STATUS_OBJECT_NAME_COLLISION;
 
        /* associate the user/group SID with the (unique) handle. */
 
-       if ((info = SMB_MALLOC_P(struct lsa_info)) == NULL)
+       info = TALLOC_ZERO_P(p->mem_ctx, struct lsa_info);
+       if (info == NULL) {
                return NT_STATUS_NO_MEMORY;
+       }
 
-       ZERO_STRUCTP(info);
        info->sid = *r->in.sid;
-       info->access = r->in.access_mask;
+       info->access = acc_granted;
+       info->type = LSA_HANDLE_ACCOUNT_TYPE;
 
        /* get a (unique) handle.  open a policy on it. */
-       if (!create_policy_hnd(p, r->out.acct_handle, free_lsa_info, (void *)info))
+       if (!create_policy_hnd(p, r->out.acct_handle, info))
                return NT_STATUS_OBJECT_NAME_NOT_FOUND;
 
        return privilege_create_account( &info->sid );
 }
 
-
 /***************************************************************************
  _lsa_OpenAccount
  ***************************************************************************/
 
-NTSTATUS _lsa_OpenAccount(pipes_struct *p,
+NTSTATUS _lsa_OpenAccount(struct pipes_struct *p,
                          struct lsa_OpenAccount *r)
 {
        struct lsa_info *handle;
        struct lsa_info *info;
+       struct security_descriptor *psd = NULL;
+       size_t sd_size;
+       uint32_t des_access = r->in.access_mask;
+       uint32_t acc_granted;
+       NTSTATUS status;
 
        /* find the connection policy handle. */
        if (!find_policy_by_hnd(p, r->in.handle, (void **)(void *)&handle))
                return NT_STATUS_INVALID_HANDLE;
 
-       /* check if the user has enough rights */
+       if (handle->type != LSA_HANDLE_POLICY_TYPE) {
+               return NT_STATUS_INVALID_HANDLE;
+       }
 
-       /*
-        * I don't know if it's the right one. not documented.
-        * but guessed with rpcclient.
-        */
-       if (!(handle->access & LSA_POLICY_GET_PRIVATE_INFORMATION))
-               return NT_STATUS_ACCESS_DENIED;
+       /* des_access is for the account here, not the policy
+        * handle - so don't check against policy handle. */
+
+       /* Work out max allowed. */
+       map_max_allowed_access(p->server_info->ptok,
+                              &p->server_info->utok,
+                              &des_access);
+
+       /* map the generic bits to the lsa account ones */
+       se_map_generic(&des_access, &lsa_account_mapping);
+
+       /* get the generic lsa account SD until we store it */
+       status = make_lsa_object_sd(p->mem_ctx, &psd, &sd_size,
+                               &lsa_account_mapping,
+                               r->in.sid, LSA_ACCOUNT_ALL_ACCESS);
+       if (!NT_STATUS_IS_OK(status)) {
+               return status;
+       }
+
+       status = access_check_object(psd, p->server_info->ptok,
+                                    NULL, 0, des_access,
+                                    &acc_granted, "_lsa_OpenAccount" );
+       if (!NT_STATUS_IS_OK(status)) {
+               return status;
+       }
 
        /* TODO: Fis the parsing routine before reenabling this check! */
        #if 0
@@ -1574,15 +1808,17 @@ NTSTATUS _lsa_OpenAccount(pipes_struct *p,
                return NT_STATUS_ACCESS_DENIED;
        #endif
        /* associate the user/group SID with the (unique) handle. */
-       if ((info = SMB_MALLOC_P(struct lsa_info)) == NULL)
+       info = TALLOC_ZERO_P(p->mem_ctx, struct lsa_info);
+       if (info == NULL) {
                return NT_STATUS_NO_MEMORY;
+       }
 
-       ZERO_STRUCTP(info);
        info->sid = *r->in.sid;
-       info->access = r->in.access_mask;
+       info->access = acc_granted;
+       info->type = LSA_HANDLE_ACCOUNT_TYPE;
 
        /* get a (unique) handle.  open a policy on it. */
-       if (!create_policy_hnd(p, r->out.acct_handle, free_lsa_info, (void *)info))
+       if (!create_policy_hnd(p, r->out.acct_handle, info))
                return NT_STATUS_OBJECT_NAME_NOT_FOUND;
 
        return NT_STATUS_OK;
@@ -1593,7 +1829,7 @@ NTSTATUS _lsa_OpenAccount(pipes_struct *p,
  For a given SID, enumerate all the privilege this account has.
  ***************************************************************************/
 
-NTSTATUS _lsa_EnumPrivsAccount(pipes_struct *p,
+NTSTATUS _lsa_EnumPrivsAccount(struct pipes_struct *p,
                               struct lsa_EnumPrivsAccount *r)
 {
        NTSTATUS status = NT_STATUS_OK;
@@ -1608,23 +1844,29 @@ NTSTATUS _lsa_EnumPrivsAccount(pipes_struct *p,
        if (!find_policy_by_hnd(p, r->in.handle, (void **)(void *)&info))
                return NT_STATUS_INVALID_HANDLE;
 
-       if ( !get_privileges_for_sids( &mask, &info->sid, 1 ) )
-               return NT_STATUS_OBJECT_NAME_NOT_FOUND;
+       if (info->type != LSA_HANDLE_ACCOUNT_TYPE) {
+               return NT_STATUS_INVALID_HANDLE;
+       }
+
+       if (!(info->access & LSA_ACCOUNT_VIEW))
+               return NT_STATUS_ACCESS_DENIED;
+
+       get_privileges_for_sids(&mask, &info->sid, 1);
 
        privilege_set_init( &privileges );
 
+       priv_set = TALLOC_ZERO_P(p->mem_ctx, struct lsa_PrivilegeSet);
+       if (!priv_set) {
+               status = NT_STATUS_NO_MEMORY;
+               goto done;
+       }
+
        if ( se_priv_to_privilege_set( &privileges, &mask ) ) {
 
                DEBUG(10,("_lsa_EnumPrivsAccount: %s has %d privileges\n",
                          sid_string_dbg(&info->sid),
                          privileges.count));
 
-               priv_set = TALLOC_ZERO_P(p->mem_ctx, struct lsa_PrivilegeSet);
-               if (!priv_set) {
-                       status = NT_STATUS_NO_MEMORY;
-                       goto done;
-               }
-
                luid_attrs = TALLOC_ZERO_ARRAY(p->mem_ctx,
                                               struct lsa_LUIDAttribute,
                                               privileges.count);
@@ -1634,20 +1876,21 @@ NTSTATUS _lsa_EnumPrivsAccount(pipes_struct *p,
                }
 
                for (i=0; i<privileges.count; i++) {
-                       luid_attrs[i].luid.low = privileges.set[i].luid.low;
-                       luid_attrs[i].luid.high = privileges.set[i].luid.high;
-                       luid_attrs[i].attribute = privileges.set[i].attr;
+                       luid_attrs[i] = privileges.set[i];
                }
 
                priv_set->count = privileges.count;
                priv_set->unknown = 0;
                priv_set->set = luid_attrs;
 
-               *r->out.privs = priv_set;
        } else {
-               status = NT_STATUS_NO_SUCH_PRIVILEGE;
+               priv_set->count = 0;
+               priv_set->unknown = 0;
+               priv_set->set = NULL;
        }
 
+       *r->out.privs = priv_set;
+
  done:
        privilege_set_free( &privileges );
 
@@ -1658,19 +1901,46 @@ NTSTATUS _lsa_EnumPrivsAccount(pipes_struct *p,
  _lsa_GetSystemAccessAccount
  ***************************************************************************/
 
-NTSTATUS _lsa_GetSystemAccessAccount(pipes_struct *p,
+NTSTATUS _lsa_GetSystemAccessAccount(struct pipes_struct *p,
                                     struct lsa_GetSystemAccessAccount *r)
 {
-       struct lsa_info *info=NULL;
+       NTSTATUS status;
+       struct lsa_info *info = NULL;
+       struct lsa_EnumPrivsAccount e;
+       struct lsa_PrivilegeSet *privset;
 
        /* find the connection policy handle. */
 
        if (!find_policy_by_hnd(p, r->in.handle, (void **)(void *)&info))
                return NT_STATUS_INVALID_HANDLE;
 
-       if (!lookup_sid(p->mem_ctx, &info->sid, NULL, NULL, NULL))
+       if (info->type != LSA_HANDLE_ACCOUNT_TYPE) {
+               return NT_STATUS_INVALID_HANDLE;
+       }
+
+       if (!(info->access & LSA_ACCOUNT_VIEW))
                return NT_STATUS_ACCESS_DENIED;
 
+       privset = talloc_zero(p->mem_ctx, struct lsa_PrivilegeSet);
+       if (!privset) {
+               return NT_STATUS_NO_MEMORY;
+       }
+
+       e.in.handle = r->in.handle;
+       e.out.privs = &privset;
+
+       status = _lsa_EnumPrivsAccount(p, &e);
+       if (!NT_STATUS_IS_OK(status)) {
+               DEBUG(10,("_lsa_GetSystemAccessAccount: "
+                       "failed to call _lsa_EnumPrivsAccount(): %s\n",
+                       nt_errstr(status)));
+               return status;
+       }
+
+       /* Samba4 would iterate over the privset to merge the policy mode bits,
+        * not sure samba3 can do the same here, so just return what we did in
+        * the past - gd */
+
        /*
          0x01 -> Log on locally
          0x02 -> Access this computer from network
@@ -1680,7 +1950,8 @@ NTSTATUS _lsa_GetSystemAccessAccount(pipes_struct *p,
          they can be ORed together
        */
 
-       *r->out.access_mask = PR_LOG_ON_LOCALLY | PR_ACCESS_FROM_NETWORK;
+       *r->out.access_mask = LSA_POLICY_MODE_INTERACTIVE |
+                             LSA_POLICY_MODE_NETWORK;
 
        return NT_STATUS_OK;
 }
@@ -1689,7 +1960,7 @@ NTSTATUS _lsa_GetSystemAccessAccount(pipes_struct *p,
   update the systemaccount information
  ***************************************************************************/
 
-NTSTATUS _lsa_SetSystemAccessAccount(pipes_struct *p,
+NTSTATUS _lsa_SetSystemAccessAccount(struct pipes_struct *p,
                                     struct lsa_SetSystemAccessAccount *r)
 {
        struct lsa_info *info=NULL;
@@ -1699,11 +1970,13 @@ NTSTATUS _lsa_SetSystemAccessAccount(pipes_struct *p,
        if (!find_policy_by_hnd(p, r->in.handle, (void **)(void *)&info))
                return NT_STATUS_INVALID_HANDLE;
 
-       /* check to see if the pipe_user is a Domain Admin since
-          account_pol.tdb was already opened as root, this is all we have */
+       if (info->type != LSA_HANDLE_ACCOUNT_TYPE) {
+               return NT_STATUS_INVALID_HANDLE;
+       }
 
-       if ( !nt_token_check_domain_rid( p->pipe_user.nt_user_token, DOMAIN_GROUP_RID_ADMINS ) )
+       if (!(info->access & LSA_ACCOUNT_ADJUST_SYSTEM_ACCESS)) {
                return NT_STATUS_ACCESS_DENIED;
+       }
 
        if (!pdb_getgrsid(&map, info->sid))
                return NT_STATUS_NO_SUCH_GROUP;
@@ -1716,7 +1989,7 @@ NTSTATUS _lsa_SetSystemAccessAccount(pipes_struct *p,
  For a given SID, add some privileges.
  ***************************************************************************/
 
-NTSTATUS _lsa_AddPrivilegesToAccount(pipes_struct *p,
+NTSTATUS _lsa_AddPrivilegesToAccount(struct pipes_struct *p,
                                     struct lsa_AddPrivilegesToAccount *r)
 {
        struct lsa_info *info = NULL;
@@ -1727,12 +2000,11 @@ NTSTATUS _lsa_AddPrivilegesToAccount(pipes_struct *p,
        if (!find_policy_by_hnd(p, r->in.handle, (void **)(void *)&info))
                return NT_STATUS_INVALID_HANDLE;
 
-       /* check to see if the pipe_user is root or a Domain Admin since
-          account_pol.tdb was already opened as root, this is all we have */
+       if (info->type != LSA_HANDLE_ACCOUNT_TYPE) {
+               return NT_STATUS_INVALID_HANDLE;
+       }
 
-       if ( p->pipe_user.ut.uid != sec_initial_uid()
-               && !nt_token_check_domain_rid( p->pipe_user.nt_user_token, DOMAIN_GROUP_RID_ADMINS ) )
-       {
+       if (!(info->access & LSA_ACCOUNT_ADJUST_PRIVILEGES)) {
                return NT_STATUS_ACCESS_DENIED;
        }
 
@@ -1756,7 +2028,7 @@ NTSTATUS _lsa_AddPrivilegesToAccount(pipes_struct *p,
  For a given SID, remove some privileges.
  ***************************************************************************/
 
-NTSTATUS _lsa_RemovePrivilegesFromAccount(pipes_struct *p,
+NTSTATUS _lsa_RemovePrivilegesFromAccount(struct pipes_struct *p,
                                          struct lsa_RemovePrivilegesFromAccount *r)
 {
        struct lsa_info *info = NULL;
@@ -1767,12 +2039,11 @@ NTSTATUS _lsa_RemovePrivilegesFromAccount(pipes_struct *p,
        if (!find_policy_by_hnd(p, r->in.handle, (void **)(void *)&info))
                return NT_STATUS_INVALID_HANDLE;
 
-       /* check to see if the pipe_user is root or a Domain Admin since
-          account_pol.tdb was already opened as root, this is all we have */
+       if (info->type != LSA_HANDLE_ACCOUNT_TYPE) {
+               return NT_STATUS_INVALID_HANDLE;
+       }
 
-       if ( p->pipe_user.ut.uid != sec_initial_uid()
-               && !nt_token_check_domain_rid( p->pipe_user.nt_user_token, DOMAIN_GROUP_RID_ADMINS ) )
-       {
+       if (!(info->access & LSA_ACCOUNT_ADJUST_PRIVILEGES)) {
                return NT_STATUS_ACCESS_DENIED;
        }
 
@@ -1793,147 +2064,139 @@ NTSTATUS _lsa_RemovePrivilegesFromAccount(pipes_struct *p,
 }
 
 /***************************************************************************
- _lsa_QuerySecurity
+ _lsa_LookupPrivName
  ***************************************************************************/
 
-NTSTATUS _lsa_QuerySecurity(pipes_struct *p,
-                           struct lsa_QuerySecurity *r)
+NTSTATUS _lsa_LookupPrivName(struct pipes_struct *p,
+                            struct lsa_LookupPrivName *r)
 {
-       struct lsa_info *handle=NULL;
-       SEC_DESC *psd = NULL;
-       size_t sd_size;
-       NTSTATUS status;
+       struct lsa_info *info = NULL;
+       const char *name;
+       struct lsa_StringLarge *lsa_name;
 
        /* find the connection policy handle. */
-       if (!find_policy_by_hnd(p, r->in.handle, (void **)(void *)&handle))
+       if (!find_policy_by_hnd(p, r->in.handle, (void **)(void *)&info)) {
                return NT_STATUS_INVALID_HANDLE;
+       }
 
-       /* check if the user has enough rights */
-       if (!(handle->access & LSA_POLICY_VIEW_LOCAL_INFORMATION))
-               return NT_STATUS_ACCESS_DENIED;
-
-
-       switch (r->in.sec_info) {
-       case 1:
-               /* SD contains only the owner */
-
-               status=lsa_get_generic_sd(p->mem_ctx, &psd, &sd_size);
-               if(!NT_STATUS_IS_OK(status))
-                       return NT_STATUS_NO_MEMORY;
+       if (info->type != LSA_HANDLE_POLICY_TYPE) {
+               return NT_STATUS_INVALID_HANDLE;
+       }
 
+       if (!(info->access & LSA_POLICY_VIEW_LOCAL_INFORMATION)) {
+               return NT_STATUS_ACCESS_DENIED;
+       }
 
-               if((*r->out.sdbuf = make_sec_desc_buf(p->mem_ctx, sd_size, psd)) == NULL)
-                       return NT_STATUS_NO_MEMORY;
-               break;
-       case 4:
-               /* SD contains only the ACL */
+       name = luid_to_privilege_name(r->in.luid);
+       if (!name) {
+               return NT_STATUS_NO_SUCH_PRIVILEGE;
+       }
 
-               status=lsa_get_generic_sd(p->mem_ctx, &psd, &sd_size);
-               if(!NT_STATUS_IS_OK(status))
-                       return NT_STATUS_NO_MEMORY;
+       lsa_name = TALLOC_ZERO_P(p->mem_ctx, struct lsa_StringLarge);
+       if (!lsa_name) {
+               return NT_STATUS_NO_MEMORY;
+       }
 
-               if((*r->out.sdbuf = make_sec_desc_buf(p->mem_ctx, sd_size, psd)) == NULL)
-                       return NT_STATUS_NO_MEMORY;
-               break;
-       default:
-               return NT_STATUS_INVALID_LEVEL;
+       lsa_name->string = talloc_strdup(lsa_name, name);
+       if (!lsa_name->string) {
+               TALLOC_FREE(lsa_name);
+               return NT_STATUS_NO_MEMORY;
        }
 
-       return status;
-}
+       *r->out.name = lsa_name;
 
-#if 0  /* AD DC work in ongoing in Samba 4 */
+       return NT_STATUS_OK;
+}
 
 /***************************************************************************
+ _lsa_QuerySecurity
  ***************************************************************************/
 
- NTSTATUS _lsa_query_info2(pipes_struct *p, LSA_Q_QUERY_INFO2 *q_u, LSA_R_QUERY_INFO2 *r_u)
+NTSTATUS _lsa_QuerySecurity(struct pipes_struct *p,
+                           struct lsa_QuerySecurity *r)
 {
-       struct lsa_info *handle;
-       const char *nb_name;
-       char *dns_name = NULL;
-       char *forest_name = NULL;
-       DOM_SID *sid = NULL;
-       struct GUID guid;
-       fstring dnsdomname;
-
-       ZERO_STRUCT(guid);
-       r_u->status = NT_STATUS_OK;
+       struct lsa_info *handle=NULL;
+       struct security_descriptor *psd = NULL;
+       size_t sd_size;
+       NTSTATUS status;
 
-       if (!find_policy_by_hnd(p, &q_u->pol, (void **)(void *)&handle))
+       /* find the connection policy handle. */
+       if (!find_policy_by_hnd(p, r->in.handle, (void **)(void *)&handle))
                return NT_STATUS_INVALID_HANDLE;
 
-       switch (q_u->info_class) {
-       case 0x0c:
-               /* check if the user has enough rights */
-               if (!(handle->access & LSA_POLICY_VIEW_LOCAL_INFORMATION))
-                       return NT_STATUS_ACCESS_DENIED;
-
-               /* Request PolicyPrimaryDomainInformation. */
-               switch (lp_server_role()) {
-                       case ROLE_DOMAIN_PDC:
-                       case ROLE_DOMAIN_BDC:
-                               nb_name = get_global_sam_name();
-                               /* ugly temp hack for these next two */
-
-                               /* This should be a 'netbios domain -> DNS domain' mapping */
-                               dnsdomname = get_mydnsdomname(p->mem_ctx);
-                               if (!dnsdomname || !*dnsdomname) {
-                                       return NT_STATUS_CANT_ACCESS_DOMAIN_INFO;
-                               }
-                               strlower_m(dnsdomname);
-
-                               dns_name = dnsdomname;
-                               forest_name = dnsdomname;
-
-                               sid = get_global_sam_sid();
-                               secrets_fetch_domain_guid(lp_workgroup(), &guid);
-                               break;
-                       default:
-                               return NT_STATUS_CANT_ACCESS_DOMAIN_INFO;
-               }
-               init_dns_dom_info(&r_u->info.dns_dom_info, nb_name, dns_name,
-                                 forest_name,&guid,sid);
+       switch (handle->type) {
+       case LSA_HANDLE_POLICY_TYPE:
+               status = make_lsa_object_sd(p->mem_ctx, &psd, &sd_size,
+                               &lsa_policy_mapping, NULL, 0);
+               break;
+       case LSA_HANDLE_ACCOUNT_TYPE:
+               status = make_lsa_object_sd(p->mem_ctx, &psd, &sd_size,
+                               &lsa_account_mapping,
+                               &handle->sid, LSA_ACCOUNT_ALL_ACCESS);
                break;
        default:
-               DEBUG(0,("_lsa_query_info2: unknown info level in Lsa Query: %d\n", q_u->info_class));
-               r_u->status = NT_STATUS_INVALID_INFO_CLASS;
+               status = NT_STATUS_INVALID_HANDLE;
                break;
        }
 
-       if (NT_STATUS_IS_OK(r_u->status)) {
-               r_u->ptr = 0x1;
-               r_u->info_class = q_u->info_class;
+       if (!NT_STATUS_IS_OK(status)) {
+               return status;
        }
 
-       return r_u->status;
+       *r->out.sdbuf = make_sec_desc_buf(p->mem_ctx, sd_size, psd);
+       if (!*r->out.sdbuf) {
+               return NT_STATUS_NO_MEMORY;
+       }
+
+       return status;
 }
-#endif /* AD DC work in ongoing in Samba 4 */
 
 /***************************************************************************
  _lsa_AddAccountRights
  ***************************************************************************/
 
-NTSTATUS _lsa_AddAccountRights(pipes_struct *p,
+NTSTATUS _lsa_AddAccountRights(struct pipes_struct *p,
                               struct lsa_AddAccountRights *r)
 {
        struct lsa_info *info = NULL;
        int i = 0;
-       DOM_SID sid;
+       uint32_t acc_granted = 0;
+       struct security_descriptor *psd = NULL;
+       size_t sd_size;
+       struct dom_sid sid;
+       NTSTATUS status;
 
        /* find the connection policy handle. */
        if (!find_policy_by_hnd(p, r->in.handle, (void **)(void *)&info))
                return NT_STATUS_INVALID_HANDLE;
 
-       /* check to see if the pipe_user is a Domain Admin since
-          account_pol.tdb was already opened as root, this is all we have */
-
-       if ( p->pipe_user.ut.uid != sec_initial_uid()
-               && !nt_token_check_domain_rid( p->pipe_user.nt_user_token, DOMAIN_GROUP_RID_ADMINS ) )
-       {
-               return NT_STATUS_ACCESS_DENIED;
+       if (info->type != LSA_HANDLE_POLICY_TYPE) {
+               return NT_STATUS_INVALID_HANDLE;
        }
 
+        /* get the generic lsa account SD for this SID until we store it */
+        status = make_lsa_object_sd(p->mem_ctx, &psd, &sd_size,
+                                &lsa_account_mapping,
+                                r->in.sid, LSA_ACCOUNT_ALL_ACCESS);
+        if (!NT_STATUS_IS_OK(status)) {
+                return status;
+        }
+
+       /*
+        * From the MS DOCs. If the sid doesn't exist, ask for LSA_POLICY_CREATE_ACCOUNT
+        * on the policy handle. If it does, ask for
+        * LSA_ACCOUNT_ADJUST_PRIVILEGES|LSA_ACCOUNT_ADJUST_SYSTEM_ACCESS|LSA_ACCOUNT_VIEW,
+        * on the account sid. We don't check here so just use the latter. JRA.
+        */
+
+       status = access_check_object(psd, p->server_info->ptok,
+                                    NULL, 0,
+                                    LSA_ACCOUNT_ADJUST_PRIVILEGES|LSA_ACCOUNT_ADJUST_SYSTEM_ACCESS|LSA_ACCOUNT_VIEW,
+                                    &acc_granted, "_lsa_AddAccountRights" );
+        if (!NT_STATUS_IS_OK(status)) {
+                return status;
+        }
+
        /* according to an NT4 PDC, you can add privileges to SIDs even without
           call_lsa_create_account() first.  And you can use any arbitrary SID. */
 
@@ -1962,27 +2225,49 @@ NTSTATUS _lsa_AddAccountRights(pipes_struct *p,
  _lsa_RemoveAccountRights
  ***************************************************************************/
 
-NTSTATUS _lsa_RemoveAccountRights(pipes_struct *p,
+NTSTATUS _lsa_RemoveAccountRights(struct pipes_struct *p,
                                  struct lsa_RemoveAccountRights *r)
 {
        struct lsa_info *info = NULL;
        int i = 0;
-       DOM_SID sid;
+       struct security_descriptor *psd = NULL;
+       size_t sd_size;
+       struct dom_sid sid;
        const char *privname = NULL;
+       uint32_t acc_granted = 0;
+       NTSTATUS status;
 
        /* find the connection policy handle. */
        if (!find_policy_by_hnd(p, r->in.handle, (void **)(void *)&info))
                return NT_STATUS_INVALID_HANDLE;
 
-       /* check to see if the pipe_user is a Domain Admin since
-          account_pol.tdb was already opened as root, this is all we have */
-
-       if ( p->pipe_user.ut.uid != sec_initial_uid()
-               && !nt_token_check_domain_rid( p->pipe_user.nt_user_token, DOMAIN_GROUP_RID_ADMINS ) )
-       {
-               return NT_STATUS_ACCESS_DENIED;
+       if (info->type != LSA_HANDLE_POLICY_TYPE) {
+               return NT_STATUS_INVALID_HANDLE;
        }
 
+        /* get the generic lsa account SD for this SID until we store it */
+        status = make_lsa_object_sd(p->mem_ctx, &psd, &sd_size,
+                                &lsa_account_mapping,
+                                r->in.sid, LSA_ACCOUNT_ALL_ACCESS);
+        if (!NT_STATUS_IS_OK(status)) {
+                return status;
+        }
+
+       /*
+        * From the MS DOCs. We need
+        * LSA_ACCOUNT_ADJUST_PRIVILEGES|LSA_ACCOUNT_ADJUST_SYSTEM_ACCESS|LSA_ACCOUNT_VIEW
+        * and DELETE on the account sid.
+        */
+
+       status = access_check_object(psd, p->server_info->ptok,
+                                    NULL, 0,
+                                    LSA_ACCOUNT_ADJUST_PRIVILEGES|LSA_ACCOUNT_ADJUST_SYSTEM_ACCESS|
+                                    LSA_ACCOUNT_VIEW|SEC_STD_DELETE,
+                                    &acc_granted, "_lsa_RemoveAccountRights");
+        if (!NT_STATUS_IS_OK(status)) {
+                return status;
+        }
+
        sid_copy( &sid, r->in.sid );
 
        if ( r->in.remove_all ) {
@@ -2056,12 +2341,12 @@ static NTSTATUS init_lsa_right_set(TALLOC_CTX *mem_ctx,
  _lsa_EnumAccountRights
  ***************************************************************************/
 
-NTSTATUS _lsa_EnumAccountRights(pipes_struct *p,
+NTSTATUS _lsa_EnumAccountRights(struct pipes_struct *p,
                                struct lsa_EnumAccountRights *r)
 {
        NTSTATUS status;
        struct lsa_info *info = NULL;
-       DOM_SID sid;
+       struct dom_sid sid;
        PRIVILEGE_SET privileges;
        SE_PRIV mask;
 
@@ -2070,25 +2355,38 @@ NTSTATUS _lsa_EnumAccountRights(pipes_struct *p,
        if (!find_policy_by_hnd(p, r->in.handle, (void **)(void *)&info))
                return NT_STATUS_INVALID_HANDLE;
 
+       if (info->type != LSA_HANDLE_POLICY_TYPE) {
+               return NT_STATUS_INVALID_HANDLE;
+       }
+
+       if (!(info->access & LSA_ACCOUNT_VIEW)) {
+               return NT_STATUS_ACCESS_DENIED;
+       }
+
        /* according to an NT4 PDC, you can add privileges to SIDs even without
           call_lsa_create_account() first.  And you can use any arbitrary SID. */
 
        sid_copy( &sid, r->in.sid );
 
-       if ( !get_privileges_for_sids( &mask, &sid, 1 ) )
+       /* according to MS-LSAD 3.1.4.5.10 it is required to return
+        * NT_STATUS_OBJECT_NAME_NOT_FOUND if the account sid was not found in
+        * the lsa database */
+
+       if (!get_privileges_for_sids(&mask, &sid, 1)) {
                return NT_STATUS_OBJECT_NAME_NOT_FOUND;
+       }
 
-       privilege_set_init( &privileges );
+       status = privilege_set_init(&privileges);
+       if (!NT_STATUS_IS_OK(status)) {
+               return status;
+       }
 
-       if ( se_priv_to_privilege_set( &privileges, &mask ) ) {
+       se_priv_to_privilege_set(&privileges, &mask);
 
-               DEBUG(10,("_lsa_EnumAccountRights: %s has %d privileges\n",
-                         sid_string_dbg(&sid), privileges.count));
+       DEBUG(10,("_lsa_EnumAccountRights: %s has %d privileges\n",
+                 sid_string_dbg(&sid), privileges.count));
 
-               status = init_lsa_right_set(p->mem_ctx, r->out.rights, &privileges);
-       } else {
-               status = NT_STATUS_NO_SUCH_PRIVILEGE;
-       }
+       status = init_lsa_right_set(p->mem_ctx, r->out.rights, &privileges);
 
        privilege_set_free( &privileges );
 
@@ -2099,12 +2397,12 @@ NTSTATUS _lsa_EnumAccountRights(pipes_struct *p,
  _lsa_LookupPrivValue
  ***************************************************************************/
 
-NTSTATUS _lsa_LookupPrivValue(pipes_struct *p,
+NTSTATUS _lsa_LookupPrivValue(struct pipes_struct *p,
                              struct lsa_LookupPrivValue *r)
 {
        struct lsa_info *info = NULL;
        const char *name = NULL;
-       LUID_ATTR priv_luid;
+       struct lsa_LUIDAttribute priv_luid;
        SE_PRIV mask;
 
        /* find the connection policy handle. */
@@ -2112,6 +2410,13 @@ NTSTATUS _lsa_LookupPrivValue(pipes_struct *p,
        if (!find_policy_by_hnd(p, r->in.handle, (void **)(void *)&info))
                return NT_STATUS_INVALID_HANDLE;
 
+       if (info->type != LSA_HANDLE_POLICY_TYPE) {
+               return NT_STATUS_INVALID_HANDLE;
+       }
+
+       if (!(info->access & LSA_POLICY_LOOKUP_NAMES))
+               return NT_STATUS_ACCESS_DENIED;
+
        name = r->in.name->string;
 
        DEBUG(10,("_lsa_lookup_priv_value: name = %s\n", name));
@@ -2127,295 +2432,373 @@ NTSTATUS _lsa_LookupPrivValue(pipes_struct *p,
        return NT_STATUS_OK;
 }
 
-/*
- * From here on the server routines are just dummy ones to make smbd link with
- * librpc/gen_ndr/srv_lsa.c. These routines are actually never called, we are
- * pulling the server stubs across one by one.
- */
+/***************************************************************************
+ _lsa_EnumAccountsWithUserRight
+ ***************************************************************************/
 
-NTSTATUS _lsa_Delete(pipes_struct *p, struct lsa_Delete *r)
+NTSTATUS _lsa_EnumAccountsWithUserRight(struct pipes_struct *p,
+                                       struct lsa_EnumAccountsWithUserRight *r)
 {
-       p->rng_fault_state = True;
-       return NT_STATUS_NOT_IMPLEMENTED;
-}
+       NTSTATUS status;
+       struct lsa_info *info = NULL;
+       struct dom_sid *sids = NULL;
+       int num_sids = 0;
+       uint32_t i;
+       SE_PRIV mask;
 
-NTSTATUS _lsa_SetSecObj(pipes_struct *p, struct lsa_SetSecObj *r)
-{
-       p->rng_fault_state = True;
-       return NT_STATUS_NOT_IMPLEMENTED;
-}
+       if (!find_policy_by_hnd(p, r->in.handle, (void **)(void *)&info)) {
+               return NT_STATUS_INVALID_HANDLE;
+       }
 
-NTSTATUS _lsa_ChangePassword(pipes_struct *p, struct lsa_ChangePassword *r)
-{
-       p->rng_fault_state = True;
-       return NT_STATUS_NOT_IMPLEMENTED;
+       if (info->type != LSA_HANDLE_POLICY_TYPE) {
+               return NT_STATUS_INVALID_HANDLE;
+       }
+
+       if (!(info->access & LSA_POLICY_LOOKUP_NAMES)) {
+               return NT_STATUS_ACCESS_DENIED;
+       }
+
+       if (!r->in.name || !r->in.name->string) {
+               return NT_STATUS_NO_SUCH_PRIVILEGE;
+       }
+
+       if (!se_priv_from_name(r->in.name->string, &mask)) {
+               return NT_STATUS_NO_SUCH_PRIVILEGE;
+       }
+
+       status = privilege_enum_sids(&mask, p->mem_ctx,
+                                    &sids, &num_sids);
+       if (!NT_STATUS_IS_OK(status)) {
+               return status;
+       }
+
+       r->out.sids->num_sids = num_sids;
+       r->out.sids->sids = talloc_array(p->mem_ctx, struct lsa_SidPtr,
+                                        r->out.sids->num_sids);
+
+       for (i=0; i < r->out.sids->num_sids; i++) {
+               r->out.sids->sids[i].sid = sid_dup_talloc(r->out.sids->sids,
+                                                         &sids[i]);
+               if (!r->out.sids->sids[i].sid) {
+                       TALLOC_FREE(r->out.sids->sids);
+                       r->out.sids->num_sids = 0;
+                       return NT_STATUS_NO_MEMORY;
+               }
+       }
+
+       return NT_STATUS_OK;
 }
 
-NTSTATUS _lsa_SetInfoPolicy(pipes_struct *p, struct lsa_SetInfoPolicy *r)
+/***************************************************************************
+ _lsa_Delete
+ ***************************************************************************/
+
+NTSTATUS _lsa_Delete(struct pipes_struct *p,
+                    struct lsa_Delete *r)
 {
-       p->rng_fault_state = True;
-       return NT_STATUS_NOT_IMPLEMENTED;
+       return NT_STATUS_NOT_SUPPORTED;
 }
 
-NTSTATUS _lsa_ClearAuditLog(pipes_struct *p, struct lsa_ClearAuditLog *r)
+/*
+ * From here on the server routines are just dummy ones to make smbd link with
+ * librpc/gen_ndr/srv_lsa.c. These routines are actually never called, we are
+ * pulling the server stubs across one by one.
+ */
+
+NTSTATUS _lsa_SetSecObj(struct pipes_struct *p, struct lsa_SetSecObj *r)
 {
        p->rng_fault_state = True;
        return NT_STATUS_NOT_IMPLEMENTED;
 }
 
-NTSTATUS _lsa_GetQuotasForAccount(pipes_struct *p, struct lsa_GetQuotasForAccount *r)
+NTSTATUS _lsa_ChangePassword(struct pipes_struct *p,
+                            struct lsa_ChangePassword *r)
 {
        p->rng_fault_state = True;
        return NT_STATUS_NOT_IMPLEMENTED;
 }
 
-NTSTATUS _lsa_SetQuotasForAccount(pipes_struct *p, struct lsa_SetQuotasForAccount *r)
+NTSTATUS _lsa_SetInfoPolicy(struct pipes_struct *p, struct lsa_SetInfoPolicy *r)
 {
        p->rng_fault_state = True;
        return NT_STATUS_NOT_IMPLEMENTED;
 }
 
-NTSTATUS _lsa_QueryTrustedDomainInfo(pipes_struct *p, struct lsa_QueryTrustedDomainInfo *r)
+NTSTATUS _lsa_ClearAuditLog(struct pipes_struct *p, struct lsa_ClearAuditLog *r)
 {
        p->rng_fault_state = True;
        return NT_STATUS_NOT_IMPLEMENTED;
 }
 
-NTSTATUS _lsa_SetInformationTrustedDomain(pipes_struct *p, struct lsa_SetInformationTrustedDomain *r)
+NTSTATUS _lsa_GetQuotasForAccount(struct pipes_struct *p,
+                                 struct lsa_GetQuotasForAccount *r)
 {
        p->rng_fault_state = True;
        return NT_STATUS_NOT_IMPLEMENTED;
 }
 
-NTSTATUS _lsa_QuerySecret(pipes_struct *p, struct lsa_QuerySecret *r)
+NTSTATUS _lsa_SetQuotasForAccount(struct pipes_struct *p,
+                                 struct lsa_SetQuotasForAccount *r)
 {
        p->rng_fault_state = True;
        return NT_STATUS_NOT_IMPLEMENTED;
 }
 
-NTSTATUS _lsa_LookupPrivName(pipes_struct *p, struct lsa_LookupPrivName *r)
+NTSTATUS _lsa_QueryTrustedDomainInfo(struct pipes_struct *p,
+                                    struct lsa_QueryTrustedDomainInfo *r)
 {
        p->rng_fault_state = True;
        return NT_STATUS_NOT_IMPLEMENTED;
 }
 
-NTSTATUS _lsa_EnumAccountsWithUserRight(pipes_struct *p, struct lsa_EnumAccountsWithUserRight *r)
+NTSTATUS _lsa_SetInformationTrustedDomain(struct pipes_struct *p,
+                                         struct lsa_SetInformationTrustedDomain *r)
 {
        p->rng_fault_state = True;
        return NT_STATUS_NOT_IMPLEMENTED;
 }
 
-NTSTATUS _lsa_QueryTrustedDomainInfoBySid(pipes_struct *p, struct lsa_QueryTrustedDomainInfoBySid *r)
+NTSTATUS _lsa_QuerySecret(struct pipes_struct *p, struct lsa_QuerySecret *r)
 {
        p->rng_fault_state = True;
        return NT_STATUS_NOT_IMPLEMENTED;
 }
 
-NTSTATUS _lsa_SetTrustedDomainInfo(pipes_struct *p, struct lsa_SetTrustedDomainInfo *r)
+NTSTATUS _lsa_QueryTrustedDomainInfoBySid(struct pipes_struct *p,
+                                         struct lsa_QueryTrustedDomainInfoBySid *r)
 {
        p->rng_fault_state = True;
        return NT_STATUS_NOT_IMPLEMENTED;
 }
 
-NTSTATUS _lsa_DeleteTrustedDomain(pipes_struct *p, struct lsa_DeleteTrustedDomain *r)
+NTSTATUS _lsa_SetTrustedDomainInfo(struct pipes_struct *p,
+                                  struct lsa_SetTrustedDomainInfo *r)
 {
        p->rng_fault_state = True;
        return NT_STATUS_NOT_IMPLEMENTED;
 }
 
-NTSTATUS _lsa_StorePrivateData(pipes_struct *p, struct lsa_StorePrivateData *r)
+NTSTATUS _lsa_DeleteTrustedDomain(struct pipes_struct *p,
+                                 struct lsa_DeleteTrustedDomain *r)
 {
        p->rng_fault_state = True;
        return NT_STATUS_NOT_IMPLEMENTED;
 }
 
-NTSTATUS _lsa_RetrievePrivateData(pipes_struct *p, struct lsa_RetrievePrivateData *r)
+NTSTATUS _lsa_StorePrivateData(struct pipes_struct *p,
+                              struct lsa_StorePrivateData *r)
 {
        p->rng_fault_state = True;
        return NT_STATUS_NOT_IMPLEMENTED;
 }
 
-NTSTATUS _lsa_QueryInfoPolicy2(pipes_struct *p, struct lsa_QueryInfoPolicy2 *r)
+NTSTATUS _lsa_RetrievePrivateData(struct pipes_struct *p,
+                                 struct lsa_RetrievePrivateData *r)
 {
        p->rng_fault_state = True;
        return NT_STATUS_NOT_IMPLEMENTED;
 }
 
-NTSTATUS _lsa_SetInfoPolicy2(pipes_struct *p, struct lsa_SetInfoPolicy2 *r)
+NTSTATUS _lsa_SetInfoPolicy2(struct pipes_struct *p,
+                            struct lsa_SetInfoPolicy2 *r)
 {
        p->rng_fault_state = True;
        return NT_STATUS_NOT_IMPLEMENTED;
 }
 
-NTSTATUS _lsa_QueryTrustedDomainInfoByName(pipes_struct *p, struct lsa_QueryTrustedDomainInfoByName *r)
+NTSTATUS _lsa_QueryTrustedDomainInfoByName(struct pipes_struct *p,
+                                          struct lsa_QueryTrustedDomainInfoByName *r)
 {
        p->rng_fault_state = True;
        return NT_STATUS_NOT_IMPLEMENTED;
 }
 
-NTSTATUS _lsa_SetTrustedDomainInfoByName(pipes_struct *p, struct lsa_SetTrustedDomainInfoByName *r)
+NTSTATUS _lsa_SetTrustedDomainInfoByName(struct pipes_struct *p,
+                                        struct lsa_SetTrustedDomainInfoByName *r)
 {
        p->rng_fault_state = True;
        return NT_STATUS_NOT_IMPLEMENTED;
 }
 
-NTSTATUS _lsa_EnumTrustedDomainsEx(pipes_struct *p, struct lsa_EnumTrustedDomainsEx *r)
+NTSTATUS _lsa_EnumTrustedDomainsEx(struct pipes_struct *p,
+                                  struct lsa_EnumTrustedDomainsEx *r)
 {
        p->rng_fault_state = True;
        return NT_STATUS_NOT_IMPLEMENTED;
 }
 
-NTSTATUS _lsa_CreateTrustedDomainEx(pipes_struct *p, struct lsa_CreateTrustedDomainEx *r)
+NTSTATUS _lsa_CreateTrustedDomainEx(struct pipes_struct *p,
+                                   struct lsa_CreateTrustedDomainEx *r)
 {
        p->rng_fault_state = True;
        return NT_STATUS_NOT_IMPLEMENTED;
 }
 
-NTSTATUS _lsa_CloseTrustedDomainEx(pipes_struct *p, struct lsa_CloseTrustedDomainEx *r)
+NTSTATUS _lsa_CloseTrustedDomainEx(struct pipes_struct *p,
+                                  struct lsa_CloseTrustedDomainEx *r)
 {
        p->rng_fault_state = True;
        return NT_STATUS_NOT_IMPLEMENTED;
 }
 
-NTSTATUS _lsa_QueryDomainInformationPolicy(pipes_struct *p, struct lsa_QueryDomainInformationPolicy *r)
+NTSTATUS _lsa_QueryDomainInformationPolicy(struct pipes_struct *p,
+                                          struct lsa_QueryDomainInformationPolicy *r)
 {
        p->rng_fault_state = True;
        return NT_STATUS_NOT_IMPLEMENTED;
 }
 
-NTSTATUS _lsa_SetDomainInformationPolicy(pipes_struct *p, struct lsa_SetDomainInformationPolicy *r)
+NTSTATUS _lsa_SetDomainInformationPolicy(struct pipes_struct *p,
+                                        struct lsa_SetDomainInformationPolicy *r)
 {
        p->rng_fault_state = True;
        return NT_STATUS_NOT_IMPLEMENTED;
 }
 
-NTSTATUS _lsa_OpenTrustedDomainByName(pipes_struct *p, struct lsa_OpenTrustedDomainByName *r)
+NTSTATUS _lsa_OpenTrustedDomainByName(struct pipes_struct *p,
+                                     struct lsa_OpenTrustedDomainByName *r)
 {
        p->rng_fault_state = True;
        return NT_STATUS_NOT_IMPLEMENTED;
 }
 
-NTSTATUS _lsa_TestCall(pipes_struct *p, struct lsa_TestCall *r)
+NTSTATUS _lsa_TestCall(struct pipes_struct *p, struct lsa_TestCall *r)
 {
        p->rng_fault_state = True;
        return NT_STATUS_NOT_IMPLEMENTED;
 }
 
-NTSTATUS _lsa_CreateTrustedDomainEx2(pipes_struct *p, struct lsa_CreateTrustedDomainEx2 *r)
+NTSTATUS _lsa_CreateTrustedDomainEx2(struct pipes_struct *p,
+                                    struct lsa_CreateTrustedDomainEx2 *r)
 {
        p->rng_fault_state = True;
        return NT_STATUS_NOT_IMPLEMENTED;
 }
 
-NTSTATUS _lsa_CREDRWRITE(pipes_struct *p, struct lsa_CREDRWRITE *r)
+NTSTATUS _lsa_CREDRWRITE(struct pipes_struct *p, struct lsa_CREDRWRITE *r)
 {
        p->rng_fault_state = True;
        return NT_STATUS_NOT_IMPLEMENTED;
 }
 
-NTSTATUS _lsa_CREDRREAD(pipes_struct *p, struct lsa_CREDRREAD *r)
+NTSTATUS _lsa_CREDRREAD(struct pipes_struct *p, struct lsa_CREDRREAD *r)
 {
        p->rng_fault_state = True;
        return NT_STATUS_NOT_IMPLEMENTED;
 }
 
-NTSTATUS _lsa_CREDRENUMERATE(pipes_struct *p, struct lsa_CREDRENUMERATE *r)
+NTSTATUS _lsa_CREDRENUMERATE(struct pipes_struct *p, struct lsa_CREDRENUMERATE *r)
 {
        p->rng_fault_state = True;
        return NT_STATUS_NOT_IMPLEMENTED;
 }
 
-NTSTATUS _lsa_CREDRWRITEDOMAINCREDENTIALS(pipes_struct *p, struct lsa_CREDRWRITEDOMAINCREDENTIALS *r)
+NTSTATUS _lsa_CREDRWRITEDOMAINCREDENTIALS(struct pipes_struct *p,
+                                         struct lsa_CREDRWRITEDOMAINCREDENTIALS *r)
 {
        p->rng_fault_state = True;
        return NT_STATUS_NOT_IMPLEMENTED;
 }
 
-NTSTATUS _lsa_CREDRREADDOMAINCREDENTIALS(pipes_struct *p, struct lsa_CREDRREADDOMAINCREDENTIALS *r)
+NTSTATUS _lsa_CREDRREADDOMAINCREDENTIALS(struct pipes_struct *p,
+                                        struct lsa_CREDRREADDOMAINCREDENTIALS *r)
 {
        p->rng_fault_state = True;
        return NT_STATUS_NOT_IMPLEMENTED;
 }
 
-NTSTATUS _lsa_CREDRDELETE(pipes_struct *p, struct lsa_CREDRDELETE *r)
+NTSTATUS _lsa_CREDRDELETE(struct pipes_struct *p, struct lsa_CREDRDELETE *r)
 {
        p->rng_fault_state = True;
        return NT_STATUS_NOT_IMPLEMENTED;
 }
 
-NTSTATUS _lsa_CREDRGETTARGETINFO(pipes_struct *p, struct lsa_CREDRGETTARGETINFO *r)
+NTSTATUS _lsa_CREDRGETTARGETINFO(struct pipes_struct *p,
+                                struct lsa_CREDRGETTARGETINFO *r)
 {
        p->rng_fault_state = True;
        return NT_STATUS_NOT_IMPLEMENTED;
 }
 
-NTSTATUS _lsa_CREDRPROFILELOADED(pipes_struct *p, struct lsa_CREDRPROFILELOADED *r)
+NTSTATUS _lsa_CREDRPROFILELOADED(struct pipes_struct *p,
+                                struct lsa_CREDRPROFILELOADED *r)
 {
        p->rng_fault_state = True;
        return NT_STATUS_NOT_IMPLEMENTED;
 }
 
-NTSTATUS _lsa_CREDRGETSESSIONTYPES(pipes_struct *p, struct lsa_CREDRGETSESSIONTYPES *r)
+NTSTATUS _lsa_CREDRGETSESSIONTYPES(struct pipes_struct *p,
+                                  struct lsa_CREDRGETSESSIONTYPES *r)
 {
        p->rng_fault_state = True;
        return NT_STATUS_NOT_IMPLEMENTED;
 }
 
-NTSTATUS _lsa_LSARREGISTERAUDITEVENT(pipes_struct *p, struct lsa_LSARREGISTERAUDITEVENT *r)
+NTSTATUS _lsa_LSARREGISTERAUDITEVENT(struct pipes_struct *p,
+                                    struct lsa_LSARREGISTERAUDITEVENT *r)
 {
        p->rng_fault_state = True;
        return NT_STATUS_NOT_IMPLEMENTED;
 }
 
-NTSTATUS _lsa_LSARGENAUDITEVENT(pipes_struct *p, struct lsa_LSARGENAUDITEVENT *r)
+NTSTATUS _lsa_LSARGENAUDITEVENT(struct pipes_struct *p,
+                               struct lsa_LSARGENAUDITEVENT *r)
 {
        p->rng_fault_state = True;
        return NT_STATUS_NOT_IMPLEMENTED;
 }
 
-NTSTATUS _lsa_LSARUNREGISTERAUDITEVENT(pipes_struct *p, struct lsa_LSARUNREGISTERAUDITEVENT *r)
+NTSTATUS _lsa_LSARUNREGISTERAUDITEVENT(struct pipes_struct *p,
+                                      struct lsa_LSARUNREGISTERAUDITEVENT *r)
 {
        p->rng_fault_state = True;
        return NT_STATUS_NOT_IMPLEMENTED;
 }
 
-NTSTATUS _lsa_lsaRQueryForestTrustInformation(pipes_struct *p, struct lsa_lsaRQueryForestTrustInformation *r)
+NTSTATUS _lsa_lsaRQueryForestTrustInformation(struct pipes_struct *p,
+                                             struct lsa_lsaRQueryForestTrustInformation *r)
 {
        p->rng_fault_state = True;
        return NT_STATUS_NOT_IMPLEMENTED;
 }
 
-NTSTATUS _lsa_LSARSETFORESTTRUSTINFORMATION(pipes_struct *p, struct lsa_LSARSETFORESTTRUSTINFORMATION *r)
+NTSTATUS _lsa_lsaRSetForestTrustInformation(struct pipes_struct *p,
+                                           struct lsa_lsaRSetForestTrustInformation *r)
 {
        p->rng_fault_state = True;
        return NT_STATUS_NOT_IMPLEMENTED;
 }
 
-NTSTATUS _lsa_CREDRRENAME(pipes_struct *p, struct lsa_CREDRRENAME *r)
+NTSTATUS _lsa_CREDRRENAME(struct pipes_struct *p,
+                         struct lsa_CREDRRENAME *r)
 {
        p->rng_fault_state = True;
        return NT_STATUS_NOT_IMPLEMENTED;
 }
 
-NTSTATUS _lsa_LSAROPENPOLICYSCE(pipes_struct *p, struct lsa_LSAROPENPOLICYSCE *r)
+NTSTATUS _lsa_LSAROPENPOLICYSCE(struct pipes_struct *p,
+                               struct lsa_LSAROPENPOLICYSCE *r)
 {
        p->rng_fault_state = True;
        return NT_STATUS_NOT_IMPLEMENTED;
 }
 
-NTSTATUS _lsa_LSARADTREGISTERSECURITYEVENTSOURCE(pipes_struct *p, struct lsa_LSARADTREGISTERSECURITYEVENTSOURCE *r)
+NTSTATUS _lsa_LSARADTREGISTERSECURITYEVENTSOURCE(struct pipes_struct *p,
+                                                struct lsa_LSARADTREGISTERSECURITYEVENTSOURCE *r)
 {
        p->rng_fault_state = True;
        return NT_STATUS_NOT_IMPLEMENTED;
 }
 
-NTSTATUS _lsa_LSARADTUNREGISTERSECURITYEVENTSOURCE(pipes_struct *p, struct lsa_LSARADTUNREGISTERSECURITYEVENTSOURCE *r)
+NTSTATUS _lsa_LSARADTUNREGISTERSECURITYEVENTSOURCE(struct pipes_struct *p,
+                                                  struct lsa_LSARADTUNREGISTERSECURITYEVENTSOURCE *r)
 {
        p->rng_fault_state = True;
        return NT_STATUS_NOT_IMPLEMENTED;
 }
 
-NTSTATUS _lsa_LSARADTREPORTSECURITYEVENT(pipes_struct *p, struct lsa_LSARADTREPORTSECURITYEVENT *r)
+NTSTATUS _lsa_LSARADTREPORTSECURITYEVENT(struct pipes_struct *p,
+                                        struct lsa_LSARADTREPORTSECURITYEVENT *r)
 {
        p->rng_fault_state = True;
        return NT_STATUS_NOT_IMPLEMENTED;