RIP BOOL. Convert BOOL -> bool. I found a few interesting
[nivanova/samba-autobuild/.git] / source3 / printing / print_cups.c
index b5315e10b2867d37cf068bd253a72cc590e276a0..e9e4e5955f4a6c85af1d6ed0db58fef0d8c0c3be 100644 (file)
@@ -1,11 +1,11 @@
 /*
  * Support code for the Common UNIX Printing System ("CUPS")
  *
- * Copyright 1999-2001 by Michael R Sweet.
+ * Copyright 1999-2003 by Michael R Sweet.
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
+ * the Free Software Foundation; either version 3 of the License, or
  * (at your option) any later version.
  * 
  * This program is distributed in the hope that it will be useful,
  * GNU General Public License for more details.
  * 
  * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+ * along with this program; if not, see <http://www.gnu.org/licenses/>.
  */
 
+#include "includes.h"
 #include "printing.h"
-#include "smb.h"
 
 #ifdef HAVE_CUPS
 #include <cups/cups.h>
 #include <cups/language.h>
 
-
-/*
- * CUPS printing interface definitions...
- */
-
-static int cups_job_delete(int snum, struct printjob *pjob);
-static int cups_job_pause(int snum, struct printjob *pjob);
-static int cups_job_resume(int snum, struct printjob *pjob);
-static int cups_job_submit(int snum, struct printjob *pjob);
-static int cups_queue_get(int snum, print_queue_struct **q,
-                          print_status_struct *status);
-static int cups_queue_pause(int snum);
-static int cups_queue_resume(int snum);
-
-
-struct printif cups_printif =
-               {
-                 cups_queue_get,
-                 cups_queue_pause,
-                 cups_queue_resume,
-                 cups_job_delete,
-                 cups_job_pause,
-                 cups_job_resume,
-                 cups_job_submit,
-               };
+extern userdom_struct current_user_info;
 
 /*
  * 'cups_passwd_cb()' - The CUPS password callback...
  */
 
-const char *                           /* O - Password or NULL */
+static const char *                            /* O - Password or NULL */
 cups_passwd_cb(const char *prompt)     /* I - Prompt */
 {
- /*
-  * Always return NULL to indicate that no password is available...
-  */
-
-  (void)prompt;
+       /*
+        * Always return NULL to indicate that no password is available...
+        */
 
-  return (NULL);
+       return (NULL);
 }
 
+static http_t *cups_connect(void)
+{
+       http_t *http;
+       char *server, *p;
+       int port;
+       
+       if (lp_cups_server() != NULL && strlen(lp_cups_server()) > 0) {
+               server = smb_xstrdup(lp_cups_server());
+       } else {
+               server = smb_xstrdup(cupsServer());
+       }
 
-/*
- * 'cups_printer_fn()' - Call a function for every printer known to the
- *                       system.
- */
+       p = strchr(server, ':');
+       if (p) {
+               port = atoi(p+1);
+               *p = '\0';
+       } else {
+               port = ippPort();
+       }
+       
+       DEBUG(10, ("connecting to cups server %s:%d\n",
+                  server, port));
+
+       if ((http = httpConnect(server, port)) == NULL) {
+               DEBUG(0,("Unable to connect to CUPS server %s:%d - %s\n", 
+                        server, port, strerror(errno)));
+               SAFE_FREE(server);
+               return NULL;
+       }
+
+       SAFE_FREE(server);
+       return http;
+}
 
-void
-cups_printer_fn(void (*fn)(char *, char *))    /* I - Function to call */
+bool cups_cache_reload(void)
 {
-       http_t          *http;          /* HTTP connection to server */
-       ipp_t           *request,       /* IPP Request */
-                       *response;      /* IPP Response */
+       http_t          *http = NULL;           /* HTTP connection to server */
+       ipp_t           *request = NULL,        /* IPP Request */
+                       *response = NULL;       /* IPP Response */
        ipp_attribute_t *attr;          /* Current attribute */
-       cups_lang_t     *language;      /* Default language */
+       cups_lang_t     *language = NULL;       /* Default language */
        char            *name,          /* printer-name attribute */
-                       *make_model,    /* printer-make-and-model attribute */
                        *info;          /* printer-info attribute */
        static const char *requested[] =/* Requested attributes */
                        {
                          "printer-name",
-                         "printer-make-and-model",
                          "printer-info"
                        };       
+       bool ret = False;
 
-
-       DEBUG(5,("cups_printer_fn(%p)\n", fn));
+       DEBUG(5, ("reloading cups printcap cache\n"));
 
        /*
         * Make sure we don't ask for passwords...
@@ -104,11 +102,8 @@ cups_printer_fn(void (*fn)(char *, char *))        /* I - Function to call */
        * Try to connect to the server...
        */
 
-       if ((http = httpConnect(cupsServer(), ippPort())) == NULL)
-       {
-               DEBUG(0,("Unable to connect to CUPS server %s - %s\n", 
-                        cupsServer(), strerror(errno)));
-               return;
+       if ((http = cups_connect()) == NULL) {
+               goto out;
        }
 
        /*
@@ -142,16 +137,13 @@ cups_printer_fn(void (*fn)(char *, char *))       /* I - Function to call */
        * Do the request and get back a response...
        */
 
-       if ((response = cupsDoRequest(http, request, "/")) == NULL)
-       {
+       if ((response = cupsDoRequest(http, request, "/")) == NULL) {
                DEBUG(0,("Unable to get printer list - %s\n",
                         ippErrorString(cupsLastError())));
-               httpClose(http);
-               return;
+               goto out;
        }
 
-       for (attr = response->attrs; attr != NULL;)
-       {
+       for (attr = response->attrs; attr != NULL;) {
               /*
                * Skip leading attributes until we hit a printer...
                */
@@ -167,19 +159,13 @@ cups_printer_fn(void (*fn)(char *, char *))       /* I - Function to call */
                */
 
                name       = NULL;
-               make_model = NULL;
                info       = NULL;
 
-               while (attr != NULL && attr->group_tag == IPP_TAG_PRINTER)
-               {
+               while (attr != NULL && attr->group_tag == IPP_TAG_PRINTER) {
                        if (strcmp(attr->name, "printer-name") == 0 &&
                            attr->value_tag == IPP_TAG_NAME)
                                name = attr->values[0].string.text;
 
-                       if (strcmp(attr->name, "printer-make-and-model") == 0 &&
-                           attr->value_tag == IPP_TAG_TEXT)
-                               make_model = attr->values[0].string.text;
-
                        if (strcmp(attr->name, "printer-info") == 0 &&
                            attr->value_tag == IPP_TAG_TEXT)
                                info = attr->values[0].string.text;
@@ -194,110 +180,104 @@ cups_printer_fn(void (*fn)(char *, char *))     /* I - Function to call */
                if (name == NULL)
                        break;
 
-               if (info == NULL || !info[0])
-                       (*fn)(name, make_model);
-               else
-                       (*fn)(name,info);
-               
-
+               if (!pcap_cache_add(name, info)) {
+                       goto out;
+               }
        }
 
        ippDelete(response);
-       httpClose(http);
-}
-
-
-/*
- * 'cups_printername_ok()' - Provide the equivalent of pcap_printername_ok()
- *                           for CUPS.
- */
-
-int                                    /* O - 1 if printer name OK */
-cups_printername_ok(char *name)                /* I - Name of printer */
-{
-       http_t          *http;          /* HTTP connection to server */
-       ipp_t           *request,       /* IPP Request */
-                       *response;      /* IPP Response */
-       cups_lang_t     *language;      /* Default language */
-       char            uri[HTTP_MAX_URI]; /* printer-uri attribute */
-
-
-       DEBUG(5,("cups_printername_ok(\"%s\")\n", name));
+       response = NULL;
 
        /*
-        * Make sure we don't ask for passwords...
-       */
-
-        cupsSetPasswordCB(cups_passwd_cb);
-
-       /*
-       * Try to connect to the server...
-       */
-
-       if ((http = httpConnect(cupsServer(), ippPort())) == NULL)
-       {
-               DEBUG(0,("Unable to connect to CUPS server %s - %s\n", 
-                        cupsServer(), strerror(errno)));
-               return (0);
-       }
-
-       /*
-       * Build an IPP_GET_PRINTER_ATTRS request, which requires the following
+       * Build a CUPS_GET_CLASSES request, which requires the following
        * attributes:
        *
        *    attributes-charset
        *    attributes-natural-language
        *    requested-attributes
-       *    printer-uri
        */
 
        request = ippNew();
 
-       request->request.op.operation_id = IPP_GET_PRINTER_ATTRIBUTES;
+       request->request.op.operation_id = CUPS_GET_CLASSES;
        request->request.op.request_id   = 1;
 
-       language = cupsLangDefault();
-
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_CHARSET,
                      "attributes-charset", NULL, cupsLangEncoding(language));
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_LANGUAGE,
                      "attributes-natural-language", NULL, language->language);
 
-       ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_NAME,
-                     "requested-attributes", NULL, "printer-uri");
-
-       slprintf(uri, sizeof(uri) - 1, "ipp://localhost/printers/%s", name);
-
-       ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_URI,
-                     "printer-uri", NULL, uri);
+        ippAddStrings(request, IPP_TAG_OPERATION, IPP_TAG_NAME,
+                     "requested-attributes",
+                     (sizeof(requested) / sizeof(requested[0])),
+                     NULL, requested);
 
        /*
        * Do the request and get back a response...
        */
 
-       if ((response = cupsDoRequest(http, request, "/")) == NULL)
-       {
-               DEBUG(0,("Unable to get printer status for %s - %s\n", name,
+       if ((response = cupsDoRequest(http, request, "/")) == NULL) {
+               DEBUG(0,("Unable to get printer list - %s\n",
                         ippErrorString(cupsLastError())));
-               httpClose(http);
-               return (0);
+               goto out;
        }
 
-       httpClose(http);
+       for (attr = response->attrs; attr != NULL;) {
+              /*
+               * Skip leading attributes until we hit a printer...
+               */
 
-       if (response->request.status.status_code >= IPP_OK_CONFLICT)
-       {
-               DEBUG(0,("Unable to get printer status for %s - %s\n", name,
-                        ippErrorString(response->request.status.status_code)));
-               ippDelete(response);
-               return (0);
+               while (attr != NULL && attr->group_tag != IPP_TAG_PRINTER)
+                       attr = attr->next;
+
+               if (attr == NULL)
+                       break;
+
+              /*
+               * Pull the needed attributes from this printer...
+               */
+
+               name       = NULL;
+               info       = NULL;
+
+               while (attr != NULL && attr->group_tag == IPP_TAG_PRINTER) {
+                       if (strcmp(attr->name, "printer-name") == 0 &&
+                           attr->value_tag == IPP_TAG_NAME)
+                               name = attr->values[0].string.text;
+
+                       if (strcmp(attr->name, "printer-info") == 0 &&
+                           attr->value_tag == IPP_TAG_TEXT)
+                               info = attr->values[0].string.text;
+
+                       attr = attr->next;
+               }
+
+              /*
+               * See if we have everything needed...
+               */
+
+               if (name == NULL)
+                       break;
+
+               if (!pcap_cache_add(name, info)) {
+                       goto out;
+               }
        }
-       else
-       {
+
+       ret = True;
+
+ out:
+       if (response)
                ippDelete(response);
-               return (1);
-       }
+
+       if (language)
+               cupsLangFree(language);
+
+       if (http)
+               httpClose(http);
+
+       return ret;
 }
 
 
@@ -305,18 +285,17 @@ cups_printername_ok(char *name)           /* I - Name of printer */
  * 'cups_job_delete()' - Delete a job.
  */
 
-static int
-cups_job_delete(int snum, struct printjob *pjob)
+static int cups_job_delete(const char *sharename, const char *lprm_command, struct printjob *pjob)
 {
-       int             ret;            /* Return value */
-       http_t          *http;          /* HTTP connection to server */
-       ipp_t           *request,       /* IPP Request */
-                       *response;      /* IPP Response */
-       cups_lang_t     *language;      /* Default language */
+       int             ret = 1;                /* Return value */
+       http_t          *http = NULL;           /* HTTP connection to server */
+       ipp_t           *request = NULL,        /* IPP Request */
+                       *response = NULL;       /* IPP Response */
+       cups_lang_t     *language = NULL;       /* Default language */
        char            uri[HTTP_MAX_URI]; /* printer-uri attribute */
 
 
-       DEBUG(5,("cups_job_delete(%d, %p (%d))\n", snum, pjob, pjob->sysjob));
+       DEBUG(5,("cups_job_delete(%s, %p (%d))\n", sharename, pjob, pjob->sysjob));
 
        /*
         * Make sure we don't ask for passwords...
@@ -328,11 +307,8 @@ cups_job_delete(int snum, struct printjob *pjob)
        * Try to connect to the server...
        */
 
-       if ((http = httpConnect(cupsServer(), ippPort())) == NULL)
-       {
-               DEBUG(0,("Unable to connect to CUPS server %s - %s\n", 
-                        cupsServer(), strerror(errno)));
-               return (1);
+       if ((http = cups_connect()) == NULL) {
+               goto out;
        }
 
        /*
@@ -369,25 +345,29 @@ cups_job_delete(int snum, struct printjob *pjob)
        * Do the request and get back a response...
        */
 
-        ret = 1;
-
-       if ((response = cupsDoRequest(http, request, "/jobs")) != NULL)
-       {
-         if (response->request.status.status_code >= IPP_OK_CONFLICT)
+       if ((response = cupsDoRequest(http, request, "/jobs")) != NULL) {
+               if (response->request.status.status_code >= IPP_OK_CONFLICT) {
+                       DEBUG(0,("Unable to cancel job %d - %s\n", pjob->sysjob,
+                               ippErrorString(cupsLastError())));
+               } else {
+                       ret = 0;
+               }
+       } else {
                DEBUG(0,("Unable to cancel job %d - %s\n", pjob->sysjob,
-                        ippErrorString(cupsLastError())));
-          else
-               ret = 0;
-
-         ippDelete(response);
+                       ippErrorString(cupsLastError())));
        }
-       else
-         DEBUG(0,("Unable to cancel job %d - %s\n", pjob->sysjob,
-                  ippErrorString(cupsLastError())));
 
-       httpClose(http);
+ out:
+       if (response)
+               ippDelete(response);
 
-       return (ret);
+       if (language)
+               cupsLangFree(language);
+
+       if (http)
+               httpClose(http);
+
+       return ret;
 }
 
 
@@ -395,14 +375,13 @@ cups_job_delete(int snum, struct printjob *pjob)
  * 'cups_job_pause()' - Pause a job.
  */
 
-static int
-cups_job_pause(int snum, struct printjob *pjob)
+static int cups_job_pause(int snum, struct printjob *pjob)
 {
-       int             ret;            /* Return value */
-       http_t          *http;          /* HTTP connection to server */
-       ipp_t           *request,       /* IPP Request */
-                       *response;      /* IPP Response */
-       cups_lang_t     *language;      /* Default language */
+       int             ret = 1;                /* Return value */
+       http_t          *http = NULL;           /* HTTP connection to server */
+       ipp_t           *request = NULL,        /* IPP Request */
+                       *response = NULL;       /* IPP Response */
+       cups_lang_t     *language = NULL;       /* Default language */
        char            uri[HTTP_MAX_URI]; /* printer-uri attribute */
 
 
@@ -418,11 +397,8 @@ cups_job_pause(int snum, struct printjob *pjob)
        * Try to connect to the server...
        */
 
-       if ((http = httpConnect(cupsServer(), ippPort())) == NULL)
-       {
-               DEBUG(0,("Unable to connect to CUPS server %s - %s\n", 
-                        cupsServer(), strerror(errno)));
-               return (1);
+       if ((http = cups_connect()) == NULL) {
+               goto out;
        }
 
        /*
@@ -459,25 +435,29 @@ cups_job_pause(int snum, struct printjob *pjob)
        * Do the request and get back a response...
        */
 
-        ret = 1;
-
-       if ((response = cupsDoRequest(http, request, "/jobs")) != NULL)
-       {
-         if (response->request.status.status_code >= IPP_OK_CONFLICT)
+       if ((response = cupsDoRequest(http, request, "/jobs")) != NULL) {
+               if (response->request.status.status_code >= IPP_OK_CONFLICT) {
+                       DEBUG(0,("Unable to hold job %d - %s\n", pjob->sysjob,
+                               ippErrorString(cupsLastError())));
+               } else {
+                       ret = 0;
+               }
+       } else {
                DEBUG(0,("Unable to hold job %d - %s\n", pjob->sysjob,
-                        ippErrorString(cupsLastError())));
-          else
-               ret = 0;
-
-         ippDelete(response);
+                       ippErrorString(cupsLastError())));
        }
-       else
-         DEBUG(0,("Unable to hold job %d - %s\n", pjob->sysjob,
-                  ippErrorString(cupsLastError())));
 
-       httpClose(http);
+ out:
+       if (response)
+               ippDelete(response);
 
-       return (ret);
+       if (language)
+               cupsLangFree(language);
+
+       if (http)
+               httpClose(http);
+
+       return ret;
 }
 
 
@@ -485,14 +465,13 @@ cups_job_pause(int snum, struct printjob *pjob)
  * 'cups_job_resume()' - Resume a paused job.
  */
 
-static int
-cups_job_resume(int snum, struct printjob *pjob)
+static int cups_job_resume(int snum, struct printjob *pjob)
 {
-       int             ret;            /* Return value */
-       http_t          *http;          /* HTTP connection to server */
-       ipp_t           *request,       /* IPP Request */
-                       *response;      /* IPP Response */
-       cups_lang_t     *language;      /* Default language */
+       int             ret = 1;                /* Return value */
+       http_t          *http = NULL;           /* HTTP connection to server */
+       ipp_t           *request = NULL,        /* IPP Request */
+                       *response = NULL;       /* IPP Response */
+       cups_lang_t     *language = NULL;       /* Default language */
        char            uri[HTTP_MAX_URI]; /* printer-uri attribute */
 
 
@@ -508,11 +487,8 @@ cups_job_resume(int snum, struct printjob *pjob)
        * Try to connect to the server...
        */
 
-       if ((http = httpConnect(cupsServer(), ippPort())) == NULL)
-       {
-               DEBUG(0,("Unable to connect to CUPS server %s - %s\n", 
-                        cupsServer(), strerror(errno)));
-               return (1);
+       if ((http = cups_connect()) == NULL) {
+               goto out;
        }
 
        /*
@@ -549,25 +525,29 @@ cups_job_resume(int snum, struct printjob *pjob)
        * Do the request and get back a response...
        */
 
-        ret = 1;
-
-       if ((response = cupsDoRequest(http, request, "/jobs")) != NULL)
-       {
-         if (response->request.status.status_code >= IPP_OK_CONFLICT)
+       if ((response = cupsDoRequest(http, request, "/jobs")) != NULL) {
+               if (response->request.status.status_code >= IPP_OK_CONFLICT) {
+                       DEBUG(0,("Unable to release job %d - %s\n", pjob->sysjob,
+                               ippErrorString(cupsLastError())));
+               } else {
+                       ret = 0;
+               }
+       } else {
                DEBUG(0,("Unable to release job %d - %s\n", pjob->sysjob,
-                        ippErrorString(cupsLastError())));
-          else
-               ret = 0;
-
-         ippDelete(response);
+                       ippErrorString(cupsLastError())));
        }
-       else
-         DEBUG(0,("Unable to release job %d - %s\n", pjob->sysjob,
-                  ippErrorString(cupsLastError())));
 
-       httpClose(http);
+ out:
+       if (response)
+               ippDelete(response);
 
-       return (ret);
+       if (language)
+               cupsLangFree(language);
+
+       if (http)
+               httpClose(http);
+
+       return ret;
 }
 
 
@@ -575,16 +555,18 @@ cups_job_resume(int snum, struct printjob *pjob)
  * 'cups_job_submit()' - Submit a job for printing.
  */
 
-static int
-cups_job_submit(int snum, struct printjob *pjob)
+static int cups_job_submit(int snum, struct printjob *pjob)
 {
-       int             ret;            /* Return value */
-       http_t          *http;          /* HTTP connection to server */
-       ipp_t           *request,       /* IPP Request */
-                       *response;      /* IPP Response */
-       cups_lang_t     *language;      /* Default language */
+       int             ret = 1;                /* Return value */
+       http_t          *http = NULL;           /* HTTP connection to server */
+       ipp_t           *request = NULL,        /* IPP Request */
+                       *response = NULL;       /* IPP Response */
+       cups_lang_t     *language = NULL;       /* Default language */
        char            uri[HTTP_MAX_URI]; /* printer-uri attribute */
-
+       const char      *clientname = NULL;     /* hostname of client for job-originating-host attribute */
+       pstring         new_jobname;
+       int             num_options = 0; 
+       cups_option_t   *options = NULL;
 
        DEBUG(5,("cups_job_submit(%d, %p (%d))\n", snum, pjob, pjob->sysjob));
 
@@ -598,11 +580,8 @@ cups_job_submit(int snum, struct printjob *pjob)
        * Try to connect to the server...
        */
 
-       if ((http = httpConnect(cupsServer(), ippPort())) == NULL)
-       {
-               DEBUG(0,("Unable to connect to CUPS server %s - %s\n", 
-                        cupsServer(), strerror(errno)));
-               return (1);
+       if ((http = cups_connect()) == NULL) {
+               goto out;
        }
 
        /*
@@ -638,8 +617,31 @@ cups_job_submit(int snum, struct printjob *pjob)
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_NAME, "requesting-user-name",
                     NULL, pjob->user);
 
+       clientname = client_name();
+       if (strcmp(clientname, "UNKNOWN") == 0) {
+               clientname = client_addr();
+       }
+
+       ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_NAME,
+                    "job-originating-host-name", NULL,
+                     clientname);
+
+        pstr_sprintf(new_jobname,"%s%.8u %s", PRINT_SPOOL_PREFIX, 
+               (unsigned int)pjob->smbjob, pjob->jobname);
+
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_NAME, "job-name", NULL,
-                    pjob->jobname);
+                    new_jobname);
+
+       /* 
+        * add any options defined in smb.conf 
+        */
+
+       num_options = 0;
+       options     = NULL;
+       num_options = cupsParseOptions(lp_cups_options(snum), num_options, &options);
+
+       if ( num_options )
+               cupsEncodeOptions(request, num_options, options); 
 
        /*
        * Do the request and get back a response...
@@ -647,44 +649,55 @@ cups_job_submit(int snum, struct printjob *pjob)
 
        slprintf(uri, sizeof(uri) - 1, "/printers/%s", PRINTERNAME(snum));
 
-        ret = 1;
-       if ((response = cupsDoFileRequest(http, request, uri,
-                                         pjob->filename)) != NULL)
-       {
-               if (response->request.status.status_code >= IPP_OK_CONFLICT)
+       if ((response = cupsDoFileRequest(http, request, uri, pjob->filename)) != NULL) {
+               if (response->request.status.status_code >= IPP_OK_CONFLICT) {
                        DEBUG(0,("Unable to print file to %s - %s\n", PRINTERNAME(snum),
                                 ippErrorString(cupsLastError())));
-               else
+               } else {
                        ret = 0;
-
-               ippDelete(response);
-       }
-       else
+               }
+       } else {
                DEBUG(0,("Unable to print file to `%s' - %s\n", PRINTERNAME(snum),
                         ippErrorString(cupsLastError())));
+       }
 
-       httpClose(http);
+       if ( ret == 0 )
+               unlink(pjob->filename);
+       /* else print_job_end will do it for us */
 
-       return (ret);
-}
+ out:
+       if (response)
+               ippDelete(response);
+
+       if (language)
+               cupsLangFree(language);
 
+       if (http)
+               httpClose(http);
+
+       return ret;
+}
 
 /*
  * 'cups_queue_get()' - Get all the jobs in the print queue.
  */
 
-static int
-cups_queue_get(int snum, print_queue_struct **q, print_status_struct *status)
+static int cups_queue_get(const char *sharename,
+               enum printing_types printing_type,
+               char *lpq_command,
+               print_queue_struct **q, 
+               print_status_struct *status)
 {
-       http_t          *http;          /* HTTP connection to server */
-       ipp_t           *request,       /* IPP Request */
-                       *response;      /* IPP Response */
-       ipp_attribute_t *attr;          /* Current attribute */
-       cups_lang_t     *language;      /* Default language */
+       fstring         printername;
+       http_t          *http = NULL;           /* HTTP connection to server */
+       ipp_t           *request = NULL,        /* IPP Request */
+                       *response = NULL;       /* IPP Response */
+       ipp_attribute_t *attr = NULL;           /* Current attribute */
+       cups_lang_t     *language = NULL;       /* Default language */
        char            uri[HTTP_MAX_URI]; /* printer-uri attribute */
-       int             qcount,         /* Number of active queue entries */
-                       qalloc;         /* Number of queue entries allocated */
-       print_queue_struct *queue,      /* Queue entries */
+       int             qcount = 0,             /* Number of active queue entries */
+                       qalloc = 0;             /* Number of queue entries allocated */
+       print_queue_struct *queue = NULL,       /* Queue entries */
                        *temp;          /* Temporary pointer for queue */
        const char      *user_name,     /* job-originating-user-name attribute */
                        *job_name;      /* job-name attribute */
@@ -709,8 +722,17 @@ cups_queue_get(int snum, print_queue_struct **q, print_status_struct *status)
                          "printer-state-message"
                        };
 
+       *q = NULL;
+
+       /* HACK ALERT!!!  The problem with support the 'printer name' 
+          option is that we key the tdb off the sharename.  So we will 
+          overload the lpq_command string to pass in the printername 
+          (which is basically what we do for non-cups printers ... using 
+          the lpq_command to get the queue listing). */
 
-       DEBUG(5,("cups_queue_get(%d, %p, %p)\n", snum, q, status));
+       fstrcpy( printername, lpq_command );
+
+       DEBUG(5,("cups_queue_get(%s, %p, %p)\n", printername, q, status));
 
        /*
         * Make sure we don't ask for passwords...
@@ -722,19 +744,15 @@ cups_queue_get(int snum, print_queue_struct **q, print_status_struct *status)
        * Try to connect to the server...
        */
 
-       if ((http = httpConnect(cupsServer(), ippPort())) == NULL)
-       {
-               DEBUG(0,("Unable to connect to CUPS server %s - %s\n", 
-                        cupsServer(), strerror(errno)));
-               return (0);
+       if ((http = cups_connect()) == NULL) {
+               goto out;
        }
 
        /*
         * Generate the printer URI...
        */
 
-       slprintf(uri, sizeof(uri) - 1, "ipp://localhost/printers/%s",
-                PRINTERNAME(snum));
+       slprintf(uri, sizeof(uri) - 1, "ipp://localhost/printers/%s", printername);
 
        /*
        * Build an IPP_GET_JOBS request, which requires the following
@@ -771,22 +789,16 @@ cups_queue_get(int snum, print_queue_struct **q, print_status_struct *status)
        * Do the request and get back a response...
        */
 
-       if ((response = cupsDoRequest(http, request, "/")) == NULL)
-       {
+       if ((response = cupsDoRequest(http, request, "/")) == NULL) {
                DEBUG(0,("Unable to get jobs for %s - %s\n", uri,
                         ippErrorString(cupsLastError())));
-               httpClose(http);
-               return (0);
+               goto out;
        }
 
-       if (response->request.status.status_code >= IPP_OK_CONFLICT)
-       {
+       if (response->request.status.status_code >= IPP_OK_CONFLICT) {
                DEBUG(0,("Unable to get jobs for %s - %s\n", uri,
                         ippErrorString(response->request.status.status_code)));
-               ippDelete(response);
-               httpClose(http);
-
-               return (0);
+               goto out;
        }
 
        /*
@@ -797,8 +809,7 @@ cups_queue_get(int snum, print_queue_struct **q, print_status_struct *status)
        qalloc = 0;
        queue  = NULL;
 
-        for (attr = response->attrs; attr != NULL; attr = attr->next)
-       {
+        for (attr = response->attrs; attr != NULL; attr = attr->next) {
               /*
                * Skip leading attributes until we hit a job...
                */
@@ -812,23 +823,16 @@ cups_queue_get(int snum, print_queue_struct **q, print_status_struct *status)
               /*
                * Allocate memory as needed...
                */
-               if (qcount >= qalloc)
-               {
+               if (qcount >= qalloc) {
                        qalloc += 16;
 
-                       temp = Realloc(queue, sizeof(print_queue_struct) * qalloc);
+                       queue = SMB_REALLOC_ARRAY(queue, print_queue_struct, qalloc);
 
-                       if (temp == NULL)
-                       {
+                       if (queue == NULL) {
                                DEBUG(0,("cups_queue_get: Not enough memory!"));
-                               ippDelete(response);
-                               httpClose(http);
-
-                               free (queue);
-                               return (0);
+                               qcount = 0;
+                               goto out;
                        }
-
-                       queue = temp;
                }
 
                temp = queue + qcount;
@@ -846,10 +850,8 @@ cups_queue_get(int snum, print_queue_struct **q, print_status_struct *status)
                user_name    = NULL;
                job_name     = NULL;
 
-               while (attr != NULL && attr->group_tag == IPP_TAG_JOB)
-               {
-                       if (attr->name == NULL)
-                       {
+               while (attr != NULL && attr->group_tag == IPP_TAG_JOB) {
+                       if (attr->name == NULL) {
                                attr = attr->next;
                                break;
                        }
@@ -889,12 +891,11 @@ cups_queue_get(int snum, print_queue_struct **q, print_status_struct *status)
                * See if we have everything needed...
                */
 
-               if (user_name == NULL || job_name == NULL || job_id == 0)
-               {
-                 if (attr == NULL)
-                   break;
-                 else
-                   continue;
+               if (user_name == NULL || job_name == NULL || job_id == 0) {
+                       if (attr == NULL)
+                               break;
+                       else
+                               continue;
                }
 
                temp->job      = job_id;
@@ -911,10 +912,11 @@ cups_queue_get(int snum, print_queue_struct **q, print_status_struct *status)
                qcount ++;
 
                if (attr == NULL)
-                 break;
+                       break;
        }
 
        ippDelete(response);
+       response = NULL;
 
        /*
        * Build an IPP_GET_PRINTER_ATTRIBUTES request, which requires the
@@ -931,8 +933,6 @@ cups_queue_get(int snum, print_queue_struct **q, print_status_struct *status)
        request->request.op.operation_id = IPP_GET_PRINTER_ATTRIBUTES;
        request->request.op.request_id   = 1;
 
-       language = cupsLangDefault();
-
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_CHARSET,
                      "attributes-charset", NULL, cupsLangEncoding(language));
 
@@ -951,31 +951,25 @@ cups_queue_get(int snum, print_queue_struct **q, print_status_struct *status)
        * Do the request and get back a response...
        */
 
-       if ((response = cupsDoRequest(http, request, "/")) == NULL)
-       {
-               DEBUG(0,("Unable to get printer status for %s - %s\n", PRINTERNAME(snum),
+       if ((response = cupsDoRequest(http, request, "/")) == NULL) {
+               DEBUG(0,("Unable to get printer status for %s - %s\n", printername,
                         ippErrorString(cupsLastError())));
-               httpClose(http);
                *q = queue;
-               return (qcount);
+               goto out;
        }
 
-       if (response->request.status.status_code >= IPP_OK_CONFLICT)
-       {
-               DEBUG(0,("Unable to get printer status for %s - %s\n", PRINTERNAME(snum),
+       if (response->request.status.status_code >= IPP_OK_CONFLICT) {
+               DEBUG(0,("Unable to get printer status for %s - %s\n", printername,
                         ippErrorString(response->request.status.status_code)));
-               ippDelete(response);
-               httpClose(http);
                *q = queue;
-               return (qcount);
+               goto out;
        }
 
        /*
         * Get the current printer status and convert it to the SAMBA values.
        */
 
-        if ((attr = ippFindAttribute(response, "printer-state", IPP_TAG_ENUM)) != NULL)
-       {
+        if ((attr = ippFindAttribute(response, "printer-state", IPP_TAG_ENUM)) != NULL) {
                if (attr->values[0].integer == IPP_PRINTER_STOPPED)
                        status->status = LPSTAT_STOPPED;
                else
@@ -986,16 +980,23 @@ cups_queue_get(int snum, print_queue_struct **q, print_status_struct *status)
                                     IPP_TAG_TEXT)) != NULL)
                fstrcpy(status->message, attr->values[0].string.text);
 
-        ippDelete(response);
-
        /*
         * Return the job queue...
        */
 
-       httpClose(http);
-
        *q = queue;
-       return (qcount);
+
+ out:
+       if (response)
+               ippDelete(response);
+
+       if (language)
+               cupsLangFree(language);
+
+       if (http)
+               httpClose(http);
+
+       return qcount;
 }
 
 
@@ -1003,15 +1004,13 @@ cups_queue_get(int snum, print_queue_struct **q, print_status_struct *status)
  * 'cups_queue_pause()' - Pause a print queue.
  */
 
-static int
-cups_queue_pause(int snum)
+static int cups_queue_pause(int snum)
 {
-       extern userdom_struct current_user_info;
-       int             ret;            /* Return value */
-       http_t          *http;          /* HTTP connection to server */
-       ipp_t           *request,       /* IPP Request */
-                       *response;      /* IPP Response */
-       cups_lang_t     *language;      /* Default language */
+       int             ret = 1;                /* Return value */
+       http_t          *http = NULL;           /* HTTP connection to server */
+       ipp_t           *request = NULL,        /* IPP Request */
+                       *response = NULL;       /* IPP Response */
+       cups_lang_t     *language = NULL;       /* Default language */
        char            uri[HTTP_MAX_URI]; /* printer-uri attribute */
 
 
@@ -1027,11 +1026,8 @@ cups_queue_pause(int snum)
         * Try to connect to the server...
         */
 
-       if ((http = httpConnect(cupsServer(), ippPort())) == NULL)
-       {
-               DEBUG(0,("Unable to connect to CUPS server %s - %s\n", 
-                        cupsServer(), strerror(errno)));
-               return (1);
+       if ((http = cups_connect()) == NULL) {
+               goto out;
        }
 
        /*
@@ -1069,25 +1065,29 @@ cups_queue_pause(int snum)
        * Do the request and get back a response...
        */
 
-        ret = 1;
-
-       if ((response = cupsDoRequest(http, request, "/admin/")) != NULL)
-       {
-         if (response->request.status.status_code >= IPP_OK_CONFLICT)
+       if ((response = cupsDoRequest(http, request, "/admin/")) != NULL) {
+               if (response->request.status.status_code >= IPP_OK_CONFLICT) {
+                       DEBUG(0,("Unable to pause printer %s - %s\n", PRINTERNAME(snum),
+                               ippErrorString(cupsLastError())));
+               } else {
+                       ret = 0;
+               }
+       } else {
                DEBUG(0,("Unable to pause printer %s - %s\n", PRINTERNAME(snum),
-                        ippErrorString(cupsLastError())));
-          else
-               ret = 0;
-
-         ippDelete(response);
+                       ippErrorString(cupsLastError())));
        }
-       else
-         DEBUG(0,("Unable to pause printer %s - %s\n", PRINTERNAME(snum),
-                  ippErrorString(cupsLastError())));
 
-       httpClose(http);
+ out:
+       if (response)
+               ippDelete(response);
+
+       if (language)
+               cupsLangFree(language);
 
-       return (ret);
+       if (http)
+               httpClose(http);
+
+       return ret;
 }
 
 
@@ -1095,15 +1095,13 @@ cups_queue_pause(int snum)
  * 'cups_queue_resume()' - Restart a print queue.
  */
 
-static int
-cups_queue_resume(int snum)
+static int cups_queue_resume(int snum)
 {
-       extern userdom_struct current_user_info;
-       int             ret;            /* Return value */
-       http_t          *http;          /* HTTP connection to server */
-       ipp_t           *request,       /* IPP Request */
-                       *response;      /* IPP Response */
-       cups_lang_t     *language;      /* Default language */
+       int             ret = 1;                /* Return value */
+       http_t          *http = NULL;           /* HTTP connection to server */
+       ipp_t           *request = NULL,        /* IPP Request */
+                       *response = NULL;       /* IPP Response */
+       cups_lang_t     *language = NULL;       /* Default language */
        char            uri[HTTP_MAX_URI]; /* printer-uri attribute */
 
 
@@ -1119,11 +1117,8 @@ cups_queue_resume(int snum)
        * Try to connect to the server...
        */
 
-       if ((http = httpConnect(cupsServer(), ippPort())) == NULL)
-       {
-               DEBUG(0,("Unable to connect to CUPS server %s - %s\n", 
-                        cupsServer(), strerror(errno)));
-               return (1);
+       if ((http = cups_connect()) == NULL) {
+               goto out;
        }
 
        /*
@@ -1161,29 +1156,185 @@ cups_queue_resume(int snum)
        * Do the request and get back a response...
        */
 
-        ret = 1;
-
-       if ((response = cupsDoRequest(http, request, "/admin/")) != NULL)
-       {
-         if (response->request.status.status_code >= IPP_OK_CONFLICT)
+       if ((response = cupsDoRequest(http, request, "/admin/")) != NULL) {
+               if (response->request.status.status_code >= IPP_OK_CONFLICT) {
+                       DEBUG(0,("Unable to resume printer %s - %s\n", PRINTERNAME(snum),
+                               ippErrorString(cupsLastError())));
+               } else {
+                       ret = 0;
+               }
+       } else {
                DEBUG(0,("Unable to resume printer %s - %s\n", PRINTERNAME(snum),
+                       ippErrorString(cupsLastError())));
+       }
+
+ out:
+       if (response)
+               ippDelete(response);
+
+       if (language)
+               cupsLangFree(language);
+
+       if (http)
+               httpClose(http);
+
+       return ret;
+}
+
+/*******************************************************************
+ * CUPS printing interface definitions...
+ ******************************************************************/
+
+struct printif cups_printif =
+{
+       PRINT_CUPS,
+       cups_queue_get,
+       cups_queue_pause,
+       cups_queue_resume,
+       cups_job_delete,
+       cups_job_pause,
+       cups_job_resume,
+       cups_job_submit,
+};
+
+bool cups_pull_comment_location(NT_PRINTER_INFO_LEVEL_2 *printer)
+{
+       http_t          *http = NULL;           /* HTTP connection to server */
+       ipp_t           *request = NULL,        /* IPP Request */
+                       *response = NULL;       /* IPP Response */
+       ipp_attribute_t *attr;          /* Current attribute */
+       cups_lang_t     *language = NULL;       /* Default language */
+       char            *name,          /* printer-name attribute */
+                       *info,          /* printer-info attribute */
+                       *location;      /* printer-location attribute */
+       char            uri[HTTP_MAX_URI];
+       static const char *requested[] =/* Requested attributes */
+                       {
+                         "printer-name",
+                         "printer-info",
+                         "printer-location"
+                       };
+       bool ret = False;
+
+       DEBUG(5, ("pulling %s location\n", printer->sharename));
+
+       /*
+        * Make sure we don't ask for passwords...
+        */
+
+        cupsSetPasswordCB(cups_passwd_cb);
+
+       /*
+        * Try to connect to the server...
+        */
+
+       if ((http = cups_connect()) == NULL) {
+               goto out;
+       }
+
+       request = ippNew();
+
+       request->request.op.operation_id = IPP_GET_PRINTER_ATTRIBUTES;
+       request->request.op.request_id   = 1;
+
+       language = cupsLangDefault();
+
+       ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_CHARSET,
+                     "attributes-charset", NULL, cupsLangEncoding(language));
+
+       ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_LANGUAGE,
+                     "attributes-natural-language", NULL, language->language);
+
+       slprintf(uri, sizeof(uri) - 1, "ipp://%s/printers/%s",
+                lp_cups_server(), printer->sharename);
+
+       ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_URI,
+                     "printer-uri", NULL, uri);
+
+        ippAddStrings(request, IPP_TAG_OPERATION, IPP_TAG_NAME,
+                     "requested-attributes",
+                     (sizeof(requested) / sizeof(requested[0])),
+                     NULL, requested);
+
+       /*
+        * Do the request and get back a response...
+        */
+
+       if ((response = cupsDoRequest(http, request, "/")) == NULL) {
+               DEBUG(0,("Unable to get printer attributes - %s\n",
                         ippErrorString(cupsLastError())));
-          else
-               ret = 0;
+               goto out;
+       }
+
+       for (attr = response->attrs; attr != NULL;) {
+               /*
+                * Skip leading attributes until we hit a printer...
+                */
+
+               while (attr != NULL && attr->group_tag != IPP_TAG_PRINTER)
+                       attr = attr->next;
+
+               if (attr == NULL)
+                       break;
+
+               /*
+                * Pull the needed attributes from this printer...
+                */
+
+               name       = NULL;
+               info       = NULL;
+               location   = NULL;
+
+               while ( attr && (attr->group_tag == IPP_TAG_PRINTER) ) {
+                       /* Grab the comment if we don't have one */
+                       if ( (strcmp(attr->name, "printer-info") == 0)
+                            && (attr->value_tag == IPP_TAG_TEXT)
+                            && !strlen(printer->comment) ) 
+                       {
+                               DEBUG(5,("cups_pull_comment_location: Using cups comment: %s\n",
+                                        attr->values[0].string.text));                         
+                               pstrcpy(printer->comment,attr->values[0].string.text);
+                       }
+
+                       /* Grab the location if we don't have one */ 
+                       if ( (strcmp(attr->name, "printer-location") == 0)
+                            && (attr->value_tag == IPP_TAG_TEXT) 
+                            && !strlen(printer->location) )
+                       {
+                               DEBUG(5,("cups_pull_comment_location: Using cups location: %s\n",
+                                        attr->values[0].string.text));                         
+                               fstrcpy(printer->location,attr->values[0].string.text);
+                       }
+
+                       attr = attr->next;
+               }
+
+               /*
+                * See if we have everything needed...
+                */
+
+               if (name == NULL)
+                       break;
 
-         ippDelete(response);
        }
-       else
-         DEBUG(0,("Unable to resume printer %s - %s\n", PRINTERNAME(snum),
-                  ippErrorString(cupsLastError())));
 
-       httpClose(http);
+       ret = True;
 
-       return (ret);
-}
+ out:
+       if (response)
+               ippDelete(response);
 
+       if (language)
+               cupsLangFree(language);
+
+       if (http)
+               httpClose(http);
+
+       return ret;
+}
 
 #else
  /* this keeps fussy compilers happy */
+ void print_cups_dummy(void);
  void print_cups_dummy(void) {}
 #endif /* HAVE_CUPS */