r10656: BIG merge from trunk. Features not copied over
[nivanova/samba-autobuild/.git] / source3 / nsswitch / winbindd_ads.c
index beb40af79de15b492890b264a5384e0f95ec2af4..dfabccd419443772e6ac4c4451c9b300a53188a9 100644 (file)
@@ -5,6 +5,7 @@
 
    Copyright (C) Andrew Tridgell 2001
    Copyright (C) Andrew Bartlett <abartlet@samba.org> 2003
+   Copyright (C) Gerald (Jerry) Carter 2004
    
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
@@ -21,6 +22,7 @@
    Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
 */
 
+#include "includes.h"
 #include "winbindd.h"
 
 #ifdef HAVE_ADS
 #undef DBGC_CLASS
 #define DBGC_CLASS DBGC_WINBIND
 
-/* the realm of our primary LDAP server */
-static char *primary_realm;
-
-
 /*
   return our ads connections structure for a domain. We keep the connection
   open to make things faster
@@ -41,8 +39,23 @@ static ADS_STRUCT *ads_cached_connection(struct winbindd_domain *domain)
        ADS_STRUCT *ads;
        ADS_STATUS status;
 
-       if (domain->private) {
-               return (ADS_STRUCT *)domain->private;
+       if (domain->private_data) {
+               ads = (ADS_STRUCT *)domain->private_data;
+
+               /* check for a valid structure */
+
+               DEBUG(7, ("Current tickets expire at %d, time is now %d\n",
+                         (uint32) ads->auth.expire, (uint32) time(NULL)));
+               if ( ads->config.realm && (ads->auth.expire > time(NULL))) {
+                       return ads;
+               }
+               else {
+                       /* we own this ADS_STRUCT so make sure it goes away */
+                       ads->is_mine = True;
+                       ads_destroy( &ads );
+                       ads_kdestroy("MEMORY:winbind_ccache");
+                       domain->private_data = NULL;
+               }       
        }
 
        /* we don't want this to affect the users ccache */
@@ -58,34 +71,42 @@ static ADS_STRUCT *ads_cached_connection(struct winbindd_domain *domain)
        SAFE_FREE(ads->auth.password);
        ads->auth.password = secrets_fetch_machine_password(lp_workgroup(), NULL, NULL);
 
-       if (primary_realm) {
-               SAFE_FREE(ads->auth.realm);
-               ads->auth.realm = strdup(primary_realm);
-       }
+       SAFE_FREE(ads->auth.realm);
+       ads->auth.realm = SMB_STRDUP(lp_realm());
 
        status = ads_connect(ads);
        if (!ADS_ERR_OK(status) || !ads->config.realm) {
-               extern struct winbindd_methods msrpc_methods;
+               extern struct winbindd_methods msrpc_methods, cache_methods;
                DEBUG(1,("ads_connect for domain %s failed: %s\n", 
                         domain->name, ads_errstr(status)));
                ads_destroy(&ads);
 
                /* if we get ECONNREFUSED then it might be a NT4
                    server, fall back to MSRPC */
-               if (status.error_type == ADS_ERROR_SYSTEM &&
+               if (status.error_type == ENUM_ADS_ERROR_SYSTEM &&
                    status.err.rc == ECONNREFUSED) {
                        DEBUG(1,("Trying MSRPC methods\n"));
-                       domain->methods = &msrpc_methods;
+                       if (domain->methods == &cache_methods) {
+                               domain->backend = &msrpc_methods;
+                       } else {
+                               domain->methods = &msrpc_methods;
+                       }
                }
                return NULL;
        }
 
-       /* remember our primary realm for trusted domain support */
-       if (!primary_realm) {
-               primary_realm = strdup(ads->config.realm);
+       if (use_nss_info("sfu") && (!ads_check_sfu_mapping(ads))) {
+               DEBUG(0,("ads_cached_connection: failed to check sfu attributes\n"));
+               return NULL;
        }
+       
+       /* set the flag that says we don't own the memory even 
+          though we do so that ads_destroy() won't destroy the 
+          structure we pass back by reference */
+
+       ads->is_mine = False;
 
-       domain->private = (void *)ads;
+       domain->private_data = (void *)ads;
        return ads;
 }
 
@@ -100,7 +121,10 @@ static NTSTATUS query_user_list(struct winbindd_domain *domain,
        const char *attrs[] = {"userPrincipalName",
                               "sAMAccountName",
                               "name", "objectSid", "primaryGroupID", 
-                              "sAMAccountType", NULL};
+                              "sAMAccountType", 
+                              ADS_ATTR_SFU_HOMEDIR_OID, 
+                              ADS_ATTR_SFU_SHELL_OID, 
+                              NULL};
        int i, count;
        ADS_STATUS rc;
        void *res = NULL;
@@ -112,10 +136,14 @@ static NTSTATUS query_user_list(struct winbindd_domain *domain,
        DEBUG(3,("ads: query_user_list\n"));
 
        ads = ads_cached_connection(domain);
-       if (!ads) goto done;
+       
+       if (!ads) {
+               domain->last_status = NT_STATUS_SERVER_DISABLED;
+               goto done;
+       }
 
-       rc = ads_search_retry(ads, &res, "(objectCategory=user)", attrs);
-       if (!ADS_ERR_OK(rc)) {
+       rc = ads_search_retry(ads, &res, "(objectClass=user)", attrs);
+       if (!ADS_ERR_OK(rc) || !res) {
                DEBUG(1,("query_user_list ads_search: %s\n", ads_errstr(rc)));
                goto done;
        }
@@ -126,7 +154,7 @@ static NTSTATUS query_user_list(struct winbindd_domain *domain,
                goto done;
        }
 
-       (*info) = talloc_zero(mem_ctx, count * sizeof(**info));
+       (*info) = TALLOC_ZERO_ARRAY(mem_ctx, WINBIND_USERINFO, count);
        if (!*info) {
                status = NT_STATUS_NO_MEMORY;
                goto done;
@@ -136,9 +164,8 @@ static NTSTATUS query_user_list(struct winbindd_domain *domain,
 
        for (msg = ads_first_entry(ads, res); msg; msg = ads_next_entry(ads, msg)) {
                char *name, *gecos;
-               DOM_SID sid;
-               DOM_SID *sid2;
-               DOM_SID *group_sid;
+               char *homedir = NULL;
+               char *shell = NULL;
                uint32 group;
                uint32 atype;
 
@@ -150,7 +177,13 @@ static NTSTATUS query_user_list(struct winbindd_domain *domain,
 
                name = ads_pull_username(ads, mem_ctx, msg);
                gecos = ads_pull_string(ads, mem_ctx, msg, "name");
-               if (!ads_pull_sid(ads, msg, "objectSid", &sid)) {
+               if (use_nss_info("sfu")) {
+                       homedir = ads_pull_string(ads, mem_ctx, msg, ads->schema.sfu_homedir_attr);
+                       shell = ads_pull_string(ads, mem_ctx, msg, ads->schema.sfu_shell_attr);
+               }
+       
+               if (!ads_pull_sid(ads, msg, "objectSid",
+                                 &(*info)[i].user_sid)) {
                        DEBUG(1,("No sid for %s !?\n", name));
                        continue;
                }
@@ -159,20 +192,11 @@ static NTSTATUS query_user_list(struct winbindd_domain *domain,
                        continue;
                }
 
-               sid2 = talloc(mem_ctx, sizeof(*sid2));
-               if (!sid2) {
-                       status = NT_STATUS_NO_MEMORY;
-                       goto done;
-               }
-
-               sid_copy(sid2, &sid);
-
-               group_sid = rid_to_talloced_sid(domain, mem_ctx, group);
-
                (*info)[i].acct_name = name;
                (*info)[i].full_name = gecos;
-               (*info)[i].user_sid = sid2;
-               (*info)[i].group_sid = group_sid;
+               (*info)[i].homedir = homedir;
+               (*info)[i].shell = shell;
+               sid_compose(&(*info)[i].group_sid, &domain->sid, group);
                i++;
        }
 
@@ -182,7 +206,8 @@ static NTSTATUS query_user_list(struct winbindd_domain *domain,
        DEBUG(3,("ads query_user_list gave %d entries\n", (*num_entries)));
 
 done:
-       if (res) ads_msgfree(ads, res);
+       if (res) 
+               ads_msgfree(ads, res);
 
        return status;
 }
@@ -209,10 +234,14 @@ static NTSTATUS enum_dom_groups(struct winbindd_domain *domain,
        DEBUG(3,("ads: enum_dom_groups\n"));
 
        ads = ads_cached_connection(domain);
-       if (!ads) goto done;
+
+       if (!ads) {
+               domain->last_status = NT_STATUS_SERVER_DISABLED;
+               goto done;
+       }
 
        rc = ads_search_retry(ads, &res, "(objectCategory=group)", attrs);
-       if (!ADS_ERR_OK(rc)) {
+       if (!ADS_ERR_OK(rc) || !res) {
                DEBUG(1,("enum_dom_groups ads_search: %s\n", ads_errstr(rc)));
                goto done;
        }
@@ -223,7 +252,7 @@ static NTSTATUS enum_dom_groups(struct winbindd_domain *domain,
                goto done;
        }
 
-       (*info) = talloc_zero(mem_ctx, count * sizeof(**info));
+       (*info) = TALLOC_ZERO_ARRAY(mem_ctx, struct acct_info, count);
        if (!*info) {
                status = NT_STATUS_NO_MEMORY;
                goto done;
@@ -232,7 +261,9 @@ static NTSTATUS enum_dom_groups(struct winbindd_domain *domain,
        i = 0;
        
        group_flags = ATYPE_GLOBAL_GROUP;
-       if ( domain->native_mode )
+
+       /* only grab domain local groups for our domain */
+       if ( domain->native_mode && strequal(lp_realm(), domain->alt_name)  )
                group_flags |= ATYPE_LOCAL_GROUP;
 
        for (msg = ads_first_entry(ads, res); msg; msg = ads_next_entry(ads, msg)) {
@@ -251,6 +282,9 @@ static NTSTATUS enum_dom_groups(struct winbindd_domain *domain,
                        continue;
                }
 
+               if (sid_check_is_in_builtin(&sid))
+                       continue;
+
                if (!sid_peek_check_rid(&domain->sid, &sid, &rid)) {
                        DEBUG(1,("No rid for %s !?\n", name));
                        continue;
@@ -269,7 +303,8 @@ static NTSTATUS enum_dom_groups(struct winbindd_domain *domain,
        DEBUG(3,("ads enum_dom_groups gave %d entries\n", (*num_entries)));
 
 done:
-       if (res) ads_msgfree(ads, res);
+       if (res) 
+               ads_msgfree(ads, res);
 
        return status;
 }
@@ -282,7 +317,7 @@ static NTSTATUS enum_local_groups(struct winbindd_domain *domain,
 {
        /*
         * This is a stub function only as we returned the domain 
-        * ocal groups in enum_dom_groups() if the domain->native field
+        * local groups in enum_dom_groups() if the domain->native field
         * was true.  This is a simple performance optimization when
         * using LDAP.
         *
@@ -295,41 +330,6 @@ static NTSTATUS enum_local_groups(struct winbindd_domain *domain,
        return NT_STATUS_OK;
 }
 
-/* convert a single name to a sid in a domain */
-static NTSTATUS name_to_sid(struct winbindd_domain *domain,
-                           TALLOC_CTX *mem_ctx,
-                           const char *name,
-                           DOM_SID *sid,
-                           enum SID_NAME_USE *type)
-{
-       ADS_STRUCT *ads;
-
-       DEBUG(3,("ads: name_to_sid\n"));
-
-       ads = ads_cached_connection(domain);
-       if (!ads) 
-               return NT_STATUS_UNSUCCESSFUL;
-
-       return ads_name_to_sid(ads, name, sid, type);
-}
-
-/* convert a sid to a user or group name */
-static NTSTATUS sid_to_name(struct winbindd_domain *domain,
-                           TALLOC_CTX *mem_ctx,
-                           DOM_SID *sid,
-                           char **name,
-                           enum SID_NAME_USE *type)
-{
-       ADS_STRUCT *ads = NULL;
-       DEBUG(3,("ads: sid_to_name\n"));
-       ads = ads_cached_connection(domain);
-       if (!ads) 
-               return NT_STATUS_UNSUCCESSFUL;
-
-       return ads_sid_to_name(ads, mem_ctx, sid, name, type);
-}
-
-
 /* convert a DN to a name, SID and name type 
    this might become a major speed bottleneck if groups have
    lots of users, in which case we could cache the results
@@ -338,24 +338,16 @@ static BOOL dn_lookup(ADS_STRUCT *ads, TALLOC_CTX *mem_ctx,
                      const char *dn,
                      char **name, uint32 *name_type, DOM_SID *sid)
 {
-       char *exp;
        void *res = NULL;
        const char *attrs[] = {"userPrincipalName", "sAMAccountName",
                               "objectSid", "sAMAccountType", NULL};
        ADS_STATUS rc;
        uint32 atype;
-       char *escaped_dn = escape_ldap_string_alloc(dn);
-
-       if (!escaped_dn) {
-               return False;
-       }
+       DEBUG(3,("ads: dn_lookup\n"));
 
-       asprintf(&exp, "(distinguishedName=%s)", dn);
-       rc = ads_search_retry(ads, &res, exp, attrs);
-       SAFE_FREE(exp);
-       SAFE_FREE(escaped_dn);
+       rc = ads_search_retry_dn(ads, &res, dn, attrs);
 
-       if (!ADS_ERR_OK(rc)) {
+       if (!ADS_ERR_OK(rc) || !res) {
                goto failed;
        }
 
@@ -370,80 +362,90 @@ static BOOL dn_lookup(ADS_STRUCT *ads, TALLOC_CTX *mem_ctx,
                goto failed;
        }
 
-       if (res) ads_msgfree(ads, res);
+       if (res) 
+               ads_msgfree(ads, res);
+
        return True;
 
 failed:
-       if (res) ads_msgfree(ads, res);
+       if (res) 
+               ads_msgfree(ads, res);
+
        return False;
 }
 
 /* Lookup user information from a rid */
 static NTSTATUS query_user(struct winbindd_domain *domain, 
                           TALLOC_CTX *mem_ctx, 
-                          DOM_SID *sid, 
+                          const DOM_SID *sid, 
                           WINBIND_USERINFO *info)
 {
        ADS_STRUCT *ads = NULL;
        const char *attrs[] = {"userPrincipalName", 
                               "sAMAccountName",
                               "name", 
-                              "primaryGroupID", NULL};
+                              "primaryGroupID", 
+                              ADS_ATTR_SFU_HOMEDIR_OID, 
+                              ADS_ATTR_SFU_SHELL_OID, 
+                              NULL};
        ADS_STATUS rc;
        int count;
        void *msg = NULL;
-       char *exp;
+       char *ldap_exp;
        char *sidstr;
        uint32 group_rid;
        NTSTATUS status = NT_STATUS_UNSUCCESSFUL;
-       DOM_SID *sid2;
-       fstring sid_string;
 
        DEBUG(3,("ads: query_user\n"));
 
        ads = ads_cached_connection(domain);
-       if (!ads) goto done;
+       
+       if (!ads) {
+               domain->last_status = NT_STATUS_SERVER_DISABLED;
+               goto done;
+       }
 
        sidstr = sid_binstring(sid);
-       asprintf(&exp, "(objectSid=%s)", sidstr);
-       rc = ads_search_retry(ads, &msg, exp, attrs);
-       free(exp);
+       asprintf(&ldap_exp, "(objectSid=%s)", sidstr);
+       rc = ads_search_retry(ads, &msg, ldap_exp, attrs);
+       free(ldap_exp);
        free(sidstr);
-       if (!ADS_ERR_OK(rc)) {
-               DEBUG(1,("query_user(sid=%s) ads_search: %s\n", sid_to_string(sid_string, sid), ads_errstr(rc)));
+       if (!ADS_ERR_OK(rc) || !msg) {
+               DEBUG(1,("query_user(sid=%s) ads_search: %s\n",
+                        sid_string_static(sid), ads_errstr(rc)));
                goto done;
        }
 
        count = ads_count_replies(ads, msg);
        if (count != 1) {
-               DEBUG(1,("query_user(sid=%s): Not found\n", sid_to_string(sid_string, sid)));
+               DEBUG(1,("query_user(sid=%s): Not found\n",
+                        sid_string_static(sid)));
                goto done;
        }
 
        info->acct_name = ads_pull_username(ads, mem_ctx, msg);
        info->full_name = ads_pull_string(ads, mem_ctx, msg, "name");
 
-       if (!ads_pull_uint32(ads, msg, "primaryGroupID", &group_rid)) {
-               DEBUG(1,("No primary group for %s !?\n", sid_to_string(sid_string, sid)));
-               goto done;
+       if (use_nss_info("sfu")) {
+               info->homedir = ads_pull_string(ads, mem_ctx, msg, ads->schema.sfu_homedir_attr);
+               info->shell = ads_pull_string(ads, mem_ctx, msg, ads->schema.sfu_shell_attr);
        }
-       
-       sid2 = talloc(mem_ctx, sizeof(*sid2));
-       if (!sid2) {
-               status = NT_STATUS_NO_MEMORY;
+
+       if (!ads_pull_uint32(ads, msg, "primaryGroupID", &group_rid)) {
+               DEBUG(1,("No primary group for %s !?\n",
+                        sid_string_static(sid)));
                goto done;
        }
-       sid_copy(sid2, sid);
-       
-       info->user_sid = sid2;
 
-       info->group_sid = rid_to_talloced_sid(domain, mem_ctx, group_rid);
+       sid_copy(&info->user_sid, sid);
+       sid_compose(&info->group_sid, &domain->sid, group_rid);
 
        status = NT_STATUS_OK;
 
        DEBUG(3,("ads query_user gave %s\n", info->acct_name));
 done:
-       if (msg) ads_msgfree(ads, msg);
+       if (msg) 
+               ads_msgfree(ads, msg);
 
        return status;
 }
@@ -454,76 +456,81 @@ static NTSTATUS lookup_usergroups_alt(struct winbindd_domain *domain,
                                      TALLOC_CTX *mem_ctx,
                                      const char *user_dn, 
                                      DOM_SID *primary_group,
-                                     uint32 *num_groups, DOM_SID ***user_gids)
+                                     uint32 *num_groups, DOM_SID **user_sids)
 {
        ADS_STATUS rc;
        NTSTATUS status = NT_STATUS_UNSUCCESSFUL;
        int count;
        void *res = NULL;
        void *msg = NULL;
-       char *exp;
+       char *ldap_exp;
        ADS_STRUCT *ads;
        const char *group_attrs[] = {"objectSid", NULL};
+       char *escaped_dn;
+
+       DEBUG(3,("ads: lookup_usergroups_alt\n"));
 
        ads = ads_cached_connection(domain);
-       if (!ads) goto done;
+
+       if (!ads) {
+               domain->last_status = NT_STATUS_SERVER_DISABLED;
+               goto done;
+       }
+
+       if (!(escaped_dn = escape_ldap_string_alloc(user_dn))) {
+               status = NT_STATUS_NO_MEMORY;
+               goto done;
+       }
 
        /* buggy server, no tokenGroups.  Instead lookup what groups this user
           is a member of by DN search on member*/
-       if (asprintf(&exp, "(&(member=%s)(objectClass=group))", user_dn) == -1) {
+
+       if (!(ldap_exp = talloc_asprintf(mem_ctx, "(&(member=%s)(objectClass=group))", escaped_dn))) {
                DEBUG(1,("lookup_usergroups(dn=%s) asprintf failed!\n", user_dn));
-               return NT_STATUS_NO_MEMORY;
+               SAFE_FREE(escaped_dn);
+               status = NT_STATUS_NO_MEMORY;
+               goto done;
        }
+
+       SAFE_FREE(escaped_dn);
+
+       rc = ads_search_retry(ads, &res, ldap_exp, group_attrs);
        
-       rc = ads_search_retry(ads, &res, exp, group_attrs);
-       free(exp);
-       
-       if (!ADS_ERR_OK(rc)) {
+       if (!ADS_ERR_OK(rc) || !res) {
                DEBUG(1,("lookup_usergroups ads_search member=%s: %s\n", user_dn, ads_errstr(rc)));
                return ads_ntstatus(rc);
        }
        
        count = ads_count_replies(ads, res);
-       if (count == 0) {
-               DEBUG(5,("lookup_usergroups: No supp groups found\n"));
-               
-               status = ads_ntstatus(rc);
-               goto done;
-       }
-       
-       (*user_gids) = talloc_zero(mem_ctx, sizeof(**user_gids) * (count + 1));
-       (*user_gids)[0] = primary_group;
        
-       *num_groups = 1;
-       
-       for (msg = ads_first_entry(ads, res); msg; msg = ads_next_entry(ads, msg)) {
-               DOM_SID group_sid;
-               
-               if (!ads_pull_sid(ads, msg, "objectSid", &group_sid)) {
-                       DEBUG(1,("No sid for this group ?!?\n"));
-                       continue;
-               }
-               
-               if (sid_equal(&group_sid, primary_group)) continue;
+       *user_sids = NULL;
+       *num_groups = 0;
+
+       /* always add the primary group to the sid array */
+       add_sid_to_array(mem_ctx, primary_group, user_sids, num_groups);
+
+       if (count > 0) {
+               for (msg = ads_first_entry(ads, res); msg;
+                    msg = ads_next_entry(ads, msg)) {
+                       DOM_SID group_sid;
                
-               (*user_gids)[*num_groups] = talloc(mem_ctx, sizeof(***user_gids));
-               if (!(*user_gids)[*num_groups]) {
-                       status = NT_STATUS_NO_MEMORY;
-                       goto done;
-               }
+                       if (!ads_pull_sid(ads, msg, "objectSid", &group_sid)) {
+                               DEBUG(1,("No sid for this group ?!?\n"));
+                               continue;
+                       }
 
-               sid_copy((*user_gids)[*num_groups], &group_sid);
+                       add_sid_to_array(mem_ctx, &group_sid, user_sids,
+                                        num_groups);
+               }
 
-               (*num_groups)++;
-                       
        }
 
-       status = NT_STATUS_OK;
+       status = (user_sids != NULL) ? NT_STATUS_OK : NT_STATUS_NO_MEMORY;
 
        DEBUG(3,("ads lookup_usergroups (alt) for dn=%s\n", user_dn));
 done:
-       if (res) ads_msgfree(ads, res);
-       if (msg) ads_msgfree(ads, msg);
+       if (res) 
+               ads_msgfree(ads, res);
 
        return status;
 }
@@ -531,22 +538,19 @@ done:
 /* Lookup groups a user is a member of. */
 static NTSTATUS lookup_usergroups(struct winbindd_domain *domain,
                                  TALLOC_CTX *mem_ctx,
-                                 DOM_SID *sid, 
-                                 uint32 *num_groups, DOM_SID ***user_gids)
+                                 const DOM_SID *sid, 
+                                 uint32 *num_groups, DOM_SID **user_sids)
 {
        ADS_STRUCT *ads = NULL;
-       const char *attrs[] = {"distinguishedName", NULL};
-       const char *attrs2[] = {"tokenGroups", "primaryGroupID", NULL};
+       const char *attrs[] = {"tokenGroups", "primaryGroupID", NULL};
        ADS_STATUS rc;
        int count;
-       void *msg = NULL;
-       char *exp;
+       LDAPMessage *msg = NULL;
        char *user_dn;
        DOM_SID *sids;
        int i;
-       DOM_SID *primary_group;
+       DOM_SID primary_group;
        uint32 primary_group_rid;
-       char *sidstr;
        fstring sid_string;
        NTSTATUS status = NT_STATUS_UNSUCCESSFUL;
 
@@ -554,83 +558,76 @@ static NTSTATUS lookup_usergroups(struct winbindd_domain *domain,
        *num_groups = 0;
 
        ads = ads_cached_connection(domain);
-       if (!ads) goto done;
-
-       if (!(sidstr = sid_binstring(sid))) {
-               DEBUG(1,("lookup_usergroups(sid=%s) sid_binstring returned NULL\n", sid_to_string(sid_string, sid)));
-               status = NT_STATUS_NO_MEMORY;
-               goto done;
-       }
-       if (asprintf(&exp, "(objectSid=%s)", sidstr) == -1) {
-               free(sidstr);
-               DEBUG(1,("lookup_usergroups(sid=%s) asprintf failed!\n", sid_to_string(sid_string, sid)));
-               status = NT_STATUS_NO_MEMORY;
+       
+       if (!ads) {
+               domain->last_status = NT_STATUS_SERVER_DISABLED;
+               status = NT_STATUS_SERVER_DISABLED;
                goto done;
        }
 
-       rc = ads_search_retry(ads, &msg, exp, attrs);
-       free(exp);
-       free(sidstr);
-
+       rc = ads_sid_to_dn(ads, mem_ctx, sid, &user_dn);
        if (!ADS_ERR_OK(rc)) {
-               DEBUG(1,("lookup_usergroups(sid=%s) ads_search: %s\n", sid_to_string(sid_string, sid), ads_errstr(rc)));
+               status = ads_ntstatus(rc);
                goto done;
        }
 
-       user_dn = ads_pull_string(ads, mem_ctx, msg, "distinguishedName");
-       if (!user_dn) {
-               DEBUG(1,("lookup_usergroups(sid=%s) ads_search did not return a a distinguishedName!\n", sid_to_string(sid_string, sid)));
-               if (msg) ads_msgfree(ads, msg);
+       rc = ads_search_retry_dn(ads, (void**)&msg, user_dn, attrs);
+       if (!ADS_ERR_OK(rc)) {
+               status = ads_ntstatus(rc);
+               DEBUG(1,("lookup_usergroups(sid=%s) ads_search tokenGroups: %s\n", 
+                        sid_to_string(sid_string, sid), ads_errstr(rc)));
                goto done;
        }
-
-       if (msg) ads_msgfree(ads, msg);
-
-       rc = ads_search_retry_dn(ads, &msg, user_dn, attrs2);
-       if (!ADS_ERR_OK(rc)) {
-               DEBUG(1,("lookup_usergroups(sid=%s) ads_search tokenGroups: %s\n", sid_to_string(sid_string, sid), ads_errstr(rc)));
+       
+       if (!msg) {
+               DEBUG(1,("lookup_usergroups(sid=%s) ads_search tokenGroups: NULL msg\n", 
+                        sid_to_string(sid_string, sid)));
+               status = NT_STATUS_UNSUCCESSFUL;
                goto done;
        }
 
        if (!ads_pull_uint32(ads, msg, "primaryGroupID", &primary_group_rid)) {
-               DEBUG(1,("%s: No primary group for sid=%s !?\n", domain->name, sid_to_string(sid_string, sid)));
+               DEBUG(1,("%s: No primary group for sid=%s !?\n", 
+                        domain->name, sid_to_string(sid_string, sid)));
                goto done;
        }
 
-       primary_group = rid_to_talloced_sid(domain, mem_ctx, primary_group_rid);
+       sid_copy(&primary_group, &domain->sid);
+       sid_append_rid(&primary_group, primary_group_rid);
 
        count = ads_pull_sids(ads, mem_ctx, msg, "tokenGroups", &sids);
 
-       if (msg) ads_msgfree(ads, msg);
+       if (msg) 
+               ads_msgfree(ads, msg);
 
        /* there must always be at least one group in the token, 
           unless we are talking to a buggy Win2k server */
        if (count == 0) {
                return lookup_usergroups_alt(domain, mem_ctx, user_dn, 
-                                            primary_group,
-                                            num_groups, user_gids);
+                                            &primary_group,
+                                            num_groups, user_sids);
        }
 
-       (*user_gids) = talloc_zero(mem_ctx, sizeof(**user_gids) * (count + 1));
-       (*user_gids)[0] = primary_group;
-       
-       *num_groups = 1;
+       *user_sids = NULL;
+       *num_groups = 0;
+
+       add_sid_to_array(mem_ctx, &primary_group, user_sids, num_groups);
        
        for (i=0;i<count;i++) {
-               if (sid_equal(&sids[i], primary_group)) continue;
-               
-               (*user_gids)[*num_groups] = talloc(mem_ctx, sizeof(***user_gids));
-               if (!(*user_gids)[*num_groups]) {
-                       status = NT_STATUS_NO_MEMORY;
-                       goto done;
-               }
 
-               sid_copy((*user_gids)[*num_groups], &sids[i]);
-               (*num_groups)++;
+               /* ignore Builtin groups from ADS - Guenther */
+               if (sid_check_is_in_builtin(&sids[i])) {
+                       continue;
+               }
+                              
+               add_sid_to_array_unique(mem_ctx, &sids[i],
+                                       user_sids, num_groups);
        }
 
-       status = NT_STATUS_OK;
-       DEBUG(3,("ads lookup_usergroups for sid=%s\n", sid_to_string(sid_string, sid)));
+       status = (user_sids != NULL) ? NT_STATUS_OK : NT_STATUS_NO_MEMORY;
+
+       DEBUG(3,("ads lookup_usergroups for sid=%s\n",
+                sid_to_string(sid_string, sid)));
 done:
        return status;
 }
@@ -640,62 +637,122 @@ done:
  */
 static NTSTATUS lookup_groupmem(struct winbindd_domain *domain,
                                TALLOC_CTX *mem_ctx,
-                               DOM_SID *group_sid, uint32 *num_names, 
-                               DOM_SID ***sid_mem, char ***names, 
+                               const DOM_SID *group_sid, uint32 *num_names, 
+                               DOM_SID **sid_mem, char ***names, 
                                uint32 **name_types)
 {
        ADS_STATUS rc;
        int count;
        void *res=NULL;
        ADS_STRUCT *ads = NULL;
-       char *exp;
+       char *ldap_exp;
        NTSTATUS status = NT_STATUS_UNSUCCESSFUL;
        char *sidstr;
-       const char *attrs[] = {"member", NULL};
        char **members;
-       int i, num_members;
+       int i;
+       size_t num_members;
        fstring sid_string;
+       BOOL more_values;
+       const char **attrs;
+       uint32 first_usn;
+       uint32 current_usn;
+       int num_retries = 0;
+
+       DEBUG(10,("ads: lookup_groupmem %s sid=%s\n", domain->name, 
+                 sid_string_static(group_sid)));
 
        *num_names = 0;
 
        ads = ads_cached_connection(domain);
-       if (!ads) goto done;
+       
+       if (!ads) {
+               domain->last_status = NT_STATUS_SERVER_DISABLED;
+               goto done;
+       }
 
        sidstr = sid_binstring(group_sid);
 
        /* search for all members of the group */
-       asprintf(&exp, "(objectSid=%s)",sidstr);
-       rc = ads_search_retry(ads, &res, exp, attrs);
-       free(exp);
-       free(sidstr);
-
-       if (!ADS_ERR_OK(rc)) {
-               DEBUG(1,("query_user_list ads_search: %s\n", ads_errstr(rc)));
+       if (!(ldap_exp = talloc_asprintf(mem_ctx, "(objectSid=%s)",sidstr))) {
+               SAFE_FREE(sidstr);
+               DEBUG(1, ("ads: lookup_groupmem: tallloc_asprintf for ldap_exp failed!\n"));
+               status = NT_STATUS_NO_MEMORY;
                goto done;
        }
+       SAFE_FREE(sidstr);
 
-       count = ads_count_replies(ads, res);
-       if (count == 0) {
-               status = NT_STATUS_OK;
-               goto done;
-       }
+       members = NULL;
+       num_members = 0;
 
-       members = ads_pull_strings(ads, mem_ctx, res, "member");
-       if (!members) {
-               /* no members? ok ... */
-               status = NT_STATUS_OK;
-               goto done;
-       }
+       attrs = TALLOC_ARRAY(mem_ctx, const char *, 3);
+       attrs[1] = talloc_strdup(mem_ctx, "usnChanged");
+       attrs[2] = NULL;
+               
+       do {
+               if (num_members == 0) 
+                       attrs[0] = talloc_strdup(mem_ctx, "member");
+
+               DEBUG(10, ("Searching for attrs[0] = %s, attrs[1] = %s\n", attrs[0], attrs[1]));
+
+               rc = ads_search_retry(ads, &res, ldap_exp, attrs);
+
+               if (!ADS_ERR_OK(rc) || !res) {
+                       DEBUG(1,("ads: lookup_groupmem ads_search: %s\n",
+                                ads_errstr(rc)));
+                       status = ads_ntstatus(rc);
+                       goto done;
+               }
 
+               count = ads_count_replies(ads, res);
+               if (count == 0)
+                       break;
+
+               if (num_members == 0) {
+                       if (!ads_pull_uint32(ads, res, "usnChanged", &first_usn)) {
+                               DEBUG(1, ("ads: lookup_groupmem could not pull usnChanged!\n"));
+                               goto done;
+                       }
+               }
+
+               if (!ads_pull_uint32(ads, res, "usnChanged", &current_usn)) {
+                       DEBUG(1, ("ads: lookup_groupmem could not pull usnChanged!\n"));
+                       goto done;
+               }
+
+               if (first_usn != current_usn) {
+                       DEBUG(5, ("ads: lookup_groupmem USN on this record changed"
+                                 " - restarting search\n"));
+                       if (num_retries < 5) {
+                               num_retries++;
+                               num_members = 0;
+                               continue;
+                       } else {
+                               DEBUG(5, ("ads: lookup_groupmem USN on this record changed"
+                                         " - restarted search too many times, aborting!\n"));
+                               status = NT_STATUS_UNSUCCESSFUL;
+                               goto done;
+                       }
+               }
+
+               members = ads_pull_strings_range(ads, mem_ctx, res,
+                                                "member",
+                                                members,
+                                                &attrs[0],
+                                                &num_members,
+                                                &more_values);
+
+               if ((members == NULL) || (num_members == 0))
+                       break;
+
+       } while (more_values);
+               
        /* now we need to turn a list of members into rids, names and name types 
           the problem is that the members are in the form of distinguised names
        */
-       for (i=0;members[i];i++) /* noop */ ;
-       num_members = i;
 
-       (*sid_mem) = talloc_zero(mem_ctx, sizeof(**sid_mem) * num_members);
-       (*name_types) = talloc_zero(mem_ctx, sizeof(**name_types) * num_members);
-       (*names) = talloc_zero(mem_ctx, sizeof(**names) * num_members);
+       (*sid_mem) = TALLOC_ZERO_ARRAY(mem_ctx, DOM_SID, num_members);
+       (*name_types) = TALLOC_ZERO_ARRAY(mem_ctx, uint32, num_members);
+       (*names) = TALLOC_ZERO_ARRAY(mem_ctx, char *, num_members);
 
        for (i=0;i<num_members;i++) {
                uint32 name_type;
@@ -705,12 +762,7 @@ static NTSTATUS lookup_groupmem(struct winbindd_domain *domain,
                if (dn_lookup(ads, mem_ctx, members[i], &name, &name_type, &sid)) {
                    (*names)[*num_names] = name;
                    (*name_types)[*num_names] = name_type;
-                   (*sid_mem)[*num_names] = talloc(mem_ctx, sizeof(***sid_mem));
-                   if (!(*sid_mem)[*num_names]) {
-                           status = NT_STATUS_NO_MEMORY;
-                           goto done;
-                   }
-                   sid_copy((*sid_mem)[*num_names], &sid);
+                   sid_copy(&(*sid_mem)[*num_names], &sid);
                    (*num_names)++;
                }
        }       
@@ -718,28 +770,39 @@ static NTSTATUS lookup_groupmem(struct winbindd_domain *domain,
        status = NT_STATUS_OK;
        DEBUG(3,("ads lookup_groupmem for sid=%s\n", sid_to_string(sid_string, group_sid)));
 done:
-       if (res) ads_msgfree(ads, res);
+
+       if (res) 
+               ads_msgfree(ads, res);
 
        return status;
 }
 
-
 /* find the sequence number for a domain */
 static NTSTATUS sequence_number(struct winbindd_domain *domain, uint32 *seq)
 {
        ADS_STRUCT *ads = NULL;
        ADS_STATUS rc;
 
+       DEBUG(3,("ads: fetch sequence_number for %s\n", domain->name));
+
        *seq = DOM_SEQUENCE_NONE;
 
        ads = ads_cached_connection(domain);
-       if (!ads) return NT_STATUS_UNSUCCESSFUL;
+       
+       if (!ads) {
+               domain->last_status = NT_STATUS_SERVER_DISABLED;
+               return NT_STATUS_UNSUCCESSFUL;
+       }
 
        rc = ads_USN(ads, seq);
+       
        if (!ADS_ERR_OK(rc)) {
-               /* its a dead connection */
-               ads_destroy(&ads);
-               domain->private = NULL;
+       
+               /* its a dead connection ; don't destroy it 
+                  through since ads_USN() has already done 
+                  that indirectly */
+                  
+               domain->private_data = NULL;
        }
        return ads_ntstatus(rc);
 }
@@ -752,41 +815,71 @@ static NTSTATUS trusted_domains(struct winbindd_domain *domain,
                                char ***alt_names,
                                DOM_SID **dom_sids)
 {
-       ADS_STRUCT *ads;
-       ADS_STATUS rc;
+       NTSTATUS                result = NT_STATUS_UNSUCCESSFUL;
+       struct ds_domain_trust  *domains = NULL;
+       int                     count = 0;
+       int                     i;
+                               /* i think we only need our forest and downlevel trusted domains */
+       uint32                  flags = DS_DOMAIN_IN_FOREST | DS_DOMAIN_DIRECT_OUTBOUND;
+       struct rpc_pipe_client *cli;
+
+       DEBUG(3,("ads: trusted_domains\n"));
 
        *num_domains = 0;
-       *names = NULL;
+       *alt_names   = NULL;
+       *names       = NULL;
+       *dom_sids    = NULL;
 
-       ads = ads_cached_connection(domain);
-       if (!ads) return NT_STATUS_UNSUCCESSFUL;
+       result = cm_connect_netlogon(domain, &cli);
+
+       if (!NT_STATUS_IS_OK(result)) {
+               DEBUG(5, ("trusted_domains: Could not open a connection to %s "
+                         "for PIPE_NETLOGON (%s)\n", 
+                         domain->name, nt_errstr(result)));
+               return NT_STATUS_UNSUCCESSFUL;
+       }
+       
+       if ( NT_STATUS_IS_OK(result) ) {
+               result = rpccli_ds_enum_domain_trusts(cli, mem_ctx,
+                                                     cli->cli->desthost, 
+                                                     flags, &domains,
+                                                     (unsigned int *)&count);
+       }
+       
+       if ( NT_STATUS_IS_OK(result) && count) {
+       
+               /* Allocate memory for trusted domain names and sids */
 
-       rc = ads_trusted_domains(ads, mem_ctx, num_domains, names, alt_names, dom_sids);
+               if ( !(*names = TALLOC_ARRAY(mem_ctx, char *, count)) ) {
+                       DEBUG(0, ("trusted_domains: out of memory\n"));
+                       return NT_STATUS_NO_MEMORY;
+               }
 
-       return ads_ntstatus(rc);
-}
+               if ( !(*alt_names = TALLOC_ARRAY(mem_ctx, char *, count)) ) {
+                       DEBUG(0, ("trusted_domains: out of memory\n"));
+                       return NT_STATUS_NO_MEMORY;
+               }
 
-/* find the domain sid for a domain */
-static NTSTATUS domain_sid(struct winbindd_domain *domain, DOM_SID *sid)
-{
-       ADS_STRUCT *ads;
-       ADS_STATUS rc;
+               if ( !(*dom_sids = TALLOC_ARRAY(mem_ctx, DOM_SID, count)) ) {
+                       DEBUG(0, ("trusted_domains: out of memory\n"));
+                       return NT_STATUS_NO_MEMORY;
+               }
 
-       ads = ads_cached_connection(domain);
-       if (!ads) return NT_STATUS_UNSUCCESSFUL;
+               /* Copy across names and sids */
 
-       rc = ads_domain_sid(ads, sid);
+               for (i = 0; i < count; i++) {
+                       (*names)[i] = domains[i].netbios_domain;
+                       (*alt_names)[i] = domains[i].dns_domain;
 
-       if (!ADS_ERR_OK(rc)) {
-               /* its a dead connection */
-               ads_destroy(&ads);
-               domain->private = NULL;
+                       sid_copy(&(*dom_sids)[i], &domains[i].sid);
+               }
+
+               *num_domains = count;   
        }
 
-       return ads_ntstatus(rc);
+       return result;
 }
 
-
 /* find alternate names list for the domain - for ADS this is the
    netbios name */
 static NTSTATUS alternate_name(struct winbindd_domain *domain)
@@ -794,10 +887,16 @@ static NTSTATUS alternate_name(struct winbindd_domain *domain)
        ADS_STRUCT *ads;
        ADS_STATUS rc;
        TALLOC_CTX *ctx;
-       char *workgroup;
+       const char *workgroup;
+
+       DEBUG(3,("ads: alternate_name\n"));
 
        ads = ads_cached_connection(domain);
-       if (!ads) return NT_STATUS_UNSUCCESSFUL;
+       
+       if (!ads) {
+               domain->last_status = NT_STATUS_SERVER_DISABLED;
+               return NT_STATUS_UNSUCCESSFUL;
+       }
 
        if (!(ctx = talloc_init("alternate_name"))) {
                return NT_STATUS_NO_MEMORY;
@@ -808,8 +907,8 @@ static NTSTATUS alternate_name(struct winbindd_domain *domain)
        if (ADS_ERR_OK(rc)) {
                fstrcpy(domain->name, workgroup);
                fstrcpy(domain->alt_name, ads->config.realm);
-               strupper(domain->alt_name);
-               strupper(domain->name);
+               strupper_m(domain->alt_name);
+               strupper_m(domain->name);
        }
 
        talloc_destroy(ctx);
@@ -823,14 +922,14 @@ struct winbindd_methods ads_methods = {
        query_user_list,
        enum_dom_groups,
        enum_local_groups,
-       name_to_sid,
-       sid_to_name,
+       msrpc_name_to_sid,
+       msrpc_sid_to_name,
        query_user,
        lookup_usergroups,
+       msrpc_lookup_useraliases,
        lookup_groupmem,
        sequence_number,
        trusted_domains,
-       domain_sid,
        alternate_name
 };