Fix valgrind memory leak in bug #6814 - Fixes for problems reported by valgrind
[nivanova/samba-autobuild/.git] / source3 / lib / smbldap.c
index bca984444d4d5df6417de10387f497127a414735..7287e3d9986a7698a0d40350a1eac71788edac70 100644 (file)
@@ -6,21 +6,20 @@
    Copyright (C) Shahms King                   2001
    Copyright (C) Andrew Bartlett               2002-2003
    Copyright (C) Stefan (metze) Metzmacher     2002-2003
-    
+
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
-   the Free Software Foundation; either version 2 of the License, or
+   the Free Software Foundation; either version 3 of the License, or
    (at your option) any later version.
-   
+
    This program is distributed in the hope that it will be useful,
    but WITHOUT ANY WARRANTY; without even the implied warranty of
    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
    GNU General Public License for more details.
-   
+
    You should have received a copy of the GNU General Public License
-   along with this program; if not, write to the Free Software
-   Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
-   
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
 */
 
 #include "includes.h"
@@ -52,6 +51,7 @@ ATTRIB_MAP_ENTRY attrib_map_v22[] = {
        { LDAP_ATTR_LOGOFF_TIME,        "logoffTime"    },
        { LDAP_ATTR_KICKOFF_TIME,       "kickoffTime"   },
        { LDAP_ATTR_CN,                 "cn"            },
+       { LDAP_ATTR_SN,                 "sn"            },
        { LDAP_ATTR_DISPLAY_NAME,       "displayName"   },
        { LDAP_ATTR_HOME_PATH,          "smbHome"       },
        { LDAP_ATTR_HOME_DRIVE,         "homeDrive"     },
@@ -106,6 +106,7 @@ ATTRIB_MAP_ENTRY attrib_map_v30[] = {
        { LDAP_ATTR_LOGOFF_TIME,        "sambaLogoffTime"       },
        { LDAP_ATTR_KICKOFF_TIME,       "sambaKickoffTime"      },
        { LDAP_ATTR_CN,                 "cn"                    },
+       { LDAP_ATTR_SN,                 "sn"                    },
        { LDAP_ATTR_DISPLAY_NAME,       "displayName"           },
        { LDAP_ATTR_HOME_DRIVE,         "sambaHomeDrive"        },
        { LDAP_ATTR_HOME_PATH,          "sambaHomePath"         },
@@ -136,6 +137,7 @@ ATTRIB_MAP_ENTRY attrib_map_to_delete_v30[] = {
        { LDAP_ATTR_LOGON_TIME,         "sambaLogonTime"        },
        { LDAP_ATTR_LOGOFF_TIME,        "sambaLogoffTime"       },
        { LDAP_ATTR_KICKOFF_TIME,       "sambaKickoffTime"      },
+       { LDAP_ATTR_DISPLAY_NAME,       "displayName"           },
        { LDAP_ATTR_HOME_DRIVE,         "sambaHomeDrive"        },
        { LDAP_ATTR_HOME_PATH,          "sambaHomePath"         },
        { LDAP_ATTR_LOGON_SCRIPT,       "sambaLogonScript"      },
@@ -215,13 +217,13 @@ ATTRIB_MAP_ENTRY sidmap_attr_list[] = {
  const char* get_attr_key2string( ATTRIB_MAP_ENTRY table[], int key )
 {
        int i = 0;
-       
+
        while ( table[i].attrib != LDAP_ATTR_LIST_END ) {
                if ( table[i].attrib == key )
                        return table[i].name;
                i++;
        }
-       
+
        return NULL;
 }
 
@@ -234,7 +236,7 @@ ATTRIB_MAP_ENTRY sidmap_attr_list[] = {
 {
        const char **names;
        int i = 0;
-       
+
        while ( table[i].attrib != LDAP_ATTR_LIST_END )
                i++;
        i++;
@@ -251,7 +253,7 @@ ATTRIB_MAP_ENTRY sidmap_attr_list[] = {
                i++;
        }
        names[i] = NULL;
-       
+
        return names;
 }
 
@@ -259,30 +261,30 @@ ATTRIB_MAP_ENTRY sidmap_attr_list[] = {
  Search an attribute and return the first value found.
 ******************************************************************/
 
BOOL smbldap_get_single_attribute (LDAP * ldap_struct, LDAPMessage * entry,
bool smbldap_get_single_attribute (LDAP * ldap_struct, LDAPMessage * entry,
                                    const char *attribute, char *value,
                                    int max_len)
 {
        char **values;
-       
+
        if ( !attribute )
                return False;
-               
+
        value[0] = '\0';
 
        if ((values = ldap_get_values (ldap_struct, entry, attribute)) == NULL) {
                DEBUG (10, ("smbldap_get_single_attribute: [%s] = [<does not exist>]\n", attribute));
-               
+
                return False;
        }
-       
+
        if (convert_string(CH_UTF8, CH_UNIX,values[0], -1, value, max_len, False) == (size_t)-1) {
                DEBUG(1, ("smbldap_get_single_attribute: string conversion of [%s] = [%s] failed!\n", 
                          attribute, values[0]));
                ldap_value_free(values);
                return False;
        }
-       
+
        ldap_value_free(values);
 #ifdef DEBUG_PASSWORDS
        DEBUG (100, ("smbldap_get_single_attribute: [%s] = [%s]\n", attribute, value));
@@ -290,20 +292,13 @@ ATTRIB_MAP_ENTRY sidmap_attr_list[] = {
        return True;
 }
 
- BOOL smbldap_get_single_pstring (LDAP * ldap_struct, LDAPMessage * entry,
-                                 const char *attribute, pstring value)
-{
-       return smbldap_get_single_attribute(ldap_struct, entry,
-                                           attribute, value, 
-                                           sizeof(pstring));
-}
-
  char * smbldap_talloc_single_attribute(LDAP *ldap_struct, LDAPMessage *entry,
                                        const char *attribute,
                                        TALLOC_CTX *mem_ctx)
 {
        char **values;
        char *result;
+       size_t converted_size;
 
        if (attribute == NULL) {
                return NULL;
@@ -323,7 +318,7 @@ ATTRIB_MAP_ENTRY sidmap_attr_list[] = {
                return NULL;
        }
 
-       if (pull_utf8_talloc(mem_ctx, &result, values[0]) < 0) {
+       if (!pull_utf8_talloc(mem_ctx, &result, values[0], &converted_size)) {
                DEBUG(10, ("pull_utf8_talloc failed\n"));
                ldap_value_free(values);
                return NULL;
@@ -338,8 +333,102 @@ ATTRIB_MAP_ENTRY sidmap_attr_list[] = {
        return result;
 }
 
- static int ldapmsg_destructor(void *p) {
-       LDAPMessage **result = talloc_get_type_abort(p, LDAPMessage *);
+ char * smbldap_talloc_smallest_attribute(LDAP *ldap_struct, LDAPMessage *entry,
+                                         const char *attribute,
+                                         TALLOC_CTX *mem_ctx)
+{
+       char **values;
+       char *result;
+       size_t converted_size;
+       int i, num_values;
+
+       if (attribute == NULL) {
+               return NULL;
+       }
+
+       values = ldap_get_values(ldap_struct, entry, attribute);
+
+       if (values == NULL) {
+               DEBUG(10, ("attribute %s does not exist\n", attribute));
+               return NULL;
+       }
+
+       if (!pull_utf8_talloc(mem_ctx, &result, values[0], &converted_size)) {
+               DEBUG(10, ("pull_utf8_talloc failed\n"));
+               ldap_value_free(values);
+               return NULL;
+       }
+
+       num_values = ldap_count_values(values);
+
+       for (i=1; i<num_values; i++) {
+               char *tmp;
+
+               if (!pull_utf8_talloc(mem_ctx, &tmp, values[i],
+                                     &converted_size)) {
+                       DEBUG(10, ("pull_utf8_talloc failed\n"));
+                       TALLOC_FREE(result);
+                       ldap_value_free(values);
+                       return NULL;
+               }
+
+               if (StrCaseCmp(tmp, result) < 0) {
+                       TALLOC_FREE(result);
+                       result = tmp;
+               } else {
+                       TALLOC_FREE(tmp);
+               }
+       }
+
+       ldap_value_free(values);
+
+#ifdef DEBUG_PASSWORDS
+       DEBUG (100, ("smbldap_get_single_attribute: [%s] = [%s]\n",
+                    attribute, result));
+#endif
+       return result;
+}
+
+ bool smbldap_talloc_single_blob(TALLOC_CTX *mem_ctx, LDAP *ld,
+                                LDAPMessage *msg, const char *attrib,
+                                DATA_BLOB *blob)
+{
+       struct berval **values;
+
+       values = ldap_get_values_len(ld, msg, attrib);
+       if (!values) {
+               return false;
+       }
+
+       if (ldap_count_values_len(values) != 1) {
+               DEBUG(10, ("Expected one value for %s, got %d\n", attrib,
+                          ldap_count_values_len(values)));
+               return false;
+       }
+
+       *blob = data_blob_talloc(mem_ctx, values[0]->bv_val,
+                                values[0]->bv_len);
+       ldap_value_free_len(values);
+
+       return (blob->data != NULL);
+}
+
+ bool smbldap_pull_sid(LDAP *ld, LDAPMessage *msg, const char *attrib,
+                      struct dom_sid *sid)
+{
+       DATA_BLOB blob;
+       bool ret;
+
+       if (!smbldap_talloc_single_blob(talloc_tos(), ld, msg, attrib,
+                                       &blob)) {
+               return false;
+       }
+       ret = sid_parse((char *)blob.data, blob.length, sid);
+       TALLOC_FREE(blob.data);
+       return ret;
+}
+
+ static int ldapmsg_destructor(LDAPMessage **result) {
        ldap_msgfree(*result);
        return 0;
 }
@@ -359,9 +448,8 @@ ATTRIB_MAP_ENTRY sidmap_attr_list[] = {
        talloc_set_destructor(handle, ldapmsg_destructor);
 }
 
- static int ldapmod_destructor(void *p) {
-       LDAPMod ***result = talloc_get_type_abort(p, LDAPMod **);
-       ldap_mods_free(*result, True);
+ static int ldapmod_destructor(LDAPMod ***mod) {
+       ldap_mods_free(*mod, True);
        return 0;
 }
 
@@ -408,9 +496,8 @@ ATTRIB_MAP_ENTRY sidmap_attr_list[] = {
        if (mods == NULL) {
                mods = SMB_MALLOC_P(LDAPMod *);
                if (mods == NULL) {
-                       smb_panic("smbldap_set_mod: out of memory!\n");
+                       smb_panic("smbldap_set_mod: out of memory!");
                        /* notreached. */
-                       abort();
                }
                mods[0] = NULL;
        }
@@ -423,15 +510,13 @@ ATTRIB_MAP_ENTRY sidmap_attr_list[] = {
        if (mods[i] == NULL) {
                mods = SMB_REALLOC_ARRAY (mods, LDAPMod *, i + 2);
                if (mods == NULL) {
-                       smb_panic("smbldap_set_mod: out of memory!\n");
+                       smb_panic("smbldap_set_mod: out of memory!");
                        /* notreached. */
-                       abort();
                }
                mods[i] = SMB_MALLOC_P(LDAPMod);
                if (mods[i] == NULL) {
-                       smb_panic("smbldap_set_mod: out of memory!\n");
+                       smb_panic("smbldap_set_mod: out of memory!");
                        /* notreached. */
-                       abort();
                }
                mods[i]->mod_op = modop;
                mods[i]->mod_values = NULL;
@@ -441,26 +526,27 @@ ATTRIB_MAP_ENTRY sidmap_attr_list[] = {
 
        if (value != NULL) {
                char *utf8_value = NULL;
+               size_t converted_size;
 
                j = 0;
                if (mods[i]->mod_values != NULL) {
                        for (; mods[i]->mod_values[j] != NULL; j++);
                }
                mods[i]->mod_values = SMB_REALLOC_ARRAY(mods[i]->mod_values, char *, j + 2);
-                                              
+
                if (mods[i]->mod_values == NULL) {
-                       smb_panic("smbldap_set_mod: out of memory!\n");
+                       smb_panic("smbldap_set_mod: out of memory!");
                        /* notreached. */
-                       abort();
                }
 
-               if (push_utf8_allocate(&utf8_value, value) == (size_t)-1) {
-                       smb_panic("smbldap_set_mod: String conversion failure!\n");
+               if (!push_utf8_talloc(talloc_tos(), &utf8_value, value, &converted_size)) {
+                       smb_panic("smbldap_set_mod: String conversion failure!");
                        /* notreached. */
-                       abort();
                }
 
-               mods[i]->mod_values[j] = utf8_value;
+               mods[i]->mod_values[j] = SMB_STRDUP(utf8_value);
+               TALLOC_FREE(utf8_value);
+               SMB_ASSERT(mods[i]->mod_values[j] != NULL);
 
                mods[i]->mod_values[j + 1] = NULL;
        }
@@ -477,7 +563,7 @@ ATTRIB_MAP_ENTRY sidmap_attr_list[] = {
                      const char *attribute, const char *newval)
 {
        char oldval[2048]; /* current largest allowed value is mungeddial */
-       BOOL existed;
+       bool existed;
 
        if (attribute == NULL) {
                /* This can actually happen for ldapsam_compat where we for
@@ -493,9 +579,9 @@ ATTRIB_MAP_ENTRY sidmap_attr_list[] = {
        }
 
        /* all of our string attributes are case insensitive */
-       
+
        if (existed && newval && (StrCaseCmp(oldval, newval) == 0)) {
-               
+
                /* Believe it or not, but LDAP will deny a delete and
                   an add at the same time if the values are the
                   same... */
@@ -514,7 +600,7 @@ ATTRIB_MAP_ENTRY sidmap_attr_list[] = {
                /* This will also allow modifying single valued attributes 
                 * in Novell NDS. In NDS you have to first remove attribute and then
                 * you could add new value */
-               
+
                DEBUG(10,("smbldap_make_mod: deleting attribute |%s| values |%s|\n", attribute, oldval));
                smbldap_set_mod(mods, LDAP_MOD_DELETE, attribute, oldval);
        }
@@ -572,8 +658,7 @@ static void smbldap_store_state(LDAP *ld, struct smbldap_state *smbldap_state)
 {
        struct smbldap_state *tmp_ldap_state;
        struct smbldap_state_lookup *t;
-       struct smbldap_state_lookup *tmp;
-       
+
        if ((tmp_ldap_state = smbldap_find_state(ld))) {
                SMB_ASSERT(tmp_ldap_state == smbldap_state);
                return;
@@ -581,8 +666,8 @@ static void smbldap_store_state(LDAP *ld, struct smbldap_state *smbldap_state)
 
        t = SMB_XMALLOC_P(struct smbldap_state_lookup);
        ZERO_STRUCTP(t);
-       
-       DLIST_ADD_END(smbldap_state_lookup_list, t, tmp);
+
+       DLIST_ADD_END(smbldap_state_lookup_list, t, struct smbldap_state_lookup *);
        t->ld = ld;
        t->smbldap_state = smbldap_state;
 }
@@ -593,12 +678,14 @@ static void smbldap_store_state(LDAP *ld, struct smbldap_state *smbldap_state)
 
 int smb_ldap_start_tls(LDAP *ldap_struct, int version)
 { 
+#ifdef LDAP_OPT_X_TLS
        int rc;
-       
+#endif
+
        if (lp_ldap_ssl() != LDAP_SSL_START_TLS) {
                return LDAP_SUCCESS;
        }
-       
+
 #ifdef LDAP_OPT_X_TLS
        if (version != LDAP_VERSION3) {
                DEBUG(0, ("Need LDAPv3 for Start TLS\n"));
@@ -628,15 +715,24 @@ int smb_ldap_setup_conn(LDAP **ldap_struct, const char *uri)
        int rc;
 
        DEBUG(10, ("smb_ldap_setup_connection: %s\n", uri));
-       
+
 #ifdef HAVE_LDAP_INITIALIZE
-       
+
        rc = ldap_initialize(ldap_struct, uri);
        if (rc) {
                DEBUG(0, ("ldap_initialize: %s\n", ldap_err2string(rc)));
+               return rc;
        }
 
-       return rc;
+       if (lp_ldap_ref_follow() != Auto) {
+               rc = ldap_set_option(*ldap_struct, LDAP_OPT_REFERRALS,
+                    lp_ldap_ref_follow() ? LDAP_OPT_ON : LDAP_OPT_OFF);
+               if (rc != LDAP_SUCCESS)
+                       DEBUG(0, ("Failed to set LDAP_OPT_REFERRALS: %s\n",
+                               ldap_err2string(rc)));
+       }
+
+       return LDAP_SUCCESS;
 #else 
 
        /* Parse the string manually */
@@ -652,9 +748,9 @@ int smb_ldap_setup_conn(LDAP **ldap_struct, const char *uri)
                if ( strnequal( uri, "URL:", 4 ) ) {
                        uri += 4;
                }
-               
+
                sscanf(uri, "%10[^:]://%254[^:/]:%d", protocol, host, &port);
-               
+
                if (port == 0) {
                        if (strequal(protocol, "ldap")) {
                                port = LDAP_PORT;
@@ -664,12 +760,12 @@ int smb_ldap_setup_conn(LDAP **ldap_struct, const char *uri)
                                DEBUG(0, ("unrecognised protocol (%s)!\n", protocol));
                        }
                }
-               
+
                if ((*ldap_struct = ldap_init(host, port)) == NULL)     {
                        DEBUG(0, ("ldap_init failed !\n"));
                        return LDAP_OPERATIONS_ERROR;
                }
-               
+
                if (strequal(protocol, "ldaps")) {
 #ifdef LDAP_OPT_X_TLS
                        int tls = LDAP_OPT_X_TLS_HARD;
@@ -677,16 +773,39 @@ int smb_ldap_setup_conn(LDAP **ldap_struct, const char *uri)
                        {
                                DEBUG(0, ("Failed to setup a TLS session\n"));
                        }
-                       
+
                        DEBUG(3,("LDAPS option set...!\n"));
 #else
                        DEBUG(0,("smbldap_open_connection: Secure connection not supported by LDAP client libraries!\n"));
                        return LDAP_OPERATIONS_ERROR;
 #endif /* LDAP_OPT_X_TLS */
                }
-
        }
 #endif /* HAVE_LDAP_INITIALIZE */
+
+       /* now set connection timeout */
+#ifdef LDAP_X_OPT_CONNECT_TIMEOUT /* Netscape */
+       {
+               int ct = lp_ldap_connection_timeout()*1000;
+               rc = ldap_set_option(*ldap_struct, LDAP_X_OPT_CONNECT_TIMEOUT, &ct);
+               if (rc != LDAP_SUCCESS) {
+                       DEBUG(0,("Failed to setup an ldap connection timeout %d: %s\n",
+                               ct, ldap_err2string(rc)));
+               }
+       }
+#elif defined (LDAP_OPT_NETWORK_TIMEOUT) /* OpenLDAP */
+       {
+               struct timeval ct;
+               ct.tv_usec = 0;
+               ct.tv_sec = lp_ldap_connection_timeout();
+               rc = ldap_set_option(*ldap_struct, LDAP_OPT_NETWORK_TIMEOUT, &ct);
+               if (rc != LDAP_SUCCESS) {
+                       DEBUG(0,("Failed to setup an ldap connection timeout %d: %s\n",
+                               (int)ct.tv_sec, ldap_err2string(rc)));
+               }
+       }
+#endif
+
        return LDAP_SUCCESS;
 }
 
@@ -699,7 +818,7 @@ int smb_ldap_upgrade_conn(LDAP *ldap_struct, int *new_version)
 {
        int version;
        int rc;
-       
+
        /* assume the worst */
        *new_version = LDAP_VERSION2;
 
@@ -719,7 +838,7 @@ int smb_ldap_upgrade_conn(LDAP *ldap_struct, int *new_version)
        if (rc) {
                return rc;
        }
-               
+
        *new_version = LDAP_VERSION3;
        return LDAP_SUCCESS;
 }
@@ -782,7 +901,7 @@ static int smbldap_open_connection (struct smbldap_state *ldap_state)
        if (rc) {
                return rc;
        }
-       
+
        DEBUG(2, ("smbldap_open_connection: connection opened\n"));
        return rc;
 }
@@ -797,33 +916,40 @@ static int rebindproc_with_state  (LDAP * ld, char **whop, char **credp,
                                   int *methodp, int freeit, void *arg)
 {
        struct smbldap_state *ldap_state = arg;
-       
+
        /** @TODO Should we be doing something to check what servers we rebind to?
            Could we get a referral to a machine that we don't want to give our
            username and password to? */
-       
+
        if (freeit) {
                SAFE_FREE(*whop);
-               memset(*credp, '\0', strlen(*credp));
+               if (*credp) {
+                       memset(*credp, '\0', strlen(*credp));
+               }
                SAFE_FREE(*credp);
        } else {
                DEBUG(5,("rebind_proc_with_state: Rebinding as \"%s\"\n", 
-                         ldap_state->bind_dn));
+                         ldap_state->bind_dn?ldap_state->bind_dn:"[Anonymous bind]"));
 
-               *whop = SMB_STRDUP(ldap_state->bind_dn);
-               if (!*whop) {
-                       return LDAP_NO_MEMORY;
-               }
-               *credp = SMB_STRDUP(ldap_state->bind_secret);
-               if (!*credp) {
-                       SAFE_FREE(*whop);
-                       return LDAP_NO_MEMORY;
+               if (ldap_state->anonymous) {
+                       *whop = NULL;
+                       *credp = NULL;
+               } else {
+                       *whop = SMB_STRDUP(ldap_state->bind_dn);
+                       if (!*whop) {
+                               return LDAP_NO_MEMORY;
+                       }
+                       *credp = SMB_STRDUP(ldap_state->bind_secret);
+                       if (!*credp) {
+                               SAFE_FREE(*whop);
+                               return LDAP_NO_MEMORY;
+                       }
                }
                *methodp = LDAP_AUTH_SIMPLE;
        }
 
        GetTimeOfDay(&ldap_state->last_rebind);
-               
+
        return 0;
 }
 #endif /*defined(LDAP_API_FEATURE_X_OPENLDAP) && (LDAP_API_VERSION > 2000)*/
@@ -839,12 +965,13 @@ static int rebindproc_connect_with_state (LDAP *ldap_struct,
                                          ber_tag_t request,
                                          ber_int_t msgid, void *arg)
 {
-       struct smbldap_state *ldap_state = arg;
+       struct smbldap_state *ldap_state =
+               (struct smbldap_state *)arg;
        int rc;
        int version;
 
        DEBUG(5,("rebindproc_connect_with_state: Rebinding to %s as \"%s\"\n", 
-                url, ldap_state->bind_dn));
+                url, ldap_state->bind_dn?ldap_state->bind_dn:"[Anonymous bind]"));
 
        /* call START_TLS again (ldaps:// is handled by the OpenLDAP library
         * itself) before rebinding to another LDAP server to avoid to expose
@@ -897,7 +1024,6 @@ static int rebindproc (LDAP *ldap_struct, char **whop, char **credp,
 
        return rebindproc_with_state(ldap_struct, whop, credp,
                                     method, freeit, ldap_state);
-       
 }
 # endif /*LDAP_SET_REBIND_PROC_ARGS == 2*/
 #endif /*defined(LDAP_API_FEATURE_X_OPENLDAP) && (LDAP_API_VERSION > 2000)*/
@@ -925,25 +1051,30 @@ static int rebindproc_connect (LDAP * ld, LDAP_CONST char *url, int request,
 static int smbldap_connect_system(struct smbldap_state *ldap_state, LDAP * ldap_struct)
 {
        int rc;
-       char *ldap_dn;
-       char *ldap_secret;
        int version;
 
-       /* get the password */
-       if (!fetch_ldap_pw(&ldap_dn, &ldap_secret)) {
-               DEBUG(0, ("ldap_connect_system: Failed to retrieve password from secrets.tdb\n"));
-               return LDAP_INVALID_CREDENTIALS;
-       }
+       if (!ldap_state->anonymous && !ldap_state->bind_dn) {
+               char *bind_dn = NULL;
+               char *bind_secret = NULL;
 
-       ldap_state->bind_dn = ldap_dn;
-       ldap_state->bind_secret = ldap_secret;
+               /* get the default dn and password only if they are not set already */
+               if (!fetch_ldap_pw(&bind_dn, &bind_secret)) {
+                       DEBUG(0, ("ldap_connect_system: Failed to retrieve password from secrets.tdb\n"));
+                       return LDAP_INVALID_CREDENTIALS;
+               }
+               smbldap_set_creds(ldap_state, false, bind_dn, bind_secret);
+               SAFE_FREE(bind_dn);
+               memset(bind_secret, '\0', strlen(bind_secret));
+               SAFE_FREE(bind_secret);
+       }
 
        /* removed the sasl_bind_s "EXTERNAL" stuff, as my testsuite 
           (OpenLDAP) doesnt' seem to support it */
-          
+
        DEBUG(10,("ldap_connect_system: Binding to ldap server %s as \"%s\"\n",
-                 ldap_state->uri, ldap_dn));
+                 ldap_state->uri, ldap_state->bind_dn));
 
+#ifdef HAVE_LDAP_SET_REBIND_PROC
 #if defined(LDAP_API_FEATURE_X_OPENLDAP) && (LDAP_API_VERSION > 2000)
 # if LDAP_SET_REBIND_PROC_ARGS == 2    
        ldap_set_rebind_proc(ldap_struct, &rebindproc_connect); 
@@ -959,8 +1090,9 @@ static int smbldap_connect_system(struct smbldap_state *ldap_state, LDAP * ldap_
        ldap_set_rebind_proc(ldap_struct, &rebindproc_with_state, (void *)ldap_state);  
 # endif
 #endif /*defined(LDAP_API_FEATURE_X_OPENLDAP) && (LDAP_API_VERSION > 2000)*/
+#endif
 
-       rc = ldap_simple_bind_s(ldap_struct, ldap_dn, ldap_secret);
+       rc = ldap_simple_bind_s(ldap_struct, ldap_state->bind_dn, ldap_state->bind_secret);
 
        if (rc != LDAP_SUCCESS) {
                char *ld_error = NULL;
@@ -969,7 +1101,8 @@ static int smbldap_connect_system(struct smbldap_state *ldap_state, LDAP * ldap_
                DEBUG(ldap_state->num_failures ? 2 : 0,
                      ("failed to bind to server %s with dn=\"%s\" Error: %s\n\t%s\n",
                               ldap_state->uri,
-                              ldap_dn ? ldap_dn : "(unknown)", ldap_err2string(rc),
+                              ldap_state->bind_dn ? ldap_state->bind_dn : "[Anonymous bind]",
+                              ldap_err2string(rc),
                               ld_error ? ld_error : "(unknown)"));
                SAFE_FREE(ld_error);
                ldap_state->num_failures++;
@@ -985,31 +1118,33 @@ static int smbldap_connect_system(struct smbldap_state *ldap_state, LDAP * ldap_
                ldap_state->paged_results = True;
        }
 
-       DEBUG(3, ("ldap_connect_system: succesful connection to the LDAP server\n"));
+       DEBUG(3, ("ldap_connect_system: successful connection to the LDAP server\n"));
        DEBUGADD(10, ("ldap_connect_system: LDAP server %s support paged results\n", 
                ldap_state->paged_results ? "does" : "does not"));
        return rc;
 }
 
+static void smbldap_idle_fn(struct event_context *event_ctx,
+                           struct timed_event *te,
+                           struct timeval now,
+                           void *private_data);
+
 /**********************************************************************
  Connect to LDAP server (called before every ldap operation)
 *********************************************************************/
 static int smbldap_open(struct smbldap_state *ldap_state)
 {
        int rc, opt_rc;
-       BOOL reopen = False;
+       bool reopen = False;
        SMB_ASSERT(ldap_state);
-               
-#ifndef NO_LDAP_SECURITY
-       if (geteuid() != 0) {
-               DEBUG(0, ("smbldap_open: cannot access LDAP when not root..\n"));
-               return  LDAP_INSUFFICIENT_ACCESS;
-       }
-#endif
 
        if ((ldap_state->ldap_struct != NULL) && ((ldap_state->last_ping + SMBLDAP_DONT_PING_TIME) < time(NULL))) {
 
+#ifdef HAVE_UNIXSOCKET
                struct sockaddr_un addr;
+#else
+               struct sockaddr addr;
+#endif
                socklen_t len = sizeof(addr);
                int sd;
 
@@ -1049,7 +1184,17 @@ static int smbldap_open(struct smbldap_state *ldap_state)
 
        ldap_state->last_ping = time(NULL);
        ldap_state->pid = sys_getpid();
-       DEBUG(4,("The LDAP server is succesfully connected\n"));
+
+       TALLOC_FREE(ldap_state->idle_event);
+
+       if (ldap_state->event_context != NULL) {
+               ldap_state->idle_event = event_add_timed(
+                       ldap_state->event_context, NULL,
+                       timeval_current_ofs(SMBLDAP_IDLE_TIME, 0),
+                       smbldap_idle_fn, ldap_state);
+       }
+
+       DEBUG(4,("The LDAP server is successfully connected\n"));
 
        return LDAP_SUCCESS;
 }
@@ -1061,23 +1206,21 @@ static NTSTATUS smbldap_close(struct smbldap_state *ldap_state)
 {
        if (!ldap_state)
                return NT_STATUS_INVALID_PARAMETER;
-               
+
        if (ldap_state->ldap_struct != NULL) {
                ldap_unbind(ldap_state->ldap_struct);
                ldap_state->ldap_struct = NULL;
        }
 
        smbldap_delete_state(ldap_state);
-       
+
        DEBUG(5,("The connection to the LDAP server was closed\n"));
        /* maybe free the results here --metze */
-       
-       
 
        return NT_STATUS_OK;
 }
 
-static BOOL got_alarm;
+static bool got_alarm;
 
 static void (*old_handler)(int);
 
@@ -1164,15 +1307,16 @@ static int smbldap_search_ext(struct smbldap_state *ldap_state,
        char           *utf8_filter;
        time_t          endtime = time(NULL)+lp_ldap_timeout();
        struct          timeval timeout;
+       size_t          converted_size;
 
        SMB_ASSERT(ldap_state);
-       
+
        DEBUG(5,("smbldap_search_ext: base => [%s], filter => [%s], "
                 "scope => [%d]\n", base, filter, scope));
 
        if (ldap_state->last_rebind.tv_sec > 0) {
                struct timeval  tval;
-               SMB_BIG_INT     tdiff = 0;
+               int64_t tdiff = 0;
                int             sleep_time = 0;
 
                ZERO_STRUCT(tval);
@@ -1194,7 +1338,7 @@ static int smbldap_search_ext(struct smbldap_state *ldap_state,
                ZERO_STRUCT(ldap_state->last_rebind);
        }
 
-       if (push_utf8_allocate(&utf8_filter, filter) == (size_t)-1) {
+       if (!push_utf8_talloc(talloc_tos(), &utf8_filter, filter, &converted_size)) {
                return LDAP_NO_MEMORY;
        }
 
@@ -1222,16 +1366,27 @@ static int smbldap_search_ext(struct smbldap_state *ldap_state,
                                       sizelimit, res);
                if (rc != LDAP_SUCCESS) {
                        char *ld_error = NULL;
+                       int ld_errno;
+
+                       ldap_get_option(ldap_state->ldap_struct,
+                                       LDAP_OPT_ERROR_NUMBER, &ld_errno);
+
                        ldap_get_option(ldap_state->ldap_struct,
                                        LDAP_OPT_ERROR_STRING, &ld_error);
-                       DEBUG(10,("Failed search for base: %s, error: %s "
-                                 "(%s)\n", base, ldap_err2string(rc),
-                                 ld_error ? ld_error : "unknown"));
+                       DEBUG(10, ("Failed search for base: %s, error: %d (%s) "
+                                  "(%s)\n", base, ld_errno,
+                                  ldap_err2string(rc),
+                                  ld_error ? ld_error : "unknown"));
                        SAFE_FREE(ld_error);
+
+                       if (ld_errno == LDAP_SERVER_DOWN) {
+                               ldap_unbind(ldap_state->ldap_struct);
+                               ldap_state->ldap_struct = NULL;
+                       }
                }
        }
 
-       SAFE_FREE(utf8_filter);
+       TALLOC_FREE(utf8_filter);
 
        /* Teardown timeout. */
        CatchSignal(SIGALRM, SIGNAL_CAST SIG_IGN);
@@ -1263,7 +1418,7 @@ int smbldap_search_paged(struct smbldap_state *ldap_state,
        BerElement      *cookie_be = NULL;
        struct berval   *cookie_bv = NULL;
        int             tmp = 0, i, rc;
-       BOOL            critical = True;
+       bool            critical = True;
 
        *res = NULL;
 
@@ -1281,7 +1436,7 @@ int smbldap_search_paged(struct smbldap_state *ldap_state,
        /* construct cookie */
        if (*cookie != NULL) {
                ber_printf(cookie_be, "{iO}", (ber_int_t) pagesize, *cookie);
-               ber_bvfree(*cookie); /* don't need it from last time */
+               ber_bvfree((struct berval *)*cookie); /* don't need it from last time */
                *cookie = NULL;
        } else {
                ber_printf(cookie_be, "{io}", (ber_int_t) pagesize, "", 0);
@@ -1308,7 +1463,7 @@ int smbldap_search_paged(struct smbldap_state *ldap_state,
                goto done;
        }
 
-       DEBUG(3,("smbldap_search_paged: search was successfull\n"));
+       DEBUG(3,("smbldap_search_paged: search was successful\n"));
 
        rc = ldap_parse_result(ldap_state->ldap_struct, *res, NULL, NULL, 
                               NULL, NULL, &rcontrols,  0);
@@ -1349,12 +1504,13 @@ int smbldap_modify(struct smbldap_state *ldap_state, const char *dn, LDAPMod *at
        int             attempts = 0;
        char           *utf8_dn;
        time_t          endtime = time(NULL)+lp_ldap_timeout();
+       size_t          converted_size;
 
        SMB_ASSERT(ldap_state);
 
        DEBUG(5,("smbldap_modify: dn => [%s]\n", dn ));
 
-       if (push_utf8_allocate(&utf8_dn, dn) == (size_t)-1) {
+       if (!push_utf8_talloc(talloc_tos(), &utf8_dn, dn, &converted_size)) {
                return LDAP_NO_MEMORY;
        }
 
@@ -1362,16 +1518,27 @@ int smbldap_modify(struct smbldap_state *ldap_state, const char *dn, LDAPMod *at
                rc = ldap_modify_s(ldap_state->ldap_struct, utf8_dn, attrs);
                if (rc != LDAP_SUCCESS) {
                        char *ld_error = NULL;
+                       int ld_errno;
+
+                       ldap_get_option(ldap_state->ldap_struct,
+                                       LDAP_OPT_ERROR_NUMBER, &ld_errno);
+
                        ldap_get_option(ldap_state->ldap_struct,
                                        LDAP_OPT_ERROR_STRING, &ld_error);
-                       DEBUG(10,("Failed to modify dn: %s, error: %s "
-                                 "(%s)\n", dn, ldap_err2string(rc),
-                                 ld_error ? ld_error : "unknown"));
+                       DEBUG(10, ("Failed to modify dn: %s, error: %d (%s) "
+                                  "(%s)\n", dn, ld_errno,
+                                  ldap_err2string(rc),
+                                  ld_error ? ld_error : "unknown"));
                        SAFE_FREE(ld_error);
+
+                       if (ld_errno == LDAP_SERVER_DOWN) {
+                               ldap_unbind(ldap_state->ldap_struct);
+                               ldap_state->ldap_struct = NULL;
+                       }
                }
        }
-               
-       SAFE_FREE(utf8_dn);
+
+       TALLOC_FREE(utf8_dn);
        return rc;
 }
 
@@ -1381,12 +1548,13 @@ int smbldap_add(struct smbldap_state *ldap_state, const char *dn, LDAPMod *attrs
        int             attempts = 0;
        char           *utf8_dn;
        time_t          endtime = time(NULL)+lp_ldap_timeout();
-       
+       size_t          converted_size;
+
        SMB_ASSERT(ldap_state);
 
        DEBUG(5,("smbldap_add: dn => [%s]\n", dn ));
 
-       if (push_utf8_allocate(&utf8_dn, dn) == (size_t)-1) {
+       if (!push_utf8_talloc(talloc_tos(), &utf8_dn, dn, &converted_size)) {
                return LDAP_NO_MEMORY;
        }
 
@@ -1394,16 +1562,27 @@ int smbldap_add(struct smbldap_state *ldap_state, const char *dn, LDAPMod *attrs
                rc = ldap_add_s(ldap_state->ldap_struct, utf8_dn, attrs);
                if (rc != LDAP_SUCCESS) {
                        char *ld_error = NULL;
+                       int ld_errno;
+
+                       ldap_get_option(ldap_state->ldap_struct,
+                                       LDAP_OPT_ERROR_NUMBER, &ld_errno);
+
                        ldap_get_option(ldap_state->ldap_struct,
                                        LDAP_OPT_ERROR_STRING, &ld_error);
-                       DEBUG(10,("Failed to add dn: %s, error: %s "
-                                 "(%s)\n", dn, ldap_err2string(rc),
-                                 ld_error ? ld_error : "unknown"));
+                       DEBUG(10, ("Failed to add dn: %s, error: %d (%s) "
+                                  "(%s)\n", dn, ld_errno,
+                                  ldap_err2string(rc),
+                                  ld_error ? ld_error : "unknown"));
                        SAFE_FREE(ld_error);
+
+                       if (ld_errno == LDAP_SERVER_DOWN) {
+                               ldap_unbind(ldap_state->ldap_struct);
+                               ldap_state->ldap_struct = NULL;
+                       }
                }
        }
-       
-       SAFE_FREE(utf8_dn);
+
+       TALLOC_FREE(utf8_dn);
        return rc;
 }
 
@@ -1413,12 +1592,13 @@ int smbldap_delete(struct smbldap_state *ldap_state, const char *dn)
        int             attempts = 0;
        char           *utf8_dn;
        time_t          endtime = time(NULL)+lp_ldap_timeout();
-       
+       size_t          converted_size;
+
        SMB_ASSERT(ldap_state);
 
        DEBUG(5,("smbldap_delete: dn => [%s]\n", dn ));
 
-       if (push_utf8_allocate(&utf8_dn, dn) == (size_t)-1) {
+       if (!push_utf8_talloc(talloc_tos(), &utf8_dn, dn, &converted_size)) {
                return LDAP_NO_MEMORY;
        }
 
@@ -1426,16 +1606,27 @@ int smbldap_delete(struct smbldap_state *ldap_state, const char *dn)
                rc = ldap_delete_s(ldap_state->ldap_struct, utf8_dn);
                if (rc != LDAP_SUCCESS) {
                        char *ld_error = NULL;
+                       int ld_errno;
+
+                       ldap_get_option(ldap_state->ldap_struct,
+                                       LDAP_OPT_ERROR_NUMBER, &ld_errno);
+
                        ldap_get_option(ldap_state->ldap_struct,
                                        LDAP_OPT_ERROR_STRING, &ld_error);
-                       DEBUG(10,("Failed to delete dn: %s, error: %s "
-                                 "(%s)\n", dn, ldap_err2string(rc),
-                                 ld_error ? ld_error : "unknown"));
+                       DEBUG(10, ("Failed to delete dn: %s, error: %d (%s) "
+                                  "(%s)\n", dn, ld_errno,
+                                  ldap_err2string(rc),
+                                  ld_error ? ld_error : "unknown"));
                        SAFE_FREE(ld_error);
+
+                       if (ld_errno == LDAP_SERVER_DOWN) {
+                               ldap_unbind(ldap_state->ldap_struct);
+                               ldap_state->ldap_struct = NULL;
+                       }
                }
        }
-       
-       SAFE_FREE(utf8_dn);
+
+       TALLOC_FREE(utf8_dn);
        return rc;
 }
 
@@ -1447,7 +1638,7 @@ int smbldap_extended_operation(struct smbldap_state *ldap_state,
        int             rc = LDAP_SERVER_DOWN;
        int             attempts = 0;
        time_t          endtime = time(NULL)+lp_ldap_timeout();
-       
+
        if (!ldap_state)
                return (-1);
 
@@ -1457,15 +1648,26 @@ int smbldap_extended_operation(struct smbldap_state *ldap_state,
                                               clientctrls, retoidp, retdatap);
                if (rc != LDAP_SUCCESS) {
                        char *ld_error = NULL;
+                       int ld_errno;
+
+                       ldap_get_option(ldap_state->ldap_struct,
+                                       LDAP_OPT_ERROR_NUMBER, &ld_errno);
+
                        ldap_get_option(ldap_state->ldap_struct,
                                        LDAP_OPT_ERROR_STRING, &ld_error);
-                       DEBUG(10,("Extended operation failed with error: %s "
-                                 "(%s)\n", ldap_err2string(rc),
-                                 ld_error ? ld_error : "unknown"));
+                       DEBUG(10, ("Extended operation failed with error: "
+                                  "%d (%s) (%s)\n", ld_errno,
+                                  ldap_err2string(rc),
+                                  ld_error ? ld_error : "unknown"));
                        SAFE_FREE(ld_error);
+
+                       if (ld_errno == LDAP_SERVER_DOWN) {
+                               ldap_unbind(ldap_state->ldap_struct);
+                               ldap_state->ldap_struct = NULL;
+                       }
                }
        }
-               
+
        return rc;
 }
 
@@ -1480,20 +1682,31 @@ int smbldap_search_suffix (struct smbldap_state *ldap_state,
                              filter, search_attr, 0, result);
 }
 
-static void smbldap_idle_fn(void **data, time_t *interval, time_t now)
+static void smbldap_idle_fn(struct event_context *event_ctx,
+                           struct timed_event *te,
+                           struct timeval now,
+                           void *private_data)
 {
-       struct smbldap_state *state = (struct smbldap_state *)(*data);
+       struct smbldap_state *state = (struct smbldap_state *)private_data;
+
+       TALLOC_FREE(state->idle_event);
 
        if (state->ldap_struct == NULL) {
                DEBUG(10,("ldap connection not connected...\n"));
                return;
        }
-               
-       if ((state->last_use+SMBLDAP_IDLE_TIME) > now) {
+
+       if ((state->last_use+SMBLDAP_IDLE_TIME) > now.tv_sec) {
                DEBUG(10,("ldap connection not idle...\n"));
+
+               state->idle_event = event_add_timed(
+                       event_ctx, NULL,
+                       timeval_add(&now, SMBLDAP_IDLE_TIME, 0),
+                       smbldap_idle_fn,
+                       private_data);
                return;
        }
-               
+
        DEBUG(7,("ldap connection idle...closing connection\n"));
        smbldap_close(state);
 }
@@ -1505,7 +1718,7 @@ static void smbldap_idle_fn(void **data, time_t *interval, time_t now)
 void smbldap_free_struct(struct smbldap_state **ldap_state) 
 {
        smbldap_close(*ldap_state);
-       
+
        if ((*ldap_state)->bind_secret) {
                memset((*ldap_state)->bind_secret, '\0', strlen((*ldap_state)->bind_secret));
        }
@@ -1513,7 +1726,7 @@ void smbldap_free_struct(struct smbldap_state **ldap_state)
        SAFE_FREE((*ldap_state)->bind_dn);
        SAFE_FREE((*ldap_state)->bind_secret);
 
-       smb_unregister_idle_event((*ldap_state)->event_id);
+       TALLOC_FREE((*ldap_state)->idle_event);
 
        *ldap_state = NULL;
 
@@ -1525,7 +1738,9 @@ void smbldap_free_struct(struct smbldap_state **ldap_state)
  Intitalise the 'general' ldap structures, on which ldap operations may be conducted
  *********************************************************************/
 
-NTSTATUS smbldap_init(TALLOC_CTX *mem_ctx, const char *location, struct smbldap_state **smbldap_state) 
+NTSTATUS smbldap_init(TALLOC_CTX *mem_ctx, struct event_context *event_ctx,
+                     const char *location,
+                     struct smbldap_state **smbldap_state)
 {
        *smbldap_state = TALLOC_ZERO_P(mem_ctx, struct smbldap_state);
        if (!*smbldap_state) {
@@ -1539,50 +1754,24 @@ NTSTATUS smbldap_init(TALLOC_CTX *mem_ctx, const char *location, struct smbldap_
                (*smbldap_state)->uri = "ldap://localhost";
        }
 
-       (*smbldap_state)->event_id =
-               smb_register_idle_event(smbldap_idle_fn, (void *)(*smbldap_state),
-                                       SMBLDAP_IDLE_TIME);
-
-       if ((*smbldap_state)->event_id == SMB_EVENT_ID_INVALID) {
-               DEBUG(0,("Failed to register LDAP idle event!\n"));
-               return NT_STATUS_INVALID_HANDLE;
-       }
+       (*smbldap_state)->event_context = event_ctx;
 
        return NT_STATUS_OK;
 }
 
-/*******************************************************************
- Return a copy of the DN for a LDAPMessage. Convert from utf8 to CH_UNIX.
-********************************************************************/
-char *smbldap_get_dn(LDAP *ld, LDAPMessage *entry)
-{
-       char *utf8_dn, *unix_dn;
-
-       utf8_dn = ldap_get_dn(ld, entry);
-       if (!utf8_dn) {
-               DEBUG (5, ("smbldap_get_dn: ldap_get_dn failed\n"));
-               return NULL;
-       }
-       if (pull_utf8_allocate(&unix_dn, utf8_dn) == (size_t)-1) {
-               DEBUG (0, ("smbldap_get_dn: String conversion failure utf8 [%s]\n", utf8_dn));
-               return NULL;
-       }
-       ldap_memfree(utf8_dn);
-       return unix_dn;
-}
-
- const char *smbldap_talloc_dn(TALLOC_CTX *mem_ctx, LDAP *ld,
-                              LDAPMessage *entry)
+ char *smbldap_talloc_dn(TALLOC_CTX *mem_ctx, LDAP *ld,
+                        LDAPMessage *entry)
 {
        char *utf8_dn, *unix_dn;
+       size_t converted_size;
 
        utf8_dn = ldap_get_dn(ld, entry);
        if (!utf8_dn) {
-               DEBUG (5, ("smbldap_get_dn: ldap_get_dn failed\n"));
+               DEBUG (5, ("smbldap_talloc_dn: ldap_get_dn failed\n"));
                return NULL;
        }
-       if (pull_utf8_talloc(mem_ctx, &unix_dn, utf8_dn) == (size_t)-1) {
-               DEBUG (0, ("smbldap_get_dn: String conversion failure utf8 "
+       if (!pull_utf8_talloc(mem_ctx, &unix_dn, utf8_dn, &converted_size)) {
+               DEBUG (0, ("smbldap_talloc_dn: String conversion failure utf8 "
                           "[%s]\n", utf8_dn));
                return NULL;
        }
@@ -1594,13 +1783,13 @@ char *smbldap_get_dn(LDAP *ld, LDAPMessage *entry)
  Check if root-dse has a certain Control or Extension
 ********************************************************************/
 
-static BOOL smbldap_check_root_dse(LDAP *ld, const char **attrs, const char *value) 
+static bool smbldap_check_root_dse(LDAP *ld, const char **attrs, const char *value) 
 {
        LDAPMessage *msg = NULL;
        LDAPMessage *entry = NULL;
        char **values = NULL;
        int rc, num_result, num_values, i;
-       BOOL result = False;
+       bool result = False;
 
        if (!attrs[0]) {
                DEBUG(3,("smbldap_check_root_dse: nothing to look for\n"));
@@ -1670,7 +1859,7 @@ static BOOL smbldap_check_root_dse(LDAP *ld, const char **attrs, const char *val
  Check if LDAP-Server supports a certain Control (OID in string format)
 ********************************************************************/
 
-BOOL smbldap_has_control(LDAP *ld, const char *control)
+bool smbldap_has_control(LDAP *ld, const char *control)
 {
        const char *attrs[] = { "supportedControl", NULL };
        return smbldap_check_root_dse(ld, attrs, control);
@@ -1680,7 +1869,7 @@ BOOL smbldap_has_control(LDAP *ld, const char *control)
  Check if LDAP-Server supports a certain Extension (OID in string format)
 ********************************************************************/
 
-BOOL smbldap_has_extension(LDAP *ld, const char *extension)
+bool smbldap_has_extension(LDAP *ld, const char *extension)
 {
        const char *attrs[] = { "supportedExtension", NULL };
        return smbldap_check_root_dse(ld, attrs, extension);
@@ -1690,8 +1879,29 @@ BOOL smbldap_has_extension(LDAP *ld, const char *extension)
  Check if LDAP-Server holds a given namingContext
 ********************************************************************/
 
-BOOL smbldap_has_naming_context(LDAP *ld, const char *naming_context)
+bool smbldap_has_naming_context(LDAP *ld, const char *naming_context)
 {
        const char *attrs[] = { "namingContexts", NULL };
        return smbldap_check_root_dse(ld, attrs, naming_context);
 }
+
+bool smbldap_set_creds(struct smbldap_state *ldap_state, bool anon, const char *dn, const char *secret)
+{
+       ldap_state->anonymous = anon;
+
+       /* free any previously set credential */
+
+       SAFE_FREE(ldap_state->bind_dn);
+       if (ldap_state->bind_secret) {
+               /* make sure secrets are zeroed out of memory */
+               memset(ldap_state->bind_secret, '\0', strlen(ldap_state->bind_secret));
+               SAFE_FREE(ldap_state->bind_secret);
+       }
+
+       if ( ! anon) {
+               ldap_state->bind_dn = SMB_STRDUP(dn);
+               ldap_state->bind_secret = SMB_STRDUP(secret);
+       }
+
+       return True;
+}