pyldb: p3k readiness: allow single unicode string in msg element
[nivanova/samba-autobuild/.git] / lib / ldb / pyldb.c
index 67a35771862eea732a3dfd628025f0888542a40b..b65e25525ad0aa6158b90ac1fa31b57d43715d3b 100644 (file)
 
 #include <Python.h>
 #include "ldb_private.h"
+#include "ldb_handlers.h"
 #include "pyldb.h"
+#include "dlinklist.h"
+
+struct py_ldb_search_iterator_reply;
+
+typedef struct {
+       PyObject_HEAD
+       TALLOC_CTX *mem_ctx;
+       PyLdbObject *ldb;
+       struct {
+               struct ldb_request *req;
+               struct py_ldb_search_iterator_reply *next;
+               struct py_ldb_search_iterator_reply *result;
+               PyObject *exception;
+       } state;
+} PyLdbSearchIteratorObject;
+
+struct py_ldb_search_iterator_reply {
+       struct py_ldb_search_iterator_reply *prev, *next;
+       PyLdbSearchIteratorObject *py_iter;
+       PyObject *obj;
+};
 
 void initldb(void);
 static PyObject *PyLdbMessage_FromMessage(struct ldb_message *msg);
@@ -38,6 +60,7 @@ static PyObject *PyExc_LdbError;
 
 static PyTypeObject PyLdbControl;
 static PyTypeObject PyLdbResult;
+static PyTypeObject PyLdbSearchIterator;
 static PyTypeObject PyLdbMessage;
 #define PyLdbMessage_Check(ob) PyObject_TypeCheck(ob, &PyLdbMessage)
 static PyTypeObject PyLdbModule;
@@ -57,15 +80,51 @@ static struct ldb_message_element *PyObject_AsMessageElement(
                                                      unsigned int flags,
                                                      const char *attr_name);
 
-/* There's no Py_ssize_t in 2.4, apparently */
-#if PY_MAJOR_VERSION == 2 && PY_MINOR_VERSION < 5
-typedef int Py_ssize_t;
-typedef inquiry lenfunc;
-typedef intargfunc ssizeargfunc;
+#if PY_MAJOR_VERSION >= 3
+#define PyStr_Check PyUnicode_Check
+#define PyStr_FromString PyUnicode_FromString
+#define PyStr_FromStringAndSize PyUnicode_FromStringAndSize
+#define PyStr_FromFormat PyUnicode_FromFormat
+#define PyStr_FromFormatV PyUnicode_FromFormatV
+#define PyStr_AsUTF8 PyUnicode_AsUTF8
+#define PyStr_AsUTF8AndSize PyUnicode_AsUTF8AndSize
+#define PyInt_FromLong PyLong_FromLong
+#else
+#define PyStr_Check PyString_Check
+#define PyStr_FromString PyString_FromString
+#define PyStr_FromStringAndSize PyString_FromStringAndSize
+#define PyStr_FromFormat PyString_FromFormat
+#define PyStr_FromFormatV PyString_FromFormatV
+#define PyStr_AsUTF8 PyString_AsString
+
+const char *PyStr_AsUTF8AndSize(PyObject *pystr, Py_ssize_t *sizeptr);
+const char *
+PyStr_AsUTF8AndSize(PyObject *pystr, Py_ssize_t *sizeptr)
+{
+       const char * ret = PyString_AsString(pystr);
+       if (ret == NULL)
+               return NULL;
+       *sizeptr = PyString_Size(pystr);
+       return ret;
+}
 #endif
 
-#define SIGN(a) (((a) == 0)?0:((a) < 0?-1:1))
-
+static PyObject *richcmp(int cmp_val, int op)
+{
+       int ret;
+       switch (op) {
+               case Py_LT: ret = cmp_val < 0;  break;
+               case Py_LE: ret = cmp_val <= 0; break;
+               case Py_EQ: ret = cmp_val == 0; break;
+               case Py_NE: ret = cmp_val != 0; break;
+               case Py_GT: ret = cmp_val > 0;  break;
+               case Py_GE: ret = cmp_val >= 0; break;
+               default:
+                       Py_INCREF(Py_NotImplemented);
+                       return Py_NotImplemented;
+       }
+       return PyBool_FromLong(ret);
+}
 
 
 static PyObject *py_ldb_control_str(PyLdbControlObject *self)
@@ -76,9 +135,9 @@ static PyObject *py_ldb_control_str(PyLdbControlObject *self)
                        PyErr_NoMemory();
                        return NULL;
                }
-               return PyString_FromString(control);
+               return PyStr_FromString(control);
        } else {
-               return PyString_FromFormat("ldb control");
+               return PyStr_FromString("ldb control");
        }
 }
 
@@ -91,9 +150,32 @@ static void py_ldb_control_dealloc(PyLdbControlObject *self)
        Py_TYPE(self)->tp_free(self);
 }
 
+/* Create a text (rather than bytes) interface for a LDB result object */
+static PyObject *wrap_text(const char *type, PyObject *wrapped)
+{
+       PyObject *mod, *cls, *constructor, *inst;
+       mod = PyImport_ImportModule("_ldb_text");
+       if (mod == NULL)
+               return NULL;
+       cls = PyObject_GetAttrString(mod, type);
+       Py_DECREF(mod);
+       if (cls == NULL) {
+               Py_DECREF(mod);
+               return NULL;
+       }
+       constructor = PyObject_GetAttrString(cls, "_wrap");
+       Py_DECREF(cls);
+       if (constructor == NULL) {
+               return NULL;
+       }
+       inst = PyObject_CallFunction(constructor, discard_const_p(char, "O"), wrapped);
+       Py_DECREF(constructor);
+       return inst;
+}
+
 static PyObject *py_ldb_control_get_oid(PyLdbControlObject *self)
 {
-       return PyString_FromString(self->data->oid);
+       return PyStr_FromString(self->data->oid);
 }
 
 static PyObject *py_ldb_control_get_critical(PyLdbControlObject *self)
@@ -121,9 +203,9 @@ static PyObject *py_ldb_control_new(PyTypeObject *type, PyObject *args, PyObject
        TALLOC_CTX *mem_ctx;
        struct ldb_context *ldb_ctx;
 
-       if (!PyArg_ParseTupleAndKeywords(args, kwargs, "Os",
+       if (!PyArg_ParseTupleAndKeywords(args, kwargs, "O!s",
                                         discard_const_p(char *, kwnames),
-                                        &py_ldb, &data))
+                                        &PyLdb, &py_ldb, &data))
                return NULL;
 
        mem_ctx = talloc_new(NULL);
@@ -191,7 +273,12 @@ static void PyErr_SetLdbError(PyObject *error, int ret, struct ldb_context *ldb_
 
 static PyObject *PyObject_FromLdbValue(const struct ldb_val *val)
 {
-       return PyString_FromStringAndSize((const char *)val->data, val->length);
+       return PyBytes_FromStringAndSize((const char *)val->data, val->length);
+}
+
+static PyObject *PyStr_FromLdbValue(const struct ldb_val *val)
+{
+       return PyStr_FromStringAndSize((const char *)val->data, val->length);
 }
 
 /**
@@ -317,7 +404,7 @@ static PyObject *PyLdbResult_FromResult(struct ldb_result *result)
        }
 
        for (i = 0;result->refs && result->refs[i]; i++) {
-               PyList_SetItem(referals, i, PyString_FromString(result->refs[i]));
+               PyList_SetItem(referals, i, PyStr_FromString(result->refs[i]));
        }
        ret->referals = referals;
        return (PyObject *)ret;
@@ -375,22 +462,22 @@ static PyObject *py_ldb_dn_is_null(PyLdbDnObject *self)
  
 static PyObject *py_ldb_dn_get_casefold(PyLdbDnObject *self)
 {
-       return PyString_FromString(ldb_dn_get_casefold(self->dn));
+       return PyStr_FromString(ldb_dn_get_casefold(self->dn));
 }
 
 static PyObject *py_ldb_dn_get_linearized(PyLdbDnObject *self)
 {
-       return PyString_FromString(ldb_dn_get_linearized(self->dn));
+       return PyStr_FromString(ldb_dn_get_linearized(self->dn));
 }
 
 static PyObject *py_ldb_dn_canonical_str(PyLdbDnObject *self)
 {
-       return PyString_FromString(ldb_dn_canonical_string(self->dn, self->dn));
+       return PyStr_FromString(ldb_dn_canonical_string(self->dn, self->dn));
 }
 
 static PyObject *py_ldb_dn_canonical_ex_str(PyLdbDnObject *self)
 {
-       return PyString_FromString(ldb_dn_canonical_ex_string(self->dn, self->dn));
+       return PyStr_FromString(ldb_dn_canonical_ex_string(self->dn, self->dn));
 }
 
 static PyObject *py_ldb_dn_extended_str(PyLdbDnObject *self, PyObject *args, PyObject *kwargs)
@@ -401,7 +488,7 @@ static PyObject *py_ldb_dn_extended_str(PyLdbDnObject *self, PyObject *args, PyO
                                         discard_const_p(char *, kwnames),
                                         &mode))
                return NULL;
-       return PyString_FromString(ldb_dn_get_extended_linearized(self->dn, self->dn, mode));
+       return PyStr_FromString(ldb_dn_get_extended_linearized(self->dn, self->dn, mode));
 }
 
 static PyObject *py_ldb_dn_get_extended_component(PyLdbDnObject *self, PyObject *args)
@@ -416,28 +503,25 @@ static PyObject *py_ldb_dn_get_extended_component(PyLdbDnObject *self, PyObject
                Py_RETURN_NONE;
        }
 
-       return PyString_FromStringAndSize((const char *)val->data, val->length);
+       return PyBytes_FromStringAndSize((const char *)val->data, val->length);
 }
 
 static PyObject *py_ldb_dn_set_extended_component(PyLdbDnObject *self, PyObject *args)
 {
        char *name;
-       PyObject *value;
        int err;
+       uint8_t *value;
+       Py_ssize_t size = 0;
 
-       if (!PyArg_ParseTuple(args, "sO", &name, &value))
+       if (!PyArg_ParseTuple(args, "sz#", &name, (const char**)&value, &size))
                return NULL;
 
-       if (value == Py_None) {
+       if (value == NULL) {
                err = ldb_dn_set_extended_component(self->dn, name, NULL);
        } else {
                struct ldb_val val;
-               if (!PyString_Check(value)) {
-                       PyErr_SetString(PyExc_TypeError, "Expected a string argument");
-                       return NULL;
-               }
-               val.data = (uint8_t *)PyString_AsString(value);
-               val.length = PyString_Size(value);
+               val.data = (uint8_t *)value;
+               val.length = size;
                err = ldb_dn_set_extended_component(self->dn, name, &val);
        }
 
@@ -451,7 +535,19 @@ static PyObject *py_ldb_dn_set_extended_component(PyLdbDnObject *self, PyObject
 
 static PyObject *py_ldb_dn_repr(PyLdbDnObject *self)
 {
-       return PyString_FromFormat("Dn(%s)", PyObject_REPR(PyString_FromString(ldb_dn_get_linearized(self->dn))));
+       PyObject *str = PyStr_FromString(ldb_dn_get_linearized(self->dn));
+       PyObject *repr, *result;
+       if (str == NULL)
+               return NULL;
+       repr = PyObject_Repr(str);
+       if (repr == NULL) {
+               Py_DECREF(str);
+               return NULL;
+       }
+       result = PyStr_FromFormat("Dn(%s)", PyStr_AsUTF8(repr));
+       Py_DECREF(str);
+       Py_DECREF(repr);
+       return result;
 }
 
 static PyObject *py_ldb_dn_check_special(PyLdbDnObject *self, PyObject *args)
@@ -464,13 +560,15 @@ static PyObject *py_ldb_dn_check_special(PyLdbDnObject *self, PyObject *args)
        return PyBool_FromLong(ldb_dn_check_special(self->dn, name));
 }
 
-static int py_ldb_dn_compare(PyLdbDnObject *dn1, PyLdbDnObject *dn2)
+static PyObject *py_ldb_dn_richcmp(PyObject *dn1, PyObject *dn2, int op)
 {
        int ret;
-       ret = ldb_dn_compare(dn1->dn, dn2->dn);
-       if (ret < 0) ret = -1;
-       if (ret > 0) ret = 1;
-       return ret;
+       if (!pyldb_Dn_Check(dn2)) {
+               Py_INCREF(Py_NotImplemented);
+               return Py_NotImplemented;
+       }
+       ret = ldb_dn_compare(pyldb_Dn_AsDn(dn1), pyldb_Dn_AsDn(dn2));
+       return richcmp(ret, op);
 }
 
 static PyObject *py_ldb_dn_get_parent(PyLdbDnObject *self)
@@ -497,8 +595,6 @@ static PyObject *py_ldb_dn_get_parent(PyLdbDnObject *self)
        return (PyObject *)py_ret;
 }
 
-#define dn_ldb_ctx(dn) ((struct ldb_context *)dn)
-
 static PyObject *py_ldb_dn_add_child(PyLdbDnObject *self, PyObject *args)
 {
        PyObject *py_other;
@@ -508,7 +604,7 @@ static PyObject *py_ldb_dn_add_child(PyLdbDnObject *self, PyObject *args)
 
        dn = pyldb_Dn_AsDn((PyObject *)self);
 
-       if (!pyldb_Object_AsDn(NULL, py_other, dn_ldb_ctx(dn), &other))
+       if (!pyldb_Object_AsDn(NULL, py_other, ldb_dn_get_ldb_context(dn), &other))
                return NULL;
 
        return PyBool_FromLong(ldb_dn_add_child(dn, other));
@@ -523,7 +619,7 @@ static PyObject *py_ldb_dn_add_base(PyLdbDnObject *self, PyObject *args)
 
        dn = pyldb_Dn_AsDn((PyObject *)self);
 
-       if (!pyldb_Object_AsDn(NULL, py_other, dn_ldb_ctx(dn), &other))
+       if (!pyldb_Object_AsDn(NULL, py_other, ldb_dn_get_ldb_context(dn), &other))
                return NULL;
 
        return PyBool_FromLong(ldb_dn_add_base(dn, other));
@@ -550,7 +646,7 @@ static PyObject *py_ldb_dn_is_child_of(PyLdbDnObject *self, PyObject *args)
 
        dn = pyldb_Dn_AsDn((PyObject *)self);
 
-       if (!pyldb_Object_AsDn(NULL, py_base, dn_ldb_ctx(dn), &base))
+       if (!pyldb_Object_AsDn(NULL, py_base, ldb_dn_get_ldb_context(dn), &base))
                return NULL;
 
        return PyBool_FromLong(ldb_dn_compare_base(base, dn) == 0);
@@ -572,7 +668,7 @@ static PyObject *py_ldb_dn_get_component_name(PyLdbDnObject *self, PyObject *arg
                Py_RETURN_NONE;
        }
 
-       return PyString_FromString(name);
+       return PyStr_FromString(name);
 }
 
 static PyObject *py_ldb_dn_get_component_value(PyLdbDnObject *self, PyObject *args)
@@ -591,28 +687,22 @@ static PyObject *py_ldb_dn_get_component_value(PyLdbDnObject *self, PyObject *ar
                Py_RETURN_NONE;
        }
 
-       return PyObject_FromLdbValue(val);
+       return PyStr_FromLdbValue(val);
 }
 
 static PyObject *py_ldb_dn_set_component(PyLdbDnObject *self, PyObject *args)
 {
        unsigned int num = 0;
-       char *name = NULL;
-       PyObject *value = Py_None;
+       char *name = NULL, *value = NULL;
        struct ldb_val val = { NULL, };
        int err;
+       Py_ssize_t size = 0;
 
-       if (!PyArg_ParseTuple(args, "IsO", &num, &name, &value))
+       if (!PyArg_ParseTuple(args, "Iss#", &num, &name, &value, &size))
                return NULL;
 
-       if (value != Py_None) {
-               if (!PyString_Check(value)) {
-                       PyErr_SetString(PyExc_TypeError, "Expected a string argument");
-                       return NULL;
-               }
-               val.data = (uint8_t *)PyString_AsString(value);
-               val.length = PyString_Size(value);
-       }
+       val.data = (unsigned char*) value;
+       val.length = size;
 
        err = ldb_dn_set_component(self->dn, num, name, val);
        if (err != LDB_SUCCESS) {
@@ -635,7 +725,7 @@ static PyObject *py_ldb_dn_get_rdn_name(PyLdbDnObject *self)
                Py_RETURN_NONE;
        }
 
-       return PyString_FromString(name);
+       return PyStr_FromString(name);
 }
 
 static PyObject *py_ldb_dn_get_rdn_value(PyLdbDnObject *self)
@@ -650,7 +740,7 @@ static PyObject *py_ldb_dn_get_rdn_value(PyLdbDnObject *self)
                Py_RETURN_NONE;
        }
 
-       return PyObject_FromLdbValue(val);
+       return PyStr_FromLdbValue(val);
 }
 
 static PyMethodDef py_ldb_dn_methods[] = {
@@ -822,7 +912,7 @@ static PyTypeObject PyLdbDn = {
        .tp_methods = py_ldb_dn_methods,
        .tp_str = (reprfunc)py_ldb_dn_get_linearized,
        .tp_repr = (reprfunc)py_ldb_dn_repr,
-       .tp_compare = (cmpfunc)py_ldb_dn_compare,
+       .tp_richcompare = (richcmpfunc)py_ldb_dn_richcmp,
        .tp_as_sequence = &py_ldb_dn_seq,
        .tp_doc = "A LDB distinguished name.",
        .tp_new = py_ldb_dn_new,
@@ -836,9 +926,11 @@ static void py_ldb_debug(void *context, enum ldb_debug_level level, const char *
 static void py_ldb_debug(void *context, enum ldb_debug_level level, const char *fmt, va_list ap)
 {
        PyObject *fn = (PyObject *)context;
-       PyObject_CallFunction(fn, discard_const_p(char, "(i,O)"), level, PyString_FromFormatV(fmt, ap));
+       PyObject_CallFunction(fn, discard_const_p(char, "(i,O)"), level, PyStr_FromFormatV(fmt, ap));
 }
 
+static PyObject *py_ldb_debug_func;
+
 static PyObject *py_ldb_set_debug(PyObject *self, PyObject *args)
 {
        PyObject *cb;
@@ -847,8 +939,13 @@ static PyObject *py_ldb_set_debug(PyObject *self, PyObject *args)
        if (!PyArg_ParseTuple(args, "O", &cb))
                return NULL;
 
+       if (py_ldb_debug_func != NULL) {
+               Py_DECREF(py_ldb_debug_func);
+       }
+
        Py_INCREF(cb);
-       /* FIXME: Where do we DECREF cb ? */
+       /* FIXME: DECREF cb when exiting program */
+       py_ldb_debug_func = cb;
        ldb_ctx = pyldb_Ldb_AsLdbContext(self);
        PyErr_LDB_ERROR_IS_ERR_RAISE(PyExc_LdbError,
                ldb_set_debug(ldb_ctx, py_ldb_debug, cb),
@@ -926,7 +1023,7 @@ static PyObject *py_ldb_setup_wellknown_attributes(PyLdbObject *self)
 
 static PyObject *py_ldb_repr(PyLdbObject *self)
 {
-       return PyString_FromFormat("<ldb connection>");
+       return PyStr_FromString("<ldb connection>");
 }
 
 static PyObject *py_ldb_get_root_basedn(PyLdbObject *self)
@@ -962,8 +1059,8 @@ static PyObject *py_ldb_get_default_basedn(PyLdbObject *self)
        return py_ldb_dn_copy(dn);
 }
 
-static const char **PyList_AsStringList(TALLOC_CTX *mem_ctx, PyObject *list, 
-                                       const char *paramname)
+static const char **PyList_AsStrList(TALLOC_CTX *mem_ctx, PyObject *list,
+                    const char *paramname)
 {
        const char **ret;
        Py_ssize_t i;
@@ -978,13 +1075,20 @@ static const char **PyList_AsStringList(TALLOC_CTX *mem_ctx, PyObject *list,
        }
 
        for (i = 0; i < PyList_Size(list); i++) {
+               const char *str = NULL;
+               Py_ssize_t size;
                PyObject *item = PyList_GetItem(list, i);
-               if (!PyString_Check(item)) {
+               if (!PyStr_Check(item)) {
                        PyErr_Format(PyExc_TypeError, "%s should be strings", paramname);
+                       talloc_free(ret);
+                       return NULL;
+               }
+               str = PyStr_AsUTF8AndSize(item, &size);
+               if (str == NULL) {
+                       talloc_free(ret);
                        return NULL;
                }
-               ret[i] = talloc_strndup(ret, PyString_AsString(item),
-                                       PyString_Size(item));
+               ret[i] = talloc_strndup(ret, str, size);
        }
        ret[i] = NULL;
        return ret;
@@ -1010,7 +1114,7 @@ static int py_ldb_init(PyLdbObject *self, PyObject *args, PyObject *kwargs)
        if (py_options == Py_None) {
                options = NULL;
        } else {
-               options = PyList_AsStringList(ldb, py_options, "options");
+               options = PyList_AsStrList(ldb, py_options, "options");
                if (options == NULL)
                        return -1;
        }
@@ -1066,7 +1170,7 @@ static PyObject *py_ldb_connect(PyLdbObject *self, PyObject *args, PyObject *kwa
        if (py_options == Py_None) {
                options = NULL;
        } else {
-               options = PyList_AsStringList(NULL, py_options, "options");
+               options = PyList_AsStrList(NULL, py_options, "options");
                if (options == NULL)
                        return NULL;
        }
@@ -1108,7 +1212,11 @@ static PyObject *py_ldb_modify(PyLdbObject *self, PyObject *args, PyObject *kwar
        if (py_controls == Py_None) {
                parsed_controls = NULL;
        } else {
-               const char **controls = PyList_AsStringList(mem_ctx, py_controls, "controls");
+               const char **controls = PyList_AsStrList(mem_ctx, py_controls, "controls");
+               if (controls == NULL) {
+                       talloc_free(mem_ctx);
+                       return NULL;
+               }
                parsed_controls = ldb_parse_control_strings(ldb_ctx, mem_ctx, controls);
                talloc_free(controls);
        }
@@ -1131,7 +1239,7 @@ static PyObject *py_ldb_modify(PyLdbObject *self, PyObject *args, PyObject *kwar
 
        ret = ldb_build_mod_req(&req, ldb_ctx, mem_ctx, msg, parsed_controls,
                                NULL, ldb_op_default_callback, NULL);
-        if (ret != LDB_SUCCESS) {
+       if (ret != LDB_SUCCESS) {
                PyErr_SetString(PyExc_TypeError, "failed to build request");
                talloc_free(mem_ctx);
                return NULL;
@@ -1208,12 +1316,12 @@ static struct ldb_message *PyDict_AsMessage(TALLOC_CTX *mem_ctx,
        }
 
        while (PyDict_Next(py_obj, &dict_pos, &key, &value)) {
-               char *key_str = PyString_AsString(key);
+               char *key_str = PyStr_AsUTF8(key);
                if (ldb_attr_cmp(key_str, "dn") != 0) {
                        msg_el = PyObject_AsMessageElement(msg->elements, value,
                                                           mod_flags, key_str);
                        if (msg_el == NULL) {
-                               PyErr_SetString(PyExc_TypeError, "unable to import element");
+                               PyErr_Format(PyExc_TypeError, "unable to import element '%s'", key_str);
                                return NULL;
                        }
                        memcpy(&msg->elements[msg_pos], msg_el, sizeof(*msg_el));
@@ -1253,7 +1361,11 @@ static PyObject *py_ldb_add(PyLdbObject *self, PyObject *args, PyObject *kwargs)
        if (py_controls == Py_None) {
                parsed_controls = NULL;
        } else {
-               const char **controls = PyList_AsStringList(mem_ctx, py_controls, "controls");
+               const char **controls = PyList_AsStrList(mem_ctx, py_controls, "controls");
+               if (controls == NULL) {
+                       talloc_free(mem_ctx);
+                       return NULL;
+               }
                parsed_controls = ldb_parse_control_strings(ldb_ctx, mem_ctx, controls);
                talloc_free(controls);
        }
@@ -1342,7 +1454,11 @@ static PyObject *py_ldb_delete(PyLdbObject *self, PyObject *args, PyObject *kwar
        if (py_controls == Py_None) {
                parsed_controls = NULL;
        } else {
-               const char **controls = PyList_AsStringList(mem_ctx, py_controls, "controls");
+               const char **controls = PyList_AsStrList(mem_ctx, py_controls, "controls");
+               if (controls == NULL) {
+                       talloc_free(mem_ctx);
+                       return NULL;
+               }
                parsed_controls = ldb_parse_control_strings(ldb_ctx, mem_ctx, controls);
                talloc_free(controls);
        }
@@ -1416,7 +1532,11 @@ static PyObject *py_ldb_rename(PyLdbObject *self, PyObject *args, PyObject *kwar
        if (py_controls == Py_None) {
                parsed_controls = NULL;
        } else {
-               const char **controls = PyList_AsStringList(mem_ctx, py_controls, "controls");
+               const char **controls = PyList_AsStrList(mem_ctx, py_controls, "controls");
+               if (controls == NULL) {
+                       talloc_free(mem_ctx);
+                       return NULL;
+               }
                parsed_controls = ldb_parse_control_strings(ldb_ctx, mem_ctx, controls);
                talloc_free(controls);
        }
@@ -1537,7 +1657,7 @@ static PyObject *py_ldb_write_ldif(PyLdbObject *self, PyObject *args)
                return NULL;
        }
 
-       ret = PyString_FromString(string);
+       ret = PyStr_FromString(string);
 
        talloc_free(mem_ctx);
 
@@ -1546,7 +1666,7 @@ static PyObject *py_ldb_write_ldif(PyLdbObject *self, PyObject *args)
 
 static PyObject *py_ldb_parse_ldif(PyLdbObject *self, PyObject *args)
 {
-       PyObject *list;
+       PyObject *list, *ret;
        struct ldb_ldif *ldif;
        const char *s;
 
@@ -1573,7 +1693,9 @@ static PyObject *py_ldb_parse_ldif(PyLdbObject *self, PyObject *args)
                }
        }
        talloc_free(mem_ctx); /* The pyobject already has a reference to the things it needs */
-       return PyObject_GetIter(list);
+       ret = PyObject_GetIter(list);
+       Py_DECREF(list);
+       return ret;
 }
 
 static PyObject *py_ldb_msg_diff(PyLdbObject *self, PyObject *args)
@@ -1624,14 +1746,16 @@ static PyObject *py_ldb_schema_format_value(PyLdbObject *self, PyObject *args)
        PyObject *ret;
        char *element_name;
        PyObject *val;
+       Py_ssize_t size;
+       int result;
 
        if (!PyArg_ParseTuple(args, "sO", &element_name, &val))
                return NULL;
 
-       old_val.data = (uint8_t *)PyString_AsString(val);
-       old_val.length = PyString_Size(val);
+       result = PyBytes_AsStringAndSize(val, (char **)&old_val.data, &size);
+       old_val.length = size;
 
-       if (old_val.data == NULL) {
+       if (result != 0) {
                PyErr_SetString(PyExc_RuntimeError, "Failed to convert passed value to String");
                return NULL;
        }
@@ -1653,7 +1777,7 @@ static PyObject *py_ldb_schema_format_value(PyLdbObject *self, PyObject *args)
                Py_RETURN_NONE;
        }
 
-       ret = PyString_FromStringAndSize((const char *)new_val.data, new_val.length);
+       ret = PyBytes_FromStringAndSize((const char *)new_val.data, new_val.length);
 
        talloc_free(mem_ctx);
 
@@ -1695,7 +1819,7 @@ static PyObject *py_ldb_search(PyLdbObject *self, PyObject *args, PyObject *kwar
        if (py_attrs == Py_None) {
                attrs = NULL;
        } else {
-               attrs = PyList_AsStringList(mem_ctx, py_attrs, "attrs");
+               attrs = PyList_AsStrList(mem_ctx, py_attrs, "attrs");
                if (attrs == NULL) {
                        talloc_free(mem_ctx);
                        return NULL;
@@ -1705,8 +1829,8 @@ static PyObject *py_ldb_search(PyLdbObject *self, PyObject *args, PyObject *kwar
        if (py_base == Py_None) {
                base = ldb_get_default_basedn(ldb_ctx);
        } else {
-               if (!pyldb_Object_AsDn(ldb_ctx, py_base, ldb_ctx, &base)) {
-                       talloc_free(attrs);
+               if (!pyldb_Object_AsDn(mem_ctx, py_base, ldb_ctx, &base)) {
+                       talloc_free(mem_ctx);
                        return NULL;
                }
        }
@@ -1714,7 +1838,11 @@ static PyObject *py_ldb_search(PyLdbObject *self, PyObject *args, PyObject *kwar
        if (py_controls == Py_None) {
                parsed_controls = NULL;
        } else {
-               const char **controls = PyList_AsStringList(mem_ctx, py_controls, "controls");
+               const char **controls = PyList_AsStrList(mem_ctx, py_controls, "controls");
+               if (controls == NULL) {
+                       talloc_free(mem_ctx);
+                       return NULL;
+               }
                parsed_controls = ldb_parse_control_strings(ldb_ctx, mem_ctx, controls);
                talloc_free(controls);
        }
@@ -1763,6 +1891,200 @@ static PyObject *py_ldb_search(PyLdbObject *self, PyObject *args, PyObject *kwar
        return py_ret;
 }
 
+static int py_ldb_search_iterator_reply_destructor(struct py_ldb_search_iterator_reply *reply)
+{
+       if (reply->py_iter != NULL) {
+               DLIST_REMOVE(reply->py_iter->state.next, reply);
+               if (reply->py_iter->state.result == reply) {
+                       reply->py_iter->state.result = NULL;
+               }
+               reply->py_iter = NULL;
+       }
+
+       if (reply->obj != NULL) {
+               Py_DECREF(reply->obj);
+               reply->obj = NULL;
+       }
+
+       return 0;
+}
+
+static int py_ldb_search_iterator_callback(struct ldb_request *req,
+                                          struct ldb_reply *ares)
+{
+       PyLdbSearchIteratorObject *py_iter = (PyLdbSearchIteratorObject *)req->context;
+       struct ldb_result result = { .msgs = NULL };
+       struct py_ldb_search_iterator_reply *reply = NULL;
+
+       if (ares == NULL) {
+               return ldb_request_done(req, LDB_ERR_OPERATIONS_ERROR);
+       }
+
+       if (ares->error != LDB_SUCCESS) {
+               int ret = ares->error;
+               TALLOC_FREE(ares);
+               return ldb_request_done(req, ret);
+       }
+
+       reply = talloc_zero(py_iter->mem_ctx,
+                           struct py_ldb_search_iterator_reply);
+       if (reply == NULL) {
+               TALLOC_FREE(ares);
+               return ldb_request_done(req, LDB_ERR_OPERATIONS_ERROR);
+       }
+       reply->py_iter = py_iter;
+       talloc_set_destructor(reply, py_ldb_search_iterator_reply_destructor);
+
+       switch (ares->type) {
+       case LDB_REPLY_ENTRY:
+               reply->obj = PyLdbMessage_FromMessage(ares->message);
+               if (reply->obj == NULL) {
+                       TALLOC_FREE(ares);
+                       return ldb_request_done(req, LDB_ERR_OPERATIONS_ERROR);
+               }
+               DLIST_ADD_END(py_iter->state.next, reply);
+               TALLOC_FREE(ares);
+               return LDB_SUCCESS;
+
+       case LDB_REPLY_REFERRAL:
+               reply->obj = PyStr_FromString(ares->referral);
+               if (reply->obj == NULL) {
+                       TALLOC_FREE(ares);
+                       return ldb_request_done(req, LDB_ERR_OPERATIONS_ERROR);
+               }
+               DLIST_ADD_END(py_iter->state.next, reply);
+               TALLOC_FREE(ares);
+               return LDB_SUCCESS;
+
+       case LDB_REPLY_DONE:
+               result = (struct ldb_result) { .controls = ares->controls };
+               reply->obj = PyLdbResult_FromResult(&result);
+               if (reply->obj == NULL) {
+                       TALLOC_FREE(ares);
+                       return ldb_request_done(req, LDB_ERR_OPERATIONS_ERROR);
+               }
+               py_iter->state.result = reply;
+               TALLOC_FREE(ares);
+               return ldb_request_done(req, LDB_SUCCESS);
+       }
+
+       TALLOC_FREE(ares);
+       return ldb_request_done(req, LDB_ERR_OPERATIONS_ERROR);
+}
+
+static PyObject *py_ldb_search_iterator(PyLdbObject *self, PyObject *args, PyObject *kwargs)
+{
+       PyObject *py_base = Py_None;
+       int scope = LDB_SCOPE_DEFAULT;
+       int timeout = 0;
+       char *expr = NULL;
+       PyObject *py_attrs = Py_None;
+       PyObject *py_controls = Py_None;
+       const char * const kwnames[] = { "base", "scope", "expression", "attrs", "controls", "timeout", NULL };
+       int ret;
+       const char **attrs;
+       struct ldb_context *ldb_ctx;
+       struct ldb_control **parsed_controls;
+       struct ldb_dn *base;
+       PyLdbSearchIteratorObject *py_iter;
+
+       /* type "int" rather than "enum" for "scope" is intentional */
+       if (!PyArg_ParseTupleAndKeywords(args, kwargs, "|OizOOi",
+                                        discard_const_p(char *, kwnames),
+                                        &py_base, &scope, &expr, &py_attrs, &py_controls, &timeout))
+               return NULL;
+
+       py_iter = (PyLdbSearchIteratorObject *)PyLdbSearchIterator.tp_alloc(&PyLdbSearchIterator, 0);
+       if (py_iter == NULL) {
+               PyErr_NoMemory();
+               return NULL;
+       }
+       py_iter->ldb = self;
+       Py_INCREF(self);
+       ZERO_STRUCT(py_iter->state);
+       py_iter->mem_ctx = talloc_new(NULL);
+       if (py_iter->mem_ctx == NULL) {
+               Py_DECREF(py_iter);
+               PyErr_NoMemory();
+               return NULL;
+       }
+
+       ldb_ctx = pyldb_Ldb_AsLdbContext(self);
+
+       if (py_attrs == Py_None) {
+               attrs = NULL;
+       } else {
+               attrs = PyList_AsStrList(py_iter->mem_ctx, py_attrs, "attrs");
+               if (attrs == NULL) {
+                       Py_DECREF(py_iter);
+                       PyErr_NoMemory();
+                       return NULL;
+               }
+       }
+
+       if (py_base == Py_None) {
+               base = ldb_get_default_basedn(ldb_ctx);
+       } else {
+               if (!pyldb_Object_AsDn(py_iter->mem_ctx, py_base, ldb_ctx, &base)) {
+                       Py_DECREF(py_iter);
+                       PyErr_NoMemory();
+                       return NULL;
+               }
+       }
+
+       if (py_controls == Py_None) {
+               parsed_controls = NULL;
+       } else {
+               const char **controls = NULL;
+
+               controls = PyList_AsStrList(py_iter->mem_ctx,
+                                           py_controls, "controls");
+               if (controls == NULL) {
+                       Py_DECREF(py_iter);
+                       PyErr_NoMemory();
+                       return NULL;
+               }
+
+               parsed_controls = ldb_parse_control_strings(ldb_ctx,
+                                                           py_iter->mem_ctx,
+                                                           controls);
+               if (controls[0] != NULL && parsed_controls == NULL) {
+                       Py_DECREF(py_iter);
+                       PyErr_NoMemory();
+                       return NULL;
+               }
+               talloc_free(controls);
+       }
+
+       ret = ldb_build_search_req(&py_iter->state.req,
+                                  ldb_ctx,
+                                  py_iter->mem_ctx,
+                                  base,
+                                  scope,
+                                  expr,
+                                  attrs,
+                                  parsed_controls,
+                                  py_iter,
+                                  py_ldb_search_iterator_callback,
+                                  NULL);
+       if (ret != LDB_SUCCESS) {
+               Py_DECREF(py_iter);
+               PyErr_SetLdbError(PyExc_LdbError, ret, ldb_ctx);
+               return NULL;
+       }
+
+       ldb_set_timeout(ldb_ctx, py_iter->state.req, timeout);
+
+       ret = ldb_request(ldb_ctx, py_iter->state.req);
+       if (ret != LDB_SUCCESS) {
+               Py_DECREF(py_iter);
+               PyErr_SetLdbError(PyExc_LdbError, ret, ldb_ctx);
+               return NULL;
+       }
+
+       return (PyObject *)py_iter;
+}
+
 static PyObject *py_ldb_get_opaque(PyLdbObject *self, PyObject *args)
 {
        char *name;
@@ -1778,7 +2100,7 @@ static PyObject *py_ldb_get_opaque(PyLdbObject *self, PyObject *args)
 
        /* FIXME: More interpretation */
 
-       return Py_True;
+       Py_RETURN_TRUE;
 }
 
 static PyObject *py_ldb_set_opaque(PyLdbObject *self, PyObject *args)
@@ -1826,6 +2148,28 @@ static PyObject *py_ldb_sequence_number(PyLdbObject *self, PyObject *args)
 
        return PyLong_FromLongLong(value);
 }
+
+
+static const struct ldb_dn_extended_syntax test_dn_syntax = {
+       .name             = "TEST",
+       .read_fn          = ldb_handler_copy,
+       .write_clear_fn   = ldb_handler_copy,
+       .write_hex_fn     = ldb_handler_copy,
+};
+
+static PyObject *py_ldb_register_test_extensions(PyLdbObject *self)
+{
+       struct ldb_context *ldb = pyldb_Ldb_AsLdbContext(self);
+       int ret;
+
+       ret = ldb_dn_extended_add_syntax(ldb, LDB_ATTR_FLAG_FIXED, &test_dn_syntax);
+
+       PyErr_LDB_ERROR_IS_ERR_RAISE(PyExc_LdbError, ret, ldb);
+
+       Py_RETURN_NONE;
+}
+
+
 static PyMethodDef py_ldb_methods[] = {
        { "set_debug", (PyCFunction)py_ldb_set_debug, METH_VARARGS, 
                "S.set_debug(callback) -> None\n"
@@ -1875,7 +2219,18 @@ static PyMethodDef py_ldb_methods[] = {
                "S.rename(old_dn, new_dn, controls=None) -> None\n"
                "Rename an entry." },
        { "search", (PyCFunction)py_ldb_search, METH_VARARGS|METH_KEYWORDS,
-               "S.search(base=None, scope=None, expression=None, attrs=None, controls=None) -> msgs\n"
+               "S.search(base=None, scope=None, expression=None, attrs=None, controls=None) -> result\n"
+               "Search in a database.\n"
+               "\n"
+               ":param base: Optional base DN to search\n"
+               ":param scope: Search scope (SCOPE_BASE, SCOPE_ONELEVEL or SCOPE_SUBTREE)\n"
+               ":param expression: Optional search expression\n"
+               ":param attrs: Attributes to return (defaults to all)\n"
+               ":param controls: Optional list of controls\n"
+               ":return: ldb.Result object\n"
+       },
+       { "search_iterator", (PyCFunction)py_ldb_search_iterator, METH_VARARGS|METH_KEYWORDS,
+               "S.search_iterator(base=None, scope=None, expression=None, attrs=None, controls=None, timeout=None) -> iterator\n"
                "Search in a database.\n"
                "\n"
                ":param base: Optional base DN to search\n"
@@ -1883,7 +2238,8 @@ static PyMethodDef py_ldb_methods[] = {
                ":param expression: Optional search expression\n"
                ":param attrs: Attributes to return (defaults to all)\n"
                ":param controls: Optional list of controls\n"
-               ":return: Iterator over Message objects\n"
+               ":param timeout: Optional timeout in seconds (defaults to 300), 0 means the default, -1 no timeout\n"
+               ":return: ldb.SearchIterator object that provides results when they arrive\n"
        },
        { "schema_attribute_remove", (PyCFunction)py_ldb_schema_attribute_remove, METH_VARARGS,
                NULL },
@@ -1915,6 +2271,9 @@ static PyMethodDef py_ldb_methods[] = {
        { "sequence_number", (PyCFunction)py_ldb_sequence_number, METH_VARARGS,
                "S.sequence_number(type) -> value\n"
                "Return the value of the sequence according to the requested type" },
+       { "_register_test_extensions", (PyCFunction)py_ldb_register_test_extensions, METH_NOARGS,
+               "S._register_test_extensions() -> None\n"
+               "Register internal extensions used in testing" },
        { NULL },
 };
 
@@ -1934,7 +2293,11 @@ static PyObject *PyLdbModule_FromModule(struct ldb_module *mod)
 
 static PyObject *py_ldb_get_firstmodule(PyLdbObject *self, void *closure)
 {
-       return PyLdbModule_FromModule(pyldb_Ldb_AsLdbContext(self)->modules);
+       struct ldb_module *mod = pyldb_Ldb_AsLdbContext(self)->modules;
+       if (mod == NULL) {
+               Py_RETURN_NONE;
+       }
+       return PyLdbModule_FromModule(mod);
 }
 
 static PyGetSetDef py_ldb_getset[] = {
@@ -2083,7 +2446,7 @@ static PySequenceMethods py_ldb_result_seq = {
 
 static PyObject *py_ldb_result_repr(PyLdbObject *self)
 {
-       return PyString_FromFormat("<ldb result>");
+       return PyStr_FromString("<ldb result>");
 }
 
 
@@ -2100,15 +2463,156 @@ static PyTypeObject PyLdbResult = {
        .tp_flags = Py_TPFLAGS_DEFAULT|Py_TPFLAGS_BASETYPE,
 };
 
+static void py_ldb_search_iterator_dealloc(PyLdbSearchIteratorObject *self)
+{
+       Py_XDECREF(self->state.exception);
+       TALLOC_FREE(self->mem_ctx);
+       ZERO_STRUCT(self->state);
+       Py_DECREF(self->ldb);
+       Py_TYPE(self)->tp_free(self);
+}
+
+static PyObject *py_ldb_search_iterator_next(PyLdbSearchIteratorObject *self)
+{
+       PyObject *py_ret = NULL;
+
+       if (self->state.req == NULL) {
+               PyErr_SetString(PyExc_RuntimeError,
+                               "ldb.SearchIterator request already finished");
+               return NULL;
+       }
+
+       /*
+        * TODO: do we want a non-blocking mode?
+        * In future we may add an optional 'nonblocking'
+        * argument to search_iterator().
+        *
+        * For now we keep it simple and wait for at
+        * least one reply.
+        */
+
+       while (self->state.next == NULL) {
+               int ret;
+
+               if (self->state.result != NULL) {
+                       /*
+                        * We (already) got a final result from the server.
+                        *
+                        * We stop the iteration and let
+                        * py_ldb_search_iterator_result() will deliver
+                        * the result details.
+                        */
+                       TALLOC_FREE(self->state.req);
+                       PyErr_SetNone(PyExc_StopIteration);
+                       return NULL;
+               }
+
+               ret = ldb_wait(self->state.req->handle, LDB_WAIT_NONE);
+               if (ret != LDB_SUCCESS) {
+                       struct ldb_context *ldb_ctx;
+                       TALLOC_FREE(self->state.req);
+                       ldb_ctx = pyldb_Ldb_AsLdbContext(self->ldb);
+                       /*
+                        * We stop the iteration and let
+                        * py_ldb_search_iterator_result() will deliver
+                        * the exception.
+                        */
+                       self->state.exception = Py_BuildValue(discard_const_p(char, "(i,s)"),
+                                               ret, ldb_errstring(ldb_ctx));
+                       PyErr_SetNone(PyExc_StopIteration);
+                       return NULL;
+               }
+       }
+
+       py_ret = self->state.next->obj;
+       self->state.next->obj = NULL;
+       /* no TALLOC_FREE() as self->state.next is a list */
+       talloc_free(self->state.next);
+       return py_ret;
+}
+
+static PyObject *py_ldb_search_iterator_result(PyLdbSearchIteratorObject *self)
+{
+       PyObject *py_ret = NULL;
+
+       if (self->state.req != NULL) {
+               PyErr_SetString(PyExc_RuntimeError,
+                               "ldb.SearchIterator request running");
+               return NULL;
+       }
+
+       if (self->state.next != NULL) {
+               PyErr_SetString(PyExc_RuntimeError,
+                               "ldb.SearchIterator not fully consumed.");
+               return NULL;
+       }
+
+       if (self->state.exception != NULL) {
+               PyErr_SetObject(PyExc_LdbError, self->state.exception);
+               self->state.exception = NULL;
+               return NULL;
+       }
+
+       if (self->state.result == NULL) {
+               PyErr_SetString(PyExc_RuntimeError,
+                               "ldb.SearchIterator result already consumed");
+               return NULL;
+       }
+
+       py_ret = self->state.result->obj;
+       self->state.result->obj = NULL;
+       TALLOC_FREE(self->state.result);
+       return py_ret;
+}
+
+static PyObject *py_ldb_search_iterator_abandon(PyLdbSearchIteratorObject *self)
+{
+       if (self->state.req == NULL) {
+               PyErr_SetString(PyExc_RuntimeError,
+                               "ldb.SearchIterator request already finished");
+               return NULL;
+       }
+
+       Py_XDECREF(self->state.exception);
+       TALLOC_FREE(self->mem_ctx);
+       ZERO_STRUCT(self->state);
+       Py_RETURN_NONE;
+}
+
+static PyMethodDef py_ldb_search_iterator_methods[] = {
+       { "result", (PyCFunction)py_ldb_search_iterator_result, METH_NOARGS,
+               "S.result() -> ldb.Result (without msgs and referrals)\n" },
+       { "abandon", (PyCFunction)py_ldb_search_iterator_abandon, METH_NOARGS,
+               "S.abandon()\n" },
+       { NULL }
+};
+
+static PyObject *py_ldb_search_iterator_repr(PyLdbSearchIteratorObject *self)
+{
+       return PyStr_FromString("<ldb search iterator>");
+}
+
+static PyTypeObject PyLdbSearchIterator = {
+       .tp_name = "ldb.SearchIterator",
+       .tp_repr = (reprfunc)py_ldb_search_iterator_repr,
+       .tp_dealloc = (destructor)py_ldb_search_iterator_dealloc,
+       .tp_iter = PyObject_SelfIter,
+       .tp_iternext = (iternextfunc)py_ldb_search_iterator_next,
+       .tp_methods = py_ldb_search_iterator_methods,
+       .tp_basicsize = sizeof(PyLdbSearchIteratorObject),
+       .tp_doc = "LDB search_iterator.",
+       .tp_flags = Py_TPFLAGS_DEFAULT|Py_TPFLAGS_BASETYPE,
+};
+
 static PyObject *py_ldb_module_repr(PyLdbModuleObject *self)
 {
-       return PyString_FromFormat("<ldb module '%s'>",
+       return PyStr_FromFormat("<ldb module '%s'>",
                pyldb_Module_AsModule(self)->ops->name);
 }
 
 static PyObject *py_ldb_module_str(PyLdbModuleObject *self)
 {
-       return PyString_FromString(pyldb_Module_AsModule(self)->ops->name);
+       return PyStr_FromString(pyldb_Module_AsModule(self)->ops->name);
 }
 
 static PyObject *py_ldb_module_start_transaction(PyLdbModuleObject *self)
@@ -2139,9 +2643,9 @@ static PyObject *py_ldb_module_search(PyLdbModuleObject *self, PyObject *args, P
        const char * const*attrs;
 
        /* type "int" rather than "enum" for "scope" is intentional */
-       if (!PyArg_ParseTupleAndKeywords(args, kwargs, "OiOO",
+       if (!PyArg_ParseTupleAndKeywords(args, kwargs, "O!iOO",
                                         discard_const_p(char *, kwnames),
-                                        &py_base, &scope, &py_tree, &py_attrs))
+                                        &PyLdbDn, &py_base, &scope, &py_tree, &py_attrs))
                return NULL;
 
        mod = self->mod;
@@ -2149,7 +2653,7 @@ static PyObject *py_ldb_module_search(PyLdbModuleObject *self, PyObject *args, P
        if (py_attrs == Py_None) {
                attrs = NULL;
        } else {
-               attrs = PyList_AsStringList(NULL, py_attrs, "attrs");
+               attrs = PyList_AsStrList(NULL, py_attrs, "attrs");
                if (attrs == NULL)
                        return NULL;
        }
@@ -2183,7 +2687,7 @@ static PyObject *py_ldb_module_add(PyLdbModuleObject *self, PyObject *args)
        int ret;
        struct ldb_module *mod;
 
-       if (!PyArg_ParseTuple(args, "O", &py_message))
+       if (!PyArg_ParseTuple(args, "O!", &PyLdbMessage, &py_message))
                return NULL;
 
        req = talloc_zero(NULL, struct ldb_request);
@@ -2205,7 +2709,7 @@ static PyObject *py_ldb_module_modify(PyLdbModuleObject *self, PyObject *args)
        PyObject *py_message;
        struct ldb_module *mod;
 
-       if (!PyArg_ParseTuple(args, "O", &py_message))
+       if (!PyArg_ParseTuple(args, "O!", &PyLdbMessage, &py_message))
                return NULL;
 
        req = talloc_zero(NULL, struct ldb_request);
@@ -2226,7 +2730,7 @@ static PyObject *py_ldb_module_delete(PyLdbModuleObject *self, PyObject *args)
        struct ldb_request *req;
        PyObject *py_dn;
 
-       if (!PyArg_ParseTuple(args, "O", &py_dn))
+       if (!PyArg_ParseTuple(args, "O!", &PyLdbDn, &py_dn))
                return NULL;
 
        req = talloc_zero(NULL, struct ldb_request);
@@ -2246,7 +2750,7 @@ static PyObject *py_ldb_module_rename(PyLdbModuleObject *self, PyObject *args)
        struct ldb_request *req;
        PyObject *py_dn1, *py_dn2;
 
-       if (!PyArg_ParseTuple(args, "OO", &py_dn1, &py_dn2))
+       if (!PyArg_ParseTuple(args, "O!O!", &PyLdbDn, &py_dn1, &PyLdbDn, &py_dn2))
                return NULL;
 
        req = talloc_zero(NULL, struct ldb_request);
@@ -2313,6 +2817,9 @@ static struct ldb_message_element *PyObject_AsMessageElement(
                                                      const char *attr_name)
 {
        struct ldb_message_element *me;
+       const char *msg = NULL;
+       Py_ssize_t size;
+       int result;
 
        if (pyldb_MessageElement_Check(set_obj)) {
                PyLdbMessageElementObject *set_obj_as_me = (PyLdbMessageElementObject *)set_obj;
@@ -2332,28 +2839,58 @@ static struct ldb_message_element *PyObject_AsMessageElement(
 
        me->name = talloc_strdup(me, attr_name);
        me->flags = flags;
-       if (PyString_Check(set_obj)) {
+       if (PyBytes_Check(set_obj) || PyStr_Check(set_obj)) {
                me->num_values = 1;
                me->values = talloc_array(me, struct ldb_val, me->num_values);
-               me->values[0].length = PyString_Size(set_obj);
-               me->values[0].data = talloc_memdup(me, 
-                       (uint8_t *)PyString_AsString(set_obj), me->values[0].length+1);
+               if (PyBytes_Check(set_obj)) {
+                       char *_msg = NULL;
+                       result = PyBytes_AsStringAndSize(set_obj, &_msg, &size);
+                       if (result != 0) {
+                               talloc_free(me);
+                               return NULL;
+                       }
+                       msg = _msg;
+               } else {
+                       msg = PyStr_AsUTF8AndSize(set_obj, &size);
+                       if (msg == NULL) {
+                               talloc_free(me);
+                               return NULL;
+                       }
+               }
+               me->values[0].data = talloc_memdup(me,
+                                                  (const uint8_t *)msg,
+                                                  size+1);
+               me->values[0].length = size;
        } else if (PySequence_Check(set_obj)) {
                Py_ssize_t i;
                me->num_values = PySequence_Size(set_obj);
                me->values = talloc_array(me, struct ldb_val, me->num_values);
                for (i = 0; i < me->num_values; i++) {
                        PyObject *obj = PySequence_GetItem(set_obj, i);
-                       if (!PyString_Check(obj)) {
+                       if (PyBytes_Check(obj)) {
+                               char *_msg = NULL;
+                               result = PyBytes_AsStringAndSize(obj, &_msg, &size);
+                               if (result != 0) {
+                                       talloc_free(me);
+                                       return NULL;
+                               }
+                               msg = _msg;
+                       } else if (PyStr_Check(obj)) {
+                               msg = PyStr_AsUTF8AndSize(obj, &size);
+                               if (msg == NULL) {
+                                       talloc_free(me);
+                                       return NULL;
+                               }
+                       } else {
                                PyErr_Format(PyExc_TypeError,
                                             "Expected string as element %zd in list", i);
                                talloc_free(me);
                                return NULL;
                        }
-
-                       me->values[i].length = PyString_Size(obj);
-                       me->values[i].data = talloc_memdup(me, 
-                               (uint8_t *)PyString_AsString(obj), me->values[i].length+1);
+                       me->values[i].data = talloc_memdup(me,
+                                                          (const uint8_t *)msg,
+                                                          size+1);
+                       me->values[i].length = size;
                }
        } else {
                PyErr_Format(PyExc_TypeError,
@@ -2431,7 +2968,7 @@ static PyObject *py_ldb_msg_element_find(PyLdbMessageElementObject *self, Py_ssi
                PyErr_SetString(PyExc_IndexError, "Out of range");
                return NULL;
        }
-       return PyString_FromStringAndSize((char *)el->values[idx].data, el->values[idx].length);
+       return PyBytes_FromStringAndSize((char *)el->values[idx].data, el->values[idx].length);
 }
 
 static PySequenceMethods py_ldb_msg_element_seq = {
@@ -2439,18 +2976,25 @@ static PySequenceMethods py_ldb_msg_element_seq = {
        .sq_item = (ssizeargfunc)py_ldb_msg_element_find,
 };
 
-static int py_ldb_msg_element_cmp(PyLdbMessageElementObject *self, PyLdbMessageElementObject *other)
+static PyObject *py_ldb_msg_element_richcmp(PyObject *self, PyObject *other, int op)
 {
-       int ret = ldb_msg_element_compare(pyldb_MessageElement_AsMessageElement(self),
+       int ret;
+       if (!pyldb_MessageElement_Check(other)) {
+               Py_INCREF(Py_NotImplemented);
+               return Py_NotImplemented;
+       }
+       ret = ldb_msg_element_compare(pyldb_MessageElement_AsMessageElement(self),
                                                                          pyldb_MessageElement_AsMessageElement(other));
-       return SIGN(ret);
+       return richcmp(ret, op);
 }
 
 static PyObject *py_ldb_msg_element_iter(PyLdbMessageElementObject *self)
 {
        PyObject *el = ldb_msg_element_to_set(NULL,
                                              pyldb_MessageElement_AsMessageElement(self));
-       return PyObject_GetIter(el);
+       PyObject *ret = PyObject_GetIter(el);
+       Py_DECREF(el);
+       return ret;
 }
 
 static PyObject *PyLdbMessageElement_FromMessageElement(struct ldb_message_element *el, TALLOC_CTX *mem_ctx)
@@ -2479,6 +3023,9 @@ static PyObject *py_ldb_msg_element_new(PyTypeObject *type, PyObject *args, PyOb
        const char * const kwnames[] = { "elements", "flags", "name", NULL };
        PyLdbMessageElementObject *ret;
        TALLOC_CTX *mem_ctx;
+       const char *msg = NULL;
+       Py_ssize_t size;
+       int result;
 
        if (!PyArg_ParseTupleAndKeywords(args, kwargs, "|OIs",
                                         discard_const_p(char *, kwnames),
@@ -2500,7 +3047,8 @@ static PyObject *py_ldb_msg_element_new(PyTypeObject *type, PyObject *args, PyOb
 
        if (py_elements != NULL) {
                Py_ssize_t i;
-               if (PyString_Check(py_elements)) {
+               if (PyBytes_Check(py_elements) || PyStr_Check(py_elements)) {
+                       char *_msg = NULL;
                        el->num_values = 1;
                        el->values = talloc_array(el, struct ldb_val, 1);
                        if (el->values == NULL) {
@@ -2508,9 +3056,20 @@ static PyObject *py_ldb_msg_element_new(PyTypeObject *type, PyObject *args, PyOb
                                PyErr_NoMemory();
                                return NULL;
                        }
-                       el->values[0].length = PyString_Size(py_elements);
+                       if (PyBytes_Check(py_elements)) {
+                               result = PyBytes_AsStringAndSize(py_elements, &_msg, &size);
+                               msg = _msg;
+                       } else {
+                               msg = PyStr_AsUTF8AndSize(py_elements, &size);
+                               result = (msg == NULL) ? -1 : 0;
+                       }
+                       if (result != 0) {
+                               talloc_free(mem_ctx);
+                               return NULL;
+                       }
                        el->values[0].data = talloc_memdup(el->values, 
-                               (uint8_t *)PyString_AsString(py_elements), el->values[0].length+1);
+                               (const uint8_t *)msg, size + 1);
+                       el->values[0].length = size;
                } else if (PySequence_Check(py_elements)) {
                        el->num_values = PySequence_Size(py_elements);
                        el->values = talloc_array(el, struct ldb_val, el->num_values);
@@ -2525,15 +3084,25 @@ static PyObject *py_ldb_msg_element_new(PyTypeObject *type, PyObject *args, PyOb
                                        talloc_free(mem_ctx);
                                        return NULL;
                                }
-                               if (!PyString_Check(item)) {
+                               if (PyBytes_Check(item)) {
+                                       char *_msg = NULL;
+                                       result = PyBytes_AsStringAndSize(item, &_msg, &size);
+                                       msg = _msg;
+                               } else if (PyStr_Check(item)) {
+                                       msg = PyStr_AsUTF8AndSize(item, &size);
+                                       result = (msg == NULL) ? -1 : 0;
+                               } else {
                                        PyErr_Format(PyExc_TypeError, 
                                                     "Expected string as element %zd in list", i);
+                                       result = -1;
+                               }
+                               if (result != 0) {
                                        talloc_free(mem_ctx);
                                        return NULL;
                                }
-                               el->values[i].length = PyString_Size(item);
                                el->values[i].data = talloc_memdup(el,
-                                       (uint8_t *)PyString_AsString(item), el->values[i].length+1);
+                                       (const uint8_t *)msg, size+1);
+                               el->values[i].length = size;
                        }
                } else {
                        PyErr_SetString(PyExc_TypeError, 
@@ -2562,21 +3131,23 @@ static PyObject *py_ldb_msg_element_repr(PyLdbMessageElementObject *self)
        char *element_str = NULL;
        Py_ssize_t i;
        struct ldb_message_element *el = pyldb_MessageElement_AsMessageElement(self);
-       PyObject *ret;
+       PyObject *ret, *repr;
 
        for (i = 0; i < el->num_values; i++) {
                PyObject *o = py_ldb_msg_element_find(self, i);
+               repr = PyObject_Repr(o);
                if (element_str == NULL)
-                       element_str = talloc_strdup(NULL, PyObject_REPR(o));
+                       element_str = talloc_strdup(NULL, PyStr_AsUTF8(repr));
                else
-                       element_str = talloc_asprintf_append(element_str, ",%s", PyObject_REPR(o));
+                       element_str = talloc_asprintf_append(element_str, ",%s", PyStr_AsUTF8(repr));
+               Py_DECREF(repr);
        }
 
        if (element_str != NULL) {
-               ret = PyString_FromFormat("MessageElement([%s])", element_str);
+               ret = PyStr_FromFormat("MessageElement([%s])", element_str);
                talloc_free(element_str);
        } else {
-               ret = PyString_FromString("MessageElement([])");
+               ret = PyStr_FromString("MessageElement([])");
        }
 
        return ret;
@@ -2587,7 +3158,7 @@ static PyObject *py_ldb_msg_element_str(PyLdbMessageElementObject *self)
        struct ldb_message_element *el = pyldb_MessageElement_AsMessageElement(self);
 
        if (el->num_values == 1)
-               return PyString_FromStringAndSize((char *)el->values[0].data, el->values[0].length);
+               return PyStr_FromStringAndSize((char *)el->values[0].data, el->values[0].length);
        else
                Py_RETURN_NONE;
 }
@@ -2598,6 +3169,16 @@ static void py_ldb_msg_element_dealloc(PyLdbMessageElementObject *self)
        PyObject_Del(self);
 }
 
+static PyObject *py_ldb_msg_element_get_text(PyObject *self, void *closure)
+{
+       return wrap_text("MessageElementTextWrapper", self);
+}
+
+static PyGetSetDef py_ldb_msg_element_getset[] = {
+       { discard_const_p(char, "text"), (getter)py_ldb_msg_element_get_text, NULL, NULL },
+       { NULL }
+};
+
 static PyTypeObject PyLdbMessageElement = {
        .tp_name = "ldb.MessageElement",
        .tp_basicsize = sizeof(PyLdbMessageElementObject),
@@ -2605,7 +3186,8 @@ static PyTypeObject PyLdbMessageElement = {
        .tp_repr = (reprfunc)py_ldb_msg_element_repr,
        .tp_str = (reprfunc)py_ldb_msg_element_str,
        .tp_methods = py_ldb_msg_element_methods,
-       .tp_compare = (cmpfunc)py_ldb_msg_element_cmp,
+       .tp_getset = py_ldb_msg_element_getset,
+       .tp_richcompare = (richcmpfunc)py_ldb_msg_element_richcmp,
        .tp_iter = (getiterfunc)py_ldb_msg_element_iter,
        .tp_as_sequence = &py_ldb_msg_element_seq,
        .tp_new = py_ldb_msg_element_new,
@@ -2674,11 +3256,11 @@ static PyObject *py_ldb_msg_keys(PyLdbMessageObject *self)
        Py_ssize_t i, j = 0;
        PyObject *obj = PyList_New(msg->num_elements+(msg->dn != NULL?1:0));
        if (msg->dn != NULL) {
-               PyList_SetItem(obj, j, PyString_FromString("dn"));
+               PyList_SetItem(obj, j, PyStr_FromString("dn"));
                j++;
        }
        for (i = 0; i < msg->num_elements; i++) {
-               PyList_SetItem(obj, j, PyString_FromString(msg->elements[i].name));
+               PyList_SetItem(obj, j, PyStr_FromString(msg->elements[i].name));
                j++;
        }
        return obj;
@@ -2689,11 +3271,11 @@ static PyObject *py_ldb_msg_getitem_helper(PyLdbMessageObject *self, PyObject *p
        struct ldb_message_element *el;
        char *name;
        struct ldb_message *msg = pyldb_Message_AsMessage(self);
-       if (!PyString_Check(py_name)) {
+       name = PyStr_AsUTF8(py_name);
+       if (name == NULL) {
                PyErr_SetNone(PyExc_TypeError);
                return NULL;
        }
-       name = PyString_AsString(py_name);
        if (!ldb_attr_cmp(name, "dn"))
                return pyldb_Dn_FromDn(msg->dn);
        el = ldb_msg_find_element(msg, name);
@@ -2735,6 +3317,7 @@ static PyObject *py_ldb_msg_get(PyLdbMessageObject *self, PyObject *args, PyObje
 
        if (el == NULL || (idx != -1 && el->num_values <= idx)) {
                if (def != NULL) {
+                       Py_INCREF(def);
                        return def;
                }
                Py_RETURN_NONE;
@@ -2854,12 +3437,12 @@ static int py_ldb_msg_setitem(PyLdbMessageObject *self, PyObject *name, PyObject
 {
        char *attr_name;
 
-       if (!PyString_Check(name)) {
+       attr_name = PyStr_AsUTF8(name);
+       if (attr_name == NULL) {
                PyErr_SetNone(PyExc_TypeError);
                return -1;
        }
 
-       attr_name = PyString_AsString(name);
        if (value == NULL) {
                /* delitem */
                ldb_msg_remove_attr(self->msg, attr_name);
@@ -2962,7 +3545,7 @@ static int py_ldb_msg_set_dn(PyLdbMessageObject *self, PyObject *value, void *cl
 {
        struct ldb_message *msg = pyldb_Message_AsMessage(self);
        if (!pyldb_Dn_Check(value)) {
-               PyErr_SetNone(PyExc_TypeError);
+               PyErr_SetString(PyExc_TypeError, "expected dn");
                return -1;
        }
 
@@ -2970,17 +3553,29 @@ static int py_ldb_msg_set_dn(PyLdbMessageObject *self, PyObject *value, void *cl
        return 0;
 }
 
+static PyObject *py_ldb_msg_get_text(PyObject *self, void *closure)
+{
+       return wrap_text("MessageTextWrapper", self);
+}
+
 static PyGetSetDef py_ldb_msg_getset[] = {
        { discard_const_p(char, "dn"), (getter)py_ldb_msg_get_dn, (setter)py_ldb_msg_set_dn, NULL },
+       { discard_const_p(char, "text"), (getter)py_ldb_msg_get_text, NULL, NULL },
        { NULL }
 };
 
 static PyObject *py_ldb_msg_repr(PyLdbMessageObject *self)
 {
-       PyObject *dict = PyDict_New(), *ret;
+       PyObject *dict = PyDict_New(), *ret, *repr;
        if (PyDict_Update(dict, (PyObject *)self) != 0)
                return NULL;
-       ret = PyString_FromFormat("Message(%s)", PyObject_REPR(dict));
+       repr = PyObject_Repr(dict);
+       if (repr == NULL) {
+               Py_DECREF(dict);
+               return NULL;
+       }
+       ret = PyStr_FromFormat("Message(%s)", PyStr_AsUTF8(repr));
+       Py_DECREF(repr);
        Py_DECREF(dict);
        return ret;
 }
@@ -2991,41 +3586,48 @@ static void py_ldb_msg_dealloc(PyLdbMessageObject *self)
        PyObject_Del(self);
 }
 
-static int py_ldb_msg_compare(PyLdbMessageObject *py_msg1,
-                             PyLdbMessageObject *py_msg2)
+static PyObject *py_ldb_msg_richcmp(PyLdbMessageObject *py_msg1,
+                             PyLdbMessageObject *py_msg2, int op)
 {
-       struct ldb_message *msg1 = pyldb_Message_AsMessage(py_msg1),
-                          *msg2 = pyldb_Message_AsMessage(py_msg2);
+       struct ldb_message *msg1, *msg2;
        unsigned int i;
        int ret;
 
+       if (!PyLdbMessage_Check(py_msg2)) {
+               Py_INCREF(Py_NotImplemented);
+               return Py_NotImplemented;
+       }
+
+       msg1 = pyldb_Message_AsMessage(py_msg1),
+       msg2 = pyldb_Message_AsMessage(py_msg2);
+
        if ((msg1->dn != NULL) || (msg2->dn != NULL)) {
                ret = ldb_dn_compare(msg1->dn, msg2->dn);
                if (ret != 0) {
-                       return SIGN(ret);
+                       return richcmp(ret, op);
                }
        }
 
        ret = msg1->num_elements - msg2->num_elements;
        if (ret != 0) {
-               return SIGN(ret);
+               return richcmp(ret, op);
        }
 
        for (i = 0; i < msg1->num_elements; i++) {
                ret = ldb_msg_element_compare_name(&msg1->elements[i],
                                                   &msg2->elements[i]);
                if (ret != 0) {
-                       return SIGN(ret);
+                       return richcmp(ret, op);
                }
 
                ret = ldb_msg_element_compare(&msg1->elements[i],
                                              &msg2->elements[i]);
                if (ret != 0) {
-                       return SIGN(ret);
+                       return richcmp(ret, op);
                }
        }
 
-       return 0;
+       return richcmp(0, op);
 }
 
 static PyTypeObject PyLdbMessage = {
@@ -3039,7 +3641,7 @@ static PyTypeObject PyLdbMessage = {
        .tp_repr = (reprfunc)py_ldb_msg_repr,
        .tp_flags = Py_TPFLAGS_DEFAULT,
        .tp_iter = (getiterfunc)py_ldb_msg_iter,
-       .tp_compare = (cmpfunc)py_ldb_msg_compare,
+       .tp_richcompare = (richcmpfunc)py_ldb_msg_richcmp,
        .tp_doc = "A LDB Message",
 };
 
@@ -3095,7 +3697,7 @@ static int py_module_search(struct ldb_module *mod, struct ldb_request *req)
                for (len = 0; req->op.search.attrs[len]; len++);
                py_attrs = PyList_New(len);
                for (i = 0; i < len; i++)
-                       PyList_SetItem(py_attrs, i, PyString_FromString(req->op.search.attrs[i]));
+                       PyList_SetItem(py_attrs, i, PyStr_FromString(req->op.search.attrs[i]));
        }
 
        py_result = PyObject_CallMethod(py_ldb, discard_const_p(char, "search"),
@@ -3353,7 +3955,7 @@ static PyObject *py_register_module(PyObject *module, PyObject *args)
                return NULL;
        }
 
-       ops->name = talloc_strdup(ops, PyString_AsString(PyObject_GetAttrString(input, discard_const_p(char, "name"))));
+       ops->name = talloc_strdup(ops, PyStr_AsUTF8(PyObject_GetAttrString(input, discard_const_p(char, "name"))));
 
        Py_INCREF(input);
        ops->private_data = input;
@@ -3386,7 +3988,7 @@ static PyObject *py_timestring(PyObject *module, PyObject *args)
        if (!PyArg_ParseTuple(args, "l", &t_val))
                return NULL;
        tresult = ldb_timestring(NULL, (time_t) t_val);
-       ret = PyString_FromString(tresult);
+       ret = PyStr_FromString(tresult);
        talloc_free(tresult);
        return ret;
 }
@@ -3414,7 +4016,7 @@ static PyObject *py_valid_attr_name(PyObject *self, PyObject *args)
 static PyObject *py_binary_encode(PyObject *self, PyObject *args)
 {
        char *str, *encoded;
-       int size = 0;
+       Py_ssize_t size = 0;
        struct ldb_val val;
        PyObject *ret;
 
@@ -3428,7 +4030,7 @@ static PyObject *py_binary_encode(PyObject *self, PyObject *args)
                PyErr_SetString(PyExc_TypeError, "unable to encode binary string");
                return NULL;
        }
-       ret = PyString_FromString(encoded);
+       ret = PyStr_FromString(encoded);
        talloc_free(encoded);
        return ret;
 }
@@ -3450,7 +4052,7 @@ static PyObject *py_binary_decode(PyObject *self, PyObject *args)
                PyErr_SetString(PyExc_TypeError, "unable to decode binary string");
                return NULL;
        }
-       ret = Py_BuildValue("s#", val.data, val.length);
+       ret = PyBytes_FromStringAndSize((const char*)val.data, val.length);
        talloc_free(val.data);
        return ret;
 }
@@ -3480,102 +4082,130 @@ static PyMethodDef py_ldb_global_methods[] = {
        { NULL }
 };
 
-void initldb(void)
+#define MODULE_DOC "An interface to LDB, a LDAP-like API that can either to talk an embedded database (TDB-based) or a standards-compliant LDAP server."
+
+#if PY_MAJOR_VERSION >= 3
+static struct PyModuleDef moduledef = {
+       PyModuleDef_HEAD_INIT,
+       .m_name = "ldb",
+       .m_doc = MODULE_DOC,
+       .m_size = -1,
+       .m_methods = py_ldb_global_methods,
+};
+#endif
+
+static PyObject* module_init(void)
 {
        PyObject *m;
 
        if (PyType_Ready(&PyLdbDn) < 0)
-               return;
+               return NULL;
 
        if (PyType_Ready(&PyLdbMessage) < 0)
-               return;
+               return NULL;
 
        if (PyType_Ready(&PyLdbMessageElement) < 0)
-               return;
+               return NULL;
 
        if (PyType_Ready(&PyLdb) < 0)
-               return;
+               return NULL;
 
        if (PyType_Ready(&PyLdbModule) < 0)
-               return;
+               return NULL;
 
        if (PyType_Ready(&PyLdbTree) < 0)
-               return;
+               return NULL;
 
        if (PyType_Ready(&PyLdbResult) < 0)
-               return;
+               return NULL;
+
+       if (PyType_Ready(&PyLdbSearchIterator) < 0)
+               return NULL;
 
        if (PyType_Ready(&PyLdbControl) < 0)
-               return;
+               return NULL;
 
-       m = Py_InitModule3("ldb", py_ldb_global_methods, 
-               "An interface to LDB, a LDAP-like API that can either to talk an embedded database (TDB-based) or a standards-compliant LDAP server.");
+#if PY_MAJOR_VERSION >= 3
+       m = PyModule_Create(&moduledef);
+#else
+       m = Py_InitModule3("ldb", py_ldb_global_methods, MODULE_DOC);
+#endif
        if (m == NULL)
-               return;
-
-       PyModule_AddObject(m, "SEQ_HIGHEST_SEQ", PyInt_FromLong(LDB_SEQ_HIGHEST_SEQ));
-       PyModule_AddObject(m, "SEQ_HIGHEST_TIMESTAMP", PyInt_FromLong(LDB_SEQ_HIGHEST_TIMESTAMP));
-       PyModule_AddObject(m, "SEQ_NEXT", PyInt_FromLong(LDB_SEQ_NEXT));
-       PyModule_AddObject(m, "SCOPE_DEFAULT", PyInt_FromLong(LDB_SCOPE_DEFAULT));
-       PyModule_AddObject(m, "SCOPE_BASE", PyInt_FromLong(LDB_SCOPE_BASE));
-       PyModule_AddObject(m, "SCOPE_ONELEVEL", PyInt_FromLong(LDB_SCOPE_ONELEVEL));
-       PyModule_AddObject(m, "SCOPE_SUBTREE", PyInt_FromLong(LDB_SCOPE_SUBTREE));
-
-       PyModule_AddObject(m, "CHANGETYPE_NONE", PyInt_FromLong(LDB_CHANGETYPE_NONE));
-       PyModule_AddObject(m, "CHANGETYPE_ADD", PyInt_FromLong(LDB_CHANGETYPE_ADD));
-       PyModule_AddObject(m, "CHANGETYPE_DELETE", PyInt_FromLong(LDB_CHANGETYPE_DELETE));
-       PyModule_AddObject(m, "CHANGETYPE_MODIFY", PyInt_FromLong(LDB_CHANGETYPE_MODIFY));
-
-       PyModule_AddObject(m, "FLAG_MOD_ADD", PyInt_FromLong(LDB_FLAG_MOD_ADD));
-       PyModule_AddObject(m, "FLAG_MOD_REPLACE", PyInt_FromLong(LDB_FLAG_MOD_REPLACE));
-       PyModule_AddObject(m, "FLAG_MOD_DELETE", PyInt_FromLong(LDB_FLAG_MOD_DELETE));
-
-       PyModule_AddObject(m, "SUCCESS", PyInt_FromLong(LDB_SUCCESS));
-       PyModule_AddObject(m, "ERR_OPERATIONS_ERROR", PyInt_FromLong(LDB_ERR_OPERATIONS_ERROR));
-       PyModule_AddObject(m, "ERR_PROTOCOL_ERROR", PyInt_FromLong(LDB_ERR_PROTOCOL_ERROR));
-       PyModule_AddObject(m, "ERR_TIME_LIMIT_EXCEEDED", PyInt_FromLong(LDB_ERR_TIME_LIMIT_EXCEEDED));
-       PyModule_AddObject(m, "ERR_SIZE_LIMIT_EXCEEDED", PyInt_FromLong(LDB_ERR_SIZE_LIMIT_EXCEEDED));
-       PyModule_AddObject(m, "ERR_COMPARE_FALSE", PyInt_FromLong(LDB_ERR_COMPARE_FALSE));
-       PyModule_AddObject(m, "ERR_COMPARE_TRUE", PyInt_FromLong(LDB_ERR_COMPARE_TRUE));
-       PyModule_AddObject(m, "ERR_AUTH_METHOD_NOT_SUPPORTED", PyInt_FromLong(LDB_ERR_AUTH_METHOD_NOT_SUPPORTED));
-       PyModule_AddObject(m, "ERR_STRONG_AUTH_REQUIRED", PyInt_FromLong(LDB_ERR_STRONG_AUTH_REQUIRED));
-       PyModule_AddObject(m, "ERR_REFERRAL", PyInt_FromLong(LDB_ERR_REFERRAL));
-       PyModule_AddObject(m, "ERR_ADMIN_LIMIT_EXCEEDED", PyInt_FromLong(LDB_ERR_ADMIN_LIMIT_EXCEEDED));
-       PyModule_AddObject(m, "ERR_UNSUPPORTED_CRITICAL_EXTENSION", PyInt_FromLong(LDB_ERR_UNSUPPORTED_CRITICAL_EXTENSION));
-       PyModule_AddObject(m, "ERR_CONFIDENTIALITY_REQUIRED", PyInt_FromLong(LDB_ERR_CONFIDENTIALITY_REQUIRED));
-       PyModule_AddObject(m, "ERR_SASL_BIND_IN_PROGRESS", PyInt_FromLong(LDB_ERR_SASL_BIND_IN_PROGRESS));
-       PyModule_AddObject(m, "ERR_NO_SUCH_ATTRIBUTE", PyInt_FromLong(LDB_ERR_NO_SUCH_ATTRIBUTE));
-       PyModule_AddObject(m, "ERR_UNDEFINED_ATTRIBUTE_TYPE", PyInt_FromLong(LDB_ERR_UNDEFINED_ATTRIBUTE_TYPE));
-       PyModule_AddObject(m, "ERR_INAPPROPRIATE_MATCHING", PyInt_FromLong(LDB_ERR_INAPPROPRIATE_MATCHING));
-       PyModule_AddObject(m, "ERR_CONSTRAINT_VIOLATION", PyInt_FromLong(LDB_ERR_CONSTRAINT_VIOLATION));
-       PyModule_AddObject(m, "ERR_ATTRIBUTE_OR_VALUE_EXISTS", PyInt_FromLong(LDB_ERR_ATTRIBUTE_OR_VALUE_EXISTS));
-       PyModule_AddObject(m, "ERR_INVALID_ATTRIBUTE_SYNTAX", PyInt_FromLong(LDB_ERR_INVALID_ATTRIBUTE_SYNTAX));
-       PyModule_AddObject(m, "ERR_NO_SUCH_OBJECT", PyInt_FromLong(LDB_ERR_NO_SUCH_OBJECT));
-       PyModule_AddObject(m, "ERR_ALIAS_PROBLEM", PyInt_FromLong(LDB_ERR_ALIAS_PROBLEM));
-       PyModule_AddObject(m, "ERR_INVALID_DN_SYNTAX", PyInt_FromLong(LDB_ERR_INVALID_DN_SYNTAX));
-       PyModule_AddObject(m, "ERR_ALIAS_DEREFERINCING_PROBLEM", PyInt_FromLong(LDB_ERR_ALIAS_DEREFERENCING_PROBLEM));
-       PyModule_AddObject(m, "ERR_INAPPROPRIATE_AUTHENTICATION", PyInt_FromLong(LDB_ERR_INAPPROPRIATE_AUTHENTICATION));
-       PyModule_AddObject(m, "ERR_INVALID_CREDENTIALS", PyInt_FromLong(LDB_ERR_INVALID_CREDENTIALS));
-       PyModule_AddObject(m, "ERR_INSUFFICIENT_ACCESS_RIGHTS", PyInt_FromLong(LDB_ERR_INSUFFICIENT_ACCESS_RIGHTS));
-       PyModule_AddObject(m, "ERR_BUSY", PyInt_FromLong(LDB_ERR_BUSY));
-       PyModule_AddObject(m, "ERR_UNAVAILABLE", PyInt_FromLong(LDB_ERR_UNAVAILABLE));
-       PyModule_AddObject(m, "ERR_UNWILLING_TO_PERFORM", PyInt_FromLong(LDB_ERR_UNWILLING_TO_PERFORM));
-       PyModule_AddObject(m, "ERR_LOOP_DETECT", PyInt_FromLong(LDB_ERR_LOOP_DETECT));
-       PyModule_AddObject(m, "ERR_NAMING_VIOLATION", PyInt_FromLong(LDB_ERR_NAMING_VIOLATION));
-       PyModule_AddObject(m, "ERR_OBJECT_CLASS_VIOLATION", PyInt_FromLong(LDB_ERR_OBJECT_CLASS_VIOLATION));
-       PyModule_AddObject(m, "ERR_NOT_ALLOWED_ON_NON_LEAF", PyInt_FromLong(LDB_ERR_NOT_ALLOWED_ON_NON_LEAF));
-       PyModule_AddObject(m, "ERR_NOT_ALLOWED_ON_RDN", PyInt_FromLong(LDB_ERR_NOT_ALLOWED_ON_RDN));
-       PyModule_AddObject(m, "ERR_ENTRY_ALREADY_EXISTS", PyInt_FromLong(LDB_ERR_ENTRY_ALREADY_EXISTS));
-       PyModule_AddObject(m, "ERR_OBJECT_CLASS_MODS_PROHIBITED", PyInt_FromLong(LDB_ERR_OBJECT_CLASS_MODS_PROHIBITED));
-       PyModule_AddObject(m, "ERR_AFFECTS_MULTIPLE_DSAS", PyInt_FromLong(LDB_ERR_AFFECTS_MULTIPLE_DSAS));
-       PyModule_AddObject(m, "ERR_OTHER", PyInt_FromLong(LDB_ERR_OTHER));
-
-       PyModule_AddObject(m, "FLG_RDONLY", PyInt_FromLong(LDB_FLG_RDONLY));
-       PyModule_AddObject(m, "FLG_NOSYNC", PyInt_FromLong(LDB_FLG_NOSYNC));
-       PyModule_AddObject(m, "FLG_RECONNECT", PyInt_FromLong(LDB_FLG_RECONNECT));
-       PyModule_AddObject(m, "FLG_NOMMAP", PyInt_FromLong(LDB_FLG_NOMMAP));
-
-       PyModule_AddObject(m, "__docformat__", PyString_FromString("restructuredText"));
+               return NULL;
+
+#define ADD_LDB_INT(val) PyModule_AddIntConstant(m, #val, LDB_ ## val)
+
+       ADD_LDB_INT(SEQ_HIGHEST_SEQ);
+       ADD_LDB_INT(SEQ_HIGHEST_TIMESTAMP);
+       ADD_LDB_INT(SEQ_NEXT);
+       ADD_LDB_INT(SCOPE_DEFAULT);
+       ADD_LDB_INT(SCOPE_BASE);
+       ADD_LDB_INT(SCOPE_ONELEVEL);
+       ADD_LDB_INT(SCOPE_SUBTREE);
+
+       ADD_LDB_INT(CHANGETYPE_NONE);
+       ADD_LDB_INT(CHANGETYPE_ADD);
+       ADD_LDB_INT(CHANGETYPE_DELETE);
+       ADD_LDB_INT(CHANGETYPE_MODIFY);
+
+       ADD_LDB_INT(FLAG_MOD_ADD);
+       ADD_LDB_INT(FLAG_MOD_REPLACE);
+       ADD_LDB_INT(FLAG_MOD_DELETE);
+
+       ADD_LDB_INT(ATTR_FLAG_HIDDEN);
+       ADD_LDB_INT(ATTR_FLAG_UNIQUE_INDEX);
+       ADD_LDB_INT(ATTR_FLAG_SINGLE_VALUE);
+       ADD_LDB_INT(ATTR_FLAG_FORCE_BASE64_LDIF);
+
+       ADD_LDB_INT(SUCCESS);
+       ADD_LDB_INT(ERR_OPERATIONS_ERROR);
+       ADD_LDB_INT(ERR_PROTOCOL_ERROR);
+       ADD_LDB_INT(ERR_TIME_LIMIT_EXCEEDED);
+       ADD_LDB_INT(ERR_SIZE_LIMIT_EXCEEDED);
+       ADD_LDB_INT(ERR_COMPARE_FALSE);
+       ADD_LDB_INT(ERR_COMPARE_TRUE);
+       ADD_LDB_INT(ERR_AUTH_METHOD_NOT_SUPPORTED);
+       ADD_LDB_INT(ERR_STRONG_AUTH_REQUIRED);
+       ADD_LDB_INT(ERR_REFERRAL);
+       ADD_LDB_INT(ERR_ADMIN_LIMIT_EXCEEDED);
+       ADD_LDB_INT(ERR_UNSUPPORTED_CRITICAL_EXTENSION);
+       ADD_LDB_INT(ERR_CONFIDENTIALITY_REQUIRED);
+       ADD_LDB_INT(ERR_SASL_BIND_IN_PROGRESS);
+       ADD_LDB_INT(ERR_NO_SUCH_ATTRIBUTE);
+       ADD_LDB_INT(ERR_UNDEFINED_ATTRIBUTE_TYPE);
+       ADD_LDB_INT(ERR_INAPPROPRIATE_MATCHING);
+       ADD_LDB_INT(ERR_CONSTRAINT_VIOLATION);
+       ADD_LDB_INT(ERR_ATTRIBUTE_OR_VALUE_EXISTS);
+       ADD_LDB_INT(ERR_INVALID_ATTRIBUTE_SYNTAX);
+       ADD_LDB_INT(ERR_NO_SUCH_OBJECT);
+       ADD_LDB_INT(ERR_ALIAS_PROBLEM);
+       ADD_LDB_INT(ERR_INVALID_DN_SYNTAX);
+       ADD_LDB_INT(ERR_ALIAS_DEREFERENCING_PROBLEM);
+       ADD_LDB_INT(ERR_INAPPROPRIATE_AUTHENTICATION);
+       ADD_LDB_INT(ERR_INVALID_CREDENTIALS);
+       ADD_LDB_INT(ERR_INSUFFICIENT_ACCESS_RIGHTS);
+       ADD_LDB_INT(ERR_BUSY);
+       ADD_LDB_INT(ERR_UNAVAILABLE);
+       ADD_LDB_INT(ERR_UNWILLING_TO_PERFORM);
+       ADD_LDB_INT(ERR_LOOP_DETECT);
+       ADD_LDB_INT(ERR_NAMING_VIOLATION);
+       ADD_LDB_INT(ERR_OBJECT_CLASS_VIOLATION);
+       ADD_LDB_INT(ERR_NOT_ALLOWED_ON_NON_LEAF);
+       ADD_LDB_INT(ERR_NOT_ALLOWED_ON_RDN);
+       ADD_LDB_INT(ERR_ENTRY_ALREADY_EXISTS);
+       ADD_LDB_INT(ERR_OBJECT_CLASS_MODS_PROHIBITED);
+       ADD_LDB_INT(ERR_AFFECTS_MULTIPLE_DSAS);
+       ADD_LDB_INT(ERR_OTHER);
+
+       ADD_LDB_INT(FLG_RDONLY);
+       ADD_LDB_INT(FLG_NOSYNC);
+       ADD_LDB_INT(FLG_RECONNECT);
+       ADD_LDB_INT(FLG_NOMMAP);
+
+       /* Historical misspelling */
+       PyModule_AddIntConstant(m, "ERR_ALIAS_DEREFERINCING_PROBLEM", LDB_ERR_ALIAS_DEREFERENCING_PROBLEM);
+
+       PyModule_AddStringConstant(m, "__docformat__", "restructuredText");
 
        PyExc_LdbError = PyErr_NewException(discard_const_p(char, "_ldb.LdbError"), NULL, NULL);
        PyModule_AddObject(m, "LdbError", PyExc_LdbError);
@@ -3597,9 +4227,9 @@ void initldb(void)
        PyModule_AddObject(m, "Tree", (PyObject *)&PyLdbTree);
        PyModule_AddObject(m, "Control", (PyObject *)&PyLdbControl);
 
-       PyModule_AddObject(m, "__version__", PyString_FromString(PACKAGE_VERSION));
+       PyModule_AddStringConstant(m, "__version__", PACKAGE_VERSION);
 
-#define ADD_LDB_STRING(val)  PyModule_AddObject(m, #val, PyString_FromString(LDB_## val))
+#define ADD_LDB_STRING(val)  PyModule_AddStringConstant(m, #val, LDB_## val)
 
        ADD_LDB_STRING(SYNTAX_DN);
        ADD_LDB_STRING(SYNTAX_DIRECTORY_STRING);
@@ -3609,4 +4239,20 @@ void initldb(void)
        ADD_LDB_STRING(SYNTAX_UTC_TIME);
        ADD_LDB_STRING(OID_COMPARATOR_AND);
        ADD_LDB_STRING(OID_COMPARATOR_OR);
+
+       return m;
 }
+
+#if PY_MAJOR_VERSION >= 3
+PyMODINIT_FUNC PyInit_ldb(void);
+PyMODINIT_FUNC PyInit_ldb(void)
+{
+       return module_init();
+}
+#else
+void initldb(void);
+void initldb(void)
+{
+       module_init();
+}
+#endif