smbd: fileserver: Change defaults to work with EA support out of the box.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Tue May 15 12:40:48 CEST 2018 on sn-devel-144

diff --git a/WHATSNEW.txt b/WHATSNEW.txt
index 7bd37927160e7633cf069ce7d0a727185fe52188..574e9b27e68db850159d76736be04ac1ec4a63e2 100644 (file)
--- a/WHATSNEW.txt
+++ b/WHATSNEW.txt
@@ -61,9 +61,16 @@ REMOVED FEATURES
 smb.conf changes
 ================
 
+As the most popular Samba install platforms (Linux and FreeBSD) both
+support extended attributes by default, the parameters "map readonly",
+"store dos attributes" and "ea support" have had their defaults changed
+to allow better Windows fileserver compatibility in a default install.
+
   Parameter Name                     Description             Default
   --------------                     -----------             -------
-
+  map readonly                       Default changed              no
+  store dos attributes               Default changed             yes
+  ea support                         Default changed             yes
 
 KNOWN ISSUES
 ============

diff --git a/docs-xml/smbdotconf/filename/mapreadonly.xml b/docs-xml/smbdotconf/filename/mapreadonly.xml
index 54a5e01ce3994307a94deea1a6bd8ba22b4f5a4f..dae17c25614fdb4f5c059c885b28f6d701263fd2 100644 (file)
--- a/docs-xml/smbdotconf/filename/mapreadonly.xml
+++ b/docs-xml/smbdotconf/filename/mapreadonly.xml
@@ -49,6 +49,13 @@
         attribute.
         </para>
 
+        <para>
+        The default has changed to no in Samba release 4.9.0 and above to allow better Windows
+        fileserver compatibility in a default install. In addition the default setting of
+        <smbconfoption name="store dos attributes"/> has been changed to <constant>Yes</constant>
+        in Samba release 4.9.0 and above.
+        </para>
+
 </description>
-<value type="default">yes</value>
+<value type="default">no</value>
 </samba:parameter>

diff --git a/docs-xml/smbdotconf/filename/storedosattributes.xml b/docs-xml/smbdotconf/filename/storedosattributes.xml
index 30665eb500ced77028174c272f067a2c86ed8292..2cdaeef9c6d2ec445a129078d3c5d50a7fd14f48 100644 (file)
--- a/docs-xml/smbdotconf/filename/storedosattributes.xml
+++ b/docs-xml/smbdotconf/filename/storedosattributes.xml
@@ -21,7 +21,10 @@
        extended attribute by earlier versions of Samba, but they will not be able to read the create
        time stored there. Storing the create time separately from the normal filesystem meta-data
        allows Samba to faithfully reproduce NTFS semantics on top of a POSIX filesystem.
+
+       The default has changed to yes in Samba release 4.9.0 and above to allow better Windows
+       fileserver compatibility in a default install.
        </para>
 </description>
-<value type="default">no</value>
+<value type="default">yes</value>
 </samba:parameter>

diff --git a/docs-xml/smbdotconf/protocol/easupport.xml b/docs-xml/smbdotconf/protocol/easupport.xml
index b453b86d78aeba140128f3cf539c32faa340333b..403e48f5a89720f42b5f3bcbd9bdbca15e429951 100644 (file)
--- a/docs-xml/smbdotconf/protocol/easupport.xml
+++ b/docs-xml/smbdotconf/protocol/easupport.xml
@@ -24,8 +24,11 @@
     access to this tight space via extended attribute support could consume all
     of it by unsuspecting client applications, which would prevent changing
     system metadata due to lack of space.
+
+    The default has changed to yes in Samba release 4.9.0 and above to allow better Windows
+    fileserver compatibility in a default install.
     </para>
 </description>
 
-<value type="default">no</value>
+<value type="default">yes</value>
 </samba:parameter>

diff --git a/lib/param/loadparm.c b/lib/param/loadparm.c
index bcb41419e1c898138be9ab2a85ae150af083d924..3b7f8053e4aeba3f74798a71047e1ed2b4cb77e9 100644 (file)
--- a/lib/param/loadparm.c
+++ b/lib/param/loadparm.c
@@ -2880,7 +2880,7 @@ struct loadparm_context *loadparm_init(TALLOC_CTX *mem_ctx)
 
        lpcfg_do_global_parameter(lp_ctx, "strict sync", "yes");
 
-       lpcfg_do_global_parameter(lp_ctx, "map readonly", "yes");
+       lpcfg_do_global_parameter(lp_ctx, "map readonly", "no");
 
        lpcfg_do_global_parameter(lp_ctx, "allow trusted domains", "yes");
 
@@ -3000,6 +3000,10 @@ struct loadparm_context *loadparm_init(TALLOC_CTX *mem_ctx)
 
        lpcfg_do_global_parameter(lp_ctx, "check parent directory delete on close", "no");
 
+       lpcfg_do_global_parameter(lp_ctx, "ea support", "yes");
+
+       lpcfg_do_global_parameter(lp_ctx, "store dos attributes", "yes");
+
        for (i = 0; parm_table[i].label; i++) {
                if (!(lp_ctx->flags[i] & FLAG_CMDLINE)) {
                        lp_ctx->flags[i] |= FLAG_DEFAULT;

diff --git a/source3/param/loadparm.c b/source3/param/loadparm.c
index 520d0660ccf36845c9b5a7e921863be2e732208f..ecff22eb638f6c7afeed0713c552ea505d309f8f 100644 (file)
--- a/source3/param/loadparm.c
+++ b/source3/param/loadparm.c
@@ -193,7 +193,7 @@ static const struct loadparm_service _sDefault =
        .map_system = false,
        .map_hidden = false,
        .map_archive = true,
-       .store_dos_attributes = false,
+       .store_dos_attributes = true,
        .dmapi_support = false,
        .locking = true,
        .strict_locking = Auto,
@@ -231,7 +231,7 @@ static const struct loadparm_service _sDefault =
        ._use_sendfile = false,
        .map_acl_inherit = false,
        .afs_share = false,
-       .ea_support = false,
+       .ea_support = true,
        .acl_check_permissions = true,
        .acl_map_full_control = true,
        .acl_group_control = false,
@@ -239,7 +239,7 @@ static const struct loadparm_service _sDefault =
        .allocation_roundup_size = SMB_ROUNDUP_ALLOCATION_SIZE,
        .aio_read_size = 1,
        .aio_write_size = 1,
-       .map_readonly = MAP_READONLY_YES,
+       .map_readonly = MAP_READONLY_NO,
        .directory_name_cache_size = 100,
        .smb_encrypt = SMB_SIGNING_DEFAULT,
        .kernel_share_modes = true,